Re: [Wesnoth-dev] new library dependencies on master, 1.12
Update: The boost random branch has now been merged to master. The boost random library is now a build requirement for master. All of the issues mentioned in the original post have now been handled, with the exception perhaps of upping min boost requirement to 1.49 in cmake / scons. Best Regards, Chris Beck On Sun, Oct 26, 2014 at 7:53 PM, chris beck wrote: > P.S. > > Also, I think it wasn't clear from my email, but the final solution > required us to use the "boost locale" library (backing up > gettext_boost.cpp). This is a separate boost library, separate from the > others we previously required. Again, this one is not required if you don't > enable the boost filesystem build option. > > On Sun, Oct 26, 2014 at 5:52 PM, chris beck wrote: > >> Update: >> >> The new filesystem code has been merged into 1.12 branch. We believe that >> all issues have been fixed. >> >> The default is to use the new code. To compile with the old code instead, >> there is now an "enable boost filesystem" option for both cmake and scons. >> For cmake, the "enable pandora" option overrides it and sets it to false, >> and additionally keeps the SDL mixer version at 1.2.0. (The code that >> required SDL mixer 1.2.12 is now guarded with #ifdef PANDORA.) >> >> The BFS option causes wesnoth to compile with filesystem_boost.cpp and >> gettext_boost.cpp, in place of filesystem.cpp and gettext.cpp. >> >> We have complied and tested with gcc, clang, and mingw, and I tested that >> cmake with gcc can compile with the pandora option enabled when pointed at >> an SDL mixer 1.2.0 header. >> >> Packagers, if you could, please test that your build system is still >> working after the changes. >> >> Best Regards, >> Chris Beck >> >> On Sun, Oct 19, 2014 at 10:16 AM, chris beck wrote: >> >>> > Please make sure to always list all new requirements / changes in >>> dependencies >>> > in the RELEASE_NOTES since I try to check this file to changes >>> relevant to the >>> > packagers when notifying them of a new release. >>> >>> Ah okay, I don't think I ever knew about this practice... I don't think >>> the dependencies have been increased for as long as I have been a developer >>> :p . >>> >>> I saw that there's some remarks at the top of the RELEASE_NOTES file >>> about this, but I have now added some remarks to the wiki also. >>> >>> http://wiki.wesnoth.org/DeveloperGuide#Dependencies >>> >>> Best Regards, >>> Chris Beck >>> >>> On Sun, Oct 19, 2014 at 3:20 AM, Nils Kneuper >>> wrote: >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 19.10.2014 um 06:57 schrieb chris beck: > Hi dev-talk, > > Just a follow-up: > > We have now (as of yesterday) fully merged the new filesystem code to > master. > > > > SDL_mixer 1.2.12 is now required. Boost filesystem 1.44 is now required. > (However, for now if you pass scons an option you may elect to use the old > filesystem code instead.) On windows, boost filesystem 1.48 is further > required, because you also need boost::locale it turns out for it to > actually work. Please make sure to always list all new requirements / changes in dependencies in the RELEASE_NOTES since I try to check this file to changes relevant to the packagers when notifying them of a new release. Cheers, Nils Kneuper PS: This is especially important for the 1.12 branch since we are about to go stable... -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEUEARECAAYFAlRDZjoACgkQfFda9thizwVJvQCaAo1MbuvjQm6OVNORL3oB3os4 JcIAlA28DRSR6gt+PlJPBp6tMvj/Pao= =2B8b -END PGP SIGNATURE- ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev >>> >>> >> > ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] new library dependencies on master, 1.12
P.S. Also, I think it wasn't clear from my email, but the final solution required us to use the "boost locale" library (backing up gettext_boost.cpp). This is a separate boost library, separate from the others we previously required. Again, this one is not required if you don't enable the boost filesystem build option. On Sun, Oct 26, 2014 at 5:52 PM, chris beck wrote: > Update: > > The new filesystem code has been merged into 1.12 branch. We believe that > all issues have been fixed. > > The default is to use the new code. To compile with the old code instead, > there is now an "enable boost filesystem" option for both cmake and scons. > For cmake, the "enable pandora" option overrides it and sets it to false, > and additionally keeps the SDL mixer version at 1.2.0. (The code that > required SDL mixer 1.2.12 is now guarded with #ifdef PANDORA.) > > The BFS option causes wesnoth to compile with filesystem_boost.cpp and > gettext_boost.cpp, in place of filesystem.cpp and gettext.cpp. > > We have complied and tested with gcc, clang, and mingw, and I tested that > cmake with gcc can compile with the pandora option enabled when pointed at > an SDL mixer 1.2.0 header. > > Packagers, if you could, please test that your build system is still > working after the changes. > > Best Regards, > Chris Beck > > On Sun, Oct 19, 2014 at 10:16 AM, chris beck wrote: > >> > Please make sure to always list all new requirements / changes in >> dependencies >> > in the RELEASE_NOTES since I try to check this file to changes relevant >> to the >> > packagers when notifying them of a new release. >> >> Ah okay, I don't think I ever knew about this practice... I don't think >> the dependencies have been increased for as long as I have been a developer >> :p . >> >> I saw that there's some remarks at the top of the RELEASE_NOTES file >> about this, but I have now added some remarks to the wiki also. >> >> http://wiki.wesnoth.org/DeveloperGuide#Dependencies >> >> Best Regards, >> Chris Beck >> >> On Sun, Oct 19, 2014 at 3:20 AM, Nils Kneuper >> wrote: >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> Am 19.10.2014 um 06:57 schrieb chris beck: >>> > Hi dev-talk, >>> > >>> > Just a follow-up: >>> > >>> > We have now (as of yesterday) fully merged the new filesystem code to >>> > master. >>> > >>> > >>> > >>> > SDL_mixer 1.2.12 is now required. Boost filesystem 1.44 is now >>> required. >>> > (However, for now if you pass scons an option you may elect to use the >>> old >>> > filesystem code instead.) On windows, boost filesystem 1.48 is further >>> > required, because you also need boost::locale it turns out for it to >>> > actually work. >>> >>> Please make sure to always list all new requirements / changes in >>> dependencies >>> in the RELEASE_NOTES since I try to check this file to changes relevant >>> to the >>> packagers when notifying them of a new release. >>> >>> Cheers, >>> Nils Kneuper >>> >>> PS: This is especially important for the 1.12 branch since we are about >>> to go >>> stable... >>> >>> -BEGIN PGP SIGNATURE- >>> Version: GnuPG v2 >>> >>> iEUEARECAAYFAlRDZjoACgkQfFda9thizwVJvQCaAo1MbuvjQm6OVNORL3oB3os4 >>> JcIAlA28DRSR6gt+PlJPBp6tMvj/Pao= >>> =2B8b >>> -END PGP SIGNATURE- >>> >>> ___ >>> Wesnoth-dev mailing list >>> Wesnoth-dev@gna.org >>> https://mail.gna.org/listinfo/wesnoth-dev >>> >> >> > ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] new library dependencies on master, 1.12
Update: The new filesystem code has been merged into 1.12 branch. We believe that all issues have been fixed. The default is to use the new code. To compile with the old code instead, there is now an "enable boost filesystem" option for both cmake and scons. For cmake, the "enable pandora" option overrides it and sets it to false, and additionally keeps the SDL mixer version at 1.2.0. (The code that required SDL mixer 1.2.12 is now guarded with #ifdef PANDORA.) The BFS option causes wesnoth to compile with filesystem_boost.cpp and gettext_boost.cpp, in place of filesystem.cpp and gettext.cpp. We have complied and tested with gcc, clang, and mingw, and I tested that cmake with gcc can compile with the pandora option enabled when pointed at an SDL mixer 1.2.0 header. Packagers, if you could, please test that your build system is still working after the changes. Best Regards, Chris Beck On Sun, Oct 19, 2014 at 10:16 AM, chris beck wrote: > > Please make sure to always list all new requirements / changes in > dependencies > > in the RELEASE_NOTES since I try to check this file to changes relevant > to the > > packagers when notifying them of a new release. > > Ah okay, I don't think I ever knew about this practice... I don't think > the dependencies have been increased for as long as I have been a developer > :p . > > I saw that there's some remarks at the top of the RELEASE_NOTES file about > this, but I have now added some remarks to the wiki also. > > http://wiki.wesnoth.org/DeveloperGuide#Dependencies > > Best Regards, > Chris Beck > > On Sun, Oct 19, 2014 at 3:20 AM, Nils Kneuper > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Am 19.10.2014 um 06:57 schrieb chris beck: >> > Hi dev-talk, >> > >> > Just a follow-up: >> > >> > We have now (as of yesterday) fully merged the new filesystem code to >> > master. >> > >> > >> > >> > SDL_mixer 1.2.12 is now required. Boost filesystem 1.44 is now required. >> > (However, for now if you pass scons an option you may elect to use the >> old >> > filesystem code instead.) On windows, boost filesystem 1.48 is further >> > required, because you also need boost::locale it turns out for it to >> > actually work. >> >> Please make sure to always list all new requirements / changes in >> dependencies >> in the RELEASE_NOTES since I try to check this file to changes relevant >> to the >> packagers when notifying them of a new release. >> >> Cheers, >> Nils Kneuper >> >> PS: This is especially important for the 1.12 branch since we are about >> to go >> stable... >> >> -BEGIN PGP SIGNATURE- >> Version: GnuPG v2 >> >> iEUEARECAAYFAlRDZjoACgkQfFda9thizwVJvQCaAo1MbuvjQm6OVNORL3oB3os4 >> JcIAlA28DRSR6gt+PlJPBp6tMvj/Pao= >> =2B8b >> -END PGP SIGNATURE- >> >> ___ >> Wesnoth-dev mailing list >> Wesnoth-dev@gna.org >> https://mail.gna.org/listinfo/wesnoth-dev >> > > ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] new library dependencies on master, 1.12
> Please make sure to always list all new requirements / changes in dependencies > in the RELEASE_NOTES since I try to check this file to changes relevant to the > packagers when notifying them of a new release. Ah okay, I don't think I ever knew about this practice... I don't think the dependencies have been increased for as long as I have been a developer :p . I saw that there's some remarks at the top of the RELEASE_NOTES file about this, but I have now added some remarks to the wiki also. http://wiki.wesnoth.org/DeveloperGuide#Dependencies Best Regards, Chris Beck On Sun, Oct 19, 2014 at 3:20 AM, Nils Kneuper wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 19.10.2014 um 06:57 schrieb chris beck: > > Hi dev-talk, > > > > Just a follow-up: > > > > We have now (as of yesterday) fully merged the new filesystem code to > > master. > > > > > > > > SDL_mixer 1.2.12 is now required. Boost filesystem 1.44 is now required. > > (However, for now if you pass scons an option you may elect to use the > old > > filesystem code instead.) On windows, boost filesystem 1.48 is further > > required, because you also need boost::locale it turns out for it to > > actually work. > > Please make sure to always list all new requirements / changes in > dependencies > in the RELEASE_NOTES since I try to check this file to changes relevant to > the > packagers when notifying them of a new release. > > Cheers, > Nils Kneuper > > PS: This is especially important for the 1.12 branch since we are about to > go > stable... > > -BEGIN PGP SIGNATURE- > Version: GnuPG v2 > > iEUEARECAAYFAlRDZjoACgkQfFda9thizwVJvQCaAo1MbuvjQm6OVNORL3oB3os4 > JcIAlA28DRSR6gt+PlJPBp6tMvj/Pao= > =2B8b > -END PGP SIGNATURE- > > ___ > Wesnoth-dev mailing list > Wesnoth-dev@gna.org > https://mail.gna.org/listinfo/wesnoth-dev > ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] new library dependencies on master, 1.12
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 19.10.2014 um 06:57 schrieb chris beck: > Hi dev-talk, > > Just a follow-up: > > We have now (as of yesterday) fully merged the new filesystem code to > master. > > > > SDL_mixer 1.2.12 is now required. Boost filesystem 1.44 is now required. > (However, for now if you pass scons an option you may elect to use the old > filesystem code instead.) On windows, boost filesystem 1.48 is further > required, because you also need boost::locale it turns out for it to > actually work. Please make sure to always list all new requirements / changes in dependencies in the RELEASE_NOTES since I try to check this file to changes relevant to the packagers when notifying them of a new release. Cheers, Nils Kneuper PS: This is especially important for the 1.12 branch since we are about to go stable... -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEUEARECAAYFAlRDZjoACgkQfFda9thizwVJvQCaAo1MbuvjQm6OVNORL3oB3os4 JcIAlA28DRSR6gt+PlJPBp6tMvj/Pao= =2B8b -END PGP SIGNATURE- ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] new library dependencies on master, 1.12
Hi dev-talk, Just a follow-up: We have now (as of yesterday) fully merged the new filesystem code to master. SDL_mixer 1.2.12 is now required. Boost filesystem 1.44 is now required. (However, for now if you pass scons an option you may elect to use the old filesystem code instead.) On windows, boost filesystem 1.48 is further required, because you also need boost::locale it turns out for it to actually work. We also fixed a variety of minor bugs that cropped up along the way, and as far as I know there are no issues with it remaining. Please, if you have time to build current master and test it briefly on your machine, it would be very helpful to us. We'd really like to catch any possible platform-specific bugs asap. Best regards, Chris Beck On Tue, Oct 14, 2014 at 3:58 PM, chris beck wrote: > Hi dev-talk, > > If you have been following the 1.12 critical bugs emails, then you may > have read something about the filesystem issues on windows that we are > trying to fix using a branch developed over a long period by AI0867. > > This branch had many conflicts with current master -- gfgtdf has just now > merged a version of the first part of this to master, that doesn't change > any behavior but fixes the vast majority of the conflicts, which were do > due to code reorganization. > > That part didn't require any library changes. The subsequent parts will. > > I propose the following plan of action: > > - Merge the rest of AI's branch as soon as we can > - Merge the SDL_rwops patch, which we also need to fix the problems. > - Test this on master for 1 week. Get anyone we can to test it, including > for instance this guy: http://forums.wesnoth.org/viewtopic.php?f=4&t=41018 > > IF things go smoothly on master and there don't seem to be any problems we > can't fix, then try to backport to 1.12. It won't be a straight-up > cherry-pick I don't think but hopefully we can use a similar strategy and > get similar results. We would then have another week to troubleshoot 1.12. > > > > If this doesn't work out then I think we should expect to delay release > until we can figure out what to do about this. > > > > Merging these things into master will require the following dependencies: > > Boost Filesystem Version 1.44 > SDL mixer version 1.2.12 > > We have negotiated to split off a 1.12_pandora branch which will not add > these dependencies (or similar technique), so as not to impede the pandora > release. > > *** If you are opposed to either of these changes with regards to master > branch, you need to speak up now, we really need to resolve this discussion > in the next 24-48 hours. *** > > > > Obviously, the plan is to then do the same thing on the main 1.12 branch. > If you have opposition to these changes with regards to 1.12 branch, > there's more time to discuss but please write back right away. > > > > While we are at it, I would like to propose that, on master, we > - Increase all boost dependencies to 1.44 > - Add boost random as a dependency. > > This will ensure that we get a bunch of bugfixes from upstream, simplify > our dependency regime, and allow us to merge the "boost rng" branch from > april. > > > > That's effectively 3 separate issues: > Filesystem 1.44 and SDL mixer 1.2.12 on master (SOON) > Filesystem 1.44 and SDL mixer 1.2.12 on 1.12 (Maybe 1 week from now) > All boost 1.44, and boost random on master (Later) > > > > Let's try to discuss them in 1 thread, but if it generates too much > traffic then let's split them into different threads. > > > > shadowm adds to this: > 20141014 19:35:23< shadowm> iceiceie: For reference, Debian stable has > Boost 1.49, and oldstable has 1.42. > 20141014 19:35:48< shadowm> Debian stable has a good SDL_mixer version > too, and olstable has 1.2.11. > 20141014 19:36:05< shadowm> Sorry, oldstable has 1.2.8, not 1.2.11. > > So maybe we should actually go to boost 1.49, so we keep up with Debian > Stable? > > > > Best regards, > Chris Beck > ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
