Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
Since is the best we can do for now functionality-wise, I'm gonna merge @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
Review: Approve code lgtm. -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
I left the capability for \n it downwards compatibility really. This part of the code will be reworked anyway when we do the full switch to the new font renderer. I am not planning to do that switch for Build 19 though, because there are still to many issues with layouting images. If we want a normal header layout for the hint, I will have to create an ugly hack for it, because otherwise the whole thing will automatically switch to the old font renderer. SO, this is an interim fix that we will have to live with for Build 19. I agree that not having paragraphs in the middle of map description forces discpline innot making the text too long. If I make the map list smaller, the title for "The Pass Through the Mountains" won't fit in English at 800x600 resolution, never mind translations that can be even longer. -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
Is there really a need for a paragraph in map description? The place to show the description is not really big, adding a possibility for a paragraph consumes just more space. Is a normal line break also needed? I knew king_of_nowhere has asked for this, but i think the description is meant to have a short description of the map, not long texts. To the HINT-label: I think it does not fit in two points to the general layout: 1. Text is indented to the headers and this does not happens to the text regarding the header HINT 2. The header HINT is full capitalized > I just noted that we can't add \n to the descriptions in the map elemental > packets, but that is a different problem (file reading/saving). If there is a consensus to have linebreaks and paragraphs, i would suggest to fix this all together. Adding \n to the description in this branch causes a crash, while in current trunk it is possible to add more than 1 \n\n without problems because the backslashes get truncated. Could we get the maplist for "new game" smaller i width? If so we have more space for text on the right :-) -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
I have added a comment to the source code. I just noted that we can't add \n to the descriptions in the map elemental packets, but that is a different problem (file reading/saving). -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
Okay. Thanks for explaining. > Am 09.02.2016 um 09:00 schrieb GunChleoc : > > If I have only 1 \n = , the renderer will only create a newline, but not > the space for a paragraph. We don't want spaces for paragraphs here, because > that would break the semantics. So, we would need to change the parser to do > some very special treatment for two tags in a row, which also feels > hacky. > > I decided not to allow \n\n\n or \n\n\n\n on purpose - in the same way that > we eat multiple blank spaces when we're not in text editing mode. > > -- > https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 > You are reviewing the proposed merge of > lp:~widelands-dev/widelands/map_hint_space into lp:widelands. -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
If I have only 1 \n = , the renderer will only create a newline, but not the space for a paragraph. We don't want spaces for paragraphs here, because that would break the semantics. So, we would need to change the parser to do some very special treatment for two tags in a row, which also feels hacky. I decided not to allow \n\n\n or \n\n\n\n on purpose - in the same way that we eat multiple blank spaces when we're not in text editing mode. -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands
Review: Needs Fixing This feels rather hacky.. what about \n\n\n or \n\n\n\n? Should this not be fixed in the richtext renderer? I suggest adding at least a TODO for now. -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
