[Wikidata-bugs] [Maniphest] [Updated] T210692: WDQS should not add (...) to VALUES

2018-11-28 Thread Smalyshev
Smalyshev edited projects, added Wikidata Query UI; removed Wikidata-Query-Service.
TASK DETAILhttps://phabricator.wikimedia.org/T210692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Yurik, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T210286: Migrate wikidata-query-gui-build and wikimedia-portals-build to Docker containers

2018-11-28 Thread greg
greg triaged this task as "Normal" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T210286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: Addshore, hashar, Aklapper, Nandana, Mihailo, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, Jdrewniak, D3r1ck01, Jonas, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, Base, aude, Tobias1984, Manybubbles, Lydia_Pintscher, TheDJ, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T184933: Use or to view coordinates on Wikidata

2018-11-28 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).
TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tpt, ReleaseTaggerBotCc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Ainali, MSantos, matej_suchanek, WMDE-leszek, Tpt, Jonas, gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, dachary, LawExplorer, Lewizho99, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Ricordisamoa, Yurik, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).
TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, ReleaseTaggerBotCc: Stashbot, gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T184933: Use or to view coordinates on Wikidata

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476143 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandler: Fix comment about Kartographer modules

https://gerrit.wikimedia.org/r/476143TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tpt, gerritbotCc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Ainali, MSantos, matej_suchanek, WMDE-leszek, Tpt, Jonas, gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, dachary, LawExplorer, Lewizho99, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Ricordisamoa, Yurik, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210692: WDQS should not add (...) to VALUES

2018-11-28 Thread Yurik
Yurik created this task.Yurik added a project: Wikidata-Query-Service.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONIn WDQS, pressing the diamond autoformats this:

SELECT * WHERE {
  VALUES ?a { wd:Q1 wd:Q2 }
}

into this:

SELECT * WHERE {
  VALUES (?a) {
(wd:Q1)
(wd:Q2)
  }
}

I think the extra parentesis produce more harm than good. Most of the time, VALUES is a relatively short single-value list, not a list of lists, so making it one item per line creates unnecessary hindrance to understanding and maintaining the query code. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T210692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: YurikCc: Aklapper, Yurik, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread hoo
hoo closed this task as "Resolved".hoo removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Stashbot, gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476292 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476292TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Stashbot, gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread matmarex
matmarex added a comment.
Also occurred on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/476339TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matmarexCc: matmarex, Bawolff, Anomie, Aklapper, Lucas_Werkmeister_WMDE, Nandana, A.S.Kochergin, God, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, hashar___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209402: A/B testing plan for wbsearchentities, context=item

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476433 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikimediaEvents@master] wbsearchentities ab test improvements

https://gerrit.wikimedia.org/r/476433TASK DETAILhttps://phabricator.wikimedia.org/T209402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, gerritbotCc: Ladsgroup, Lucas_Werkmeister_WMDE, Stashbot, gerritbot, Aklapper, TJones, dcausse, Smalyshev, EBernhardson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T210679: Make WDQS auto-completion keyboard shortcut configurable

2018-11-28 Thread Smalyshev
Smalyshev updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThe CTRL-SPACE shortcut in #wikidata-query-serviceui seems to be hardcoded [1] and it's a key combination that's not particularly friendly to Mac OS or Chromebook users. Please consider making it configurable, I'd love to be able to use query auto-completion without having to change my other OS-level keyboard shortcutsTASK DETAILhttps://phabricator.wikimedia.org/T210679EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Tarrow, Addshore, DarTar, Aklapper, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210679: Make WDQS auto-completion keyboard shortcut configurable

2018-11-28 Thread Smalyshev
Smalyshev edited projects, added Wikidata Query UI; removed Wikidata-Query-Service.
TASK DETAILhttps://phabricator.wikimedia.org/T210679EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Tarrow, Addshore, DarTar, Aklapper, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210679: Make WDQS auto-completion keyboard shortcut configurable

2018-11-28 Thread bd808
bd808 added a project: Wikidata-Query-Service.Restricted Application added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T210679EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: bd808Cc: Tarrow, Addshore, DarTar, Aklapper, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread Anomie
Anomie added a comment.
Or you could have someone else try it again.TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Bawolff, Anomie, Aklapper, Lucas_Werkmeister_WMDE, Nandana, A.S.Kochergin, God, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, hashar___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T204748: Create Federated Wikibase instance on Beta Commons

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476403 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseMediaInfo@master] Don't check for integer namespace in MediaInfoIdLookup

https://gerrit.wikimedia.org/r/476403TASK DETAILhttps://phabricator.wikimedia.org/T204748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, Abit, ArielGlenn, gerritbot, Jdforrester-WMF, Ladsgroup, Cparle, MarkTraceur, Lydia_Pintscher, Ramsey-WMF, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T204748: Create Federated Wikibase instance on Beta Commons

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476391 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "labs: Add mediainfo to federation config"

https://gerrit.wikimedia.org/r/476391TASK DETAILhttps://phabricator.wikimedia.org/T204748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, Abit, ArielGlenn, gerritbot, Jdforrester-WMF, Ladsgroup, Cparle, MarkTraceur, Lydia_Pintscher, Ramsey-WMF, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reopened] T204748: Create Federated Wikibase instance on Beta Commons

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF reopened this task as "Open".Jdforrester-WMF added a comment.
Unfortunately this triggered some Wikibase code that wasn't previously running, which broke all of WBMI. :-(

[W-8D66wQBHcAAAJ5GoUB] /wiki/File:Redsq.png Wikimedia\Assert\ParameterTypeException from line 89 of /srv/mediawiki/php-master/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $mediaInfoNamespace: must be a integer

Backtrace:

#0 /srv/mediawiki/php-master/extensions/WikibaseMediaInfo/src/Services/MediaInfoIdLookup.php(28): Wikimedia\Assert\Assert::parameterType(string, NULL, string)
#1 /srv/mediawiki/php-master/extensions/WikibaseMediaInfo/src/Services/MediaInfoServices.php(23): Wikibase\MediaInfo\Services\MediaInfoIdLookup->__construct(NULL)
#2 /srv/mediawiki/php-master/extensions/WikibaseMediaInfo/WikibaseMediaInfo.entitytypes.php(129): Wikibase\MediaInfo\Services\MediaInfoServices::getMediaInfoIdLookup()
#3 [internal function]: Closure$#6()
#4 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Content/EntityContentFactory.php(217): call_user_func(Closure$#6;1820)
#5 /srv/mediawiki/php-master/extensions/Wikibase/repo/RepoHooks.php(136): Wikibase\Repo\Content\EntityContentFactory->getContentHandlerForType(string)
#6 /srv/mediawiki/php-master/includes/content/ContentHandler.php(320): Closure$Wikibase\RepoHooks::onSetupAfterCache(string)
#7 /srv/mediawiki/php-master/includes/Revision/RevisionStore.php(1464): ContentHandler::getForModelID(string)
#8 /srv/mediawiki/php-master/includes/Revision/RevisionStore.php(1628): MediaWiki\Revision\RevisionStore->loadSlotContent(MediaWiki\Revision\SlotRecord, NULL, NULL, NULL, integer)
#9 [internal function]: Closure$MediaWiki\Revision\RevisionStore::loadSlotRecords(MediaWiki\Revision\SlotRecord)
#10 /srv/mediawiki/php-master/includes/Revision/SlotRecord.php(309): call_user_func(Closure$MediaWiki\Revision\RevisionStore::loadSlotRecords;471, MediaWiki\Revision\SlotRecord)
#11 /srv/mediawiki/php-master/includes/Revision/RevisionRecord.php(175): MediaWiki\Revision\SlotRecord->getContent()
#12 /srv/mediawiki/php-master/includes/Revision/RenderedRevision.php(226): MediaWiki\Revision\RevisionRecord->getContent(string, integer, NULL)
#13 /srv/mediawiki/php-master/includes/Revision/RevisionRenderer.php(201): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#14 /srv/mediawiki/php-master/includes/Revision/RevisionRenderer.php(133): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#15 [internal function]: Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2(MediaWiki\Revision\RenderedRevision, array)
#16 /srv/mediawiki/php-master/includes/Revision/RenderedRevision.php(197): call_user_func(Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2;492, MediaWiki\Revision\RenderedRevision, array)
#17 /srv/mediawiki/php-master/includes/poolcounter/PoolWorkArticleView.php(194): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#18 /srv/mediawiki/php-master/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#19 /srv/mediawiki/php-master/includes/page/Article.php(774): PoolCounterWork->execute()
#20 /srv/mediawiki/php-master/includes/page/ImagePage.php(147): Article->view()
#21 /srv/mediawiki/php-master/includes/actions/ViewAction.php(68): ImagePage->view()
…

I'm reverting 474993 to start with, to see if that fixes it.TASK DETAILhttps://phabricator.wikimedia.org/T204748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Jdforrester-WMFCc: Stashbot, Abit, ArielGlenn, gerritbot, Jdforrester-WMF, Ladsgroup, Cparle, MarkTraceur, Lydia_Pintscher, Ramsey-WMF, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T204748: Create Federated Wikibase instance on Beta Commons

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Revert "labs: Add mediainfo to federation config"

https://gerrit.wikimedia.org/r/476391TASK DETAILhttps://phabricator.wikimedia.org/T204748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, Abit, ArielGlenn, gerritbot, Jdforrester-WMF, Ladsgroup, Cparle, MarkTraceur, Lydia_Pintscher, Ramsey-WMF, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T204748: Create Federated Wikibase instance on Beta Commons

2018-11-28 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T204748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, Abit, ArielGlenn, gerritbot, Jdforrester-WMF, Ladsgroup, Cparle, MarkTraceur, Lydia_Pintscher, Ramsey-WMF, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T210664: List of most used Wikidata entities

2018-11-28 Thread GoranSMilovanovic
GoranSMilovanovic added subscribers: Lydia_Pintscher, GoranSMilovanovic.GoranSMilovanovic added a comment.
@Lydia_Pintscher Should we pick up this one? Please let me know.TASK DETAILhttps://phabricator.wikimedia.org/T210664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GoranSMilovanovicCc: GoranSMilovanovic, Lydia_Pintscher, abian, Aklapper, Nandana, Lahi, Gq86, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread Bawolff
Bawolff added a comment.
The gci task is already accepted - we cant force the student to do more work (we can of course ask nicely)


In T210634#4782783, @Anomie wrote:
Apparently the test added for T209232: Add a unit test to Scribunto testing it is not vulnerable to CVE-2014-5461 is sometimes running out of allowed memory (set by ulimit most likely) before it runs out of Lua stack space (a constant set in Lua's C code), so it's giving a different error from the one that was expected.

If nothing else we could revert rELUA7a7f5226765e: Adding a unit test for CVE-2014-5461 in Scribunto. and let them try again on that task.


TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: Bawolff, Anomie, Aklapper, Lucas_Werkmeister_WMDE, Nandana, A.S.Kochergin, God, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, hashar___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T210664: List of most used Wikidata entities

2018-11-28 Thread abian
abian updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* I would expect to get a list of entities ordered by the number of Wikipmedia pages on which these entities are used (first the most used one) with at least the following information about each of them:...TASK DETAILhttps://phabricator.wikimedia.org/T210664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: abian, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T76230: [Epic] data quality and trust

2018-11-28 Thread abian
abian added a subtask: T210664: List of most used Wikidata entities.
TASK DETAILhttps://phabricator.wikimedia.org/T76230EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: AfroThundr3007730, Agabi10, Capankajsmilyo, Herzi.Pinki, SandraF_WMF, Tbayer, abian, Aklapper, Ricordisamoa, Elitre, Liuxinyu970226, Lydia_Pintscher, Nickleh, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210664: List of most used Wikidata entities

2018-11-28 Thread abian
abian added a parent task: T76230: [Epic] data quality and trust.
TASK DETAILhttps://phabricator.wikimedia.org/T210664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: abian, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T210664: List of most used Wikidata entities

2018-11-28 Thread abian
abian updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs a Wikidata editor I want to regularly check which Wikidata entities are the most used on the Wikimedia projects (as the number of Wikimedia pages containing data from them, something similar to [[https://www.wikidata.org/wiki/Special:MostTranscludedPages|Special:MostTranscludedPages]]) in order to be aware of Wikidata's weaknesses, know how much damage a vandal can cause when modifying these entities and make decisions about them (watching, protecting, etc.)TASK DETAILhttps://phabricator.wikimedia.org/T210664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: abian, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210664: List of most used Wikidata entities

2018-11-28 Thread abian
abian created this task.abian added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONAs a Wikidata editor I want to check which Wikidata entities are the most used on the Wikimedia projects (as the number of Wikimedia pages containing data from them, something similar to Special:MostTranscludedPages) in order to be aware of Wikidata's weaknesses, know how much damage a vandal can cause when modifying these entities and make decisions about them (watching, protecting, etc.).

Problem: Vandalism on a single Item can cause thousands of pages in several projects to appear vandalized.

Example:

Screenshots/mockups:

BDD
GIVEN 
AND 
WHEN
AND
THEN
AND

Acceptance criteria:


I would expect to get a list of entities ordered by the number of Wikipedia pages on which these entities are used (first the most used one) with at least the following information about each of them:
identifier (QX, LY, etc.),
label in my language,
current protection status, and
number of uses (Wikimedia pages).

The list should be as long as technically reasonable.


Open questions:


Perhaps only confirmed users should be able to access the list?
TASK DETAILhttps://phabricator.wikimedia.org/T210664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: abian, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T208828: Link with other language from mobile view

2018-11-28 Thread ovasileva
ovasileva added a project: Advanced Mobile Contributions.
TASK DETAILhttps://phabricator.wikimedia.org/T208828EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ovasilevaCc: Nikerabbit, Jdlrobson, Capankajsmilyo, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T183126: Link to wikidata item in mobile view

2018-11-28 Thread ovasileva
ovasileva added a project: Advanced Mobile Contributions.
TASK DETAILhttps://phabricator.wikimedia.org/T183126EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ovasilevaCc: Ayack, ovasileva, Aklapper, Beta16, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, Winter, _jensen, Jdrewniak, D3r1ck01, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210044: Data corruption when loading RDF data into WDQS

2018-11-28 Thread Smalyshev
Smalyshev added a comment.
@Lea_Lacroix_WMDE yes, this is possible.TASK DETAILhttps://phabricator.wikimedia.org/T210044EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lea_Lacroix_WMDE, MisterSynergy, ValterVB, gerritbot, Graemebp, Gstupp, Tarrow, Jane023, EBjune, Floatingpurr, mhl20, Wikidata-Query-Service, Oravrattas, Lucas_Werkmeister_WMDE, Stashbot, Alexsdutton, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread Anomie
Anomie added a comment.
Apparently the test added for T209232: Add a unit test to Scribunto testing it is not vulnerable to CVE-2014-5461 is sometimes running out of allowed memory (set by ulimit most likely) before it runs out of Lua stack space (a constant set in Lua's C code), so it's giving a different error from the one that was expected.

If nothing else we could revert rELUA7a7f5226765e: Adding a unit test for CVE-2014-5461 in Scribunto. and let them try again on that task.TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Aklapper, Lucas_Werkmeister_WMDE, Nandana, A.S.Kochergin, God, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, hashar___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T210235: wdqs-updater crashing when update size is too large

2018-11-28 Thread Smalyshev
Smalyshev renamed this task from "wdqs-updater crashing on all wdqs servers" to "wdqs-updater crashing when update size is too large".Smalyshev edited projects, added Wikidata-Query-Service, User-Smalyshev; removed Patch-For-Review, Operations.Restricted Application added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T210235EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, gerritbot, Stashbot, Gehel, Aklapper, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331, Legado_Shulgin, CucyNoiD, NebulousIris, thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, Lewizho99, Zppix, Maathavan, Wong128hk, faidon, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210495: Number of Senses is decreasing on ListeriaBot's report

2018-11-28 Thread Smalyshev
Smalyshev added a comment.
Hmm looks like newer items are affected too, so probably it's an instance of T210044: Data corruption when loading RDF data into WDQS.TASK DETAILhttps://phabricator.wikimedia.org/T210495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, ArthurPSmith, KaMan, Lucas_Werkmeister_WMDE, Addshore, Ladsgroup, Aklapper, Lydia_Pintscher, Cyberpower678, Lea_Lacroix_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210495: Number of Senses is decreasing on ListeriaBot's report

2018-11-28 Thread Smalyshev
Smalyshev added a comment.
Looks like some data affected by T207673 wasn't properly updated. I'll try to re-update them.TASK DETAILhttps://phabricator.wikimedia.org/T210495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, ArthurPSmith, KaMan, Lucas_Werkmeister_WMDE, Addshore, Ladsgroup, Aklapper, Lydia_Pintscher, Cyberpower678, Lea_Lacroix_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210495: Number of Senses is decreasing on ListeriaBot's report

2018-11-28 Thread ArthurPSmith
ArthurPSmith added a comment.
Just a note - WDQS query gives different results hopping up and down - sometimes 3004 (for English lexeme senses) and sometimes 2872, over about the last 10 minutes.TASK DETAILhttps://phabricator.wikimedia.org/T210495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArthurPSmithCc: Smalyshev, ArthurPSmith, KaMan, Lucas_Werkmeister_WMDE, Addshore, Ladsgroup, Aklapper, Lydia_Pintscher, Cyberpower678, Lea_Lacroix_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T193969: track percentage of articles making use of data from Wikidata

2018-11-28 Thread GoranSMilovanovic
GoranSMilovanovic added a comment.
@DarTar

Please expand in the report what's meant by "Wikidata usage", it's ambiguous and could be interpreted as items linked vs statement-level data reused via templates.

The exact definition of what "Wikidata usage" refers to on this dashboard is provided above the table, almost at the top of the page, right bellow the Wikidata logo:

Wikidata (WD) usage upon which the reported data are based excludes Sitelinks
[see: S usage aspect, wbc_entity_usage table in the Wikibase schema].

The definition of Wikidata usage is dependent upon the exact meaning of the item usage aspects as provided in the documentation of the wbc_entity_usage Wikibase table (also cf. this Diffusion page). The wbc_entity_usage table lacks a functional documentation in a sense that it does not explicitly state what user actions map onto what usage aspects, preventing the analytics from providing more meaningful, interpretable insights (e.g. going beyond expressions like "... a (S)itelink usage aspect would be registered following an application of this or that Lua module on the page..." - which are not very informative neither to our readers or editors, neither to us in analytics who take a behavioral, user-centered perspective on the data). A separate ticket will be opened soon to ask for a more thorough documentation of this table. In the meantime: this dashboards exludes only the (S)itelink usage aspect, so yes it does take into account the usage of statements (or, the so-called (C) usage aspect, quote from the documentation: "statements (C): certain statements (identified by their property id) from the entity are used").

Also: do we have the complementary chart?

Complimentary in what sense?

How much of Wikidata, by class, is reused?

This might take a while, but I certainly agree that is worth answering the question.

@Lydia_Pintscher Please let me know if any of these two question should be addressed and the respective features incorporated to our [[ http://wdcm.wmflabs.org/WD_percentUsageDashboard/


Percentage of articles making use of data from Wikidata page ]].
TASK DETAILhttps://phabricator.wikimedia.org/T193969EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GoranSMilovanovicCc: DarTar, Daniel_Mietchen, Aklapper, Addshore, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210495: Number of Senses is decreasing on ListeriaBot's report

2018-11-28 Thread Smalyshev
Smalyshev added projects: User-Smalyshev, Wikidata-Query-Service.Smalyshev added a comment.
We've had issues with deletes not being reported (T210451) but this should be fixed now. But the new ones should not be missing. I'll take a look into what's going on (probably will take a couple of days as I'm on WikiCite now).TASK DETAILhttps://phabricator.wikimedia.org/T210495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, ArthurPSmith, KaMan, Lucas_Werkmeister_WMDE, Addshore, Ladsgroup, Aklapper, Lydia_Pintscher, Cyberpower678, Lea_Lacroix_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).
TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, ReleaseTaggerBotCc: Stashbot, gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T210495: Number of Senses is decreasing on ListeriaBot's report

2018-11-28 Thread ArthurPSmith
ArthurPSmith added a subscriber: Smalyshev.ArthurPSmith added a comment.
@Smalyshev I'd forgotten there was a phabricator ticket for this - anyway, this is what I was referring to... Last night's update bumped the number down again to 2718; however when I run the query directly on WDQS I get 3004 right now. Something's not right!TASK DETAILhttps://phabricator.wikimedia.org/T210495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArthurPSmithCc: Smalyshev, ArthurPSmith, KaMan, Lucas_Werkmeister_WMDE, Addshore, Ladsgroup, Aklapper, Lydia_Pintscher, Cyberpower678, Lea_Lacroix_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210645: .toolbar overlaps .popover on the Wikidata Query UI

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476342 had a related patch set uploaded (by Abián; owner: Abián):
[wikidata/query/gui@master] Remove wrong z-index from CSS class

https://gerrit.wikimedia.org/r/476342TASK DETAILhttps://phabricator.wikimedia.org/T210645EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abian, gerritbotCc: gerritbot, Aklapper, abian, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210645: .toolbar overlaps .popover on the Wikidata Query UI

2018-11-28 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T210645EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abian, gerritbotCc: gerritbot, Aklapper, abian, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T208569: Get Wikidata clickstream

2018-11-28 Thread GoranSMilovanovic
GoranSMilovanovic added a comment.
@Lea_WMDE Just to clarify, I will put no further efforts here until you let me know what you think in respect to my insights in T208569#4767950.TASK DETAILhttps://phabricator.wikimedia.org/T208569EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GoranSMilovanovicCc: JAllemandou, Aklapper, Lea_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210645: .toolbar overlaps .popover on the Wikidata Query UI

2018-11-28 Thread abian
abian created this task.abian added a project: Wikidata Query UI.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONSeen:
F27322481: seen.png

Expected:
F27322483: expected-.pngTASK DETAILhttps://phabricator.wikimedia.org/T210645EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Aklapper, abian, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-11-28T18:33:10Z]  Synchronized php-1.33.0-wmf.6/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: [[gerrit:476312|Never return null in CachingKartographerEmbeddingHandler::getParserOutput]] T210617 (duration: 00m 53s)TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, StashbotCc: Stashbot, gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-11-28 Thread hashar
hashar added a comment.
The base container has the appropriate locale apparently and we can have the container to set ENV LC_ALL=C.UTF-8 or let blubber do it.

$ docker run --rm -it docker-registry.wikimedia.org/stretch

 # locale
LANG=
LANGUAGE=
LC_CTYPE="POSIX"
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=

# locale -a
C
C.UTF-8
POSIX
# apt update && apt install python3-minimal
...
# export LC_ALL=C.UTF-8
# bash
# python3 -c 'print("étoile")'
étoile
#

Note, I had to reload bash to get LC_ALL to apply and be able to write étoile in the terminal.TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, notconfusing, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210637: Wikidata interface language

2018-11-28 Thread Sjoerddebruin
Sjoerddebruin closed this task as a duplicate of T5665: Auto-detect interface language for anonymous users on Wikimedia projects.
TASK DETAILhttps://phabricator.wikimedia.org/T210637EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lea_Lacroix_WMDE, SjoerddebruinCc: Zeroth, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-11-28 Thread hashar
hashar added a comment.
On my local Debian Stretch machine:

$ locale -a
C
C.UTF-8
fr_FR.utf8
POSIX

$ LC_ALL=C.UTF-8 python3 -c "print('étoile')"
étoile

But I guess we are fine going with en_US.UTF-8.TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, notconfusing, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476312 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.6] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476312TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-11-28 Thread Ladsgroup
Ladsgroup added a comment.
That sounds good to add to blubber. My knowledge in go (and docker) is not well to add it on my own. So I leave it to the team. Thanks <3TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, notconfusing, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-28 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error.
TASK DETAILhttps://phabricator.wikimedia.org/T209368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, KrinkleCc: Michael, Lucas_Werkmeister_WMDE, Addshore, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331, Jdforrester-WMF, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210637: Wikidata interface language

2018-11-28 Thread Zeroth
Zeroth created this task.Zeroth added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONWhen a person visit Wikidata, the default language he/she sees is English unless that person is already logged and the default language set to some other one. This shoudnt be the case, since we are trying to be a multilangauage plataform and have easy means to check the language of the user's browser to deliver language specific interface to any person in the world, logged or not.

This is not an exclusive problem of Wikidata, since it also happens in Commons, Meta and the rest of the projects that have a centralized, not language specipic website, but since we discussed it in the wikidata telegram I thought it would be appropriate to start there.TASK DETAILhttps://phabricator.wikimedia.org/T210637EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lea_Lacroix_WMDE, ZerothCc: Zeroth, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-11-28 Thread LarsWirzenius
LarsWirzenius added a comment.
19:21 exolobe4:~/uni $ docker run unitest env LC_ALL=en_US.UTF8 python3 -c "print('étoile')"
étoile

The en_US.UTF8 locale seems to also work. Note that the locale needs to be in the docker image; it doesn't matter what's on the host.TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LarsWirzeniusCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, notconfusing, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 475316 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Display captions block immediately after the file links, before the wikitext content

https://gerrit.wikimedia.org/r/475316TASK DETAILhttps://phabricator.wikimedia.org/T205891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, gerritbotCc: gerritbot, daniel, Agabi10, Cparle, Aklapper, Jdforrester-WMF, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210635: Problems with Wikidata - Distributed Game

2018-11-28 Thread Adithyak1997
Adithyak1997 created this task.Adithyak1997 added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONI would like to point out some bugs present in the Wikidata - The Distributed Game. I am not asking it in Wikidata is because of the reason that it is being hosted in wmflabs.
The problems/suggestions are:
1)In the page https://tools.wmflabs.org/wikidata-game/distributed/ , the option to open a link/option in new tab which appears when I press the scrolling button on mouse needs to be enabled(don't know whether its my browser issue).
2)In the same page, when I click an option(for example Common Category Matches), it redirects to the corresponding page. But, when I press the back button, it is not going to the previous page which I have visited recently.
3)I am able to find two options with same name ie. 'Automated Constraint Violation Correction'  in which only one link is working. So my suggestion is to remove the inactive link. If it needs to be kept, then the name of any one of them needs to be changed.
If I am not at the right place, please tell me where I need to mention this. I am using Google Chrome browser(version 70) with adblock plus extension.TASK DETAILhttps://phabricator.wikimedia.org/T210635EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Adithyak1997Cc: Adithyak1997, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-11-28 Thread Ladsgroup
Ladsgroup added a comment.
What about en_US.UTF8? Most servers has this locale installedTASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, notconfusing, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210503: Wikidata Query UI code sample tests are disabled everywhere

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476034 merged by jenkins-bot:
[wikidata/query/gui@master] Try running code samples tests anywhere

https://gerrit.wikimedia.org/r/476034TASK DETAILhttps://phabricator.wikimedia.org/T210503EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Smalyshev
Smalyshev added a comment.
Got it, thanks. I guess then we have to give up on the idea to compare to SQL for the test in T209402: A/B testing plan for wbsearchentities, context=item and not do it in other tests. Not a big deal, I was just not aware it's not an option anymore.TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, SmalyshevCc: Stashbot, gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Continuous-Integration-Config.
TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Nandana, A.S.Kochergin, God, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Anomie, Jackmcbarn, Mbch331, hashar___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONIn Wikidata-related repositories, we’re experiencing random CI failures with the following error ([example build](https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/13724/console)) since yesterday evening (I think):...TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Anomie, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "LuaStandalone: SecurityTests[1]: CVE-2014-5461 failing" to "Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds".
TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Anomie, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
SQL search is intentionally disabled on Wikidata, and all the data that would back it (i. e. the term_search_key and term_weight columns) is not available. If for some reason we want to enable SQL search again, all that data needs to be reconstructed first, but the reason we disabled it in the first case is to reduce database bloat, because wb_terms is such a worryingly large table.

Basically, keeping the ability to fall back to SQL search costs us large amounts of database storage space, which doesn’t seem to be worth it when we really want to be using CirrusSearch anyways. We could discuss that decision, but it’s not a simple config change.TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Stashbot, gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476312 had a related patch set uploaded (by Thcipriani; owner: Hoo man):
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.6] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476312TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Smalyshev
Smalyshev added a comment.
Does it mean SQL-based search doesn't work now on Wikidata, or that we need to do some more setup to make it work? Would setting useTermsTableSearchFields be enough? Should we have it enabled in our mediawiki configs or disabling it also means we don't have proper index now and SQL search is unusable for us?TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, SmalyshevCc: Stashbot, gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-11-28 Thread LarsWirzenius
LarsWirzenius added a comment.
I confirm that generating the locales in the image, or installing locales-all (which has all locales generated) will make the étoile test work. I agree that it might be good for Blubber to automatically add one of those, but at least there's a workaround without Blubber changing. locales-all adds about 125 MB to the size of the image, so generating a UTF8 locale is probably better.

I don't know which locale should be used. The C.UTF8 locale does not seem to work with the test case.

I ran this command: docker run unitest env LC_ALL=fr_FR.UTF8 python3 -c "print('étoile')"

Varying that to set C.UTF8 or fi_FI.UTF8 gives different results. C.UTF8 fails , the fi or fr ones work.TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LarsWirzeniusCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, notconfusing, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210634: LuaStandalone: SecurityTests[1]: CVE-2014-5461 failing

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, MediaWiki-extensions-Scribunto.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONIn Wikidata-related repositories, we’re experiencing random CI failures with the following error (example build):

There was 1 failure:

1) LuaStandalone: SecurityTests[1]: CVE-2014-5461
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'ERROR: stack overflow'
+'ERROR: not enough memory'

/workspace/src/extensions/Scribunto/tests/phpunit/engines/LuaCommon/LuaEngineTestBase.php:261
/workspace/src/tests/phpunit/MediaWikiTestCase.php:424
/workspace/src/maintenance/doMaintenance.php:94

This is impacting our ability to merge changes, including the fix to T210617, a train blocker.TASK DETAILhttps://phabricator.wikimedia.org/T210634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, D3r1ck01, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Anomie, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a comment.
Fixed, as far as I can tell. (By which I mean: I could never reproduce the bug anyways – presumably I’m in the wrong group for the AB test, which is apparently not sampled per-request – but Lydia was able to test the fix and now the bug isn’t happening for her anymore.)TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Stashbot, gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209402: A/B testing plan for wbsearchentities, context=item

2018-11-28 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-11-28T17:11:12Z]  Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:476303|Disable classic_entity wbsearchentities AB test]] T209402 T210618 (duration: 00m 55s)TASK DETAILhttps://phabricator.wikimedia.org/T209402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, StashbotCc: Ladsgroup, Lucas_Werkmeister_WMDE, Stashbot, gerritbot, Aklapper, TJones, dcausse, Smalyshev, EBernhardson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-11-28T17:11:12Z]  Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:476303|Disable classic_entity wbsearchentities AB test]] T209402 T210618 (duration: 00m 55s)TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StashbotCc: Stashbot, gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T208139: Georgian words are automatically (incorrectly) capitalized when entered

2018-11-28 Thread Aklapper
Aklapper renamed this task from "Problem with Georgian writing" to "Georgian words are automatically (incorrectly) capitalized when entered".Aklapper changed the task status from "Stalled" to "Open".Aklapper added a project: I18n.
TASK DETAILhttps://phabricator.wikimedia.org/T208139EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Alan.H, Mbch331, Framawiki, Urbanecm, Dereckson, MIKHEIL, David1010, Aklapper, Mehman97, Nandana, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, D3r1ck01, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476303 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable classic_entity wbsearchentities AB test

https://gerrit.wikimedia.org/r/476303TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209402: A/B testing plan for wbsearchentities, context=item

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476303 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable classic_entity wbsearchentities AB test

https://gerrit.wikimedia.org/r/476303TASK DETAILhttps://phabricator.wikimedia.org/T209402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, gerritbotCc: Ladsgroup, Lucas_Werkmeister_WMDE, Stashbot, gerritbot, Aklapper, TJones, dcausse, Smalyshev, EBernhardson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209402: A/B testing plan for wbsearchentities, context=item

2018-11-28 Thread Ladsgroup
Ladsgroup added a comment.
Hey, I just wanted to say please contact the development team before doing something as major as this. The wb_terms table in production is fragmented (we emptied lots of its data) and never should be used as the search backend, specially in prod. The plan is to completely drop it. It's worth noting that this table has been cause of outages several times before.TASK DETAILhttps://phabricator.wikimedia.org/T209402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, LadsgroupCc: Ladsgroup, Lucas_Werkmeister_WMDE, Stashbot, gerritbot, Aklapper, TJones, dcausse, Smalyshev, EBernhardson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Blocker] T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions)

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF changed the status of subtask T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block from "Stalled" to "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T205732EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMFCc: ArielGlenn, daniel, Ramsey-WMF, Abit, Aklapper, Cparle, Jdforrester-WMF, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Status] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF moved this task from Blocked to Sign off on the SDC Engineering board.Jdforrester-WMF assigned this task to Cparle.Jdforrester-WMF changed the task status from "Stalled" to "Open".Jdforrester-WMF added a comment.
We did a local hack in WBMI to make this happen. Eventually the former sub-tasks will be fixed, at which point we should migrate to the proper fix.TASK DETAILhttps://phabricator.wikimedia.org/T205891WORKBOARDhttps://phabricator.wikimedia.org/project/board/3633/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, Jdforrester-WMFCc: gerritbot, daniel, Agabi10, Cparle, Aklapper, Jdforrester-WMF, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF removed a parent task: T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block.
TASK DETAILhttps://phabricator.wikimedia.org/T205459EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, Jdforrester-WMFCc: Cparle, Aklapper, gerritbot, daniel, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, D3r1ck01, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T195212: ServiceContainer: Allow extensions to manipulate services upon creation

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF removed a parent task: T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block.
TASK DETAILhttps://phabricator.wikimedia.org/T195212EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, Jdforrester-WMFCc: gerritbot, Aklapper, Tgr, daniel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Mainframe98, JJMC89, _jensen, Agabi10, D3r1ck01, MGChecker, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF removed a parent task: T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block.
TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, Jdforrester-WMFCc: gerritbot, Aklapper, daniel, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, D3r1ck01, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-28 Thread Jdforrester-WMF
Jdforrester-WMF removed subtasks: T209878: Allow control of page layout of multiple slots during rendering, T195212: ServiceContainer: Allow extensions to manipulate services upon creation, T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots, T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles., T209924: Introduce PageTypeHandler, T200915: Allow SlotRoleHandlers to control page layout.
TASK DETAILhttps://phabricator.wikimedia.org/T205891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMFCc: gerritbot, daniel, Agabi10, Cparle, Aklapper, Jdforrester-WMF, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread greg
greg added a parent task: T206660: 1.33.0-wmf.6 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T184933: Use or to view coordinates on Wikidata

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
I think that would be better, yes.TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tpt, Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Ainali, MSantos, matej_suchanek, WMDE-leszek, Tpt, Jonas, gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, dachary, LawExplorer, Lewizho99, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Ricordisamoa, Yurik, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476303 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Disable classic_entity wbsearchentities AB test

https://gerrit.wikimedia.org/r/476303TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209402: A/B testing plan for wbsearchentities, context=item

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476303 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Disable classic_entity wbsearchentities AB test

https://gerrit.wikimedia.org/r/476303TASK DETAILhttps://phabricator.wikimedia.org/T209402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, gerritbotCc: Lucas_Werkmeister_WMDE, Stashbot, gerritbot, Aklapper, TJones, dcausse, Smalyshev, EBernhardson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T209402: A/B testing plan for wbsearchentities, context=item

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata.Lucas_Werkmeister_WMDE added a comment.
Please see T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch for a bug that may have been caused by this.TASK DETAILhttps://phabricator.wikimedia.org/T209402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Stashbot, gerritbot, Aklapper, TJones, dcausse, Smalyshev, EBernhardson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added subscribers: EBernhardson, Smalyshev.Lucas_Werkmeister_WMDE added a comment.
So Logstash says errors start happening around 1AM today (except for a single event about four hours earlier, apparently?), and SAL says T209402: A/B testing plan for wbsearchentities, context=item was deployed around that time, which sounds very related.

This sounds even more related:


In T209402#4779955, @EBernhardson wrote:
Test is shipped out. 10% of english item searches will use the newly tuned parameters. Another 10% will use the classic SQL search. Test is intended to run one week, to be disabled on Dec 4.
TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Smalyshev, EBernhardson, TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE removed a parent task: T206660: 1.33.0-wmf.6 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
According to Logstash:


This only happens on Wikidata, not on Test Wikidata. No idea why.
This happened before the wmf.6 deployment as well, we just didn’t notice it. Therefore, I’m removing this as a train blocker, since it’s more likely to be due to a wmf-config change IMHO.
TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Lowered Priority] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to "High".Lucas_Werkmeister_WMDE added a comment.
Lowering priority from UBN to High, since Wikidata has been rolled back to wmf.4 for now.TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Lowered Priority] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to "High".Lucas_Werkmeister_WMDE added a comment.
Lowering priority from UBN to High, since Wikidata has been rolled back to wmf.4 for now.TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, Lydia_PintscherCc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Lydia_Pintscher, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Context: We used to use the wb_terms table for entity search, and for this it has two extra columns, term_search_key and term_weight. However, since we now use CirrusSearch for entity search on Wikidata (and have done so for, I think, at least a year? a while, at least), those columns were unnecessarily bloating the database, so in T188993 we wiped them. (The columns still exist because having a different table schema on some wikis would be icky, but they’re never written to nor read from.)

The error message

Using wb_terms table for wbsearchentities API action but not using search-related fields of terms table. This results in degraded search experience, please enable the useTermsTableSearchFields setting.

indicates that, for some reason, we are now using wb_terms for searching again; since the term_search_key is not available, this doesn’t work very well (making the search case sensitive is the most obvious effect, but various other normalizations are now also missing), hence the warning.TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Campsite.Lydia_Pintscher triaged this task as "Unbreak Now!" priority.Lydia_Pintscher added a subscriber: WMDE-leszek.Restricted Application added subscribers: Liuxinyu970226, TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: TerraCodes, Liuxinyu970226, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread gerritbot
gerritbot added a comment.
Change 476292 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476292TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, JGirault, D3r1ck01, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread hoo
hoo claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, CucyNoiD, Nandana, NebulousIris, MSantos, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikimedia-production-error, Wikidata, CirrusSearch.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Discovery-Search.
TASK DESCRIPTIONError

Request ID: W-62LApAAEoAAHHylHQAAABT

message[W-62LApAAEoAAHHylHQAAABT] /w/api.php?action=""   ErrorException from line 309 of /srv/mediawiki/php-1.33.0-wmf.6/includes/debug/MWDebug.php: PHP Warning: Using wb_terms table for wbsearchentities API action but not using search-related fields of terms table. This results in degraded search experience, please enable the useTermsTableSearchFields setting. [Called from Closure$#10 in /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/WikibaseRepo.entitytypes.php at line 178]

trace#0 /srv/mediawiki/php-1.33.0-wmf.6/includes/debug/MWDebug.php(309): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.33.0-wmf.6/includes/debug/MWDebug.php(164): MWDebug::sendMessage(string, array, string, integer)
#2 /srv/mediawiki/php-1.33.0-wmf.6/includes/GlobalFunctions.php(1104): MWDebug::warning(string, integer, integer, string)
#3 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/WikibaseRepo.entitytypes.php(178): wfLogWarning(string)
#4 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Api/TypeDispatchingEntitySearchHelper.php(49): Closure$#10(WebRequest)
#5 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Api/SearchEntities.php(101): Wikibase\Repo\Api\TypeDispatchingEntitySearchHelper->getRankedSearchResults(string, string, string, integer, boolean)
#6 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Api/SearchEntities.php(211): Wikibase\Repo\Api\SearchEntities->getSearchEntries(array)
#7 /srv/mediawiki/php-1.33.0-wmf.6/includes/api/ApiMain.php(1576): Wikibase\Repo\Api\SearchEntities->execute()
#8 /srv/mediawiki/php-1.33.0-wmf.6/includes/api/ApiMain.php(531): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.33.0-wmf.6/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.33.0-wmf.6/api.php(87): ApiMain->execute()
#11 /srv/mediawiki/w/api.php(3): include(string)
#12 {main}



Impact

Wikidata entity search is case-sensitive, which it isn’t supposed to be, making it harder to find entities.

Notes

This seems to be because we’re for some reason using wb_terms for search instead of CirrusSearch? Did some config get messed up?

(Contrary to what the error message suggests, we should not enable the useTermsTableSearchFields setting, since we shouldn’t be using the terms table at all here.

For some reason, this doesn’t always seen to happen. @Nikki and @Lydia_Pintscher can reproduce it, I can’t (but I can see the warnings in logstash).TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...(Contrary to what the error message suggests, we should //not// enable the `useTermsTableSearchFields` setting, since we shouldn’t be using the terms table at all here.)

For some reason, this doesn’t always seen to happen. @Nikki and @Lydia_Pintscher can reproduce it, I can’t (but I can see the warnings in logstash).TASK DETAILhttps://phabricator.wikimedia.org/T210618EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikimedia-production-error, Wikidata, Maps (Kartographer).Lucas_Werkmeister_WMDE triaged this task as "Unbreak Now!" priority.Restricted Application added subscribers: Liuxinyu970226, Mholloway, TerraCodes, Aklapper.
TASK DESCRIPTIONError

Request ID: W-60bApAIC8AACwmGvkAAABH

message[W-60bApAIC8AACwmGvkAAABH] /wiki/Q499158   BadMethodCallException from line 81 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/GlobeCoordinateKartographerDataUpdater.php: Call to a member function getJsConfigVars() on a non-object (null)

trace/srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/GlobeCoordinateKartographerDataUpdater.php:81
#0 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/EntityStatementDataUpdaterAdapter.php(32): Wikibase\Repo\ParserOutput\GlobeCoordinateKartographerDataUpdater->updateParserOutput(ParserOutput)
#1 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/EntityParserOutputDataUpdaterCollection.php(45): Wikibase\Repo\ParserOutput\EntityStatementDataUpdaterAdapter->updateParserOutput(ParserOutput)
#2 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/EntityParserOutputGenerator.php(139): Wikibase\Repo\ParserOutput\EntityParserOutputDataUpdaterCollection->updateParserOutput(Wikibase\DataModel\Entity\Item)
#3 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Content/EntityContent.php(291): Wikibase\Repo\ParserOutput\EntityParserOutputGenerator->getParserOutput(Wikibase\DataModel\Entity\Item, boolean)
#4 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Content/EntityContent.php(228): Wikibase\EntityContent->getParserOutputFromEntityView(integer, ParserOptions, boolean)
#5 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RenderedRevision.php(265): Wikibase\EntityContent->getParserOutput(Title, integer, ParserOptions, boolean)
#6 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RenderedRevision.php(233): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(Wikibase\ItemContent, boolean)
#7 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RevisionRenderer.php(184): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#8 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RevisionRenderer.php(133): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#9 [internal function]: Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2(MediaWiki\Revision\RenderedRevision, array)
#10 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RenderedRevision.php(197): call_user_func(Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2;2592, MediaWiki\Revision\RenderedRevision, array)
#11 /srv/mediawiki/php-1.33.0-wmf.6/includes/poolcounter/PoolWorkArticleView.php(194): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#12 /srv/mediawiki/php-1.33.0-wmf.6/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#13 /srv/mediawiki/php-1.33.0-wmf.6/includes/page/Article.php(774): PoolCounterWork->execute()
#14 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(79): Article->view()
#15 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(54): Wikibase\ViewEntityAction->showEntityPage()
#16 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(501): Wikibase\ViewEntityAction->show()
#17 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#18 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(862): MediaWiki->performRequest()
#19 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(517): MediaWiki->main()
#20 /srv/mediawiki/php-1.33.0-wmf.6/index.php(42): MediaWiki->run()
#21 /srv/mediawiki/w/index.php(3): include(string)
#22 {main}



Impact

Internal error when loading Wikidata item pages which have coordinate values with a globe other than the Earth (e. g. coordinates on the Moon or on Mars). (Presumably. Investigation ongoing.) Happening since the deployment of 1.33.0-wmf.6, which includes T184933: Use  or  to view coordinates on Wikidata.

NotesTASK DETAILhttps://phabricator.wikimedia.org/T210617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, TerraCodes, Mholloway, Lucas_Werkmeister_WMDE, Liuxinyu970226, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, JGirault, D3r1ck01, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T210148: Allow user specific selection of "more languages" in termbox

2018-11-28 Thread Lea_WMDE
Lea_WMDE triaged this task as "Normal" priority.Lea_WMDE updated the task description. (Show Details)Lea_WMDE set the point value for this task to "5".
CHANGES TO TASK DESCRIPTION...- We don't know yet, what happens ifexpect that we will never have the ULS extension is not installedcase of not having a ULS extension

**Mock**...TASK DETAILhttps://phabricator.wikimedia.org/T210148EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lea_WMDECc: Lea_WMDE, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T184933: Use or to view coordinates on Wikidata

2018-11-28 Thread hoo
hoo added a comment.
@Lucas_Werkmeister_WMDE This is done for Wikibase repo… but there's still a patch (by @Tpt) pending for the wikitext formatter (for clients). Do we want to create a new bug for that?TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tpt, hooCc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Ainali, MSantos, matej_suchanek, WMDE-leszek, Tpt, Jonas, gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, dachary, LawExplorer, Lewizho99, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Ricordisamoa, Yurik, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T184933: Use or to view coordinates on Wikidata

2018-11-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subscriber: Lydia_Pintscher.Lucas_Werkmeister_WMDE added a comment.
For the record, this just went live with the train, so I guess it should’ve been in the “needs announcement” column at some point. But I’ll leave it in “needs review” now for the last unmerged patch. @Lydia_Pintscher, if you want to do the “verification” part already, you can see it in action at https://www.wikidata.org/wiki/Q4115189#P626.TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tpt, Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Ainali, MSantos, matej_suchanek, WMDE-leszek, Tpt, Jonas, gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, dachary, LawExplorer, Lewizho99, Maathavan, _jensen, JGirault, D3r1ck01, phabyogi, Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Ricordisamoa, Yurik, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


  1   2   >