[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lydia_Pintscher]

Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher moved this task from Product Verification to Our work done on 
the Wikidata Dev Team (Sprint-∞) board.
Lydia_Pintscher added a comment.


  \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Alright, added that to the PR too.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: LucasWerkmeister, Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, 
Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Sarai-WMDE]

Sarai-WMDE added a subscriber: LucasWerkmeister.
Sarai-WMDE added a comment.


  Thanks so much for all the changes and for your patient support, 
@LucasWerkmeister!  
  After taking a look at the specs and changes again, I realized that we might 
need to increase the spacing under the 'Find more mismatches' button. This is 
to prevent it from being visually grouped with the introductory title + text 
after adjusting the space at the top. I think the increase could be applied as 
a 1rem margin-bottom. That would be the last needed change. Thanks again!

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: LucasWerkmeister, Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, 
Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the 
Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  I think https://github.com/wmde/wikidata-mismatch-finder/pull/487 should 
implement all the changes.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > This had the intention of making both pages consistent again: the 
description in the main page has technically a bottom margin of 2.5rem applied 
to it, but that spacing increases due to the extra margin applied to the 
elements placed right below it. Looking at it now with the intention of making 
the UI more 'compact', maybe we could attempt to adjust the spacing between the 
description and the 'message section' in the main page to really be 2.5rem? 
(Updating specs too)
  
  Okay, so removing the margin-top from the querying section’s heading so that 
it’s not added to the previous section’s margin-bottom… makes sense, I think.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > We should add some spacing between the header and the back button to keep 
the main page and the results pages similarly spaced, yes. The specs suggested 
adding the same (slightly increased) spacing between the header (which should 
be considered a unit that includes its margins: should these actually be 
paddings?) and the next element below it. Given the increase of the header 
spacing from 1.25 to 1.5, I think it's fair to reduce that spacing to 1rem now: 
this means that no change is required in the main page, but yes, the button 
shouldn't be adjacent to the header.
  
  I see what you mean – makes sense 

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Regarding the tablet breakpoint: I'm not able to find any mention of the 
spacing change in the header specs 樂  The header seems to stay the same, or at 
least that's what's documented in the original MVP designs 

 and the SPA consolidation specs 

 (which now need to be updated to reflect the right spacing). I'm not sure why 
this distinction was made, but it could be related to trying to fix some layout 
issues (see #100 
)?
  
  It looks like the different header margin was added in #82 
 (specifically this 
commit 
),
 part of porting to Wikit ; I don’t 
see why, though. Let’s always use `small` then, I guess.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Summary of what's causing confusion: rather than fully adhering to creating a 
'compact' look, the spacing changes included in the mock have the purpose of 
fixing the heading dimensions, and solving some spacing inconsistencies between 
the main and the results pages, and the original designs. The course of action 
from my side should have consisted on creating a separate ticket. If that's 
preferable, I'll go ahead and create a new task!
  
  > - In Figma, the header has a vertical margin of 1.25em. In the app, it 
currently has `$dimension-layout-xsmall` (1rem), or `$dimension-layout-small` 
(1.5rem) above the tablet breakpoint. Which breakpoint does Figma correspond 
to? And should I hard-code the 1.25em (1.25rem?), or is there another variable 
I’m missing?
  
  Sorry about that. The 1.25em value is part of the Codex sizing & spacing 
scale, but not WiKit's. Let's keep using `$dimension-layout-small`. Regarding 
the tablet breakpoint: I'm not able to find any mention of the spacing change 
in the header specs 樂  The header seems to stay the same, or at least that's 
what's documented in the original MVP designs 

 and the SPA consolidation specs 

 (which now need to be updated to reflect the right spacing). I'm not sure why 
this distinction was made, but it could be related to trying to fix some layout 
issues (see #100 
)? If 
possible, thee header spacing should remain the same regardless of the device 
size in both the Mismatch website and the store.
  
  > - In Figma, the “find more mismatches” button has a vertical margin of 
1.5em, which apparently doesn’t collapse with the header margin. In the app, it 
currently has no margin of its own, but its surrounding elements produce a 
margin of 1.5rem (header, above) and 1rem (description section heading, below) 
respectively. Do we want to increase that?
  
  We should add some spacing between the header and the back button to keep the 
main page and the results pages similarly spaced, yes. The specs suggested 
adding the same (slightly increased) spacing between the header (which should 
be considered a unit that includes its margins: should these actually be 
paddings?) and the next element below it. Given the increase of the header 
spacing from 1.25 to 1.5, I think it's fair to reduce that spacing to 1em now: 
this means that no change is required in the main page, but yes, the button 
shouldn't be adjacent to the header.
  
  > - In Figma, the description section has a lower margin of 3em; in the app, 
it’s currently 2.5rem. Do we want to increase that?
  
  This had the intention of making both pages consistent again: the description 
in the main page has technically a bottom margin of 2.5em applied to it, but 
that spacing increases due to the extra margin applied to the elements placed 
right below it. Looking at now with the intention of making the UI more 
'compact', maybe we could attempt to adjust the spacing between the description 
and the 'message section' 2.5rem? (Updating specs too)
  
  F35824132: Screenshot 2022-11-29 at 15.22.38.png 

  
  > - In Figma, the mismatches form footer (with the “save reviews” button) has 
an upper margin of 1.5em and a lower margin of 3.5em; in the app, it currently 
has an upper margin of 1rem, a lower margin of 2.5rem, and additionally a 
minimum height of 5em. I assume we want to remove the min-height (it doesn’t 
collapse with the margin, and I see nothing corresponding to it in Figma), but 
do we want to increase the margins?
  
  The specs suggested increasing the margin between the 'Save reviews' button 
and table to 1.5em (again, to keep spacing homogenous) while reducing the 
min-height to 3.5em to condense a little bit the view (doing this gave a pass 
to add a bit of extra spacing between table and button). Now, thanks to your 
comment regarding the message: that's right. I remember this conversation and 
us going for the default increase in space. So we should leave this as is.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to 

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > I assume we want to remove the min-height (it doesn’t collapse with the 
margin, and I see nothing corresponding to it in Figma)
  
  Looks like the minimum height is there to ensure that there’s enough space 
for the message when the reviews are saved – the message can appear without 
changing the layout:
  F35824012: Screenshot from 2022-11-29 12-55-15.png 

  F35824013: Screenshot from 2022-11-29 12-55-13.png 

  
  And this seems to be important because the message of one set of mismatches 
disappears as soon as you submit the next set of mismatches (when reviewing 
mismatches of multiple items on one page), so I guess you don’t want the page 
to jump around in that case as the older message disappears… but maybe we can 
instead only reserve that space for messages that have been shown at some point 
(e.g. by setting old messages to `visibility: none` instead of removing them), 
not for all potential messages?

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  @Sarai-WMDE I could use some clarifications on Figma, sorry…
  
  - In Figma, the header has a vertical margin of 1.25em. In the app, it 
currently has `$dimension-layout-xsmall` (1rem), or `$dimension-layout-small` 
(1.5rem) above the tablet breakpoint. Which breakpoint does Figma correspond 
to? And should I hard-code the 1.25em (1.25rem?), or is there another variable 
I’m missing?
  - In Figma, the “find more mismatches” button has a vertical margin of 1.5em, 
which apparently doesn’t collapse with the header margin. In the app, it 
currently has no margin of its own, but its surrounding elements produce a 
margin of 1.5rem (header, above) and 1rem (description section heading, below) 
respectively. Do we want to increase that?
  - In Figma, the description section has a lower margin of 3em; in the app, 
it’s currently 2.5rem. Do we want to increase that?
  - In Figma, the mismatches form footer (with the “save reviews” button) has 
an upper margin of 1.5em and a lower margin of 3.5em; in the app, it currently 
has an upper margin of 1rem, a lower margin of 2.5rem, and additionally a 
minimum height of 5em. I assume we want to remove the min-height (it doesn’t 
collapse with the margin, and I see nothing corresponding to it in Figma), but 
do we want to increase the margins?
  
  Basically, a lot of the differences I can see in Figma seem to be adding more 
space, not saving it  though it’s very possible that I’m missing or 
misunderstanding something.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the 
Wikidata Dev Team (Sprint-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[karapayneWMDE]

karapayneWMDE moved this task from Unified prioritized backlog to Sprint-∞ on 
the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed 
Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[karapayneWMDE]

karapayneWMDE set the point value for this task to "2".

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T323678#8424149 , 
@Michael wrote:
  
  > Mh, this means we're //dropping// the ``, right? Not sure that this is 
ideal
  
  The Figma link in T323680  has a 
screenreader-only `` (for sighted users, the clickable header image takes 
over the role of the heading).

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Michael]

Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Michael]

Michael added a comment.


  Mh, this means we're //dropping// the ``, right? Not sure that this is 
ideal

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I feel obliged to point out that the screenshot in the task description is at 
150% zoom; at 100%, only a few pixels below the footer are cut off on a 
maximized non-fullscreen browser on a 1080p screen (which seems to be where the 
screenshot was taken):
  F35821946: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323678: Save space on Mismatch Finder main page and results page to make call to action easier to see

[Lydia_Pintscher]

Lydia_Pintscher renamed this task from "Mismatch Finder should be easier to use 
on laptops" to "Save space on Mismatch Finder main page and results page to 
make call to action easier to see".

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org