[MediaWiki-CodeReview] [MediaWiki r88362]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r88362. Old Status: deferred New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r88362. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88362#c18747 Commit summary: some work on paging stuff Comment: Marking back to fixme: message key still has a typo, no plural support and messages should be documented. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90743]: New comment added
User SPQRobin posted a comment on MediaWiki.r90743. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90743#c18748 Commit summary: Directionality improvements as part of bug 6100 (under $wgBetterDirectionality): * Add CSS that should fix all LTR/LTR text on both LTR/RTL wikis, for the editsection link, TOC, and lists (ul/ol). * Add a class mw-content-ltr/rtl for that. * Change the divs on CategoryPage so it works wit that CSS. This is the last relatively major issue for bug 6100. Comment: The structure is pre div class=mw-content-rtl dir=rtl Stuff like span class=editsection/span /div /pre but the extra [dir=ltr/rtl] is to make sure a div dir=ltr/rtl within the wikitext works as well (which doesn't work without $wgBetterDirectionality). Ideally it shouldn't be there, but there are many pages on multilingual wikis that have an extra div dir=rtl where editsection/TOC/lists currently don't display nicely. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88622]: Revision status changed
User Hashar changed the status of MediaWiki.r88622. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88622#c0 Commit summary: Adding test suite for jquery.tabIndex.js, currently broken per: (bug 29048) jQuery.tabIndex: firstTabIndex() outputs the same as lastTabIndex() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added
User TheDJ posted a comment on MediaWiki.r68904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c18749 Commit summary: (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis. Comment: As far as I'm concerned, there are toggles: If you don't want external sources in 'control' of your wiki 1: Don't use instantcommons/foreignrepo If you don't want external skinning by external wiki 2: Override in your own Wiki with stronger CSS statements. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90819]: New comment added, and revision status changed
User Simetrical changed the status of MediaWiki.r90819. Old Status: new New Status: fixme User Simetrical also posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18750 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805, XOR passed iff an odd number of subconds passed. It now passes iff exactly one subcond passes. This should be more intuitive, as I highly doubt anyone using 3+ subconds was doing it correctly before. Comment: This is not how xor works in programming languages or mathematics. If you xor multiple things, it is indeed true if and only if an odd number are true. If you want an only one operator, you shouldn't call it ^ -- that's extremely confusing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90524]: New comment added
User Devayon posted a comment on MediaWiki.r90524. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90524#c18751 Commit summary: follow up to r90521 Comment: Hi, I get a database error if I go to index.php directly. Problem is solved (as in I get a proper redirect to main-page) if this patch is reverted. Can you confirm if it's a real bug? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] WMF XML dump title case problem
Sorry, now correctly cross posted. Emmanuel Original Message Subject:WMF XML dump title case problem Date: Sun, 26 Jun 2011 17:07:19 +0200 From: Emmanuel Engelhart emman...@engelhart.org To: Mailing list for Wikimedia CH wikimediac...@lists.wikimedia.org, offlin...@lists.wikimedia.org Hi Titles should be stored in the table page with a first letter uppercased. http://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_%28technical_restrictions%29#Lower_case_first_letter Unfortunately, it seems that we have XML dumps (and consequently mwdumper generated SQL) containing titles with a first letter lowercased. For example: $wget http://download.wikimedia.org/mywiktionary/20110617/mywiktionary-20110617-pages-articles.xml.bz2 $bzip2 -d -c mywiktionary-20110617-pages-articles.xml.bz2 | grep title| grep tationery | more titlestationery/title titlestationery shop/title Is that a bug? Regards Emmanuel ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] WMF XML dump title case problem
Emmanuel Engelhart wrote: Titles should be stored in the table page with a first letter uppercased. http://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_%28technical_restric tions%29#Lower_case_first_letter Unfortunately, it seems that we have XML dumps (and consequently mwdumper generated SQL) containing titles with a first letter lowercased. For example: $wget http://download.wikimedia.org/mywiktionary/20110617/mywiktionary-20110617-page s-articles.xml.bz2 $bzip2 -d -c mywiktionary-20110617-pages-articles.xml.bz2 | grep title| grep tationery | more titlestationery/title titlestationery shop/title Is that a bug? No. You're trying to apply the English Wikipedia's rules to the Burmese Wiktionary. Wiktionaries have $wgCapitalLinks set to false.[1] MZMcBride [1] http://www.mediawiki.org/wiki/Manual:$wgCapitalLinks ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] WMF XML dump title case problem
Emmanuel Engelhart wrote: Titles should be stored in the table page with a first letter uppercased... Unfortunately, it seems that we have XML dumps (and consequently mwdumper generated SQL) containing titles with a first letter lowercased. For example: $wget http://download.wikimedia.org/mywiktionary/20110617/mywiktionary-20110617-pages-articles.xml.bz2 Wiktionary is different. Its users requested reconfiguration so that words are stored in the database with their exact capitalization. The Wikipedia-style first-letter capitalization (which caused pretty severe problems for a dictionary) is *not* performed there. See also http://en.wiktionary.org/wiki/Wiktionary:Capitalization . ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90835]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90835#c18752 Commit summary: Unbreak multiple maintenance scripts Comment: Please backport, these are regressions in 1.17. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90524]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r90524. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90524#c18753 Commit summary: follow up to r90521 Comment: You need to run the table update script at special smwadmin ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82418]: Revision status changed
User Hashar changed the status of MediaWiki.r82418. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82418#c0 Commit summary: re bug #25523: add mime.info and mime.types for *.dwg files so that when people add dwg to $wgFileExtensions, they can move files. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90524]: New comment added
User Devayon posted a comment on MediaWiki.r90524. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90524#c18754 Commit summary: follow up to r90521 Comment: oh, thanks :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90839]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r90839. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r90839. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90839#c18755 Commit summary: Followup r90775: Fix PHP Notice: Undefined index: deletedonly in /www/w/includes/specials/SpecialContributions.php on line 131 Comment: Cheers Raymond ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90819]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18756 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805, XOR passed iff an odd number of subconds passed. It now passes iff exactly one subcond passes. This should be more intuitive, as I highly doubt anyone using 3+ subconds was doing it correctly before. Comment: I talked to Bawolff and he thought the parity based behavior was confusing too. Either it should be one-hot or just allow two things. Otherwise it's just asking for mistakes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90304]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r90304. Old Status: fixme New Status: new User Aaron Schulz also posted a comment on MediaWiki.r90304. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90304#c18757 Commit summary: Fix r90024: missing one PG sql file change Comment: Resetting to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90835]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90835. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90835#c0 Commit summary: Unbreak multiple maintenance scripts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90827]: Revision status changed
User Reedy changed the status of MediaWiki.r90827. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90827#c0 Commit summary: userinfo for Guillaume Paumier ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90002]: Revision status changed
User Reedy changed the status of MediaWiki.r90002. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90002#c0 Commit summary: fix random link ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90826]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90826. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90826#c0 Commit summary: Fix comment in BacklinkCache::partition() + a typo Per cr on r84254 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84254]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84254. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84254#c0 Commit summary: documentation for BacklinkCache class - still need examples - could use peer review - no functional changes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83754]: Revision status changed
User Reedy changed the status of MediaWiki.r83754. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83754#c0 Commit summary: Update description how CentralNotice works to match the current landscape. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83731]: Revision status changed
User Reedy changed the status of MediaWiki.r83731. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83731#c0 Commit summary: removed .project file ( mistake in r83730 ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86448]: Revision status changed
User Reedy changed the status of MediaWiki.r86448. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86448#c0 Commit summary: added licence ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90833]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r90833. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90833#c18758 Commit summary: Per http://translatewiki.net/wiki/Thread:Support/Unprotect get rid of term unprotect (hard to translate, not necessarily used to remove protection) Comment: code 'protectlogtext' = 'Below is a list of changes to page protections./code Maybe that should say protection status (not those exact words) or something. That bit seems awkward. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90839]: New comment added
User Duplicatebug posted a comment on MediaWiki.r90839. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90839#c18759 Commit summary: Followup r90775: Fix PHP Notice: Undefined index: deletedonly in /www/w/includes/specials/SpecialContributions.php on line 131 Comment: api params always lowercase: changing tt$apiParams['deletedonly'] = true;/tt is wrong ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89566]: New comment added
User Duplicatebug posted a comment on MediaWiki.r89566. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89566#c18760 Commit summary: Followup r89564 Strip out the ?feed= functionality, update urls to point at the API! Comment: Using tt$wgUser/tt for ttuser/tt looks wrong, because you want not your own list at this point ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80167]: New comment added
User Hashar posted a comment on MediaWiki.r80167. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80167#c18761 Commit summary: Coerce mtimes to TS_UNIX before outputting them, and fix a wrong timestamp format in ResourceLoaderUserModule. This should fix bug 26704 Comment: This looks similar to r81689 . I am wondering if we need it in 1.17 and on live site. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90823]: New comment added
User Kaldari posted a comment on MediaWiki.r90823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90823#c18762 Commit summary: mw.util.wikiUrlencode is not meant for encoding entire URLs, or if it is, its too agressive. For example, it encodes tildes, which will break some URLs. Its great for encoding page names, though, which may include question marks, etc. Comment: Took out the wgServer in r90842. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90845]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90845.
Old Status: new
New Status: fixme
User Krinkle also posted a comment on MediaWiki.r90845.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90845#c18765
Commit summary:
Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditor
Comment:
pre
- 'result': { 'htmlMsg':
[ 'wikieditor-toolbar-help-content-file-result', stylepath ] }
+ 'result': { 'htmlMsg':
[ 'wikieditor-toolbar-help-content-file-result', mw.get( 'stylepath' ) ] }
/pre
mw.'''config.'''get. Wasn't part of the patch.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90845]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90845.
Old Status: fixme
New Status: resolved
User Krinkle also posted a comment on MediaWiki.r90845.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90845#c18766
Commit summary:
Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditor
Comment:
pre
-'result': { 'htmlMsg': [ 'wikieditor-toolbar-help-content-file-result',
stylepath ] }
+'result': { 'htmlMsg': [ 'wikieditor-toolbar-help-content-file-result',
mw.get( 'stylepath' ) ] }
/pre
mw'''.config'''.get. Wasn't part of the patch.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90845]: New comment added
User Krinkle posted a comment on MediaWiki.r90845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90845#c18767 Commit summary: Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditor Comment: Fixed in r90850. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90239]: Revision status changed
User MarkAHershberger changed the status of MediaWiki.r90239. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90239#c0 Commit summary: Fix Bug #28344 - “Links doesn't work inside collapsible toggles” Patch from mybugs.mail If a link is added inside of a collapsible toggle and a user click on it, the target page should be opened. … The attached patch was tested locally and fixes this bug (clicking outside the link toogles the collapsed content, and clicking on the link opens the target page). PS: It is the same code which was used to fix the problem on Commons. http://commons.wikimedia.org/w/index.php?diff=45383826oldid=45265712 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90851]: Revision status changed
User Krinkle changed the status of MediaWiki.r90851. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90851#c0 Commit summary: Followup r90239: Move return till after the toggle is executed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90239]: Revision status changed
User Krinkle changed the status of MediaWiki.r90239. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90239#c0 Commit summary: Fix Bug #28344 - “Links doesn't work inside collapsible toggles” Patch from mybugs.mail If a link is added inside of a collapsible toggle and a user click on it, the target page should be opened. … The attached patch was tested locally and fixes this bug (clicking outside the link toogles the collapsed content, and clicking on the link opens the target page). PS: It is the same code which was used to fix the problem on Commons. http://commons.wikimedia.org/w/index.php?diff=45383826oldid=45265712 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87483]: Revision status changed
User Krinkle changed the status of MediaWiki.r87483. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87483#c0 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89812]: New comment added
User Krinkle posted a comment on MediaWiki.r89812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c18769 Commit summary: MFT r89278, r89452. Also had to grab r83360. Comment: Looks like the first part of r89278 wasn't applied here, intentional ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89812]: Revision status changed
User Krinkle changed the status of MediaWiki.r89812. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c0 Commit summary: MFT r89278, r89452. Also had to grab r83360. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89813]: Revision status changed
User Krinkle changed the status of MediaWiki.r89813. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89813#c0 Commit summary: Followup r89812, RELEASE-NOTES ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90586]: New comment added
User Krinkle posted a comment on MediaWiki.r90586. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90586#c18770 Commit summary: * MFT r90585 (i know it's late ... ready for 1.17.1 :D) * *this* is why i need testing pplz on oracle Comment: The revision in trunk isn't reviewed yet. Please wait for review next time before MFT'ing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90852]: Revision status changed
User Krinkle changed the status of MediaWiki.r90852. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90852#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-26 19:34:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90843]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90843. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r90843. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90843#c18771 Commit summary: Update calls to deprecated User::isValidEmailAddr Fix trailing whitespace Some minor documentation fixes Comment: ftr, move was done in r86364 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86364]: New comment added
User Krinkle posted a comment on MediaWiki.r86364. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86364#c18772 Commit summary: Move User::isValidEmailAddr() to Sanitizer. Comment: Reedy fixed the deprecated uses of it in trunk in r90843. See also [http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=230hash=f6e14dcf3ef906c9903e6ea825399dd3 isValidEmailAddr in trunk] for more mentions of it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88551]: Revision status changed
User Krinkle changed the status of MediaWiki.r88551. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88551#c0 Commit summary: * (bug 26240) CodeReview's (partially absence of) query params suck (tracking) Make filtering by author/status work for each other when using the main list view $suckage--; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90819]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18774 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805, XOR passed iff an odd number of subconds passed. It now passes iff exactly one subcond passes. This should be more intuitive, as I highly doubt anyone using 3+ subconds was doing it correctly before. Comment: Sounds fine by me. If there are 3+ items for '^' it should give some kind of error though (not silently ignore stuff). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83909]: New comment added
User Happy-melon posted a comment on MediaWiki.r83909. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c18775 Commit summary: Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist: * Move and rename to SpecialBlockList * Use an HTMLForm in GET mode for the options form * Use TablePager to organise the results more nicely * Standardise the filtration for IPs and IP ranges, so looking at blocks for a range will now also show rangeblocks which contain the range * General tidy up Comment: blockquotepre+ $formatted = wfMessage( 'autoblockid', $row-ipb_id );/pre How does that work? Should it return HTML? /blockquote The ttMessage/tt class has a __toString() magic method. blockquotepre+ static $headers = null;/pre Why does getFieldNames() use a static var? Is it called often or something? /blockquote Actually no, it's not. Doesn't do any ''harm'', per se, though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84251]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r84251. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r84251. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84251#c18776 Commit summary: First forays into the swamp of the Block.php backend: * Move Block::parseExpiryInput() to the frontend SpecialBlock::parseExpiryInput() * consolidate the several implementations of the MediaWiki:Ipblockoptions parsing into SpecialBlock::getSuggestedDurations() Comment: Reverted this part in r90857. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90857]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90857#c0 Commit summary: Follow-up r84251 - isAllowed( 'right', 'or-another-right' ) was reverted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90815]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90815. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90815#c0 Commit summary: (sort of bug 29586) Make the (next 200) links on categories link directly to the relevant section of the category. The bug in question actually want to remove all the other sections of the category when you hit (next 200), I personally think that'd be confusing, but would be good to have other people's thoughts. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90814]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r90814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90814#c18778 Commit summary: (bug 8556) When using $wgRawHtml, don't show scary session_failure/possible attack warning when you try to edit categories. Categories automatically go to preview on open, but there's no edit token on the initial open of the edit window, which causes big warning over nothing. Comment: Should the code$this-textbox1 !== ''/code check be up there with codeif ( $wgRawHtml !$this-mTokenOk )/code? What about the code after that check? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added
User Happy-melon posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18779 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: Are static variables in methods shared between separate instances of the same class, then? If so, that's definitely not the way to cache it tt:S/tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90840]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90840. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90840#c0 Commit summary: Twesk description message for consistency Register extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18781 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: See http://www.php.net/manual/en/language.variables.scope.php#53915 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added
User Krinkle posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18783 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: Oh you meant a static variable within an public method. Hm.. that's interesting. Gonna try that one out. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added
User Happy-melon posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18782 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: Trying to translate the target is a user condition into pure SQL would be difficult, and would introduce potential inconsistencies with the behaviour of Block::parseTarget(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18784 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: Fair enough, I was getting hung up on the $block-isHardblock() part, which would be easy by itself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90841]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90841. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90841#c0 Commit summary: Fix class name conflict with core ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90803]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90803. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90803#c0 Commit summary: add tooltip-invert tooltip-namespace_association introduced by 90766 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84475. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c0 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84588]: New comment added
User Happy-melon posted a comment on MediaWiki.r84588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84588#c18787 Commit summary: Try to untangle the autoblock time logic, which made very little sense and led to very old indefinite blocks triggering autoblocks with ipb_expiry ipb_timestamp. Comment: In a word, yes. DB_READ was replaced at some point since this revision. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90860]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90860. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90860#c0 Commit summary: Follow-up r84588 CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84588]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84588. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84588#c0 Commit summary: Try to untangle the autoblock time logic, which made very little sense and led to very old indefinite blocks triggering autoblocks with ipb_expiry ipb_timestamp. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86234]: Revision status changed
User Happy-melon changed the status of MediaWiki.r86234. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86234#c0 Commit summary: Update Skin.php to not call the now-separate Linker methods via $this-foo(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85951]: New comment added
User Happy-melon posted a comment on MediaWiki.r85951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85951#c18788 Commit summary: Implement user-is-blocked and wiki-is-read-only as exceptions. Comment: ''All'' of User.php smells, the bits associated with blocking particularly so... tt:D/tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85951]: New comment added
User Happy-melon posted a comment on MediaWiki.r85951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85951#c18789 Commit summary: Implement user-is-blocked and wiki-is-read-only as exceptions. Comment: One step closer to the global-less code nirvana tt;)/tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85872]: New comment added
User Happy-melon posted a comment on MediaWiki.r85872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85872#c18790 Commit summary: Clean up some direct $db-query($sql) calls. Remove limit/offset parameters from Article::getContributors() as they weren't being used anywhere and probably didn't work properly anyway. Comment: AFAICT, this is what it does; the query is something like source lang=mysql SELECT '*' FROM `page` WHERE ( ( `page_namespace` = 0 AND `page_title` IN ( 'foo', 'bar', 'baz' ) ) OR ( `page_namespace` = 1 AND `page_title` IN ( 'baz', 'nada', 'quok' ) ) OR ( `page_namespace` = 2 AND `page_title` = 'blat' ) ) /source Am I misunderstanding the problem? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r35826]: New comment added
User Solitarius posted a comment on MediaWiki.r35826. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/35826#c18791 Commit summary: Revert r35769. The star-shaped bullet isn't really ideal; it doesn't display properly in some browsers (overlaps with square bullet), and isn't particularly clear. Might be best to break the pages back out again so things are visible and accessible. Comment: Aren't font-weight: bold; and strong redundant? It seem to make a odd rendering in FF5. See bug 26442 and bug 29602 . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85872]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85872. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85872#c0 Commit summary: Clean up some direct $db-query($sql) calls. Remove limit/offset parameters from Article::getContributors() as they weren't being used anywhere and probably didn't work properly anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85872]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r85872.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85872#c18792
Commit summary:
Clean up some direct $db-query($sql) calls. Remove limit/offset parameters
from Article::getContributors() as they weren't being used anywhere and
probably didn't work properly anyway.
Comment:
Nevermind, it *is* what it should be. Maybe I thought that $pages in
codeforeach( $queries as $ns = $pages ){/code was singular...
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90814]: New comment added
User Bawolff posted a comment on MediaWiki.r90814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90814#c18793 Commit summary: (bug 8556) When using $wgRawHtml, don't show scary session_failure/possible attack warning when you try to edit categories. Categories automatically go to preview on open, but there's no edit token on the initial open of the edit window, which causes big warning over nothing. Comment: I did it down there to be paranoid. In theory extensions could use the EditPageGetPreviewText hook to look at other request variables (like MetadataEdit extension). This way the function will still return before that if there is no edit token. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90865]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90865. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90865#c0 Commit summary: Follow-up r86234, and more parameter documentation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86234]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r86234. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86234#c0 Commit summary: Update Skin.php to not call the now-separate Linker methods via $this-foo(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90861]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90861#c0 Commit summary: Comment shuffling, also fixing r86347 CR. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89812]: New comment added
User ^demon posted a comment on MediaWiki.r89812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c18794 Commit summary: MFT r89278, r89452. Also had to grab r83360. Comment: Do you mean the changes to HttpTest? Not necessary since the phpunit tests were dropped from REL1_17. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Bugzilla Weekly Report
MediaWiki Bugzilla Report for June 20, 2011 - June 27, 2011 Status changes this week Bugs NEW : 247 Bugs ASSIGNED : 10 Bugs REOPENED : 37 Bugs RESOLVED : 138 Total bugs still open: 5871 Resolutions for the week: Bugs marked FIXED : 85 Bugs marked REMIND : 0 Bugs marked INVALID: 10 Bugs marked DUPLICATE : 13 Bugs marked WONTFIX: 19 Bugs marked WORKSFORME : 5 Bugs marked LATER : 8 Bugs marked MOVED : 0 Specific Product/Component Resolutions User Metrics New Bugs Per Component MobileFrontend 8 Semantic MediaWiki 6 Installation5 [other] 4 Site requests 4 New Bugs Per Product MediaWiki 30 Wikimedia 14 MediaWiki extensions34 Wikipedia Mobile1 Security1 Top 5 Bug Resolvers jeluf [AT] gmx.de 15 volker.haas [AT] pediapress.com 15 p858snake [AT] gmail.com8 pdhanda [AT] wikimedia.org 8 mah [AT] everybody.org 8 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89812]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r89812. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r89812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c18795 Commit summary: MFT r89278, r89452. Also had to grab r83360. Comment: Ah, okay that makes sense. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
