[MediaWiki-CodeReview] [MediaWiki r92138]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92138. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92138#c19579 Commit summary: InputBox: * instead of checking each namespace if it is given through the parameter, check each given namespace if it is a valid one * this fixes the inconsistency where 2 namespaces are given but only 1 is valid and that one is shown (normally if there is only 1 given, it is hidden) * fix bug 22591 (Allow i18n of Main namespace search option label) * allow namespace aliases as well * also trim the given namespaces, so spaces do not make them invalid Comment: Core refers to the zero namespace as (Main). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92141]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92141#c19580 Commit summary: Babel: (bug 29663) Babel doesn't validate babel-autocreate-user message - do nothing if the username is invalid. Also, do not create categories if the user is blocked. NewUserMessage: Fix fatal error when username is invalid. Instead, do nothing. Comment: If this code has any chance of being executed during web requests, it needs zero as second parameter to Article constructor. $article = new Article( $title ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92138]: New comment added
User SPQRobin posted a comment on MediaWiki.r92138. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92138#c19581 Commit summary: InputBox: * instead of checking each namespace if it is given through the parameter, check each given namespace if it is a valid one * this fixes the inconsistency where 2 namespaces are given but only 1 is valid and that one is shown (normally if there is only 1 given, it is hidden) * fix bug 22591 (Allow i18n of Main namespace search option label) * allow namespace aliases as well * also trim the given namespaces, so spaces do not make them invalid Comment: This has always been Main without brackets in InputBox... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91869]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r91869. Old Status: resolved New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r91869. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c19582 Commit summary: use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757 Comment: Not sure if it was introduced in this revision but now I get the tab name as tooltip when hovering preferences. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90186]: New comment added
User Schnark posted a comment on MediaWiki.r90186. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90186#c19583 Commit summary: Minor fixed in ext.vector.simpleSearch * Aliasing jQuery to $ locally instead of implying global * Don't use != for length comparison, it's loose (may cast to boolean instead of numeral, 0 == false) and slower than a strict comparison. * size() is the same number of characters than .length and returns exactly the same, saves a function call * $.isArray does not return boolean as in PHP, it's a jQuery function to account for browser compatibility (ie. indexOf), returns -1 if not found. * Removed mouseover/focus per r89950 CR * Replaced spaces with tabs * Passes JSHint Comment: code$.isArray/code does return a boolean, it's code$.inArray/code that returns an index, but this function isn't used here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Fomafix posted a comment on MediaWiki.r92054.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19584
Commit summary:
Render category links as an HTML list. Bug 12261. Based on patch by Thana
Bergi. It's removing the textual pipe separator, wrapping the links inside li
elements and adding a left 1px border as separator. This makes it much easier
to manipulate the list via JS or CSS and is also semantically correct
Comment:
The space in code{$pop} {$embed}/code must be removed, because it is
rendered as codenowiki/li li/nowiki/code. This space is visible and
shifts the separator border out of the middle between the two words.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92151]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92151. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92151#c19586 Commit summary: AjaxCategories: * Restructuring to allow both private and public functions/objects. * Add an error when category alread present, instead of quitting silently. * Add documentation to most functions. * Remove hardcoded api.php (Thanks Krinkle) Ping r92062 Comment: Shouldn't there be '''e'' in function _makeCaseInsensitiv. +'ajax-category-already-present' = 'This page already has the category you specified.', Can you make this to say This page already belongs to the category $1. This looks like a very nice feature. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92151]: New comment added
User DieBuche posted a comment on MediaWiki.r92151. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92151#c19587 Commit summary: AjaxCategories: * Restructuring to allow both private and public functions/objects. * Add an error when category alread present, instead of quitting silently. * Add documentation to most functions. * Remove hardcoded api.php (Thanks Krinkle) Ping r92062 Comment: Sure. mw.msg() can replace dollar sign placeholders. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Fomafix posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c19588 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: The style definition for printing is missing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91869]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r91869. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r91869. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c19589 Commit summary: use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757 Comment: r92155 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91869]: Revision status changed
User DieBuche changed the status of MediaWiki.r91869. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c0 Commit summary: use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User DieBuche posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19590 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: EditWatchlist is fixed in r92156 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91871]: Revision status changed
User DieBuche changed the status of MediaWiki.r91871. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c0 Commit summary: Add action-* class to body. Bug 4438. Based on patch by Subfader ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19591 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: That is a hack only for EditWatchlist, while the syntax code$request-getVal( 'action', $par )/code is used on a lot of (special) pages, so this commit should be fixed so that it works again everywhere (and r92156 is not necessary). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19592 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: In other words, it is/was expected that the action is empty when it is actually view. Another observation due to this commit: Going to Special:Random redirects you to a page with the action=view in the URL, which was not the case before this commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92003]: Revision status changed
User Reedy changed the status of MediaWiki.r92003. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92003#c0 Commit summary: switching normalization ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92151]: New comment added
User DieBuche posted a comment on MediaWiki.r92151. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92151#c19593 Commit summary: AjaxCategories: * Restructuring to allow both private and public functions/objects. * Add an error when category alread present, instead of quitting silently. * Add documentation to most functions. * Remove hardcoded api.php (Thanks Krinkle) Ping r92062 Comment: Both done in r92159 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] special:export question
Hi folks,
Any special:export experts out there?
I'm trying to download the complete revision history for just a few
pages. The options, as I see it, are using the API or special:export.
The API returns XML that is formatted differently than special:export
and I already have a set of parsers that work with special:export data
so I'm inclined to go with that.
I am running into the problem that, it seems when I try to use POST so
that I can iteratively grab revisions in increments of 1000, I am
denied (I get a WMF servers down error). If I use GET, it works, but
then I can't use the parameters that allow me to iterate through all
the revisions.
Code pasted below. Any suggestions as to why the server won't accept POST?
Better yet, does anyone already have a working script/tool handy that
grabs all the revisions of a page? :)
Thanks, all! (Excuse the cross posting, I usually hang out on
research, but thought perhaps folks on the developers list would have
insight.)
Andrea
class Wikipedia {
public function __construct(){ }
public function searchResults( $pageTitle = null, $initialRevision =
null ) {
$url =
http://en.wikipedia.org/w/index.php?title=Special:Exportpages=;
. $pageTitle . offset=1limit=1000action=submit;
$curl = curl_init();
curl_setopt( $curl, CURLOPT_URL, $url );
curl_setopt( $curl, CURLOPT_RETURNTRANSFER, 1 );
curl_setopt( $curl, CURLOPT_POST, true);
curl_setopt( $curl, CURLOPT_USERAGENT, Page Revisions Retrieval
Script - Andrea Forte - afo...@drexel.edu);
$result = curl_exec( $curl );
curl_close( $curl );
return $result;
}
}
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Distinguishing normal categories from categories added through transcluded templates
Hi folks
I've been working on bringing back AjaxCategories the last two days (r92112 and
followups, try it out by setting $wgUseAJAXCategories = true;
Obviously it can't edit or remove transcluded categories, so it would be good
to not show the edit buttons on transcluded categories.
Question is, how could I get those? Anyone got an idea?
( I could do something like
$templatesCache = $holders-parent-mTplExpandCache;
foreach ( $templatesCache as $template ) {
$strp = strpos($template, $line);
if ( $strp ) break;
}
inside parser-replaceInternalLinks2, L1980, but that's pretty hacky not
really stable either )
Leo
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91980]: New comment added
User Duplicatebug posted a comment on MediaWiki.r91980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91980#c19594 Commit summary: Added WikiPageFactory class with newFromTitle() function Comment: What about NS_SPECIAL? Throw Exception (just in case) or create the special page? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92113]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r92113. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r92113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92113#c19595 Commit summary: Unit tests for jquery.localize (Follow-up r92069) Also fixing a bug in jquery.localize. Previously it did mw.msg(key, [p1, p2, ...]); (passing an array as second argument), however mw.msg doesn't take an array as second argument, instead the second argument is the first in a list of optional variadic arguments. (like mw.msg(key, p1, p2, ..); In cases were only 1 variable is passed, this didn't brake the test as [p1].toString() === p1. Fixing by using .apply instead and creating an array of arguments, starting with the key (unshifted) and if available adding parameters. All these tests appear to be broken in Gecko-browsers because it uses a different attribute order (WebKit moslty in order of touch, Gecko mostly alphabetical, Trident/Presto engine different too). They are reported because the elements are compared as strings. I'll fix this in a better way when I think of one (soon!) Comment: test failures on gecko, IE, opera ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92125]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r92125. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r92125. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92125#c19596 Commit summary: Fix broken test introduced in r92113 for Gecko-browsers. - Checking text() and attr() separately instead of comparing the resulting HTML (which was problematic due to browsers putting attributes in a different order) Comment: tests still broken in ie 6/7/8 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92126]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r92126.
Old Status: new
New Status: fixme
User Brion VIBBER also posted a comment on MediaWiki.r92126.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92126#c19597
Commit summary:
Fixes for jquery.localize unit test IE6,IE7,IE8:
- localize doesn't offically support self modification, only for children via
find(). Which is why most were wrapped in a div (otherwise
find('[title-msg]') won't find it). Now adding a div around the others as
well to be consistent, and hopefully fix the breakage on testswarm in IE6-8
Comment:
Still broken as of r92167 -- http://toolserver.org/~krinkle/testswarm/job/221/
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91980]: New comment added
User Duplicatebug posted a comment on MediaWiki.r91980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91980#c19598 Commit summary: Added WikiPageFactory class with newFromTitle() function Comment: Handled with r92169 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92124]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r92124. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92124#c19599 Commit summary: (bug 26360) $wgSessionHandler was overriding system settings unconditionally. Regression I introduced a little over 2 years ago with r49370. Comment: r49370 preserved the previous behavior by default (force the setting to 'files' unless we're using $wgSessionsInMemcached) which had been deliberately selected several years ago, so I don't see how it was a regression. (We chose to force it to 'files' because there were complaints of some servers where the setting got left at something utterly bizarre by some other app. This may not be a current issue.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92124]: New comment added
User ^demon posted a comment on MediaWiki.r92124. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92124#c19600 Commit summary: (bug 26360) $wgSessionHandler was overriding system settings unconditionally. Regression I introduced a little over 2 years ago with r49370. Comment: Right now if you don't use $wgSessionsInMemcached, but you have session_handler set, we're overriding your current session_handler with 'files.' This is not correct for setups that have a perfectly fine session_handler setup already. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92086]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r92086. Old Status: fixme New Status: new User Raymond also posted a comment on MediaWiki.r92086. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92086#c19601 Commit summary: some work on adding KML support to googlemaps v3 Comment: No idea what changed since yesterday but the error does not longer occur on Translatewiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92174]: New comment added
User IAlex posted a comment on MediaWiki.r92174. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92174#c19602 Commit summary: Fix PHP notice undefined index Comment: Parenthesis are not needed tt;)/tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Protocol-relative URLs enabled on test.wikipedia.org
Over the past couple days Roan Kattouw and I have been pushing out changes to enable protocol-relative URL support. We've gotten to a point where we think it is stable and working. We've enabled this on test.wikipedia.org, and plan on running it for two weeks before enabling it elsewhere. Please test if everything is working properly, especially with regards to the API and bots. Report bugs in bugzilla if any are found. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] special:export question
On Thu, Jul 14, 2011 at 6:58 PM, Andrea Forte andrea.fo...@gmail.com wrote: I'm trying to download the complete revision history for just a few pages. The options, as I see it, are using the API or special:export. The API returns XML that is formatted differently than special:export and I already have a set of parsers that work with special:export data so I'm inclined to go with that. You can use api.php?action=queryexportexportnowraptitles=Foo|Bar|Baz , that should give you the same format. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Wiki-research-l] special:export question
Andrea Forte, 14/07/2011 18:58: Better yet, does anyone already have a working script/tool handy that grabs all the revisions of a page? :) There's https://code.google.com/p/wikiteam/ Its purpose is to download whole wikis, but you can always edit the titles list. Nemo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92170]: Revision status changed
User Hashar changed the status of MediaWiki.r92170. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92170#c0 Commit summary: Passing actual offsets to render functions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92181]: New comment added
User Hashar posted a comment on MediaWiki.r92181. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92181#c19603 Commit summary: svn:eol-style native Comment: no functional change ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92183]: Revision status changed
User ^demon changed the status of MediaWiki.r92183. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92183#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-07-14 19:30:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92145]: Revision status changed
User ^demon changed the status of MediaWiki.r92145. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92145#c0 Commit summary: userinfo for benedikt Kämpgen ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92139]: Revision status changed
User ^demon changed the status of MediaWiki.r92139. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92139#c0 Commit summary: r92138: bump version (and update @version) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92181]: Revision status changed
User ^demon changed the status of MediaWiki.r92181. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92181#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92186]: New comment added
User Raymond posted a comment on MediaWiki.r92186. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92186#c19604 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-14 19:36:00 UTC) Ping r92057: Full export of core and ext-installer Comment: Strike the ping. cp error from yesterday. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92186]: Revision status changed
User Meno25 changed the status of MediaWiki.r92186. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92186#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-14 19:36:00 UTC) Ping r92057: Full export of core and ext-installer ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92113]: New comment added
User Krinkle posted a comment on MediaWiki.r92113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92113#c19605 Commit summary: Unit tests for jquery.localize (Follow-up r92069) Also fixing a bug in jquery.localize. Previously it did mw.msg(key, [p1, p2, ...]); (passing an array as second argument), however mw.msg doesn't take an array as second argument, instead the second argument is the first in a list of optional variadic arguments. (like mw.msg(key, p1, p2, ..); In cases were only 1 variable is passed, this didn't brake the test as [p1].toString() === p1. Fixing by using .apply instead and creating an array of arguments, starting with the key (unshifted) and if available adding parameters. All these tests appear to be broken in Gecko-browsers because it uses a different attribute order (WebKit moslty in order of touch, Gecko mostly alphabetical, Trident/Presto engine different too). They are reported because the elements are compared as strings. I'll fix this in a better way when I think of one (soon!) Comment: Gecko (and opera) fixed in r92125 as seen [http://toolserver.org/~krinkle/testswarm/user/MediaWiki here] , between [http://toolserver.org/~krinkle/testswarm/job/213/ 213] and [http://toolserver.org/~krinkle/testswarm/job/214/ 214]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92125]: New comment added
User Krinkle posted a comment on MediaWiki.r92125. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92125#c19606 Commit summary: Fix broken test introduced in r92113 for Gecko-browsers. - Checking text() and attr() separately instead of comparing the resulting HTML (which was problematic due to browsers putting attributes in a different order) Comment: in those browsers it's not returning anything at all (not a wrong response, but none at all) in those browsers. something is going wrong in the unit test. I've tried a dozen different things, I'm missing something... For example, check [http://toolserver.org/~krinkle/testswarm/?state=runresultsrun_id=1820client_id=3364 the result in IE8], it's getting an empty string ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90186]: New comment added
User Krinkle posted a comment on MediaWiki.r90186. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90186#c19607 Commit summary: Minor fixed in ext.vector.simpleSearch * Aliasing jQuery to $ locally instead of implying global * Don't use != for length comparison, it's loose (may cast to boolean instead of numeral, 0 == false) and slower than a strict comparison. * size() is the same number of characters than .length and returns exactly the same, saves a function call * $.isArray does not return boolean as in PHP, it's a jQuery function to account for browser compatibility (ie. indexOf), returns -1 if not found. * Removed mouseover/focus per r89950 CR * Replaced spaces with tabs * Passes JSHint Comment: Thanks, must've read too quickly. Fixed in r92190. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92044]: New comment added
User Catrope posted a comment on MediaWiki.r92044. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92044#c19608 Commit summary: Per wikitech-l, run a bunch of URLs in the API output through wfExpandUrl(), so they become fully-qualified even if they were originally protocol-relative Comment: getFullUrl(), currently, will return a fully qualified URL if $wgServer is fully qualified, and a protocol-relative one if $wgServer is protocol-relative. I did it this way because 1) that's what getFullUrl() does right now and 2) there are more places that need protrel URLs than fq ones (fq is an exception that you only need in very specific cases). I could change the behavior of the Title functions to be as you say, then change almost every call to getFullUrl() to getRelativeUrl(), but I don't really see what would be the benefit of that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Distinguishing normal categories from categories added through transcluded templates
2011/7/14 Leo Koppelkamm diebu...@gmail.com:
( I could do something like
$templatesCache = $holders-parent-mTplExpandCache;
foreach ( $templatesCache as $template ) {
$strp = strpos($template, $line);
if ( $strp ) break;
}
inside parser-replaceInternalLinks2, L1980, but that's pretty hacky not
really stable either )
$parser-mTplExpandCache holds only the text of template calls without
parameters ( eg. {{Foo}} but not {{bar|x|y}} ), so it won't help you
much. You could do a separate parse of the article text while skipping
the preprocessor. This should give you only the categories that are
linked directly from the page. Of course for normal page views this
would probably be too expensive, so maybe an API module that you call
via AJAX?
HTH,
Paul Copperman
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90503]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90503. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90503#c0 Commit summary: setting up new tab for CentralNotice logs - no logs to actually display yet ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90663]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90663. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90663#c0 Commit summary: adding campaign to allocation table ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90665]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90665. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90665#c0 Commit summary: adding log placeholder for now ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90690]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90690. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90690#c0 Commit summary: adding sql patch file for upcoming campaign logs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90739]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90739. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90739#c0 Commit summary: more specific table name - will have other log tables later ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90896]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90896. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90896#c0 Commit summary: logging for campaign creation and removal ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91517]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91517. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91517#c0 Commit summary: Support for logging campaign modifications. Right now only works via listNoticeDetail method (Edit Campaign interface). Need to add support for logging campaign changes from Manage Campaigns interface as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91522]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r91522. Old Status: new New Status: fixme User Awjrichards also posted a comment on MediaWiki.r91522. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91522#c19609 Commit summary: CentralNotice settings log - adding projects, languages, and countries Comment: With your static methods, be sure you're calling them as static methods elsewhere in code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91522]: New comment added
User ^demon posted a comment on MediaWiki.r91522. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91522#c19610 Commit summary: CentralNotice settings log - adding projects, languages, and countries Comment: It looks nicer yes, but isn't required :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91617]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91617. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91617#c0 Commit summary: moving DB function into DB class and giving functions more logical names ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91670]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91670. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91670#c0 Commit summary: Beginning to add logging for campaign setting changes. Better logic for handling different requests - fixes bug where settings could not be changed at the same time as deleting a campaign ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91695]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91695. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91695#c0 Commit summary: Consolidate boolean campaign setting methods. Log the campaign setting changes from the Manage Campaigns interface. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91707]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91707. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91707#c0 Commit summary: storing campaign name differently in logs, beginning output to Logs tab, fixing issues with campaign deletion ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91709]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91709. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91709#c0 Commit summary: consolidate log output, order logs by timestamp ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91801]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91801. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91801#c0 Commit summary: setting up pagination for the campaign logs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91806]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91806. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91806#c0 Commit summary: adding links to campaign logs, tweaking log layout ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91936]: Revision status changed
User Awjrichards changed the status of MediaWiki.r91936. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91936#c0 Commit summary: follow-up to r91695, fixing wrong campaign ID bug ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r92037. Old Status: new New Status: ok User Awjrichards also posted a comment on MediaWiki.r92037. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19611 Commit summary: output campaign log details Comment: You might consider un-hardcoding styling in showInitialSettings() and showChanges() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92038]: Revision status changed
User Awjrichards changed the status of MediaWiki.r92038. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92038#c0 Commit summary: adding schema updating code for campaign log table ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92042]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r92042. Old Status: new New Status: fixme User Awjrichards also posted a comment on MediaWiki.r92042. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92042#c19612 Commit summary: adding direct link to user talk page from log entries Comment: marking fixme to remind kaldari to dbl check with i18n guys about the link generation/punctuation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92194]: Revision status changed
User Awjrichards changed the status of MediaWiki.r92194. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92194#c0 Commit summary: updating schema, no longer recording separate campaign name settings since this never changes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92196]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r92196. Old Status: new New Status: ok User Awjrichards also posted a comment on MediaWiki.r92196. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92196#c19613 Commit summary: checking in collapse arrows Comment: Possible to pull these images from elsewhere eg core? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92042]: New comment added
User Kaldari posted a comment on MediaWiki.r92042. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92042#c19614 Commit summary: adding direct link to user talk page from log entries Comment: fixed in r92212 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91522]: New comment added
User Kaldari posted a comment on MediaWiki.r91522. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91522#c19615 Commit summary: CentralNotice settings log - adding projects, languages, and countries Comment: Fixed anyway in r92214. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92201]: New comment added
User Reedy posted a comment on MediaWiki.r92201. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92201#c19616 Commit summary: Commit Special:MoodBar, shows feedback in a rudimentary way. Copy and modify from SpecialCommunityApplications.php Comment: Bad werdna Fix your autoprops ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] The final stretch for 1.18 code review
Hi everyone, Thanks to the heroic efforts of many folks here, we're down to a manageable number of revisions. See the newly repaired chart here: http://toolserver.org/~robla/crstats/crstats.118all.html Now that we've got a small enough list, I'm reviving the revision report for 1.18, which is a list of all of the revisions remaining for review, broken down by preferred reviewer. That's available here: http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report This also has fixmes, broken down by the committer. Revisions with the following tags will be excluded from this report: * nodeploy - won't ever affect deployment (e.g. installer) * 1.18revert - reverted from the 1.18 branch * 1.18ok - still needs a full review, but we'll let it slide for this deployment These tags roughly map onto what we used for 1.17, though not exactly. During that deploy cycle, it was far, far more important to choose our battles to have any hope of getting done soon, whereas now, we know we want to get through everything anyway. So, you should feel a tinge of guilt using these tags. :) These are manually generated (currently by me, but Hexmode took over last time, and I wouldn't be surprised if he does it again). Let me know if there's anything obviously wrong with the list. Otherwise, we're all looking forward to seeing this list shrink to zero! Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r80116]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r80116.
Old Status: ok
New Status: fixme
User Brion VIBBER also posted a comment on MediaWiki.r80116.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80116#c19618
Commit summary:
Fixed IE bug, you must use html:msg for the msg elements that jquery.localize
uses to translate things otherwise IE chokes when you insert them cause it
doesn't know about the msg element.
Comment:
The find('msg,html\\:msg') doesn't appear to work in IE 8 -- it finds neither
'msg' nor 'html:msg' bits for me when running the tests in r92113, r92126
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92113]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r92113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92113#c19619 Commit summary: Unit tests for jquery.localize (Follow-up r92069) Also fixing a bug in jquery.localize. Previously it did mw.msg(key, [p1, p2, ...]); (passing an array as second argument), however mw.msg doesn't take an array as second argument, instead the second argument is the first in a list of optional variadic arguments. (like mw.msg(key, p1, p2, ..); In cases were only 1 variable is passed, this didn't brake the test as [p1].toString() === p1. Fixing by using .apply instead and creating an array of arguments, starting with the key (unshifted) and if available adding parameters. All these tests appear to be broken in Gecko-browsers because it uses a different attribute order (WebKit moslty in order of touch, Gecko mostly alphabetical, Trident/Presto engine different too). They are reported because the elements are compared as strings. I'll fix this in a better way when I think of one (soon!) Comment: For IE tests see my comment on r80116 -- the selector doesn't seem to work on IE 8 (maybe this regresed from older jquery versions in use at the time?) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added
User Kaldari posted a comment on MediaWiki.r92037. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19620 Commit summary: output campaign log details Comment: Done in r92224. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81396]: Revision status changed
User ^demon changed the status of MediaWiki.r81396. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81396#c0 Commit summary: * recover dropped check of $wgUsePathInfo from r81363 * document getPathInfo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91385]: Revision status changed
User Catrope changed the status of MediaWiki.r91385. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91385#c0 Commit summary: Follow up to r91349 Missed adding quotes to two of the [rel=] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91388]: Revision status changed
User Catrope changed the status of MediaWiki.r91388. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91388#c0 Commit summary: Fix for the broken tests introduced in r91387. Check input before assuming there are no arguments and the values object is expected. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91754]: Revision status changed
User Catrope changed the status of MediaWiki.r91754. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91754#c0 Commit summary: redoing r91673 . I need to commit in two steps to preserve the file's history ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91672]: Revision status changed
User Catrope changed the status of MediaWiki.r91672. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91672#c0 Commit summary: r74966: Deleting unused rtl.css ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92187]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r92187.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r92187.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92187#c19621
Commit summary:
Various cleanups to ExternalEdit. Documentation, code style, removed some
unused variables, removed silly 'm' prefix, etc.
Comment:
pre
+ public function __construct( $title, $mode ) {
+ $this-title = $article-getTitle();
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92213]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92213. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92213#c19622 Commit summary: properly handle the case where a file disappears during the uploadwizard process remove database records for files that move out of the stash Comment: xdebug_break? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
