[MediaWiki-CodeReview] [MediaWiki r97161]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97161. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97161 Commit summary: Implement DerivativeContext. Can be used to inherit context from another context while overriding only parts of the context. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97207]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97207. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97207#c22640 Commit summary: RevisionDeleter::getChanges() documentation cleanup Comment: I didn't change anything about third arg. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97216]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97216. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97216#c22641 Commit summary: Added new hook, 'SIOHandler::updateData', from patch by Keith Fligg Comment: Not that I am aware of. I just added first hook to Translate extension myself and wondered the same thing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97233]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97233. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97233#c22642 Commit summary: Since I accidentally committed most of it in r97232, commit my formatter API module Comment: for return __CLASS__ . ': $Id: ApiLqtForm.php 79941 2011-01-10 17:18:57Z hartman $'; svn pg svn:keywords includes/api/ApiQueryBase.php Id ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97203]: Revision status changed
User Hashar changed the status of MediaWiki.r97203. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97203 Commit summary: New hook RecentChangesListRecentChangesLine which let you customize an entire recent changes line for user with 'Enhanced recent changes' option It is equivalent to the existing hook OldChangesListRecentChangesLine Reported by finlay on IRC. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97207]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97207. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97207 Commit summary: RevisionDeleter::getChanges() documentation cleanup ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97234]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97234. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97234 Commit summary: Fix naming ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table (discussing r94289)
RE: http://www.mediawiki.org/wiki/Requests_for_comment/Database_field_for_checksum_of_page_text#Field_type Recently, Adding MD5 / SHA1 column to revision table (discussing r94289) was discussed. For some applications, I use the technique of representing the 128 bit of md5 or other checksums as base-62 character strings instead of hexadecimal (base-16) strings. When you need a non-binary, i.e. character representation for displaying, storing or transmitting checksums, you should always consider to use base-62 instead of base-16 representations (for md5 you need 22 bytes instead of 32 bytes). When you encode the 128 bits of MD5 (example) in base-16 aka /hexadecimal/, you need CHAR(32). When you use the technique of enoding the 128 bits in /base-62/ with characters from [A-Za-z0-9], you'll need CHAR(22). See http://de.php.net/manual/en/function.md5.php#83321 for one possible implementation. I found this for example first in Microsofts free FCIV program which creates checksum xml files and uses this shorter representation. signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97241]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97241. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r97241. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97241#c22645 Commit summary: Fix typo Comment: Any particular reason to use fullURL instead of localURL? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97235]: New comment added
User Akshay.agarwal posted a comment on MediaWiki.r97235. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97235#c22646 Commit summary: removed duplicate declaration of '' on line 31 Comment: oops, will use \ from now ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97240]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97240. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97240 Commit summary: Improve r97239 with comments from Aaron. Also fixed another typo that was lurking there. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97239]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97239. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97239 Commit summary: * Fixed indentation * Fixed assumption about message keys that was no longer true * Ping r97207 * Clarified the part about null ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97212]: Revision status changed
User ^demon changed the status of MediaWiki.r97212. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97212 Commit summary: * Added es.Html (the final resting place for HTML generation functions * Moved serializers that we needed for models to views, since we really just need them for off-screen rendering purposes (like for table measurements) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Upcoming MediaWiki 1.18 deployment
2011/9/16 Rob Lanphier ro...@wikimedia.org Hi folks, I just wanted to quickly highlight the plan that we have for deploying MediaWiki 1.18 to the Wikimedia sites: * Monday, September 19 (-20), 23:00-01:00 UTC (4pm-6pm PDT): MediaWiki 1.18 deployment to test2 * Wednesday, September 21 (-22), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 1 deployment (simplewiki, simplewiktionary, usabilitywiki, strategywiki, mediawikiwiki, hewikisource) Yesh! Good to see hewikisource in the default list. And mediawikiwiki should be a good early testbed for Robin's directionality fixes, thanks to the crazy things in the Code Review extension. Will Commons be upgraded with the remaining wikis? I expect the biggest (and positive) influence of these fixes in Commons, but i also expect some issues at first, because of the Rtl.css and Rtl.js customization there. If all is well, these two files should probably be deleted, but the transition may be a bit rocky at first. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97239]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r97239. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r97239. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97239#c22643 Commit summary: * Fixed indentation * Fixed assumption about message keys that was no longer true * Ping r97207 * Clarified the part about null Comment: Maybe 'keys in 0 and 1' could read 'keys in $arr[0] and $arr[1]'. Also, typo in 'they keys respectively' :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97235]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97235. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r97235. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97235#c22644 Commit summary: removed duplicate declaration of '' on line 31 Comment: The global $wgRequest; is in a bit weird place now. And svn ci -m is evil :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] (no subject)
a tabindex=1 title= name=qniclbchps href=http://sellmydiamonds.com/administrator/components/com_rsform/tmp/arccre.htm;http://sellmydiamonds.com/administrator/components/com_rsform/tmp/arccre.htm/a ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97241]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97241. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97241#c22648 Commit summary: Fix typo Comment: Latter does not have problems with choosing the correct protocol :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97238]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97238. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97238 Commit summary: revert r97203 That code was not really meant to work :-D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Wikimania tech presentations: ResourceLoader, testing more
Hi folks, just a heads up in case you've missed it -- Wikimedia Israel has started posting more and more videos from Wikimania 2011 in their YouTube channel. Relevant overall link: http://youtube.com/user/WikimediaIL Here are a few quick links to some of the tech presentations that have gone up, for convenience: 1) Roan's and Timo's ResourceLoader presentation: http://www.youtube.com/watch?v=Cc8quyp2XBA#t=986s 2) Markus Glaser's presentation about testing: http://www.youtube.com/watch?v=PEUI9sBii9Y#t=2045s 3) Diederik/Dario/Ryan's panel about Wikipedia/MediaWiki as a platform (OAuth, Wikilytics): http://www.youtube.com/watch?v=Cc8quyp2XBA#t=2314s 4) Guillaume's presentation regarding a Qt library for MediaWiki: http://www.youtube.com/watch?v=Cc8quyp2XBA#t=3227s Hopefully we'll have all these and more on Commons soon as well :) Cheers, Erik -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97229]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97229. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97229#c22649 Commit summary: match changes in SMW Comment: pre - $params = $this-parameters; + $params = $this-m_params; /pre This looks wrong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97223]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97223. Old Status: deferred New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r97223. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97223#c22650 Commit summary: changing param handling to happen on query processor level instead of in the query printers; high risk commit, might break stuff somewhere Comment: And it did: [16-Sep-2011 07:48:32] PHP Notice: Undefined index: mappingservice in /www/w/extensions/Maps/includes/manipulations/Maps_ParamGeoService.php on line 53 [16-Sep-2011 07:48:32] PHP Fatal error: Call to a member function getValue() on a non-object in /www/w/extensions/Maps/includes/manipulations/Maps_ParamGeoService.php on line 53 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97241]: New comment added
User Werdna posted a comment on MediaWiki.r97241. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97241#c22647 Commit summary: Fix typo Comment: Not really, is there a preference for the latter? I guess it works better for different domains etc… ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97242]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97242. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97242 Commit summary: svn:keywords -- Id for api modules ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97227]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97227. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97227 Commit summary: fix to table format; I failed - difference is because of wikitext vs html, not MW version ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97096]: New comment added
User Purodha posted a comment on MediaWiki.r97096. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97096#c22651 Commit summary: Typo fixed in message text of MediaWiki:logentry-suppress-delete see http://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-suppress-delete/en Comment: Yes, here it is: Additional namespace name aliases for ksh, mainly genderized user ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table (discussing r94289)
On Fri, Sep 16, 2011 at 8:15 AM, Thomas Gries m...@tgries.de wrote: For some applications, I use the technique of representing the 128 bit of md5 or other checksums as base-62 character strings instead of hexadecimal (base-16) strings. MediaWiki already uses a similar technique, storing SHA-1 hashes of images in base 36. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97241]: New comment added
User Catrope posted a comment on MediaWiki.r97241. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97241#c22652 Commit summary: Fix typo Comment: How does getFullURL() have protocol choosing issues? It'll just use the protocol from $wgServer (which might mean none, if $wgServer is protocol-relative). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97233]: New comment added
User Catrope posted a comment on MediaWiki.r97233. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97233#c22653 Commit summary: Since I accidentally committed most of it in r97232, commit my formatter API module Comment: It means you need to do codesvn propset svn:keywords Id ApiLqtFormatter.php/code in order for code$Id$/code to work. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97096]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97096. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97096#c22654 Commit summary: Typo fixed in message text of MediaWiki:logentry-suppress-delete see http://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-suppress-delete/en Comment: But you didn't add $namespaceGenderAliases? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97253]: Revision status changed
User Hashar changed the status of MediaWiki.r97253. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97253 Commit summary: Fix indenting of a couple of braces ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97229]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r97229. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97229#c22655 Commit summary: match changes in SMW Comment: It's correct. parameters is a field in the deriving class that was being used instead of m_params defined in the base class. Now this is no longer the case. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97223]: New comment added, and revision status changed
User Jeroen De Dauw changed the status of MediaWiki.r97223. Old Status: fixme New Status: new User Jeroen De Dauw also posted a comment on MediaWiki.r97223. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97223#c22656 Commit summary: changing param handling to happen on query processor level instead of in the query printers; high risk commit, might break stuff somewhere Comment: Should be fixed by follow up :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97252]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97252 Commit summary: Fix svn:eol-style native from r97250 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97229]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97229. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97229#c22657 Commit summary: match changes in SMW Comment: Why is there $protected parameters; declaration then? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97229]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r97229. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97229#c22658 Commit summary: match changes in SMW Comment: Because I forgot to remove it, it's gone now though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Upcoming MediaWiki 1.18 deployment
Message: 4 Date: Thu, 15 Sep 2011 16:30:44 -0700 From: Rob Lanphier ro...@wikimedia.org Subject: [Wikitech-l] Upcoming MediaWiki 1.18 deployment To: Wikimedia developers wikitech-l@lists.wikimedia.org Message-ID: capzpxh6lujpb0rn6k9ngkqma2aipwf_x7cshu5s5d-f8+7b...@mail.gmail.com Content-Type: text/plain; charset=ISO-8859-1 Hi folks, I just wanted to quickly highlight the plan that we have for deploying MediaWiki 1.18 to the Wikimedia sites: * Monday, September 19 (-20), 23:00-01:00 UTC (4pm-6pm PDT): MediaWiki 1.18 deployment to test2 * Wednesday, September 21 (-22), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 1 deployment (simplewiki, simplewiktionary, usabilitywiki, strategywiki, mediawikiwiki, hewikisource) * Monday, September 26 (-27), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 2 deployment (metawiki, enwikiquote, enwikibooks, betawikiversity, eowiki, nlwiki) * Tuesday, October 4 (-5), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 3 deployment (remaining wikis) More about MediaWiki 1.18 can be found here: http://www.mediawiki.org/wiki/MediaWiki_1.18 The main blocker right now? Code review: http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report See Mark's email earlier today for more detail on this. Please chip in where you can. Thanks! Rob btw, could refreshImageMetadata.php be run on wmf wikis some time after the deployment? 1.18 contains lots of new code related to Exif support (and related image metadata stuff). The maintenance script just regenerates img_metadata based on the source image. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Upcoming MediaWiki 1.18 deployment
Hey, Are you going to set some test wikis on prototype cluster? - I would be interested in Polish version of wiki. Regards, Daniel // Leinad 2011/9/16 Rob Lanphier ro...@wikimedia.org: Hi folks, I just wanted to quickly highlight the plan that we have for deploying MediaWiki 1.18 to the Wikimedia sites: * Monday, September 19 (-20), 23:00-01:00 UTC (4pm-6pm PDT): MediaWiki 1.18 deployment to test2 * Wednesday, September 21 (-22), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 1 deployment (simplewiki, simplewiktionary, usabilitywiki, strategywiki, mediawikiwiki, hewikisource) * Monday, September 26 (-27), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 2 deployment (metawiki, enwikiquote, enwikibooks, betawikiversity, eowiki, nlwiki) * Tuesday, October 4 (-5), 23:00-03:00 UTC (4pm-8pm PDT): MediaWiki 1.18 stage 3 deployment (remaining wikis) More about MediaWiki 1.18 can be found here: http://www.mediawiki.org/wiki/MediaWiki_1.18 The main blocker right now? Code review: http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report See Mark's email earlier today for more detail on this. Please chip in where you can. Thanks! Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97034]: New comment added
User Thelema314 posted a comment on MediaWiki.r97034. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97034#c22659 Commit summary: * (bug 6722) Spacing fixes for math functions with/without parens * (bug 18912) Add math support for \sen Spanish variant of \sin * (bug 18912) Fix spacing for \operatorname in math Reapplies r86962, r87117, r87936, r87941 plus some parser tests. Note that further batch testing to identify any other potential problems due to the spacing tweaks is a good idea! Comment: This patch looks like it puts together a bunch of pieces from previous patches. I assume they're all there. They look correctly applied. I'm a bit surprised at the removal of braces around TEX_FUN1, but if it works, I guess it's okay. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86735]: New comment added
User Sumanah posted a comment on MediaWiki.r86735.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86735#c22660
Commit summary:
Followup to r86312
ialex Reedy: that rev is breaking usage of {{PAGENAME}} in messages, such as
in MediaWiki:Noarticles
Allowing optional passing in of a Title object (like it may be set in Message),
but if it's not set, or not a title object, fall back and use $wgTitle (I'm
sorry!)
Comment:
From Reedy in IRC just now:
: http://pastebin.com/fvKdKtEG Tim suggested a 1 line diff of code, but the
code he suggested to change doesn't actually exist as it stands..
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97145]: New comment added, and revision status changed
User MarkAHershberger changed the status of MediaWiki.r97145. Old Status: new New Status: ok User MarkAHershberger also posted a comment on MediaWiki.r97145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97145#c22661 Commit summary: Reverted r85922 and related: new doTableStuff(). I copied in the old doTableStuff() from before r85922 and reverted all parser test changes that looked vaguely related. Apologies to Platonides, since some of his parser tests appeared to be relevant to the old parser, but it's simplest to just revert all the related changes and then re-add any useful tests later. See CR r85922 for full rationale. Comment: Marking per IRC and, heck, this is a revert. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86735]: Revision status changed
User MarkAHershberger changed the status of MediaWiki.r86735.
Old Status: fixme
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86735
Commit summary:
Followup to r86312
ialex Reedy: that rev is breaking usage of {{PAGENAME}} in messages, such as
in MediaWiki:Noarticles
Allowing optional passing in of a Title object (like it may be set in Message),
but if it's not set, or not a title object, fall back and use $wgTitle (I'm
sorry!)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97273]: Revision status changed
User ^demon changed the status of MediaWiki.r97273. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97273 Commit summary: Improved display of lists of categories, and pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97277]: Revision status changed
User ^demon changed the status of MediaWiki.r97277. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97277 Commit summary: Made extension sections collapsible (and collapsed by default) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97268]: Revision status changed
User ^demon changed the status of MediaWiki.r97268. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97268 Commit summary: Typofix in variable name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97254]: Revision status changed
User ^demon changed the status of MediaWiki.r97254. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97254 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] page view stats redux
This is really cool! Thanks Ariel and team for making this available. best, Diederik On Thu, Sep 15, 2011 at 5:16 PM, MZMcBride z...@mzmcbride.com wrote: Ariel T. Glenn wrote: I think we finally have a complete copy from December 2007 through August 2011 of the pageview stats scrounged from various sources, now available on our dumps server. See http://dumps.wikimedia.org/other/pagecounts-raw/ This is a great step in the right direction! Thanks! MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- a href=http://about.me/diederik;Check out my about.me profile!/a ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] CSS Injection Vulnerabilities
Hey, We should probably consider building an interface such as `Html::element( 'div', array( 'style' = array( 'width' = $width, 'height' = $height ) ), '...' );` into core. +1; I actually didn't read this email very carefully and changed this in some extensions before realizing it's a proposed interface and not an existing one :) Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97289]: Revision status changed
User ^demon changed the status of MediaWiki.r97289. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97289 Commit summary: 1.17wmf1 Revert r96400, MFT r96560 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96400]: Revision status changed
User ^demon changed the status of MediaWiki.r96400. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400 Commit summary: Fix for total extension breakage due to protocol relative URLs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97150]: New comment added
User Dantman posted a comment on MediaWiki.r97150. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97150#c22662 Commit summary: Update jquery.tablesorter for r97145: emulate thead if there is no thead in the HTML, by walking down the table starting at the first row and moving rows to the thead as long as all of its cells are ths (or the row is empty). Also fix and simplify the sortbottom code, which was incorrectly creating multiple tfoot elements if there were multiple sortbottom rows. Comment: code$(this).find( 'td' ).length 0/code using `$(this).children( 'td' ).length 0` would be more efficient and also avoid any bugs where a th in the first row had a table or whatnot. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96400]: Revision status changed
User Reedy changed the status of MediaWiki.r96400. Old Status: resolved New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400 Commit summary: Fix for total extension breakage due to protocol relative URLs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97150]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r97150.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97150#c22663
Commit summary:
Update jquery.tablesorter for r97145: emulate thead if there is no thead in
the HTML, by walking down the table starting at the first row and moving rows
to the thead as long as all of its cells are ths (or the row is empty).
Also fix and simplify the sortbottom code, which was incorrectly creating
multiple tfoot elements if there were multiple sortbottom rows.
Comment:
From IRC, Dantman says:
+ if ( $(this).find( 'td' ).length 0 ) {
Using (this).children( 'td' ).length 0 would be more efficient and also
avoid any bugs where a th in the first row had a table or whatnot.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97150]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r97150. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97150#c22664 Commit summary: Update jquery.tablesorter for r97145: emulate thead if there is no thead in the HTML, by walking down the table starting at the first row and moving rows to the thead as long as all of its cells are ths (or the row is empty). Also fix and simplify the sortbottom code, which was incorrectly creating multiple tfoot elements if there were multiple sortbottom rows. Comment: oops, should have reloaded ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97251]: Revision status changed
User ^demon changed the status of MediaWiki.r97251. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97251 Commit summary: Localization update for he. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table (discussing r94289)
Am 16.09.2011 11:24, schrieb Roan Kattouw: For some applications, I use the technique of representing the 128 bit of md5 or other checksums as base-62 character strings instead of hexadecimal (base-16) strings. MediaWiki already uses a similar technique, storing SHA-1 hashes of images in base 36. Was there a certain reason to chose base 36 ? Why not recoding to base 62 and saving 3 bytes per checksum ? base 16 = CHAR(32) md5 sum in hexadecimal base 36 = CHAR(25) base 62 = CHAR(22) using base 62 (upper and lower ASCII letters and digits) would save 3 bytes over base 36. if my calculator works correctly ;-) signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91561]: New comment added
User Reedy posted a comment on MediaWiki.r91561. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561#c22665 Commit summary: (Bug 19725) Do not include suppressed edits in the View X deleted edits message, and when doing prefix search of special:undelete. I'm not 100% sure this is the right thing to do, see the bug for the details. But basically this doesn't include an edit in the count if its text is hidden and its hidden from admins. (Not sure if it should not be included only if everything is hidden). Its also weird to show people different things depending if they have suppress rights, without really indicating that. Minor db note: This causes the query to no longer use a covering index. I don't think that matters but just thought i'd mention. p.s. The upload page show deleted edits link is broken right now, (from before) I'll fix in a follow-up. Comment: Ragh Everything but the RELEASE-NOTES conflict ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91561]: Revision status changed
User Reedy changed the status of MediaWiki.r91561. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561 Commit summary: (Bug 19725) Do not include suppressed edits in the View X deleted edits message, and when doing prefix search of special:undelete. I'm not 100% sure this is the right thing to do, see the bug for the details. But basically this doesn't include an edit in the count if its text is hidden and its hidden from admins. (Not sure if it should not be included only if everything is hidden). Its also weird to show people different things depending if they have suppress rights, without really indicating that. Minor db note: This causes the query to no longer use a covering index. I don't think that matters but just thought i'd mention. p.s. The upload page show deleted edits link is broken right now, (from before) I'll fix in a follow-up. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table (discussing r94289)
On 9/16/11 9:48 AM, Thomas Gries wrote: Am 16.09.2011 11:24, schrieb Roan Kattouw: For some applications, I use the technique of representing the 128 bit of md5 or other checksums as base-62 character strings instead of hexadecimal (base-16) strings. MediaWiki already uses a similar technique, storing SHA-1 hashes of images in base 36. Was there a certain reason to chose base 36 ? Why not recoding to base 62 and saving 3 bytes per checksum ? 11M images in commons x 3 bytes = 33MB / ~1MB per file on average = a savings equivalent to 33 more files in Commons In the time it took you to write this we probably had more than 33 files uploaded. -- Neil Kandalgaonkar (| ne...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table (discussing r94289)
On 11-09-16 09:48 AM, Thomas Gries wrote: Am 16.09.2011 11:24, schrieb Roan Kattouw: For some applications, I use the technique of representing the 128 bit of md5 or other checksums as base-62 character strings instead of hexadecimal (base-16) strings. MediaWiki already uses a similar technique, storing SHA-1 hashes of images in base 36. Was there a certain reason to chose base 36 ? Why not recoding to base 62 and saving 3 bytes per checksum ? base 16 = CHAR(32) md5 sum in hexadecimal base 36 = CHAR(25) base 62 = CHAR(22) using base 62 (upper and lower ASCII letters and digits) would save 3 bytes over base 36. if my calculator works correctly ;-) If we're picking apart checksum sizes in database storage. Why not just go all the way and store the binary data as binary with a BINARY(16) 16, 36, 62... what happened to base 64 anyways? php even has native code for that. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table (discussing r94289)
On Fri, Sep 16, 2011 at 9:48 AM, Thomas Gries m...@tgries.de wrote: Am 16.09.2011 11:24, schrieb Roan Kattouw: For some applications, I use the technique of representing the 128 bit of md5 or other checksums as base-62 character strings instead of hexadecimal (base-16) strings. MediaWiki already uses a similar technique, storing SHA-1 hashes of images in base 36. Was there a certain reason to chose base 36 ? Why not recoding to base 62 and saving 3 bytes per checksum ? This format was chosen for hashes to be used as filenames for uploaded file storage (currently used only for storing deleted files, I think, but there's long been a long-term plan to switch primary image storage to this as well some day). For greatest compatibility with all filesystems, we only use characters that are safe (ASCII digits and letters) and don't rely on case distinctions which are not always preserved (Windows and Mac OS X systems default to case-insensitive filesystems). The reason we're not using hex here is that a more compact representation makes the filenames, and thus any URL references including them in the path, shorter. On img_sha1 I guess we just kept using it for compatibility/similarity with the deleted file archives? -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97231]: Revision status changed
User Awjrichards changed the status of MediaWiki.r97231. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97231 Commit summary: Some IE6/7 fixes for testing, outside review ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97318]: New comment added
User Reedy posted a comment on MediaWiki.r97318. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97318#c22666 Commit summary: Fix extra brace Comment: Was me in r97297 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97298]: Revision status changed
User MarkAHershberger changed the status of MediaWiki.r97298. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97298 Commit summary: Amend documentation for r97296 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97323]: Revision status changed
User Reedy changed the status of MediaWiki.r97323. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97323 Commit summary: Patch to support new fr_rev_timestamp column if it either exists or not ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97311]: Revision status changed
User Awjrichards changed the status of MediaWiki.r97311. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97311 Commit summary: Changed redirect URL for IE6 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97321]: Revision status changed
User Reedy changed the status of MediaWiki.r97321. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97321 Commit summary: holy annoying type, batman ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added
User Bawolff posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22667 Commit summary: Switch JSON to (un)serialize Comment: Is there any security considerations for using unserialize like this? Its not unconcievable that the log_params for some log types could be entirely user supplied (although off hand I don't know if there are any logs that that is true for). I know that unserializing objects will call __wakeup() on them (that requires an already existing class with a __wakeup method that does something evil though). I don't really know if we have any classes where you can do evil stuff with that (or if their is other more applicable ways of doing evil with serialized objects), but it sounds kind of sketchy to test if the log_params are a serialized array by simply unserializing it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97296]: New comment added, and revision status changed
User MarkAHershberger changed the status of MediaWiki.r97296. Old Status: new New Status: fixme User MarkAHershberger also posted a comment on MediaWiki.r97296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97296#c22668 Commit summary: * (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces Comment: If I create a User:Test page and then set $wgExtraGenderNamespaces[NS_USER] = array( 'male' = 'The man', 'female' = 'The lady' ); in my LocalSettings.php and then set User:Test's gender, my User page becomes The_man:Test and no longer has any content. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22669 Commit summary: Switch JSON to (un)serialize Comment: I don't think there is any, and the hole will soon close up when logs are converted to produce new style param storage. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97296]: New comment added, and revision status changed
User MarkAHershberger changed the status of MediaWiki.r97296. Old Status: fixme New Status: ok User MarkAHershberger also posted a comment on MediaWiki.r97296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97296#c22670 Commit summary: * (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces Comment: Niklas showed me that The_man worked and The man failed. Setting $wgExtraNamespaces[NS_USER] = 'A big one' also failed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97331]: Revision status changed
User ^demon changed the status of MediaWiki.r97331. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97331 Commit summary: MFT changes from r87606 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97297]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97297. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97297 Commit summary: Revert r91561 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87606]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r87606. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87606#c22671 Commit summary: Follow-up r86179: Updated and commented out two USE INDEX statements. This *has* to be done before the schema change. The new index hints can be added after all DBs are updated. Comment: These FORCE statements were defensive and probably not really useful. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97332]: Revision status changed
User ^demon changed the status of MediaWiki.r97332. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97332 Commit summary: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22672 Commit summary: Switch JSON to (un)serialize Comment: Moar details? :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Upcoming MediaWiki 1.18 deployment
On 16/09/11 15:16, bawolff wrote: btw, could refreshImageMetadata.php be run on wmf wikis some time after the deployment? 1.18 contains lots of new code related to Exif support (and related image metadata stuff). The maintenance script just regenerates img_metadata based on the source image. Please open a bug on bugzilla.wikimedia.org against the Site requests component :-) This way we will remember about it! -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Internationalisation bug triage notes
Siebrand Mazeland wrote: https://bugzilla.wikimedia.org/show_bug.cgi?id=17865 -- Mismatched input syntax for Cite error messages * Some discussion. Cite is seen as scary! No one to take this yet. Please give this some TLC. Cite is not /that/ scary. What's TLC? I don't see the problem with those messages, though. They look like the rest of Cite errors. Just through the parser instead of the wfMsg() calls (which would have its own problems). Seems that ParserBeforeTidy is too late for doing a recursiveTagParse(). Just replacing the call to Cite::parse() of Cite::error with a call to MessageCache::singleton()-parse() looks like the best solution. We don't need to keep the parser context for errors. And now MessageCache::parse() doesn't pollute the $wgParser state. == Harder issues and discussion == https://bugzilla.wikimedia.org/show_bug.cgi?id=28428 -- Allow saving pages with LRM and RLM in titles, showing a warning and requiring a user right https://bugzilla.wikimedia.org/show_bug.cgi?id=28411 -- titles of articles with LTR titles in RTL wikis may be displayed incorrectly in categories and special pages * It looks like a schema change is not needed, and that the page_props table can and should be used. Use batches where needed; integrate that in Linker, LinkBatch and probably Title as well. Ambitious according to Roan. Roan agrees that having displaytitle as a page_ field makes more sense *conceptually*. In practice, he prefers page_props because that avoids a schema change and is still cheap. Niklas indicated the discussion gave him ideas on how to work towards resolving these issues. I agree with the idea of storing the displaytitle in page_props. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Internationalisation bug triage notes
On Fri, Sep 16, 2011 at 5:14 PM, Platonides platoni...@gmail.com wrote: Siebrand Mazeland wrote: https://bugzilla.wikimedia.org/show_bug.cgi?id=17865 -- Mismatched input syntax for Cite error messages * Some discussion. Cite is seen as scary! No one to take this yet. Please give this some TLC. Cite is not /that/ scary. What's TLC? TLC is Tender Loving Care. Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Upcoming MediaWiki 1.18 deployment
bawolff wrote: btw, could refreshImageMetadata.php be run on wmf wikis some time after the deployment? 1.18 contains lots of new code related to Exif support (and related image metadata stuff). The maintenance script just regenerates img_metadata based on the source image. -bawolff Do they work correctly? Some metadata tests have been failing to me for a long time, though I didn't bother to find out the root cause. If that code is yours, you may want to take a look. More specifically: FormatMetadataTest::testInvalidDate BitmapMetadataHandlerTest::testMultilingualCascade JpegTest::testJpegMetadataExtraction ExifRotationTest::testMetadata (dataset #1) ExifRotationTest::testWidthFlipping Results in REL1.18 are a bit different, although they look to be older tests? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96356]: New comment added
User Siebrand posted a comment on MediaWiki.r96356. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96356#c22673 Commit summary: Nimbus -- the skin used on Halopedia (http://www.halopedian.com/). Tested against MediaWiki 1.18, requires ResourceLoader. TODO: Nimbus_IE.css should be loaded for Internet Explorers, but currently it isn't. Comment: Please document the messages that were added in the i18n file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Upcoming MediaWiki 1.18 deployment
Do they work correctly? Some metadata tests have been failing to me for a long time, though I didn't bother to find out the root cause. If that code is yours, you may want to take a look. More specifically: FormatMetadataTest::testInvalidDate BitmapMetadataHandlerTest::testMultilingualCascade JpegTest::testJpegMetadataExtraction ExifRotationTest::testMetadata (dataset #1) ExifRotationTest::testWidthFlipping Results in REL1.18 are a bit different, although they look to be older tests? That's concerning. They work for me perfectly fine and seem to work on cruise control. What's the error they're failing with? Thanks, Bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97339]: Revision status changed
User ^demon changed the status of MediaWiki.r97339. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97339 Commit summary: Code cleanup Add README Fix php4 style constructor in backup.inc ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Upcoming MediaWiki 1.18 deployment
bawolff wrote:
That's concerning. They work for me perfectly fine and seem to work on
cruise control. What's the error they're failing with?
Thanks,
Bawolff
It may just be that I don't have something properly configured locally.
This is a run of make databaseless on trunk.
There were 5 failures:
1) FormatMetadataTest::testInvalidDate
Valid metadata extracted
Failed asserting that boolean:false is not equal to boolean:false.
tests/phpunit/includes/media/FormatMetadataTest.php:13
tests/phpunit/MediaWikiTestCase.php:64
tests/phpunit/MediaWikiPHPUnitCommand.php:31
tests/phpunit/phpunit.php:60
2) BitmapMetadataHandlerTest::testMultilingualCascade
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array
(
[_type] = lang
[en] = right translation
-[x-default] = right(iptc)
+[x-default] = An example image (wrong should not show this)
)
tests/phpunit/includes/media/BitmapMetadataHandlerTest.php:33
tests/phpunit/MediaWikiTestCase.php:64
tests/phpunit/MediaWikiPHPUnitCommand.php:31
tests/phpunit/phpunit.php:60
3) JpegTest::testJpegMetadataExtraction
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array
(
-[ImageDescription] = Test file
@@ @@
[MEDIAWIKI_EXIF_VERSION] = 2
-[ResolutionUnit] = 2
-[XResolution] = 72/1
-[YCbCrPositioning] = 1
-[YResolution] = 72/1
)
tests/phpunit/includes/media/JpegTest.php:25
tests/phpunit/MediaWikiTestCase.php:64
tests/phpunit/MediaWikiPHPUnitCommand.php:31
tests/phpunit/phpunit.php:60
4) ExifRotationTest::testMetadata with data set #1 ('portrait-rotated.jpg',
'image/jpeg', array(768, 1024))
portrait-rotated.jpg: post-rotation width check
Failed asserting that integer:768 matches expected integer:1024.
tests/phpunit/includes/media/ExifRotationTest.php:42
tests/phpunit/MediaWikiTestCase.php:64
tests/phpunit/MediaWikiPHPUnitCommand.php:31
tests/phpunit/phpunit.php:60
5) ExifRotationTest::testWidthFlipping
Failed asserting that double:38 matches expected integer:50.
tests/phpunit/includes/media/ExifRotationTest.php:109
tests/phpunit/MediaWikiTestCase.php:64
tests/phpunit/MediaWikiPHPUnitCommand.php:31
tests/phpunit/phpunit.php:60
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97342]: New comment added
User Reedy posted a comment on MediaWiki.r97342. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97342#c22674 Commit summary: Merged in changes from LogEventsList which prevent missing usernames in log-lines and adds hook LogEventsListShowLogExtract. Part of merge from here: http://www.mediawiki.org/wiki/Wikia_code Comment: If you're commiting in new hooks, please add them to docs/hooks.txt, and also create an onwiki page ALSO, [[Manual:Coding_conventions#PHP_pitfalls|we no liek empty()]] Aswell as there not being enough spaces in your code ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97086]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r97086. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97086#c22675 Commit summary: Update make-wmf-branch/default.conf per http://etherpad.wikimedia.org/118make-wmf-branch Comment: I guess $mainSourceUrl still has to be updated and a patch setting the MW version in defaultsettings.php is needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97086]: New comment added
User Reedy posted a comment on MediaWiki.r97086. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97086#c22676 Commit summary: Update make-wmf-branch/default.conf per http://etherpad.wikimedia.org/118make-wmf-branch Comment: Do we actually need a patch in the sense of this config/script? Or just make that the first manual commit afterwards? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97034]: Revision status changed
User MarkAHershberger changed the status of MediaWiki.r97034. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97034 Commit summary: * (bug 6722) Spacing fixes for math functions with/without parens * (bug 18912) Add math support for \sen Spanish variant of \sin * (bug 18912) Fix spacing for \operatorname in math Reapplies r86962, r87117, r87936, r87941 plus some parser tests. Note that further batch testing to identify any other potential problems due to the spacing tweaks is a good idea! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97343]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97343. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97343 Commit summary: Change $mainSourceUrl per aaron Add another extension comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r18334]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r18334. Old Status: old New Status: fixme User Krinkle also posted a comment on MediaWiki.r18334. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/18334#c22677 Commit summary: User::getOption now accept a default value to override default user values this makes it consistent with WebRequest::get* methods. Corrected code in various places accordingly. Comment: Resetting to false for sanity and tracking. I know it's a 4 year old rev, but I don't care right now. Unless I'm missing some undocumented functionality here, this revision is heavily broken and causing bug 30940. This revision introduces the assumption that a preference is never set to an empty string. Although that assumption is not very weird, it's undocumented and (moreover) inconsistent because other code doesn't assume this. Albeit that the default value of the $default argument is 'false', the equation compares against an empty string. Which means if you call the function without providing a default you'll get 'false' (instead of of, like previously was the case, an empty string). Aside from that, it's also affecting the user interface. More precisely, in the preferences. If a preference (say, a checkbox) sould be set to true by default, '''the user will be unable to uncheck the checkbox'''. When the user does so, it's instantly reset, because of the weird way it's handled here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r18334]: New comment added
User Krinkle posted a comment on MediaWiki.r18334. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/18334#c22678 Commit summary: User::getOption now accept a default value to override default user values this makes it consistent with WebRequest::get* methods. Corrected code in various places accordingly. Comment: Resetting from 'old' to 'fixme' for sanity and tracking. I know it's a 4 year old rev, but I don't care right now. Unless I'm missing some undocumented functionality here, this revision is heavily broken and causing bug 30940. This revision introduces the assumption that a preference is never set to an empty string. Although that assumption is not very weird, it's undocumented and (moreover) inconsistent because other code doesn't assume this. Albeit that the default value of the $default argument is 'false', the equation compares against an empty string. Which means if you call the function without providing a default you'll get 'false' (instead of of, like previously was the case, an empty string). Aside from that, it's also affecting the user interface. More precisely, in the preferences. If a preference (say, a checkbox) sould be set to true by default, '''the user will be unable to uncheck the checkbox'''. When the user does so, it's instantly reset, because of the weird way it's handled here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97344]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97344. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97344 Commit summary: Copy a few scripts out of 1.17wmf1 for preservation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97345]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97345. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97345 Commit summary: Remove 1 preservedItems add another ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97346]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97346. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97346 Commit summary: Move 2 wikimedia specific files to WikimediaMaintenance ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97086]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97086. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97086 Commit summary: Update make-wmf-branch/default.conf per http://etherpad.wikimedia.org/118make-wmf-branch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97347]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97347. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97347 Commit summary: Merge in more various WMF scripts (somewhat a merge of r81699) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97322]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97322. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97322 Commit summary: We were not getting enough of significant digits to sort 0.02% and 0.05% correctly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97342]: New comment added
User SColombo posted a comment on MediaWiki.r97342. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97342#c22679 Commit summary: Merged in changes from LogEventsList which prevent missing usernames in log-lines and adds hook LogEventsListShowLogExtract. Part of merge from here: http://www.mediawiki.org/wiki/Wikia_code Comment: http://www.mediawiki.org/wiki/Manual:Hooks/LogEventsListShowLogExtract ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97342]: New comment added
User SColombo posted a comment on MediaWiki.r97342. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97342#c22680 Commit summary: Merged in changes from LogEventsList which prevent missing usernames in log-lines and adds hook LogEventsListShowLogExtract. Part of merge from here: http://www.mediawiki.org/wiki/Wikia_code Comment: Thanks for the tips! Added to docs/hooks.txt, added page (linked above). After reading that page, I think empty() is still what we want there since were testing for null, completely unset, etc. If I'm misinterpreting that page there's a more MediaWiki way you guys prefer to do it, please tag that as a followup commit so I can learn :) thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97320]: Revision status changed
User Meno25 changed the status of MediaWiki.r97320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97320 Commit summary: Fix extra brace from r97299 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
