Re: [Wikitech-l] Fixme, please fix me!
On 8/20/10 10:56 PM, MZMcBride wrote: Trevor Parscal wrote: Can we please exclude branches from this calculation? I think this is what you want. mysql select cr_author, count(*) from code_rev where cr_status = 'fixme' and cr_path not like '/branches/%' group by cr_author order by count(*) desc; +--+--+ | cr_author| count(*) | +--+--+ | awjrichards |7 | | kaldari |5 | | nimishg |5 | | werdna |4 | | platonides |4 | | huji |4 | | catrope |3 | | demon|3 | | btongminh|3 | | daniel |2 | | pdhanda |2 | | sean_colombo |2 | | happy-melon |2 | | tparscal |2 | | jeroendedauw |2 | | maxsem |2 | | mgrabovsky |1 | | rainman |1 | | yaauie |1 | | philip |1 | | hartman |1 | | ialex|1 | | mah |1 | | aaron|1 | | soxred93 |1 | | vyznev |1 | | jdpond |1 | | leonsp |1 | | tisane |1 | | thomasv |1 | | brion|1 | | nikerabbit |1 | | siebrand |1 | | tstarling|1 | | diana|1 | | dantman |1 | | purodha |1 | | svip |1 | +--+--+ 38 rows in set (0.07 sec) The total is 74. This chart could be made dynamic in a Toolserver tool, if there were interest. It could also possibly go into the extension, but the database would need some indices first. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l Yes, this is excellent, and much more useful than tracking all fixmes in the whole system. Generally we push people off into branches so they can develop in a less mission-critical environment. Tracking fixmes in those areas only servers to skew the numbers in a negative direction, or at least make it unclear how skewed they may or may not be. Thanks for poking at this! - Trevor ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
From: wikitech-l-boun...@lists.wikimedia.org On Behalf Of MZMcBride This chart could be made dynamic in a Toolserver tool I nicked your query (hope you didn't mind :P) to make this: http://toolserver.org/~stwalkerster/codereview-fixme.php Simon (stwalkerster) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
Siebrand Mazeland wrote: Just a friendly reminder to everyone about their outstanding FIXMEs in Code Review (up to 97[1] from 63[2] beginning of June). The following is a list of everyone who has a commit with a fixme on it: platonides - 4 r70434 is the $wgUser-getOption( 'stubthreshold' ) vs $wgUser-getStubThreshold(). It's not something I care about too much, nor does Aryeh care strongly... r70783 is fixed IMHO. r70809 is a documentation problem. Waiting for Nikerabbit answer... r70917 is a real bug (a bunch of parsertests failing) but I can't reproduce it, so need to grab Simetrical first to determine it. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Fixme, please fix me!
Just a friendly reminder to everyone about their outstanding FIXMEs in Code Review (up to 97[1] from 63[2] beginning of June). The following is a list of everyone who has a commit with a fixme on it: tparscal - 11 awjrichards - 7 peter17 - 6 nimishg - 5 werdna - 4 catrope - 4 platonides - 4 demon - 4 huji - 4 kaldari - 4 siebrand - 2 jeroendedauw - 2 tstarling - 2 happy-melon - 2 sean_colombo - 2 papyromancer - 2 btongminh - 2 pdhanda - 2 neilk - 2 daniel - 2 maxsem - 2 tisane - 1 dale - 1 vyznev - 1 freakolowsky - 1 soxred93 - 1 nikerabbit - 1 mah - 1 brion - 1 aaron - 1 hartman - 1 diana - 1 dantman - 1 svip - 1 ialex - 1 leonsp - 1 philip - 1 vibber - 1 jdpond - 1 yaauie - 1 purodha - 1 rainman - 1 mgrabovsky - 1 TOTAL: 97 Please be sure to ping anyone you know isn't on this mailing list (like some contractors, or people working on special projects maybe?) so we can get everyone informed. Cheers! Siebrand [1] http://www.mediawiki.org/w/index.php?limit=100title=Special%3ACode%2FMediaWiki%2Fstatus%2Ffixme [2] http://lists.wikimedia.org/pipermail/wikitech-l/2010-June/048066.html ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
Can we please exclude branches from this calculation? - Trevor On 8/20/10 3:54 AM, Siebrand Mazeland wrote: Just a friendly reminder to everyone about their outstanding FIXMEs in Code Review (up to 97[1] from 63[2] beginning of June). The following is a list of everyone who has a commit with a fixme on it: tparscal - 11 awjrichards - 7 peter17 - 6 nimishg - 5 werdna - 4 catrope - 4 platonides - 4 demon - 4 huji - 4 kaldari - 4 siebrand - 2 jeroendedauw - 2 tstarling - 2 happy-melon - 2 sean_colombo - 2 papyromancer - 2 btongminh - 2 pdhanda - 2 neilk - 2 daniel - 2 maxsem - 2 tisane - 1 dale - 1 vyznev - 1 freakolowsky - 1 soxred93 - 1 nikerabbit - 1 mah - 1 brion - 1 aaron - 1 hartman - 1 diana - 1 dantman - 1 svip - 1 ialex - 1 leonsp - 1 philip - 1 vibber - 1 jdpond - 1 yaauie - 1 purodha - 1 rainman - 1 mgrabovsky - 1 TOTAL: 97 Please be sure to ping anyone you know isn't on this mailing list (like some contractors, or people working on special projects maybe?) so we can get everyone informed. Cheers! Siebrand [1] http://www.mediawiki.org/w/index.php?limit=100title=Special%3ACode%2FMediaWiki%2Fstatus%2Ffixme [2] http://lists.wikimedia.org/pipermail/wikitech-l/2010-June/048066.html ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
Trevor Parscal wrote: Can we please exclude branches from this calculation? I think this is what you want. mysql select cr_author, count(*) from code_rev where cr_status = 'fixme' and cr_path not like '/branches/%' group by cr_author order by count(*) desc; +--+--+ | cr_author| count(*) | +--+--+ | awjrichards |7 | | kaldari |5 | | nimishg |5 | | werdna |4 | | platonides |4 | | huji |4 | | catrope |3 | | demon|3 | | btongminh|3 | | daniel |2 | | pdhanda |2 | | sean_colombo |2 | | happy-melon |2 | | tparscal |2 | | jeroendedauw |2 | | maxsem |2 | | mgrabovsky |1 | | rainman |1 | | yaauie |1 | | philip |1 | | hartman |1 | | ialex|1 | | mah |1 | | aaron|1 | | soxred93 |1 | | vyznev |1 | | jdpond |1 | | leonsp |1 | | tisane |1 | | thomasv |1 | | brion|1 | | nikerabbit |1 | | siebrand |1 | | tstarling|1 | | diana|1 | | dantman |1 | | purodha |1 | | svip |1 | +--+--+ 38 rows in set (0.07 sec) The total is 74. This chart could be made dynamic in a Toolserver tool, if there were interest. It could also possibly go into the extension, but the database would need some indices first. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
On Sun, Jun 13, 2010 at 4:47 PM, Rob Lanphier ro...@robla.net wrote: I was going to chime in and say that new seems like the right state to go into, but what about the (very common) case where a later checkin fixes the original fixme? Can't the committer put the original checkin in resolved, and redirect any further discussion to the followup checkin (which should remain new)? Often fixme is set when there's only one detail of the commit that's bad. In that case, the rest of the commit still needs to be reviewed, and setting it to resolved will obscure that. The fix for the bad aspect of the commit needs to be reviewed separately. Personally, I think we should just ditch resolved as a possible status. If there are still parts to review, set to new. If it was set to ok and then the flaw was found and fixed, set back to ok. If the entire commit was flawed and the new commit supersedes it, set to reverted. The fix should be new in all cases. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
On Thu, Jun 10, 2010 at 9:22 AM, Roan Kattouw roan.katt...@gmail.comwrote: 2010/6/10 Chad innocentkil...@gmail.com: This is a general note to all committers, since I keep seeing the same question asked. Committers should never set their own revisions to OK or RESOLVED. Even if you review code, review other people's code and let other people review yours :) I do believe it's acceptable to reset the status of a FIXME back to NEW when you've addressed all the comments. It can then be reviewed again. In general, moving an issue out of FIXME seems like the right thing to do for issues that the original developer thinks have been addressed, since fixme is implicitly assigned to the original committer. I was going to chime in and say that new seems like the right state to go into, but what about the (very common) case where a later checkin fixes the original fixme? Can't the committer put the original checkin in resolved, and redirect any further discussion to the followup checkin (which should remain new)? The only time it seems like a checkin should go back into new state is when the committer stands by the original commit, and has provided further rationale for it in the comments. Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
(Realized I hadn't actually subscribed, so re-sending.) Chad innocentkil...@gmail.com writes: mah - 5 When a FIXME is fixed, my understanding is that the fixer isn't supposed to un-mark the FIXME. If I'm wrong, I'll toggle a few of these to RESOLVED. Looking at the recent state changes, it isn't clear that the committer is supposed to mark it RESOLVED. Since I'm at the top of the list: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/62006 Fixed. http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66696 Fixed but failed to commit. Committed. http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66698 Fixed. Six days later (as I started my vacation) Platonides added another item that needed fixing. Fixed just now. Which leaves these two: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/61911 http://www.mediawiki.org/wiki/Special:Code/MediaWiki/65152 At least I've moved down the list :) Mark. -- http://hexmode.com/ Embrace Ignorance. Just don't get too attached. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
On Thu, Jun 10, 2010 at 11:40 AM, Mark A. Hershberger m...@everybody.org wrote: (Realized I hadn't actually subscribed, so re-sending.) Chad innocentkil...@gmail.com writes: mah - 5 When a FIXME is fixed, my understanding is that the fixer isn't supposed to un-mark the FIXME. If I'm wrong, I'll toggle a few of these to RESOLVED. Looking at the recent state changes, it isn't clear that the committer is supposed to mark it RESOLVED. This is a general note to all committers, since I keep seeing the same question asked. Committers should never set their own revisions to OK or RESOLVED. Even if you review code, review other people's code and let other people review yours :) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
2010/6/10 Chad innocentkil...@gmail.com: This is a general note to all committers, since I keep seeing the same question asked. Committers should never set their own revisions to OK or RESOLVED. Even if you review code, review other people's code and let other people review yours :) I do believe it's acceptable to reset the status of a FIXME back to NEW when you've addressed all the comments. It can then be reviewed again. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
On Thu, Jun 10, 2010 at 12:22 PM, Roan Kattouw roan.katt...@gmail.com wrote: I do believe it's acceptable to reset the status of a FIXME back to NEW when you've addressed all the comments. It can then be reviewed again. It would be nice if this weren't necessary, but in practice people set a commit to fixme, then don't set it back when it's fixed. So when my commits are marked fixme and I address the problem, I set them back to whatever it was beforehand, generally. It's only reasonable, if people are going to post lists of how many outstanding fixmes there are for everyone. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fixme, please fix me!
Yay, I'm in the top 3! :) -- Jeroen De Dauw * http://blog.bn2vs.com * http://wiki.bn2vs.com Don't panic. Don't be evil. 50 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65! -- On 9 June 2010 11:02, Chad innocentkil...@gmail.com wrote: Just a friendly reminder to everyone about their outstanding FIXMEs in Code Review. The following is a list of everyone who has a commit with a fixme on it: mah - 5 tparscal - 5 jeroendedauw - 4 reedy - 4 siebrand - 4 catrope - 3 werdna - 3 adam - 2 maxsem - 2 neilk - 2 philip - 2 aaron - 1 brion - 1 dale - 1 daniel - 1 demon - 1 devunt - 1 diana - 1 gurch - 1 hartman - 1 ishimatsu - 1 jojo - 1 mgrabovsky - 1 ning - 1 pdhanda - 1 purodha - 1 platonides - 1 shmichael - 1 simetrical - 1 svip - 1 than4213 - 1 thomasv - 1 tisane - 1 tomasz - 1 tstarling - 1 vyznev - 1 TOTAL: 63 Please be sure to ping anyone you know isn't on this mailing list (like some contractors, or people working on special projects maybe?) so we can get everyone informed. Thanks, -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
