Re: gdi32: check for null-pointer in CreateDIBSection
On 5/19/07, Louis. Lenders <[EMAIL PROTECTED]> wrote: Hi , this fixes bug 8066, http://bugs.winehq.org/show_bug.cgi?id=8066 See the crash log here: http://bugs.winehq.org/attachment.cgi?id=5800&action=view , CreateDIBSection is called with bitmapinfo = null. The program should be passing in a correctly initialized BITMAPINFO. We need to make sure this isn't hiding another bug. Could you provide a test case?
Re: Patch [1/4]:Implement D3DRMColorGetRed
Am Samstag 19 Mai 2007 22:01 schrieb [EMAIL PROTECTED]: +color=2949120; +expected=45.0/255.0; Maybe it would be easier to read if you write the color as a hex value(the D3DCOLOR one). Also try to set blue and green to something different than 0. pgpifuH4sMviX.pgp Description: PGP signature
Error compiling wine during git regression test
Howdy, I was attempting to run a regression test, and kept running into errors when trying to compile a bisect between wine 0.9.34 and 0.9.35. After trying all sorts of things to fix it, I tried compiling between wine 0.9.34 and the current git, which worked fine, eventually leading me to the troubled patch. However, building between 0.9.34 and 0.9.35 still does not work. Below is the output from terminal of where it fails, seemingly on the cmd program, and more specifically, in the directory function. make[2]: Entering directory `/home/austin/wine-git/programs/cmd' gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o batch.o batch.c gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o builtins.o builtins.c gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o directory.o directory.c directory.c:36: error: expected ) before * token directory.c: In function WCMD_directory: directory.c:409: warning: implicit declaration of function WCMD_list_directory directory.c: At top level: directory.c:443: warning: conflicting types for WCMD_list_directory directory.c:443: error: static declaration of WCMD_list_directory follows non-static declaration directory.c:409: error: previous implicit declaration of WCMD_list_directory was here make[2]: *** [directory.o] Error 1 make[2]: Leaving directory `/home/austin/wine-git/programs/cmd' make[1]: *** [cmd] Error 2 make[1]: Leaving directory `/home/austin/wine-git/programs' make: *** [programs] Error 2 Please CC me in any replies, as I am not subscribed to this mailing list. Austin
configure error on OpenBSD
I am trying to port wine to OpenBSD, or at least trying to make it build and not segfault upon execution... (This bug is a minor issue compared to some ld.so trouble I have run into. I'd be happy to know about differences between Net/Free/OpenBSD ld.so) configure output: configure: WARNING: sys/sysctl.h: present but cannot be compiled configure: WARNING: sys/sysctl.h: check for missing prerequisite headers? configure: WARNING: sys/sysctl.h: see the Autoconf documentation configure: WARNING: sys/sysctl.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/sysctl.h: proceeding with the preprocessor's result configure: WARNING: sys/sysctl.h: in the future, the compiler will take precedence configure: WARNING: ## ## configure: WARNING: ## Report this to wine-devel@winehq.org ## configure: WARNING: ## ## Some rows from config.log: In file included from /usr/include/sys/sysctl.h:46, from conftest.c:106: /usr/include/sys/ucred.h:49: error: `NGROUPS' undeclared here (not in a function ) In file included from /usr/include/sys/sysctl.h:47, from conftest.c:106: /usr/include/sys/proc.h:65: error: `MAXLOGNAME' undeclared here (not in a functi on) /usr/include/sys/proc.h:91: error: syntax error before "int" /usr/include/sys/proc.h:215: error: syntax error before "sigset_t" /usr/include/sys/proc.h:230: error: `MAXCOMLEN' undeclared here (not in a function) In file included from conftest.c:106: /usr/include/sys/sysctl.h:327: error: `MAXLOGNAME' undeclared here (not in a function) I managed to get around this by including sys/param.h in the sys/proc.h and sys/ucred.h headers but I'm not sure that's the right approach. Wine developers wouldn't benefit from such patches anyway. I have tried to change configure.ac properly but it seems that I can't get it right... // V.A. P.S. Adding sys/proc and sys/ucred to header list and checking for param.h dependency is not sufficient: AC_CHECK_HEADERS([sys/proc.h],,, [#if HAVE_SYS_PARAM_H # include #endif]) AC_CHECK_HEADERS([sys/ucred.h],,, [#if HAVE_SYS_PARAM_H # include #endif]) With these addons, both proc and ucred fails. D.S. _ Flyger tiden iväg? Fånga dagen med Yahoo! Mails inbyggda kalender. Dessutom 250 MB gratis, virusscanning och antispam. Få den på: http://se.mail.yahoo.com _ Ont om plats? Skaffa gratis Yahoo! Mail med obegränsat, lagringsutrymme, kalender, virusscan och antispamfunktion. http://se.mail.yahoo.com
Re: Small Direct3D milestone
> Did you change something affecting D3D multithreaded apps? I am currently working on this. Some fundamental work went into wine somewhen between .33 and .35, but its not active yet. It was just some data structure modifications to handle multiple contexts for one swapchain. Before that the state management rework enabled us to keep track of states for multiple contexts. But right now I am working on making things really thread safe, and after that I can debug some gl crashes with the context selection patches I posted on this list a few months ago so they can go in finally. > Star Trek: > Bridge Commander doesn't start for me (only blank screen) since 0.9.37. > http://appdb.winehq.org/appview.php?iVersionId=4207 (AppDB) > http://www.bridgecommander.com/indepth/bcdemo.htm (downloadable demo) > I'm using the opensource r300 ATI drivers if that matters. No idea about that. If it worked before a regression test will help pgpPx9Yn2sK7C.pgp Description: PGP signature
Re: Small Direct3D milestone
Hi! On 11.05.2007 21:16, Stefan Dösinger wrote: > With Wine 0.9.37 we've archieved something that I allow myself to call a > small > milestone - All Direct3D7 Immediate mode SDK demos successfully perform their > intended rendering. Congratulations! > Two major problems are left though, namely windowed opengl rendering(see the > junk where a menu bar should be) and GetDC(there should be a little bit of > text rendered, I disabled render target locking to get proper performance). > > Where to go from here? I am currently fixing the DirectDraw rewrite > regressions I can get hold of, and I am trying to make D3D thread safe > finally. From the application point of view my focus will stay on fixing > older apps first, which somewhat includes getting thread safety, render > target locking and GetDC working properly. Did you change something affecting D3D multithreaded apps? Star Trek: Bridge Commander doesn't start for me (only blank screen) since 0.9.37. http://appdb.winehq.org/appview.php?iVersionId=4207 (AppDB) http://www.bridgecommander.com/indepth/bcdemo.htm (downloadable demo) I'm using the opensource r300 ATI drivers if that matters. Regards, Carl-Daniel
Re: Direct3D thread safety review
On 18/05/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: * When a method needs locking, the lock is aquired after printing the trace, but before checking error conditions(like windows). * If a method doesn't need locking(e.g. unimplemented, or just a getter for static info(GetCaps), or QI / AddRef / Release), then the lock is not held Since ddraw, d3d8 and d3d9 need their own locking anyway, my plan is to implement locking in them and assume synchronised calls in wined3d - ie no wined3d locking. No 2 threads may call wined3d at the same time, and ddraw/d3d8/d3d9 have to take care of that. That keeps the code simpler. Makes sense to me.
Re: [PATCH] wined3d: IWineD3DDeviceImpl_Clear: list Color parameter in the trace.
On 12/05/07, Erik Inge Bolsø <[EMAIL PROTECTED]> wrote:
-TRACE("(%p) Count (%d), pRects (%p), Flags (%x), Z (%f), Stencil (%d)\n",
This,
- Count, pRects, Flags, Z, Stencil);
+TRACE("(%p) Count (%d), pRects (%p), Flags (%x), Color (%f %f %f %f), Z (%f),
Stencil (%d)\n", This,
+ Count, pRects, Flags, D3DCOLOR_R(Color), D3DCOLOR_G(Color),
D3DCOLOR_B(Color), D3DCOLOR_A(Color), Z, Stencil);
Tracing the color is fine, but there's no reason to convert it do
individual float components. Printing it as 0x%08x should be fine.
Re: [PATCH] wined3d: debug_d3dusage: prettyprint a flag combination
On 12/05/07, Erik Inge Bolsø <[EMAIL PROTECTED]> wrote:
---
dlls/wined3d/utils.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c
index c444232..4db0622 100644
--- a/dlls/wined3d/utils.c
+++ b/dlls/wined3d/utils.c
@@ -238,6 +238,7 @@ const char* debug_d3dusage(DWORD usage) {
WINED3DUSAGE_TO_STR(WINED3DUSAGE_SOFTWAREPROCESSING);
WINED3DUSAGE_TO_STR(WINED3DUSAGE_DONOTCLIP);
WINED3DUSAGE_TO_STR(WINED3DUSAGE_POINTS);
+WINED3DUSAGE_TO_STR(WINED3DUSAGE_WRITEONLY|WINED3DUSAGE_POINTS);
WINED3DUSAGE_TO_STR(WINED3DUSAGE_RTPATCHES);
WINED3DUSAGE_TO_STR(WINED3DUSAGE_NPATCHES);
WINED3DUSAGE_TO_STR(WINED3DUSAGE_DYNAMIC);
--
1.4.4.2
That's not a proper fix, debug_d3dusage() should be changed to print
all the flags in "usage", not just exact matches.
Re: Small Direct3D milestone
On 12/05/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Am Samstag 12 Mai 2007 00:02 schrieb Raymond Barbiero: > FYI, I get similar vertex blending errors playing Oblivion. Oblivion is a direct3d9 game which makes heavy use of vertex shaders. I'd be really surprised if it uses fixed function vertex blending, so I don't think the problems in oblivion are related. They may be some rounding/precision problem in the vertex shaders. What wine version? There was a rounding issue with mova a couple of versions ago.
Re: [PATCH] dlls/wined3d: Implemented converting X1R5G5B5 format to R5G5B5A1 to emulate color-keying.
Am Samstag 19 Mai 2007 15:33 schrieb [EMAIL PROTECTED]: Looks good to me, although I wonder if the maskin in "*Dest = (color & 0x7FFF) << 1" is really needed or if we can just shift out the highest bit.
Re: New Gecko package
Luke Bratch wrote: >> I'm interested in >> regressions, so just a simple test if app that >> > worked before still works > >> will be fine. >> > > I've given it a test, and found the following: > > - When setting that URL in HKCU\Software\Wine\MSHTML, > it will download but fail to install. > It's not supposed to work. Package that I've uploaded for testing is in tar.bz2 format while MSHTML Gecko installer expects cab format. > - Extracting it to install it manually works, as do > the scroll bars (which work fine) > - It crashes after submitting more than one form on > websites. For instance searching for something on > Google, then searching again will cause a crash. > Thanks for testing. I've reproduced the crash and I'm trying to fix it. I've found that using older nspr4.dll fixes it so far. Thanks, Jacek
