Re: include: Deconstify a variable
Oops! Please ignore this one: I only changed the prototype of MapLS() and forgot to change the definition. -- Andy.
Patch for WineD3D to set Driver an Description (try 2)
Hi, Fallout 3 and maybe other games or D3D apps needs such special
settings, this patch should be ok, it is well tested.
This patch is not hack!
New wine registry settings:
VideoDriver
VideoDescription
Patch is for current (14.03.2009) git.
PS: For Fallout 3 you should use registry settings (or similar):
VideoDescription=NVIDIA GeForce 9600 GT
VideoDriver=nv4_disp.dll
Mirek Slugen
diff -Naur wine.old/dlls/wined3d/directx.c wine/dlls/wined3d/directx.c
--- wine.old/dlls/wined3d/directx.c 2008-11-07 18:01:46.0 +0100
+++ wine/dlls/wined3d/directx.c 2008-11-07 18:02:05.0 +0100
@@ -4247,8 +4247,19 @@
goto nogl_adapter;
}
-adapter-driver = Display;
-adapter-description = Direct3D HAL;
+/* Use VideoDriver registry setting when set */
+if(wined3d_settings.video_driver) {
+adapter-driver = wined3d_settings.video_driver;
+} else {
+adapter-driver = Display;
+}
+
+/* Use VideoDescription registry setting when set */
+if(wined3d_settings.video_description) {
+adapter-description = wined3d_settings.video_description;
+} else {
+adapter-description = Direct3D HAL;
+}
/* Use the VideoRamSize registry setting when set */
if(wined3d_settings.emulated_textureram)
@@ -4450,8 +4461,22 @@
This-adapters[0].monitorPoint.x = -1;
This-adapters[0].monitorPoint.y = -1;
-This-adapters[0].driver = Display;
-This-adapters[0].description = WineD3D DirectDraw Emulation;
+
+/* Use VideoDriver registry setting when set */
+if(wined3d_settings.video_driver) {
+This-adapters[0].driver = wined3d_settings.video_driver;
+} else {
+This-adapters[0].driver = Display;
+}
+
+/* Use VideoDescription registry setting when set */
+if(wined3d_settings.video_description) {
+This-adapters[0].description = wined3d_settings.video_description;
+} else {
+This-adapters[0].description = WineD3D DirectDraw Emulation;
+}
+
+/* Use VideoRamSize registry setting when set */
if(wined3d_settings.emulated_textureram) {
This-adapters[0].TextureRam = wined3d_settings.emulated_textureram;
} else {
diff -Naur wine.old/dlls/wined3d/wined3d_main.c wine/dlls/wined3d/wined3d_main.c
--- wine.old/dlls/wined3d/wined3d_main.c 2008-10-24 15:13:40.0 +0200
+++ wine/dlls/wined3d/wined3d_main.c 2008-11-07 17:48:16.0 +0100
@@ -304,6 +304,18 @@
wined3d_settings.allow_multisampling = TRUE;
}
}
+if ( !get_config_key( hkey, appkey, VideoDriver, buffer, size) )
+{
+TRACE(Video Driver name: %s\n,buffer);
+wined3d_settings.video_driver = HeapAlloc(GetProcessHeap(), 0, strlen(buffer) + 1);
+if(wined3d_settings.video_driver ) strcpy(wined3d_settings.video_driver, buffer);
+}
+if ( !get_config_key( hkey, appkey, VideoDescription, buffer, size) )
+{
+TRACE(Video Description: %s\n,buffer);
+wined3d_settings.video_description = HeapAlloc(GetProcessHeap(), 0, strlen(buffer) + 1);
+if(wined3d_settings.video_description ) strcpy(wined3d_settings.video_description, buffer);
+}
}
if (wined3d_settings.vs_mode == VS_HW)
TRACE(Allow HW vertex shaders\n);
diff -Naur wine.old/dlls/wined3d/wined3d_private.h wine/dlls/wined3d/wined3d_private.h
--- wine.old/dlls/wined3d/wined3d_private.h 2008-10-28 16:02:51.0 +0100
+++ wine/dlls/wined3d/wined3d_private.h 2008-11-07 17:56:42.0 +0100
@@ -297,6 +297,8 @@
/* Memory tracking and object counting */
unsigned int emulated_textureram;
char *logo;
+ char *video_driver;
+ char *video_description;
int allow_multisampling;
} wined3d_settings_t;
Re: [AppDB] Entry for Everquest 2
This is really nitpicking isn't it? On Sun, 2009-03-15 at 12:02 +1100, Ben Klein wrote: I just noticed that the entry for Everquest II, the sequel to Everquest, is listed as version 2 under Everquest in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers.
Re: [AppDB] Entry for Everquest 2
not really... it's a completly new game. i'll see if i can do something... 2009/3/15 John Beaulieu john.beaul...@comcast.net This is really nitpicking isn't it? On Sun, 2009-03-15 at 12:02 +1100, Ben Klein wrote: I just noticed that the entry for Everquest II, the sequel to Everquest, is listed as version 2 under Everquest in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers.
Re: [AppDB] Entry for Everquest 2
done. i've created a new application and moved test data there. unfortunatly appdb doesn't move comments so those are lost :( i wait for the EQ maintainers to step up for EQ2 :P http://appdb.winehq.org/objectManager.php?sClass=applicationiId=9400 2009/3/15 Ben Klein shackl...@gmail.com I just noticed that the entry for Everquest II, the sequel to Everquest, is listed as version 2 under Everquest in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers.
Re: [AppDB] Entry for Everquest 2
On Sun, Mar 15, 2009 at 7:40 AM, Ricardo Filipe ricardojdfil...@gmail.com wrote: done. i've created a new application and moved test data there. unfortunatly appdb doesn't move comments so those are lost :( i wait for the EQ maintainers to step up for EQ2 :P http://appdb.winehq.org/objectManager.php?sClass=applicationiId=9400 2009/3/15 Ben Klein shackl...@gmail.com I just noticed that the entry for Everquest II, the sequel to Everquest, is listed as version 2 under Everquest in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers. I've always wondered about that. Thanks for fixing it. Someone already changed the description to include the link you mentioned. Is that all you wanted? I am a maintainer of the original EQ.
Re: Vacations
On Fr, 2009-03-13 at 20:05 +0100, Alexandre Julliard wrote: Folks, There won't be any commits next week, as I'll be skiing... Have fun and take care -- By by ... Detlef
Re: [AppDB] Entry for Everquest 2
all that is changed it was me. i kept everything on context, although i forgot to copy EQ2 description :S what i meant is that you or other EQ maintainer ask to be EQ2 maintainer ;) 2009/3/15 Charity Abbott angeli...@gmail.com On Sun, Mar 15, 2009 at 7:40 AM, Ricardo Filipe ricardojdfil...@gmail.com wrote: done. i've created a new application and moved test data there. unfortunatly appdb doesn't move comments so those are lost :( i wait for the EQ maintainers to step up for EQ2 :P http://appdb.winehq.org/objectManager.php?sClass=applicationiId=9400 2009/3/15 Ben Klein shackl...@gmail.com I just noticed that the entry for Everquest II, the sequel to Everquest, is listed as version 2 under Everquest in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers. I've always wondered about that. Thanks for fixing it. Someone already changed the description to include the link you mentioned. Is that all you wanted? I am a maintainer of the original EQ.
How to enable font anti-aliasing in Wine?
Hi, This weekend I was reading the 'Dutch slashdot' (tweakers.net) about Wine 1.1.17 and a user was wondering when Wine would finally support font anti-aliasing. I said we have been supporting this for ages. I also thought I was using it on my own Debian system. When asking more and more users about it in #winehackers (Chris, Detlef, Marcus, Stefan ..) only Stefan had it working on a Wine 1.1.0 build he still had around on his system (he didn't have a newer normal Wine copy) on his Gentoo. Further nobody on Debian, Fedora, Gentoo or Suse had it working except someone on a old 1.0 Wine. For the record when anti-aliasing is around Winecfg should look like: http://stud4.tuwien.ac.at/~e0526822/winecfg.png (this on Stefan his 1.1.0). What is so special about Wine why anti-aliasing isn't working for most users? (it could be a regression) In Stefan his case it started working after installing a Windows tahoma.ttf. What is so special about this font? A modern Linux system has dozens or hundreds of fonts installed and both GNOME/KDE can use each font AA'ed without issues. Roderick -- Pt! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01
Re: How to enable font anti-aliasing in Wine?
2009/3/15 Roderick Colenbrander thunderbir...@gmx.net: What is so special about Wine why anti-aliasing isn't working for most users? (it could be a regression) In Stefan his case it started working after installing a Windows tahoma.ttf. What is so special about this font? A modern Linux system has dozens or hundreds of fonts installed and both GNOME/KDE can use each font AA'ed without issues. I recently reinstalled this system with Ubuntu 8.10 and its inbuilt Wine 1.0.1. I then added the budgededicated.com repo to get the fortnightly snapshots. A string of registry changes enabled smoothed fonts for me: http://forum.winehq.org/viewtopic.php?p=20061sid=6fbbcf362e44a66b310ef88f631c83f5 However, it's deeply problematic that I had to do this at all instead of it Just Working when Wine was updated. This is just broken. - d.
Re: How to enable font anti-aliasing in Wine?
2009/3/15 Roderick Colenbrander thunderbir...@gmx.net: What is so special about Wine why anti-aliasing isn't working for most users? (it could be a regression) In Stefan his case it started working after installing a Windows tahoma.ttf. What is so special about this font? A modern Linux system has dozens or hundreds of fonts installed and both GNOME/KDE can use each font AA'ed without issues. I recently reinstalled this system with Ubuntu 8.10 and its inbuilt Wine 1.0.1. I then added the budgededicated.com repo to get the fortnightly snapshots. A string of registry changes enabled smoothed fonts for me: http://forum.winehq.org/viewtopic.php?p=20061sid=6fbbcf362e44a66b310ef88f631c83f5 However, it's deeply problematic that I had to do this at all instead of it Just Working when Wine was updated. This is just broken. - d. For Stefan (and some others who tried 1.0) I believe it worked on a PLAIN wine config without any registry settings. Where these options added after 1.0? (I think the subpixel one was) Perhaps these options should appear in winecfg or perhaps even be turned on by default and let users disable it in there if needed. Thanks, Roderick -- Nur bis 16.03.! DSL-Komplettanschluss inkl. WLAN-Modem für nur 17,95 ¿/mtl. + 1 Monat gratis!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a
Re: How to enable font anti-aliasing in Wine?
Roderick Colenbrander wrote: 2009/3/15 Roderick Colenbrander thunderbir...@gmx.net: What is so special about Wine why anti-aliasing isn't working for most users? (it could be a regression) In Stefan his case it started working after installing a Windows tahoma.ttf. What is so special about this font? A modern Linux system has dozens or hundreds of fonts installed and both GNOME/KDE can use each font AA'ed without issues. I recently reinstalled this system with Ubuntu 8.10 and its inbuilt Wine 1.0.1. I then added the budgededicated.com repo to get the fortnightly snapshots. A string of registry changes enabled smoothed fonts for me: http://forum.winehq.org/viewtopic.php?p=20061sid=6fbbcf362e44a66b310ef88f631c83f5 However, it's deeply problematic that I had to do this at all instead of it Just Working when Wine was updated. This is just broken. - d. For Stefan (and some others who tried 1.0) I believe it worked on a PLAIN wine config without any registry settings. Where these options added after 1.0? (I think the subpixel one was) Perhaps these options should appear in winecfg or perhaps even be turned on by default and let users disable it in there if needed. There is already a bug for that: http://bugs.winehq.org/show_bug.cgi?id=16729 It's back to the discussion of people just breaking stuff and never following up to fix it. Because they don't care or it's not their problem. Vitaliy
Re: Patch for WineD3D to set Driver an Description (try 2)
2009/3/14 Mirek Slugeň thunde...@email.cz: Hi, Fallout 3 and maybe other games or D3D apps needs such special settings, this patch should be ok, it is well tested. This patch is not hack! You're leaking wined3d_settings.video_description and wined3d_settings.video_driver. Having an override would be ok, but you need to add detection code first in IWineD3DImpl_FillGLCaps().
Re: riched20: add tests for EM_FORMATRANGE
James McKenzie wrote: Lei Zhang wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong with the implementation, but the test cases should be ok. Hi Lei, Pretty old patch. (June 2007) I just moved some of my VMware 'boxes' to my new laptop (laptop resolution 1024x800) and I suddenly had some failures. The resolution that VMware can use (with all those borders and the sidebar) is 1044x574. Running the tests fullscreen makes them pass again. You can replicate this by playing with the screen resolution. The smaller the resolution the more test failures. Any idea where I need to look? -- Cheers, Paul. Is this on Windows in VMWare? I'm not getting any riched20 crosstest failures here at 800x600. Interesting that this should fail on a VMWare workstation setup. The tests are pretty straightfoward. Also, I have not worked on this due to other pressures of life. Would someone like to take this over and finish it? This would solve a couple of open bug reports and fix some complaints about text rendering. James McKenzie As said before, this issue can be seen on both VMware and real boxes. It's much easier of course to play around with resolutions on VMware. I'm currently trying loads of different resolutions to see if there is some logic. I do see that when I'm reducing just the horizontal resolution for example that the result of the EM_FORMATRANGE message changes at certain intervals (no logic found yet though). The number that keeps coming back is '15' : Hor VertEM_FORMATRANGE 1040800 20 937 800 16 832 800 15 712 800 14 652 800 13 547 800 12 517 800 9 412 800 7 382 800 6 The difference between the horizontal resolution when the results change is always a multiple of 15 (can't check the first one as 20 is the maximum returned). The same behavior can be seen with a vertical resolution of 600: Hor VertEM_FORMATRANGE 1238600 20 1222600 18 1057600 16 1012600 15 937 600 9 547 600 7 517 600 6 And with a horizontal resolution of 979 (yeah I know): Hor VertEM_FORMATRANGE 979 724 20 979 712 15 979 472 7 So any idea about that number '15'? Maybe once I've figured out where that comes from the logic makes more sense. -- Cheers, Paul.
Re: How to enable font anti-aliasing in Wine?
2009/3/15 Roderick Colenbrander thunderbird2k at gmx.net: ... A string of registry changes enabled smoothed fonts for me: http://forum.winehq.org/viewtopic.php?p=20061sid=6fbbcf362e44a66b310ef88f631c83f5 I was already using FontSmoothing=2 which was some improvement over nothing, but I didn't know these other settings. FontSmoothingType=2 made things much better, the others didn't seem to have any effect. However, I then discovered that with FontSmoothingType=2, a Java app I run in Wine crashes when it opens. :( The interesting item out of the Java stack trace is: Caused by: java.lang.IllegalArgumentException: 0 incompatible with Text-specific LCD contrast key Quite why Java is getting involved at this level I don't really know. Running on Windows with the same font smoothing settings it works fine. Puzzling ...
Re: How to enable font anti-aliasing in Wine?
Just in case anyone interested, some time ago I've written script to simplify enabling font smoothing and choosing the type one needs. Here it is: http://files.polosatus.ru/winefontssmoothing_en.sh Russian version (in case anyone needs it): http://files.polosatus.ru/winefontssmoothing.sh Screenshot and short description: http://ubuntuforums.org/showthread.php?t=1050920 HTH -- Igor
Re: [AppDB] Entry for Everquest 2
no test data was lost. it is all in the new link. i already stated the comments got lost and i'm sorry for that, i thought appdb would copy them too. and that's why i asked for the EQ maintainers to step up to be EQ2 maintainers. i apologize for the missing comments, again. 2009/3/15 John Beaulieu john.beaul...@comcast.net Hey, you caused comments, data, and maintainers to be removed. Thats not cool. On Sun, 2009-03-15 at 11:18 +, Ricardo Filipe wrote: not really... it's a completly new game. i'll see if i can do something...
Re: How to enable font anti-aliasing in Wine?
Roderick Colenbrander wrote: 2009/3/15 Roderick Colenbrander thunderbir...@gmx.net: What is so special about Wine why anti-aliasing isn't working for most users? (it could be a regression) In Stefan his case it started working after installing a Windows tahoma.ttf. What is so special about this font? A modern Linux system has dozens or hundreds of fonts installed and both GNOME/KDE can use each font AA'ed without issues. I recently reinstalled this system with Ubuntu 8.10 and its inbuilt Wine 1.0.1. I then added the budgededicated.com repo to get the fortnightly snapshots. A string of registry changes enabled smoothed fonts for me: http://forum.winehq.org/viewtopic.php?p=20061sid=6fbbcf362e44a66b310ef88f631c83f5 However, it's deeply problematic that I had to do this at all instead of it Just Working when Wine was updated. This is just broken. - d. For Stefan (and some others who tried 1.0) I believe it worked on a PLAIN wine config without any registry settings. Where these options added after 1.0? (I think the subpixel one was) Perhaps these options should appear in winecfg or perhaps even be turned on by default and let users disable it in there if needed. There is already a bug for that: http://bugs.winehq.org/show_bug.cgi?id=16729 It's back to the discussion of people just breaking stuff and never following up to fix it. Because they don't care or it's not their problem. Vitaliy Thanks I hadn't seen the bug report. As far as I understand it, the only issue left is the lack of a default registy settings in wine.inf (and winecfg support) ? Roderick -- Nur bis 16.03.! DSL-Komplettanschluss inkl. WLAN-Modem für nur 17,95 ¿/mtl. + 1 Monat gratis!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a
Re: wine web pages update
Apostolos Syropoulos wrote: Hello, I believe you the person responsible for the Wine web pages. If this is not true, please disregard the rest of this message and accept my apologies for this uninvited intrusion. Previous versions of the wine web pages includes information about Solaris/OpenSolaris binaries and info about these systems. Now there is no mention about Solaris/OpenSolaris! For example, the first page says Run Windows Applications on Linux, BSD and MacOS. OK Solaris is a commercial product but so is MacOS! Since I do release binary packages of wine for both Solaris and OpenSolaris at http://ww.sunfreepacks.com could you include this info in the download section. Also, could you please say something like Run Windows Application on most Unix and Unix-like systems. This shows impartiality and is far more friendly. Thanks in advance for your cooperation. Apostolos Syropoulos Hi Apostolos, I can see no Wine packages on the link mentioned above. Maintainers of Wine webpages could be reached on wine-de...@winehq.org. Including wine-devel on list. BTW. There are IPS packages of 1.0.1 for OpenSolaris available (1). Recent Wine compiles well under OpenSolaris too (1.1.17). Cheers Hark 1) 2) http://pkg.opensolaris.org/contrib/en/index.shtml
Re: wine - paths
2009/3/16 Joerg Schiermeier i...@schiermeier-software.de: Hello Ben, I update my debian including your repository to download the wine-packages. Today in the morning the new version of wine 1.1.17 came in. Now I saw in the list of processes this: ---cite - begin--- UID PID PPID C STIME TTY TIME CMD joerg 19311 3547 0 21:56 ? 00:00:00 winver joerg 19314 1 3 21:56 ? 00:00:01 /usr/bin/../lib/../bin/wineserver joerg 19320 1 0 21:56 ? 00:00:00 c:\windows\system32\services.exe joerg 19322 19320 0 21:56 ? 00:00:00 c:\windows\system32\winedevice.exe cdenable joerg 19327 19320 0 21:56 ? 00:00:00 c:\windows\system32\winedevice.exe MountMgr joerg 19336 1 0 21:56 ? 00:00:00 c:\windows\system32\explorer.exe /desktop joerg 19425 17858 0 21:57 pts/1 00:00:00 ps -f -u joerg ---cite - end--- (result of: ps -f -u joerg after starting winver - the wine version info) This '/usr/bin/../lib/../bin/wineserver' is a little bit confused isn't it? The executable 'wineserver' lives in '/usr/bin'. So this has to be '/usr/bin/wineserver', or? What's wrong? It still works, that much demonstrates there's nothing actually wrong. /usr/bin/../lib/../bin is the same as /usr/bin, it's just a bit roundabout. The .. directories mean go to the parent directory. Regardless, I've CC'd wine-devel in case it can be cleaned up.
Re: wine web pages update
2009/3/16 Vít Hrachový vit.hrach...@sandbox.cz: Apostolos Syropoulos wrote: For example, the first page says Run Windows Applications on Linux, BSD and MacOS. OK Solaris is a commercial product but so is MacOS! Since I do release binary packages of wine for both Solaris and OpenSolaris at http://ww.sunfreepacks.com could you include this info in the download section. Also, could you please say something like Run Windows Application on most Unix and Unix-like systems. This shows impartiality and is far more friendly. Didn't someone suggest this change when then new website design was being discussed? I believe I showed support for it too ... But now we're being accused of bias against Solaris? What about HP-UX, AIX, NetBSD, OpenBSD etc.? :P
Re: [AppDB] Entry for Everquest 2
actually ben, how to's and warnings also went away. i think beaulieu already found them elsewhere and updated the page with them, thanks ;) sorry about that again, i'll post a bug for moving data to also copy the rest of the page... 2009/3/15 Ben Klein shackl...@gmail.com 2009/3/16 Ricardo Filipe ricardojdfil...@gmail.com: no test data was lost. it is all in the new link. i already stated the comments got lost and i'm sorry for that, i thought appdb would copy them too. and that's why i asked for the EQ maintainers to step up to be EQ2 maintainers. i apologize for the missing comments, again. 2009/3/15 John Beaulieu john.beaul...@comcast.net Hey, you caused comments, data, and maintainers to be removed. Thats not cool. On Sun, 2009-03-15 at 11:18 +, Ricardo Filipe wrote: not really... it's a completly new game. i'll see if i can do something... Thanks Ricardo. Pity about the comments, but Notes, HOWTOs and Warnings are more useful than comments anyway, and comments tend to get stale faster :)
Re: [AppDB] Entry for Everquest 2
2009/3/16 Ricardo Filipe ricardojdfil...@gmail.com: actually ben, how to's and warnings also went away. i think beaulieu already found them elsewhere and updated the page with them, thanks ;) sorry about that again, i'll post a bug for moving data to also copy the rest of the page... Oh well, I still appreciate your help in cleaning it up :D
Re: [AppDB] Entry for Everquest 2
On Sun, 15 Mar 2009 18:23:20 + Ricardo Filipe ricardojdfil...@gmail.com wrote: no test data was lost. it is all in the new link. i already stated the comments got lost and i'm sorry for that, i thought appdb would copy them too. and that's why i asked for the EQ maintainers to step up to be EQ2 maintainers. i apologize for the missing comments, again. Screenshots are not copied either. IMO, the move child objects link should be renamed move test data, as that seems to be all it actually moves. And perhaps deleting the entry moved from should not be automatic. It's just one extra step for an admin to go back and manually delete an entry after moving test data, and this would give us a chance to verify that everything that needed to be copied over has been before the change becomes irrevocable. -- Rosanne DiMesio dime...@earthlink.net
Re: [AppDB] Entry for Everquest 2
agreed. either that or do a new link that copies EVERYTHING. i've CCed the appdb site manager to see what he thinks :) 2009/3/15 Rosanne DiMesio dime...@earthlink.net On Sun, 15 Mar 2009 18:23:20 + Ricardo Filipe ricardojdfil...@gmail.com wrote: no test data was lost. it is all in the new link. i already stated the comments got lost and i'm sorry for that, i thought appdb would copy them too. and that's why i asked for the EQ maintainers to step up to be EQ2 maintainers. i apologize for the missing comments, again. Screenshots are not copied either. IMO, the move child objects link should be renamed move test data, as that seems to be all it actually moves. And perhaps deleting the entry moved from should not be automatic. It's just one extra step for an admin to go back and manually delete an entry after moving test data, and this would give us a chance to verify that everything that needed to be copied over has been before the change becomes irrevocable. -- Rosanne DiMesio dime...@earthlink.net
Re: wine web pages update
2009/3/15 Ben Klein shackl...@gmail.com: 2009/3/16 Vít Hrachový vit.hrach...@sandbox.cz: Apostolos Syropoulos wrote: For example, the first page says Run Windows Applications on Linux, BSD and MacOS. OK Solaris is a commercial product but so is MacOS! Since I do release binary packages of wine for both Solaris and OpenSolaris at http://ww.sunfreepacks.com could you include this info in the download section. Also, could you please say something like Run Windows Application on most Unix and Unix-like systems. This shows impartiality and is far more friendly. Didn't someone suggest this change when then new website design was being discussed? I believe I showed support for it too ... But now we're being accused of bias against Solaris? What about HP-UX, AIX, NetBSD, OpenBSD etc.? :P It's *intended* to run on anything Unix or Unix-like, but in practice, development was Linux-centric for long enough that everything else is in practice a second-class platform, and implying otherwise would be misleading. I understand the actively supported platforms where stuff can be expected mostly to work (Linux, Mac OS X, FreeBSD, Solaris) are already listed. AIUI, Wine isn't actually working properly at present on OpenBSD and NetBSD. (Heck, I'm fiddling with getting it compiling on Windows ... but I'm not demanding that be listed to be fair.) - d.
[Wine Documentation] GDB Help
Hello Wine Developers, Besides the winedbg --gdb mode, I found a way to run gdb directly on wine. I figured all or part of this text file I'm included could be appended to section 1.8 of the Wine documentation where other debuggers are discussed. Thanks, Andrew Look This debugging document is meant to be appended to the Wine Developer's documentation, at: http://www.winehq.org/docs/winedev-guide/dbg-others 1.8.9 Using GDB to debug Wine tests From the wine build directory, GDB can be called in such a manner as to load wine's symbol table: cd wine64 gdb ./loader/wine-pthread At this point, breakpoints can be set in GDB on the wine source code files. However, breakpoints will be set on future loads of the source code file. (gdb) break sock.c:430 No source file named sock.c. Make breakpoint pending on future shared library load? (y or [n]) y Breakpoint 1 (sock.c:430) pending. Now, we can run the tests and have our breakpoint get loaded before execution. Using the 'run' command with the desired .exe file of our test will begin testing. (gdb) run ./dlls/ws2_32/tests/ws2_32_test.exe.so sock Starting program: /home/andrew/BRANCH_WINE/wine64/loader/ wine-pthread ./dlls/ws2_32/tests/ws2_32_test.exe.so sock [Thread debugging using libthread_db enabled] [New Thread 0x7f5b46eae6e0 (LWP 6229)] Could not load Mozilla. HTML rendering will be disabled. err:process:__wine_kernel_init boot event wait timed out sock.c:1820: Test failed: getsockopt should fail for UDP sockets but return value is 0x sock.c:2322: STARTING TEST 0 [New Thread 0x7f5b4456f950 (LWP 6255)] sock.c:409: simple_server (20) starting [New Thread 0x7f5b4445f950 (LWP 6256)] sock.c:597: simple_client (21): starting sock.c:418: simple_server (20) ready sock.c:600: simple_client (21): server ready [New Thread 0x7f5b4434f950 (LWP 6257)] sock.c:423: simple_server (20): waiting for client sock.c:597: simple_client (22): starting sock.c:600: simple_client (22): server ready sock.c:612: simple_client (21) connected [Switching to Thread 0x7f5b4456f950 (LWP 6255)] Now, all of the normal GDB commands can be called to help analyze the program execution. 'backtrace' is a good starting point to get an idea of the context under which we are executing. 'info threads' displays a representation of the current threads at this breakpoint. Breakpoint 1, simple_server (par=0x7f5b44bfdc48) at ../../../../wine-git/dlls/ws2_32/tests/sock.c:430 430 ok ( mem-sock[0].peer.sin_addr.s_addr == inet_addr ( gen-inet_addr ), (gdb) backtrace #0 simple_server (par=0x7f5b44bfdc48) at ../../../../ wine-git/dlls/ws2_32/tests/sock.c:430 #1 0x7f5b45f80a54 in call_thread_func (rtl_func=0x7f5b449f7510 simple_server, arg=0x7f5b44bfdc48) at ../../../wine-git/dlls/ntdll/thread.c:413 #2 0x7f5b45f80c00 in start_thread (info=value optimized out) at ../../../wine-git/dlls/ ntdll/thread.c:489 #3 0x7f5b467493ea in start_thread () from /lib/libpthread.so.0 #4 0x7f5b464b6cbd in clone () from /lib/libc.so.6 #5 0x in ?? () (gdb) info threads 4 Thread 0x7f5b4434f950 (LWP 6257) 0x7f5b4675024b in connect () from /lib/libpthread.so.0 3 Thread 0x7f5b4445f950 (LWP 6256) 0x7f5b4674ff4b in read () from /lib/libpthread.so.0 * 2 Thread 0x7f5b4456f950 (LWP 6255) simple_server (par=0x7f5b44bfdc48) at ../../../../wine-git/dlls/ ws2_32/tests/sock.c:430 1 Thread 0x7f5b46eae6e0 (LWP 6229) 0x7f5b4674ff4b in read () from /lib/libpthread.so.0 To inspect our current frame, 'info locals' displays local variables, 'info args' displays the values of all arguments with which the current function was called. In debugging Wine 64 particularly, I found 'info registers' to be particularly useful for a low level view of the execution.
[PATCH] RESEND programs/explorer: Allow spaces in virtual desktop names via command line /desktop option
I noticed I left off the component in the subject of a few of my
recent patch submissions. Resend. I'd love to have suggestions on
cleaning this up! :D
2009/3/9 Ben Klein shackl...@gmail.com:
The purpose of this patch should be pretty clear from the subject
line. Feel free to adjust the comments I've added; it seems like what
I've done here might not be completely obvious.
From cde0f703803a6b3849ca342e920b1d663e4541f0 Mon Sep 17 00:00:00 2001
From: Ben Klein shackl...@gmail.com
Date: Mon, 9 Mar 2009 15:11:00 +1100
Subject: programs/explorer Allow spaces in virtual desktop names via command
line /desktop option
The stripping of spaces from the start of the command line has been moved to
prevent duplication of code in the added lines where cmdline is recalculated.
---
programs/explorer/desktop.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c
index 480d245..7bc76e0 100644
--- a/programs/explorer/desktop.c
+++ b/programs/explorer/desktop.c
@@ -264,20 +264,29 @@ void manage_desktop( WCHAR *arg )
WCHAR *p = arg;
const WCHAR *name = NULL;
-/* get the rest of the command line (if any) */
+/* assume the command line starts after the first space in arg */
while (*p !isspace(*p)) p++;
if (*p)
-{
-*p++ = 0;
-while (*p isspace(*p)) p++;
-if (*p) cmdline = p;
-}
+cmdline = p;
/* parse the desktop option */
/* the option is of the form /desktop=name[,widthxheight] */
if (*arg == '=' || *arg == ',')
{
arg++;
+/* arguments with spaces are surrounded with '' */
+if ((p = strchrW( arg, '' )))
+{
+/* terminate the end of the desktop name */
+*p = 0;
+cmdline = ++p;
+}
+else if (cmdline)
+{
+/* cmdline points to the end of the desktop name argument */
+*cmdline++ = 0;
+}
+
name = arg;
if ((p = strchrW( arg, ',' ))) *p++ = 0;
if (!p || !parse_size( p, width, height ))
@@ -349,6 +358,8 @@ void manage_desktop( WCHAR *arg )
STARTUPINFOW si;
PROCESS_INFORMATION pi;
+while (*cmdline isspace(*cmdline)) cmdline++;
+
memset( si, 0, sizeof(si) );
si.cb = sizeof(si);
WINE_TRACE( starting %s\n, wine_dbgstr_w(cmdline) );
--
1.6.1.3
[PATCH] RESEND mountmgr.sys: implement tracking of fixed/hardisk devices
Out of all the drive types that can be set in winecfg, the only one that currently doesn't work is Local disk, which should map to DRIVE_FIXED. It seems to me that define_unix_drive, which handles creation and changes to the Drives tab in winecfg, is missing the case for DRIVE_FIXED mapping to DEVICE_HARDISK_VOL, as it appears in the query_unix_drive later in mountmgr.c. I'd like some comment on whether this patch is appropriate. 2009/3/6 Ben Klein shackl...@gmail.com: This fixes bug 17618, where setting a drive type to Local disk does not save the appropriate change to the registry. The problem can be traced to mountmgr.c, where define_unix_drive has no case for the type being Local disk (DRIVE_FIXED). From 100c129bbb1a3df3ebb68d52b22c798b6a2150c2 Mon Sep 17 00:00:00 2001 From: Ben Klein shackl...@gmail.com Date: Fri, 6 Mar 2009 00:49:39 +1100 Subject: mountmgr.sys: implement tracking of fixed/hardisk devices This fixes bug 17618, where setting a drive type to Local disk does not save the appropriate change to the registry. The problem can be traced to mountmgr.c, where define_unix_drive has no case for the type being Local disk (DRIVE_FIXED). --- dlls/mountmgr.sys/mountmgr.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/mountmgr.sys/mountmgr.c b/dlls/mountmgr.sys/mountmgr.c index 00112b9..d2b1515 100644 --- a/dlls/mountmgr.sys/mountmgr.c +++ b/dlls/mountmgr.sys/mountmgr.c @@ -264,6 +264,7 @@ static NTSTATUS define_unix_drive( const void *in_buff, SIZE_T insize ) case DRIVE_REMOTE:type = DEVICE_NETWORK; break; case DRIVE_CDROM: type = DEVICE_CDROM; break; case DRIVE_RAMDISK: type = DEVICE_RAMDISK; break; +case DRIVE_FIXED: type = DEVICE_HARDDISK_VOL; break; } return add_dos_device( letter - 'a', NULL, device, mount_point, type ); } -- 1.6.1.3
Re: Disabling File attachments on Wiki
2009/3/14 David Gerard dger...@gmail.com: 2009/3/13 John Klehm xixsimplicity...@gmail.com: On Fri, Mar 13, 2009 at 2:24 PM, David Gerard dger...@gmail.com wrote: Because the ideal way to deal with more malicious users without hampering the good users is to give community members the power to do the work, so it doesn't fall to just Dimi. I'd agree, but there doesn't seem to be a way to delete users from the web interface. Disabling them could be our best bet without some custom coding. Disabling will do. I'd think that disabling would be preferred to removing accounts, at least as a quick-fix if someone is identified as a spammer. I also think it's probably a bad idea to have too many SuperUsers :D
Re: Disabling File attachments on Wiki
Ben Klein wrote: 2009/3/14 David Gerard dger...@gmail.com: 2009/3/13 John Klehm xixsimplicity...@gmail.com: On Fri, Mar 13, 2009 at 2:24 PM, David Gerard dger...@gmail.com wrote: Because the ideal way to deal with more malicious users without hampering the good users is to give community members the power to do the work, so it doesn't fall to just Dimi. I'd agree, but there doesn't seem to be a way to delete users from the web interface. Disabling them could be our best bet without some custom coding. Disabling will do. I'd think that disabling would be preferred to removing accounts, at least as a quick-fix if someone is identified as a spammer. I also think it's probably a bad idea to have too many SuperUsers :D I was asking about disabling of file attachments since they can not be monitored for spam content. How did this deviate into disabling users? Vitaliy.
Re: Disabling File attachments on Wiki
2009/3/16 Vitaliy Margolen wine-de...@kievinfo.com: Ben Klein wrote: 2009/3/14 David Gerard dger...@gmail.com: 2009/3/13 John Klehm xixsimplicity...@gmail.com: On Fri, Mar 13, 2009 at 2:24 PM, David Gerard dger...@gmail.com wrote: Because the ideal way to deal with more malicious users without hampering the good users is to give community members the power to do the work, so it doesn't fall to just Dimi. I'd agree, but there doesn't seem to be a way to delete users from the web interface. Disabling them could be our best bet without some custom coding. Disabling will do. I'd think that disabling would be preferred to removing accounts, at least as a quick-fix if someone is identified as a spammer. I also think it's probably a bad idea to have too many SuperUsers :D I was asking about disabling of file attachments since they can not be monitored for spam content. How did this deviate into disabling users? Because someone started talking about spam-control methods.
Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle non printablecharacters
Massimo Del Fedele m...@veneto.com wrote: PATH_ExtTextOut() uses GetGlyphOutlineW() which can return a NULL buffer size not just on errors but also on non-printable glyphs. Instead of aborting the function should check for such cases, get the metrics and continue. This patch doesn't match the normal logic of ExtTextOut implemented in dlls/winex11.drv/xrender.c, also this requires a test case for both code paths. -- Dmitry.
Re: [1/7] mshtml: Implement IHTMLStyle get/put borderLeftWidth (resend)
Could I get some feedback on this patch please?
Best Regards
Alistair Leslie-Hughes
From 60473b955b3b35feb089ad1cbf1320ce9f971020 Mon Sep 17 00:00:00 2001
From: Alistair Leslie-Hughes leslie_alist...@hotmail.com
Date: Thu, 5 Mar 2009 20:44:38 +1100
Subject: [PATCH] Implement IHTMLStyle get/put borderLeftWidth
To: wine-patches wine-patc...@winehq.org
---
dlls/mshtml/htmlstyle.c | 11 +++
dlls/mshtml/htmlstyle.h |1 +
dlls/mshtml/tests/dom.c | 19 +++
3 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index 7641701..10f90e1 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -59,6 +59,8 @@ static const WCHAR attrBorderLeft[] =
{'b','o','r','d','e','r','-','l','e','f','t',0};
static const WCHAR attrBorderLeftStyle[] =
{'b','o','r','d','e','r','-','l','e','f','t','-','s','t','y','l','e',0};
+static const WCHAR attrBorderLeftWidth[] =
+
{'b','o','r','d','e','r','-','l','e','f','t','-','w','i','d','t','h',0};
static const WCHAR attrBorderRightStyle[] =
{'b','o','r','d','e','r','-','r','i','g','h','t','-','s','t','y','l','e',0};
static const WCHAR attrBorderRightWidth[] =
@@ -138,6 +140,7 @@ static const struct{
{attrBorderColor, DISPID_IHTMLSTYLE_BORDERCOLOR},
{attrBorderLeft, DISPID_IHTMLSTYLE_BORDERLEFT},
{attrBorderLeftStyle, DISPID_IHTMLSTYLE_BORDERLEFTSTYLE},
+{attrBorderLeftWidth, DISPID_IHTMLSTYLE_BORDERLEFTWIDTH},
{attrBorderRightStyle, DISPID_IHTMLSTYLE_BORDERRIGHTSTYLE},
{attrBorderRightWidth, DISPID_IHTMLSTYLE_BORDERRIGHTWIDTH},
{attrBorderStyle, DISPID_IHTMLSTYLE_BORDERSTYLE},
@@ -1571,15 +1574,15 @@ static HRESULT WINAPI
HTMLStyle_get_borderBottomWidth(IHTMLStyle *iface, VARIANT
static HRESULT WINAPI HTMLStyle_put_borderLeftWidth(IHTMLStyle *iface,
VARIANT v)
{
HTMLStyle *This = HTMLSTYLE_THIS(iface);
-FIXME((%p)-(v%d)\n, This, V_VT(v));
-return E_NOTIMPL;
+TRACE((%p)-(v%d)\n, This, V_VT(v));
+return set_nsstyle_attr_var(This-nsstyle, STYLEID_BORDER_LEFT_WIDTH,
v, 0);
}
static HRESULT WINAPI HTMLStyle_get_borderLeftWidth(IHTMLStyle *iface,
VARIANT *p)
{
HTMLStyle *This = HTMLSTYLE_THIS(iface);
-FIXME((%p)-(%p)\n, This, p);
-return E_NOTIMPL;
+TRACE((%p)-(%p)\n, This, p);
+return get_nsstyle_attr_var(This-nsstyle, STYLEID_BORDER_LEFT_WIDTH,
p, 0);
}
static HRESULT WINAPI HTMLStyle_put_borderStyle(IHTMLStyle *iface, BSTR v)
diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h
index 596f579..b900e67 100644
--- a/dlls/mshtml/htmlstyle.h
+++ b/dlls/mshtml/htmlstyle.h
@@ -47,6 +47,7 @@ typedef enum {
STYLEID_BORDER_COLOR,
STYLEID_BORDER_LEFT,
STYLEID_BORDER_LEFT_STYLE,
+STYLEID_BORDER_LEFT_WIDTH,
STYLEID_BORDER_RIGHT_STYLE,
STYLEID_BORDER_RIGHT_WIDTH,
STYLEID_BORDER_STYLE,
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index f95b753..be877b2 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -3587,6 +3587,25 @@ static void test_default_style(IHTMLStyle *style)
ok(hres == S_OK, put_borderBottomWidth: %08x\n, hres);
VariantClear(vDefault);
+/* borderLeftWidth */
+hres = IHTMLStyle_get_borderLeftWidth(style, vDefault);
+ok(hres == S_OK, get_borderLeftWidth: %08x\n, hres);
+
+V_VT(v) = VT_BSTR;
+V_BSTR(v) = a2bstr(10);
+hres = IHTMLStyle_put_borderLeftWidth(style, v);
+ok(hres == S_OK, put_borderLeftWidth: %08x\n, hres);
+VariantClear(v);
+
+hres = IHTMLStyle_get_borderLeftWidth(style, v);
+ok(hres == S_OK, get_borderLeftWidth: %08x\n, hres);
+ok(!strcmp_wa(V_BSTR(v), 10px), expected 10px = %s\n,
dbgstr_w(V_BSTR(v)));
+VariantClear(v);
+
+hres = IHTMLStyle_put_borderLeftWidth(style, vDefault);
+ok(hres == S_OK, put_borderLeftWidth: %08x\n, hres);
+VariantClear(vDefault);
+
hres = IHTMLStyle_QueryInterface(style, IID_IHTMLStyle2,
(void**)style2);
ok(hres == S_OK, Could not get IHTMLStyle2 iface: %08x\n, hres);
if(SUCCEEDED(hres)) {
--
1.5.4.3
Re: Disabling File attachments on Wiki
Ben Klein wrote: 2009/3/16 Vitaliy Margolen wine-de...@kievinfo.com: Ben Klein wrote: 2009/3/14 David Gerard dger...@gmail.com: 2009/3/13 John Klehm xixsimplicity...@gmail.com: On Fri, Mar 13, 2009 at 2:24 PM, David Gerard dger...@gmail.com wrote: Because the ideal way to deal with more malicious users without hampering the good users is to give community members the power to do the work, so it doesn't fall to just Dimi. I'd agree, but there doesn't seem to be a way to delete users from the web interface. Disabling them could be our best bet without some custom coding. Disabling will do. I'd think that disabling would be preferred to removing accounts, at least as a quick-fix if someone is identified as a spammer. I also think it's probably a bad idea to have too many SuperUsers :D I was asking about disabling of file attachments since they can not be monitored for spam content. How did this deviate into disabling users? Because someone started talking about spam-control methods. Ok, then please can we disable attachments? And if not why? If we have to have attachments then is it possible to let admins only to upload them? BTW disabling users won't do you much good withe current registration process. Most spam is added by users with random usernames. With few exceptions. Vitaliy.
