Re: dmusic: remove unused variable (try 2)

2010-07-27 Thread Andrew Nguyen 
On Tue, Jul 27, 2010 at 12:59 AM, Austin English
austinengl...@gmail.com wrote:
 --
 -Austin





The source file seems to use tabs for indentation, so your patch
should do the same.

Re: kernel32: add a test for CreateFileA() (try 3)

2010-07-27 Thread Andrew Nguyen 
On Tue, Jul 27, 2010 at 12:53 AM, Austin English
austinengl...@gmail.com wrote:
 Addressing Nikolay and Dmitry's comments.

 Passed wtb:
 https://testbot.winehq.org/JobDetails.pl?Key=3947

 --
 -Austin




You forgot to attach the patch.

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Paul Vriens 

On 07/27/2010 03:48 AM, Austin English wrote:

There were no test results on winehq today. Seems everyone's exceeding
1.5. Guess some new tests today have a lot of output...



I do see output for July 26th or am I missing something?

We could use a volunteer to implement compression for the winetest reports.

--
Cheers,

Paul.

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Alexandre Julliard 
Paul Vriens paul.vriens.w...@gmail.com writes:

 On 07/27/2010 03:48 AM, Austin English wrote:
 There were no test results on winehq today. Seems everyone's exceeding
 1.5. Guess some new tests today have a lot of output...


 I do see output for July 26th or am I missing something?

 We could use a volunteer to implement compression for the winetest reports.

That shouldn't be necessary. Just fix the offending test (urlmon:uri in
this case).

-- 
Alexandre Julliard
julli...@winehq.org

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Austin English 
On Tue, Jul 27, 2010 at 2:01 AM, Paul Vriens paul.vriens.w...@gmail.com wrote:
 On 07/27/2010 03:48 AM, Austin English wrote:

 There were no test results on winehq today. Seems everyone's exceeding
 1.5. Guess some new tests today have a lot of output...


 I do see output for July 26th or am I missing something?

http://test.winehq.org/data/20f51c29a99299384e840e148f02aae66bfb45be/

I don't see any for wine. All of my test setups failed when sending
with the error of a too large data file.

 We could use a volunteer to implement compression for the winetest reports.

That of course would be better...

-- 
-Austin

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Michael Stefaniuc 
Hello Austin,

Austin English wrote:
 There were no test results on winehq today. Seems everyone's exceeding
 1.5. Guess some new tests today have a lot of output...
wouldn't it make more sense to have a global variable 'max_filesize'
instead of duplicating the magic constants all over the place?

 diff --git a/programs/winetest/send.c b/programs/winetest/send.c
 index 11c9f33..9fc4b81 100644
 --- a/programs/winetest/send.c
 +++ b/programs/winetest/send.c
 @@ -155,11 +155,11 @@ send_file_direct (const char *name)
  goto abort1;
  }
  filesize = GetFileSize( file, NULL );
 -if (filesize  1.5*1024*1024) {
 +if (filesize  1.75*1024*1024) {
  report (R_WARNING,
 -File too big (%.1f MB  1.5 MB); submitting partial 
 report.,
 +File too big (%.1f MB  1.75 MB); submitting partial 
 report.,
  filesize/1024.0/1024);
 -filesize = (DWORD) 1.5*1024*1024;
 +filesize = (DWORD) 1.75*1024*1024;
  }
  
  report (R_STATUS, Sending header);
 @@ -298,11 +298,11 @@ send_file_wininet (const char *name)
  }
  
  filesize = GetFileSize( file, NULL );
 -if (filesize  1.5*1024*1024) {
 +if (filesize  1.75*1024*1024) {
  report (R_WARNING,
 -File too big (%.1f MB  1.5 MB); submitting partial 
 report.,
 +File too big (%.1f MB  1.75 MB); submitting partial 
 report.,
  filesize/1024.0/1024);
 -filesize = 1.5*1024*1024;
 +filesize = 1.75*1024*1024;
  }
  
  report (R_STATUS, Opening HTTP connection to  SERVER_NAME);

bye
michael

[website] Update French translation of 'About Wine' page

2010-07-27 Thread Frédéric Delanoy 
From d9eb3a4cf56f7fbaf972ed3418c82e91524117a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Delanoy?= frederic.dela...@gmail.com
Date: Tue, 27 Jul 2010 11:22:49 +0200
Subject: Update French translation of 'About Wine' page

---
 templates/fr/about.template |   77 --
 1 files changed, 37 insertions(+), 40 deletions(-)

diff --git a/templates/fr/about.template b/templates/fr/about.template
index 68629e2..f989cd7 100644
--- a/templates/fr/about.template
+++ b/templates/fr/about.template
@@ -1,49 +1,46 @@
 !--TITLE:[À propos de Wine]--
 !--BLURB:[Qu'est-ce que Wine et à quoi sert-il exactement ?]--
 
-h1 class=titleÀ propos de Wine/h1
-
-pWine est une couche de traduction (un chargeur de programme) capable 
d'exécuter
-des applications Windows sous Linux et d'autres systèmes d'exploitation 
compatibles
-POSIX. Les programmes Windows exécutés par Wine agissent comme le feraient 
des programmes natifs,
-c'est à dire sans pénalités de performances ou d'utilisation de mémoire 
(ce qui serait le cas avec un émulateur) et
-avec un aspect et une utilisation similaire aux autres applications de votre 
environnement de travail./p
-
-pLe projet Wine a débuté en 1993 comme un moyen d'exécuter des
-programmes Windows 3.1 sous Linux. Bob Amstadt était le coordinateur
-à l'origine, mais Alexandre Julliard a rapidement pris le relai et 
-continue de gérer le projet jusqu'à aujourd'hui. Au cours des années 
-le projet a été porté pour d'autres Unixes et le support pour les 
applications
-Win32 a été ajouté au fur et à mesure que celles-ci sont devenues 
populaires./p
-
-pWine est toujours en cours de développement et n'est pas prévu pour une 
utilisation 
-générale. Néanmoins, de nombreuses personnes le trouve utile pour exécuter 
un nombre
-grandissant de programmes Windows. Veuillez vous rapporter à la
-a href=http://appdb.winehq.org/;base de données des applications/a
-pour des rapports concernant le succès ou l'échec de l'exécution de 
centaines de programmes
-Windows, ainsi qu'à la a href=http://bugs.winehq.org/;base de données de 
suivi des
-anomalies/a pour une liste des problèmes connus et, finalement, à la page
-a href={$root}/statusÉtat/a pour une vue globale de l'état 
d'implémentation de Wine./p
-
-pUne grande partie des développeurs de Wine peuvent être contactés dans 
les
-a href={$root}/forumsforums de Wine/a. Les commentaires à propos du 
site winehq.org
-peuvent être envoyés par courriel à a
-href=mailto:web-admin_at_winehq.org;web-admin_at_winehq.org/a. Alexandre
-Julliard mène le projet Wine et peut être contacté par courriel à
-a href=mailto:julliard_at_winehq.org;julliard_at_winehq.org/a./p
-
-pNous avons également mis en place une courte liste de resources qui vous 
aideront a comprendre le projet :/p
+h1 class=titleAbout Wine/h1
+
+pWine vous permet d'exécuter des logiciels Windows sous d'autres systèmes
+d'exploitation. Avec Wine, vous pouvez installer et exécuter ces applications,
+exactement comme vous le feriez sous Windows./p
+
+pWine est toujours en cours de développement actif. Tous les programmes ne
+fonctionnent pas encore, mais il y a déjà a
+href=http://wiki.winehq.org/UsageStatistics; title=Statistiques d'utilisation
+de Wineplusieurs millions de personnes/a qui utilisent Wine pour faire
+tourner leurs logiciels./p
+
+h3Open Source et conduit par ses utilisateurs/h3
+
+pWine sera toujours du a href=http://wiki.winehq.org/Licensing;
+title=Licence de Winelogiciel libre/a. À peu près la moitié du code 
source
+de Wine est écrite par des volontaires. Le reste est sponsorisé par des 
intérêts
+commerciaux, en particulier a href=http://www.codeweavers.com/products/;
+title=Codeweavers Crossover OfficeCodeweavers/a qui vend une version de
+Wine avec du support./p
+
+pWine dépend fortement de sa communauté d'utilisateurs. Les tests des
+utilisateurs composant notre a href=http://appdb.winehq.org/; title=Base de
+données d'applications de WineBase de données d'applications/a 
permettent de
+vérifier la façon dont les programmes fonctionnent, et toutes les réponses 
des a
+href=http://forums.winehq.org/; title=Forums WineHQforums/a proviennent 
de
+volontaires./p
+
+h3En savoir plus :/h3
 ul
-lia href={$root}/historyL'historique de Wine/a/li
-lia href={$root}/whyPourquoi Wine est-il si important ?/a/li
-lia href={$root}/mythsDémonter les mythes sur Wine/a/li
-lia href={$root}/wine_featuresFonctionnalités de Wine/a/li
-lia href={$root}/acknowledgementRemerciements/a/li
-lia href={$root}/wwnWorld Wine News : les nouvelles de Wine/a/li
-lia href={$root}/interviewInterviews/a/li
+lia href=http://wiki.winehq.org/ImportanceOfWine;Pourquoi Wine est-il
+si important/a/li
+lia href=http://wiki.winehq.org/Debunking_Wine_Myths;Mythes courants
+sur Wine/a/li
+lia href=http://wiki.winehq.org/WineHistory;Historique du projet 
Wine/a/li
+

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread testbot 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3956

Your paranoid android.


=== W98SE (32 bit) ===
No test summary line found

=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W2K8SE (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

Re: dmusic: use a previously unused variable (try 3)

2010-07-27 Thread Octavian Voicu 
On Tue, Jul 27, 2010 at 9:36 AM, Austin English austinengl...@gmail.com wrote:
 Try 3: Use tabs, not spaces.
 Try 2: return hr, free memory

There's still a memory leak in this function if
IDirectMusicPortImpl_QueryInterface fails. Would be nice to fix that
also :)

Octavian

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread Jacek Caban 

 On 7/27/10 12:18 PM,  (Marvin) wrote:

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3956

Your paranoid android.


This is a problem that I change files in test directory that are stored in 
resources, so Test Bot doesn't know, which test should it run. Can we do 
something about it? There are a few options that come to my mind:


- Add magic keyword that would be present in patch mail telling which tests 
should be ran
- Detect that the patched file is not a test file and run all tests 
corresponding to dll or ignore the patch

- Store a map associating such files with tests somewhere

Jacek

Re: [2/2] ntdll: Fix the status code for ProcessDebugObjectHandle class in NtQueryInformationProcess when the debugger is ab

2010-07-27 Thread testbot 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3961

Your paranoid android.


=== WINEBUILD (build) ===
Make failed

Re: mshtml: Improve status messages sent to IOleInPlaceFrame

2010-07-27 Thread Alexander Nicolaysen Sørnes 
 Mandag 26. juli 2010 15.59.55 skrev Jacek Caban :
   Hi Alexander,
 
 On 7/26/10 11:36 AM, Alexander Nicolaysen Sørnes wrote:
  In preparation for adding a status bar to Wine's IE
 
 -static const WCHAR wszDone[] = {'D','o','n','e',0};
 +static WCHAR wszDone[40] = { 0 };
 +
 +if(!wszDone[0])
 +LoadStringW(hInst, IDS_DONE, wszDone,
  sizeof(wszDone)/sizeof(wszDone[0]));
  IOleInPlaceFrame_SetStatusText(doc_obj-frame, wszDone);
 
 
 
 SetStatusText call really deserves a helper function that would take care
 of loading the string resources instead of duplicating the code.
 
 @@ -44,6 +45,7 @@ typedef struct {
   task_t header;
   HTMLDocumentObj *doc;
   BOOL set_download;
 +BSTR url;
   } download_proc_task_t;
 
 
 You don't need this, URL is stored in HTMLWindow object at this point.
 
 
 Jacek
 


Thanks! I'll make a new version



Alexander N. Sørnes

Re: [1/2] d3dx9: Implement missing D3DXCreateTextureFromFile functions

2010-07-27 Thread Henri Verbeet 
On 26 July 2010 23:05, Owen Rudge o...@owenrudge.net wrote:
 +HRESULT WINAPI D3DXCreateTextureFromFileInMemory(LPDIRECT3DDEVICE9 device,
 + LPCVOID srcdata,
 + UINT srcdatasize,
 + LPDIRECT3DTEXTURE9 *texture)
Please don't use those, just write IDirect3DTexture9 **, const void
*, etc. Also, srcdatasize is unsigned.

 +TRACE((void): relay\n);
That's doesn't really match the function arguments.

Re: [2/2] d3dx9: Implement D3DXCreateTextureFromFileInMemoryEx

2010-07-27 Thread Henri Verbeet 
On 26 July 2010 23:05, Owen Rudge o...@owenrudge.net wrote:
 +if ((filter  0x)  D3DX_FILTER_BOX  filter != D3DX_DEFAULT)
 +return D3DERR_INVALIDCALL;
 +
 +if ((mipfilter  0x)  D3DX_FILTER_BOX  mipfilter != D3DX_DEFAULT)
 +return D3DERR_INVALIDCALL;
 +
 +if (!filter || !mipfilter)
 +return D3DERR_INVALIDCALL;
I think those should be handled implicitly by
D3DXLoadSurfaceFromFileInMemory() / D3DXFilterTexture(). Provided you
check the return values anyway.

 +if (filter == D3DX_DEFAULT)
 +filter = D3DX_FILTER_TRIANGLE | D3DX_FILTER_DITHER;
 +
 +if (mipfilter == D3DX_DEFAULT)
 +mipfilter = D3DX_FILTER_BOX;
Same.

 +if (width == 0 || width == D3DX_DEFAULT_NONPOW2)
 +width = imginfo.Width;
Probably depends on the device supporting NPOT textures again.

 +if ((pool != D3DPOOL_DEFAULT)  (usage != D3DUSAGE_DYNAMIC))
Dynamic textures are a device capability.

Re: [3/4] shdocvw: Add and use AdviseSinkInerface for IE

2010-07-27 Thread Jacek Caban 

 On 7/27/10 1:25 PM, Alexander Nicolaysen Sørnes wrote:

This will be used to change the address bar URL when navigating to new pages


+*ppvoid = NULL;
+if(IsEqualGUID(IID_IAdviseSink, riid))

You also need to handle IUnknown.

+{
+*ppvoid = iface;
+AdviseSink_AddRef(iface);

Direct call to interface function is not really nice.

+typedef struct _AdviseSink {
+const IAdviseSinkVtbl *lpAdviseSinkVtbl;
+LONG ref;
+DocHost* doc_host;
+} AdviseSink;

Is there any reason to make it a separated struct?

Also, you don't need it for URL change notification. We already have better way 
of doing that in shdocvw. See IPropertyNotifySink related code.


Jacek

Re: ddraw: Ensure fullscreen size of fullscreen windows

2010-07-27 Thread Johan Gill 
On Tue, Jul 27, 2010 at 12:22 PM, Stefan Dösinger
stefandoesin...@gmx.at wrote:

 Am 27.07.2010 um 00:19 schrieb Johan Gill:

 This patch fixes the long-standing regression bug 17215.

 Enjoy, and provide feedback if you don't ;)
 17215.txt
 Usually wined3d does the window setup. I recommend to take a look at 
 WineD3D's AcquireFocusWindow and SetDisplayMode

 The problem is somewhat more complicated though - there's 
 swapchain_setup_fullscreen_window and swapchain_restore_fullscreen_window, 
 but wined3ddevice::Setdisplaymode doesn't call the swapchain(because there 
 may not be one if ddraw hasn't created the primary surface yet).



I would say that we need to pull the WineD3DDevice into the game as
soon as we go fullscreen then. I didn't look that closely on that code
yet, but I guess it takes some changes there to have it fly without a
surface.

/Johan Gill

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread Nicolas Le Cam 
2010/7/27 Jacek Caban ja...@codeweavers.com:
  On 7/27/10 12:18 PM,  (Marvin) wrote:

 Hi,

 While running your changed tests on Windows, I think I found new failures.
 Being a bot and all I'm not very good at pattern recognition, so I might
 be
 wrong, but could you please double-check?
 Full results can be found at
 http://testbot.winehq.org/JobDetails.pl?Key=3956

 Your paranoid android.

 This is a problem that I change files in test directory that are stored in
 resources, so Test Bot doesn't know, which test should it run. Can we do
 something about it? There are a few options that come to my mind:

 - Add magic keyword that would be present in patch mail telling which tests
 should be ran
 - Detect that the patched file is not a test file and run all tests
 corresponding to dll or ignore the patch
 - Store a map associating such files with tests somewhere

 Jacek



If resource files are only used by one testset a simple option could
be to name it like the source file and change the testbot to handle
that :

--- a/lib/WineTestBot/Patches.pm2010-07-27 13:58:41 +0200
+++ b/lib/WineTestBot/Patches.pm2010-07-27 14:10:07 +0200
@@ -102,7 +102,7 @@
 my $FileType = patch$1;
 my $BaseName = $2;
 my $TestSet = $3;
-if ($TestSet =~ m/^(.*)\.c$/)
+if ($TestSet =~ m/^(.*)\..*$/)
 {
   $TestSet = $1;
 }

-- 
Nicolas Le Cam

Re: [2/6] richedit: EN_UPDATE notification is sent on WM_PAINT.

2010-07-27 Thread Dylan Smith 
On Mon, Jul 26, 2010 at 3:48 PM, Dylan Smith dylan.ah.sm...@gmail.comwrote:

 On Mon, Jul 26, 2010 at 3:26 PM, James Mckenzie 
 jjmckenzi...@earthlink.net wrote:


 Just a question, I don't see 1/6 in this sequence. Was it submitted
 earlier?

 I sent it, but somehow it must have gotten lost along its digital path.
  It shows up in my gmail sent mail folder.


I have tried re-submitting the patch two more times, and both times the
email didn't turn up in the wine-patches archive.

I'm attaching the patch in case it gets through here, but I don't know how
to get it to not get filtered as spam on wine-patches.

changelog:
richedit: Only get cursor coordinates if we need them in ME_MoveCaret.
diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c
index 5750db9..ce8e36e 100644
--- a/dlls/riched20/caret.c
+++ b/dlls/riched20/caret.c
@@ -252,18 +252,16 @@ ME_GetCursorCoordinates(ME_TextEditor *editor, ME_Cursor 
*pCursor,
 }
 
 
-void
-ME_MoveCaret(ME_TextEditor *editor)
+void ME_MoveCaret(ME_TextEditor *editor)
 {
   int x, y, height;
 
+  if (!editor-bHaveFocus || ME_IsSelection(editor))
+return;
   ME_GetCursorCoordinates(editor, editor-pCursors[0], x, y, height);
-  if(editor-bHaveFocus  !ME_IsSelection(editor))
-  {
-x = min(x, editor-rcFormat.right-1);
-ITextHost_TxCreateCaret(editor-texthost, NULL, 0, height);
-ITextHost_TxSetCaretPos(editor-texthost, x, y);
-  }
+  x = min(x, editor-rcFormat.right - 1);
+  ITextHost_TxCreateCaret(editor-texthost, NULL, 0, height);
+  ITextHost_TxSetCaretPos(editor-texthost, x, y);
 }

Ukrainian translation of Wine at 100%

2010-07-27 Thread Paul Vriens 

Hi,

And Ukrainian is also at a 100% !!!

Thanks go to Igor for his efforts in getting us this far.

--
Cheers,

Paul.

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Matteo Bruni 
2010/7/27 Henri Verbeet hverb...@gmail.com:
 On 26 July 2010 21:21, Matteo Bruni matteo.myst...@gmail.com wrote:
 // ID3D10Blob has been made version-neutral and moved to d3dcommon.h.

 Actually, since this comes up now, perhaps this is a good time to
 think about implementing d3dcompiler and d3dx10? I think we'll have to
 anyway at some point, and perhaps it's better to do this now instead
 of once there's much more code in d3d10.


Yes, this is the best time I believe. Some time ago there was
agreement to implement the shader compiler in d3dcompiler, with the
d3dx9/d3d10/d3dx10 compiler function calls forwarding to d3dcompiler.
My plan for the immediate future is to stub out d3dcompiler_43.dll and
then move the shader assembler there (forwarding D3DXAssembleShader to
d3dcompiler's D3DAssemble, which is undocumented but stable in the
last 3 DirectX SDK) to be able to reuse some assembler code for the
compiler implementation. I have some patches in my local git, they
just need a bit of cleanup. Should I proceed with my plan?

GetVolumeInformationA: please test this on MS-Windows

2010-07-27 Thread Joerg-Cyril.Hoehle 
Hi,

Wine's testbot job #3910 at http://testbot.winehq.org/JobDetails.pl?Key=3910
contains one binary downloadable via 
http://testbot.winehq.org/GetFile.pl?JobKey=3910StepKey=1
that I'd like people to test esp. on Win9X machines (virtual or real). Please 
invoke it as

wintest.exe volume # or X:\path\to\wintest.exe volume

Please start it from *another* drive than C: (where your Windows directory is
located) or it will skip the important test:
volume.c:406: Tests skipped: Please re-run from another device than C:
That's why testbot is not good enough here: its machines only have a single 
drive, C:

Normal output on Win9X will be:
volume.c:326: Test failed: info: GetVolumeInformationA did fail, 
current=C:\winetest, last error 161
volume.c:342: Test failed: GetVolumeInformationA did not fail, last error 161
volume.c:422: Test failed: GetVolumeInformationA failed, root=\\?\C:\, last 
error=53
volume.c:428: Test failed: GetVolumeInformationA failed, root=\\.\C:\, last 
error=53
volume.c:434: Test failed: GetVolumeInformationA failed, root=C:\WINDOWS\, last 
error=161
volume.c:440: Test failed: GetVolumeInformationA failed, root=C:\WINDOWS, last 
error=161
Normal output on more recent OS:
volume.c:326: Test failed: info: GetVolumeInformationA did fail, 
current=C:\winetest, last error 123
[other skipped tests not mentioned]

The test in line 326 always fails in order to show what happens on the current 
directory. Try it out
by starting from different directories.

See bugs #23355 and #20887 about GetVolumeInformationA.

Thank you very much,
 Jörg Höhle

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Henri Verbeet 
On 27 July 2010 16:37, Matteo Bruni matteo.myst...@gmail.com wrote:
 Yes, this is the best time I believe. Some time ago there was
 agreement to implement the shader compiler in d3dcompiler, with the
 d3dx9/d3d10/d3dx10 compiler function calls forwarding to d3dcompiler.
 My plan for the immediate future is to stub out d3dcompiler_43.dll and
 then move the shader assembler there (forwarding D3DXAssembleShader to
 d3dcompiler's D3DAssemble, which is undocumented but stable in the
 last 3 DirectX SDK) to be able to reuse some assembler code for the
 compiler implementation. I have some patches in my local git, they
 just need a bit of cleanup. Should I proceed with my plan?

You should probably check with Alexandre to make sure, but makes sense
to me. I think the effect parsing stuff doesn't interact too much with
d3dcompiler, and should go into d3dx10.

Re: GetVolumeInformationA: please test this on MS-Windows

2010-07-27 Thread Austin English 
On Tue, Jul 27, 2010 at 9:42 AM,  joerg-cyril.hoe...@t-systems.com wrote:
 Hi,

 Wine's testbot job #3910 at http://testbot.winehq.org/JobDetails.pl?Key=3910
 contains one binary downloadable via 
 http://testbot.winehq.org/GetFile.pl?JobKey=3910StepKey=1
 that I'd like people to test esp. on Win9X machines (virtual or real). Please 
 invoke it as

 wintest.exe volume # or X:\path\to\wintest.exe volume

 Please start it from *another* drive than C: (where your Windows directory is
 located) or it will skip the important test:
 volume.c:406: Tests skipped: Please re-run from another device than C:
 That's why testbot is not good enough here: its machines only have a single 
 drive, C:

 Normal output on Win9X will be:
 volume.c:326: Test failed: info: GetVolumeInformationA did fail, 
 current=C:\winetest, last error 161
 volume.c:342: Test failed: GetVolumeInformationA did not fail, last error 161
 volume.c:422: Test failed: GetVolumeInformationA failed, root=\\?\C:\, last 
 error=53
 volume.c:428: Test failed: GetVolumeInformationA failed, root=\\.\C:\, last 
 error=53
 volume.c:434: Test failed: GetVolumeInformationA failed, root=C:\WINDOWS\, 
 last error=161
 volume.c:440: Test failed: GetVolumeInformationA failed, root=C:\WINDOWS, 
 last error=161
 Normal output on more recent OS:
 volume.c:326: Test failed: info: GetVolumeInformationA did fail, 
 current=C:\winetest, last error 123
 [other skipped tests not mentioned]

 The test in line 326 always fails in order to show what happens on the 
 current directory. Try it out
 by starting from different directories.

 See bugs #23355 and #20887 about GetVolumeInformationA.

On my work machine the only non-C drives are network drives, but that
result is interesting as well:
volume.c:322: CurrentDirectory is F:\
volume.c:326: Test failed: info: GetVolumeInformationA did not fail,
current=F:\, last error 3735928559
volume: 297 tests executed (0 marked as todo, 1 failure), 0 skipped.

F: is a samba served network share. Machine is XP SP3.

-- 
-Austin

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Matteo Bruni 
2010/7/27 Henri Verbeet hverb...@gmail.com:
 On 27 July 2010 16:37, Matteo Bruni matteo.myst...@gmail.com wrote:
 Yes, this is the best time I believe. Some time ago there was
 agreement to implement the shader compiler in d3dcompiler, with the
 d3dx9/d3d10/d3dx10 compiler function calls forwarding to d3dcompiler.
 My plan for the immediate future is to stub out d3dcompiler_43.dll and
 then move the shader assembler there (forwarding D3DXAssembleShader to
 d3dcompiler's D3DAssemble, which is undocumented but stable in the
 last 3 DirectX SDK) to be able to reuse some assembler code for the
 compiler implementation. I have some patches in my local git, they
 just need a bit of cleanup. Should I proceed with my plan?

 You should probably check with Alexandre to make sure, but makes sense
 to me. I think the effect parsing stuff doesn't interact too much with
 d3dcompiler, and should go into d3dx10.


Will do. Not sure on the effect stuff: on
http://msdn.microsoft.com/en-us/library/dd607324%28v=VS.85%29.aspx the
D3DCompile input is described as a pointer to uncompiled shader data;
either ASCII HLSL code or a compiled effect, but some tests are
required to see what that really means.

Re: GetVolumeInformationA: please test this on MS-Windows

2010-07-27 Thread Andrew Eikum 

On 07/27/2010 09:42 AM, joerg-cyril.hoe...@t-systems.com wrote:

Hi,

Wine's testbot job #3910 at http://testbot.winehq.org/JobDetails.pl?Key=3910
contains one binary downloadable via 
http://testbot.winehq.org/GetFile.pl?JobKey=3910StepKey=1
that I'd like people to test esp. on Win9X machines (virtual or real).


Run on a Win98SE VM.  The E drive is a CDROM drive.

E:\wintest.exe volume
volume.c:45: Tests skipped: On win9x, HARDDISK and RAMDISK not present
volume.c:87: Tests skipped: FindFirstVolumeA not found
volume.c:123: Tests skipped: GetVolumeNameForVolumeMountPointA not found
volume.c:197: Tests skipped: GetVolumeNameForVolumeMountPointW not found
volume.c:268: Tests skipped: GetLogicalDriveStringsW not implemented
volume.c:322: CurrentDirectory is E:\
volume.c:326: Test failed: info: GetVolumeInformationA did not fail, 
current=E:\, last error 120
volume.c:342: Test failed: GetVolumeInformationA did not fail, last 
error 161

volume.c:366: Test failed: GetVolumeInformationA did fail, last error 161
volume.c:378: Test failed: GetVolumeInformationA did fail, last error 161
volume.c:422: Test failed: GetVolumeInformationA failed, root=\\?\C:\, 
last error=53
volume.c:428: Test failed: GetVolumeInformationA failed, root=\\.\C:\, 
last error=53
volume.c:434: Test failed: GetVolumeInformationA failed, 
root=C:\WINDOWS\, last error=161
volume.c:440: Test failed: GetVolumeInformationA failed, 
root=C:\WINDOWS, last error=161

volume.c:444: Tests skipped: GetVolumeNameForVolumeMountPointA not found
volume.c:472: Tests skipped: GetVolumeNameForVolumeMountPointA not found
volume: 46 tests executed (0 marked as todo, 8 failures), 7 skipped.

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Henri Verbeet 
On 27 July 2010 17:04, Matteo Bruni matteo.myst...@gmail.com wrote:
 Will do. Not sure on the effect stuff: on
 http://msdn.microsoft.com/en-us/library/dd607324%28v=VS.85%29.aspx the
 D3DCompile input is described as a pointer to uncompiled shader data;
 either ASCII HLSL code or a compiled effect, but some tests are
 required to see what that really means.

Odd, I'd expect compiled effects to also have compiled shaders. If
it's just about extracting the shader blobs that's easy though, you
don't need a full effect parser for that.

Re: [1/2] shlwapi/tests: Skip on invalid security descriptor to avoid exception

2010-07-27 Thread testbot 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3964

Your paranoid android.


=== W2KPROSP4 (32 bit ordinal) ===
ordinal.c:607: Test failed: GetShellSecurityDescriptor should fail
ordinal.c:1962: Test failed: got 0x00393939, expected 0x0080. Key 
{2AD91900-A873-11cf-9A80-00AA00C16E65}
ordinal.c:1962: Test failed: got 0x00393939, expected 0x0121. Key 
{DB8DC413-C0AA-11D0-9545-080009B1C2F3}

=== WVISTAADM (32 bit ordinal) ===
No test summary line found

=== W7PRO (32 bit ordinal) ===
ordinal.c:1780: Test failed: got 26
ordinal.c:1830: Test failed: got 26
ordinal.c:1838: Test failed: got 26
ordinal.c:1846: Test failed: got 37, length 38
ordinal.c:1857: Test failed: got 40

=== W7PROX64 (64 bit ordinal) ===
ordinal.c:1774: Test failed: got 10
ordinal.c:1795: Test failed: got 7
ordinal.c:1808: Test failed: got 10
ordinal.c:1816: Test failed: got 10
ordinal.c:1846: Test failed: got 33, length 34
ordinal.c:1857: Test failed: got 36
ordinal.c:1868: Test failed: got 20
ordinal.c:1879: Test failed: got 23

Re: [2/2] shlwapi/ordinal: Partially implement SHGetShellKey

2010-07-27 Thread testbot 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3965

Your paranoid android.


=== W2KPROSP4 (32 bit ordinal) ===
ordinal.c:609: Test failed: GetShellSecurityDescriptor should fail
ordinal.c:1964: Test failed: got 0x00393939, expected 0x0080. Key 
{2AD91900-A873-11cf-9A80-00AA00C16E65}
ordinal.c:1964: Test failed: got 0x00393939, expected 0x0121. Key 
{DB8DC413-C0AA-11D0-9545-080009B1C2F3}

=== WVISTAADM (32 bit ordinal) ===
No test summary line found

=== W7PRO (32 bit ordinal) ===
ordinal.c:1782: Test failed: got 26
ordinal.c:1832: Test failed: got 26
ordinal.c:1840: Test failed: got 26
ordinal.c:1848: Test failed: got 37, length 38
ordinal.c:1859: Test failed: got 40

=== W7PROX64 (64 bit ordinal) ===
ordinal.c:1776: Test failed: got 10
ordinal.c:1797: Test failed: got 7
ordinal.c:1810: Test failed: got 10
ordinal.c:1818: Test failed: got 10
ordinal.c:1848: Test failed: got 33, length 34
ordinal.c:1859: Test failed: got 36
ordinal.c:1870: Test failed: got 20
ordinal.c:1881: Test failed: got 23

Re: [PATCH 02/11] d3d10: Implement D3D10CreateBlob().

2010-07-27 Thread Rico Schüller 

Am 27.07.2010 00:55, schrieb Henri Verbeet:

2010/7/26 Rico Schüllerkgbric...@web.de:
   

+IUnknown_Release((IUnknown *)object);
 

Since you'll probably resend this anyway based on Matteo's comment, I
think just HeapFree() should do just as well. Also, I don't have a
recent enough DX SDK to check at the moment, but if d3dcommon.h is
generated by IDL, it will mostly likely have proper COM macros for
ID3D10Blob as well.


   
Yeah, I'll resend the patches after Matteo's patch is in. I'll check the 
suggestions.

The Bugzilla Project is interested in hearing about your feedback

2010-07-27 Thread Frédéric Buclin 
Hello dear Bugzilla maintainers and administrators,

I am Frédéric LpSolit Buclin, the QA lead and one of the two assistant
project leads for the Bugzilla project. You are receiving this email
because you have already been contacted by Max Kanat-Alexander (mkanat)
some time ago when he did a survey about Bugzilla, or because you have
been CC'ed to two notable security bugs in 2009, from where I took your
email addresses.

A few days ago, core Bugzilla developers were talking about relaxing a
security policy, and we couldn't come to an agreement because some of us
disagree to relax this policy, while some others are fine with this
change. We realized that the lack of agreement was because we didn't
have enough data from real Bugzilla installations, and that having
feedback from maintainers and administrators of large and popular
Bugzilla installations was important in this process. Now you probably
see why you are getting this email, aren't you? :)

The proposed idea is to create a new mailing-list, containing mostly
maintainers and administrators of main and popular Bugzilla
installations, to discuss security policy changes and major UI changes.
This mailing-list should be low-traffic (I don't expect more than 2-4
threads per year). To be clear, we are not going to talk about technical
aspects of Bugzilla; important back-end changes being already discussed
in develop...@bugzilla.org. Also, we are not going to talk about minor
UI changes, those changes being discussed with the UI lead. The goal of
this mailing-list is only to get feedback from you, to know how a
security policy change or a major UI change would affect your
installation and your users, based on your work flow and based on your
own management. So this is a good opportunity to let us know how you
would be affected by such or such change.

So in order to create the mailing-list, I need to know who would be
willing to be in this list and give us their feedback. There will be a
way to unsubscribe, in case you are no longer interested to participate.
Your feedback is important to us!

Please let me know if you are interested or not (with a short reminder
about which Bugzilla installation you maintain, to make sure I'm
up-to-date), so that we can add you to this new mailing-list. The first
topic will be about the security policy change I talked earlier.


Best regards,

Frédéric Buclin

Re: ddraw: Ensure fullscreen size of fullscreen windows

2010-07-27 Thread Johan Gill 
On Tue, Jul 27, 2010 at 1:44 PM, Johan Gill johan.g...@gmail.com wrote:
 On Tue, Jul 27, 2010 at 12:22 PM, Stefan Dösinger
 stefandoesin...@gmx.at wrote:

 Usually wined3d does the window setup. I recommend to take a look at 
 WineD3D's AcquireFocusWindow and SetDisplayMode

 The problem is somewhat more complicated though - there's 
 swapchain_setup_fullscreen_window and swapchain_restore_fullscreen_window, 
 but wined3ddevice::Setdisplaymode doesn't call the swapchain(because there 
 may not be one if ddraw hasn't created the primary surface yet).



 I would say that we need to pull the WineD3DDevice into the game as
 soon as we go fullscreen then. I didn't look that closely on that code
 yet, but I guess it takes some changes there to have it fly without a
 surface.

 /Johan Gill


Hmm, I need to read up on the wined3d-ddraw interaction a bit before
trying to say anything further. Anyway, I just submitted a patch with
just the new test case.

/Johan Gill

Re: ddraw: Added a todo_wine test for SetCooperativeLevel

2010-07-27 Thread testbot 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3977

Your paranoid android.


=== W98SE (32 bit ddrawmodes) ===
No test summary line found

=== W7PROX64 (64 bit ddrawmodes) ===
Timeout

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-27 Thread Scott Ritchie 
On 07/26/2010 03:57 AM, Alexandre Julliard wrote:
 Damjan Jovanovic damjan@gmail.com writes:
 
 diff --git a/tools/Makefile.in b/tools/Makefile.in
 index a9ec324..a0c9c99 100644
 --- a/tools/Makefile.in
 +++ b/tools/Makefile.in
 @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS)
  $(INSTALL_DATA) $(SRCDIR)/l_intl.nls 
 $(DESTDIR)$(datadir)/wine/l_intl.nls
  $(INSTALL_DATA) $(SRCDIR)/wine.desktop 
 $(DESTDIR)$(datadir)/applications/wine.desktop
  -$(UPDATE_DESKTOP_DATABASE)
 +gconftool --set -t string 
 /desktop/gnome/thumbnailers/applicat...@x-ms-shortcut/command wine 
 winemenubuilder -t %i %o || true
 +gconftool --set -t bool 
 /desktop/gnome/thumbnailers/applicat...@x-ms-shortcut/enable true || true
 
 There needs to be a better way of doing this. Probably filing a bug with
 freedesktop.org is in order.
 

For sure.  Thumbnailers are just shell scripts, but there is currently
no cross distro way to enable them.

My current solution is to just do this at the packaging layer and
ignore KDE entirely until someone tells me the equivalent of installing
gconf schemas, but this is obviously not good.

Thanks,
Scott Ritchie