Re: user32: FindWindow() should treat an empty title same way as NULL. (Resend)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6315 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = win.c:2684: Test failed: GetFocus() = win.c:2710: Test failed: GetActiveWindow() = win.c:2710: Test failed: GetFocus() = win.c:2769: Test failed: GetActiveWindow() = win.c:2769: Test failed: GetFocus() = === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = win.c:2684: Test failed: GetFocus() = win.c:2710: Test failed: GetActiveWindow() = win.c:2710: Test failed: GetFocus() = win.c:2769: Test failed: GetActiveWindow() = win.c:2769: Test failed: GetFocus() =
Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )
On Mon, 2010-10-18 at 18:10 +0200, Tomasz Michno wrote: +/* unfortunately GetProcAddress cannot return proper pointer to from_bmformat() function, but for this function it's not a problem, using copy from ../transform.c */ That's not how it's done in Wine, you will need to go through the API. In this case that means you need to define a bitmap in the appropriate format, create a color transform and then call TranslateBitmapBits. Note that Wine doesn't bundle a color profile, so you need to install one, or configure your X server to use one and retrieve it via GetICMProfile.
Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
Adam Martinson amartin...@codeweavers.com writes: --- dlls/msxml3/tests/schema.c | 438 +--- 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series numbered from 1 so that winetestbot can figure it out. -- Alexandre Julliard julli...@winehq.org
Re: Translation of the AppDB
On Tue, Oct 19, 2010 at 12:40 AM, Austin English austinengl...@gmail.comwrote: On Sun, Oct 17, 2010 at 3:59 AM, Yaron Shahrabani sh.ya...@gmail.com wrote: Is there any way to localize the AppDB? The Israeli community assumes that having a Hebrew system will make more users report issues. It seems unlikely. There are many different languages used by wine's users, and English is the most common understood by users/developers. All bug reports/AppDB/etc. are in English. I see but I had another idea in mind... I was thinking about having the possibility to rate and report but without any way to comment, I mean that you cannot comment in foreign languages but you can vote and report (any operation that requires clicking is OK, typing is not). Having different languages available would probably lead to a lot of information being lost across the different language sections. That's why commenting is not an option :) Is this a better suggestion? -- -Austin
Re: Reflection interfaces
2010/10/18 Rico Schüller kgbric...@web.de: What's the preferred way to implement the different interfaces? 1. Implement a parser which parses the shader (RDEF, STAT), and implement 4 independent interfaces (each in its own dll). Only reuse the parser. 2. Like 1, but all 4 implementations have there own parser, which leads to a lot of duplicated code. But it is the most flexible way. It could easily parse all possible shader blobs (theoretically they could differ from version to version, I have no test for that, yet). 3. Forward all interfaces to d3dcompiler_43.dll and this will contain all interfaces and the parser. This way the codebase is the smallest possible one, but it will offer all interfaces, which isn't what native does. Also all further interfaces would go to d3dcompiler_43.dll. This could get tricky. I'm not sure. The problem with 3 is that it will prevent using the native d3dcompiler to work around e.g. the missing HLSL compiler because it doesn't implement ID3D10ShaderReflection etc. Perhaps we don't care in the long term, but at least in the short term that would be a problem. Option 1 would require d3dcompiler to have some private interface or entry point, and you'd still have the same problem as with option 3. Option 2 leads to duplicated code. There may be an option 4 though, which would be to implement the older interfaces on top of ID3D11ShaderReflection. I.e., you'd use the information you get from the ID3D11ShaderReflection interface to construct constant buffers and variables for the other interfaces, instead of parsing the shader bytecode yourself. It would need some investigation to determine how feasible this option is.
Re: [PATCH 3/3] jscript: Add index, input and lastIndex properties to regexp funtions results
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6322 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
About: d3dx9: Store transform matrix per-sprite.
Hello,
In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like:
int i, count, start;
/* ... */
for(start=0;startThis-sprite_count;start+=count,count=0) {
i=start;
while(iThis-sprite_count
(count==0 ||
This-sprites[i].texture==This-sprites[i-1].texture)) {
/* filling in array */
}
/* rest of the outer loop, using array and count */
}
It seems count is used uninitialised here on the first iteration ?
HTH,
Joris
Re: About: d3dx9: Store transform matrix per-sprite.
2010/10/19 Joris Huizer joris_hui...@yahoo.com:
Hello,
In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like:
int i, count, start;
/* ... */
for(start=0;startThis-sprite_count;start+=count,count=0) {
i=start;
while(iThis-sprite_count
(count==0 ||
This-sprites[i].texture==This-sprites[i-1].texture)) {
/* filling in array */
}
/* rest of the outer loop, using array and count */
}
It seems count is used uninitialised here on the first iteration ?
HTH,
Joris
Argh! You're absolutely right. Apparently it managed to work fine for
me so I didn't notice that silly mistake...
Thank you, I'll send a fix immediately.
Re: Surprise surprise, Tmax Window OS was a complete hoax
Scott Ritchie sc...@open-vote.org wrote: About a year or so ago a Korean company called Tmax was claiming to have developed a new operating system that was 100% fully Windows compatible. They also claimed to have their own office suite, web browser, and more, all developed with their own special Korean engineering to keep the license proprietary. And they would be 'busted' anyway as Korea is one of the signaturs to the World Digital Copyright agreement. Thanks for seeing them for what they were: False. James McKenzie
Re: Translation of the AppDB
On Tue, 19 Oct 2010 12:12:33 +0200 Yaron Shahrabani sh.ya...@gmail.com wrote: I see but I had another idea in mind... I was thinking about having the possibility to rate and report but without any way to comment, I mean that you cannot comment in foreign languages but you can vote and report (any operation that requires clicking is OK, typing is not). It's not possible to report without typing, and ratings without the typed information as to why the user gave the app that rating would be at best useless (Why is this silver? What doesn't work?), and at worst misleading. False platinums in particular are already a big problem: users give an app a platinum rating, but list tweaks they applied (so it really should be gold) or things that didn't work (so it really should be silver). Admins and maintainers need that typed information to assess whether a rating is correct. -- Rosanne DiMesio dime...@earthlink.net
Re: [1/2] windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle (try 2).
Krzysztof Nowicki kri...@op.pl writes: I've decided to keep the optimisation in copy_pixels() that checks if the source and dest rectangles + strides matches and if yes, does a straight memcpy of the whole bitmap. Please do this as a separate patch. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )
Hi, That's not how it's done in Wine, you will need to go through the API. In this case that means you need to define a bitmap in the appropriate format, create a color transform and then call TranslateBitmapBits. I thought that I only need to test function which I modified, so I created tests in that way. Now I'm modifying them to use TranslateBitmapBits. Should I resend the whole patch or only create one new with only tests/transform.c? I tested wine with my modification with different images (including raw's) and applications and all works well. thanks for your time and help Tomasz Michno
Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )
On Tue, 2010-10-19 at 17:35 +0200, Tomasz Michno wrote: I thought that I only need to test function which I modified, so I created tests in that way. Now I'm modifying them to use TranslateBitmapBits. Should I resend the whole patch or only create one new with only tests/transform.c? Please resend the whole patch.
Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
Adam Martinson amartin...@codeweavers.com writes: OK, just for future reference or do you want me to resend this set? Please resend, it needs to go through testbot again. -- Alexandre Julliard julli...@winehq.org
Re: Translation of the AppDB
On Tue, Oct 19, 2010 at 5:16 PM, Rosanne DiMesio dime...@earthlink.netwrote: On Tue, 19 Oct 2010 12:12:33 +0200 Yaron Shahrabani sh.ya...@gmail.com wrote: I see but I had another idea in mind... I was thinking about having the possibility to rate and report but without any way to comment, I mean that you cannot comment in foreign languages but you can vote and report (any operation that requires clicking is OK, typing is not). It's not possible to report without typing, and ratings without the typed information as to why the user gave the app that rating would be at best useless (Why is this silver? What doesn't work?), and at worst misleading. False platinums in particular are already a big problem: users give an app a platinum rating, but list tweaks they applied (so it really should be gold) or things that didn't work (so it really should be silver). Admins and maintainers need that typed information to assess whether a rating is correct. I fully understand, so reporting is way complicated without typing... Well its just a thought but maybe we should consider simplifying the whole process, maybe this way more data will be collected. Kind regards, Yaron Shahrabani. -- Rosanne DiMesio dime...@earthlink.net
Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
On 10/19/2010 03:17 AM, Alexandre Julliard wrote: Adam Martinsonamartin...@codeweavers.com writes: --- dlls/msxml3/tests/schema.c | 438 +--- 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series numbered from 1 so that winetestbot can figure it out. OK, just for future reference or do you want me to resend this set?
Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
On 10/19/2010 11:32 AM, Alexandre Julliard wrote: Adam Martinsonamartin...@codeweavers.com writes: OK, just for future reference or do you want me to resend this set? Please resend, it needs to go through testbot again. OK, resent, along with a few new ones.
Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle
On 10/18/10 9:53 PM, Vitaliy Margolen wrote: On 10/18/2010 12:51 PM, Krzysztof Nowicki wrote: Where I come from copying structures directly is considered bad practice and it's safer to use memcpy. We had problems before with broken compilers that would try to do some black magic in such cases. Then don't use broken compilers. GCC handles struct copying this just fine. And it's up-to compiler what sort of magic it's uses white or black. As long as struct gets copied you are all set. Actually, gcc modifies the code to do a PROPER memcpy. Thus you can copy the contents of a string using a pointer rather than the string if you use variable a = variable b. Using memcpy might lead to interesting results if you do the same thing. If the policy for Wine is to copy structures directly then I'll respect it. I'm not the one setting policies, but that's what you should do - utilize C language constructs instead of going around them. That's very true and this has been a C language construct for quite some time. James McKenzie
Re: msxml3/domdoc: Partially implement ::setAttributeNode()
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6343 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1
Re: Translation of the AppDB
On 10/19/10 10:20 AM, Yaron Shahrabani wrote: On Tue, Oct 19, 2010 at 5:16 PM, Rosanne DiMesio dime...@earthlink.net mailto:dime...@earthlink.net wrote: On Tue, 19 Oct 2010 12:12:33 +0200 Yaron Shahrabani sh.ya...@gmail.com mailto:sh.ya...@gmail.com wrote: I see but I had another idea in mind... I was thinking about having the possibility to rate and report but without any way to comment, I mean that you cannot comment in foreign languages but you can vote and report (any operation that requires clicking is OK, typing is not). It's not possible to report without typing, and ratings without the typed information as to why the user gave the app that rating would be at best useless (Why is this silver? What doesn't work?), and at worst misleading. False platinums in particular are already a big problem: users give an app a platinum rating, but list tweaks they applied (so it really should be gold) or things that didn't work (so it really should be silver). Admins and maintainers need that typed information to assess whether a rating is correct. I fully understand, so reporting is way complicated without typing... Well its just a thought but maybe we should consider simplifying the whole process, maybe this way more data will be collected. Yaron: As a maintainer of several applications, I want to know about improvements/regressions of all functions in those applications. Thus, I ask those who use the products I maintain to provide details 'What Works' and 'What Does Not Work' and these must be, for the present time, in English. Sorry, but English is the Universal language. The boxes, for now, should stay. There are many 'drop down' menus that it would be nice to input Hebrew and have English populate them. Would this be a good idea? James McKenzie
