Re: gdiplus: Store device resolution in the graphics object.

[Dmitry Timoshkov]

Marvin  wrote:

> === windowsxp (32 bit image) ===
> image.c:2736: Test failed: GdipLoadImageFromStream error 2
> image.c:2739: Test failed: GdipGetImageType error 2
> image.c:2749: Test failed: GdipCloneImage error 2
> image: unhandled exception c005 at 4EBB42CD

Testbot really needs to reset pending in the queue patches.

-- 
Dmitry.

Re: [PATCH 3/5] d3d10: Implement d3d10_effect_blend_variable_GetBackingStore().

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=66

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 5/5] d3d10: Implement d3d10_effect_sampler_variable_GetBackingStore().

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=67

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 4/6] jscript: Use prototype for buitin Number properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=62

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 6/6] jscript: Use prototype for buitin String properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=64

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 5/6] jscript: Use prototype for buitin RegExp properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=63

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 2/6] jscript: Use prototype for buitin Boolean properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=60

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=55

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform (resend)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=58

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 3/6] jscript: Use prototype for buitin Date properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=61

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 1/6] jscript: Use prototype for buitin Array properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=59

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize() (try2)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=57

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize()

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=54

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: gdiplus: Store device resolution in the graphics object.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=56

Your paranoid android.


=== windowsxp (32 bit image) ===
image.c:2736: Test failed: GdipLoadImageFromStream error 2
image.c:2739: Test failed: GdipGetImageType error 2
image.c:2749: Test failed: GdipCloneImage error 2
image: unhandled exception c005 at 4EBB42CD

Re: [1/5] windowscodecs: Implement MetadataHandler_GetValue. Take 2.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=43

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [4/5] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=44

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: [PATCH 2/3] mshtml: Added IHTMLDOMAttribute::get_specified implementation

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=41

Your paranoid android.


=== windowsxp (32 bit dom) ===
Can't copy TestLauncher to VM: :7094

Re: windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts. Resend.

[Dmitry Timoshkov]

Vincent Povirk  wrote:

> > The patch is marked as 'build failure', but it builds just fine here.
> > What kind of build failure is that?
> 
> Did you try building it on a Mac?

I don't have a Mac here, what's the failure there?

-- 
Dmitry.

Re: windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts. Resend.

[Vincent Povirk]

> The patch is marked as 'build failure', but it builds just fine here.
> What kind of build failure is that?

Did you try building it on a Mac?

Re: kernel32/tests: Explicitly cast to signed char

[Dmitry Timoshkov]

André Hentschel  wrote:

> -ok(mbc == -28, "mbc is %d\n", mbc);
> +ok((signed char)mbc == -28, "mbc is %d\n", mbc);
>  if(bUsedDefaultChar) ok(*bUsedDefaultChar == FALSE, "bUsedDefaultChar is 
> %d\n", *bUsedDefaultChar);
>  ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u\n", 
> GetLastError());
>  
> @@ -301,7 +301,7 @@ static void test_string_conversion(LPBOOL 
> bUsedDefaultChar)
>  SetLastError(0xdeadbeef);
>  ret = WideCharToMultiByte(1251, 0, &wc2, 1, &mbc, 1, NULL, 
> bUsedDefaultChar);
>  ok(ret == 1, "ret is %d\n", ret);
> -ok(mbc == -16, "mbc is %d\n", mbc);
> +ok((signed char)mbc == -16, "mbc is %d\n", mbc);

In these cases comparison with hex would work better IMO, and printing
the result of conversion in hex would be more readable as well.

-- 
Dmitry.

Re: What's the right way to implement _wtoi_l?

[André Hentschel]

Am 24.07.2012 06:58, schrieb Alex Henrie:
> 2012/7/23 Austin English :
>> Judging by similar recent commits
>> (http://source.winehq.org/git/wine.git/commitdiff/f320f6cf4843eab3d22b60674808e4e3de964b5a),
>> 1 seems to be the way to go.
> 
> Thanks for the answer. What makes me uneasy about this approach is
> that if I want to duplicate the tests for wtoi, there are a LOT of
> them:
> http://source.winehq.org/git/wine.git/blob/7b89de9e481cf8cca264dc48c444f2c33537afad:/dlls/ntdll/tests/string.c#l785
> 
> Could I just copy the wtoi code and not the tests? Also, out of
> curiosity, why can't you call a function in ntdll.dll from msvcrt.dll?

FWIW, i choosed that way because the implementation differed already in the 
function prototype.


-- 

Best Regards, André Hentschel

Re: msvcp90: Explicitly cast to signed char

[André Hentschel]

Am 24.07.2012 21:30, schrieb André Hentschel:
> ---
>  dlls/msvcp90/ios.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

This has been obsoleted due to Piotrs changes, thx.


-- 

Best Regards, André Hentschel

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Jacek Caban]

On 07/24/12 17:47, Dmitry Timoshkov wrote:
> Vincent Povirk  wrote:
>
 I disagree with many of the choices in this series (for example, I
 think casting an interface pointer to an inherited interface is fine,
 and replacing that with QueryInterface just adds unnecessary
 additional logic), but I don't think any semantics have been changed
 and overall it's a good cleanup.
>>> Please also consider that many of the objects may be implemented by
>>> a someone's else codec dll, and relying on an implementation detail
>>> is not acceptable in that case.
>> An implementation where the two approaches work differently would be
>> wrong. Every interface with IWICBitmapSource methods should implement
>> them in the same way. In cases where it matters we "should" match
>> native which could be doing either.
> Requesting somebody how he "should" implement things instead of calling
> QueryInterface() when appropriate and avoiding potentially harmful casts
> sounds like a not very nice stance. Arguing that native implementation
> may be doing it wrong doesn't help either.

Casts to inherited interfaces are the kind of casts that are not bad at
all. The child interface is perfectly good implementation of parent
interface by definition. It's just C that can't reflect it in its typing
system. So, while we want to avoid casts as much as possible, we need to
live with the fact that we sometimes need to cast inteface pointer to
its inherited parent.

BTW, changing them to QueryInterface call is not avoiding any cast. It
actually adds more of them in form of cast to void** in caller and
assignment to void* in QI implementation (not to mention runtime overhead).

Obviously many other casts you're fixing should indeed be fixed.

Jacek

Re: start: Support getting the file to open by AppleEvent.

[Per Johansson]

19 jul 2012 kl. 20:00 skrev Per Johansson:

> 19 jul 2012 kl. 18:11 skrev Alexandre Julliard :
> 
>> You really don't want to do that.
> 
> Alright, but like I said earlier there's really no other good way to support 
> associations without using Objective-C. I'll send a new version without 
> associations support in a few days.

I've sent in a new series without associations support, so this one can be 
discarded (noticed it's still in new status).

I've also managed to write a function which fetches the AppleEvent using 
Objective-C, which can be seen here: 
.

I suppose if there's no way to get this file into wine I could make it into a 
library and check for it in configure. Would that be the most proper approach?

Regrads,
-- 
Per Johansson

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Dmitry Timoshkov]

Vincent Povirk  wrote:

> >> I disagree with many of the choices in this series (for example, I
> >> think casting an interface pointer to an inherited interface is fine,
> >> and replacing that with QueryInterface just adds unnecessary
> >> additional logic), but I don't think any semantics have been changed
> >> and overall it's a good cleanup.
> >
> > Please also consider that many of the objects may be implemented by
> > a someone's else codec dll, and relying on an implementation detail
> > is not acceptable in that case.
> 
> An implementation where the two approaches work differently would be
> wrong. Every interface with IWICBitmapSource methods should implement
> them in the same way. In cases where it matters we "should" match
> native which could be doing either.

Requesting somebody how he "should" implement things instead of calling
QueryInterface() when appropriate and avoiding potentially harmful casts
sounds like a not very nice stance. Arguing that native implementation
may be doing it wrong doesn't help either.

-- 
Dmitry.

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Vincent Povirk]

>> I disagree with many of the choices in this series (for example, I
>> think casting an interface pointer to an inherited interface is fine,
>> and replacing that with QueryInterface just adds unnecessary
>> additional logic), but I don't think any semantics have been changed
>> and overall it's a good cleanup.
>
> Please also consider that many of the objects may be implemented by
> a someone's else codec dll, and relying on an implementation detail
> is not acceptable in that case.

An implementation where the two approaches work differently would be
wrong. Every interface with IWICBitmapSource methods should implement
them in the same way. In cases where it matters we "should" match
native which could be doing either.

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Dmitry Timoshkov]

Vincent Povirk  wrote:

> I disagree with many of the choices in this series (for example, I
> think casting an interface pointer to an inherited interface is fine,
> and replacing that with QueryInterface just adds unnecessary
> additional logic), but I don't think any semantics have been changed
> and overall it's a good cleanup.

Please also consider that many of the objects may be implemented by
a someone's else codec dll, and relying on an implementation detail
is not acceptable in that case.

-- 
Dmitry.

Re: gdiplus: Store device resolution in the graphics object.

[Vincent Povirk]

Looks good, thanks.

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Vincent Povirk]

I disagree with many of the choices in this series (for example, I
think casting an interface pointer to an inherited interface is fine,
and replacing that with QueryInterface just adds unnecessary
additional logic), but I don't think any semantics have been changed
and overall it's a good cleanup.

Re: windowscodecs: Implement MetadataHandler_Load.

[Vincent Povirk]

Looks good, thanks.

Re: [PATCH 1/6] jscript: Use prototype for buitin Array properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20277

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH 2/6] jscript: Use prototype for buitin Boolean properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20278

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH 5/6] jscript: Use prototype for buitin RegExp properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20281

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH 4/6] jscript: Use prototype for buitin Number properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20280

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH 3/6] jscript: Use prototype for buitin Date properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20279

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH 6/6] jscript: Use prototype for buitin String properties

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20282

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform (resend)

[Alexandre Julliard]

Nikolay Sivov  writes:

> +DWORD NTAPI RtlRunOnceExecuteOnce(PRTL_RUN_ONCE initonce, 
> PRTL_RUN_ONCE_INIT_FN callback, void *parameter, void **ctxt)
> +{
> +#ifdef __linux__
> +if (!use_futexes()) return FALSE;
> +
> +for (;;)
> +{
> +DWORD_PTR val = (DWORD_PTR)interlocked_cmpxchg_ptr( &initonce->Ptr, 
> (void*)1, NULL );
> +switch (val & 0x3)
> +{
> +case 0:
> +{
> +DWORD ret = callback(initonce, parameter, ctxt);
> +if (ret)
> +{
> +DWORD_PTR context = ctxt ? (DWORD_PTR)*ctxt : 0;
> +context = (context & ~0x3) | 0x2;
> +interlocked_cmpxchg_ptr( &initonce->Ptr, (void*)context, 
> (void*)1 );
> +}
> +else
> +interlocked_cmpxchg_ptr( &initonce->Ptr, NULL, (void*)1 
> );
> +futex_wake( (int *)&initonce->Ptr, 1 );
> +return ret;
> +}
> +case 1:
> +/* blocked by another thread */
> +futex_wait( (int *)&initonce->Ptr, 1, NULL );
> +break;
> +case 2:
> +/* already initialized */
> +return TRUE;
> +}
> +}

It's supposed to return an NTSTATUS, not a boolean. Also you have to
always return the context, and you should try to do a generic
implementation first.

-- 
Alexandre Julliard
julli...@winehq.org

Re: [PATCH 3/3] apphelp/tests: Add tests for ApphelpCheckShellObject

[Alexandre Julliard]

Detlef Riekenberg  writes:

> +flags = 0xdeadbeeffeedfaceULL;

Don't use long long constants.

-- 
Alexandre Julliard
julli...@winehq.org

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Dmitry Timoshkov]

Michael Stefaniuc  wrote:

> > @@ -102,7 +104,7 @@ static HRESULT WINAPI 
> > BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface
> >  IsEqualIID(&IID_IWICBitmapSource, iid) ||
> >  IsEqualIID(&IID_IWICBitmapFrameDecode, iid))
> >  {
> > -*ppv = iface;
> > +*ppv = &This->IWICBitmapFrameDecode_iface;
> >  }
> >  else
> >  {
> this part of the change is gratuitous. As long as there is only one
> interface implementation in the object there is no need for impl_from_Foo().

That's for consistency with other places, so if/when a new interface is
going to be added it's obvious for an implementror what to do.

Thanks for the review.

-- 
Dmitry.

Re: [rfc msvcp100] add Container_base::_Orphan_all

[Piotr Caban]

On 07/20/12 19:32, Dan Kegel wrote:

I have not tested at all on 64 bits, and am only guessing on the
calling convention stuff.
The calling convention is correct. The class name is _Container_base0 
(not _Container_base).


I can't say anything about the implementation. I don't know what this 
class is supposed to do.

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize()

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20268

Your paranoid android.


=== WVISTAADM (32 bit sync) ===
sync.c:1225: Test failed: got 0

=== W7PRO (32 bit sync) ===
sync.c:1225: Test failed: got 0

=== W7PROX64 (32 bit sync) ===
sync.c:1225: Test failed: got 0

=== TEST64_W7SP1 (32 bit sync) ===
sync.c:1225: Test failed: got 0

=== W7PROX64 (64 bit sync) ===
sync.c:1225: Test failed: got 0

=== TEST64_W7SP1 (64 bit sync) ===
sync.c:1225: Test failed: got 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=20269

Your paranoid android.


=== WVISTAADM (32 bit sync) ===
sync.c:1231: Test failed: got 0

=== W7PRO (32 bit sync) ===
sync.c:1231: Test failed: got 0

=== W7PROX64 (32 bit sync) ===
sync.c:1231: Test failed: got 0

=== TEST64_W7SP1 (32 bit sync) ===
sync.c:1231: Test failed: got 0

=== W7PROX64 (64 bit sync) ===
sync.c:1231: Test failed: got 0

=== TEST64_W7SP1 (64 bit sync) ===
sync.c:1231: Test failed: got 0

Re: [12/18] windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts.

[Michael Stefaniuc]

Hello Dmitry,

On 07/24/2012 08:12 AM, Dmitry Timoshkov wrote:
> ---
>  dlls/windowscodecs/jpegformat.c | 23 +--
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c
> index 53d7ec4..2c77d4f 100644
> --- a/dlls/windowscodecs/jpegformat.c
> +++ b/dlls/windowscodecs/jpegformat.c
> @@ -469,6 +470,8 @@ static const IWICBitmapDecoderVtbl JpegDecoder_Vtbl = {
>  static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode 
> *iface, REFIID iid,
>  void **ppv)
>  {
> +JpegDecoder *This = impl_from_IWICBitmapFrameDecode(iface);
> +
>  TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv);
>  
>  if (!ppv) return E_INVALIDARG;
> @@ -477,7 +480,7 @@ static HRESULT WINAPI 
> JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *if
>  IsEqualIID(&IID_IWICBitmapSource, iid) ||
>  IsEqualIID(&IID_IWICBitmapFrameDecode, iid))
>  {
> -*ppv = iface;
> +*ppv = &This->IWICBitmapFrameDecode_iface;
>  }
>  else
>  {
same here: not needed.

bye
michael

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

[Michael Stefaniuc]

Hello Dmitry,

On 07/24/2012 08:01 AM, Dmitry Timoshkov wrote:
> The patches in this series do not depend on each other, numeration is just
> for a convenience. Patches do basically the same job for different objects,
> so I decided to not invent a new subject for every separate kind of object.
> ---
>  dlls/windowscodecs/bmpdecode.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/dlls/windowscodecs/bmpdecode.c b/dlls/windowscodecs/bmpdecode.c
> index 6da6a3c..1a1ee0a 100644
> --- a/dlls/windowscodecs/bmpdecode.c
> +++ b/dlls/windowscodecs/bmpdecode.c
> @@ -94,6 +94,8 @@ static inline BmpDecoder 
> *impl_from_IWICBitmapFrameDecode(IWICBitmapFrameDecode
>  static HRESULT WINAPI BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode 
> *iface, REFIID iid,
>  void **ppv)
>  {
> +BmpDecoder *This = impl_from_IWICBitmapFrameDecode(iface);
> +
>  TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv);
>  
>  if (!ppv) return E_INVALIDARG;
> @@ -102,7 +104,7 @@ static HRESULT WINAPI 
> BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface
>  IsEqualIID(&IID_IWICBitmapSource, iid) ||
>  IsEqualIID(&IID_IWICBitmapFrameDecode, iid))
>  {
> -*ppv = iface;
> +*ppv = &This->IWICBitmapFrameDecode_iface;
>  }
>  else
>  {
this part of the change is gratuitous. As long as there is only one
interface implementation in the object there is no need for impl_from_Foo().

bye
michael