Re: Removal of unused audio drivers
Francois Gouget wrote: On Thu, 12 Apr 2007, Maarten Lankhorst wrote: [...] I'm not sure what nas is for, but it seems to be 'network audio system', I haven't seen any use for it, except that it causes a 30 seconds slowdown at showing 'audio' tab in winecfg. I don't think anyone uses it. For esd I think it's best to remove, for nas I'm also for remove, but I'll settle for removing it from winecfg list same way as winearts was disabled for a while. NAS is used to get sound on X terminals. It would be interesting to get input from the LTSP and thin-client crowd before concluding it can be removed. We use Wine with only ESD for our terminals. From what I gather, most LTSP systems use only ESD, but NAS is the second most popular. By the way, in LTSP, ESD's major deficiency is not being able to control the volume from things like the GNOME sound applet, so there's some interest in (but no support for) changing to PulseAudio. There's some info here: http://wiki.ltsp.org/twiki/bin/view/Ltsp/Sound Andrew
Re: Removal of unused audio drivers
Jonathan Ernst wrote: Le lundi 23 avril 2007 à 09:23 -0600, Andrew Ziem a écrit : [...] By the way, in LTSP, ESD's major deficiency is not being able to control the volume from things like the GNOME sound applet, so there's some interest in (but no support for) changing to PulseAudio. LTSP on Ubuntu feisty uses PulseAudio already (instead of ESD). Perhaps that's just Feisty or LTSP 5. I think most LTSP systems still use LTSP 4. (After all, Feisty is very new, and LTSP 5 is only available for the new Ubuntu and Debian.) In any case, I wish Wine would keep esd support for a while. Andrew
Re: SetDesktopWallPaper() should call SystemParametersInfoA()
Dmitry Timoshkov wrote: Andrew Ziem [EMAIL PROTECTED] wrote: -static HBITMAP hbitmapWallPaper; -static SIZE bitmapSize; -static BOOL fTileWallPaper; +HBITMAP hbitmapWallPaper; /* desktop wallpaper */ +SIZE bitmapSize; /* size of desktop wallpaper */ +BOOL fTileWallPaper; If the varaibles are no more used in this file you should not make static variables public, but move them into appropriate file instead. All these variables are now used in two files: desktop.c and sysparams.c Andrew
Re: automatic winetest builds stopped
Ivan Leo Puoti wrote: Does someone know why the tests at test.winehq.com/data aren't being built any more? Maybe a month ago there was a discussion on this list. IIRC, here's the gist: The build system is broken. Then, someone sent in a patch, but the maintainer is not at home. Andrew
Re: msvcrt[2/3]: add initial tests for dlls/msvcrt/data.c [try 2]
Uwe Bonnes wrote: Andrew == Andrew Ziem [EMAIL PROTECTED] writes: Andrew because tests yield inconsistent results */ +#if 0 + /* address #if 0 in a patch is depreciated. If the test fails on wine, butt succeeds in windows, use todo_wine(). If there are other conditions that must be met, tell these conditions, perhaps like #define SOME_SPECIAL_TEST 0 #ifdef SOME_SPECIAL_TEST so that others can decipher what you mean. Sorry, I meant to document the conditions under which Windows 2000 yields inconsistent results. For example, in the first ok() on Windows 2000, _initterm() returned either 0 or 1. Also, one of the #if 0 blocks documents a condition that crashes both Wine and Windows 2000. Andrew
Re: What is needed to get more sites with a winetest executable
Paul Vriens wrote: Am Montag, 12. Juni 2006 20:22 schrieb Paul Vriens: Hi, in the last months we've experienced several times that there was no winetest.exe available at the usual location (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? Cheers, Paul. Hi, not the answer to your question, but some thoughts about the topic. As long as the automatic build of Paul Millar works, there is not reason to have a second winetest binary for nearly the same git/cvs source of the tests. One binary a day is enough. If you check http://test.winehq.org/data/ you will see that we miss often tests results for some windows platforms. If building the winetest binary fails. Someone needs to look into the reason anyway. In almost all cases its a missing import in a library the test ist linked against. So first our mingw environment needs to be fixed. Just running another automatic build will fail with the same error as the build of Paul. Its not hard for me to do the manual build. I just need some webspace to put the stuff on. And i need to know what needs to be modified in the source before the build (somehow the build date need to be patched into the source). Also the question is how the new build is announce to the public (hope that it si not the case that it appears on astro.gla.ac.uk). exactly my point. I know Paul Millar fixes stuff all the time by patches of you I think and Hans Leidekker (and others). But he is only one person, with of course a limited amount of time. Maybe we should have a few sites generating the winebuild and using a different path to publish stuff at test.winehq.org/data/[site]. We don't want to mix the output of different executables in one view (apples and pears). There are a limited number of winetest reports, but it's nice to be able to see how a single test operates on a variety of systems. However, having separate sites would fragment the reports. How about integrating all of winetest into winehq.org where there is a primary maintainer and one or more backup maintainers? Andrew
Re: msvcrt[1/2]: add initial tests for dlls/msvcrt/data.c
Alexandre Julliard wrote: Andrew Ziem [EMAIL PROTECTED] writes: +typedef void (*_INITTERMFUN)(void); +unsigned int (WINAPI *p_initterm)(_INITTERMFUN *,_INITTERMFUN *); Msvcrt functions are not WINAPI. And why don't you simply call the function directly instead of loading it dynamically? I found the second problem. To avoid warning implicit declaration of function ‘_initterm’ when compiling the test data.c, where should _initterm be declared? In a new dlls/msvcrt/data.h? Andrew
Re: msvcrt[1/2]: add initial tests for dlls/msvcrt/data.c
Alexandre Julliard wrote: +typedef void (*_INITTERMFUN)(void); +unsigned int (WINAPI *p_initterm)(_INITTERMFUN *,_INITTERMFUN *); Msvcrt functions are not WINAPI. Thanks for catching that. And why don't you simply call the function directly instead of loading it dynamically? Dynamic loading was the easier solution to the problem LINK : fatal error LNK1104: cannot open file 'MSVCRT.lib' when compiling with MSVC7. Now, I found msvcrt.lib, so I'll test and resubmit. Andrew
Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER (FIXED)
Andrey Turkin wrote:
Andrew Ziem wrote:
Please use this patch instead of previous user3.patch. Thanks to
Andrey Turkin for catching the uninitialized variable.
changelog:
user: handle special cases for SPI_SETDESKWALLPAPER
The special cases remove the wallpaper or set it to default.
Previously, these cases were ignored, so Wine would crash.
-if (filename == (LPSTR)-1)
+if ((LPCSTR)SETWALLPAPER_DEFAULT == filename || (LPCSTR)NULL ==
filename || '\0' == filename[0])
{
-GetProfileStringA( desktop, WallPaper, (None), buffer, 256 );
-filename = buffer;
+ /* set default wallpaper or remove wallpaper*/
+ if (hbitmapWallPaper)
+ DeleteObject( hbitmapWallPaper );
+ return TRUE;
}
hdc = GetDC( 0 );
According to MSDN, if
- pvParam==SETWALLPAPER_DEFAUL || pvParam==NULL, then wallpaper will be
set to default one
- pvParam[0]=='\0', then wallpaper will be removed.
I cannot see any signs of such distinction in your code :)
When I ran the unit test on Windows 2000, that's what it did: in all
three cases (SETWALLPAPER_DEFAULT, NULL, or '\0'), Windows 2000 removed
the wallpaper. So, it seems the default wallpaper is no wallpaper, and
a test could be added to show that. (I already have a test that checks
the default wallpaper is the same on both SETWALLPAPER_DEFAULT and NULL).
Beyond the cosmetics of changing the wallpaper, the purpose of the new
code is to keep Wine from crashing on SETWALLPAPER_DEFAULT.
Andrew
Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER
Thank you for catching that. I missed the part
= {'\0'};
Andrey Turkin wrote:
I cannot see where emptyW initialized.
Andrew Ziem wrote:
The special cases remove the wallpaper or set it to default.
Previously, these cases were ignored, so Wine would crash.
snip
+if (NULL == pvParam || SETWALLPAPER_DEFAULT == pvParam)
+{
+static const WCHAR emptyW[1];
+if (!SetDeskWallPaper( (LPSTR)pvParam ))
+return FALSE;
+SYSPARAMS_Save(SPI_SETDESKWALLPAPER_REGKEY,
SPI_SETDESKWALLPAPER_VALNAME, emptyW, fWinIni);
Re: How are we doing?
Jeremy White wrote: On a side note, there is something that worries me a bit. Specifically, it appears that we have a dirty secret about the regression tests - that they only work reliably on Alexandre's machine. Is that true? Shouldn't we do something about that? Or am I on crack, and lots of people run all the tests cleanly every day... Hi Jeremy, No crack: you can see the variation graphically. Because bug 3666[1] has become stale, I sent a winetest report[2] from an SMP machine to demonstrate problems running Wine on the terminal server at our office: a Dual AMD Opteron with Fedora Core 5 x86 (32-bit software only). Then, I sent another report from a single CPU machine. The former report had many more failures. [1] http://bugs.winehq.org/show_bug.cgi?id=3666 [2] http://test.winehq.org/data/200605161000/#Wine (Later, I suppose should run the tests on the same machine with an SMP kernel and a normal kernel.) Andrew
Re: how to edit wiki?
mark cox wrote: When i search in google for 'cxtest', one of the hits is from winenq, but when i open the page http://wiki.winehq.org/CxTest, i get the message '* This page does not exist yet. You can create a new empty page, or use one of the page templates. Before creating the page, please check if a similar page already exists.'. and an option to 'create a new empty page'. If i choose to create a new page, i get the message ' *You are not allowed to edit this page.'. No indication is given as to how to sign in or what to do. Most wiki's have an option to 'sign in', or 'create a new account'. I thought that the idea of wiki's was that were meant to be accessible without jumping through hoops, so what's going on? Because of wiki spam problems, some wikis require that you login before making changes. Andrew
Re: kernel[2/2]: fix path test to pass on 95 and 98
Alexandre Julliard wrote:
Andrew Ziem [EMAIL PROTECTED] writes:
--- dlls/kernel/tests/path1.c 2006-05-14 23:32:47.0 -0600
+++ dlls/kernel/tests/path.c2006-05-15 08:08:52.0 -0600
@@ -339,14 +339,22 @@
newdir,tmpstr,tmpstr1,id);
ok(DeleteFileA(newdir),Couldn't delete the temporary file we just created\n);
- ok((id=GetTempFileNameA(tmppath,NULL,0,newdir)),GetTempFileNameA failed\n);
- sprintf(tmpstr,%.4x.tmp,id 0x);
- sprintf(tmpstr1,%x.tmp,id 0x);
- ok(lstrcmpiA(newdir+lstrlenA(tmppath),tmpstr)==0 ||
- lstrcmpiA(newdir+lstrlenA(tmppath),tmpstr1)==0,
- GetTempFileNameA returned '%s' which doesn't match '%s' or '%s'.
id=%x\n,
- newdir,tmpstr,tmpstr1,id);
- ok(DeleteFileA(newdir),Couldn't delete the temporary file we just
created\n);
+ if (GetVersion() 0x8000) {
You should never add version checks in tests, simply check for both
behaviors.
Thanks for the reply. Now, since some behavior is mutually exclusive,
that implies the wine tests will never see 0 total failures? When
writing this patch, I was trying to see what I could I could do to see
more green zeros in the reports: http://test.winehq.org/data/200605151000/
Also, I sort of copied the GetVersion() part from existing tests. For
example:
$ grep GetVersion dlls/*/tests/*.c | wc -l
31
Andrew
Re: setupapi: add case sensitivity string table tests
Mike McCormack wrote:
Hi Andrew,
Andrew Ziem wrote:
These test case sensitivity in setupapi string tables, and all the
parts I
modified pass on Microsoft's 98 and XP. As this is my first Wine patch,
comments are especially welcome.
For tests that don't pass in wine, please enclose them in todo_wine {
}, so that the Wine test suite doesn't fail.
Everything passes in WINE, 2000, and XP. However, in 98 one test fails:
result=lstrcmpiW(string, string3);
ok(result!=0,StringID %p matches requested StringID %p\n,string,string3);
Index: stringtable.c
===
RCS file: /home/wine/wine/dlls/setupapi/tests/stringtable.c,v
retrieving revision 1.2
diff -u -r1.2 stringtable.c
--- stringtable.c 23 Sep 2005 10:09:47 - 1.2
+++ stringtable.c 1 May 2006 05:59:55 -
Please do the diff in the wine directory like this:
cvs diff dlls/setupapi/tests/stringtable
OK. Thanks for the tip.
Andrew
