Re: Add d3drmdef.h header file - try 4
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Fix the D3DRMAPI definitions (Dimitry's Comments) Fix the inclusion of d3dtypes.h (Francois' Comments) Where other comments has gone, into a black hole? Changelog Add d3drmdef.h header file, required for d3drm implementation This version is absolutely broken and unusable. -- Dmitry.
re: Add d3drmdef.h header - try 2
Vijay wrote: Add minimalistic d3drmdef.h But why? None of the code in wine currently needs it. Maybe you should submit it together with the first bit of code that needs it. -- Wine for Windows ISVs: http://kegel.com/wine/isv
Re: Add d3drmdef.h header - try 2
On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: Changelog --- Add minimalistic d3drmdef.h extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR); Two nitpicks: Wine's headers usually don't specify extern (it's implicit). If there's a large list of functions it can also be nice to sort them in alphabetical order as other forms of grouping tend to break down after a time. But this is not a hard and fast rules and it is not always followed. -- Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS
Re: Add d3drmdef.h header - try 2
Hi, Please ignore the this one. I am sending a new one. I wrongly named the header file, effects of late night coding bye, VJ On 3/13/07, Francois Gouget [EMAIL PROTECTED] wrote: On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: Changelog --- Add minimalistic d3drmdef.h extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR); Two nitpicks: Wine's headers usually don't specify extern (it's implicit). If there's a large list of functions it can also be nice to sort them in alphabetical order as other forms of grouping tend to break down after a time. But this is not a hard and fast rules and it is not always followed. -- Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS
re: Add d3drmdef.h header
vijay wrote: [complete d3drmdef.h] It seems premature to check that in without any code that uses it. Also, did you really write all that yourself? - Dan
Re: Add d3drmdef.h header
Hi, I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) Thanks, VJ On 3/12/07, Dan Kegel [EMAIL PROTECTED] wrote: vijay wrote: [complete d3drmdef.h] It seems premature to check that in without any code that uses it. Also, did you really write all that yourself? - Dan
Re: Add d3drmdef.h header
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) If it ends up as an almost exact copy of a microsoft header it's not worth an effort. +#ifndef __D3DRMDEFS_H__ +#define __D3DRMDEFS_H__ That's exactly how microsoft does it, this is not how we do it in Wine. +#ifndef D3DRMAPI +#define D3DRMAPI WINAPI +#endif Same here. +#define D3DRMOPTIONS_LEFTHANDED 0x0001L Same here, and in a lot of other places. You lost 3 hours typing it, we lost time reviewing it. This not the 1st time. -- Dmitry.
Re: Add d3drmdef.h header
Hi On 3/12/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) If it ends up as an almost exact copy of a microsoft header it's not worth an effort. +#ifndef __D3DRMDEFS_H__ +#define __D3DRMDEFS_H__ I saw d3dtypes.h and other d3d header files, its defined like this only, no wine prefix has been added. That's exactly how microsoft does it, this is not how we do it in Wine. +#ifndef D3DRMAPI +#define D3DRMAPI WINAPI +#endif In some header files its defined like this. I will remove all of the below and submit a minimalistic header file. That will support the d3drmvector functions. Consider this patch as for the record. Same here. +#define D3DRMOPTIONS_LEFTHANDED 0x0001L Same here, and in a lot of other places. You lost 3 hours typing it, we lost time reviewing it. This not the 1st time. I have problems porting header files from native SDK's -- Dmitry. Thanks, VJ
Re: Add d3drmdef.h header
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: +#ifndef __D3DRMDEFS_H__ +#define __D3DRMDEFS_H__ I saw d3dtypes.h and other d3d header files, its defined like this only, no wine prefix has been added. No, it's not defined like this. That's exactly how microsoft does it, this is not how we do it in Wine. +#ifndef D3DRMAPI +#define D3DRMAPI WINAPI +#endif In some header files its defined like this. I will remove all of the below and submit a minimalistic header file. I'd suggest to leave this job to somebody knowledgeable, and who really needs this file. You lost 3 hours typing it, we lost time reviewing it. This not the 1st time. I have problems porting header files from native SDK's Then don't do that. -- Dmitry.
