Re: wine bug 27600
On 07/02/2011 04:21 AM, Austin Lund wrote: On 1 July 2011 06:10, wy...@volny.cz wrote: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O2 -o adsiid.o adsiid.c In file included from bug_test.c:8: ../include/winternl.h:2361: error: expected declaration specifiers or ‘...’ before ‘va_list’ Try adding #include stdarg.h before the windows headers. That is the correct answer, it's just the 64bit version of gcc (due to a feature or configuration path) works without it.
Re: wine bug 27600
Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit even though it was covered by several other faulty commits etc. I think I can find a problem between patches quite well. I can't go under patch level aka go into lines of code and that's the helping hand i would need here, i.e. i know, that 3rd patch of your series makes troubles to me and i also know, that your one big merged and modified patch works for me. Unfortunately as i said, i can't search a regression between lines of code. And this is a place we should look in, i guess... Sure, i will try again your modified script later today and let you know. For the other guys, could i call for help?? Could you please try to apply the Vincas's 9 patch raw-input series to the current git, try to compile and let me know, if you succeed? I really would like to know if i'm the only one with such problem. Thank you all, W.
Re: wine bug 27600
On 06/30/2011 05:31 PM, wy...@volny.cz wrote: Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit even though it was covered by several other faulty commits etc. I think I can find a problem between patches quite well. I can't go under patch level aka go into lines of code and that's the helping hand i would need here, i.e. i know, that 3rd patch of your series makes troubles to me and i also know, that your one big merged and modified patch works for me. Unfortunately as i said, i can't search a regression between lines of code. And this is a place we should look in, i guess... Sure, i will try again your modified script later today and let you know. For the other guys, could i call for help?? Could you please try to apply the Vincas's 9 patch raw-input series to the current git, try to compile and let me know, if you succeed? I really would like to know if i'm the only one with such problem. Thank you all, W. Well, I am almost certain what the problem is :) I think that you have a 32bit OS (well, the ./configure logs could tell me that). I and the WINE's testbot builder run 64bit OSes, the people from bug 20395 (also a person in #winehq) that compiled and ran the patch successfully most likely also run 64bit OSes, thus 64bit version of gcc by default. The issue is on i386, where a certain include-file combination that is used is hitting this expected declaration specifiers or ‘...’ bug for __ms_va_list. I wrote a small test-case patch, that should fail to compile using 32bit gcc - http://dl.dropbox.com/u/6901628/bug_test.patch If it fails, it's most likely a WINE bug and should be filed to bugzilla. As a solution to workaround that, I will add those unused include statements (as is a similar story with user.h) for it compile on i386; will submit once I've finished some new features. Thanks for discovering this :)
Re: wine bug 27600
2011/6/30 wy...@volny.cz: Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit even though it was covered by several other faulty commits etc. I think I can find a problem between patches quite well. I can't go under patch level aka go into lines of code and that's the helping hand i would need here, i.e. i know, that 3rd patch of your series makes troubles to me and i also know, that your one big merged and modified patch works for me. Unfortunately as i said, i can't search a regression between lines of code. And this is a place we should look in, i guess... Sure, i will try again your modified script later today and let you know. For the other guys, could i call for help?? Could you please try to apply the Vincas's 9 patch raw-input series to the current git, try to compile and let me know, if you succeed? I really would like to know if i'm the only one with such problem. Thank you all, W. $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: austin@debian:~/wine-git$ cat /etc/issue Debian GNU/Linux wheezy/sid \n \l austin@debian:~/wine-git$ uname -a Linux debian 2.6.39-2-686-pae #1 SMP Wed Jun 8 11:33:14 UTC 2011 i686 GNU/Linux -- -Austin
Re: wine bug 27600
On Thu, Jun 30, 2011 at 4:52 PM, Austin English austinengl...@gmail.com wrote: 2011/6/30 wy...@volny.cz: Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit even though it was covered by several other faulty commits etc. I think I can find a problem between patches quite well. I can't go under patch level aka go into lines of code and that's the helping hand i would need here, i.e. i know, that 3rd patch of your series makes troubles to me and i also know, that your one big merged and modified patch works for me. Unfortunately as i said, i can't search a regression between lines of code. And this is a place we should look in, i guess... Sure, i will try again your modified script later today and let you know. For the other guys, could i call for help?? Could you please try to apply the Vincas's 9 patch raw-input series to the current git, try to compile and let me know, if you succeed? I really would like to know if i'm the only one with such problem. Thank you all, W. $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: austin@debian:~/wine-git$ cat /etc/issue Debian GNU/Linux wheezy/sid \n \l austin@debian:~/wine-git$ uname -a Linux debian 2.6.39-2-686-pae #1 SMP Wed Jun 8 11:33:14 UTC 2011 i686 GNU/Linux -- -Austin Wylda already reported that this big patch worked, but the 9-patch series didn't. Can you try those?
Re: wine bug 27600
On 06/30/2011 05:57 PM, wy...@volny.cz wrote: $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: Thanks Austin for testing, but this raw.patch is already modified and works for me too. I would need to retest the series of nine individial patches ;) (thoses in wine-patches queue with status=New). But it looks like Vincas already know where the problem is :-) Regards, W. Austin just reported that I do not :) Another thing that would be helpful would be to get the exact modifications that are applied to the source tree (not only the patches but also the products of code generation from server/protocol.def). So with the non-compiling code, execute these commands: git add . git diff origin/master mod.patch Add send the mod.patch file, maybe that will reveal the secret.
Re: wine bug 27600
On 06/30/2011 06:07 PM, Vincas Miliūnas wrote: On 06/30/2011 05:57 PM, wy...@volny.cz wrote: $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: Thanks Austin for testing, but this raw.patch is already modified and works for me too. I would need to retest the series of nine individial patches ;) (thoses in wine-patches queue with status=New). But it looks like Vincas already know where the problem is :-) Regards, W. Austin just reported that I do not :) Another thing that would be helpful would be to get the exact modifications that are applied to the source tree (not only the patches but also the products of code generation from server/protocol.def). So with the non-compiling code, execute these commands: git add . git diff origin/master mod.patch Add send the mod.patch file, maybe that will reveal the secret. Ahh, just looked again and saw that I assumed wrong. Austin ran the http://dl.dropbox.com/u/6901628/raw.patch (with the modified header, that is intended to be fixed), not the http://dl.dropbox.com/u/6901628/bug_test.patch test-case, that should validate that the 32bit gcc WINE build is broken. (also the topic is about bug 27600, but you do not need this patch to reproduce it, left/right-clicking repositions the mouse cursor) (also applying patch http://source.winehq.org/patches/data/75733 fixes one regression, where the game hangs)
Re: wine bug 27600
On Thu, Jun 30, 2011 at 07:57, wy...@volny.cz wrote: $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: Thanks Austin for testing, but this raw.patch is already modified and works for me too. I would need to retest the series of nine individial patches ;) (thoses in wine-patches queue with status=New). Ah, right. Doing: git clean -dfx git reset --hard origin for i in 75876 75883 75878 75882 75881 75884 75877 75879 75880 do wget http://source.winehq.org/patches/data/$i -O /tmp/raw-$i.patch git apply /tmp/raw-$i.patch done ./tools/make_requests ./configure make gives: make[1]: Entering directory `/home/austin/wine-git/server' gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o raw_input.o raw_input.c In file included from raw_input.c:28: ../include/winternl.h:2361: error: expected declaration specifiers or '...' before 'va_list' ../include/winternl.h:2531: error: expected declaration specifiers or '...' before 'va_list' ../include/winternl.h:2532: error: expected declaration specifiers or '...' before 'va_list' In file included from raw_input.c:29: ../include/winbase.h:1578: error: expected declaration specifiers or '...' before 'va_list' ../include/winbase.h:1579: error: expected declaration specifiers or '...' before 'va_list' make[1]: *** [raw_input.o] Error 1 make[1]: Leaving directory `/home/austin/wine-git/server' make: *** [server] Error 2 http://dl.dropbox.com/u/6901628/raw.patch works And the bug test patch: gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o bug_test.o bug_test.c In file included from bug_test.c:8: ../include/winternl.h:2361: error: expected declaration specifiers or '...' before 'va_list' ../include/winternl.h:2531: error: expected declaration specifiers or '...' before 'va_list' ../include/winternl.h:2532: error: expected declaration specifiers or '...' before 'va_list' In file included from bug_test.c:9: ../include/winbase.h:1578: error: expected declaration specifiers or '...' before 'va_list' ../include/winbase.h:1579: error: expected declaration specifiers or '...' before 'va_list' make: *** [bug_test.o] Error 1 These tests were on: Linux aw25 2.6.37 #1 SMP Thu Apr 21 17:36:51 PDT 2011 i686 Intel(R) Core(TM) i7 CPU 960 @ 3.20GHz GenuineIntel GNU/Linux (gentoo) -- -Austin
Re: wine bug 27600
Otherwise WINE compilation with 32bit gcc gets broken (not yet 100% confirmed, see the discussion with Wylda on wine-devel mailing list). Small patch to test for the issue - http://dl.dropbox.com/u/6901628/bug_test.patch Now i can confirm for sure, that simple testcase bug_test.patch fails here as in Austin's case: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O2 -o adsiid.o adsiid.c In file included from bug_test.c:8: ../include/winternl.h:2361: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2531: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2532: error: expected declaration specifiers or ‘...’ before ‘va_list’ In file included from bug_test.c:9: ../include/winbase.h:1578: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winbase.h:1579: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [bug_test.o] Error 1 Including winternl.h before winbase.h and winuser.h must have caused the issue. Vincas could you open a bug for that? You probably know most about this issue ;) Thanks Vincas Austin! W.
Re: wine bug 27600
Maybe gcc 4.4.5 is too old or i'm extremly dumb today :-/ Regards, W. I'm not a WINE developer, just scratching my own itch :) I have the same gcc version. Well, this might be a legitimate issue, another important thing would be to see the ./configure output log. Thanks for interest :) That gives me hope, i won't be out of wine game ;) I've merged the patch with the include lines modified, so they would be identical to the include files mostly used in the other wineserver c files. This is just a guess, I have no idea why it doesn't work. There is also today's commit, that changed include/winternl.h: ntdll: Encode the function pointers in the vectored handler list, but it's not related. The patch is rebased against today's commits - http://dl.dropbox.com/u/6901628/raw.patch Nice to have all that 9+ changes in one box. So later today i will try to apply them on current fresh git tree and upload config.log if any trouble. If anything else comes to your mind in next 10hours don't hesitate to ask for, so i could report that too. Thanks, W. -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz
Re: wine bug 27600
On 06/30/2011 12:22 AM, wy...@volny.cz wrote: The patch is rebased against today's commits - http://dl.dropbox.com/u/6901628/raw.patch The good news is, that this combo patch successfully compiles here. The bad new is, that today's 9 newly sent patches still fails here. I did regression test above them and 1of9 + 2of9 successfully compiles here, in other word first bad commit is 3of9. Adding config.log and output of ./configure (each as vanilla and patched for comparison). Regards, W. The 3th patch adds the c file for wineserver. ./configure log just shows that you have way more devel packages installed then me :) There is some garbage added to the patch code, I suspect that the way you downloaded the patch corrupted it. I wrote a bash script that will download the patches correctly and apply them: git clean -fd git reset --hard origin/master for i in 75876 75883 75878 75882 75881 75884 75877 75879 75880 do wget http://source.winehq.org/patches/data/$i -O /tmp/raw-$i.patch git apply /tmp/raw-$i.patch done ./tools/make_requests
Re: wine bug 27600
There is some garbage added to the patch code, I suspect that the way you downloaded the patch corrupted it. I wrote a bash script that will download the patches correctly and apply them: git clean -fd git reset --hard origin/master for i in 75876 75883 75878 75882 75881 75884 75877 75879 75880 do wget http://source.winehq.org/patches/data/$i -O /tmp/raw-$i.patch git apply /tmp/raw-$i.patch done ./tools/make_requests Even before i used wget for downloads patch -p1. Anyway i gave your script a chance, but i got during the compilation: gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o raw_input.o raw_input.c In file included from raw_input.c:28: ../include/winternl.h:2361: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2531: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2532: error: expected declaration specifiers or ‘...’ before ‘va_list’ In file included from raw_input.c:29: ../include/winbase.h:1578: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winbase.h:1579: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [raw_input.o] Error 1 make[1]: Leaving directory `/build/wine-git_build/server' make: *** [server] Error 2
Re: wine bug 27600
On 06/30/2011 02:19 AM, wy...@volny.cz wrote: There is some garbage added to the patch code, I suspect that the way you downloaded the patch corrupted it. I wrote a bash script that will download the patches correctly and apply them: git clean -fd git reset --hard origin/master for i in 75876 75883 75878 75882 75881 75884 75877 75879 75880 do wget http://source.winehq.org/patches/data/$i -O /tmp/raw-$i.patch git apply /tmp/raw-$i.patch done ./tools/make_requests Even before i used wget for downloads patch -p1. Anyway i gave your script a chance, but i got during the compilation: gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o raw_input.o raw_input.c In file included from raw_input.c:28: ../include/winternl.h:2361: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2531: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2532: error: expected declaration specifiers or ‘...’ before ‘va_list’ In file included from raw_input.c:29: ../include/winbase.h:1578: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winbase.h:1579: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [raw_input.o] Error 1 make[1]: Leaving directory `/build/wine-git_build/server' make: *** [server] Error 2 Ok, try with a modified header: git clean -fd git reset --hard origin/master for patch in \ 0001-user32-tests-Added-client-side-raw-input-function-te.patch \ 0002-user32-Added-DefRawInputProc-implementation-try-10.patch \ 0003-server-user32-Added-GetRawInputDeviceList-implementa.patch \ 0004-server-user32-Added-GetRawInputDeviceInfoW-implement.patch \ 0005-user32-Added-GetRawInputDeviceInfoA-implementation-t.patch \ 0006-server-user32-Added-GetRegisteredRawInputDevices-imp.patch \ 0007-server-user32-Added-RegisterRawInputDevices-implemen.patch \ 0008-user32-Added-GetRawInputBuffer-implementation-try-10.patch \ 0009-server-user32-Added-GetRawInputData-implementation-t.patch do wget http://dl.dropbox.com/u/6901628/$patch -O /tmp/$patch git apply /tmp/$patch done ./tools/make_requests
Re: wine bug 27600
On Tue, Jun 28, 2011 at 13:16, wy...@volny.cz wrote: Hi Vincas, i wanted to give bug 27600 a try. So on top of wine-1.3.23-50-g2497a91 i applied patches: 1. 75818 2. 75819 3. 75831 4. 75830 5. 75829 6. 75820 7. 75821 8. 75822 9. 75823 but i end up with failure during the buildup: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-stric t-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogi cal-op -g -O0 -o input.o input.c input.c: In function ‘GetRawInputDeviceList’: input.c:495: error: ‘union generic_request’ has no member named ‘get_raw_input_device_list_request’ input.c:495: error: ‘union generic_reply’ has no member named ‘get_raw_input_device_list_reply’ Regards, W. Did you run ./tools/make_requests ? -- -Austin
Re: wine bug 27600
Did you run ./tools/make_requests ? -- -Austin Nope. So i did: ./tools/make_requests make distclean ./configure followed by make and got (-O0 issue??): gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempt y-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -o raw_input.o raw_input.c In file included from raw_input.c:28: ../include/winternl.h:2359: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2529: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2530: error: expected declaration specifiers or ‘...’ before ‘va_list’ In file included from raw_input.c:29: ../include/winbase.h:1578: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winbase.h:1579: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [raw_input.o] Error 1 make[1]: Leaving directory `/build/wine-git_build/server' make: *** [server] Error 2 -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz
Re: wine bug 27600
So i another try: * rm -rf * in my git tree. * git checkout -f 2497a91f6b1326988dd5ea56dc4052cbcc2e521d * applied all nine patches * ./tools/make_requests * configure + make with -O2 and got again: In file included from raw_input.c:28: ../include/winternl.h:2359: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2529: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2530: error: expected declaration specifiers or ‘...’ before ‘va_list’ -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz
Re: wine bug 27600
On 06/29/2011 12:10 AM, wy...@volny.cz wrote: So i another try: * rm -rf * in my git tree. * git checkout -f 2497a91f6b1326988dd5ea56dc4052cbcc2e521d * applied all nine patches * ./tools/make_requests * configure + make with -O2 and got again: In file included from raw_input.c:28: ../include/winternl.h:2359: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2529: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2530: error: expected declaration specifiers or ‘...’ before ‘va_list’ Looks like there is some external interference, try compiling in a clean bash environment; some googling suggests that LIBRARY_PATH variable should be unset - https://bbs.archlinux.org/viewtopic.php?id=30418 First be sure it can compile the original master branch without issues. Compilation with the patch after make distclean works for me.
Re: wine bug 27600
Looks like there is some external interference, try compiling in a clean bash environment; some googling suggests that LIBRARY_PATH variable should be unset - https://bbs.archlinux.org/viewtopic.php?id=30418 First be sure it can compile the original master branch without issues. Still fails here :-/ * succesfully compiled vanilla wine-1.3.23-50-g2497a91 * make distclean * applied all nine patches * unset LIBRARY_PATH * ./tools/make_requests //3 files updated * ./configure * make -j 16 Debian 32 squeeze, gcc v4.4.5, no CFLAGS override. -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz
Re: wine bug 27600
On 06/29/2011 12:28 AM, wy...@volny.cz wrote: Looks like there is some external interference, try compiling in a clean bash environment; some googling suggests that LIBRARY_PATH variable should be unset - https://bbs.archlinux.org/viewtopic.php?id=30418 First be sure it can compile the original master branch without issues. Still fails here :-/ * succesfully compiled vanilla wine-1.3.23-50-g2497a91 * make distclean * applied all nine patches * unset LIBRARY_PATH * ./tools/make_requests //3 files updated * ./configure * make -j 16 Debian 32 squeeze, gcc v4.4.5, no CFLAGS override. It fails on the #include winternl.h line and these are standard includes, you can try to replace [code] #include stdarg.h #include stdio.h [/code] code fragment with [code] #include config.h #include wine/port.h #include assert.h #include stdarg.h #include stdio.h [/code] maybe that will change something. Others that have successfully built with the patch applied are WINE's testbot and two persons from http://bugs.winehq.org/show_bug.cgi?id=20395
Re: wine bug 27600
It fails on the #include winternl.h line and these are standard includes, you can try to replace [code] #include stdarg.h #include stdio.h [/code] code fragment with [code] #include config.h #include wine/port.h #include assert.h #include stdarg.h #include stdio.h [/code] maybe that will change something. Unfortunately that's too generic for me (i can't handle code) :-( I would need it in more detail way or a patch. But i'm not asking you from that. I do not want to waste developers time ;) Others that have successfully built with the patch applied are WINE's testbot and two persons from http://bugs.winehq.org/show_bug.cgi?id=20395 Maybe gcc 4.4.5 is too old or i'm extremly dumb today :-/ Regards, W. -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz
Re: wine bug 27600
On 06/29/2011 01:25 AM, wy...@volny.cz wrote: It fails on the #include winternl.h line and these are standard includes, you can try to replace [code] #include stdarg.h #include stdio.h [/code] code fragment with [code] #include config.h #include wine/port.h #include assert.h #include stdarg.h #include stdio.h [/code] maybe that will change something. Unfortunately that's too generic for me (i can't handle code) :-( I would need it in more detail way or a patch. But i'm not asking you from that. I do not want to waste developers time ;) Others that have successfully built with the patch applied are WINE's testbot and two persons from http://bugs.winehq.org/show_bug.cgi?id=20395 Maybe gcc 4.4.5 is too old or i'm extremly dumb today :-/ Regards, W. I'm not a WINE developer, just scratching my own itch :) I have the same gcc version. Well, this might be a legitimate issue, another important thing would be to see the ./configure output log. I've merged the patch with the include lines modified, so they would be identical to the include files mostly used in the other wineserver c files. This is just a guess, I have no idea why it doesn't work. There is also today's commit, that changed include/winternl.h: ntdll: Encode the function pointers in the vectored handler list, but it's not related. The patch is rebased against today's commits - http://dl.dropbox.com/u/6901628/raw.patch There are some paranormal stuff in wineserver, like in the first revision of this patch (I haven't tried since then), if I removed the user.h include (which is not used), some magical force was preventing from successfully copying lParam value in the peek_message function (it had the correct value from the source, but the target was reset back to some constant) for each WM_INPUT message I posted, while other messages where working just fine.
