Re: gdiplus: added stub implementation of gdiplus.dll

2007-06-08 Thread Jeff L

James Hawkins wrote:

On 5/25/07, Andrey Turkin [EMAIL PROTECTED] wrote:

James Hawkins wrote:
 On 5/25/07, Mounir IDRASSI [EMAIL PROTECTED] wrote:
 Hi,
 You also have to modify other files in order to integrate your stub
 implementation to the wine build chain: Makefile.in, configure and
 configure.ac in the wine root directory, Makefile.in in the dlls
 directory. 
 The only file outside of gdiplus that he has to modify is 
configure.ac.



I thought he should run tools/make_makefiles
That's not required. tools/make_makefiles 
I have tried this a number of ways but it seems that you need to 
/autoconf/ to create configure and you need to run 
/tools/make_makefiles./  Did you mean that you only need to submit 
/configure.ac /in the patch?  If so then I can add a note to the wiki 
otherwise the issue is another mystery.


Jeff




Re: gdiplus: added stub implementation of gdiplus.dll

2007-05-26 Thread Jeff L

James Hawkins wrote:

On 5/25/07, Andrey Turkin [EMAIL PROTECTED] wrote:

James Hawkins wrote:
 On 5/25/07, Mounir IDRASSI [EMAIL PROTECTED] wrote:
 Hi,
 You also have to modify other files in order to integrate your stub
 implementation to the wine build chain: Makefile.in, configure and
 configure.ac in the wine root directory, Makefile.in in the dlls
 directory. 
 The only file outside of gdiplus that he has to modify is 
configure.ac. 

I thought he should run tools/make_makefiles

That's not required.
When adding a directory into the local repository I have found need to 
add the Makefiles and configure, etc, in addition the the configure.ac 
if you want to compile from your new directory as part of a make at the 
top level.  Is there a secret to propagating the configuration?  Or is 
this a prerogative of Alexandre's?


Jeff Latimer




Re: gdiplus: added stub implementation of gdiplus.dll

2007-05-25 Thread Mounir IDRASSI
Hi,
You also have to modify other files in order to integrate your stub
implementation to the wine build chain: Makefile.in, configure and
configure.ac in the wine root directory, Makefile.in in the dlls
directory.

Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr


Evan Stade wrote:
 Changelog:
 * added stub implementation of gdiplus.dll (3 files)

  dlls/gdiplus/Makefile.in  |   16 +
  dlls/gdiplus/gdiplus.c|   45 +++
  dlls/gdiplus/gdiplus.spec |  609
 +
  3 files changed, 670 insertions(+), 0 deletions(-)





Re: gdiplus: added stub implementation of gdiplus.dll

2007-05-25 Thread Andrey Turkin

James Hawkins wrote:

On 5/25/07, Mounir IDRASSI [EMAIL PROTECTED] wrote:

Hi,
You also have to modify other files in order to integrate your stub
implementation to the wine build chain: Makefile.in, configure and
configure.ac in the wine root directory, Makefile.in in the dlls
directory.



The only file outside of gdiplus that he has to modify is configure.ac.



I thought he should run tools/make_makefiles




Re: gdiplus: added stub implementation of gdiplus.dll

2007-05-25 Thread James Hawkins

On 5/25/07, Andrey Turkin [EMAIL PROTECTED] wrote:

James Hawkins wrote:
 On 5/25/07, Mounir IDRASSI [EMAIL PROTECTED] wrote:
 Hi,
 You also have to modify other files in order to integrate your stub
 implementation to the wine build chain: Makefile.in, configure and
 configure.ac in the wine root directory, Makefile.in in the dlls
 directory.


 The only file outside of gdiplus that he has to modify is configure.ac.


I thought he should run tools/make_makefiles



That's not required.

--
James Hawkins




Re: gdiplus: added stub implementation of gdiplus.dll

2007-05-25 Thread James Hawkins

On 5/25/07, Mounir IDRASSI [EMAIL PROTECTED] wrote:

Hi,
You also have to modify other files in order to integrate your stub
implementation to the wine build chain: Makefile.in, configure and
configure.ac in the wine root directory, Makefile.in in the dlls
directory.



The only file outside of gdiplus that he has to modify is configure.ac.

--
James Hawkins




Re: gdiplus: added stub implementation of gdiplus.dll

2007-05-25 Thread Evan Stade

I think all the files that Mounir said to include are all modified
automatically or by Julliard

You should not include any autogenerated code, that was created from
'autoconf' or a tool inside 'tools/' ( tools/make_makefiles or winedump as
examples), when you submit your Patch to winehq.org

On 5/25/07, James Hawkins [EMAIL PROTECTED] wrote:


On 5/25/07, Andrey Turkin [EMAIL PROTECTED] wrote:
 James Hawkins wrote:
  On 5/25/07, Mounir IDRASSI [EMAIL PROTECTED] wrote:
  Hi,
  You also have to modify other files in order to integrate your stub
  implementation to the wine build chain: Makefile.in, configure and
  configure.ac in the wine root directory, Makefile.in in the dlls
  directory.
 
 
  The only file outside of gdiplus that he has to modify is configure.ac
.
 

 I thought he should run tools/make_makefiles


That's not required.

--
James Hawkins