Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-05 Thread zeugs 


Quoting Michal Labedzki :


Therefore I think there is no need to translate the terms manually.


What about  "Ctrl + Down" etc.? I am not sure if something like that
can be translating automatically. If so, that great.


Yes, this is also translated automatically with qt_xx.qm.


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-05 Thread Michal Labedzki 
> Therefore I think there is no need to translate the terms manually.

What about  "Ctrl + Down" etc.? I am not sure if something like that
can be translating automatically. If so, that great.

On 4 April 2016 at 20:16, Uli Heilmeier  wrote:
> Hi Alexis,
>
>> How can we prevent this?
>> * Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
>>
>> After a check, yes, it is possible to remove (via Qt Design for example
>> "Close"
>> diff --git a/ui/qt/main_window.ui b/ui/qt/main_window.ui
>> index 021d788..881f6c7 100644
>> --- a/ui/qt/main_window.ui
>> +++ b/ui/qt/main_window.ui
>> @@ -817,7 +817,7 @@
>>  Close this capture file
>> 
>> 
>> -Ctrl+W
>> +Ctrl+W
>> 
>> 
>>  false
>>
>> and after it is remove from ts file
>>
>
> Sounds good. I would vote for removing the terms from the ts files.
>
> If no one complains I will upload a patch with fixed ui file in the next days.
>
>> * Establish a review process (like Gerrit) for translation files
>>
>> It is possible to have "Reviewer" on Transifex, if you are interresed and
>> can add you to reviewer group for check german translation
>>
>
> Keeping the automatic sync (without review) is ok for me when we've
> removed the shortcuts from ts file.
>
> Cheers
> Uli
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe



-- 

Pozdrawiam / Best regards
-
Michał Łabędzki, Software Engineer
Tieto Corporation

Product Development Services

http://www.tieto.com / http://www.tieto.pl
---
ASCII: Michal Labedzki
location: Swobodna 1 Street, 50-088 Wrocław, Poland
room: 5.01 (desk next to 5.08)
---
Please note: The information contained in this message may be legally
privileged and confidential and protected from disclosure. If the
reader of this message is not the intended recipient, you are hereby
notified that any unauthorised use, distribution or copying of this
communication is strictly prohibited. If you have received this
communication in error, please notify us immediately by replying to
the message and deleting it from your computer. Thank You.
---
Please consider the environment before printing this e-mail.
---
Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w
Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym
Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego
Rejestru Sądowego pod numerem 124858. NIP: 8542085557. REGON:
812023656. Kapitał zakładowy: 4 271500 PLN
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-04 Thread Uli Heilmeier 
Am 04.04.16 um 08:07 schrieb Michal Labedzki:
> Please note that some translations (not Wireshark only!) translate
> arrow keys names (Up, Down, Left, Right).
> For example: Polish. (I think it based on the fact that Enter,
> Backspace, Shift, Ctrl, Alt, PrintScreen, Insert, Esc, etc. has
> English name on the button, but arrows have only arrows (pictogram),
> so it is better to translate them. So I am ok to lock all shortcut
> without those with arrow and also if someone requests something... Let
> me think... we should ask Russian, Chinese, etc. what they have on the
> keyboard?

Fair enough.
I've checked some qt_XX.qm files coming with Qt:
--
/var/tmp/qt_cs.ts:Down
/var/tmp/qt_cs.ts-Dolů
--
/var/tmp/qt_de.ts:Down
/var/tmp/qt_de.ts-Runter
--
/var/tmp/qt_hu.ts:Down
/var/tmp/qt_hu.ts-Le
--
/var/tmp/qt_ja.ts:Down
/var/tmp/qt_ja.ts-↓
--
/var/tmp/qt_ko.ts:Down
/var/tmp/qt_ko.ts-아래
--
/var/tmp/qt_pl.ts:Down
/var/tmp/qt_pl.ts-Dół
--
/var/tmp/qt_ru.ts:Down
/var/tmp/qt_ru.ts-Вниз
--
/var/tmp/qt_zh_CN.ts:Down
/var/tmp/qt_zh_CN.ts-Down


Therefore I think there is no need to translate the terms manually.

However Qt doesn't provide qt_xx.qm files for all languages we have in
Transifex (at least my Qt installation). But for every language where we
have active contributions.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-04 Thread Uli Heilmeier 
Hi Alexis,

> How can we prevent this?
> * Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
> 
> After a check, yes, it is possible to remove (via Qt Design for example
> "Close"
> diff --git a/ui/qt/main_window.ui b/ui/qt/main_window.ui
> index 021d788..881f6c7 100644
> --- a/ui/qt/main_window.ui
> +++ b/ui/qt/main_window.ui
> @@ -817,7 +817,7 @@
>  Close this capture file
> 
> 
> -Ctrl+W
> +Ctrl+W
> 
> 
>  false
> 
> and after it is remove from ts file
> 

Sounds good. I would vote for removing the terms from the ts files.

If no one complains I will upload a patch with fixed ui file in the next days.

> * Establish a review process (like Gerrit) for translation files
>
> It is possible to have "Reviewer" on Transifex, if you are interresed and
> can add you to reviewer group for check german translation
>

Keeping the automatic sync (without review) is ok for me when we've
removed the shortcuts from ts file.

Cheers
Uli
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-04 Thread Alexis La Goutte 
Hi Uli,


On Fri, Apr 1, 2016 at 8:27 PM, Uli Heilmeier  wrote:

> Hi list,
>
> At the moment the translation source files ui/qt/wireshark_xx.ts contains
> all the keyboard shortcuts (e.g. like 'Ctrl+Home'). Therefore these terms
> are also listed in Transifex.
>
> However these terms are translated "automatically" with the qt_xx.qm
> files. Doing a manually translation breaks the display of the shortcuts in
> the UI (s.
> https://www.wireshark.org/lists/wireshark-dev/201511/msg00101.html).
>
> I did the mistake to translate the terms some month ago and another
> member of the German Transifex team has done the same mistake this week.
>
I have the member to contact you before...


>
> How can we prevent this?
> * Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
>
After a check, yes, it is possible to remove (via Qt Design for example
"Close"
diff --git a/ui/qt/main_window.ui b/ui/qt/main_window.ui
index 021d788..881f6c7 100644
--- a/ui/qt/main_window.ui
+++ b/ui/qt/main_window.ui
@@ -817,7 +817,7 @@
 Close this capture file


-Ctrl+W
+Ctrl+W


 false

and after it is remove from ts file

* Lock the terms (non writeable) in Transifex (if feasible)
>
Sorry, it is no possible (only can add translator note : "DON'T TRANSLATE
!")

> * Establish a review process (like Gerrit) for translation files
>
> It is possible to have "Reviewer" on Transifex, if you are interresed and
can add you to reviewer group for check german translation



> At the moment the translation is synced automatically (also for master-20).
>
> Any opinions?


> Cheers
> Uli
>
Regards,
Alexis


> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-04 Thread Michal Labedzki 
Please note that some translations (not Wireshark only!) translate
arrow keys names (Up, Down, Left, Right).
For example: Polish. (I think it based on the fact that Enter,
Backspace, Shift, Ctrl, Alt, PrintScreen, Insert, Esc, etc. has
English name on the button, but arrows have only arrows (pictogram),
so it is better to translate them. So I am ok to lock all shortcut
without those with arrow and also if someone requests something... Let
me think... we should ask Russian, Chinese, etc. what they have on the
keyboard?

On 2 April 2016 at 00:24, Peter Wu  wrote:
> On Fri, Apr 01, 2016 at 08:27:57PM +0200, Uli Heilmeier wrote:
>> At the moment the translation source files ui/qt/wireshark_xx.ts contains
>> all the keyboard shortcuts (e.g. like 'Ctrl+Home'). Therefore these terms
>> are also listed in Transifex.
>>
>> However these terms are translated "automatically" with the qt_xx.qm
>> files. Doing a manually translation breaks the display of the shortcuts in
>> the UI (s.
>> https://www.wireshark.org/lists/wireshark-dev/201511/msg00101.html).
>>
>> I did the mistake to translate the terms some month ago and another
>> member of the German Transifex team has done the same mistake this week.
>>
>> How can we prevent this?
>> * Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
>
> I looked through the manual
> (https://doc.qt.io/qt-5/linguist-translators.html) and did not find an
> option to disable translation for such options. It should however be
> possible to remove the shortcuts from the .ts files and add them to the
> cpp files instead using the setShortcut method of QActions. See:
>
>  - https://doc.qt.io/qt-5/qaction.html#shortcut-prop
>  - https://doc.qt.io/qt-5/qkeysequence.html#details
> --
> Kind regards,
> Peter Wu
> https://lekensteyn.nl
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe



-- 

Pozdrawiam / Best regards
-
Michał Łabędzki, Software Engineer
Tieto Corporation

Product Development Services

http://www.tieto.com / http://www.tieto.pl
---
ASCII: Michal Labedzki
location: Swobodna 1 Street, 50-088 Wrocław, Poland
room: 5.01 (desk next to 5.08)
---
Please note: The information contained in this message may be legally
privileged and confidential and protected from disclosure. If the
reader of this message is not the intended recipient, you are hereby
notified that any unauthorised use, distribution or copying of this
communication is strictly prohibited. If you have received this
communication in error, please notify us immediately by replying to
the message and deleting it from your computer. Thank You.
---
Please consider the environment before printing this e-mail.
---
Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w
Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym
Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego
Rejestru Sądowego pod numerem 124858. NIP: 8542085557. REGON:
812023656. Kapitał zakładowy: 4 271500 PLN
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-01 Thread Peter Wu 
On Fri, Apr 01, 2016 at 08:27:57PM +0200, Uli Heilmeier wrote:
> At the moment the translation source files ui/qt/wireshark_xx.ts contains
> all the keyboard shortcuts (e.g. like 'Ctrl+Home'). Therefore these terms
> are also listed in Transifex.
> 
> However these terms are translated "automatically" with the qt_xx.qm
> files. Doing a manually translation breaks the display of the shortcuts in
> the UI (s.
> https://www.wireshark.org/lists/wireshark-dev/201511/msg00101.html).
> 
> I did the mistake to translate the terms some month ago and another
> member of the German Transifex team has done the same mistake this week.
> 
> How can we prevent this?
> * Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)

I looked through the manual
(https://doc.qt.io/qt-5/linguist-translators.html) and did not find an
option to disable translation for such options. It should however be
possible to remove the shortcuts from the .ts files and add them to the
cpp files instead using the setShortcut method of QActions. See:

 - https://doc.qt.io/qt-5/qaction.html#shortcut-prop
 - https://doc.qt.io/qt-5/qkeysequence.html#details
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] QT translation: lock keyboard shortcut terms?

2016-04-01 Thread Uli Heilmeier 
Hi list,

At the moment the translation source files ui/qt/wireshark_xx.ts contains
all the keyboard shortcuts (e.g. like 'Ctrl+Home'). Therefore these terms
are also listed in Transifex.

However these terms are translated "automatically" with the qt_xx.qm
files. Doing a manually translation breaks the display of the shortcuts in
the UI (s.
https://www.wireshark.org/lists/wireshark-dev/201511/msg00101.html).

I did the mistake to translate the terms some month ago and another
member of the German Transifex team has done the same mistake this week.

How can we prevent this?
* Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
* Lock the terms (non writeable) in Transifex (if feasible)
* Establish a review process (like Gerrit) for translation files

At the moment the translation is synced automatically (also for master-20).

Any opinions?

Cheers
Uli
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe