Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Thu, Jan 11, 2007 at 01:59:56PM -, Douglas Pratley wrote: > This is a patch adding items to the context menus for the packet list > and packet details panes for copying packet data to the clipboard. Looking good so far. I fixed a few warnings about unused variables. BTW, if you have a function call that takes a parameter that it doesn't use you can put _U_ after it and Wireshark's compilation process will expand that to code that tells (gcc at least) not to warn about that. > I'm not convinced that Base64 is useful; I wanted to implement a > non-trivial encoding to test a particular path through the code. Instead of encoding the contents into base64, decoding a stream of base64 data and placing the decoded data in the clipboard would be very useful. > I have not updated any documentation because I cannot find a > description of what context menu items do anywhere (main menu items > are listed in the man page). If I should have done, please let me > know. The documentation here needs to be updated with new screenshots and text: http://www.wireshark.org/docs/wsug_html_chunked/ChWorkDisplayPopUpSection.html You can find this chapter in the source as docbook/wsug_src/WSUG_chapter_work.xml. Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
Hi Steve > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Stephen Fisher > Sent: 22 January 2007 01:10 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy > packet data > > On Thu, Jan 11, 2007 at 01:59:56PM -, Douglas Pratley wrote: > > > This is a patch adding items to the context menus for the > packet list > > and packet details panes for copying packet data to the clipboard. > > Looking good so far. I fixed a few warnings about unused variables. > BTW, if you have a function call that takes a parameter that > it doesn't use you can put _U_ after it and Wireshark's > compilation process will expand that to code that tells (gcc > at least) not to warn about that. > Ah. I'm doing my development on Windows and not seeing these - I guess MSCV6 doesn't warn on this at the level that Wireshark builds. While I'm doing a build / test cycle on Fedora before sending out the patch, I've not been checking the build output for warnings on gcc. I'll try to do so in future. > > I have not updated any documentation because I cannot find a > > description of what context menu items do anywhere (main menu items > > are listed in the man page). If I should have done, please let me > > know. > > The documentation here needs to be updated with new screenshots and > text: > http://www.wireshark.org/docs/wsug_html_chunked/ChWorkDisplayP > opUpSection.html > You can find this chapter in the source as > docbook/wsug_src/WSUG_chapter_work.xml. > OK - I'll get this done and send in a patch for the documentation. Are you holding off on committing the code until I've done this? > > Steve > Cheers Doug > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately. Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies. Detica Limited is registered in England under No: 1337451. Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Mon, Jan 22, 2007 at 10:54:44AM -, Douglas Pratley wrote: > > The documentation here needs to be updated with new screenshots and > > text: > > OK - I'll get this done and send in a patch for the documentation. Are > you holding off on committing the code until I've done this? Yes :). I was also wondering if you could change the base64 encoder feature to decode instead. Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
Hi Steve > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Stephen Fisher > Sent: 22 January 2007 20:24 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy > packet data > > On Mon, Jan 22, 2007 at 10:54:44AM -, Douglas Pratley wrote: > > > > The documentation here needs to be updated with new > screenshots and > > > text: > > > > OK - I'll get this done and send in a patch for the > documentation. Are > > you holding off on committing the code until I've done this? > > Yes :). That's what I assumed - I've sent in a patch for the documentation. > > I was also wondering if you could change the base64 > encoder feature to decode instead. Hmm. I can see that might be useful (more useful than the current menu option). Unfortunately I'm right in the middle of big piece of work - adding the ability to select dissectors based on display filters - and I'd rather get that finished first. Would it be possible to accept the patch as it is (or possibly remove the Base64 menu items and documentation to avoid future confusion) for the moment? I'd hope to be able to look at a quick change to do Base64 decoding of data in a couple of weeks. I'm afraid I'm getting paid for this work, which means that I have a bunch of users and a manager to answer to - although we're obviously keen to make changes that are useful to the community as well as to ourselves. Cheers Doug This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately. Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies. Detica Limited is registered in England under No: 1337451. Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Thu, Jan 11, 2007 at 01:59:56PM -, Douglas Pratley wrote: > This is a patch adding items to the context menus for the packet list > and packet details panes for copying packet data to the clipboard. I've checked in your changes as SVN revision 20581. Thanks for your contribution! I'll check in your documentation changes next. I did make the following changes: - Removed base64 encoding support as we discussed. This leaves room for a base64 decoder as a future feature. - moved eth_clist_get_text define up higher in the list of defines to keep it alphabetically sorted (packet_list.c) - took out the empty gtk1 copy_binary_to_clipboard function and wrapped its declaration in the header file and case(CD_BINARY) in #if GTK_MAJOR_VERSION >= 2 (gui_utils.c / gui_utils.h) - wrapped create_copy_binary_t and destroy_copy_binary_t within the same #if GTK_MAJOR_VERSION >= 2 since those functions aren't used in GTK1 - took extra new line break out of end of proto_draw.h - changed all calls to g_string_append_printf to g_string_sprintfa for GTK1 compatibility - changed call to g_ascii_isprint to isprint for GTK1 compatibility (proto_draw.c) - changed call to g_string_append_len to g_string_append for GTK1 compatability since it was appending the entire string anyway (proto_draw.c) Thanks, Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Mon, Jan 22, 2007 at 02:41:58PM -, Douglas Pratley wrote: > Here is a patch for the documentation on the pop-up menus. Please note > that the .diff file is from the top-level, even though it affects only > one file. Your attachment came across as a winmail.dat file that my mail reader can't understand. Could you try sending it again or with a different mail program? Thanks, Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
[EMAIL PROTECTED] wrote: > Log: > From Douglas Pratley: > > This is a patch adding items to the context menus for the packet list > and packet details panes for copying packet data to the clipboard. > > New menu item on packet list pane: > Copy (sub menu) -> > Summary (Text) Copies fields displayed in the packet > list, tab separated > Summary (CSV) Copies fields displayed in the packet > list, comma separated > Hex and TextCopies data for the selected frame in > hex-editor style (similar to Copy\All Information in packet bytes pane) > Text Only Copies data for the selected frame, > dropping non-printable characters other than line breaks (similar to > Copy\Text Only in packet bytes pane) > Hex Columns As Hex and Text but without text > Hex Stream Copies data for the selected frame as an > unpunctuated list of hex values > Binary Stream Copies raw packet bytes to the clipboard > as MIME type application/octet-stream > Nice work! As usual some GUI nitpicking from me ;-) Comparing the context menus (packet list, details, bytes), they have no common way they are named (especially in combination with the existing menu items), it's looking a bit weird now. In addition, I had to try some things out before I get the actual meaning. So a new layout proposal of the corresponding menu items: 1.) Packet List / Copy item: Summary (Text) Summary (CSV) -- Bytes (Offset Hex Text) Bytes (Offset Hex) Bytes (Printable Text Only) -- Bytes (Hex Stream) Bytes (Binary Stream) 2.) Packet Details / Copy item (only one Copy item in this menu): Description -- Bytes (Offset Hex Text) Bytes (Offset Hex) Bytes (Printable Text Only) -- Bytes (Hex Stream) Bytes (Binary Stream) 3.) Packet Bytes / Copy item: The usability of this menu is completely odd, as you select things you don't want. With the new Details menu the dialog menu is completely obsolete - after some cleanup. Namely moving the "Export Selected Packet Bytes" item to Packet Details menu (shouldn't be too difficult?!?). We might also want to remove this export feature completely, as I guess that the "Copy" mechanism is what users really need ... What do you think about all the name changes? BTW: Is the "Printable Text" a good idea? Wouldn't the "common" replacement of unprintable chars by dots be more common / helpful? Or is there even a need for both? Again, your work was already overdue in my eyes, thanks for doing it! Regards, ULFL ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Stephen Fisher > Sent: 28 January 2007 02:54 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy > packet data > > On Thu, Jan 11, 2007 at 01:59:56PM -, Douglas Pratley wrote: > > > This is a patch adding items to the context menus for the > packet list > > and packet details panes for copying packet data to the clipboard. > > I've checked in your changes as SVN revision 20581. Thanks > for your contribution! I'll check in your documentation > changes next. I did make the following changes: Great! Glad to get something done. > > - Removed base64 encoding support as we discussed. This > leaves room for a base64 decoder as a future feature. > Could you give an example of how you might see this working, perhaps with a capture file? Some initial thoughts - I think we'd need to give the user more power to select an exact set of bytes (to avoid preamble / postamble). If we're talking about e.g. mail attachments on SMTP, then the clipboard might not be a good target - straight to file might be better. Are there any other encodings / decodings it would be worth having available (uuencode? zip?). This might be better done as a full "Select bytes and decode / encode" feature rather than something in a copy menu. In any case, probably best left until any changes coming out of discussion of Ulf's email are carried out. > - changed all calls to g_string_append_printf to > g_string_sprintfa for > GTK1 compatibility > > - changed call to g_ascii_isprint to isprint for GTK1 compatibility > (proto_draw.c) > > - changed call to g_string_append_len to g_string_append for > GTK1 compatability since it was appending the entire string anyway > (proto_draw.c) I've changed my bookmark in Firefox to point at the old GLib 1 API documentation, so should avoid this in future. > > > Thanks, > Steve > > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > Cheers Doug This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately. Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies. Detica Limited is registered in England under No: 1337451. Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Ulf Lamping > Sent: 28 January 2007 04:40 > To: wireshark-dev@wireshark.org > Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy > packet data > > Nice work! Thanks > > As usual some GUI nitpicking from me ;-) > You warned me before I started! Hopefully my documentation patch will be committed soon, which might make life a little easier (my first attempt was mangled by Outlook). > So a new layout proposal of the corresponding menu items: > > 1.) Packet List / Copy item: > Summary (Text) > Summary (CSV) > -- > Bytes (Offset Hex Text) > Bytes (Offset Hex) > Bytes (Printable Text Only) > -- > Bytes (Hex Stream) > Bytes (Binary Stream) > I like this. > 2.) Packet Details / Copy item (only one Copy item in this menu): > Description > -- > Bytes (Offset Hex Text) > Bytes (Offset Hex) > Bytes (Printable Text Only) > -- > Bytes (Hex Stream) > Bytes (Binary Stream) I agree that it would be good to combine the Copy / Copy Selected Bytes menu items. I didn't for the first cut as I didn't want to interfere with existing functionality. Is "Description" the right phrase? I find it vague, but can't think of anything better. These items do something different to the ones from Menu (1); they copy only the selected bytes. That is why they are "inconsistent" at the moment. I agree that it is ugly to have them different, but is the context of having a row within a packet enough to make it intuitive on its own? > > 3.) Packet Bytes / Copy item: > The usability of this menu is completely odd, as you select > things you don't want. > With the new Details menu the dialog menu is completely > obsolete - after some cleanup. Namely moving the "Export > Selected Packet Bytes" item to Packet Details menu (shouldn't > be too difficult?!?). We might also want to remove this > export feature completely, as I guess that the "Copy" > mechanism is what users really need ... Again, I was reluctant to change existing functionality; I think that we should either drop the Copy and move the Export as you suggest, or else duplicate the same Copy and Export functionality across both pop-ups (either should be easy). The question is, is there anybody out there who is going to be upset if we remove this functionality (or more accurately, move it and rename it). I'd value a third opinion! > > BTW: Is the "Printable Text" a good idea? Wouldn't the "common" > replacement of unprintable chars by dots be more common / > helpful? Or is there even a need for both? > Don't know - quite possibly both - I actually think we could probably do with more advanced functionality that copes with unicode text (UTF-8 and UTF-16) as well. Steve F suggested being able to decode Base64 would be useful. I hope that this patch will give a better baseline for all of that if anyone gets the time to do it. I'm tempted to leave it for a few days to let my documentation patch work its way through and to let others comment (they've been quiet so far); if they stay quiet I'll then implement your suggestions. Cheers Doug This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately. Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies. Detica Limited is registered in England under No: 1337451. Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Mon, Jan 29, 2007 at 10:22:15AM -, Douglas Pratley wrote: > > - Removed base64 encoding support as we discussed. This leaves > > room for a base64 decoder as a future feature. > > Could you give an example of how you might see this working, perhaps > with a capture file? > Some initial thoughts - I think we'd need to give the user more power > to select an exact set of bytes (to avoid preamble / postamble). If > we're talking about e.g. mail attachments on SMTP, then the clipboard > might not be a good target - straight to file might be better. I think users would be satisfied with a pop-up screen that displayed the decoded content. We've also considered adding this to the follow tcp stream window. I started to, but ran into the problem where our(?) code is adding extra line breaks when you copy and paste or save out of a follow tcp stream window. > Are there any other encodings / decodings it would be worth having > available (uuencode? zip?). This might be better done as a full > "Select bytes and decode / encode" feature rather than something in a > copy menu. Good point. For viewing encoded e-mail contents, uudecode support may be useful, though it's not very popular these days as far as I can tell. We could go the whole way and even add viewers for images contained within capture files. I'm not sure how useful this would be? Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Mon, Jan 29, 2007 at 10:04:20AM -, Douglas Pratley wrote: > Try this - the tar / gzip tools I have on Windows seem to be a bit > tempermental, which is why I have been avoiding them, but if Outlook > is going to mangle the files... I got the images but not the patch this time ;). The documentation patch file is just a tar of the images again. Go ahead and send the documentation patch within an e-mail's body. Thanks, Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
Douglas Pratley wrote: >> 2.) Packet Details / Copy item (only one Copy item in this menu): >> Description >> -- >> Bytes (Offset Hex Text) >> Bytes (Offset Hex) >> Bytes (Printable Text Only) >> -- >> Bytes (Hex Stream) >> Bytes (Binary Stream) >> > I agree that it would be good to combine the Copy / Copy Selected Bytes > menu items. I didn't for the first cut as I didn't want to interfere > with existing functionality. > Ack, keeping a contribution as simple as possible is a good idea - but now we're already in the second round ;-) > Is "Description" the right phrase? I find it vague, but can't think of > anything better. > Same problem I had. I also just don't know a good and suitable name here. Anyone else? > These items do something different to the ones from Menu (1); they copy > only the selected bytes. That is why they are "inconsistent" at the > moment. I agree that it is ugly to have them different, but is the > context of having a row within a packet enough to make it intuitive on > its own? > I guess so. This is a *context* menu, so it's ok in my eyes that the same entry at different places will copy different parts. BTW: I disagree that "these items do something different". They copy the currently selected bytes in both cases, only the amount is different, namely corresponding to the selection. >> 3.) Packet Bytes / Copy item: >> The usability of this menu is completely odd, as you select >> things you don't want. >> With the new Details menu the dialog menu is completely >> obsolete - after some cleanup. Namely moving the "Export >> Selected Packet Bytes" item to Packet Details menu (shouldn't >> be too difficult?!?). We might also want to remove this >> export feature completely, as I guess that the "Copy" >> mechanism is what users really need ... >> > > Again, I was reluctant to change existing functionality; I think that we > should either drop the Copy and move the Export as you suggest, or else > duplicate the same Copy and Export functionality across both pop-ups > (either should be easy). > As the functionality doesn't work nicely in the Bytes pane, I'd vote to just remove it. We can add it later again if someone is shouting "foul" loud enough ;-) > The question is, is there anybody out there who is going to be upset if > we remove this functionality (or more accurately, move it and rename > it). I'd value a third opinion! > Well, removing *might* be a problem. My observation over the last years of Ethereal / Wireshark development is that anything that is changed, there's someone who will dislike it, regardless what your doing. >> BTW: Is the "Printable Text" a good idea? Wouldn't the "common" >> replacement of unprintable chars by dots be more common / >> helpful? Or is there even a need for both? >> > Don't know - quite possibly both - I actually think we could probably > do with more advanced functionality that copes with unicode text (UTF-8 > and UTF-16) as well. Steve F suggested being able to decode Base64 would > be useful. I hope that this patch will give a better baseline for all of > that if anyone gets the time to do it. > Ack, having a basic "copy" mechanism is a good idea. Don't know if an UTF-8 will work nicely on Windows, but that needs further investigation. > I'm tempted to leave it for a few days to let my documentation patch > work its way through and to let others comment (they've been quiet so > far); if they stay quiet I'll then implement your suggestions. > I guess, the first comments you'll get is when the 0.99.6 is released in a lot of weeks ;-) Regards, ULFL ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
Stephen Fisher wrote: > On Mon, Jan 29, 2007 at 10:22:15AM -, Douglas Pratley wrote: > >> Are there any other encodings / decodings it would be worth having >> available (uuencode? zip?). This might be better done as a full >> "Select bytes and decode / encode" feature rather than something in a >> copy menu. >> > Good point. For viewing encoded e-mail contents, uudecode support may > be useful, though it's not very popular these days as far as I can tell. > We could go the whole way and even add viewers for images contained > within capture files. I'm not sure how useful this would be? > Every program attempts to expand until it can read mail ;-))) Ok, serious again, this is more of a question about a general way to copy/export/display "generic objects". Why not be able to copy/export/display a picture from a HTTP capture, or a HTML page, or ... Other analyzers will provide you with a list of files, derived from the captured HTTP packets, with an option to display/export it. That reminds me of the media dissector which already gets in that direction - we are getting more and more into the application layer - and I like it :-) Regards, ULFL ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
Ok, I've attached the text as well. I must have done something odd with tar and gzip (you can probably tell that I'm more familiar with Windows than UNIX tools). Will be more cautious next time... Cheers Doug -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Stephen Fisher Sent: 30 January 2007 19:28 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy packet data On Mon, Jan 29, 2007 at 10:04:20AM -, Douglas Pratley wrote: > Try this - the tar / gzip tools I have on Windows seem to be a bit > tempermental, which is why I have been avoiding them, but if Outlook > is going to mangle the files... I got the images but not the patch this time ;). The documentation patch file is just a tar of the images again. Go ahead and send the documentation patch within an e-mail's body. Thanks, Steve Index: docbook/wsug_src/WSUG_chapter_work.xml === --- docbook/wsug_src/WSUG_chapter_work.xml (revision 20523) +++ docbook/wsug_src/WSUG_chapter_work.xml (working copy) @@ -166,7 +166,87 @@ + + Copy/ Summary (Text) + - + + + Copy the summary fields as displayed to the clipboard, as tab-separated text. + + + + + Copy/ Summary (CSV) + - + + + Copy the summary fields as displayed to the clipboard, as comma-separated text. + + + + + Copy/ Hex and Text + - + + + Copy the packet bytes to the clipboard in hexdump-like format; similar to the Packet Bytes Pane + "Copy/ All Information" command. + + + + + Copy/ Text Only + - + + + Copy the packet bytes to the clipboard as ASCII text; similar to the Packet Bytes Pane + "Copy/ Text Only" command. + + + + + Copy/ Hex Columns + - + + + Copy the packet bytes to the clipboard in hexdump-like format, but without the text portion. + + + + + Copy/ Hex Stream + - + + + Copy the packet bytes to the clipboard as an unpunctuated list of hex digits. + + + + + Copy/ Base64 Stream + - + + + Copy the packet bytes to the clipboard as a Base64 text encoding. + + + + + Copy/ Binary Stream + - + + + Copy the packet bytes to the clipboard as raw binary. The data is stored in the + clipboard as MIME-type "application/octect-stream". + This option is not available in versions of Wireshark built using GTK+ 1.x. + + + - + + + + Decode As... Analyze @@ -225,21 +305,6 @@ - Copy - - - - - Copy the displayed text of the selected field to the system - clipboard. - - - - - - - - - - Expand Subtrees View @@ -275,6 +340,79 @@ + Copy + - + + + Copy the displayed text of the selected field to the system + clipboard. + + + + + Copy Selected Bytes As/ Hex and Text + - + + + Copy the selected packet bytes to the clipboard in hexdump-like format; similar to the Packet Bytes Pane + "Copy/ All Information" command, but copies only the bytes relevant to the selected part of the tree (the bytes selected + in the Packet Bytes Pane). + + + +
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
> > Stephen Fisher wrote: > > On Mon, Jan 29, 2007 at 10:22:15AM -, Douglas Pratley wrote: > > > >> Are there any other encodings / decodings it would be worth having > >> available (uuencode? zip?). This might be better done as a full > >> "Select bytes and decode / encode" feature rather than > something in a > >> copy menu. > >> > > Good point. For viewing encoded e-mail contents, uudecode > support may > > be useful, though it's not very popular these days as far > as I can tell. > > We could go the whole way and even add viewers for images contained > > within capture files. I'm not sure how useful this would be? > > > > Every program attempts to expand until it can read mail ;-))) ...and browse the web, these days. Wouldn't take much to integrate an HTML display engine into Wireshark, surely ;-) > > Ok, serious again, this is more of a question about a > general way to copy/export/display "generic objects". Why not > be able to copy/export/display a picture from a HTTP capture, > or a HTML page, or ... > > Other analyzers will provide you with a list of files, > derived from the captured HTTP packets, with an option to > display/export it. > > That reminds me of the media dissector which already gets in > that direction - we are getting more and more into the > application layer - and I like it :-) Given time, I'd tackle it like this, in three layers. 1) Provide the user with ways to select bytes of interest: a) User can select exactly the bytes they want [New feature] b) User can select the bytes represented by a line in the packet details pane; dissectors can be "helpful" here, by breaking packets down appropriately [Existing feature] c) Specialist analysis for content-rich formats (mail, HTTP); I don't know what is already in Wireshark. These could provide lists of embedded data. 2) Ability to apply decodings / encodings to bytes of interest; I think this should _not_ be built into the dissectors, as you then have to repeat the code, or find you can't actually apply it to the exact set of bytes that you want. A "reflective" architecture where encodings are registered would make sense - easy to generate lists. 3) Ability to move encoded bytes (encoding may have been a NOOP) to file, clipboard, viewers (again, registered viewers). Each layer should be available, and hence re-usable, from within the whole UI codebase, so defining decent interfaces would be important. If this makes sense (some might think it over-engineered), I'll put together a wish-list entry, and also put it forward as a suggestion in our internal process. Unfortunately, I'm not free to tackle something this large off my own bat in work time (and I'm organising my upcoming wedding in my free time, so am not my own boss there either!). It's possible that I'll get a chance to work on it later, or someone else might like the idea enough to pick it up and run with it. Cheers Doug This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately. Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies. Detica Limited is registered in England under No: 1337451. Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Wed, Jan 31, 2007 at 09:14:24AM -, Douglas Pratley wrote: > Ok, I've attached the text as well. > > I must have done something odd with tar and gzip (you can probably > tell that I'm more familiar with Windows than UNIX tools). Will be > more cautious next time... The attachment came across fine this time. I've committed your changes to the xml document and the two png files as SVN revision 20654. Thanks! Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Wed, Jan 31, 2007 at 04:01:39AM +0100, Ulf Lamping wrote: > Ok, serious again, this is more of a question about a general way to > copy/export/display "generic objects". Why not be able to > copy/export/display a picture from a HTTP capture, or a HTML page, or > ... > > Other analyzers will provide you with a list of files, derived from > the captured HTTP packets, with an option to display/export it. I'm now working on adding this feature as my time permits. Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Wed, Feb 07, 2007 at 04:52:50PM -0800, Stephen Fisher wrote: > On Wed, Jan 31, 2007 at 04:01:39AM +0100, Ulf Lamping wrote: > > > Other analyzers will provide you with a list of files, derived from > > the captured HTTP packets, with an option to display/export it. > > I'm now working on adding this feature as my time permits. I've committed the initial version of this new feature as SVN revision 20867. Can others please try it out and let me know their comments on the implementation. It's under Statistics -> Content List -> HTTP. This new sub-menu under Statistics lets us add the feature for other dissectors that reassemble content for us (which ones do?). The FTP dissector would need some additional work before this works there. When we add additional protocol support, we can move some of content_list_http.c into a common file and have one smaller file for each protocol. However, The statistics menu is messed up in my Windows build environment (MSVC 2005 EE). Everything is one off from the group it should be in. The HTTP option is still buried within the content list menu. Anyone else seeing this? I'm still trying to figure out why this is happening but if anyone has an idea let me know. Thanks, Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Mon, Feb 19, 2007 at 03:50:57PM -0800, Stephen Fisher wrote: > However, The statistics menu is messed up in my Windows build > environment (MSVC 2005 EE). Everything is one off from the group it > should be in. The HTTP option is still buried within the content list > menu. Anyone else seeing this? I'm still trying to figure out why > this is happening but if anyone has an idea let me know. I should note that it looks fine in Unix. Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
That sounds familiar... Just today I noticed that if I enable Lua on windows the "Tools" menu (that is hidden unless Lua uses it) ends up as a submenu of "User Tables". As in your case this infact does not happen on my mac. The reason of the different behaviour is still unknown to me. As I think it probably has to do with the changes I made to menu.c to add the "User Tables" menu I planned to investigate it on the next weekend. BTW I trying to understand an odd crash I see on windows after an exception (due to a very corrupt packet) is thrown that does not happen against my mac. Luis On 2/20/07, Stephen Fisher <[EMAIL PROTECTED]> wrote: > On Mon, Feb 19, 2007 at 03:50:57PM -0800, Stephen Fisher wrote: > > > However, The statistics menu is messed up in my Windows build > > environment (MSVC 2005 EE). Everything is one off from the group it > > should be in. The HTTP option is still buried within the content list > > menu. Anyone else seeing this? I'm still trying to figure out why > > this is happening but if anyone has an idea let me know. > > I should note that it looks fine in Unix. > > > Steve > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > -- This information is top security. When you have read it, destroy yourself. -- Marshall McLuhan ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Feb 19, 2007, at 3:50 PM, Stephen Fisher wrote: > I've committed the initial version of this new feature as SVN revision > 20867. Can others please try it out and let me know their comments on > the implementation. It's under Statistics -> Content List -> HTTP. I'm not sure "Statistics" is the best top-level menu bar item for it, as it's not just summary statistics - but I'm not sure what the *right* top-level menu bar item would be (either an existing one or a new one). ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Mon, Feb 19, 2007 at 07:10:53PM -0800, Guy Harris wrote: > > On Feb 19, 2007, at 3:50 PM, Stephen Fisher wrote: > > > I've committed the initial version of this new feature as SVN revision > > 20867. Can others please try it out and let me know their comments on > > the implementation. It's under Statistics -> Content List -> HTTP. > > I'm not sure "Statistics" is the best top-level menu bar item for it, > as it's not just summary statistics - but I'm not sure what the > *right* top-level menu bar item would be (either an existing one or a > new one). Thanks for your feedback. My initial thought was to put it under the View menu... Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
On Tue, Feb 20, 2007 at 01:06:16AM +0100, Luis Ontanon wrote: > That sounds familiar... Just today I noticed that if I enable Lua on > windows the "Tools" menu (that is hidden unless Lua uses it) ends up > as a submenu of "User Tables". As in your case this infact does not > happen on my mac. The reason of the different behaviour is still > unknown to me. > > As I think it probably has to do with the changes I made to menu.c to > add the "User Tables" menu I planned to investigate it on the next > weekend. After wasting a lot of time wondering what could be wrong, I decided to download the buildbot's version and it looks correct this time. I then did a make clean and make all again on my MSVC 2005EE version and it works there too now! > BTW I trying to understand an odd crash I see on windows after an > exception (due to a very corrupt packet) is thrown that does not > happen against my mac. Are you using the MSVC debugging tools? Steve ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
I backed up the changes I made. And now it looks fine at least to me. BTW I'd love if someone with some knowledge of the way menus work could explain to me why I got that broken... and why adding the "Tools" menu did not. Luis On 2/20/07, Luis Ontanon <[EMAIL PROTECTED]> wrote: > That sounds familiar... > Just today I noticed that if I enable Lua on windows the "Tools" menu > (that is hidden unless Lua uses it) ends up as a submenu of "User > Tables". As in your case this infact does not happen on my mac. The > reason of the different behaviour is still unknown to me. > > As I think it probably has to do with the changes I made to menu.c to > add the "User Tables" menu I planned to investigate it on the next > weekend. > > BTW I trying to understand an odd crash I see on windows after an > exception (due to a very corrupt packet) is thrown that does not > happen against my mac. > > Luis > > On 2/20/07, Stephen Fisher <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 19, 2007 at 03:50:57PM -0800, Stephen Fisher wrote: > > > > > However, The statistics menu is messed up in my Windows build > > > environment (MSVC 2005 EE). Everything is one off from the group it > > > should be in. The HTTP option is still buried within the content list > > > menu. Anyone else seeing this? I'm still trying to figure out why > > > this is happening but if anyone has an idea let me know. > > > > I should note that it looks fine in Unix. > > > > > > Steve > > ___ > > Wireshark-dev mailing list > > Wireshark-dev@wireshark.org > > http://www.wireshark.org/mailman/listinfo/wireshark-dev > > > > > -- > This information is top security. When you have read it, destroy yourself. > -- Marshall McLuhan > -- This information is top security. When you have read it, destroy yourself. -- Marshall McLuhan ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [PATCH] New menu items to copy packet data
Luis Ontanon wrote: > I backed up the changes I made. And now it looks fine at least to me. > > BTW I'd love if someone with some knowledge of the way menus work > could explain to me why I got that broken... and why adding the > "Tools" menu did not. > > Luis > On 2/20/07, Luis Ontanon <[EMAIL PROTECTED]> wrote: > Hi Luis! Yes, the menu system is a beast on it's own. I've implemented the mechanism with the goal in mind to dynamically add things to the existing Analyze and Statistics menus - not to be a general approach. I can't remember if this is a limitation of my implementation or caused by the way the menu systems work. But as I know myself, if there would be a reasonable way to write these things in a generic way I would have done it. I didn't followed the changes you've done, so I can't give you more detailed help right now ... Regards, ULFL ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
