Re: [PATCH] WPrefs: add expert option to disable switch panel
Oh well. Still this isn't cycling, we find cycling alt-tab in other platforms GUIs, all right? Yury On 06/05/2014 07:37 AM, David Maciejak wrote: Enclosed the patch with lain text proposal Show switch panel when cycling windows. and with logic changed, to amend commit c994b65f14ad2ab872f5c1b91119d78885743cfc. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoth Yury Tarasievich, Oh well. Still this isn't cycling, we find cycling alt-tab in other platforms GUIs, all right? I'm not dead set on the word cycling I just want us to be consistent about what we do use. Having said that I do think that cycling is fine because if you keep pressing FocusNextKey you keep on iterating through the window list but if you want to call that switching instead then I won't object as long as you can convince everyone else that it's worth changing. If we do change it we'll probably need different text for the new preference because Show switch panel when switching windows is a bit weird. Just Show panel... maybe? Either way, since I raised the point I'm happy to go through and replace all occurrences of the old terminology once we've decided. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On 06/05/2014 09:19 AM, Iain Patterson wrote: Quoth Yury Tarasievich, Oh well. Still this isn't cycling, we find cycling alt-tab in other platforms GUIs, all right? I'm not dead set on the word cycling I just want us to be consistent about what we do use. Consistency is a big problem in OSS as a class, anyway. Having said that I do think that cycling is fine because if you keep pressing FocusNextKey you keep on iterating through the window list To repeat myself, if you do one-off alt-tab, do you get cycling? In fact, you get the opposite, or, at least, not cycling through the initial set. When you work with switch panel activated, you get additional visual element, which doesn't change the base logic of the action, but provides additional controls. This just doesn't boil down to cycle, this is broader than just cycle, but then again, having had worked on l10n for a while, I just might have a somewhat different perspective on this... BTW, I still remember this little change of logic of alt-tab behaviour was quite a source of confusion to me in days of transition from os2/win guis. These days, I rely on this feature. :) but if you want to call that switching instead then I won't object as long as you can convince everyone else that it's worth changing. Well, I won't put any additional effort into this worthy task. It's sort of people problem, not argument problem: changes on the scale of this are disproportionally hard to negotiate. If we do change it we'll probably need different text for the new preference because Show switch panel when switching windows is a bit weird. Just Show panel... maybe? There are lots of panels, which one do you have in mind? :) Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Thursday 2014-06-05 09:58:13 Iain Patterson: Quoth Yury Tarasievich, There are lots of panels, which one do you have in mind? :) The one that shows up when you switch windows, hence Show panel when switching windows :) you mean cycle windows? ;-) -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Double-click on application in wmdock does not launch the application if one instance is already running
Hello As said in the subject, double-click on an application in wmdock does not launch the application in case there is an instance of the application already running. As I heard from a friend of mine it used to work in 0.95.3 and previous versions of Windowmaker with Shared application icon check box turned on for a specific application that has been added to wmdock. With version 0.95.5 and version from current git repository it is not the case any more. It is possible to launch additional instance by using right-click and selecting Launch option but this really sucks. Is this behavior intentional? A friend of mine decided to downgrade to 0.95.3 until this is resolved. It seems that Windowmaker users constitute a class of users that really don't like unexpected changes. :-) -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-440-gf33c89e3
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
discards c7a91d7750c2b1acc160f7b5d22fcf0b7936516e (commit)
discards c994b65f14ad2ab872f5c1b91119d78885743cfc (commit)
via f33c89e369de347fece7a40b86ff74a2dd3dc3a6 (commit)
via b323800c02b0a06bfeac3a769ec30599935f3227 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (c7a91d7750c2b1acc160f7b5d22fcf0b7936516e)
N -- N -- N (f33c89e369de347fece7a40b86ff74a2dd3dc3a6)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/f33c89e369de347fece7a40b86ff74a2dd3dc3a6
commit f33c89e369de347fece7a40b86ff74a2dd3dc3a6
Author: David Maciejak david.macie...@gmail.com
Date: Thu Jun 5 11:23:51 2014 +0700
WPrefs: add expert option to disable switch panel
This patch is adding a checkbox option in the expert panel
to let the user enable/disable switching panel.
diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
index e939df03..8cf5d6d9 100644
--- a/WPrefs.app/Expert.c
+++ b/WPrefs.app/Expert.c
@@ -2,6 +2,7 @@
*
* WPrefs - Window Maker Preferences Program
*
+ * Copyright (c) 2014 Window Maker Team
* Copyright (c) 1998-2003 Alfredo K. Kojima
*
* This program is free software; you can redistribute it and/or modify
@@ -31,6 +32,7 @@ static const struct {
enum {
OPTION_WMAKER,
+ OPTION_WMAKER_ARRAY,
OPTION_USERDEF
} class;
@@ -65,6 +67,9 @@ static const struct {
{ N_(Ignore minimized windows when cycling.),
/* default: */ False, OPTION_WMAKER, CycleIgnoreMinimized },
+ { N_(Show switch panel when cycling windows.),
+ /* default: */ True, OPTION_WMAKER_ARRAY, SwitchPanelImages },
+
{ N_(Show workspace title on Clip.),
/* default: */ True, OPTION_WMAKER, ShowClipTitle },
@@ -96,7 +101,7 @@ typedef struct _Panel {
#define ICON_FILE expert
-static void createPanel(Panel * p)
+static void createPanel(Panel *p)
{
_Panel *panel = (_Panel *) p;
WMScrollView *sv;
@@ -134,6 +139,14 @@ static void createPanel(Panel * p)
state = expert_options[i].def_state;
break;
+ case OPTION_WMAKER_ARRAY: {
+ char *str =
GetStringForKey(expert_options[i].op_name);
+ state = expert_options[i].def_state;
+ if (str strcasecmp(str, None) == 0)
+ state = False;
+ }
+ break;
+
case OPTION_USERDEF:
state = WMGetUDBoolForKey(udb,
expert_options[i].op_name);
break;
@@ -141,7 +154,7 @@ static void createPanel(Panel * p)
default:
#ifdef DEBUG
wwarning(export_options[%d].class = %d, this should
not happenn,
-i, expert_options[i].class);
+ i, expert_options[i].class);
#endif
state = expert_options[i].def_state;
break;
@@ -154,7 +167,7 @@ static void createPanel(Panel * p)
WMRealizeWidget(panel-box);
}
-static void storeDefaults(_Panel * panel)
+static void storeDefaults(_Panel *panel)
{
WMUserDefaults *udb = WMGetStandardUserDefaults();
int i;
@@ -165,6 +178,17 @@ static void storeDefaults(_Panel * panel)
SetBoolForKey(WMGetButtonSelected(panel-swi[i]),
expert_options[i].op_name);
break;
+ case OPTION_WMAKER_ARRAY:
+ if (WMGetButtonSelected(panel-swi[i])) {
+ /* check if the array was not manually modified
*/
+ char *str =
GetStringForKey(expert_options[i].op_name);
+ if (str strcasecmp(str, None) == 0)
+
RemoveObjectForKey(expert_options[i].op_name);
+ }
+ else
+ SetStringForKey(None,
expert_options[i].op_name);
+
Re: Double-click on application in wmdock does not launch the application if one instance is already running
On Thu, 5 Jun 2014, Josip Deanovic wrote: As said in the subject, double-click on an application in wmdock does not launch the application in case there is an instance of the application already running. As I heard from a friend of mine it used to work in 0.95.3 and previous versions of Windowmaker with Shared application icon check box turned on for a specific application that has been added to wmdock. With version 0.95.5 and version from current git repository it is not the case any more. It is possible to launch additional instance by using right-click and selecting Launch option but this really sucks. Is this behavior intentional? I don't think it ever worked the way you describe or if it did it was probably a bug. What used to work and should still work is starting additional instances with Ctrl+double click. So I think this is intentional and not a regression. Regards, BALATON Zoltan -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Double-click on application in wmdock does not launch the application if one instance is already running
Quoth BALATON Zoltan, I don't think it ever worked the way you describe or if it did it was probably a bug. What used to work and should still work is starting additional instances with Ctrl+double click. So I think this is intentional and not a regression. Going from memory, since I don't use the dock and haven't built from any recent commits, starting a docked application wait()s for the process so if it runs in the foreground you can't launch another one except via one of the methods already discussed. I thought it had always been that way. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] wmaker: increase logo size
On 06/04/2014 10:47 PM, David Maciejak wrote: Increase the size to default 64x64, please test. --- WindowMaker/Icons/GNUstep.tiff | Bin 906 - 3014 bytes WindowMaker/Icons/GNUstep.xpm | 326 ++--- 2 files changed, 271 insertions(+), 55 deletions(-) Personally, I use GNUstep.tiff for my dock icon. It's too large at 64x64. Would it be possible to provide these icons in addition to, instead of in place of, the original files? Doug
