Re: A couple of composite fixes from Owen Taylor
On Fri, 2008-09-19 at 13:44 -0400, Owen Taylor wrote: Thanks for checking things out; I will go ahead and push them now. > I guess I might quibble with the comment in the second one which makes > it sounds like this has to do with exotic guffaw scrolling manipulations > or something. Older window systems would often just discard all window contents on resize. Adding well-defined bit and window gravity to X11 made it able to preserve window contents across resize in a predictable manner, and the whole adventure in SlideAndSizeWindow was designed to 'fix' what was once a fairly broken implementation of that. The recomputation of exposures is a fairly blunt instrument to apply in this case, but it was the easiest mechanism I could come up with at the time. -- [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: A couple of composite fixes from Owen Taylor
On Fri, 2008-09-19 at 22:30 +0200, Maarten Maathuis wrote: > On Fri, Sep 19, 2008 at 7:44 PM, Owen Taylor <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-09-19 at 09:06 -0700, Keith Packard wrote: > >> On Fri, 2008-09-19 at 17:11 +0200, Maarten Maathuis wrote: > >> > >> > Is there a reason why you didn't commit these patches? > >> > >> Owen hasn't tested the second patch yet. Also, it's nice to see if > >> anyone has comments on the patch before they hit master. > > > > I've tested both patches and they work well as far as I can tell. > > > > (Of course, proving that they don't cause obscure problems elsewhere is > > a lot harder than proving that they fix the problems they were designed > > to fix.) > > > > Also, they make sense to me as patches. > > > > I guess I might quibble with the comment in the second one which makes > > it sounds like this has to do with exotic guffaw scrolling manipulations > > or something. > > > > /* No matter what happened to the parent window bits because of window > > * and bit gravity, the bits of redirected children are not affected > > * so no exposures are needed > > */ > > > > ? > > > > - Owen > > > > > > > > If keithp wrote that comment, than perhaps he could improve the > comment, because it's not very obvious to me what window gravity does. Although I didn't make it clear ... the above is a suggestion for an improvement, the original comment is: /* * Redirected windows are not affected by parent window * gravity manipulations */ - Owen ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: A couple of composite fixes from Owen Taylor
On Fri, Sep 19, 2008 at 7:44 PM, Owen Taylor <[EMAIL PROTECTED]> wrote: > On Fri, 2008-09-19 at 09:06 -0700, Keith Packard wrote: >> On Fri, 2008-09-19 at 17:11 +0200, Maarten Maathuis wrote: >> >> > Is there a reason why you didn't commit these patches? >> >> Owen hasn't tested the second patch yet. Also, it's nice to see if >> anyone has comments on the patch before they hit master. > > I've tested both patches and they work well as far as I can tell. > > (Of course, proving that they don't cause obscure problems elsewhere is > a lot harder than proving that they fix the problems they were designed > to fix.) > > Also, they make sense to me as patches. > > I guess I might quibble with the comment in the second one which makes > it sounds like this has to do with exotic guffaw scrolling manipulations > or something. > > /* No matter what happened to the parent window bits because of window > * and bit gravity, the bits of redirected children are not affected > * so no exposures are needed > */ > > ? > > - Owen > > > If keithp wrote that comment, than perhaps he could improve the comment, because it's not very obvious to me what window gravity does. ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: A couple of composite fixes from Owen Taylor
On Fri, 2008-09-19 at 09:06 -0700, Keith Packard wrote: > On Fri, 2008-09-19 at 17:11 +0200, Maarten Maathuis wrote: > > > Is there a reason why you didn't commit these patches? > > Owen hasn't tested the second patch yet. Also, it's nice to see if > anyone has comments on the patch before they hit master. I've tested both patches and they work well as far as I can tell. (Of course, proving that they don't cause obscure problems elsewhere is a lot harder than proving that they fix the problems they were designed to fix.) Also, they make sense to me as patches. I guess I might quibble with the comment in the second one which makes it sounds like this has to do with exotic guffaw scrolling manipulations or something. /* No matter what happened to the parent window bits because of window * and bit gravity, the bits of redirected children are not affected * so no exposures are needed */ ? - Owen ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: A couple of composite fixes from Owen Taylor
On Fri, 2008-09-19 at 17:11 +0200, Maarten Maathuis wrote: > Is there a reason why you didn't commit these patches? Owen hasn't tested the second patch yet. Also, it's nice to see if anyone has comments on the patch before they hit master. -- [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: A couple of composite fixes from Owen Taylor
On Thu, Sep 18, 2008 at 9:22 PM, Keith Packard <[EMAIL PROTECTED]> wrote: > Owen Taylor has been poking at Composite for a while now and has helped > uncover a couple of interesting corner cases. Here are two patches, the > first is a correctness patch which fixes parent clip recomputation when > windows move from automatic to manual redirection. The second is an > optimization to eliminate descendent exposures on parent resize. > > -- > [EMAIL PROTECTED] > > ___ > xorg mailing list > xorg@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/xorg > Is there a reason why you didn't commit these patches? ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
A couple of composite fixes from Owen Taylor
Owen Taylor has been poking at Composite for a while now and has helped uncover a couple of interesting corner cases. Here are two patches, the first is a correctness patch which fixes parent clip recomputation when windows move from automatic to manual redirection. The second is an optimization to eliminate descendent exposures on parent resize. -- [EMAIL PROTECTED] 0001-Switching-from-Automatic-to-Manual-redirect-needs-to.patch Description: application/mbox 0002-When-resizing-a-window-with-redirected-descendents.patch Description: application/mbox signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
