Re: [Yxa-devel] Use built in autoconf macro
On Fri, 2010-09-24 at 14:16 -0400, Vance Shipley wrote: > On Fri, Sep 24, 2010 at 08:02:34PM +0200, Mikael Magnusson wrote: ... > } I don't see the problem with using a user macro. > > Because you don't have to and by doing so you stopped me dead in my > tracks at step one! The `bootstrap' script isn't even mentioned in > the README. There is no reason why `aclocal; autoconf' shouldn't > just work as expected. > Then we need to update README, and we might want to rename "bootstrap" to "autogen(.sh)" or similar to avoid any confusion with yxa-bootstrap at the same time. /Mikael ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] Use built in autoconf macro
On Fri, Sep 24, 2010 at 08:02:34PM +0200, Mikael Magnusson wrote: } On Fri, 2010-09-24 at 13:40 -0400, Vance Shipley wrote: } > On Fri, Sep 24, 2010 at 01:33:42PM +0200, Mikael Magnusson wrote: } > } You have only moved the call to AC_ERLANG_CHECK_LIB away from the user } > } m4 macro into configure.ac. } > } > Yes, but now it works as it should: aclocal; autoconf; ./configure } > } > I now notice there is a `bootstrap' script to do the above with } > an option to aclocal to include the user macros in the m4 directory. } > It's unnecessary. } > } } I don't see the problem with using a user macro. Because you don't have to and by doing so you stopped me dead in my tracks at step one! The `bootstrap' script isn't even mentioned in the README. There is no reason why `aclocal; autoconf' shouldn't just work as expected. } Btw, you should read } http://github.com/fredrikt/yxa/wiki/Submitting-patches . Thanks, indeed I should! I'm just getting my feet wet with git/github. -- -Vance ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] Use built in autoconf macro
On Fri, 2010-09-24 at 13:40 -0400, Vance Shipley wrote: > On Fri, Sep 24, 2010 at 01:33:42PM +0200, Mikael Magnusson wrote: > } You have only moved the call to AC_ERLANG_CHECK_LIB away from the user > } m4 macro into configure.ac. > > Yes, but now it works as it should: aclocal; autoconf; ./configure > > I now notice there is a `bootstrap' script to do the above with > an option to aclocal to include the user macros in the m4 directory. > It's unnecessary. > I don't see the problem with using a user macro. > } You also removed ERLANG_LIB_VER_SUBST, which > } you fixed for all but one release file in another commit. > > Aha! I missed that. Here you go: > > http://github.com/vances/yxa/commit/20d92dc5f5461fd9746ab3e92e94656662c79af5 > Actually I was thinking of the eventserver. But I haven't tried your master, maybe it works. http://github.com/vances/yxa/blob/master/src/event/Makefile.in#L40 > } I'm planning to change the way yaws is autodetected. We need to use > } pkg-config since yaws' directory is not search by default. (Except in > } some Debian/Ubuntu versions where yaws is installed in > } the /usr/lib/erlang tree.) > > That won't work for me as I use OTP release packages. The existing > way (autoconf) shouldn't interfere with whatever you're doing. It > just won't apply to the release files (i.e. don't use ERLANG_LIB_???_yaws). > I won't require yaws.pc then, but use it if it's available. Btw, you should read http://github.com/fredrikt/yxa/wiki/Submitting-patches . /Mikael ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] Use built in autoconf macro
On Fri, Sep 24, 2010 at 01:33:42PM +0200, Mikael Magnusson wrote: } You have only moved the call to AC_ERLANG_CHECK_LIB away from the user } m4 macro into configure.ac. Yes, but now it works as it should: aclocal; autoconf; ./configure I now notice there is a `bootstrap' script to do the above with an option to aclocal to include the user macros in the m4 directory. It's unnecessary. } You also removed ERLANG_LIB_VER_SUBST, which } you fixed for all but one release file in another commit. Aha! I missed that. Here you go: http://github.com/vances/yxa/commit/20d92dc5f5461fd9746ab3e92e94656662c79af5 } I'm planning to change the way yaws is autodetected. We need to use } pkg-config since yaws' directory is not search by default. (Except in } some Debian/Ubuntu versions where yaws is installed in } the /usr/lib/erlang tree.) That won't work for me as I use OTP release packages. The existing way (autoconf) shouldn't interfere with whatever you're doing. It just won't apply to the release files (i.e. don't use ERLANG_LIB_???_yaws). -- -Vance ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] Use built in autoconf macro
On Thu, 2010-09-23 at 21:39 -0400, Vance Shipley wrote: > This commit moves away from a user m4 macro to the internal Erlang support > in autoconf v2.64: > > > http://github.com/vances/yxa/commit/73b1c8802aa9008cdf5a6365546490c42f3112ce > You have only moved the call to AC_ERLANG_CHECK_LIB away from the user m4 macro into configure.ac. You also removed ERLANG_LIB_VER_SUBST, which you fixed for all but one release file in another commit. > This commit (should have been done above) makes yaws optional: > > > http://github.com/vances/yxa/commit/d923a9423a03620b3522d88bf4fd743122dfd9ca > > I'm planning to change the way yaws is autodetected. We need to use pkg-config since yaws' directory is not search by default. (Except in some Debian/Ubuntu versions where yaws is installed in the /usr/lib/erlang tree.) /Mikael ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
[Yxa-devel] Use built in autoconf macro
This commit moves away from a user m4 macro to the internal Erlang support in autoconf v2.64: http://github.com/vances/yxa/commit/73b1c8802aa9008cdf5a6365546490c42f3112ce This commit (should have been done above) makes yaws optional: http://github.com/vances/yxa/commit/d923a9423a03620b3522d88bf4fd743122dfd9ca -- -Vance ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
