Re: [OpenJDK 2D-Dev] JDK 9: RFR: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-20 Thread Henry Jen
On 02/19/2014 02:59 PM, Henry Jen wrote: On 02/19/2014 01:46 PM, Phil Race wrote: W.r.t the following change ... http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java.sdiff.html 145 class Htable implements

Re: [OpenJDK 2D-Dev] JDK 9: RFR: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-20 Thread Andrew Brygin
Hello Henry, please see my comments regrading the fallthrough warnings inline. On 2/20/2014 12:05 PM, Henry Jen wrote: On 02/19/2014 02:59 PM, Henry Jen wrote: On 02/19/2014 01:46 PM, Phil Race wrote: W.r.t the following change ...

[OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-20 Thread Henry Jen
Hi, Please review the latest update, I think this should address the issues raised, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/ - revert the clone method changes so that return type remains Object - break long lines - fix fallthrough warnings as Andrew suggested. Cheers,

[OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-20 Thread Omair Majid
Hi, The following is a preliminary webrev that allows OpenJDK to build and run against a system-installed copy of lcms2 rather than the copy bundled with OpenJDK: root: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/00/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/00-jdk/

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-02-20 Thread Jim Graham
Yes, approved. ...jim On 2/17/14 6:09 AM, Anton V. Tarasov wrote: Jim, so this is ready for a push then. Thanks! Anton. On 15.02.2014 5:01, Jim Graham wrote: I don't need to see an update for that. I didn't read the entire webrev, but I looked at this one piece of code and

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8034998: Fix raw and unchecked lint warnings in javax.imageio

2014-02-20 Thread Henry Jen
Updated webrev at http://cr.openjdk.java.net/~henryjen/jdk9/8034998/1/webrev/ - change those two Iterator from public to private - rebase to jdk9/client Who will be pushing those changes once approved? Cheers, Henry On 02/19/2014 01:12 PM, Phil Race wrote: ImageIO.java 515 public

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8034998: Fix raw and unchecked lint warnings in javax.imageio

2014-02-20 Thread Phil Race
Re-checked only the changed part. Looks good. Do you have two reviewers yet? I can push this if you like but you have commit rights so you can push yourself if you so wish .. -phil. On 2/20/2014 3:33 PM, Henry Jen wrote: Updated webrev at

[OpenJDK 2D-Dev] JDK9: RFR: 8035487: Fix raw and unchecked lint warnings in javax.imageio.spi

2014-02-20 Thread Henry Jen
Hi, Please review the webrev to clean up raw and unchecked warnings in javax.imageio.spi packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8035487/0/webrev/ Cheers, Henry

Re: [OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-20 Thread Andrew Brygin
Hello Henry, the fix looks fine to me. Thanks, Andrew On 2/21/2014 1:01 AM, Henry Jen wrote: Hi, Please review the latest update, I think this should address the issues raised, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/ - revert the clone method changes so that return