Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

The fix looks fine. Note that this change implement the new SPI readers for ImageIO. But as far as I understand it does not add support of the tiff format to the Toolkit.createImage which use old decoders. I think it is necessary to delete support of old decoders and to replace it with spi?

Re: [OpenJDK 2D-Dev] RFR: 8143177: Integrate harfbuzz opentype layout engine per JEP 258

Looks fine. On 23.11.15 20:36, Vadim Pakhnushev wrote: +1 On 23/11/15 20:27, Philip Race wrote: Thanks Steven. Sergey & Vadim: I think I've addressed your concerns .. are we good to push ? -phil On 11/23/15, 8:21 AM, Steven Loomis wrote: 3 looks good On 11/22/2015 8:58 AM, Philip Race

Re: [OpenJDK 2D-Dev] RFR: 8143177: Integrate harfbuzz opentype layout engine per JEP 258

Thanks Steven. Sergey & Vadim: I think I've addressed your concerns .. are we good to push ? -phil On 11/23/15, 8:21 AM, Steven Loomis wrote: 3 looks good On 11/22/2015 8:58 AM, Philip Race wrote: On 11/22/15, 4:33 AM, Sergey Bylokhov wrote: On 18.11.15 18:09, Sergey Bylokhov wrote:

[OpenJDK 2D-Dev] Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

Hello All, Changed test image used in previous webrev. Because I need image with similar properties in another fix(JDK - 8041501) but content should be white. Changed image and its name in test file no other code changes. Updated Webrev:

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hello All, Please review following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.00/ Issue : Pink discoloration when we read JPEG images without JFIF & EXIF header and having no subsampling. Root

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Thanks for suggestion. I have made related changes and updated the Webrev. Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/ Please review. Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 4:43 PM To: Jayathirth D V;

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Removed repeated usage of getWidth() and getHeight(). Please review. http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 5:15 PM To: Jayathirth D V Cc: Philip Race; 2d-dev@openjdk.java.net Subject:

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Looks ok to me. Regards Prasanta On 11/23/2015 5:31 PM, Jayathirth D V wrote: Hi Prasanta, Removed repeated usage of getWidth() and getHeight(). Please review. http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ Thanks, Jay

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

On 11/23/2015 5:11 PM, Jayathirth D V wrote: Hi Prasanta, Thanks for suggestion. I have made related changes and updated the Webrev. Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/ Please review. There's no point getting

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Looks ok to me. But probably you could check for image width programmatically instead of hardcoding to 64 in testcode. Regards Prasanta On 11/23/2015 4:09 PM, Jayathirth D V wrote: Hello All, _Please review following fix in JDK9:_ __ Bug : https://bugs.openjdk.java.net/browse/JDK-8041501

Re: [OpenJDK 2D-Dev] RFR: 8076529: Marlin antialiasing renderer integration

Approved. -phil. On 11/23/2015 01:31 PM, Jim Graham wrote: An updated webrev to fix the automated tests. The only changes are to remove the package statements from the files in test/sun/java2d/marlin/*.java: http://cr.openjdk.java.net/~flar/JDK-8076529/webrev.01/ The benchmark results

Re: [OpenJDK 2D-Dev] RFR: 8076529: Marlin antialiasing renderer integration

I missed this in my last round of changes. It's not critical, though, so I'll file an issue to fix it up. We may also be tweaking how we control/advertise the RenderingEngine in the future so we can deal with it in that case... ...jim On 11/23/15 11:07 AM, Sergey

Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

OK. "Approved" in case there is any doubt on that. -phil. On 11/20/15, 7:35 AM, Brian Burkhalter wrote: On Nov 19, 2015, at 7:41 PM, Philip Race > wrote: The changes to pre-existing files look good although it is not apparent to me

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Rather than adding a comment block, it seems you need to edit the preceding one. * IJG assumes all unidentified 3-channels are YCbCr. 1715 * We assume that only if the second two channels are 1716 * subsampled (either horizontally or vertically). If not, 1717

Re: [OpenJDK 2D-Dev] RFR: 8076529: Marlin antialiasing renderer integration

Hi, Jim. It seems that the tests cannot be run via jtreg because of "package marlin" in it. Also as far as I know there is a possibility in the latest jtreg to filter out the system based on the ram, so is it possible to make CrashTest.java automated? RenderingEngine.java: GetPropertyAction

Re: [OpenJDK 2D-Dev] RFR: 8143177: Integrate harfbuzz opentype layout engine per JEP 258

3 looks good On 11/22/2015 8:58 AM, Philip Race wrote: On 11/22/15, 4:33 AM, Sergey Bylokhov wrote: On 18.11.15 18:09, Sergey Bylokhov wrote: Hi, Phil. Not an expert here, just a few notes: - Copyright is missing: hb-jdk-font.cc, hb-jdk.h hmm. how did I miss that ? Fixed. -

Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

So you should re-open 8041746 and close it as a dup of 6967419. I am approving 6967419 since it fixes an apparent problem. There may be additional problems but these are still theoretical .. -phil. On 11/17/2015 01:11 AM, Jayathirth D V wrote: Hi Phil, Thanks for pointing to JDK-8041746 .

Re: [OpenJDK 2D-Dev] Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

Approved. -phil. On 11/23/2015 01:39 AM, Jayathirth D V wrote: Hello All, Changed test image used in previous webrev. Because I need image with similar properties in another fix(JDK - 8041501) but content should be white. Changed image and its name in test file no other code changes.