Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

That looks good to me. Has the CCC cleared yet? ...jim On 6/3/16 2:49 AM, Jayathirth D V wrote: Hi Jim, Oh that's an important change. Thanks for your review. I have updated ColorModel constructor to copy nBIts only of numOfComponents length and I have removed validBits

Re: [OpenJDK 2D-Dev] Review request for: JDK-8158495 CCE: sun.java2d.NullSurfaceData cannot be cast to sun.java2d.opengl.OGLSurfaceData

Thanks. Looks fine. BTW, could you integrate this fix into jdk8 and jdk9 as well. I'll push it. Best Regards, Alexey On 02 Jun 2016, at 21:42, Sergey Bylokhov > wrote: Hi, Alexey. The code in OGLMaskFill.java is mirrored in

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

Ok. we can pass VK_ESCAPE instead of VK_ENTER and it works ok. Regards Prasanta On 6/3/2016 7:37 PM, prasanta sadhukhan wrote: No, we do not really need to print anything but we need to show the printdialog to reproduce the previous bug. But to avoid human interaction ,we need to close the

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

No, we do not really need to print anything but we need to show the printdialog to reproduce the previous bug. But to avoid human interaction ,we need to close the dialog so that jtreg should not fail in timeout. I am not sure how to select "Cancel" in the print dialog automatically but

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

Hi Phil, Sergey, I pushed the fix and submitted a new bug https://bugs.openjdk.java.net/browse/JDK-8158637 Regards, Alexey On 01.06.2016 20:25, Alexey Ivanov wrote: Hi Phil, Sergey, Thank you for reviewing! I suggest pushing the current version of the fix:

Re: [OpenJDK 2D-Dev] Review request for: JDK-8158495 CCE: sun.java2d.NullSurfaceData cannot be cast to sun.java2d.opengl.OGLSurfaceData

Hi Sergey, Thanks for the comments. Here is updated webrev: http://cr.openjdk.java.net/~avu/JDK-8158495/webrev.01 BTW, could you integrate this fix into jdk8 and jdk9 as well. Best Regards, Alexey > On 02 Jun 2016, at 21:42, Sergey

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

Do we really need try to print something or cancel(ESC) will be enough to reproduce the previous bug? On 03.06.16 14:46, prasanta sadhukhan wrote: Please review a test bug which was added for bug 7161283. Toolkit.getPrintJob() threw a NPE if no printer was available. Although the testcase was

[OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails on timeout

Hi All, Please review a test bug which was added for bug 7161283. Toolkit.getPrintJob() threw a NPE if no printer was available. Although the testcase was working ok in failure case by throwing NPE, in pass case it was waiting for manual intervention causing jtreg to fail on timeout. Made

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Hi Jim, Oh that's an important change. Thanks for your review. I have updated ColorModel constructor to copy nBIts only of numOfComponents length and I have removed validBits check in hashCode() of ICM. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/7107905/webrev.10/