Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Brian Burkhalter
OK unless there are objections from Sergey tomorrow I will plan to push it as-is. Thanks, Brian On Aug 23, 2016, at 5:12 PM, Philip Race wrote: > Still fine with me. > > -phil. > > On 8/23/16, 4:18 PM, Brian Burkhalter wrote: >> >> Hi Sergey, >> >> I have added some comments in both the s

Re: [OpenJDK 2D-Dev] [9] RFC JDK-8154058: [TIFF] ignoreMetadata parameter of TIFFImageReader's setInput() method affects TIFFImageReadParam in non-obvious way

2016-08-23 Thread Brian Burkhalter
Not entirely sure whether this addresses your concerns but I have an updated version of the test which seems to validate my intent with this: http://cr.openjdk.java.net/~bpb/8154058/webrev.00/ Part of the output of this test is: STDOUT: ignore = true: ImageWidth: 50 EXIF (false): false Fax (fal

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Philip Race
Still fine with me. -phil. On 8/23/16, 4:18 PM, Brian Burkhalter wrote: Hi Sergey, I have added some comments in both the source and the test: http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ Please indicate whether you think this is

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Brian Burkhalter
Hi Sergey, I have added some comments in both the source and the test: http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ Please indicate whether you think this is sufficient. The CCC request has been approved therefore pushing this code is pending only review approval. Thanks, Brian On Aug

Re: [OpenJDK 2D-Dev] RFR: JDK-8164628: update copyright header in java.awt.font.JavaAWTFontAccessImpl class

2016-08-23 Thread Philip Race
Approved -phil. On 8/23/16, 3:08 PM, Yuka Kamiya wrote: Hi, https://bugs.openjdk.java.net/browse/JDK-8164628 Please review the following fix in JDK9. A comma was missing in the fix for https://bugs.openjdk.java.net/browse/JDK-8163362. --- a/src/java.desktop/share/classes/java/awt/font/Jav

Re: [OpenJDK 2D-Dev] RFR: JDK-8164628: update copyright header in java.awt.font.JavaAWTFontAccessImpl class

2016-08-23 Thread Iris Clark
Hi, Yuka. This looks fine to me. Thanks, iris (not a Reviewer) -Original Message- From: Yuka Kamiya Sent: Tuesday, August 23, 2016 3:08 PM To: 2d-dev@openjdk.java.net Subject: [OpenJDK 2D-Dev] RFR: JDK-8164628: update copyright header in java.awt.font.JavaAWTFontAccessImpl class Hi,

[OpenJDK 2D-Dev] RFR: JDK-8164628: update copyright header in java.awt.font.JavaAWTFontAccessImpl class

2016-08-23 Thread Yuka Kamiya
Hi, https://bugs.openjdk.java.net/browse/JDK-8164628 Please review the following fix in JDK9. A comma was missing in the fix for https://bugs.openjdk.java.net/browse/JDK-8163362. --- a/src/java.desktop/share/classes/java/awt/font/JavaAWTFontAccessImpl.java +++ b/src/java.desktop/share/class

Re: [OpenJDK 2D-Dev] 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-08-23 Thread Jim Graham
I wonder why the @throws is not inherited...? Another way to fix this would be to implement it in the base Image class with the throw and all classes that can return a graphics override it. Then you wouldn't even need documentation in the AMRI class just to say "never mind we don't provide thi

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Sergey Bylokhov
On 23.08.16 21:41, Sergey Bylokhov wrote: Is it possible, just for the record, to provide a comment why NPE was changed to IAE. I meant the first check node==null. actually this code looks a little bit strange: 493 } catch (NullPointerException npe) { 494 throw new Illega

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Brian Burkhalter
I could do that but the most recent revision does not look like that. Thanks, Brian On Aug 23, 2016, at 11:41 AM, Sergey Bylokhov wrote: > Is it possible, just for the record, to provide a comment why NPE was changed > to IAE. actually this code looks a little bit strange: > 493 } ca

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Sergey Bylokhov
Is it possible, just for the record, to provide a comment why NPE was changed to IAE. actually this code looks a little bit strange: 493 } catch (NullPointerException npe) { 494 throw new IllegalArgumentException(npe); 495 } On 23.08.16 21:38, Brian Burkhalter wrot

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Brian Burkhalter
OK I have updated the test accordingly: http://cr.openjdk.java.net/~bpb/8149562/webrev.02/ 458 try { 459 TIFFField.createFromMetadataNode(ts, null); 460 } catch (IllegalArgumentException e) { 461 ok = true; 462 } Thanks, Brian On Aug 23, 2016,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Phil Race
Whilst there is no harm in the cause of the IAE being NPE, unless it is precisely called out in the spec - which it is not - all it says is "Note that a cause might be set on such an exception." which is non-specific, I don't think the test should check for it. -phil. On 8/23/2016 11:17 AM, Bri

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-23 Thread Brian Burkhalter
Here is a revision based on the CCC request discussion: http://cr.openjdk.java.net/~bpb/8149562/webrev.01/ It was necessary slightly to modify one test as well. Thanks, Brian On Aug 17, 2016, at 10:39 AM, Phil Race wrote: > +1 > > -phil. > > On 08/16/2016 09:02 AM, Brian Burkhalter wrote:

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

2016-08-23 Thread Phil Race
On 08/23/2016 08:47 AM, Erik Joelsson wrote: > Hello, > > I do agree that maintaining the list of disabled warnings will be > impossible unless we have a structured way of tracking for which > compiler versions we disable what. Ideally we should be able to easily > add conditions for when certain w

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

2016-08-23 Thread Erik Joelsson
Hello, I do agree that maintaining the list of disabled warnings will be impossible unless we have a structured way of tracking for which compiler versions we disable what. Ideally we should be able to easily add conditions for when certain warnings should be disabled. We are unfortunatel

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

2016-08-23 Thread Philip Race
Erik .. please chime in if you disagree with the following The goal here is to have no warnings with the *official* compilers. If you are using something else and get warnings then either fix the *source* or else you need to use --disable-warning-as-errors. Otherwise we'll be suppressing the warni

[OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

2016-08-23 Thread Yasumasa Suenaga
Hi all, I've fixed several warnings when we build OpenJDK with GCC 6 in JDK-8160294. However, I encountered shift-negative-value warnings at jdhuff.c on my Fedora 24 (GCC 6.1.1): -- /home/ysuenaga/OpenJDK/hs/jdk/src/java.desktop/share/native/libjavajpeg/jdhuff.c:458:13: warning: lef

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-23 Thread Vadim Pakhnushev
+1 Vadim On 21.08.2016 21:31, Philip Race wrote: Thanks Sergey .. I am still waiting for a 2nd +1 from someone else. -phil. On 8/12/16, 12:28 PM, Sergey Bylokhov wrote: Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On 8

[OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable

2016-08-23 Thread Prasanta Sadhukhan
Hi All, Please review a fix whereby it is seen that Page Ranges fields in the "cross-platform" dialog does not get populated based on what pageable's getNumberOfPages() returns. "To" field is always 1. However, for native dialog it shows the "To" field correctly based on what getNumberOfPages(

Re: [OpenJDK 2D-Dev] 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-08-23 Thread Alexander Scherbatiy
On 22/08/16 11:06, Avik Niyogi wrote: + awt-dev On 22-Aug-2016, at 12:28 pm, Avik Niyogi > wrote: Hi All, Kindly review the proposed specifications for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8138771* *Webrev: http://cr.openjdk.java.net/~aniyogi/