If Clemens can also look at it, that would be great, but if he does not
have time
right now, I would not like to hold it up, since its a tck-red for 11.
-phil.
On 7/27/18, 2:27 AM, Jayathirth D V wrote:
Hi Phil,
Thanks for fixing the regression introduced by
Actually, although the recommendation is not "as strong", it is still
recommended to use the EDT for initialising AWT apps.
You'll find the same in some other tests I think.
In any case it is just a harmless precaution.
-phil.
On 7/27/18, 3:11 AM, Prasanta Sadhukhan wrote:
Fix looks good to
Hello.
According to my investigation, FT_Render_Glyph() was not called
even if FT_GlyphSlot_Oblique() was called.
=
if (ftglyph->format == FT_GLYPH_FORMAT_OUTLINE) {
FT_Render_Glyph(ftglyph, FT_LOAD_TARGET_MODE(target)); <<===
}
=
It seemed FT_Load_Glyph() and
Fix looks good to me.
A nit in the test
61 SwingUtilities.invokeAndWait(() -> createAndShowGUI());
Since awt Frame is being created and not JFrame, there is no need of
using EDT.
Regards
Prasanta
On 7/27/2018 1:12 AM, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8204931
Hi Phil,
Thanks for fixing the regression introduced by
https://bugs.openjdk.java.net/browse/JDK-8176795 .
I went through the changes present in http://cr.openjdk.java.net/~prr/8204931/
and it looks fine.
I have added detail review summary in the bug itself.
We can also ask Clemens to take a
