Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Jayathirth D V
Hi, I was also looking into this test case under https://bugs.openjdk.java.net/browse/JDK-8224969 I will close it as duplicate of this bug. I saw that in case of Ubuntu and Mac we are throwing "java.awt.print.PrinterException: No print service found. " but I in case of Windows test just timeso

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Sergey Bylokhov
On 29/05/2019 18:06, Philip Race wrote: This test does not check. Nor does (IIRC) the implementation, [1] I guess it is checked in the RasterPrintJob.print() where the code call the getPrintService(). And getPrintService() returns null if there are no printers installed, as a result "new Prin

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Philip Race
On 5/29/19, 4:05 PM, Sergey Bylokhov wrote: On 29/05/2019 15:42, Phil Race wrote: For example windows some times pops up a dialog prompting you to install a printer. But in this case we should not even try to print something, since we checked at the beginning that there are no printers.

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Sergey Bylokhov
Looks fine. On 29/05/2019 12:30, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8225007 Webrev : http://cr.openjdk.java.net/~prr/8225007/ This is just adding the printer keyword to two jtreg tests. This is useful for both selecting & excluding the tests and should prevent one o

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Sergey Bylokhov
On 29/05/2019 15:42, Phil Race wrote: For example windows some times pops up a dialog prompting you to install a printer. But in this case we should not even try to print something, since we checked at the beginning that there are no printers. I decided to check by eyes what happens on the s

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Phil Race
For example windows some times pops up a dialog prompting you to install a printer. -Phil. > On May 29, 2019, at 3:40 PM, Phil Race wrote: > > If you try to print when there is no printer the behavior is not strictly > specified. > > -Phil. > >>> On May 29, 2019, at 3:25 PM, Sergey Bylokho

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Phil Race
If you try to print when there is no printer the behavior is not strictly specified. -Phil. > On May 29, 2019, at 3:25 PM, Sergey Bylokhov > wrote: > >> On 29/05/2019 15:16, Philip Race wrote: >> It doesn't hang there. It hangs in print(). > > I guess it is even more strange, it hangs when t

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Sergey Bylokhov
On 29/05/2019 15:16, Philip Race wrote: It doesn't hang there. It hangs in print(). I guess it is even more strange, it hangs when tries to print to non-existent printer. I guess in this case the "new PrinterException("No print service found.")" should be thrown. It looks like a bug, no? -

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Philip Race
It doesn't hang there. It hangs in print(). -phil. On 5/29/19, 3:17 PM, Sergey Bylokhov wrote: On 29/05/2019 14:09, Phil Race wrote: think the mystery is not why it times out now, but why it did not do so earlier. But I assume it if the system does not have the printer then PrinterJob.getPr

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Sergey Bylokhov
On 29/05/2019 14:09, Phil Race wrote: think the mystery is not why it times out now, but why it did not do so earlier. But I assume it if the system does not have the printer then PrinterJob.getPrinterJob() should not hang? It looks like the test correctly assume that .getPrinterJob() should r

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Phil Race
The reason is that there is no printer installed, so it hangs when printing starts, when windows tries to ask the non-existent user where to send the output but gets no response. jtreg then times out the test. So requiring a printer should fix that. I think the mystery is not why it times out no

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Sergey Bylokhov
Hi, Phil. Should not we create a new CR to evaluate this failure later? On 29/05/2019 12:30, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8225007 Webrev : http://cr.openjdk.java.net/~prr/8225007/ This is just adding the printer keyword to two jtreg tests. This is useful for

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

2019-05-29 Thread Sergey Bylokhov
Looks fine. On 27/05/2019 02:33, Prasanta Sadhukhan wrote: Hi All, AlphaColorTest is failing in mach5 linux headful nightly system consistently and it seems to be a product bug, so needs to be problemlisted. diff -r cb2628a4f33f test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Wed May

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Brian Burkhalter
+1 Brian > On May 29, 2019, at 12:30 PM, Phil Race wrote: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8225007 > > Webrev : http://cr.openjdk.java.net/~prr/8225007/ > > > This is just adding t

[OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-29 Thread Phil Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8225007 Webrev : http://cr.openjdk.java.net/~prr/8225007/ This is just adding the printer keyword to two jtreg tests. This is useful for both selecting & excluding the tests and should prevent one of these tests from hanging in our nightly headful te

Re: [OpenJDK 2D-Dev] JDK-8048782, which is designated for u222, fixes a bug, but it also introduces a new one.

2019-05-29 Thread Andrew John Hughes
On 29/05/2019 17:45, Andrew Haley wrote: > On 5/23/19 6:27 PM, Hohensee, Paul wrote: >> Our current 8u222 solution would be to revert the patch for >> https://bugs.openjdk.java.net/browse/JDK-8221166 (which is the 8u222 >> backport issue for https://bugs.openjdk.java.net/browse/JDK-8048782). >

Re: [OpenJDK 2D-Dev] JDK-8048782, which is designated for u222, fixes a bug, but it also introduces a new one.

2019-05-29 Thread Andrew Haley
On 5/23/19 6:27 PM, Hohensee, Paul wrote: > Our current 8u222 solution would be to revert the patch for > https://bugs.openjdk.java.net/browse/JDK-8221166 (which is the 8u222 backport > issue for https://bugs.openjdk.java.net/browse/JDK-8048782). Fine by me. Please open a bug and create a webrev