[OpenJDK 2D-Dev] Integrated: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

2021-03-31 Thread Alexander Scherbatiy
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outline coordinates

Re: [OpenJDK 2D-Dev] RFR: 8263984: Invalidate printServices when there are no printers

2021-03-31 Thread Jayathirth D V
On Tue, 23 Mar 2021 13:45:33 GMT, Alexey Ivanov wrote: > When `getAllPrinterNames()` returns null, the list of `printServices` is > assigned a new empty array without invalidating old services which were in > the array before. > > The old print services should be invalidated. src/java.desktop

Re: [OpenJDK 2D-Dev] RFR: 8263984: Invalidate printServices when there are no printers

2021-03-31 Thread Jayathirth D V
On Wed, 24 Mar 2021 20:44:26 GMT, Alexey Ivanov wrote: >> Since this is windows specific code, I am not sure if system will not have >> any printers. I guess by default, Microsoft XPS Document Writer, Microsoft >> Print-to-PDF, Fax are present in printers list. That is the reason we do not >>

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v3]

2021-03-31 Thread Ajit Ghaisas
On Thu, 1 Apr 2021 05:49:51 GMT, Jayathirth D V wrote: >> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state >> information because of which we ignore clip parameters set in rect clip and >> shape clip. We need to query and use encoders from EncoderManager to honour >

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v3]

2021-03-31 Thread Jayathirth D V
> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state > information because of which we ignore clip parameters set in rect clip and > shape clip. We need to query and use encoders from EncoderManager to honour > clip states in copyArea. Jayathirth D V has updated the pu

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v2]

2021-03-31 Thread Ajit Ghaisas
On Wed, 31 Mar 2021 15:03:54 GMT, Jayathirth D V wrote: >> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state >> information because of which we ignore clip parameters set in rect clip and >> shape clip. We need to query and use encoders from EncoderManager to honour

Re: [OpenJDK 2D-Dev] RFR: 8255800: Raster creation methods need some specification clean up

2021-03-31 Thread Sergey Bylokhov
On Fri, 26 Mar 2021 19:53:44 GMT, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line > spec clean up but > it didn't take a lot of looking to realize there were many more > inconsistencies between spec and implementation. > I've spent a lot of time on

[OpenJDK 2D-Dev] Integrated: 8012229: [lcms] Improve performance of color conversion for images with alpha channel

2021-03-31 Thread Sergey Bylokhov
On Mon, 29 Mar 2021 07:36:35 GMT, Sergey Bylokhov wrote: > The lcms 2.8 version added support for the cmsFLAGS_COPY_ALPHA flag: > https://sourceforge.net/p/lcms/mailman/lcms-user/thread/001c01d1c0f3%2484a7cb30%248df76190%24%40ProDigitalSoftware.com/#msg35143398 > > which supports alpha channel t

Re: [OpenJDK 2D-Dev] RFR: 8255800: Raster creation methods need some specification clean up

2021-03-31 Thread Phil Race
On Wed, 31 Mar 2021 21:21:24 GMT, Sergey Bylokhov wrote: >> https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line >> spec clean up but >> it didn't take a lot of looking to realize there were many more >> inconsistencies between spec and implementation. >> I've spent a lot

Re: [OpenJDK 2D-Dev] RFR: 8255800: Raster creation methods need some specification clean up

2021-03-31 Thread Phil Race
On Wed, 31 Mar 2021 21:17:07 GMT, Sergey Bylokhov wrote: >> Meaning even though you like the NPE you would change it to IAE like the >> rest ? > > Yes and no, I just wanted to highlight this place, since somebody may prefer > IAE here. Well IAE was my initial thought but I decided to minimize

Re: [OpenJDK 2D-Dev] RFR: 8012229: [lcms] Improve performance of color conversion for images with alpha channel [v2]

2021-03-31 Thread Alexander Zvegintsev
On Wed, 31 Mar 2021 21:31:43 GMT, Sergey Bylokhov wrote: >> The lcms 2.8 version added support for the cmsFLAGS_COPY_ALPHA flag: >> https://sourceforge.net/p/lcms/mailman/lcms-user/thread/001c01d1c0f3%2484a7cb30%248df76190%24%40ProDigitalSoftware.com/#msg35143398 >> >> which supports alpha chann

Re: [OpenJDK 2D-Dev] RFR: 8012229: [lcms] Improve performance of color conversion for images with alpha channel [v2]

2021-03-31 Thread Sergey Bylokhov
> The lcms 2.8 version added support for the cmsFLAGS_COPY_ALPHA flag: > https://sourceforge.net/p/lcms/mailman/lcms-user/thread/001c01d1c0f3%2484a7cb30%248df76190%24%40ProDigitalSoftware.com/#msg35143398 > > which supports alpha channel transportation > > For our usage, it means we can use TYPE_

Re: [OpenJDK 2D-Dev] RFR: 8255800: Raster creation methods need some specification clean up

2021-03-31 Thread Sergey Bylokhov
On Fri, 26 Mar 2021 19:53:44 GMT, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line > spec clean up but > it didn't take a lot of looking to realize there were many more > inconsistencies between spec and implementation. > I've spent a lot of time on

Re: [OpenJDK 2D-Dev] RFR: 8255800: Raster creation methods need some specification clean up

2021-03-31 Thread Sergey Bylokhov
On Fri, 26 Mar 2021 22:45:56 GMT, Phil Race wrote: >> src/java.desktop/share/classes/java/awt/image/ComponentSampleModel.java line >> 127: >> >>> 125: * @throws IllegalArgumentException if {@code pixelStride} is less >>> than 0 >>> 126: * @throws IllegalArgumentException if {@code sc

Re: [OpenJDK 2D-Dev] RFR: 8264428: Replace uses of StringBuffer with StringBuilder in java.desktop

2021-03-31 Thread Sergey Bylokhov
On Tue, 30 Mar 2021 12:39:15 GMT, Aleksey Shipilev wrote: >> Found by IntelliJ IDEA inspection `Java | Java language level migration aids >> | Java 5 | 'StringBuffer' may be 'StringBuilder'` >> As suggested in >> https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created >> s

Re: [OpenJDK 2D-Dev] RFR: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt

2021-03-31 Thread Sergey Bylokhov
On Tue, 23 Mar 2021 15:18:13 GMT, Severin Gehwolf wrote: > The suggestion is to rename 'jvm' variable in `libjavajpeg` to `the_jvm` so > this conflict no longer occurs when `libjavajpeg.a` and `libawt.a` are being > linked into one native image. > > Testing: test/jdk/javax/imageio jtreg tests.

Re: [OpenJDK 2D-Dev] RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

2021-03-31 Thread Sergey Bylokhov
On Thu, 18 Mar 2021 12:29:01 GMT, Alexander Scherbatiy wrote: >> Printing text using GlyphVector outline has bad quality on printers with low >> DPI on Windows. >> The GDI system used for text printing on Windows accepts only integer path >> coordinates. >> Rounding GlyphVector outline coordin

[OpenJDK 2D-Dev] Withdrawn: 8263893: getPrinterNames() leaks nameArray if Java String allocation fails

2021-03-31 Thread Alexey Ivanov
On Fri, 19 Mar 2021 20:36:57 GMT, Alexey Ivanov wrote: > If `JNU_NewStringPlatform` fails to allocate new Java String object for > printer name, `std::bad_alloc` is thrown. The handler for the exception does > not release the local reference to the `nameArray`, thus it will be leaked. This pul

Re: [OpenJDK 2D-Dev] RFR: 8012229: [lcms] Improve performance of color conversion for images with alpha channel

2021-03-31 Thread Alexander Zvegintsev
On Mon, 29 Mar 2021 07:36:35 GMT, Sergey Bylokhov wrote: > The lcms 2.8 version added support for the cmsFLAGS_COPY_ALPHA flag: > https://sourceforge.net/p/lcms/mailman/lcms-user/thread/001c01d1c0f3%2484a7cb30%248df76190%24%40ProDigitalSoftware.com/#msg35143398 > > which supports alpha channel t

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline

2021-03-31 Thread Jayathirth D V
On Wed, 31 Mar 2021 12:39:49 GMT, Ajit Ghaisas wrote: > I tested this fix. No regressions were observed. > > Using MTLBlitCommandEncoder is intuitive when metal resource copying needs to > be done. > I suggest to add a comment (may be as a method description or in code where > we do the actual

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v2]

2021-03-31 Thread Jayathirth D V
> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state > information because of which we ignore clip parameters set in rect clip and > shape clip. We need to query and use encoders from EncoderManager to honour > clip states in copyArea. Jayathirth D V has updated the pu

Re: [OpenJDK 2D-Dev] libfontmanager.so: undefined symbol: hb_font_destroy in openjdk17~14

2021-03-31 Thread Philip Race
On 3/30/21 11:31 PM, mc36 wrote: please find below, but, again, it's jre17~15, where everything seems fine. Oh that's what you mean by the incomprehensible " please dont! i got ~15 and the issue is gone!" So it was some one-off problem with the build 14 from your distro. I think this poin

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline

2021-03-31 Thread Ajit Ghaisas
On Wed, 31 Mar 2021 07:27:45 GMT, Jayathirth D V wrote: > In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state > information because of which we ignore clip parameters set in rect clip and > shape clip. We need to query and use encoders from EncoderManager to honour > c

[OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline

2021-03-31 Thread Jayathirth D V
In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state information because of which we ignore clip parameters set in rect clip and shape clip. We need to query and use encoders from EncoderManager to honour clip states in copyArea. - Commit messages: - 826447

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline

2021-03-31 Thread Jayathirth D V
On Wed, 31 Mar 2021 07:27:45 GMT, Jayathirth D V wrote: > In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state > information because of which we ignore clip parameters set in rect clip and > shape clip. We need to query and use encoders from EncoderManager to honour > c