Looks good to me.
Cheers,
Henry
On 07/03/2014 03:28 PM, Joe Darcy wrote:
A nice small fix, ready to review...
Thanks,
-Joe
On 07/01/2014 05:35 PM, Joe Darcy wrote:
Hello,
Please review this small change to address a few remaining unchecked
and raw types warnings in platform-specific
Thanks Joe and Phil for reviewing.
Cheers,
Henry
On 06/10/2014 08:45 PM, Phil Race wrote:
Ditto
-phil.
On 6/5/14 7:34 PM, Joe Darcy wrote:
Hi Henry,
From a quick look, the changes seem fine.
Thanks,
-Joe
On 06/05/2014 04:51 PM, Henry Jen wrote:
Hi,
Please review a follow-up to clean
not obvious are simply remove tailing space, a (positive)
side effect of the tools I use so I kept them.
Cheers,
Henry
[1]
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-June/027113.html
On 06/03/2014 06:22 PM, Henry Jen wrote:
Hi,
In an effort to determine APIs availability in a given
On 05/15/2014 12:07 PM, Joe Darcy wrote:
Hello,
Please review these change to fix
JDK-8042864 : Fix raw and unchecked warnings in javax.print
http://cr.openjdk.java.net/~darcy/8042864.0/
Patch below.
Looks good to me, just nit-picking.
---
,
double cx1, double cy1,
Cheers,
Henry
...jim
On 4/7/14 1:46 PM, Henry Jen wrote:
Hi,
Please review the webrev cleans up raw and unchecked warnings in sun.awt,
http://cr.openjdk.java.net/~henryjen/jdk9/8039342/0/webrev/
The following changes
Ping.
The webrev is updated(rebase) to latest jdk9/client repo,
http://cr.openjdk.java.net/~henryjen/jdk9/8039342/1/webrev/
I also run Java2Demo with the result build and it seems fine.
Cheers,
Henry
On 04/09/2014 03:31 PM, Henry Jen wrote:
On 04/09/2014 02:35 PM, Phil Race wrote
On 04/09/2014 02:35 PM, Phil Race wrote:
Yes it looks to be about 70% AWT and about 30% 2d ..
Remember there's a magic decoder ring at
http://openjdk.java.net/groups/2d/2dawtfiles.html
It may not have 100% coverage but it should help.
I looked over the 2D ones as below ..
Hi,
Please review the webrev cleans up raw and unchecked warnings in sun.awt,
http://cr.openjdk.java.net/~henryjen/jdk9/8039342/0/webrev/
The following changes in AreaOp::pruneEdges() is particular worth
attention, when numedges 2, two different type are mixed up in the
past with use of
*/
so there does seem to be some internal inconsistency in what the Vector
is meant to hold.
In any case, your changes look good to me. (I'll adapt my changes for
8039109 based on your changes in this bug.)
Cheers,
-Joe
On 04/07/2014 01:46 PM, Henry Jen wrote:
Hi,
Please review the webrev
there does seem to be some internal inconsistency in what the Vector
is meant to hold.
In any case, your changes look good to me. (I'll adapt my changes for
8039109 based on your changes in this bug.)
Cheers,
-Joe
On 04/07/2014 01:46 PM, Henry Jen wrote:
Hi,
Please review the webrev cleans up
Hi,
Please review the webrev to clean up raw and unchecked warnings in
sun.java2d packag at,
http://cr.openjdk.java.net/~henryjen/jdk9/8038644/0/webrev/
Cheers,
Henry
);
+}
model.put(SunHints.KEY_RENDERING,
SunHints.Value.get(SunHints.INTKEY_RENDERING,
renderHint));
Cheers,
Henry
On 03/28/2014 10:01 AM, Henry Jen wrote:
Hi,
Please review the webrev to clean up raw and unchecked warnings
On 02/19/2014 02:59 PM, Henry Jen wrote:
On 02/19/2014 01:46 PM, Phil Race wrote:
W.r.t the following change ...
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java.sdiff.html
145 class Htable implements
,
Henry
On 02/20/2014 10:09 AM, Phil Race wrote:
On 2/20/2014 12:05 AM, Henry Jen wrote:
On 02/19/2014 02:59 PM, Henry Jen wrote:
On 02/19/2014 01:46 PM, Phil Race wrote:
W.r.t the following change ...
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio
if you can
1) make the two changes
2) re-generate against the client forest
then it should be ready for approval.
-phil.
On 2/14/2014 6:43 PM, Henry Jen wrote:
Hi,
Please review the webrev to clean up raw and unchecked warnings in
javax.imageio packag at,
http://cr.openjdk.java.net/~henryjen/jdk9
Hi,
Please review the webrev to clean up raw and unchecked warnings in
javax.imageio.spi packag at,
http://cr.openjdk.java.net/~henryjen/jdk9/8035487/0/webrev/
Cheers,
Henry
On 02/19/2014 01:46 PM, Phil Race wrote:
.
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java.sdiff.html
230 public IteratorImageTypeSpecifier getImageTypes(int
imageIndex) throws IIOException {
Nitpicky perhaps,
On 02/15/2014 01:15 PM, Joe Darcy wrote:
On 02/14/2014 06:43 PM, Henry Jen wrote:
Hi,
Please review the webrev to clean up raw and unchecked warnings in
javax.imageio packag at,
http://cr.openjdk.java.net/~henryjen/jdk9/8034998/0/webrev/
The webrev does not cover javax.imageio.spi
, Joe Darcy wrote:
Hi Henry,
On 02/05/2014 12:19 PM, Henry Jen wrote:
Hi,
Please review the webrev to clean up raw and unchecked warnings in
com.sun.imageio packag at,
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/0/webrev/
The more significant change in this webrev is that I have changed
On 02/07/2014 03:00 PM, Phil Race wrote:
BMPMetadata.java
94 // Fields from CommentExtension
95 // List of byte[]
96 public Listbyte[] comments = null; // new ArrayList();
hmm .. how did you decide this was correct, other than trusting the
comment?
For this one, I took it
20 matches
Mail list logo
