Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

2010-02-01 Thread Dmitri Trembovetski
Roman Kennke wrote: Looks ok to me except the copyright on the test should probably be 2010 now =) Arg! I knew it! http://cr.openjdk.java.net/~rkennke/6888734/webrev.04/ Now don't tell me I have to put 'Oracle' in there! ;-) Ship it before we had to go through that exercise.. =) Dmit

Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

2010-02-01 Thread Dmitri Trembovetski
Looks ok to me except the copyright on the test should probably be 2010 now =) Dmitri Roman Kennke wrote: Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: As Dmitri mentioned you need to move policy file too. Otherwise test will not work in new location when run with jt

Re: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

2009-12-07 Thread Dmitri Trembovetski
Hi Roman, I think you also need to move the 'policy' file from the closed dir along with the test. Thanks, Dmitri Roman Kennke wrote: Hi Phil, Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: Roman Kennke wrote: I added the (previously closed) testcase, keeping it in

Re: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite

2009-11-05 Thread Dmitri Trembovetski
> PS: Is there an easy way to apply a webrev to a local repository? The webrev/ dir contains a patch, you could do patch -p1 -i webrev/stuff.patch Thanks, Dmitri Clemens Eisserer wrote: Hello, I've merged the xrender pipeline with master, please take a look at the webrev: http:

Re: [OpenJDK 2D-Dev] Review request for bug 100053

2009-10-01 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: Hi Dmitri, a comment about the test: would the bug reproduce if you just rendered into a BufferedImage? If so, no need for creating a frame and such. Oh yes. Stupid me :-) Regarding the fix, it looks ok - but there are other places in the code where t

Re: [OpenJDK 2D-Dev] Review request for bug 100053

2009-10-01 Thread Dmitri Trembovetski
Hi Roman, a comment about the test: would the bug reproduce if you just rendered into a BufferedImage? If so, no need for creating a frame and such. Regarding the fix, it looks ok - but there are other places in the code where the 'crossings' is accessed - are those safe from an NPE?

Re: [OpenJDK 2D-Dev] Request to backport fix for 6708392 to openjdk6

2009-09-10 Thread Dmitri Trembovetski
Hi Martin, I think this is an AWT bug/fix, may be it would be more appropriate to ask on awt dev list? Thanks, Dmitri Martin Buchholz wrote: Hi SunToolkit.setOverrideRedirect team, Google engineers have found that 6708392: Provide internal API to create OverrideRedirect windows,

Re: [OpenJDK 2D-Dev] Question regarding GraphicsConfiguration/DisplayMode

2009-03-31 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: This doesn't explain some methods that crept up into this class (like getBounds and getNormalizingTransform). They should have been on GraphicsDevice. Why? Isn't getBounds() used to indicate which part of the whole virtual screen (Xinerama) a GC is represent

Re: [OpenJDK 2D-Dev] Question regarding GraphicsConfiguration/DisplayMode

2009-03-31 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: I think my mental model regarding the GD/GC/DisplayMode API is a bit messed up, or the API is a bit messed up. It's the API that's a bit messed up. Basically, GD represents a real graphics device - like a video board on windows, and screen on X11 (w/o xin

Re: [OpenJDK 2D-Dev] Potential problem in X11GraphicsDevice

2009-03-25 Thread Dmitri Trembovetski
Hi Roman, this issue was filed. While it's not very serious, and could at most be used to do a dos attack on one VM - but there's plenty of other ways to do that (like creating thousands of threads), it should still be addressed. Java security model won't allow the client code to be ru

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6791612: OGLBat tests are failed in jdk 7 b42

2009-02-26 Thread dmitri . trembovetski
Changeset: 0c856354b669 Author:tdv Date: 2009-02-26 13:38 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0c856354b669 6791612: OGLBat tests are failed in jdk 7 b42 Reviewed-by: tdv Contributed-by: ceisserer ! make/sun/xawt/mapfile-vers

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Dmitri Trembovetski
Hiroshi Yamauchi wrote: Aha. Can someone point me to the Mercurial changeset URL of the patch? I'd like to use the existing patch. As per earlier Phil's email which pointed to this post: http://mail.openjdk.java.net/pipermail/2d-dev/2009-January/000651.html the revision is http://

Re: [OpenJDK 2D-Dev] [PATCH] 4494651: Wrong width and height in BufferedImage GraphicsConfiguration objects

2009-02-17 Thread Dmitri Trembovetski
Note that this fix may have some performance implications for cases when there are caches based on the graphics configuration of the Graphics object used for rendering - these caches may grow uncontrollably. I don't know of any other solution for this bug, but I'm not sure fixing it

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

2009-01-22 Thread Dmitri Trembovetski
Anthony Petrov wrote: Hi Dmitri, On 01/21/2009 10:23 PM Anthony Petrov wrote: Yeah, I see the point. Another option is to make the field private, create a final package-private getter (though why? we have a lovely public one already), and private setter. The setter would be invoked through

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

2009-01-21 Thread Dmitri Trembovetski
Hi Anthony, Anthony Petrov wrote: Hi Dmitri, On 1/21/2009 8:43 PM Dmitri Trembovetski wrote: implementation of this method in the Container class that recursively calls this method for every child of the container. The question is: is it really possible for one toplevel to contain

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

2009-01-21 Thread Dmitri Trembovetski
Anthony Petrov wrote: Hello 2D and AWT teams, While working on the fix for 6783411 to enable re-parenting heavyweight components between toplevel windows, I found the Component.checkGD() method which verifies equality of GraphicsDevice's (by the way, a minor question: is it correct to check

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

2009-01-21 Thread Dmitri Trembovetski
Anthony Petrov wrote: Hi Roman, On 01/21/2009 06:17 PM Roman Kennke wrote: The question is: is it really possible for one toplevel to contain components having different GraphicsDevice's (and/or different GraphicsConfiguration's)? Not sure, but in Xinerama-mode, when half of a window is on

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread Dmitri Trembovetski
David Gilbert wrote: Clemens Eisserer wrote: It hasn't. The default mode is not outline AFAIK. So if you enabled outline, it's all your fault! I disagree here, Swing does provide the outline mode as a public API, it worked great in the past and now its broken. Its not deprecated, not e

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread Dmitri Trembovetski
Clemens Eisserer wrote: It hasn't. The default mode is not outline AFAIK. So if you enabled outline, it's all your fault! I disagree here, Swing does provide the outline mode as a public API, it worked great in the past and now its broken. In case it wasn't clear, I was joking. Dmitri

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-14 Thread Dmitri Trembovetski
Clemens Eisserer wrote: Hi Dmitri, We tried really hard to remove these kinds of kludges from the new code though. It would be a shame to introduce them back in. Yes, I understand that. I guess it also would cause a flood of bug-reports from confused developers ;) If only millions of de

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-11 Thread Dmitri Trembovetski
Hi Clemens, Clemens Eisserer wrote: Hi, About a year ago I reported a bug about slow XOR rendering when the D3D pipeline is enabled, I saw major performance problems with one of our applications, it even affects Swing performance when OUTLINE_DRAG is specified. Its now even in the top-25 bug

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6772137: D3D: Dragging the scroll bar of a JScrollPane containing a JTree causes incorrect red

2008-12-08 Thread dmitri . trembovetski
Changeset: b163d898f83f Author:tdv Date: 2008-12-08 17:04 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b163d898f83f 6772137: D3D: Dragging the scroll bar of a JScrollPane containing a JTree causes incorrect red Reviewed-by: campbell ! src/windows/native/sun/java2d/d3d/D3D

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6708580: Java applications slow when EXA enabled

2008-12-04 Thread dmitri . trembovetski
Changeset: 15435c60c751 Author:tdv Date: 2008-12-04 11:21 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/15435c60c751 6708580: Java applications slow when EXA enabled Reviewed-by: prr, tdv Contributed-by: ceisserer <[EMAIL PROTECTED]> ! make/sun/awt/mapfile-mawt-vers ! make/

Re: [OpenJDK 2D-Dev] Disabling offscreen pixmaps by default?

2008-11-26 Thread Dmitri Trembovetski
Hi Clemens, Clemens Eisserer wrote: Hi, Would it be possible to disable offscreen pixmaps by default when running the X11 pipeline and when the xserver is running locally and does not support SHMPIxmaps? Yes, we may have to do that. It can be done under this bug id: 6708580: Java

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6757527: D3D: serious rendering issues on Nvidia boards with driver version 178.13 on Vista

2008-11-18 Thread dmitri . trembovetski
Changeset: 3fea7e660a8f Author:tdv Date: 2008-11-18 18:32 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3fea7e660a8f 6757527: D3D: serious rendering issues on Nvidia boards with driver version 178.13 on Vista Reviewed-by: campbell ! src/windows/native/sun/java2d/d3d/D3DBli

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6758179: D3D: AlphaComposite is applied incorrectly for uncached opaque BufferedImage

2008-11-18 Thread dmitri . trembovetski
Changeset: 8eb24fc88242 Author:tdv Date: 2008-11-18 17:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8eb24fc88242 6758179: D3D: AlphaComposite is applied incorrectly for uncached opaque BufferedImage Reviewed-by: campbell, flar ! src/windows/native/sun/java2d/d3d/D3DBli

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6764257: D3D/OGL: color is not reset properly after save/restoreState() [RSL]

2008-10-28 Thread dmitri . trembovetski
Changeset: 594c52582b21 Author:tdv Date: 2008-10-28 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/594c52582b21 6764257: D3D/OGL: color is not reset properly after save/restoreState() [RSL] Reviewed-by: campbell ! src/share/classes/sun/java2d/pipe/BufferedContext.java

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6755274: 6u10b33 2d tests fails on sles10x64 with jvm crash

2008-10-21 Thread dmitri . trembovetski
Changeset: 452c58b2f533 Author:tdv Date: 2008-10-21 08:25 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/452c58b2f533 6755274: 6u10b33 2d tests fails on sles10x64 with jvm crash Reviewed-by: campbell ! src/solaris/classes/sun/java2d/opengl/GLXGraphicsConfig.java ! src/window

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6749060: LCD AA text rendered incorrectly when destination is non opaque (sw pipeline only)

2008-10-09 Thread dmitri . trembovetski
Changeset: 3bc4d79d8123 Author:tdv Date: 2008-10-09 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3bc4d79d8123 6749060: LCD AA text rendered incorrectly when destination is non opaque (sw pipeline only) Reviewed-by: campbell, prr ! src/share/classes/sun/java2d/Surfac

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6748082: remove platform-specific code from SwingUtilities2.isDisplayLocal

2008-09-12 Thread dmitri . trembovetski
Changeset: b8f91ea2fb33 Author:tdv Date: 2008-09-12 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b8f91ea2fb33 6748082: remove platform-specific code from SwingUtilities2.isDisplayLocal Reviewed-by: prr, tdv Contributed-by: [EMAIL PROTECTED] ! src/share/classes/sun/ja

Re: [OpenJDK 2D-Dev] [PATCH] SwingUtilities2.isLocalDisplay()

2008-09-10 Thread Dmitri Trembovetski
Yep, I see. I didn't look at the file itself, only at the patch, and got confused. Thanks, Dmitri Roman Kennke wrote: Hi Dmitri, I need to repost my original patch for two reasons: 1. it doesn't apply cleanly (only with some fuzz), 2. it also has this init-loop problem. Find attac

Re: [OpenJDK 2D-Dev] [PATCH] SwingUtilities2.isLocalDisplay()

2008-09-10 Thread Dmitri Trembovetski
Roman Kennke wrote: I need to repost my original patch for two reasons: 1. it doesn't apply cleanly (only with some fuzz), 2. it also has this init-loop problem. Find attached the correct version. I'd be happy to see it committed ASAP. I have a question about the fix: --- a/src/solaris/nati

Re: [OpenJDK 2D-Dev] [PATCH] SwingUtilities2.isLocalDisplay()

2008-09-10 Thread Dmitri Trembovetski
eg. On Tue, Sep 9, 2008 at 10:16 PM, Dmitri Trembovetski <[EMAIL PROTECTED]> wrote: Hi Oleg, Roman, I myself don't think that this API belongs in public. It is used by the platform implementation for doing specific tasks and is of questionable value for general public. Also, it i

Re: [OpenJDK 2D-Dev] [PATCH] SwingUtilities2.isLocalDisplay()

2008-09-09 Thread Dmitri Trembovetski
Martin On Tue, Sep 9, 2008 at 11:16, Dmitri Trembovetski <[EMAIL PROTECTED]> wrote: Hi Oleg, Roman, I myself don't think that this API belongs in public. It is used by the platform implementation for doing specific tasks and is of questionable value for general public. Al

Re: [OpenJDK 2D-Dev] [PATCH] SwingUtilities2.isLocalDisplay()

2008-09-09 Thread Dmitri Trembovetski
Hi Oleg, Roman, I myself don't think that this API belongs in public. It is used by the platform implementation for doing specific tasks and is of questionable value for general public. Also, it is too platform-specific and typically we refrain from adding platform-specific APIs t

Re: [OpenJDK 2D-Dev] [PATCH] SwingUtilities2.isLocalDisplay()

2008-09-05 Thread Dmitri Trembovetski
Hi Roman, the patch looks reasonable to me. Thanks, Dmitri Roman Kennke wrote: Hi there, I've just synced up the Cacio forest with the JDK7 master forest, and I'd like to discuss and try to merge back (into JDK7) some of our patches. The following one affects all of AWT, Swing and

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6739267: D3D/OGL: add missing ThreeByteBgr to texture upload blit loop

2008-08-28 Thread dmitri . trembovetski
Changeset: cd88b4ad7f25 Author:tdv Date: 2008-08-28 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/cd88b4ad7f25 6739267: D3D/OGL: add missing ThreeByteBgr to texture upload blit loop Reviewed-by: campbell, flar ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java !

Re: [OpenJDK 2D-Dev] Where/Why are X11 errors caught?

2008-08-14 Thread Dmitri Trembovetski
I believe AWT installs their own error handler which traps the errors. It should be somewhere in awt_GraphicsEnv.c or around there. Look for where they open the display. You can install your own handler to override theirs - check out how it's done when we detect if shared memory ext

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-08-12 Thread Dmitri Trembovetski
Hi Roman, just to let you know, the main font person (Phil) is out on vacation until 26th I believe so you probably won't get an answer before that.. Thanks, Dmitri Roman Kennke wrote: Hi there, I have a small problem with current implementation of fonts in OpenJDK. It is requi

Re: [OpenJDK 2D-Dev] Code review request to integrate IcedTea Color.createContext fix into OpenJDK 6

2008-08-07 Thread Dmitri Trembovetski
Hi Joe, A couple of comments: One is that the ColorModel check is not really needed since ColorPaintContext doesn't use the passed color model and in fact ignores it if you look at the code so there's no need to create a new one for different CM. So the color model check should

Re: [OpenJDK 2D-Dev] Code review request to integrate IcedTea Color.createContext fix into OpenJDK 6

2008-08-07 Thread Dmitri Trembovetski
Hi Joe, > Webrev uploaded to: > http://dcstaff.invokedynamic.info/images/1/1f/darcy-6735154.tgz Just wondering, would it be possible to have it unzipped there (for future reviews)? It's a bit of a pain to d/l and unzip, much easier to click =) Thanks, Dmitri Joe Darcy wrote: H

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

2008-08-05 Thread Dmitri Trembovetski
Hi Mario, Mario Torre wrote: Il giorno mar, 05/08/2008 alle 12.25 -0700, Dmitri Trembovetski ha scritto: Yeah, I knew you'll like Phil's changes to that code =) eh... I'll try to sync asap. I think we should define a better interface for Sorry, I didn't mean

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

2008-08-05 Thread Dmitri Trembovetski
Dmitri Trembovetski wrote: Actually, our current working repository is a child of jdk7 master, however, it's using an older version. At some point we had to stop syncing, otherwise we would not have been able to finish the thing in time. Unfortunately this means that there are some uns

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

2008-08-05 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: In your case it'd be a webrev between a repo with your changes vs jdk7 master (assuming your repo is synced with master so that the webrev doesn't show any changes other than ones you made). Actually, our current working repository is a child of jd

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6733718: test /java/awt/FullScreen/UninitializedDisplayModeChangeTest/ fails

2008-08-05 Thread dmitri . trembovetski
Changeset: 06a02adcba4e Author:tdv Date: 2008-08-05 09:37 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/06a02adcba4e 6733718: test /java/awt/FullScreen/UninitializedDisplayModeChangeTest/ fails Reviewed-by: igor + test/java/awt/FullScreen/UninitializedDisplayModeChangeTest

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

2008-08-05 Thread Dmitri Trembovetski
Hi Mario, looks pretty good! It'd be awesome if along with all those documents there was a webrev [1] for your changes. In your case it'd be a webrev between a repo with your changes vs jdk7 master (assuming your repo is synced with master so that the webrev doesn't show any cha

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6717988: D3D: rendering problems with JConsole on [Nvidia FX 5200]

2008-08-04 Thread dmitri . trembovetski
Changeset: b2413144d908 Author:tdv Date: 2008-08-04 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b2413144d908 6717988: D3D: rendering problems with JConsole on [Nvidia FX 5200] Reviewed-by: campbell ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6728834: D3D/OGL: LCD AA text becomes bold and blurred when rendering to a non-opaque destination

2008-08-04 Thread dmitri . trembovetski
Changeset: a56641c1f54e Author:tdv Date: 2008-08-04 11:29 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a56641c1f54e 6728834: D3D/OGL: LCD AA text becomes bold and blurred when rendering to a non-opaque destination Reviewed-by: campbell ! src/share/classes/sun/java2d/openg

Re: [OpenJDK 2D-Dev] Linking problems in Solaris :-/

2008-08-02 Thread Dmitri Trembovetski
Hi Clemens, as I mentioned in my other email, I see that for X11 text renderer the AWTDrawGlyphList (used in X11TextRenderer.c) is added to make/awt/mapfile-* and make/xawt/mapfile*, but your XRT_DrawGlyphList is only in xawt, may be that's the problem? Thanks, Dmitri Cleme

Re: [OpenJDK 2D-Dev] Initial code drop in xrender-repository

2008-07-25 Thread Dmitri Trembovetski
Congratulations, Clemens! For those who haven't seen his pipeline at work, take a look at his blog - http://linuxhippy.blogspot.com/ . It's pretty impressive, he can even run Java2Demo, Netbeans and SwingSet2, and even with Nimbus =) Thanks, Dmitri Clemens Eisserer wrote: He

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6728492: typo in copyrights in some files touched by the d3d pipeline port

2008-07-22 Thread dmitri . trembovetski
Changeset: 2d7068a03750 Author:tdv Date: 2008-07-22 11:24 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2d7068a03750 6728492: typo in copyrights in some files touched by the d3d pipeline port Reviewed-by: prr ! make/common/shared/Platform.gmk ! make/common/shared/Sanity.gmk

Re: [OpenJDK 2D-Dev] xrender-pipeline prototype/hack uploaded

2008-07-21 Thread Dmitri Trembovetski
Hi Clemens, Clemens Eisserer wrote: 1.) I've created a seperate struct to hold the per-surface xrender data structures, similar to ShmPixmapData. I initialize it in JX11SD_InitWindow for windows, because initSurface where I do the xrender-initialization for pixmaps is not called for windows.

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6725214: D3D: forward-port the new pipeline from 6u10

2008-07-18 Thread dmitri . trembovetski
Changeset: 3efc003bf097 Author:tdv Date: 2008-07-18 10:48 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3efc003bf097 6725214: D3D: forward-port the new pipeline from 6u10 Summary: Forward port of the new Direct3D 9 rendering pipeline from 6u10. Also includes fixes for 66906

Re: [OpenJDK 2D-Dev] CFV: Doug Felt to Membership in the 2D group

2008-06-24 Thread Dmitri Trembovetski
vote: yes Phil Race wrote: I hereby nominate Doug Felt as a member of the OpenJDK 2D group. Doug has made significant contributions to the Java 2D text APIs and their implementation starting in 1997 and in every release from JDK 1.2 up to and including JDK 6. As part of the Taligent (later IB

Re: [OpenJDK 2D-Dev] Basic Color Management

2008-06-13 Thread Dmitri Trembovetski
Have you looked at java.awt.color package? java.awt.BufferedImage has a ColorModel with ColorSpace describing how to interpret the colors, and which may be defined by ICC profile: http://java.sun.com/javase/6/docs/api/java/awt/image/ColorModel.html http://java.sun.com/javase/6/do

Re: [OpenJDK 2D-Dev] Question about AccelGlyphCache_AddGlyph

2008-06-09 Thread Dmitri Trembovetski
Clemens Eisserer wrote: Sorry again, already found where it is set to null :-/ lg Clemens 2008/6/9 Clemens Eisserer <[EMAIL PROTECTED]>: Hello, 1. In AccelGlyphCache_AddGlyph the cache simply nulls the cellInfo-field, if the glyphinfo is removed from cache: // if the cell is occupied,

Re: [OpenJDK 2D-Dev] Why does the OpenGL pipeline not use setupBlitVector?

2008-06-02 Thread Dmitri Trembovetski
Hi Clemens, Clemens Eisserer wrote: 3.) I have an awkward problem: The strange thing is that the GetPrimitiveArrayCritical call crashes, but if I copy exactly the same call into the trampoline-function, Did you try to run it with -Xcheck:jni (preferably on a fastdebug build)? What does

Re: [OpenJDK 2D-Dev] Why does the OpenGL pipeline not use setupBlitVector?

2008-05-30 Thread Dmitri Trembovetski
Phil Race wrote: I'm not sure at which level you (or rather XRender) are caching the glyphs. You can certainly cache the glyph images, as we do for OGL/D3D (see AccelGlyphCache.c), but I don't see how you could (or would want to) cache position information, etc. It makes sense to do the s

Re: [OpenJDK 2D-Dev] How are transformations done and some other questions

2008-05-19 Thread Dmitri Trembovetski
That's the best kind of question - that answers itself up after a while =) Dmitri Clemens Eisserer wrote: Sorry, seems I've mixed some things up. After stepping through with a debugger things are much clearer now :) Sorry for the traffic, lg Clemens 2008/5/16 Clemens Eisserer <[EMAIL

Re: [OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

2008-05-14 Thread Dmitri Trembovetski
OTECTED] null} > > Fixed. > >> 75: I'd prefer an IllegalArgumentException with an explanatory message >> (e.g. "factory must be non-null"). > > Fixed. Thanks, Dmitri Dmitri Trembovetski wrote: Hi Roman, Roman Kennke wrote: I can tell tha

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6675596: SurfaceManagerFactory should allow plugging in different implementations

2008-05-14 Thread dmitri . trembovetski
Changeset: 4af4867ed787 Author:tdv Date: 2008-05-14 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4af4867ed787 6675596: SurfaceManagerFactory should allow plugging in different implementations Reviewed-by: tdv, campbell Contributed-by: Roman Kennke <[EMAIL PROTECTED]>

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-05-14 Thread Dmitri Trembovetski
Hi Dan, I have integrated the fix into openjdk6 and openjdk7. It's not clear that I will be allowed to put it into 6u10 (we have to justify putting stuff into this release at this point - well past beta) but that shouldn't be a big problem for two reasons: - fix for 6604044 (whic

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6604044: java crashes talking to second X screen

2008-05-14 Thread dmitri . trembovetski
Changeset: ed68352f7e42 Author:tdv Date: 2008-05-14 09:16 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ed68352f7e42 6604044: java crashes talking to second X screen Reviewed-by: prr ! src/solaris/native/sun/awt/awt_GraphicsEnv.c

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-05-13 Thread dmitri . trembovetski
Changeset: 11a35970b90e Author:tdv Date: 2008-05-13 16:46 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/11a35970b90e 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above Summary: improve the check for full exclusive screen support by analyzin

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-05-06 Thread Dmitri Trembovetski
Hi Dan, thanks for doing this. I'll integrate the fix into java7 (and possibly Sun's openjdk6 tree as well) after Javaone. Sorry about dragging this for so long. One piece of good news is that I have integrated the other fix into 6u10 and openjdk6 - to better recognize xinerama, or

Re: [OpenJDK 2D-Dev] Questions about the X11 backend

2008-05-04 Thread Dmitri Trembovetski
Phil is right, the pipeline is still being used and is the fastest way to render on the framebuffers where it is used. As for the MITSHM ifdefs, I believe they are there for some licensees who might want to build the jdk w/o the MITSHM support. Although I would not hazard to guess

Re: [OpenJDK 2D-Dev] CFV: Project sponsorship: XRender Java2D Pipeline

2008-04-10 Thread Dmitri Trembovetski
Nekrestyanov Phil Race Dmitri Trembovetski Alexey Ushakov

Re: [OpenJDK 2D-Dev] Project Proposal: "XRender Java2D Backend"

2008-04-10 Thread Dmitri Trembovetski
Dmitri Trembovetski wrote: This is really confusing. According to Mark we're supposed to send the proposal to the announce, but vote should be held on the group mailing list, and the vote result is reported on the announce list (but Mark I think mistakenly said "discus

Re: [OpenJDK 2D-Dev] Project Proposal: "XRender Java2D Backend"

2008-04-10 Thread Dmitri Trembovetski
Phil Race wrote: Clemens, The URL you referenced says : >A new Project may be proposed by a Member of any existing Group by sending a message to >the announcement list, with replies directed to the general discussion list. So the proposal should go to [EMAIL PROTECTED], not the 2D list.

Re: [OpenJDK 2D-Dev] Project Proposal: "XRender Java2D Backend"

2008-04-10 Thread Dmitri Trembovetski
Vote: yes Clemens Eisserer wrote: In accordance with the OpenJDK guidelines for projects http://openjdk.java.net/projects/ I hereby propose an openjdk project "XRender Java2D Backend". This project will be used for the development of the OpenJDK Community Innovators' Challenge proposal of th

Re: [OpenJDK 2D-Dev] 6523398: sun.java2d.cmm.lcms.LCMS.setTagData

2008-04-07 Thread Dmitri Trembovetski
Keith Seitz wrote: Dmitri Trembovetski wrote: According to this bug: 6523402: OSS CMM: Some quality problems with GRAY, PYCC and CIEXYZ color spaces with lcms library it should have worked with GRAY profile (albeit with some quality issues). Yes, the supplied GRAY.pf *does

Re: [OpenJDK 2D-Dev] 6523398: sun.java2d.cmm.lcms.LCMS.setTagData

2008-04-07 Thread Dmitri Trembovetski
Hi Keith, thanks for looking into this. I suspect that the problem is with the GRAY.pf profile which came with openjdk. I believe Alexey who worked on this stuff generated it himself and might have made a mistake or the file got mangled later somehow (may be during mercurial conve

Re: [OpenJDK 2D-Dev] Missing colour profiles

2008-04-04 Thread Dmitri Trembovetski
HI Andrew, thanks for keeping us in the loop. Dmitri Andrew Haley wrote: Andrew Haley wrote: Just a heads-up: I'm working on Bug 6523403, Need to provide lcms library with PYCC and LINEAR_RGB OS ICC profiles. I'm also looking at the causes of Bug 6523402, Some quality problems with G

Re: [OpenJDK 2D-Dev] lcms native library

2008-04-04 Thread Dmitri Trembovetski
I don't quite see the reason for doing this (not to mention questionable legal ramifications). Why not just use openjdk6? http://openjdk.java.net/projects/jdk6/ Thanks, Dmitri [EMAIL PROTECTED] wrote: Hi, I am trying to replace the color management system of JRE 1.6.0 by the

Re: [OpenJDK 2D-Dev] Thread-Private RenderBuffers for RenderQueue?

2008-03-25 Thread Dmitri Trembovetski
Hi Clemens, Clemens Eisserer wrote: 3.) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6253009 Mentions a deadlock problem that can occur with a seperate lock for the RenderQueue. For my X11 pipeline it would be enough to ensure only one thread does access xlib, it does not have to be al

Re: [OpenJDK 2D-Dev] Thread-Private RenderBuffers for RenderQueue?

2008-03-24 Thread Dmitri Trembovetski
kind of Java2D performance testing I would encourage to use J2DBench as the benchmark (can be found in jdk/src/share/demo/J2DBench). You can plug in new tests if the existing ones don't match what you want to test. Thanks, Dmitri Dmitri Trembovetski wrote: Hi Clemens

Re: [OpenJDK 2D-Dev] Thread-Private RenderBuffers for RenderQueue?

2008-03-24 Thread Dmitri Trembovetski
Hi Clemens. Clemens Eisserer wrote: Hello, Since most applications do render from one thread (either the Event Queue like Swing apps, or some kind of dedicated rendering thread like games), the lock is indeed very fast, given biased locking and such. I would suggest not tryi

Re: [OpenJDK 2D-Dev] Thread-Private RenderBuffers for RenderQueue?

2008-03-24 Thread Dmitri Trembovetski
Hi Clemens, Clemens Eisserer wrote: Hello, 1.) While studying RenderQueue from the STR based 2d pipelines I notices synchronization happening for every command put in the queue. I don't know wether tuning this is worth anything (guess not), but are there cases which make thread-private Ren

Re: [OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

2008-03-14 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: I can tell that someone didn't build on windows since the build fails there =) The fix should have deleted src/windows/classes/sun/java2d/SurfaceManagerFactory.java just like it did the solaris/ one. Whoops, did I forget that? I was sure I deleted i

Re: [OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

2008-03-14 Thread Dmitri Trembovetski
it did the solaris/ one. In general, if the fix touches shared code it is very advisable to build on all platforms - at least on 32-bit solaris/linux/windows. Thanks, Dmitri Dmitri Trembovetski wrote: Roman, I'm sorry, I'm completely swamped with a high priority bug. I'

Re: [OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

2008-03-10 Thread Dmitri Trembovetski
Roman, I'm sorry, I'm completely swamped with a high priority bug. I'll try to file a bug and a code review tomorrow. Dmitri Roman Kennke wrote: Hi, This makes sense, because BufImgVolatileSurfaceManager is required for all targets. Yep, you're right, that should cover it. I

Re: [OpenJDK 2D-Dev] DRAFT PROPOSAL: Implement XRender pipeline for Java2D

2008-02-29 Thread Dmitri Trembovetski
Hi Clemens, this looks like a good project. We currently have no solution for the remote X case, XRender pipeline may be a good answer. Some notes - if this project is to be integrated into the openjdk at some point as the default pipeline on unix (with the current X11 pipeline as

Re: [OpenJDK 2D-Dev] Portable GUI backends

2008-02-29 Thread Dmitri Trembovetski
Hi Roman, this looks like a good proposal. Won't be easy, but it would be nice to have a clear separation between the interfaces and the implementation. Thanks, Dmitri Roman Kennke wrote: Hi, (sorry for x-posting, but I think this affects all 3 lists.) I'd like to point you to

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-02-29 Thread Dmitri Trembovetski
Hi Dan, Dan Munckton wrote: Sorry haven't had time to test your patch here yet. But I did notice that only Xinerama seems to report the correct number of screens - XScreenCount(...) returns 1 whether I've got 1 or 2 monitors plugged in. Yes, that's what I'm hoping for. XScreenCount is sup

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-02-28 Thread Dmitri Trembovetski
s is when we had issues. I can't enable such configuration on my nvidia-accelerated server for some reason. I'll install solaris nevada x86 and see if that would work. Thanks, Dmitri Dmitri Trembovetski wrote: Dmitri Trembovetski wrote: Hi Dan, I have been pre

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-02-28 Thread Dmitri Trembovetski
Dmitri Trembovetski wrote: Hi Dan, I have been preparing the fix for the integration into openjdk6. If you could put it into IcedTea that'd be beneficial as well in case someone runs into a problem. BTW, have you thought by any chance about the other part of the pr

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-02-28 Thread Dmitri Trembovetski
Dmitri On Fri, 2008-02-15 at 15:34 -0800, Dmitri Trembovetski wrote: The good news is that we can probably integrate this fix into the newly created 6open workspace so that the fix gets into the major linux distros quickly. Happily, I've been unable to recreate the weird mouse

Re: [OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

2008-02-26 Thread Dmitri Trembovetski
Roman Kennke wrote: This makes sense, because BufImgVolatileSurfaceManager is required for all targets. Yep, you're right, that should cover it. I'd wait for another reviewer and if there are no objections we could integrate it. Thanks, Dmitri

Re: [OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

2008-02-26 Thread Dmitri Trembovetski
Hi Roman, the change looks mostly fine to me. One thing - have you tested your change with the headless toolkit? Because it has its own GraphicsEnvironment class, and it would appear that you'd need to set appropriate SMF in there too. Now what would that "appropriate SMF" be

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-02-15 Thread Dmitri Trembovetski
Hi Dan, Dan Munckton wrote: Hi Dmitri Regarding testing configurations: I have requested a sparc system with Nevada (so that it has the new X server), and also an x86/64 machine for linux/solaris. Once we have those set up we can proceed with the integration. How's it going? H

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-01-17 Thread Dmitri Trembovetski
Hi Dan, the patch looks fine. The only thing is that we typically try to avoid the use of goto if possible (like in this case since you don't win much by using it), so I'd suggest to just use +dlclose(pLibRandR); +return JNI_FALSE; instead of +goto return_false

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-01-04 Thread Dmitri Trembovetski
OK, Phil actually bothered to check, and now we see your name in the list of SCA signatories! Woo-hoo! Thanks, Dmitri Dmitri Trembovetski wrote: Hi Dan, did you receive a confirmation about the SCA? Thanks, Dmitri Dmitri Trembovetski wrote: Hi Dan, I know that

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2008-01-04 Thread Dmitri Trembovetski
Hi Dan, did you receive a confirmation about the SCA? Thanks, Dmitri Dmitri Trembovetski wrote: Hi Dan, I know that you sent your SCA (repeatedly =) so I looked at the fix. It looks good. Please see my comments below. Dan Munckton wrote: APPROACH The fix is really

Re: [OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above

2007-12-19 Thread Dmitri Trembovetski
Hi Dan, I know that you sent your SCA (repeatedly =) so I looked at the fix. It looks good. Please see my comments below. Dan Munckton wrote: APPROACH The fix is really simple it just checks to make sure RANDR's version is 1.2 or greater if usingXinerama is true, if this is all fi

Re: [OpenJDK 2D-Dev] Best way organizing XRenderadditions for theX11 pipeline?

2007-12-07 Thread Dmitri Trembovetski
1] Use RENDER extension for complex operations done in software * 5086814: RFE: Java 2D: consider Xrender for anti-aliased text on remote X11 Thanks, Dmitri Java2D Team Dmitri Trembovetski wrote: LOUD, Ben wrote: >> Meanwhile, if instead of "paths" you've actually

Re: [OpenJDK 2D-Dev] Best way organizing XRenderadditions for theX11 pipeline?

2007-12-07 Thread Dmitri Trembovetski
LOUD, Ben wrote: >> Meanwhile, if instead of "paths" you've actually already got something >> tessellated and just need it to be rasterized, then sure, you can call >> into XRenderCompositeTrapezoids to do just that if you'd like. ahh ok this is interesting. I see your point. I've been spe

Re: [OpenJDK 2D-Dev] Java Fullscreen Mode with Xorg server 1.3.0+ (I'm ready to work on a patch)

2007-12-03 Thread Dmitri Trembovetski
Hi Dan, thank you for filing the bug. I found your posts on various forums when researching for bug 6599351. Dan Munckton wrote: am I right that your are going to fix our code so it correctly handled situation when Xinerama is loaded but we have just one screen, so we could use Xrandr e

Re: [OpenJDK 2D-Dev] DirectX9 support for java-2d

2007-11-16 Thread Dmitri Trembovetski
Saravanan S wrote: Hi Phil, Thanks for the update. I will try it out. Yes, the work is largely already done and you can download EA binaries at http://download.java.net/jdk6/binaries. Does this mean that the source for the same is not available on openjdk? Correct. Not because of any s

Re: [OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-04 Thread Dmitri Trembovetski
Hi Roman, Roman Kennke wrote: Hi Dmitri, thanks for the patch. We're currently in a somewhat of a freeze because of the move to Mercurial, so we'll probably integrate the patch after that's done. Cool, thank you. I'll wait with more patches then until Mercurial is done. Will

Re: [OpenJDK 2D-Dev] Remove warnings in sun.java2d

2007-10-04 Thread Dmitri Trembovetski
Hi Roman, thanks for the patch. We're currently in a somewhat of a freeze because of the move to Mercurial, so we'll probably integrate the patch after that's done. Thanks, Dmitri Roman Kennke wrote: I looked through the classes in sun.java2d and removed most warnings there.

  1   2   >