Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Approved. Please send a request to commit this change to the 8u-dev list. -phil. On 01/20/2016 10:20 PM, Jayathirth D V wrote: Hi, This is backport of the fix that is already merged into JDK9. _Please review the fix in JDK8u:_ Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev :

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi, This is backport of the fix that is already merged into JDK9. Please review the fix in JDK8u: Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev : http://cr.openjdk.java.net/~jdv/8041501.8u/webrev.00/ Issue : Pink discoloration when we read JPEG images without JFI

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

+1 Regards Prasanta On 11/25/2015 12:08 PM, Jayathirth D V wrote: Hi Prasanta, Please review updated webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.03/ Thanks, Jay *From:*Phil Race *Sent:* Tuesday, November 24, 2015 11:57 PM

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Please review updated webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8041501/webrev.03/"http://cr.openjdk.java.net/~jdv/8041501/webrev.03/ Thanks, Jay From: Phil Race Sent: Tuesday, November 24, 2015 11:57 PM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@o

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Approved. -phil. On 11/24/2015 01:39 AM, Jayathirth D V wrote: Hi Phil, I have replaced already present comment block with proper comments , since it was contradicting Metadata spec. And removed extra comments added by me. _Please review updated webrev:_ http://cr.openjdk.java.net/~jdv/8

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Phil, I have replaced already present comment block with proper comments , since it was contradicting Metadata spec. And removed extra comments added by me. Please review updated webrev: http://cr.openjdk.java.net/~jdv/8041501/webrev.03/ Thanks, Jay From: Phil Race Sent: Tues

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Rather than adding a comment block, it seems you need to edit the preceding one. * IJG assumes all unidentified 3-channels are YCbCr. 1715 * We assume that only if the second two channels are 1716 * subsampled (either horizontally or vertically). If not, 1717

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Looks ok to me. Regards Prasanta On 11/23/2015 5:31 PM, Jayathirth D V wrote: Hi Prasanta, Removed repeated usage of getWidth() and getHeight(). Please review. http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ Thanks, Jay *From:*pra

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Looks ok to me. But probably you could check for image width &height programmatically instead of hardcoding to 64 in testcode. Regards Prasanta On 11/23/2015 4:09 PM, Jayathirth D V wrote: Hello All, _Please review following fix in JDK9:_ __ Bug : https://bugs.openjdk.java.net/browse/JDK-8

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Removed repeated usage of getWidth() and getHeight(). Please review. http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 5:15 PM To: Jayathirth D V Cc: Philip Race; 2d-dev@openjdk.java.net Subject: Re

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

On 11/23/2015 5:11 PM, Jayathirth D V wrote: Hi Prasanta, Thanks for suggestion. I have made related changes and updated the Webrev. Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/ Please review. There's no point getting

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Thanks for suggestion. I have made related changes and updated the Webrev. Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/ Please review. Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 4:43 PM To: Jayathirth D V; 2d-dev@openjdk.ja

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hello All, Please review following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.00/ Issue : Pink discoloration when we read JPEG images without JFIF & EXIF header and having no subsampling. Root caus