On Fri, 7 May 2021 17:53:49 GMT, Alexander Zuev wrote:
>> This comment is also about the case of not fetching icons of sizes smaller
>> than requested size.
>
> Sorry, missed that in my latest fix. Indeed there is no legitimate ways to
> set scaling factor to less than 100% on Windows so yes,
On Thu, 27 May 2021 16:38:02 GMT, Alexander Zuev wrote:
>> Is this requirement is so important? can we return an MRI(same as on
>> Windows) which will have just one resolution? Otherwise what the user should
>> do if the requested size was 32x32 but returned image will be 21x21? Paint
>> the
On Thu, 27 May 2021 16:16:19 GMT, Sergey Bylokhov wrote:
> Is this requirement is so important? can we return an MRI(same as on Windows)
> which will have just one resolution?
We might - when the implementation will be done on other platforms. Probably it
will be done by me, probably - by
On Wed, 26 May 2021 21:39:19 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 87:
>>
>>> 85: }
>>> 86:
>>> 87: if (implComplete && icon.getIconWidth() != size) {
>>
>> Why the size of the returned images might be
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Test comment fixed.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2875/files
- new:
On Wed, 26 May 2021 21:06:49 GMT, Sergey Bylokhov wrote:
> Did somebody run the test on Linux and macOS, Does our stub implementation
> there confirms the specification?
I did run fill tier4 and visually compared the JFileChooser appearance on both
Linux and Mac OS X - this change introduced
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
On Thu, 27 May 2021 00:18:13 GMT, Phil Race wrote:
>> Alexander Zuev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fixed small errors
>>Adjustments in the test
>> - Grammar fix in method documentation
>
>
On Wed, 26 May 2021 21:37:44 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 77:
>>
>>> 75: int[] sizes = new int[] {16, 32, 48, 64, 128};
>>> 76: for (int size : sizes) {
>>> 77: ImageIcon icon = (ImageIcon)
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
On Wed, 26 May 2021 21:12:16 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fixed small errors
>>Adjustments in the test
>> - Grammar fix in method documentation
>
>
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
On Fri, 21 May 2021 19:37:19 GMT, Alexander Zuev wrote:
>> Didn't you answer your question already? If `FileSystemView.getRoots()`
>> returns Desktop in Windows shell namespace. Otherwise, I don't know a way to
>> get a reference to a *virtual* folder in Windows shell namespace which
>>
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
On Wed, 26 May 2021 17:40:44 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 300:
>>
>>> 298:
>>> 299: if(!f.exists()) {
>>> 300: return null;
>>
>> Shall it throw `FileNotFoundException` or
On Wed, 26 May 2021 15:15:42 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> null file now properly causes IllegalArgumentException
>> Small fixed in JavaDoc
>
>
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with two additional
commits since the last revision:
- Fixed small errors
Adjustments in the test
- Grammar fix in method documentation
-
Changes:
- all:
On Wed, 26 May 2021 16:03:02 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 67:
>>
>>> 65: if (!gotException) {
>>> 66: throw new RuntimeException("Negative size icon should throw
>>> invalid argument exception");
>>>
On Wed, 26 May 2021 15:07:30 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> null file now properly causes IllegalArgumentException
>> Small fixed in JavaDoc
>
>
On Tue, 25 May 2021 23:36:43 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> null file now properly causes IllegalArgumentException
> Small fixed
On Tue, 25 May 2021 23:36:43 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> null file now properly causes IllegalArgumentException
> Small fixed
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
null file now properly causes IllegalArgumentException
Small fixed in JavaDoc
-
Changes:
- all:
On Tue, 25 May 2021 23:17:39 GMT, Phil Race wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed API to support non-square icons and updated documentation
>> accordingly
>> Fixed test to support updated
On Tue, 25 May 2021 22:01:36 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed API to support non-square icons and updated documentation
>
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Changed API to support non-square icons and updated documentation
accordingly
Fixed test to support updated API
Added negative test
On Fri, 21 May 2021 22:07:30 GMT, Phil Race wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Chenged implementation specification based on CSR review
>
>
On Fri, 21 May 2021 21:41:44 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Chenged implementation specification based on CSR review
> > if the
On Fri, 21 May 2021 21:24:10 GMT, Phil Race wrote:
> if the aspect ratio is consistent as I expect is typical we should support
> that
Ok, i see your point. I can do that for sure, it is just a change of API for
now, no implementation will be affected since Windows does not support
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Chenged implementation specification based on CSR review
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2875/files
On Thu, 20 May 2021 22:25:05 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Specification of getSystemIcon reworded to get rid of the non-public
>
On Fri, 21 May 2021 20:10:55 GMT, Phil Race wrote:
> Please note that I added a number of comments in the CSR itself.
> I had suggestions about what to do in many of the cases but there's a couple
> of cases where
> I could not either divine what was intended or know the best way to phrase it.
On Thu, 20 May 2021 22:25:05 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Specification of getSystemIcon reworded to get rid of the non-public
>
On Fri, 21 May 2021 19:11:45 GMT, Alexey Ivanov wrote:
>> But how you got them via this method? I am not sure what parameters should
>> be passed to it.
>
> Didn't you answer your question already? If `FileSystemView.getRoots()`
> returns Desktop in Windows shell namespace. Otherwise, I don't
On Fri, 21 May 2021 18:16:36 GMT, Sergey Bylokhov wrote:
>>> It is accessible from the "JFileChooser" drop-down menu. On my system, the
>>> Libraries at that drop down menu contain "GIT", "Documents", "Music".
>>> https://docs.microsoft.com/en-us/windows/client-management/windows-libraries
>>>
On Fri, 21 May 2021 01:11:38 GMT, Sergey Bylokhov wrote:
>>> But this is shared code, which has a specification it should work
>>> everywhere, so even if on Linux and macOS it is not implemented in the best
>>> way it should return something.
>>
>> The stuff that is returned by the common
On Fri, 21 May 2021 06:32:02 GMT, Alexander Zuev wrote:
>> It is accessible from the "JFileChooser" drop-down menu. On my system, the
>> Libraries at that drop down menu contain "GIT", "Documents", "Music".
>> https://docs.microsoft.com/en-us/windows/client-management/windows-libraries
>>
>>
On Fri, 21 May 2021 05:42:46 GMT, Sergey Bylokhov wrote:
> It is accessible from the "JFileChooser" drop-down menu. On my system, the
> Libraries at that drop down menu contain "GIT", "Documents", "Music".
> https://docs.microsoft.com/en-us/windows/client-management/windows-libraries
>
>
On Fri, 21 May 2021 04:15:41 GMT, Alexander Zuev wrote:
>> Maybe we can test this case by just reusing this method where the
>> "sf.getIcon(largeicon)" previously used in the WindowsPlacesBar class? That
>> old method has the special code for "folder.isLibrary()" so I assume it
>> supported
On Fri, 21 May 2021 03:21:19 GMT, Sergey Bylokhov wrote:
>> The JFileChooser supports the libraries since it allows navigation inside
>> them. It is done via ShellFolder which extends the file class. The
>> FileSystemView feeds the JFileChooser by the data, so it may returns
>> "non-file"
On Fri, 21 May 2021 02:45:15 GMT, Sergey Bylokhov wrote:
>> No, libraries are not supported.
>>
>> I see no contradiction here: `JFileChooser` uses Windows Shell API to
>> enumerate objects and navigate the shell namespace. But it does not return
>> non-file objects, does it?
>>
>> The new
On Thu, 20 May 2021 18:51:54 GMT, Alexey Ivanov wrote:
>> So the libraries are not supported? I doubt since JFileChooser should
>> support them, and supports of it is one of the reasons why we use shell
>> folder to iterate the folders and do not use the javaio.
>
> No, libraries are not
On Thu, 20 May 2021 22:38:48 GMT, Sergey Bylokhov wrote:
> But this is shared code, which has a specification it should work everywhere,
> so even if on Linux and macOS it is not implemented in the best way it should
> return something.
The stuff that is returned by the common code is already
On Thu, 20 May 2021 22:37:08 GMT, Sergey Bylokhov wrote:
> I did not get how you will be able to force use MRI later since this method
> is implemented as a return icon. So this choice should be made before
> integration.
I am not going to force MRI usage - i am assuming that there might be
On Thu, 20 May 2021 19:25:38 GMT, Alexander Zuev wrote:
>> Here I am not talking about specification, I am talking about the usage of
>> it, is the instanceof+cast is helpful? It does not look good, why we cannot
>> always return MRI?
>
>> Here I am not talking about specification, I am
On Thu, 20 May 2021 18:49:53 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 27:
>>
>>> 25: * @test
>>> 26: * @bug 8182043
>>> 27: * @requires os.family == "windows"
>>
>> Other than using "explorer" what prevents us to run this test
On Thu, 20 May 2021 19:35:57 GMT, Phil Race wrote:
> Really I would need to see what the actual delta ends up being to be sure for
> this case.
I have updated the method documentation. Could you please take a look before i
finalized the CSR again? I am really trying to push this functionality
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Specification of getSystemIcon reworded to get rid of the non-public
class reference and to better describe some cornor cases
On Thu, 20 May 2021 19:22:50 GMT, Alexander Zuev wrote:
>> But it is still part of the specification unlike implnote/apinote, and we
>> cannot use non-public classes there, since other JavaSE implementations may
>> not have this class. see discussion on the link above.
>
>> But it is still
On Thu, 20 May 2021 17:29:55 GMT, Sergey Bylokhov wrote:
> Here I am not talking about specification, I am talking about the usage of
> it, is the instanceof+cast is helpful?
It is necessary until all the consequences of always returning of MRI is
extensively tested on all the supported
On Thu, 20 May 2021 17:33:08 GMT, Sergey Bylokhov wrote:
> But it is still part of the specification unlike implnote/apinote
I think you can suggest usage of the implNote here - i am going from the
initial description of the reason implSpec in the JEP saying that
implementation and logic of
On Thu, 20 May 2021 17:37:20 GMT, Sergey Bylokhov wrote:
>>> Are we sure that all possible paths can be pointed by the file object?
>>
>> We specify that we return the icon for a file. If path can not be resolved
>> in the file object we can not return the icon for it.
>
> So the libraries are
On Thu, 20 May 2021 16:09:14 GMT, Sergey Bylokhov wrote:
> Other than using "explorer" what prevents us to run this test on other
> platforms?
Because right now it makes no sense? The functionality we are testing is
implemented on Windows only. Once we extend it to other platforms we might
On Thu, 20 May 2021 16:45:35 GMT, Alexander Zuev wrote:
>> We do not test for that in the regression test but i did tested it manually
>> and we do return null for the non-existed files. I tested it on non-windows
>> platform too. We still return null.
>
>> Are we sure that all possible paths
On Thu, 20 May 2021 17:25:33 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 72:
>>
>>> 70: if (icon.getImage() instanceof MultiResolutionImage) {
>>> 71: MultiResolutionImage mri = (MultiResolutionImage)
>>>
On Thu, 20 May 2021 16:58:36 GMT, Alexander Zuev wrote:
>> No they will have the same size. That's why the broad wording is used that
>> we take a requested size into consideration but we will return the best
>> possible icon we can get and we do not guarantee that the icon size will
>>
On Thu, 20 May 2021 16:14:42 GMT, Sergey Bylokhov wrote:
> BTW this is why I recommended filing a CSR after the fix is fully discussed
> and agreed upon.
The CSR was filed almost five years ago.
-
PR: https://git.openjdk.java.net/jdk/pull/2875
On Thu, 20 May 2021 15:57:04 GMT, Sergey Bylokhov wrote:
> This is to describe one of my questions above, is this instanceof+cast cannot
> be improved? Why we cannot always wrap the data in the MRI and if we have
> only one icon return the MRI with one resolution?
No because in specification
On Thu, 20 May 2021 16:53:06 GMT, Alexander Zuev wrote:
>> As for the example on Linux, how it will work for different sizes?
>>Icon icon1 = fsv.getSystemIcon(new File("."), 16);
>>Icon icon2 = fsv.getSystemIcon(new File("."), 32);
>> Will the resulted icons have proper size 16 and 32?
>
On Thu, 20 May 2021 16:13:41 GMT, Sergey Bylokhov wrote:
>> My point was that the implspec is a normative specification and we cannot
>> refer to non-public classes in that documentation.
>
> As for the example on Linux, how it will work for different sizes?
>Icon icon1 =
On Thu, 20 May 2021 16:06:37 GMT, Sergey Bylokhov wrote:
>> Are we sure that all possible paths can be pointed by the file object?
>> Especially some "Windows Libraries" which are accessed by the shell folder?
>
> Later we say that this method returns null for non-existed files. is it
> always
On Thu, 20 May 2021 16:43:05 GMT, Alexander Zuev wrote:
>> Later we say that this method returns null for non-existed files. is it
>> always correct? I am not sure that the file created for the library report
>> true for the exists() method; DId we test this usecase?
>
> We do not test for
On Thu, 20 May 2021 07:30:00 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Empty tag before @implSpec causes warning during javadoc generation
On Thu, 20 May 2021 14:55:06 GMT, Alexey Ivanov wrote:
>> The CSR is already approved and changing specification at this point will
>> require to roll it back to draft and then going trough the approval process
>> again which in turn risks this change not to make it in the upcoming LTS
>>
On Thu, 20 May 2021 16:01:32 GMT, Sergey Bylokhov wrote:
>>> The @implSpec is part of the specification, it is different from the
>>> @implNote, no?
>>>
On Thu, 20 May 2021 07:30:00 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Empty tag before @implSpec causes warning during javadoc generation
On Thu, 20 May 2021 07:40:35 GMT, Sergey Bylokhov wrote:
>> Good catch! Yes, fixed both here and in CSR.
>
> Are we sure that all possible paths can be pointed by the file object?
> Especially some "Windows Libraries" which are accessed by the shell folder?
Later we say that this method
On Thu, 20 May 2021 10:36:39 GMT, Alexander Zuev wrote:
>> The @implSpec is part of the specification, it is different from the
>> @implNote, no?
>>
On Thu, 20 May 2021 08:26:07 GMT, Alexander Zuev wrote:
>> SurfaceData is not a public class, do we use this term somewhere in the
>> spec? If not then it will be better to use size/points in the user space
>> coordinate system, it is used already in the java2d.
>
> The CSR is already approved
On Thu, 20 May 2021 08:25:25 GMT, Sergey Bylokhov wrote:
> The @implSpec is part of the specification, it is different from the
> @implNote, no?
>
On Thu, 20 May 2021 08:13:21 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 272:
>>
>>> 270: * returned is a multi-resolution icon image,
>>> 271: * which allows better support for High DPI environments
>>> 272: *
On Thu, 20 May 2021 08:18:02 GMT, Sergey Bylokhov wrote:
>>> What are the "virtual pixels"? I remember we refer to something similar by
>>> the point in the "user space coordinate system" Or probably we use the
>>> virtual pixels somewhere?
>>
>> It is to say that the sizes are given in the
On Thu, 20 May 2021 08:07:48 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 275:
>>
>>> 273: *
>>> 274: * @param f a {@code File} object
>>> 275: * @param size width and height of the icon in virtual pixels
>>
>>
On Thu, 20 May 2021 07:47:02 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Empty tag before @implSpec causes warning during javadoc generation
>
>
On Thu, 20 May 2021 07:46:28 GMT, Sergey Bylokhov wrote:
> What are the "virtual pixels"? I remember we refer to something similar by
> the point in the "user space coordinate system" Or probably we use the
> virtual pixels somewhere?
It is to say that the sizes are given in the same pixels
On Thu, 20 May 2021 07:30:00 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Empty tag before @implSpec causes warning during javadoc generation
On Mon, 17 May 2021 05:08:13 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 271:
>>
>>> 269: * Example:
>>> 270: * FileSystemView fsv = FileSystemView.getFileSystemView();
>>> 271: * Icon icon =
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Empty tag before @implSpec causes warning during javadoc generation
-
Changes:
- all:
On Tue, 18 May 2021 00:29:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed documentation based on CSR review feedback
Marked as reviewed by
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixed documentation based on CSR review feedback
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2875/files
- new:
On Sun, 16 May 2021 18:49:24 GMT, Alexander Zvegintsev
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Slight change of wording in javadoc
>> Fixed Win32ShellFolder2.getSystemIcon scaling issue
>
>
On Fri, 14 May 2021 19:46:03 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Slight change of wording in javadoc
> Fixed
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Slight change of wording in javadoc
Fixed Win32ShellFolder2.getSystemIcon scaling issue
-
Changes:
- all:
On Fri, 14 May 2021 13:30:13 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make getShell32Icon method return multi-resolition image in case of
>> requested icon size and actual icon size
On Tue, 11 May 2021 21:34:59 GMT, Alexander Zuev wrote:
>> No, it isn't wrapped: if `getShell32Icon` is called in `getIcon(final
>> boolean getLargeIcon)`, the returned value is immediately returned to the
>> caller, see lines 1157–1163 in the updated code:
>>
>> if
On Tue, 11 May 2021 21:41:15 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make getShell32Icon method return multi-resolition image in case of
>
On Tue, 11 May 2021 19:36:12 GMT, Alexey Ivanov wrote:
>> I will create a separate bug to track this - i do not know if library
>> loading gets cached on some level and what impact on performance will we
>> have if we release it every call. But i will check it out separately.
>
> Sure! I just
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Make getShell32Icon method return multi-resolition image in case of
requested icon size and actual icon size mismatch.
-
On Tue, 11 May 2021 20:01:37 GMT, Alexey Ivanov wrote:
>> Wherever it is necessary down the line we are wrapping the result in
>> multi-resolution and if we wrap it here too we will have multi-resolution
>> icon that contains multi-resolution images as a resolution variant.
>> Unfortunately
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Slightly changing javadoc wording
Removing unnecessary boxing of int
Releasing the pIcon in native code properly
-
On Tue, 11 May 2021 10:07:30 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Tue, 11 May 2021 18:48:31 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1196:
>>
>>> 1194: Image icon = makeIcon(hIcon);
>>> 1195: disposeIcon(hIcon);
>>> 1196: return icon;
>>
>> Shall it not
On Tue, 11 May 2021 18:50:13 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1192:
>>
>>> 1190: */
>>> 1191: static Image getShell32Icon(int iconID, int size) {
>>> 1192: long hIcon = getIconResource("shell32.dll",
On Tue, 11 May 2021 10:53:06 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Fri, 7 May 2021 17:30:15 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java line 213:
>>
>>> 211: * Returns the icon of the specified size used to display this
>>> shell folder.
>>> 212: *
>>> 213: * @param size size of the icon > 0
On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Fri, 30 Apr 2021 20:50:53 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64:
>>
>>> 62: }
>>> 63:
>>> 64: if (icon.getIconWidth() != size) {
>>
>> Does it make sense to check that the icon is a multi-resolution
> Fix updated after first round of review.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since the last
On Fri, 30 Apr 2021 20:48:21 GMT, Alexey Ivanov wrote:
>> Getting smaller icon is relevant in the case of the scaling. I do not think
>> refactoring image caches from icons to multiresolution images will make code
>> much cleaner - at the end we will have to extract images from the
>>
1 - 100 of 127 matches
Mail list logo
