Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-08-16 Thread Maxim Kartashev
On Fri, 13 Aug 2021 18:50:01 GMT, Sergey Bylokhov wrote: >> Yes, the exception will still be "raised" after this call. Since there are >> no JNI calls (at least those that are forbidden to make with an exception >> pending) between here and return back to Java, I believe no additional steps

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-08-13 Thread Sergey Bylokhov
On Fri, 13 Aug 2021 12:11:15 GMT, Maxim Kartashev wrote: >> Does it actually suppress the "Xcheck:jni" or it clears a raised exception? >> If an exception is still "raised" after this call we should do some >> additional steps to log/clean it. > > Yes, the exception will still be "raised"

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-08-13 Thread Maxim Kartashev
On Thu, 12 Aug 2021 21:57:58 GMT, Sergey Bylokhov wrote: >> Yes, the `ExceptionCheck()` call will silence the warnings from >> `-Xcheck:jni`. > > Does it actually suppress the "Xcheck:jni" or it clears a raised exception? > If an exception is still "raised" after this call we should do some >

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-08-12 Thread Sergey Bylokhov
On Mon, 19 Jul 2021 08:31:21 GMT, Maxim Kartashev wrote: >> src/java.desktop/windows/native/libawt/java2d/d3d/D3DRenderQueue.cpp line >> 870: >> >>> 868: J2dTraceLn(J2D_TRACE_VERBOSE, " executing runnable"); >>> 869: jboolean ignoreException; >>> 870:

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-07-23 Thread Maxim Kartashev
On Sat, 17 Jul 2021 03:05:35 GMT, Sergey Bylokhov wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Marked the test as headful so that it doesn't fail on a headless >> system. >> 2. Added exception checks

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-07-19 Thread Maxim Kartashev
On Sat, 17 Jul 2021 03:03:41 GMT, Sergey Bylokhov wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Marked the test as headful so that it doesn't fail on a headless >> system. >> 2. Added exception checks

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-07-16 Thread Sergey Bylokhov
On Wed, 14 Jul 2021 05:48:42 GMT, Maxim Kartashev wrote: >> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and >> `ExceptionClear()` immediately after the Java calls made from the callback >> function `ReadTTFontFileFunc()` in `freetypeScaler.c`. >> >> The exception(s) need

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v3]

2021-07-13 Thread Maxim Kartashev
> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and > `ExceptionClear()` immediately after the Java calls made from the callback > function `ReadTTFontFileFunc()` in `freetypeScaler.c`. > > The exception(s) need to be cleared because we're not returning immediately > to Java