Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread Russ Cox
> Is there any way we could solve the current state of affairs with > slightly diverging gui/draw codebases for p9p, drawterm, 9vx, acme-sac > and inferno-os? Each seems to have a set of bugs that somewhat > overlaps with the other projects, and they have to be rediscovered, > and the fixes moved a

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread andrey mirtchovski
> - BeginFullScreen(&restore, 0, 0, 0, &osx.window, 0, 0); > + GDHandle device; > + GetWindowGreatestAreaDevice(&osx.window, > kWindowTitleBarRgn, &device, NULL); > + BeginFullScreen(&fullScreenRestore, device, 0, 0, > &osx.window, 0, 0); oop

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread underspecified
Sorry, I was a bit hasty with the patch. This one should compile properly: diff -r ca5b26cbe43a src/9vx/osx/screen.c --- a/src/9vx/osx/screen.c Tue Jul 01 17:27:41 2008 -0400 +++ b/src/9vx/osx/screen.c Fri Jul 04 01:31:37 2008 +0900 @@ -513,7 +511,9 @@ }else{ Hide

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread underspecified
Greetings, Thanks for finding that snippet, andrey :-) I was about to search the acme-sac code for it so I could post a patch. After looking through the 9vx code, it looks like russ is handling memory allocation for the screen a little differently than acme-sac (and possibly drawterm). In acme-sa

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread ron minnich
On Thu, Jul 3, 2008 at 8:55 AM, Uriel <[EMAIL PROTECTED]> wrote: > If there was a single codebase shared > across projects none of this would be an issue at all. you are right but it's a hard problem, we're all tight for time, so the only fix is for somebody to step up and do it. But your questio

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread Uriel
X11 code is still broken in various places, for example in Inferno-os (and even more so acme-sac, which is missing some of the updates that made it into inferno-os). So my comment applies as much to the osx code as to the x11 code, and to hypothetical win32 code. That is the whole point, that ever

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread andrey mirtchovski
> Is there any way we could solve the current state of affairs if that's the royal "we" you're using then sure, there is a way: simply download the latest versions of all programs that you're interested in unifying (p9p, drawterm, 9vx, acme-sac, inferno), merge the osx drawing code (using the bes

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread Uriel
This seems to be (given my limited understanding) similar to what acme-sac is doing. Is there any way we could solve the current state of affairs with slightly diverging gui/draw codebases for p9p, drawterm, 9vx, acme-sac and inferno-os? Each seems to have a set of bugs that somewhat overlaps with

Re: [9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread andrey mirtchovski
I think the problem comes from 9vx picking up the main display's dimensions as the preallocation for "full screen". Drawterm has a fix for that which loops through all the currently attached displays and picks up the one with the largest size to decide what the "maximum dimensions" should be. here

[9fans] 9vx.OSX bug: resize on second display causes window to go wrong

2008-07-03 Thread Anthony Sorace
I have a 10.5 MacBook with an external display attached. When I start 9vx, things look normal. I can resize the window on the main display. If I move it to the second display and resize, the window goes from "good" to "bad": http://strand1.com/who/anthony/bug/good.png http://strand1.com/who/anthon