Re: tr:datetimeconverter and shortish style

2007-03-22 Thread Gabrielle Crawford
This seems like a fine fix, I will merge this unless there are objections. Thanks, Gab On 3/15/2007 3:12 PM, Yee-wah Lee wrote: I've filed JIRA ADF-Faces 410 on this: https://issues.apache.org/jira/browse/ADFFACES-410 In there I suggest a fix to use the 4-digit pattern when formatting,

Re: Add a messageSummary attribute to various converter and validator

2007-03-13 Thread Gabrielle Crawford
+1 on adding a way to customize the summary per instance. Thanks, Gab On 3/10/2007 10:57 AM, Simon Lessard wrote: Hello all, Currently, most converters and validators allow a *MessageDetail attribute to specify the detail message to use when a conversion/validation error occurs. However,

Re: Check for application specific resource bundle before the embedded one

2007-03-13 Thread Gabrielle Crawford
+1 This seems to match the spec, which defines the algorithm below, so we'd just use org.apache.myfaces.trinidad.resource.MessageBundle instead of javax.faces.Messages. The following algorithm must be used to create a FacesMessage instance given a message key. Call getMessageBundle() on the

Re: [vote] release of core (1.0.0-incubating)

2007-03-09 Thread Gabrielle Crawford
[X] +1 (Binding) for PPMC members only [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. On 3/9/2007 4:31 AM, Matthias Wessendorf wrote: Hi, I managed to get some release artifacts

Re: XRTS files

2007-02-27 Thread Gabrielle Crawford
My motto is use it or lose it. It works for code and for the stuff in the garage. - Gab On 2/27/2007 12:37 PM, Matthias Wessendorf wrote: Hello, there are some messages inside the XRTS files, which aren't used, like: !-- {0} the label that identifies the component -- !-- {1} value

Re: [vote] release of plugins (1.0.0-incubating)

2007-02-14 Thread Gabrielle Crawford
+1. Thanks, Gab On 2/14/2007 2:13 AM, Matthias Wessendorf wrote: Hi, I finally managed to get some release artifacts published to a stage repo. I used my private Apache account for that ([1]). Please take a look at the 1.0.0-incubating artifacts and vote if we should take these file to ask

Re: jsp mojo changes

2006-11-17 Thread Gabrielle Crawford
Thanks Matthias, This is issue 296. https://issues.apache.org/jira/browse/ADFFACES-296 Thanks, Gab Matthias Wessendorf wrote: I have no concerns in putting changes to the mojo file. -M On 11/17/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Darn, found one more. Sorry this isn't more

assigning issues to myself

2006-11-17 Thread Gabrielle Crawford
Hi there, Now that I'm a committer I'd like to be able to assign issues to myself and I don't see a way to do that. Anyone know what I need to do to get that working? Thanks, Gabrielle

jsp mojo changes

2006-11-16 Thread Gabrielle Crawford
Hi, We are using the Trin Tag generator class GenerateJspTaglibsMojo. However we want to add some custom code in the tag and tld. I would like to make the following changes to GenerateJspTaglibsMojo, does anyone have any objections 1] add 2 protected methods which are no-ops in Trinidad.

Re: jsp mojo changes

2006-11-16 Thread Gabrielle Crawford
minor correction below. Gabrielle Crawford wrote: Hi, We are using the Trin Tag generator class GenerateJspTaglibsMojo. However we want to add some custom code in the tag and tld. I would like to make the following changes to GenerateJspTaglibsMojo, does anyone have any objections 1

Re: jsp mojo changes

2006-11-16 Thread Gabrielle Crawford
Crawford wrote: minor correction below. Gabrielle Crawford wrote: Hi, We are using the Trin Tag generator class GenerateJspTaglibsMojo. However we want to add some custom code in the tag and tld. I would like to make the following changes to GenerateJspTaglibsMojo, does anyone have any objections

Re: -adfinternal-supportsDisabledOptions

2006-11-15 Thread Gabrielle Crawford
It means if an option had disabled set to true, does the browser actually support this? For example I think ie 6 shows options that have the disabled attribute as regular selectable options. Thanks, Gab Piyush Hari wrote: Anyone knows what this capabiliy means for a browser ?

Re: Formatting locale vs. translation locale

2006-10-25 Thread Gabrielle Crawford
as a German-speaking user, this is not the way I'd want the application to behave automatically. regards, Martin On 10/25/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Arjuna Wijeyekoon wrote: On 10/24/06, Adam Winer [EMAIL PROTECTED] wrote: On 10/24/06, Arjuna Wijeyekoon [EMAIL

Re: Formatting locale vs. translation locale

2006-10-25 Thread Gabrielle Crawford
/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Simon Lessard wrote: I'm so divided on this issue that I think I'll call a +0 on my side. When I go on a site in English, I expect the date to be formatted accordingly. On I couldn't tell from the comment what you meant exactly. It may

new validator: dateRestrictionValidator

2006-10-25 Thread Gabrielle Crawford
Hi, I'd like to add a new validator. My proposed name is DateRestrictionValidator, other suggestions welcome. This would support attributes like: invalidMonths - example: dates in April are invalid invalidDaysOfWeek - example: Saturdays and Sundays are invalid invalidDays - example: 12-25-06

Re: new validator: dateRestrictionValidator

2006-10-25 Thread Gabrielle Crawford
, when discussing an enhancement. :) -M On 10/25/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Hi, I'd like to add a new validator. My proposed name is DateRestrictionValidator, other suggestions welcome. This would support attributes like: invalidMonths - example: dates in April are invalid

Re: Formatting locale vs. translation locale

2006-10-24 Thread Gabrielle Crawford
Arjuna Wijeyekoon wrote: On 10/24/06, Adam Winer [EMAIL PROTECTED] wrote: On 10/24/06, Arjuna Wijeyekoon [EMAIL PROTECTED] wrote: I like #2 because: 1. no new public apis. Maybe I didn't explain #2: in either case, we have a new public API. There's no way to add this feature without

Re: commandNavigationItem: Propose adding a 'visited' attribute...

2006-10-17 Thread Gabrielle Crawford
+1 Jeanne Waldman wrote: +1. This sounds good to me. I've always wanted the model to control visited. Pavitra Subramaniam wrote: Hello, I would like to propose adding a 'visited' attribute to the commandNavigationItem component. This attribute is relevant only when used within the train

Re: commandNavigationItem - recommend changing 2 properties

2006-10-16 Thread Gabrielle Crawford
Hi, I have 3 thoughts about this. 1] I think navPane and breadcrumbs clearly only need 1 attribute. I actually thought they basically treat readOnly and disabled the same. 2] I can't think of a real world use case for using both attributes on train, if anyone on this list has a real world

Re: Trinidad on JDK 1.4

2006-10-11 Thread Gabrielle Crawford
-1 to having to worry about what retroweaver does and does not support, and I certainly don't want to have to check in to two branches regularly. Thanks, Gabrielle Bruno Bernard wrote: Scott, Maybe Trinidad does not work completly with Portlets but it seems to have some support. It seems

Re: [Proposal] ProcessModel changes

2006-09-29 Thread Gabrielle Crawford
turns the parent train and possibly sets the focusRowKey public abstract TrainModel getParentTrain(); // (I meant to write focusRowKey not viewId) public abstract Object getFocusRowKey (); } - Pavitra ____ From: Gabrielle Crawford [mailto:[EMAIL PROTECTED]] Se

Re: [Proposal] ProcessModel changes

2006-09-29 Thread Gabrielle Crawford
I apologize, the link I sent is to an internal Oracle server. The Trinidad javadoc is still not up, so I am using an internally generated copy of the doc. Sorry about that! Thanks, Gab Gabrielle Crawford wrote: Pavitra Subramaniam wrote: Come to think of it, we do not require

Re: [Proposal] ProcessModel changes

2006-09-28 Thread Gabrielle Crawford
Hi, Pavitra Subramaniam wrote: Can you explain 1] What this new api you are proposing looks like? - (This is just an idea and I have not thought through this completely. So read on.) - It probably will be very close to the list of all abstract methods defined in MenuModel -

Re: [Proposal] ProcessModel changes

2006-09-27 Thread Gabrielle Crawford
Pavitra Subramaniam wrote: Comments below - Pavitra - Whatever we decide to do about the autobind or rowData interface is ok with me. - But I believe that the train component should not be bound to a MenuModel for various reasons. One a train is not a menu. The name menuModel should

Re: add tags for validateLength, validateLongRange, validateDoubleRange

2006-09-26 Thread Gabrielle Crawford
implementation of this (just committed last week, improving on the original design) that hides almost all of the message attribute handling code from the validator subclasses. On 9/22/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Thanks Mike. Here's some of the pros and cons of each, if you don't

Re: add tags for validateLength, validateLongRange, validateDoubleRange

2006-09-22 Thread Gabrielle Crawford
of them would be used at a time. Is that really necessary? If you're going to make the type a value binding, you could make the message a value binding too. The other ones I glanced at only have one message attribute, even though the name varies from component to component. On 9/21/06, Gabrielle

Re: Suggested LifecycleRenderer improvement

2006-09-22 Thread Gabrielle Crawford
Adam Winer wrote: Trinidad has a LifecycleRenderer, which is an interface that can be implemented by a Renderer to let the renderer take over handling processDecodes(), processUpdates(), processValidators(). This is a big improvement if you have a smart DHTML table that lets you scroll

javadoc not generating?

2006-09-11 Thread Gabrielle Crawford
Hi, I'm pressing the javadoc link off here and it doesn't seem to be working, it's been this way for a few days at least. Is any build guru looking into this? http://incubator.apache.org/adffaces/ Thanks, Gab

Re: client js objects: prefix with Tr?

2006-09-08 Thread Gabrielle Crawford
Thanks Matthias, Gunther, I have opened an issue for this if anyone wants to comment there: https://issues.apache.org/jira/browse/ADFFACES-168 Thanks, Gabrielle Matthias Wessendorf wrote: On 9/8/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Hi, This isn't the point of this email

client js objects: prefix with Tr?

2006-09-07 Thread Gabrielle Crawford
Hi, This isn't the point of this email, but if anyone with committer status is reading this, can you uncomment the link to the client validation chapter here (I'll do it on my next patch otherwise) trinidad\src\site\xdoc\devguide\index.xml Anyway, Trinidad has some public javascript

client converters and validators - changes to the public contract

2006-08-19 Thread Gabrielle Crawford
Hi, I have a couple of filed issues that would change the contract for users writing client converters and validators. I don't think these will be controversial but I just wanted to make sure people don't have objections. The goal is that client side converters and validators are as similar

Re: java 5 compliance in jdev

2006-08-16 Thread Gabrielle Crawford
. Regards, Simon Gabrielle Crawford [EMAIL PROTECTED] 2006-08-16 12:30 Please respond to adffaces-dev To: adffaces-dev@incubator.apache.org cc: Subject:java 5 compliance in jdev Hi, I'm testing using the demo bundle and the jdev project created by running mvn

new methods on ClientConverter, ClientValidator

2006-08-08 Thread Gabrielle Crawford
Hi, I'm proposing two new methods for ClientConverter and ClientValidator in issue 17. Please let me know if there are comments or objections? https://issues.apache.org/jira/browse/ADFFACES-117 Thanks, Gabrielle - I would like

Re: PPR if PIE

2006-07-24 Thread Gabrielle Crawford
At the time the code was originally written I think PIE did not support iframes, and ppr used iframes. As far as I can remember ppr is not supported on a pda, meaning only full page refresh is supported. Thanks, Gabrielle Piyush Hari wrote: PPR does not seem to work with Pocket IE. I am

Re: Small UIXHierarchy and MenuModel decoding question

2006-07-24 Thread Gabrielle Crawford
I believe changing the currency happens in the component, not the renderer. Then decode is called on the children, meaning the command stamp. So you shouldn't need to write a decode method in the renderer if you're encoding correctly. See what navigationLevel is doing.