Hi Marc,
let me add Peter, he probably can answer your question.
Danny
Am 13.09.19 um 10:13 schrieb Marc Roos:
>
>
> How do I actually configure dovecot to use ceph for a mailbox? I have
> build the plugins as mentioned here[0]
>
> - but where do I copy/load what module?
> - can I configur
Hi,
you can find the slides here:
https://dalgaaf.github.io/Cephalocon-Barcelona-librmb/
And Wido is right, it's not production ready and we have some work ahead
to make it work with an acceptable performance atm especially in our scale.
If you have any questions don't hesitate to contact me.
Hi,
some time back we had similar discussions when we, as an email provider,
discussed to move away from traditional NAS/NFS storage to Ceph.
The problem with POSIX file systems and dovecot is that e.g. with mdbox
only around ~20% of the IO operations are READ/WRITE, the rest are
metadata IOs. Yo
Hi,
some time back we had similar discussions when we, as an email provider,
discussed to move away from traditional NAS/NFS storage to Ceph.
The problem with POSIX file systems and dovecot is that e.g. with mdbox
only around ~20% of the IO operations are READ/WRITE, the rest are
metadata IOs. Yo
;>
>>>> I just want to thank all organizers and speakers for the awesome Ceph
>>>> Day at Darmstadt, Germany yesterday.
>>>>
>>>> I learned of some cool stuff I'm eager to try out (NFS-Ganesha for
>>> RGW,
>>>> openATTIC,.
In Sydney at the OpenStack Summit Sage announced a Cephalocon for
2018.03.22-23 in Beijing (China).
Danny
Am 12.10.2017 um 13:02 schrieb Matthew Vernon:
> Hi,
>
> The recent FOSDEM CFP reminded me to wonder if there's likely to be a
> Cephalocon in 2018? It was mentioned as a possibility when th
Am 25.09.2017 um 10:00 schrieb Marc Roos:
>
>
> But from the looks of this dovecot mailinglist post, you didn’t start
> your project with talking to the dovecot guys, or have an ongoing
> communication with them during the development. I would think with that
> their experience could be a val
Am 25.09.2017 um 09:00 schrieb Marc Roos:
>
>>From the looks of it, to bad the efforts could not be
> combined/coordinated, that seems to be an issue with many open source
> initiatives.
That's not right. The plan is to contribute the librmb code to the Ceph
project and the Dovecot part back t
Am 24.09.2017 um 02:43 schrieb Timo Sirainen:
> On 22 Sep 2017, at 14.18, mj wrote:
>> First, the Github link:
>> https://github.com/ceph-dovecot/dovecot-ceph-plugin
>>
>> I am not going to repeat everything which is on Github, put a short
>> summary:
>>
>> - CephFS is used for storing Mailbox
Am 22.09.2017 um 23:56 schrieb Gregory Farnum:
> On Fri, Sep 22, 2017 at 2:49 PM, Danny Al-Gaaf
> wrote:
>> Am 22.09.2017 um 22:59 schrieb Gregory Farnum:
>> [..]
>>> This is super cool! Is there anything written down that explains this
>>> for Ceph dev
Am 22.09.2017 um 22:59 schrieb Gregory Farnum:
[..]
> This is super cool! Is there anything written down that explains this
> for Ceph developers who aren't familiar with the workings of Dovecot?
> I've got some questions I see going through it, but they may be very
> dumb.
>
> *) Why are indexes
Am 13.05.2017 um 21:28 schrieb Joao Eduardo Luis:
> On 05/13/2017 09:06 AM, John Spray wrote:
>> On Fri, May 12, 2017 at 9:45 PM, Wido den Hollander
[...]
>>> Sad to here, especially the reasoning behind it. But understandable!
>>>
>>> Let's move this event to Europe :-)
>>
>> My dining table seat
If you use os.chmod("/tmp/foo.txt", 0600) with python3 it will produce
an "SyntaxError: invalid token"
** Changed in: glance
Status: New => Invalid
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launch
#
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: New
** Changed in: glance
Assignee: (unassigned) => Danny Al-Gaaf (danny-al-gaaf)
** Description changed:
Glance should use ostestr instead of testr. ostestr is more powerful
#
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: New
** Changed in: glance
Assignee: (unassigned) => Danny Al-Gaaf (danny-al-gaaf)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which
cause is that the created virtualenv is missing some packages
defined in setup.cfg as extras for optional stores but missing those
packages in test-requirements.txt.
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: New
** Changed in: glanc
bug #1563889
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: In Progress
** Description changed:
- As the cinder rbd driver the glance_store should support to pass the
- ceph cluster name to the Rados/RBD driver while initiating a
without a blank line; unexpected unindent.
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: New
** Changed in: glance
Assignee: (unassigned) => Danny Al-Gaaf (danny-al-gaaf)
--
You received this bug notification because you are a mem
<../../configuring>`
to generate the correct link.
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: New
** Changed in: glance
Assignee: (unassigned) => Danny Al-Gaaf (danny-al-gaaf)
--
You received this bug notification be
*** This bug is a duplicate of bug 1501443 ***
https://bugs.launchpad.net/bugs/1501443
** This bug has been marked a duplicate of bug 1501443
glance_store exceptions trigger child exceptions (which break Glance's error
handling)
--
You received this bug notification because you are a mem
user.
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: New
** Changed in: glance
Assignee: (unassigned) => Danny Al-Gaaf (danny-al-gaaf)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is su
tocol, tiered, and globally distributed
storage platform with Ceph, Sage Weil, https://goo.gl/Q33K2e
- From Hardware to Application - NFV@OpenStack and Ceph, Danny Al-Gaaf,
https://goo.gl/uZZH4K
- Micro Storage Servers at multi-PetaByte scale running Ceph, Joshua
Johnson/Sage Weil, https://g
Am 25.04.2015 um 01:34 schrieb Sage Weil:
> On Fri, 24 Apr 2015, Ken Dreyer wrote:
>> Oh, my bad, sorry I missed that part of the pull request! Looks good to me.
>
> Still missing ceph.spec file changes, if you're up for it. :)
I can change the spec files, but do we have finally some user/group
Am 24.04.2015 um 22:52 schrieb Sage Weil:
> On Fri, 24 Apr 2015, Danny Al-Gaaf wrote:
>> Am 24.04.2015 um 19:37 schrieb Sage Weil:
>> [...]
>>> -- systemd --
>>>
>>> Most of the daemons can just get the User=ceph and Group=cpeh lines in the
>>&g
Am 24.04.2015 um 19:37 schrieb Sage Weil:
[...]
> -- systemd --
>
> Most of the daemons can just get the User=ceph and Group=cpeh lines in the
> unit files. The OSD is tricky, though, since we want the prestart script
> to run as root so that it can chown the disk contents if necessary. We
>
Am 10.03.2015 um 09:02 schrieb Loic Dachary:
> Hi Danny,
>
> On 10/03/2015 06:59, Danny Al-Gaaf wrote:
>> Am 10.03.2015 um 00:06 schrieb Loic Dachary:
[...]
>>>
>>> Do you know what changes have been done in hammer in src/gmock
>>> ?
>>
>&
Am 10.03.2015 um 00:06 schrieb Loic Dachary:
>
>
> On 09/03/2015 18:31, Danny Al-Gaaf wrote:
>> Hi Loic,
>>
>> this one is a tricky one. I didn't find a smooth/automatic
>> solution yet.
>>
>> This seems to work:
>>
>> git ch
Am 09.03.2015 um 20:35 schrieb Mark Nelson:
>
>
> On 03/09/2015 02:06 PM, Deneau, Tom wrote:
>> I'm trying to gather information on what it would take to get packages
>> for an architecture other than x86_64 up on http://download.ceph.com
>
> What we've done in the past for certain non-X86 archi
Hi Loic,
this one is a tricky one. I didn't find a smooth/automatic solution yet.
This seems to work:
git checkout master
git merge --no-ff origin/hammer
git mergetool
-> for the conflict: select 'local' for src/gmock (this should keep
the changes im master and ignore changes from hammer)
g
Am 05.03.2015 um 19:09 schrieb Loic Dachary:
> Hi Danny,
>
> The build of master shows linkage errors:
>
> http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-deb-trusty-amd64-basic/log.cgi?log=60e2bec73ff3970e0c6b44250ce465e6c5dde56f
>
> error: dpkg-shlibdeps: couldn't find library libgmock_ma
Am 05.03.2015 um 22:14 schrieb Loic Dachary:
> Hi Danny,
>
> Unfortunately it looks like submodule deinit requires a version of
> git that's not in precise.
>
> http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-deb-precise-amd64-basic/log.cgi?log=9a0ac62a9cf27573d5345143a3bc6c6b737031db
>
> + git
Am 04.03.2015 um 15:12 schrieb Csaba Henk:
> Hi Danny,
>
> - Original Message -
>> From: "Danny Al-Gaaf" To: "OpenStack
>> Development Mailing List (not for usage questions)"
>> , ceph-de...@vger.kernel.org
>> Sent: Sunday, Ma
Am 04.03.2015 um 15:18 schrieb Csaba Henk:
> Hi Danny,
>
> - Original Message -
>> From: "Danny Al-Gaaf"
>> To: "Deepak Shetty"
>> Cc: "OpenStack Development Mailing List (not for usage questions)"
>> ,
>> ce
Am 04.03.2015 um 15:12 schrieb Csaba Henk:
> Hi Danny,
>
> - Original Message -
>> From: "Danny Al-Gaaf" To: "OpenStack
>> Development Mailing List (not for usage questions)"
>> , ceph-devel@vger.kernel.org
>> Sent: Sunday, Ma
Am 04.03.2015 um 05:19 schrieb Deepak Shetty:
> On Wed, Mar 4, 2015 at 5:10 AM, Danny Al-Gaaf
> wrote:
>> Am 03.03.2015 um 19:31 schrieb Deepak Shetty: [...]
[...]
>>
>>> I was curious to understand. IIUC Neutron provides private and
>>> public networks a
Am 04.03.2015 um 05:19 schrieb Deepak Shetty:
> On Wed, Mar 4, 2015 at 5:10 AM, Danny Al-Gaaf
> wrote:
>> Am 03.03.2015 um 19:31 schrieb Deepak Shetty: [...]
[...]
>>
>>> I was curious to understand. IIUC Neutron provides private and
>>> public networks a
Am 03.03.2015 um 19:31 schrieb Deepak Shetty:
[...]
>> For us security is very critical, as the performance is too. The
>> first solution via ganesha is not what we prefer (to use CephFS
>> via p9 and NFS would not perform that well I guess). The second
>> solution, to use CephFS directly to the VM
Am 03.03.2015 um 19:31 schrieb Deepak Shetty:
[...]
>> For us security is very critical, as the performance is too. The
>> first solution via ganesha is not what we prefer (to use CephFS
>> via p9 and NFS would not perform that well I guess). The second
>> solution, to use CephFS directly to the VM
Am 27.02.2015 um 23:10 schrieb Sage Weil:
> This is the first release candidate for Hammer, and includes all
> of the features that will be present in the final release. We
> welcome and encourage any and all testing in non-production
> clusters to identify any problems with functionality, stabili
Am 27.02.2015 um 01:04 schrieb Sage Weil:
> [sorry for ceph-devel double-post, forgot to include
> openstack-dev]
>
> Hi everyone,
>
> The online Ceph Developer Summit is next week[1] and among other
> things we'll be talking about how to support CephFS in Manila. At
> a high level, there are ba
Am 27.02.2015 um 01:04 schrieb Sage Weil:
> [sorry for ceph-devel double-post, forgot to include
> openstack-dev]
>
> Hi everyone,
>
> The online Ceph Developer Summit is next week[1] and among other
> things we'll be talking about how to support CephFS in Manila. At
> a high level, there are ba
Hi Jay,
do you have a link to the etherpad?
Danny
Am 13.02.2015 um 05:54 schrieb Jay S. Bryant:
> All,
>
> Several members of the Cinder team and I were discussing the
> current state of volume replication while trying to figure out the
> best way to resolve bug 1383524 [1]. The outcome of the
Am 11.02.2015 um 04:10 schrieb Ben Swartzlander:
>> https://etherpad.openstack.org/p/manila-kilo-midcycle-meetup
>
> This is a reminder that the meetup is tomorrow! It will be entirely
> virtual, so please join the Google Hangout or the phone bridge. The
> details are in the etherpad.
Do you have
Am 09.01.2015 um 16:26 schrieb Sage Weil:
> On Fri, 9 Jan 2015, scan-ad...@coverity.com wrote:
>> ** CID 1262114: Uninitialized scalar field (UNINIT_CTOR)
>> /messages/MOSDRepOp.h: 107 in MOSDRepOp::MOSDRepOp()()
>>
>> ** CID 1262115: Uninitialized scalar field (UNINIT_CTOR)
>> /messages/MOS
Hi,
these can be ignored, they are caused by the ASSERT_* handling of the
gtest framework.
Danny
Am 28.10.2014 um 14:16 schrieb scan-ad...@coverity.com:
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to ceph
> found with Coverity Scan.
>
> 2 new defect(s) introduced to
Am 24.10.2014 um 07:35 schrieb Jens Axboe:
> CC'ing relevant parties, leaving email intact.
>
I'll take a look at it.
@Jens: I removed Daniel from the thread since his email is no longer valid.
Regards,
Danny
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a me
Hi all,
I've added some new blueprints for Hammer:
* Ceph Security
https://wiki.ceph.com/Planning/Blueprints/Hammer/Ceph_Security
* How to make Ceph enterprise ready:
https://wiki.ceph.com/Planning/Blueprints/Hammer/How_to_make_Ceph_enterprise_ready
* rados: improve ex-/import functionality
, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
** Affects: glance
Importance: Undecided
Assignee: Danny Al-Gaaf (danny-al-gaaf)
Status: In Progress
** Changed in: glance
Assignee: (unassigned) => Danny Al-Gaaf (danny-al-gaaf)
** Changed in: gla
rote:
>> Have I mentioned how exciting that is?
>>
>> Mark
>>
>>
>> On 04/30/2014 04:14 PM, Samuel Just wrote:
>>>
>>> Cool. Looks like we read the same guide on the autotools bit :P. I'm
>>> focusing on instrumenting the
Am 03.06.2014 20:55, schrieb Sushma R:
> Haomai,
>
> I'm using the latest ceph master branch.
>
> ceph_smalliobench is a Ceph internal benchmarking tool similar to rados
> bench and the performance is more or less similar to that reported by fio.
>
> I tried to use fio with rbd ioengine (
> http
Am 03.06.2014 20:55, schrieb Sushma R:
> Haomai,
>
> I'm using the latest ceph master branch.
>
> ceph_smalliobench is a Ceph internal benchmarking tool similar to rados
> bench and the performance is more or less similar to that reported by fio.
>
> I tried to use fio with rbd ioengine (
> http
Am 30.04.2014 23:00, schrieb Jens Axboe:
> On 04/30/2014 12:48 PM, Danny Al-Gaaf wrote:
>> Replace include of time.h with renamed fio_time.h to fix build.
>
> Thanks Danny, applied. Mine still builds fine, for some odd reason...
> But it of course needs fixing.
>
It
Am 30.04.2014 14:18, schrieb Sage Weil:
> Today we are announcing some very big news: Red Hat is acquiring Inktank.
> We are very excited about what this means for Ceph, the community, the
> team, our partners, and our customers. Ceph has come a long way in the ten
> years since the first line o
Am 30.04.2014 14:18, schrieb Sage Weil:
> Today we are announcing some very big news: Red Hat is acquiring Inktank.
> We are very excited about what this means for Ceph, the community, the
> team, our partners, and our customers. Ceph has come a long way in the ten
> years since the first line o
Replace include of time.h with renamed fio_time.h to fix build.
Signed-off-by: Danny Al-Gaaf
---
crc/test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crc/test.c b/crc/test.c
index 2cc7c0f..3773b71 100644
--- a/crc/test.c
+++ b/crc/test.c
@@ -4,7 +4,7 @@
#include
Am 30.04.2014 04:21, schrieb Haomai Wang:
> So cool!
>
> I remember a telekomcloud guy is also worked for it since last summit.
Correct ... our initial version is/was this:
https://github.com/dalgaaf/ceph/commits/wip-master-bp-systemtap
Danny
> On Wed, Apr 30, 2014 at 6:17 AM, Samuel Just wrot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Am 07.03.2014 18:27, schrieb Michael J. Kidd:
[...]
> * I've not seen any documentation on each counter, aside from
> occasional mailing list posts about specific counters..
>
[...]
>> One additional question, are these latency values in
>> milli
Hi,
Am 28.02.2014 03:45, schrieb Haomai Wang:
[...]
> I use fio which rbd supported from
> TelekomCloud(https://github.com/TelekomCloud/fio/commits/rbd-engine)
> to test rbd.
I would recommend to no longer use this branch, it's outdated. The rbd
engine got contributed back to upstream fio and is
Hi,
Am 28.02.2014 03:45, schrieb Haomai Wang:
[...]
> I use fio which rbd supported from
> TelekomCloud(https://github.com/TelekomCloud/fio/commits/rbd-engine)
> to test rbd.
I would recommend to no longer use this branch, it's outdated. The rbd
engine got contributed back to upstream fio and is
Hi Sage,
since firefly is frozen and the task is now to focus on stabilization:
how do you plan to handle it on the coverity side?
Is Coverity able use the firefly branch instead of master to get
everything checked on regular bases for the next stable release?
The last Coverity check was Jan 22,
Am 06.11.2013 15:05, schrieb Gautam Saxena:
> We're looking to deploy CEPH on about 8 Dell servers to start, each of
> which typically contain 6 to 8 harddisks with Perc RAID controllers which
> support write-back cache (~512 MB usually). Most machines have between 32
> and 128 GB RAM. Our question
Am 18.10.2013 11:20, schrieb hjwsm1989-gmail:
> Hi,all
> I get ceph from g...@github.com:ceph/ceph.git
> But when I try to build rpm package from the master branch,
> It runs error like : No target to Make.
> I found there are no file or dirs under src/libs3/ in my mater and next
> branch.(all my b
Am 17.10.2013 22:29, schrieb Andrew Woodward:
> We need to have a reasonable license on this preferably Apache 2.0.
> the enovance module is AGPL which can't come in contact with nearly
> anything with out causing massive license issues. Starting with any of
> the enovance code is a Non-starter as
Hi,
I've overseen this call, sorry. Is there any meeting results or a log?
I asked because we (Deutsche Telekom AG) forked our puppet-ceph module
from the enovance puppet-ceph (deploying ceph without ceph-deploy) and
we plan to contribute our code back to the community into the source
project.
Y
Hi,
I've opened a pull request with some additional fixes for this issue:
https://github.com/ceph/ceph/pull/478
Danny
Am 30.07.2013 09:53, schrieb Erik Logtenberg:
> Hi,
>
> This patch adds two buildrequires to the ceph.spec file, that are needed
> to build the rpms under Fedo
Hi,
I've opened a pull request with some additional fixes for this issue:
https://github.com/ceph/ceph/pull/478
Danny
Am 30.07.2013 09:53, schrieb Erik Logtenberg:
> Hi,
>
> This patch adds two buildrequires to the ceph.spec file, that are needed
> to build the rpms under Fedo
t;
> Erik.
>
>
> On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote:
>> Hi,
>>
>> I think this is a bug in packaging of the leveldb package in this case
>> since the spec-file already sets dependencies on on leveldb-devel.
>>
>> leveldb depends on snappy,
t;
> Erik.
>
>
> On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote:
>> Hi,
>>
>> I think this is a bug in packaging of the leveldb package in this case
>> since the spec-file already sets dependencies on on leveldb-devel.
>>
>> leveldb depends on snappy,
Hi,
I think this is a bug in packaging of the leveldb package in this case
since the spec-file already sets dependencies on on leveldb-devel.
leveldb depends on snappy, therefore the leveldb package should set a
dependency on snappy-devel for leveldb-devel (check the SUSE spec file
for leveldb:
h
Hi,
I think this is a bug in packaging of the leveldb package in this case
since the spec-file already sets dependencies on on leveldb-devel.
leveldb depends on snappy, therefore the leveldb package should set a
dependency on snappy-devel for leveldb-devel (check the SUSE spec file
for leveldb:
h
Hi Sage,
no problem I'll review the pull request.
Danny
Am 03.07.2013 07:12, schrieb Sage Weil:
> Hi Danny,
>
> Can you review wip-5492? The original ceph_sbindir was introduced by your
> patch fixing up python install locations,
> 4d16f38f48e276497190c8bc03abc55c40e18eed.
>
> http://tracke
Hi Sage,
I would like to take a look at the issues.
Danny
Am 09.05.2013 18:26, schrieb Sage Weil:
> We were added to coverity's awesome scan program a while back, which gives
> free access to their static analysis tool to open source projects.
>
> Currently it identifies 421 issues. We've alr
Hi Sage,
cloud someone please update also the "Mailing lists & IRC" webpage at
ceph.com (http://ceph.com/resources/mailing-list-irc/)?
The issues are:
- ceph-commit: points still to ceph-com...@lists.ceph.newdream.net
Note: you may need to add a link to the old archives or you need to
merge t
Am 10.02.2013 06:57, schrieb Sage Weil:
> On Thu, 7 Feb 2013, Danny Al-Gaaf wrote:
>> Fix "variable length array of non-POD element type" errors caused by
>> using librados::ObjectWriteOperation VLAs. (-Wvla)
>>
>> Signed-off-by: Danny Al-Gaaf
>> ---
>
Am 10.02.2013 07:02, schrieb Sage Weil:
> Hey Danny-
>
> These look good, modulo those 2 comments. Do you have a public git tree
> with these patches I can cherry-pick or pull from? It's a bit faster than
> yanking them off the list for merge (although posting to the list for
> review is stil
Am 10.02.2013 07:04, schrieb Sage Weil:
> On Fri, 8 Feb 2013, Danny Al-Gaaf wrote:
[...]
>>//dout(5) << "SyntheticClient::write_fd: writing to fd " << fd << dendl;
>> - if (fd < 0) return fd;
>> + if (fd < 0) {
>> +retur
buf
---
v2: - fix order in two cases
Signed-off-by: Danny Al-Gaaf
---
src/client/SyntheticClient.cc | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/client/SyntheticClient.cc b/src/client/SyntheticClient.cc
index b2a936f..0da8bed 100644
--- a/src/cli
Am 08.02.2013 17:25, schrieb Danny Al-Gaaf:
> Fix some memory leaks in case of error handling due to failed
> client->open() calls.
>
> Error from cppcheck was:
> [src/client/SyntheticClient.cc:1980]: (error) Memory leak: buf
> [src/client/SyntheticClient.cc:2040]: (error) Me
Fix error from cppcheck:
[src/common/fiemap.cc:73]: (error) Common realloc mistake: 'fiemap'
nulled but not freed upon failure
Signed-off-by: Danny Al-Gaaf
---
src/common/fiemap.cc | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/common/fiemap.cc b/
buf
Signed-off-by: Danny Al-Gaaf
---
src/client/SyntheticClient.cc | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/client/SyntheticClient.cc b/src/client/SyntheticClient.cc
index b2a936f..0da8bed 100644
--- a/src/client/SyntheticClient.cc
+++ b/src/cli
Fix error from cppcheck:
[src/rgw/rgw_xml.cc:212]: (error) Common realloc mistake: 'buf'
nulled but not freed upon failure
Signed-off-by: Danny Al-Gaaf
---
src/rgw/rgw_xml.cc | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/rgw/rgw_xml.cc
Here some patches to fix memory leaks in Ceph found by cppcheck.
Danny Al-Gaaf (6):
common/fiemap.cc: fix realloc memory leak
os/FileStore.cc: fix realloc memory leak in error case
rgw/rgw_xml.cc: fix realloc memory leak in error case
wireshark: fix some memory leaks
SyntheticClient.cc
Fix error from cppcheck:
[src/os/FileStore.cc:512]: (error) Common realloc mistake: 'fiemap'
nulled but not freed upon failure
Signed-off-by: Danny Al-Gaaf
---
src/os/FileStore.cc | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/os/FileStore.c
Fix 4K memory leak in case RGWClientIO::read() fails in
read_all_chunked_input().
Error from cppcheck was:
Checking src/rgw/rgw_rest.cc...
[src/rgw/rgw_rest.cc:688]: (error) Memory leak: data
Signed-off-by: Danny Al-Gaaf
---
src/rgw/rgw_rest.cc | 4 +++-
1 file changed, 3 insertions(+), 1
Fix some memory leaks in packet-ceph.c. Error from cppcheck was:
[wireshark/ceph/packet-ceph.c:215]: (error) Memory leak: plop
[wireshark/ceph/packet-ceph.c:237]: (error) Memory leak: plop
[wireshark/ceph/packet-ceph.c:543]: (error) Memory leak: fsid_dec
Signed-off-by: Danny Al-Gaaf
Fix "(performance) Function parameter 'e' should be passed by reference."
from cppchecker.
Signed-off-by: Danny Al-Gaaf
---
src/osd/osd_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/osd/osd_types.h b/src/osd/osd_types.h
index e068057..b193
checking for
'objects' emptiness.
Signed-off-by: Danny Al-Gaaf
---
src/osd/PG.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/osd/PG.h b/src/osd/PG.h
index ba80f81..3c95058 100644
--- a/src/osd/PG.h
+++ b/src/osd/PG.h
@@ -596,7 +596,7 @@ protected:
/
Fix "(performance) Function parameter 'm' should be passed by reference."
from cppchecker.
Signed-off-by: Danny Al-Gaaf
---
src/msg/Messenger.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/msg/Messenger.h b/src/msg/Messenger.h
index b75e442..f47c
checking for
'last_scrub_pg' emptiness.
[osd/OSD.h:274]: (performance) Possible inefficient checking for
'last_scrub_pg' emptiness.
Signed-off-by: Danny Al-Gaaf
---
src/osd/OSD.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/osd/OSD.h b/src/osd
Fix warning from clang(++):
librados/librados.cc:15:17: warning: using directive refers to
implicitly-defined namespace 'std'
using namespace std;
^
Include what we need and use the related classes.
Signed-off-by: Danny Al-Gaaf
---
src/librados/librad
Fix warning from clang(++):
test/mon/test_mon_workloadgen.cc:311:23: warning: in-class
initializer for static data member of type 'const double' is
a GNU extension [-Wgnu]
Signed-off-by: Danny Al-Gaaf
---
src/test/mon/test_mon_workloadgen.cc | 3 ++-
1 file changed, 2 insert
Fix "Function parameter 'm' should be passed by reference." from cppchecker.
Signed-off-by: Danny Al-Gaaf
---
src/msg/msg_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/msg/msg_types.h b/src/msg/msg_types.h
index 8f3d74b..e80639e 100644
--- a
:97]: (performance) Possible inefficient
checking for 'queue' emptiness.
Signed-off-by: Danny Al-Gaaf
---
src/common/WorkQueue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h
index b19a6a2..ced952c 100644
--- a/src/common/Work
]: (performance) Possible inefficient
checking for 'queue' emptiness.
Signed-off-by: Danny Al-Gaaf
---
src/common/AsyncReserver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/AsyncReserver.h b/src/common/AsyncReserver.h
index 8cc2258..638bfb3 100644
--- a/
Fix "variable length array of non-POD element type" errors caused by
using librados::ObjectWriteOperation VLAs. (-Wvla)
Signed-off-by: Danny Al-Gaaf
---
src/key_value_store/kv_flat_btree_async.cc | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff -
Fix "(performance) Function parameter 's' should be passed by reference."
from cppchecker.
Signed-off-by: Danny Al-Gaaf
---
src/log/Entry.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/log/Entry.h b/src/log/Entry.h
index 7f6b149..7cdf116 100644
-
Remove unused variable to fix:
mon/PGMonitor.cc:170:11: warning: unused variable 'now'
[-Wunused-variable]
Signed-off-by: Danny Al-Gaaf
---
src/mon/PGMonitor.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mon/PGMonitor.cc b/src/mon/PGMonitor.cc
index 7e9b83b..f34ffb8 10
Here another set of patches to fix issues found by clang/clang++
and cppchecker.
Danny Al-Gaaf (15):
kv_flat_btree_async.cc: use vector instead of VLA's
common/config.h: declaration of config_option as struct
src/msg/msg_types.h: pass function parameter by reference
fuse_ll.cc: fix
Fix 'struct ceph_file_layout g_default_file_layout' related
-Wgnu-designator warning from clang(++):
common/config.cc:61:2: warning: use of GNU old-style field
designator extension [-Wgnu-designator]
Signed-off-by: Danny Al-Gaaf
---
src/common/config.cc | 14 +++---
1 file
Fix 'const static struct fuse_lowlevel_ops fuse_ll_oper' related
-Wgnu-designator warning from clang(++):
client/fuse_ll.cc:537:2: warning: use of GNU old-style field
designator extension [-Wgnu-designator]
Signed-off-by: Danny Al-Gaaf
---
src/client/fuse_
1 - 100 of 221 matches
Mail list logo
