[jira] [Commented] (LUCENE-10236) CombinedFieldsQuery to use fieldAndWeights.values() when constructing MultiNormsLeafSimScorer for scoring

2022-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545527#comment-17545527 ] David Smiley commented on LUCENE-10236: --- If this is a "improvement", then I think it doesn't go

[jira] [Resolved] (SOLR-11745) SolrCore doesn't log core if too many closes called on it

2022-05-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-11745. - Fix Version/s: 9.0 Resolution: Fixed Fixed via the linked issue it's superseded by. >

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-05-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542685#comment-17542685 ] David Smiley commented on SOLR-14699: - We agree on ease of parsepability but disagree that some

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-05-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542664#comment-17542664 ] David Smiley commented on SOLR-14699: - [~nazerke], I think you proposed {{logid}} because you are

[jira] [Resolved] (SOLR-16210) Lift Configuration Change to Correct failing Lift Tools

2022-05-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16210. - Resolution: Fixed > Lift Configuration Change to Correct failing Lift Tools >

[jira] [Commented] (SOLR-16210) Lift Configuration Change to Correct failing Lift Tools

2022-05-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541646#comment-17541646 ] David Smiley commented on SOLR-16210: - Thanks. BTW a JIRA issue isn't needed for this. I suppose we

[jira] [Commented] (SOLR-14251) Shard Split on HDFS

2022-05-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541586#comment-17541586 ] David Smiley commented on SOLR-14251: - NodeStateProviders can be considered deprecated, BTW.

[jira] [Resolved] (LUCENE-8519) MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8519. -- Fix Version/s: 9.3 Resolution: Fixed Thanks for contributing Rushabh! >

[jira] [Commented] (SOLR-14569) Configuring a shardHandlerFactory on the /select requestHandler results in HTTP 401 when searching on alias in secured Solr

2022-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540441#comment-17540441 ] David Smiley commented on SOLR-14569: - Random question: What's the purpose in configuring a

[jira] [Commented] (SOLR-16205) Span operationName for v2 APIs should include collection/core names

2022-05-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539794#comment-17539794 ] David Smiley commented on SOLR-16205: - I don't have a strong opinion, but I suppose my preference is

[jira] [Commented] (SOLR-16143) SolrConfig ResourceProvider can miss updates from ZooKeeper

2022-05-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537725#comment-17537725 ] David Smiley commented on SOLR-16143: - bq. A learning I got is that we should use Curator instead of

[jira] [Updated] (SOLR-16143) SolrConfig ResourceProvider can miss updates from ZooKeeper

2022-05-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16143: Affects Version/s: 8.9 > SolrConfig ResourceProvider can miss updates from ZooKeeper >

[jira] [Commented] (SOLR-16143) SolrConfig ResourceProvider can miss updates from ZooKeeper

2022-05-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537316#comment-17537316 ] David Smiley commented on SOLR-16143: - This issue is categorized as a test but I suppose it is in

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-05-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535113#comment-17535113 ] David Smiley commented on SOLR-14699: - The JSON idea is alluring, even if it adds a bit more syntax.

[jira] [Commented] (SOLR-16104) Test failure in TestCoreDiscovery.testTooManyTransientCores

2022-05-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531934#comment-17531934 ] David Smiley commented on SOLR-16104: - I'll look for sure; if I introduce bugs, I should fix them.

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-05-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531788#comment-17531788 ] David Smiley commented on SOLR-14699: - [~jbernste] not sure if you have an opinion here. I ask

[jira] [Commented] (SOLR-16176) Reproducing failure in TestCloudJSONFacetSKGEquiv.testRandom

2022-05-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530980#comment-17530980 ] David Smiley commented on SOLR-16176: - It's great to see the randomized testing methodology catch

[jira] [Commented] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-04-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529003#comment-17529003 ] David Smiley commented on SOLR-15045: - Yes; I'd do both the JIRA issue & CHANGES.txt > 2x latency of

[jira] [Resolved] (SOLR-13044) IndexFetcher.openNewSearcherAndUpdateCommitPoint can throw NPE on null SolrCore

2022-04-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13044. - Fix Version/s: 9.1 Assignee: David Smiley Resolution: Fixed >

[jira] [Resolved] (SOLR-16145) Overseer rejoinOverseerElection NPE

2022-04-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16145. - Fix Version/s: 9.1 Resolution: Fixed > Overseer rejoinOverseerElection NPE >

[jira] [Updated] (SOLR-14920) Format Java code automatically and enforce it in Solr

2022-04-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14920: Fix Version/s: 9.0 (was: 9.1) I'm marking this as 9.0 because the very vast

[jira] [Commented] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527776#comment-17527776 ] David Smiley commented on SOLR-15045: - In CHANGES.txt, you've classified this as a bug. Perhaps it

[jira] [Updated] (SOLR-16145) Overseer rejoinOverseerElection NPE

2022-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16145: Affects Version/s: 7.7.2 > Overseer rejoinOverseerElection NPE >

[jira] [Commented] (SOLR-16158) Separate Solr Embedded from solr-core

2022-04-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524715#comment-17524715 ] David Smiley commented on SOLR-16158: - (assuming we want to do this at all) Yeah I tend to agree with

[jira] [Commented] (SOLR-16153) Clone Collection

2022-04-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521707#comment-17521707 ] David Smiley commented on SOLR-16153: - Yes; I definitely want to ensure that the Directory

[jira] [Commented] (SOLR-16153) Clone Collection

2022-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521347#comment-17521347 ] David Smiley commented on SOLR-16153: - I guess we needn't bother with

[jira] [Commented] (SOLR-16153) Clone Collection

2022-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521345#comment-17521345 ] David Smiley commented on SOLR-16153: - I imagine a sub-task would be a core level clone -- a new Core

[jira] [Commented] (SOLR-5784) Solr create collection can support clone, and alias can support add collection function

2022-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521255#comment-17521255 ] David Smiley commented on SOLR-5784: This issue is really two very distinct issues / ideas. I've

[jira] [Created] (SOLR-16153) Clone Collection

2022-04-12 Thread David Smiley (Jira)
David Smiley created SOLR-16153: --- Summary: Clone Collection Key: SOLR-16153 URL: https://issues.apache.org/jira/browse/SOLR-16153 Project: Solr Issue Type: New Feature Security Level:

[jira] [Commented] (SOLR-16148) Tika / Solr Cell documentation needs to use techproducts

2022-04-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520552#comment-17520552 ] David Smiley commented on SOLR-16148: - The error you show in the description would not lead me to

[jira] [Commented] (SOLR-13044) IndexFetcher.openNewSearcherAndUpdateCommitPoint can throw NPE on null SolrCore

2022-04-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519177#comment-17519177 ] David Smiley commented on SOLR-13044: - I merely observed it in a test where it was clear based on

[jira] [Commented] (SOLR-13044) IndexFetcher.openNewSearcherAndUpdateCommitPoint can throw NPE on null SolrCore

2022-04-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518581#comment-17518581 ] David Smiley commented on SOLR-13044: - I think the right thing to do is simply do nothing.

[jira] [Commented] (SOLR-13410) Designated overseer not able to become overseer quickly

2022-04-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518574#comment-17518574 ] David Smiley commented on SOLR-13410: - There's an obvious NPE risk that can happen in the code

[jira] [Created] (SOLR-16145) Overseer rejoinOverseerElection NPE

2022-04-06 Thread David Smiley (Jira)
David Smiley created SOLR-16145: --- Summary: Overseer rejoinOverseerElection NPE Key: SOLR-16145 URL: https://issues.apache.org/jira/browse/SOLR-16145 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514825#comment-17514825 ] David Smiley commented on SOLR-15045: - No; go for it! > 2x latency of synchronous commits due to

[jira] [Commented] (SOLR-16111) hl.queryFieldPattern support (advanced alternative to hl.requireFieldMatch)

2022-03-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513672#comment-17513672 ] David Smiley commented on SOLR-16111: - Can this be used to solve

[jira] [Updated] (LUCENE-10454) UnifiedHighlighter can miss terms because of query rewrites

2022-03-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-10454: -- Status: Open (was: Open) WeightMatches is the default as of 9.0: LUCENE-9431 -- the

[jira] [Updated] (LUCENE-10454) UnifiedHighlighter can miss terms because of query rewrites

2022-03-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-10454: -- Attachment: LUCENE-10454-fix.patch > UnifiedHighlighter can miss terms because of query

[jira] [Resolved] (SOLR-15223) Deprecate Apache-HttpClient, refactor CloudSolrClient to use jetty-httpclient

2022-03-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15223. - Resolution: Fixed > Deprecate Apache-HttpClient, refactor CloudSolrClient to use

[jira] [Assigned] (SOLR-8156) RequestHandlerBase.handleRequest logs stacktraces caused by user requests

2022-03-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-8156: -- Assignee: David Smiley > RequestHandlerBase.handleRequest logs stacktraces caused by user

[jira] [Commented] (SOLR-12885) BinaryResponseWriter (javabin format) should directly copy from Bytesref to output

2022-03-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510103#comment-17510103 ] David Smiley commented on SOLR-12885: - I really appreciate the addition of the dynamicFieldCache

[jira] [Resolved] (SOLR-12336) Remove Filter from Solr

2022-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-12336. - Resolution: Fixed > Remove Filter from Solr > --- > > Key:

[jira] [Resolved] (SOLR-16061) Decouple CloudSolrClient from ZkStateReader

2022-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16061. - Assignee: David Smiley Resolution: Fixed > Decouple CloudSolrClient from ZkStateReader >

[jira] [Commented] (SOLR-16061) Decouple CloudSolrClient from ZkStateReader

2022-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508783#comment-17508783 ] David Smiley commented on SOLR-16061: - Indeed; I stopped short when the communication above happened,

[jira] [Resolved] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2022-03-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15051. - Resolution: Won't Fix Maybe Bruno could put it on his fork as he crafted all or nearly all that

[jira] [Commented] (SOLR-16061) Decouple CloudSolrClient from ZkStateReader

2022-03-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507178#comment-17507178 ] David Smiley commented on SOLR-16061: - For me, It's A & C. If there will be a 8.11.2 then fine; I'll

[jira] [Commented] (SOLR-15223) Deprecate HttpSolrClient and friends in 9.0

2022-03-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17505449#comment-17505449 ] David Smiley commented on SOLR-15223: - Now that I'm "seeing" the results of this in my IDE, seeing

[jira] [Resolved] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2022-03-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14401. - Resolution: Fixed > "distrib" request handler metrics should only be tracked on pertinent

[jira] [Commented] (SOLR-16061) Decouple CloudSolrClient from ZkStateReader

2022-03-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17505295#comment-17505295 ] David Smiley commented on SOLR-16061: - I believe I addressed all remaining issues. If there is a

[jira] [Commented] (SOLR-16073) totalTime metric should be milliseconds (not nano)

2022-03-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504723#comment-17504723 ] David Smiley commented on SOLR-16073: - "mean" as well (according to what I quoted). I really should

[jira] [Commented] (SOLR-16073) totalTime metric should be milliseconds (not nano)

2022-03-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504722#comment-17504722 ] David Smiley commented on SOLR-16073: - Correct -- just Prometheus config because their advise

[jira] [Resolved] (SOLR-16073) totalTime metric should be milliseconds (not nano)

2022-03-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16073. - Resolution: Invalid _(Palm-to-face)_ Seeing NanoTimeTimerImpl.elapsed iml now, I see it's in

[jira] [Resolved] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

2022-03-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14290. - Resolution: Fixed > Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x >

[jira] [Commented] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

2022-03-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504003#comment-17504003 ] David Smiley commented on SOLR-14290: - Attached PR is trivial.  Am I missing something? > Fix NPE in

[jira] [Assigned] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

2022-03-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-14290: --- Assignee: David Smiley (was: Gus Heck) > Fix NPE in SolrTestCaseJ4 breaking external usage

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2022-03-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503081#comment-17503081 ] David Smiley commented on SOLR-15730: - In 9.x we can continue to have the solr-solrj jar dependency

[jira] [Commented] (SOLR-16072) Metrics: solr.jetty disappeared in 9

2022-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501631#comment-17501631 ] David Smiley commented on SOLR-16072: - Got it but my recommendation (a text file of file names in the

[jira] [Commented] (SOLR-16074) Reproducible failure TestReplicationHandler.doTestStressReplication

2022-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501543#comment-17501543 ] David Smiley commented on SOLR-16074: - Congrats on finding the cause here!  A week ago I saw this

[jira] [Commented] (SOLR-16072) Metrics: solr.jetty disappeared in 9

2022-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501508#comment-17501508 ] David Smiley commented on SOLR-16072: - I'm imagining a machine generated text file listing every file

[jira] [Commented] (SOLR-15984) Ensure all used dependencies are declared

2022-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501505#comment-17501505 ] David Smiley commented on SOLR-15984: - This caused SOLR-16072; for those following here but didn't

[jira] [Commented] (SOLR-16072) Metrics: solr.jetty disappeared in 9

2022-03-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501503#comment-17501503 ] David Smiley commented on SOLR-16072: - {quote}Does metrics-jetty9 need to be in WEB-INF/lib {quote}

[jira] [Commented] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2022-03-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500954#comment-17500954 ] David Smiley commented on SOLR-14401: - Thanks for looking Jan! Notice the PR removes the prometheus

[jira] [Created] (SOLR-16073) totalTime metric should be milliseconds (not nano)

2022-03-03 Thread David Smiley (Jira)
David Smiley created SOLR-16073: --- Summary: totalTime metric should be milliseconds (not nano) Key: SOLR-16073 URL: https://issues.apache.org/jira/browse/SOLR-16073 Project: Solr Issue Type:

[jira] [Commented] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2022-03-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500803#comment-17500803 ] David Smiley commented on LUCENE-10302: --- I attached my WIP as a patch file. Looking back, I

[jira] [Updated] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2022-03-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-10302: -- Attachment: LUCENE_PriorityQueue_Builder_with_heapify.patch > PriorityQueue: optimize where

[jira] [Commented] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2022-03-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500766#comment-17500766 ] David Smiley commented on SOLR-14401: - My proposed changes text is: {quote} SOLR-14401: Metrics: Only

[jira] [Commented] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2022-03-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500497#comment-17500497 ] David Smiley commented on SOLR-14401: - There are ripple effects of this on our default prometheus

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500418#comment-17500418 ] David Smiley commented on SOLR-14920: - I definitely think the scope should include formatting our XML

[jira] [Created] (SOLR-16072) Metrics: solr.jetty disappeared in 9

2022-03-02 Thread David Smiley (Jira)
David Smiley created SOLR-16072: --- Summary: Metrics: solr.jetty disappeared in 9 Key: SOLR-16072 URL: https://issues.apache.org/jira/browse/SOLR-16072 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-16061) Decouple CloudSolrClient from ZkStateReader

2022-03-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499548#comment-17499548 ] David Smiley commented on SOLR-16061: - [~haythem] please create a PR for this and push your work. >

[jira] [Commented] (SOLR-16013) Overseer gives up election node before closing - inflight commands can be processed twice

2022-02-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498703#comment-17498703 ] David Smiley commented on SOLR-16013: - This may be cold comfort but I suppose this problem is

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498200#comment-17498200 ] David Smiley commented on SOLR-14920: - Why not 9_0? I think we should have all of 9 follow this new

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497797#comment-17497797 ] David Smiley commented on SOLR-14920: - [~erickerickson] Sometimes the reformatted code shows

[jira] [Commented] (SOLR-3955) Return only matched multiValued field

2022-02-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496374#comment-17496374 ] David Smiley commented on SOLR-3955: highlighting returns the stored values. I'm not sure how sorting

[jira] [Resolved] (SOLR-15964) Transient cores should not be unloaded/evicted while it's being used

2022-02-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15964. - Resolution: Fixed > Transient cores should not be unloaded/evicted while it's being used >

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495769#comment-17495769 ] David Smiley commented on SOLR-14920: - Can we do one PR for the updates to .git-blame-ignore-revs as

[jira] [Commented] (SOLR-15342) Separate out a SolrJ-Zookeeper module

2022-02-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495682#comment-17495682 ] David Smiley commented on SOLR-15342: - Perhaps the API changes on CloudSolrClient should be its own

[jira] [Commented] (SOLR-3955) Return only matched multiValued field

2022-02-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495603#comment-17495603 ] David Smiley commented on SOLR-3955: try highlighting and let us know how it is? > Return only

[jira] [Resolved] (SOLR-15064) Atomic/partial updates to nested docs should not assume _route_ param is the root ID

2022-02-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15064. - Resolution: Fixed > Atomic/partial updates to nested docs should not assume _route_ param is the

[jira] [Commented] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495538#comment-17495538 ] David Smiley commented on SOLR-15983: - [~cpoerschke] next time, please clean up the commit message

[jira] [Commented] (SOLR-14610) ReflectMapWriter to use VarHandle instead of old legacy reflection

2022-02-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495326#comment-17495326 ] David Smiley commented on SOLR-14610: - [~noble.paul] please close the issue and reflect the right

[jira] [Commented] (SOLR-15904) Move SQLHandler to a module/package

2022-02-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495084#comment-17495084 ] David Smiley commented on SOLR-15904: - Come to think of it, if SolrJ has tests depending on SQL then

[jira] [Commented] (SOLR-15904) Move SQLHandler to a module/package

2022-02-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495024#comment-17495024 ] David Smiley commented on SOLR-15904: - We can declare this handler as {{"startup": "lazy"}} in

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494998#comment-17494998 ] David Smiley commented on SOLR-14920: - I don't think we need a Jira issue per module but a PR per

[jira] [Commented] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2022-02-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494892#comment-17494892 ] David Smiley commented on SOLR-14401: - In my PR, I did something a bit different than what I said

[jira] [Commented] (SOLR-6237) An option to have only leaders write and replicas read when using a shared file system with SolrCloud.

2022-02-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494625#comment-17494625 ] David Smiley commented on SOLR-6237: I nearly forgot about this issue. At the time this was filed,

[jira] [Commented] (SOLR-14928) Remove Overseer ClusterStateUpdater

2022-02-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494328#comment-17494328 ] David Smiley commented on SOLR-14928: - I rather wish this new mode was the default in 9. > Remove

[jira] [Commented] (SOLR-16012) Remove mapParams from StreamingTest and TestSQLHandler

2022-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492945#comment-17492945 ] David Smiley commented on SOLR-16012: - cool but BTW didn't need a JIRA > Remove mapParams from

[jira] [Resolved] (SOLR-575) Highlighting spans should merge across phrase query

2022-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-575. --- Resolution: Fixed Closing because the UnifiedHighlighter does this in its default mode

[jira] [Closed] (SOLR-575) Highlighting spans should merge across phrase query

2022-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-575. - > Highlighting spans should merge across phrase query > --- >

[jira] [Commented] (SOLR-15904) Move SQLHandler to a module/package

2022-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492331#comment-17492331 ] David Smiley commented on SOLR-15904: - BTW, Jan created some script to help modularize stuff. Was

[jira] [Commented] (SOLR-15904) Move SQLHandler to a module/package

2022-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492330#comment-17492330 ] David Smiley commented on SOLR-15904: - I'm so glad you are taking this up! Perhaps ImplicitPlugins

[jira] [Commented] (SOLR-15066) DocBasedVersionConstraintsProcessor should only fetch the fields it needs from RTG

2022-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492168#comment-17492168 ] David Smiley commented on SOLR-15066: - Also perhaps in this same issue: don't require that the field

[jira] [Resolved] (SOLR-15949) Use Java 17 in docker

2022-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15949. - Resolution: Fixed > Use Java 17 in docker > - > > Key:

[jira] [Resolved] (SOLR-14800) Filter default score should be the provided boost, not zero

2022-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14800. - Resolution: Won't Fix After looking at this some more, I'm closing this as Won't-Fix. The

[jira] [Commented] (SOLR-14800) Filter default score should be the provided boost, not zero

2022-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490224#comment-17490224 ] David Smiley commented on SOLR-14800: - [~hossman] I'd like your opinion on this, as a long-time Solr

[jira] [Assigned] (SOLR-12420) Propose removing schema version; use luceneMatchVersion instead

2022-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-12420: --- Assignee: (was: David Smiley) > Propose removing schema version; use luceneMatchVersion

[jira] [Commented] (SOLR-12420) Propose removing schema version; use luceneMatchVersion instead

2022-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490211#comment-17490211 ] David Smiley commented on SOLR-12420: - I suppose the utmost simplest thing we could do is interpret a

[jira] [Commented] (SOLR-15987) Remove ant-compat/force-versions.gradle

2022-02-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489139#comment-17489139 ] David Smiley commented on SOLR-15987: - Why did it exist in the first place?  I'd just like to know.

[jira] [Commented] (SOLR-15992) Globally forbid and exclude known bad dependencies

2022-02-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489099#comment-17489099 ] David Smiley commented on SOLR-15992: - The PR does more than what is stated in JIRA.  Can you

<    3   4   5   6   7   8   9   10   11   12   >