sw/source/core/layout/paintfrm.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 19d80a257b0e5c9d45985e49f33493f38c5d5f10
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon Feb 13 19:34:58 2012 +0400
Header/Footer: don't show in web layout mode
diff --git a/sw/source
oox/inc/oox/xls/unitconverter.hxx |1 -
oox/source/xls/formulabase.cxx|3 ---
oox/source/xls/unitconverter.cxx |1 -
3 files changed, 5 deletions(-)
New commits:
commit c2ad01cc22d79aeed31d97220430d9a9fd4fd2b1
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon Feb 13 20:12
sc/source/core/data/cell.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit ee38b167c86c8f96aa41dca861cae327c6df5915
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Mon Feb 13 12:26:50 2012 -0500
fdo#45916: Ensure formula cell's pCode isn't NULL even when compilation
fails.
Signed-off-by: Ivan Timofeev timofeev@gmail.com
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index 155f4bd..8ddc540 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -782,6 +782,9 @@ ScFormulaCell::ScFormulaCell
sc/source/core/data/cell.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit bf789d4a40711b7b04b969e3330373a2f947b994
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon Feb 13 22:46:38 2012 +0400
make the return statement more visible
diff --git a/sc
Hi Cedric, Kendy,
On 13.02.2012 14:24, Cedric Bosdonnat wrote:
Could someone (kendy?) review and cherry-pick -s in -3-5 the following
commit:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=beb8a85796c78d4cdcf6497b6725fce8f7141d75
What about hiding the indicators in the web layout
On 13.02.2012 18:26, Caolán McNamara wrote:
On Mon, 2012-02-13 at 17:56 +0400, Ivan Timofeev wrote:
Hi Cedric, Kendy,
On 13.02.2012 14:24, Cedric Bosdonnat wrote:
Could someone (kendy?) review and cherry-pick -s in -3-5 the following
commit:
http://cgit.freedesktop.org/libreoffice/core/commit
On 13.02.2012 18:20, Caolán McNamara wrote:
So I've pushed it now :-)
Thanks!! Is it worth being in 3-5? :)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Elton, Michael,
On 13.02.2012 20:04, Michael Meeks wrote:
On Sat, 2012-02-11 at 00:50 +0800, Elton Chung wrote:
This patch removes 10 unused methods.
Lovely; if you 'git grep bNetLock' - I think we can remove that item
from the header, and it's remaining initialization too now
On 13.02.2012 21:08, nthieb...@gmail.com wrote:
Hi folks,
One of you broke the build of LibreOffice with your commit :-(
Please commit and push a fix ASAP!
[...]
/Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx: In member
function 'void FontSizeBox::SetUserValue(sal_Int64)':
Hi Kohei,
On 13.02.2012 21:40, Kohei Yoshida wrote:
The problem happened when calc was not able to
compile the formula string for whatever reason, in which case pCode
would remain NULL after the Compile is called in one of its
constructors.
Sorry, I did not test the bug, but...
On 13.02.2012 22:22, Kohei Yoshida wrote:
Hi Ivan,
On Mon, Feb 13, 2012 at 1:13 PM, Ivan Timofeevtimofeev@gmail.com wrote:
[...]
A crash will be right here, inside Compile?..
No it does not.
Oh, pardon, did not noticed one-line if - return:
if ( pDocument-IsClipOrUndo() )
On 08.02.2012 17:06, Muhammad Haggag wrote:
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=37775
Patch link:
https://bugs.freedesktop.org/attachment.cgi?id=56740
Patch Review:
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=37775attachment=56740
Changes (copied from patch):
This
Hi Noel,
On 10.02.2012 10:56, Noel Grandin wrote:
Convert tools/table.hxx usage in
editeng/inc/editeng/forbiddencharacterstable.hxx to boost::ptr_map
ForbiddenCharactersInfo is simple wrapper for ForbiddenCharacters. It
only adds the bTemporary flag. But bTemporary seems to be write-only,
Hi Noel,
On 10.02.2012 13:42, Noel Grandin wrote:
Convert tools/table.hxx usage in editeng/source/editeng/editdoc.hxx to
boost::ptr_map
Your patch looks good to me. But... let's look at the usages of the
SvxFontTable class. All of them are in editeng/source/editeng/impedit4.cxx.
oox/inc/oox/xls/formulabase.hxx | 38 --
oox/source/xls/formulabase.cxx | 39 ---
oox/source/xls/formulaparser.cxx | 13 -
unusedcode.easy |5 -
4 files changed, 95 deletions(-)
On 10.02.2012 18:24, Elton Chung wrote:
This patch removes 5 unused methods.
Pushed, thank you.
Regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Julien,
On 11.02.2012 19:21, julien2412 wrote:
Cppcheck reports this :
[spelldsp.hxx:138]: (error) Possible null pointer dereference: pCache -
otherwise it is redundant to check if pCache is null at line 136
Here are the lines :
134 inline linguistic::SpellCache
On 11.02.2012 20:13, julien2412 wrote:
What about the Riccardo's suggestion ?
Oh, it is better then mine wrt cheating cppcheck :) But I hate the hacks
like
((SpellCheckerDispatcher *) this)-...
A type cast from const to non-const looks like a black magic to me.
Regards,
Ivan
On 08.02.2012 23:49, Stephan Bergmann wrote:
On 02/08/2012 07:13 PM, Ivan Timofeev wrote:
I didn't try German, but see how it looks in Russian in the attached
screenshot. The problem is that the new links start with '=' and are
quoted. Looks like a bug somewhere.
That looks suspiciously like
cui/source/dialogs/about.src |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 66e4c5851b7ef27d375e2bdb482e723f6e0ce1f0
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon Feb 6 18:50:58 2012 +0400
correct TDF link
diff --git a/cui/source/dialogs/about.src b
l10ntools/inc/export.hxx|2
l10ntools/source/export.cxx | 199 +---
2 files changed, 60 insertions(+), 141 deletions(-)
New commits:
commit e747a4e87e6abf581a5b0c381f706b581c2a0fbc
Author: Christina Rossmanith chrrossman...@web.de
Date: Sun Feb
06.02.2012 00:13, Chr. Rossmanith пишет:
I've added a third parameter nType to ResData2Output() (s. reworked
attached patch)
The following string concatenation argument have to be passed as a
parameter as well.
+if ( pResData-bText )
+sOutput +=
06.02.2012 11:36, Winfried Donkers пишет:
Please open bugs for each of these, you can put me as assignee.
There is the one for Background Colour in Writer...
https://bugs.freedesktop.org/show_bug.cgi?id=44611
- the only that I remember.
Ivan
___
On 06.02.2012 13:34, Chr. Rossmanith wrote:
I have replaced parameter ResData *pResData (which became ununsed) with
parameter rtl::OString sTextType. Or should it be rtl::OString
sTextType instead?
A reference is better, however it is not really performance-critical I
think. But if so,
Hi Norbert,
great work, thank you very much!
I noted some new points:
* 'make dev-install' does not create install/program
* 'make' does not run autogen.sh automatically after 'make clean'
Regards,
Ivan
___
LibreOffice mailing list
* 'make' does not run autogen.sh automatically after 'make clean'
why would autogen.sh be necessarily ran after a make clean ? make
clean is not suppose to remove config_host.mk or any configure.in
generated file.
Oops, now all work fine, the first time I cleaned the tree and then ran
'make'
Ok, pushed, the patch is simply brilliant now! ;) I think we can defy
the tests after all.
I apologize for my hair-splitting while reviewing it.
Thanks,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
sc/inc/cellsuno.hxx |4 --
sc/source/filter/xml/XMLExportDDELinks.cxx | 17 --
sc/source/filter/xml/XMLExportDDELinks.hxx |2 -
sc/source/filter/xml/xmlfilti.cxx | 11 --
sc/source/filter/xml/xmlfilti.hxx
editeng/source/editeng/edtspell.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 1c85118414d91bc0b881f03ad7fac20454ec43a0
Author: Ivan Timofeev timofeev@gmail.com
Date: Sun Feb 5 22:02:12 2012 +0400
fix debug build
diff --git a/editeng/source/editeng/edtspell.cxx
b
Hi Olivier,
05.02.2012 02:13, Olivier Hallot пишет:
it is now 3 days I cannot build master because of tail_build.
editeng/source/editeng/edtspell.cxx:508:
#ifdef DBG_UTIL
sal_Bool WrongList::DbgIsBuggy() const
{
...
}
#endif
remove the surrounding ifdef and then the linker should find
Hi Elton,
thanks for your patch; I tweaked it a bit and then pushed.
Notes:
1. ScVbaWorksheet( const css::uno::Reference ov::XHelperInterface
xParent, const css::uno::Reference css::uno::XComponentContext
xContext );
is *not* unused, we can see it at least in
Pushed, thanks; however I have returned
ScSubTotalDescriptorBase::GetData(ScSubTotalParam) const
ScSubTotalDescriptorBase::PutData(ScSubTotalParam const)
back to the header, because these functions are is pure virtual, and the
implementations in ScSubTotalDescriptorBase is unused, not the all
pushed this one after all.
SfxMedium::GetHdl() seems to be used for now (in
tools/inc/tools/ref.hxx), maybe we can remove all of those macro
definitions...
I also removed 'using SfxControllerItem::GetCoreMetric;' statement from
sfx2/inc/sfx2/unoctitm.hxx, and then the build has succeeded.
05.02.2012 15:15, Ivan Timofeev пишет:
remove the surrounding ifdef and then the linker should find this function.
I committed this change. Don't know why I didn't commit it at that time. %-|
By the way...
05.02.2012 02:13, Olivier Hallot пишет:
All fail in tail_build, a module that takes
Hi Christina,
05.02.2012 20:26, Chr. Rossmanith пишет:
there were three blocks of nearly identical code.
Awful! Thanks for working on this task.
I've moved them to a method ResData2Output(). Please review.
Looks nice. All of the differences seem to be handled...
bWriteNoSlash seems to
05.02.2012 23:37, Chr. Rossmanith пишет:
I've moved them to a method ResData2Output(). Please review.
Looks nice. All of the differences seem to be handled...
Oh, oh, oh! No, we must pass all the different values as paramerers to
the function.
Because it was
if ( pEntry pResData-bText )
Hello Cor,
03.02.2012 23:56, Cor Nouws пишет:
Do I see a contradiction below?
Ivan Timofeev wrote (31-01-12 12:16)
I've just pushed it.
Caolán McNamara wrote (31-01-12 14:21)
Its windows only code, and callcatcher can only see what gets compiled
as its just a compiler wrapper and I run
sd/inc/cusshow.hxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit ab8f1757cedf0029bf3bec40cfe48069a33151be
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Feb 1 15:05:27 2012 +0400
add comments
diff --git a/sd/inc/cusshow.hxx b/sd/inc/cusshow.hxx
index 74c6cfa
Hi Eike,
31.01.2012 17:41, Eike Rathke пишет:
Yup, good catch. Technically there's also the limitation that a ' single
quote character is not allowed as the very first or last character. The
message would get quite lengthy though if we added and not the
character ' at the beginning or end.
I
Hi Caolán,
30.01.2012 21:08, Caolán McNamara пишет:
The original code with...
git show 7b0b5cdf source/ui/inc/scroll.hxx source/ui/uiview/scroll.cxx
it seems that this SwScrollbar had its own SwScrollbar::Show method and
inherits from Window which has a Window::Show method as well. The
Hi Eike,
31.01.2012 17:41, Eike Rathke пишет:
Yup, good catch. Technically there's also the limitation that a ' single
quote character is not allowed as the very first or last character. The
message would get quite lengthy though if we added and not the
character ' at the beginning or end.
I
sc/source/ui/src/globstr.src |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0a9d8c07ddf054930e1b000cc3c972a3d217d71c
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Jan 31 12:42:08 2012 +0400
':' is not allowed in sheet names as well
diff --git a/sc
vcl/inc/win/saldata.hxx|1 -
vcl/win/source/gdi/salgdi3.cxx | 39 ---
2 files changed, 40 deletions(-)
New commits:
commit c1d04217e87e175017898f918cd77fe6529ec0da
Author: Christina Rossmanith chrrossman...@web.de
Date: Tue Jan 31 11:40:22 2012
f2e17f8f6b6724d7e56d6583d79434372f6221bd
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Jan 31 21:38:43 2012 +0400
erase garbage after std::remove
this fixes commit 5a71069339b3a3c118f3015d978799ef66db7564
diff --git a/sd/inc/cusshow.hxx b/sd/inc/cusshow.hxx
index 1bd3614..74c6cfa 100644
30.01.2012 13:07, Stefan Knorr (Astron) пишет:
the idea sounds good, ... patch is simple, and the details seem to be
correct now. Thus, I've taken the liberty to replace can by may
and then push to master.
just added ':' to the sequence of characters
31.01.2012 18:22, Noel Power пишет:
On 30/01/12 13:54, Noel Grandin wrote:
Attached patch converts SdCustomShow to use std::vector.
I hate these remove list etc. type patches as they tend to be tricky and
time consuming to look at ;-) . The patch looked ok for me, hopefully if
I missed
31.01.2012 19:42, Noel Grandin пишет:
So I should be calling
maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );
??
maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage),
maPages.end() );
I'll fix that.
Ivan
___
31.01.2012 19:55, Ivan Timofeev пишет:
I'll fix that.
Hum; guys, what about
- mpSdCustomShow-Remove(pPage-GetSdrPage());
+ ::std::remove(mpSdCustomShow-PagesVector().begin(),
mpSdCustomShow-PagesVector().end(),
+ pPage-GetSdrPage());
mpSdCustomShow-Remove(pPage-GetSdrPage()); - using
31.01.2012 21:12, Noel Power пишет:
should remove the first occurrence, care to fix ?
so the exact equivalent of
mpSdCustomShow-Remove(pPage-GetSdrPage())
will be:
SdCustomShow::PageVec::iterator it = std::find(
mpSdCustomShow-PagesVector().begin(),
31.01.2012 21:44, Noel Power пишет:
hey I've already proved my (non) STL credentials :-) , but.. if we are
to believe the old code then
mpSdCustomShow-Remove(pPage-GetSdrPage()); would call
Container::Remove( void* p ) which would call Container::Remove(
Container::GetPos( p ) ) which afaics
From: Ivan Timofeev timofeev@gmail.com
Date: Sun, 29 Jan 2012 14:08:54 +0400
Subject: [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty
horizontal scrollbar
---
sw/source/ui/uiview/scroll.cxx |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sw/source/ui
sc/source/ui/vba/vbachart.cxx | 33 -
sc/source/ui/vba/vbachart.hxx |1 -
unusedcode.easy |1 -
3 files changed, 35 deletions(-)
New commits:
commit 2b507836fc88f294ef55652174b66dc706125599
Author: Santiago Martinez smvar...@gmail.com
Date:
sfx2/inc/sfx2/dispatch.hxx |1 -
sfx2/source/control/dispatch.cxx | 12 +---
sfx2/source/view/viewfrm.cxx |3 ---
3 files changed, 1 insertion(+), 15 deletions(-)
New commits:
commit ff2c26f586c87452a23f307f4b63568e5276538c
Author: Ivan Timofeev timofeev@gmail.com
Hi Santiago,
28.01.2012 02:02, Santiago Martinez пишет:
This patch removes unused code as listed in unusedcode.easy
Pushed, thank you!
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b507836fc88f294ef55652174b66dc706125599
Cheers,
Ivan
___
28.01.2012 08:41, Korrawit Pruegsanusak пишет:
Hello guys,
Forwarding this to ux-advise. Could you please have a look? Thanks :-)
On Sat, Jan 28, 2012 at 07:19, Albert Thuswaldner
albert.thuswald...@gmail.com wrote:
Hi,
Here is a simple patch which includes a more informative error message
Hi Julien,
28.01.2012 11:12, julien2412 пишет:
So either the duplicated part (obviously mpOutliner != NULL) could be
simply removed
or perhaps the author thought about this :
mpOutlineViewShell != NULL
mpOutlineViewShell is initialized and dereferenced in the ctor, and
keeps its value all
sfx2/source/view/sfxbasecontroller.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit e2407767b39df00c4057a8174391ab70b97a39a5
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Jan 25 23:37:30 2012 +0400
remember that map has been initialized
diff --git a/sfx2/source
27.01.2012 08:55, Muthu Subramanian K пишет:
@Alex: Forgot to mention one more thing: We follow (normally) space
after '(' and before ')' if there are parameters. Sometimes, we would be
tempted to remove the space in cases like foo( param1, param2 ); as well
;) ( I am always tempted in such
sfx2/source/appl/workwin.cxx |2
sfx2/source/view/viewsh.cxx | 528 +--
2 files changed, 261 insertions(+), 269 deletions(-)
New commits:
commit b46d71a558d935bac5c1f484e9635338b1654728
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Jan 24
17.01.2012 16:05, Caolán McNamara пишет:
On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote:
Hi there,
https://bugs.freedesktop.org/show_bug.cgi?id=43932
this patch partially reverts
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9
because
24.01.2012 15:56, David Tardon пишет:
Oops, sorry... It seems it does not work: the tray setting is always
reset to 'Auto' again.
Oh, well then my patch is wrong. I'm sorry for my fallacy...
No another idea on this bug, and no idea of testing patches without a
multitray printer, I'll reset
Hi Thorsten,
23.01.2012 15:40, Thorsten Behrens пишет:
Sorry for the lag - patch is fine as-is I think, let's add the
startcenter icon etc. as/when they arrive.
Thanks for reviewing/pushing!
I was afraid that the hard-coded url is not fine, because I saw another
urls in
sd/source/ui/slidesorter/view/SlsPageObjectPainter.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 799f2de5d1085d845ec498af0a7932965c42ed68
Author: Ivan Timofeev timofeev@gmail.com
Date: Sun Jan 22 14:53:11 2012 +0400
fdo#43705: fix incomplete updating of the page
Hi,
https://bugs.freedesktop.org/show_bug.cgi?id=43705 (regression since 3.4)
The fix for review:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=799f2de5d1085d845ec498af0a7932965c42ed68
Thanks,
Ivan
___
LibreOffice mailing list
quality
though :) - attaching it.
So, I either have to reassign the bug to Thorsten or have to ask how to
make the patch better. :)
Thorsten, are you working on this already?
Best Regards,
Ivan
From 186a015831027d5a8c77a0110b49b3e4614ac38d Mon Sep 17 00:00:00 2001
From: Ivan Timofeev timofeev
11.01.2012 22:15, Lionel Elie Mamane пишет:
On Wed, Jan 11, 2012 at 04:22:59PM +, Caolán McNamara wrote:
Looks good to me on the surface anyway. Go for it I say for master and
3.5. Lionel ? are we right here ?
Yes, that patch is right. I committed (and pushed) a slightly extended
version
Hi Andras,
20.01.2012 02:33, Andras Timar пишет:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d2f27834abd9ea13556387ffa7f773587edbebc
#offtopic:
My native windows build had failed on that call to msiinfo.exe, it would
be nice to build with your patch again...
Cheers,
Ivan
extensions/source/bibliography/bib.hrc |1
svx/inc/globlmn_tmpl.hrc | 721 -
2 files changed, 722 deletions(-)
New commits:
commit bb921f1df6bb12671777e3f3e4a8caa6f7791c3d
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Jan 18 23:23:05
17.01.2012 16:49, Thorsten Behrens пишет:
Seen pushed on -3-5
Great, thanks! -3-4 is still pending.
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hello,
I want to push the following commit to 3-5 and to 3-4:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=005d6524977bd51ce2f859b5ae5352a2fba68dd0
It fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=43193
partially reverting:
framework/source/services/backingwindow.cxx | 20 ++--
framework/source/services/backingwindow.hxx |2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit 1f628c7bf8361086be2044d0d6aa8bbf3f128162
Author: Tomcsik Bence tomcsikbe...@gmail.com
Date: Sat
14.01.2012 03:30, Tomcsik Bence Tibor пишет:
I send the new patch.
Ok, pushed to the master branch and cherry-picked to libreoffice-3-5:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f628c7bf8361086be2044d0d6aa8bbf3f128162
Hi Mat,
15.01.2012 03:29, Mat M пишет:
Hello
Le Sat, 14 Jan 2012 16:00:31 +0100, julien2412 serval2...@yahoo.fr a
écrit:
Hello,
cppcheck reported this :
core/vcl/generic/fontmanager/fontconfig.cxx
196 duplicateExpression style Same expression on both sides of '-'
class SortFont : public
Hello,
13.01.2012 18:15, Tomcsik Bence Tibor пишет:
Hi,
Bug 33794 solved.
IMHO it's better to pass some additional parameter to the layoutButton
function ( e.g. int i_nExtraWidth = 0 ) and change:
nTextWidth += maButtonImageSize.Width() + 8; // add some fuzz to be
on the safe side
Hi there,
https://bugs.freedesktop.org/show_bug.cgi?id=43932
this patch partially reverts
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9
because the following change made the option
[ ] Use only paper tray from printer preferences useless:
@@
forgot to attach the patch.
From bae6b73a56cf4fcfffe21aa9f3f9ccce87e890cd Mon Sep 17 00:00:00 2001
From: Ivan Timofeev timofeev@gmail.com
Date: Fri, 13 Jan 2012 21:50:55 +0400
Subject: [PATCH] fdo#43932: try to fix paper tray settings
---
vcl/source/gdi/print3.cxx | 25
cui/source/customize/eventdlg.src |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit b90940233f34d6cb468a2b4b8a38a78973e1d579
Author: Ivan Timofeev timofeev@gmail.com
Date: Thu Jan 12 18:08:11 2012 +0400
move overlapped controls
diff --git a/cui/source
Hi,
glancing over the git-log I have noticed the following code
writerperfect/source/filter/OdgGenerator.cxx:951
if (!propList[libwpg:mime-type]
propList[libwpg:mime-type]-getStr().len() = 0)
return;
Is there should be || instead of ?
Regards,
Ivan
cui/source/options/optdict.src |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit bcaa334ad6cba9b339a72bfdf9d5e74a7773cacd
Author: Ivan Timofeev timofeev@gmail.com
Date: Sat Jan 7 09:29:29 2012 +0400
move overlapped controls
diff --git a/cui/source
cui/source/options/optdict.src |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 5907a4c1b8af1f73e966b4c1fe517dee0a3815f1
Author: Ivan Timofeev timofeev@gmail.com
Date: Sat Jan 7 09:29:29 2012 +0400
move overlapped controls
diff --git a/cui/source
chart2/source/controller/dialogs/DataBrowser.cxx |3 ---
chart2/source/controller/dialogs/dlg_ObjectProperties.cxx |3 ---
chart2/source/controller/dialogs/tp_AxisPositions.cxx |3 ---
chart2/source/controller/dialogs/tp_Scale.cxx |3 ---
06.01.2012 20:57, Lior Kaplan пишет:
Anyone ?
I'll try... :)
On Mon, Jan 2, 2012 at 5:13 PM, Lior Kaplan kaplanl...@gmail.com wrote:
Hi,
1. The format - page - organizer tab is missing a space between
the page orientation and the page direction. You'll notice it as
Hello Marcel,
07.01.2012 20:19, Marcel Metz пишет:
this patch removes the superfluous _ZFORLIST_DECLARE_TABLE define that
is explicit defined right in in front of the conditional code.
Cool, you've killed this ancient and ugly definition. :) Thanks!
Pushed:
Hello Julien,
07.01.2012 20:57, julien2412 пишет:
Would it be possible to cherry-pick the commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=948f57e74dda7e64b7c72208eaec00eac1bb96ba
in 3.5 branch ?
It's a very quick and easy fix for fdo#44065.
He-he, copy-paste negligence... :)
07.01.2012 22:37, Lior Kaplan пишет:
This fix is also relevant a few lines bellow, adding a patch to include
them both.
Yep, feel free to push. It is anyway doubtful whether sticking two
different-meaning strings together is good idea.
Ivan
___
sd/source/ui/dlg/present.src |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit e2b57677d3fcb184606b4efb02c79b3e4847c1a0
Author: Ivan Timofeev timofeev@gmail.com
Date: Fri Jan 6 17:08:54 2012 +0400
fdo#44294: overlapped controls
diff --git a/sd/source/ui
sd/source/ui/dlg/present.src |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 58174c2a1e9291cf8cef63dcd51fd6357233c797
Author: Ivan Timofeev timofeev@gmail.com
Date: Fri Jan 6 17:08:54 2012 +0400
fdo#44294: overlapped controls
diff --git a/sd/source/ui
someone who is willing to improve/change the UI
Hello,
Ivan Timofeev was very active eliminating problems and improving GUI.
Ivan, what do you think? Are you interested?
Interested, but extremely busy the whole January through... :-(
I'm sorry. But an UI is an easy piece of programming
Hi Korrawit,
31.12.2011 14:46, Korrawit Pruegsanusak пишет:
I found this while translating.
Could someone please review it?
Looks great! Nice catch, thanks! :)
Also, if this patch could be pushed in -3-5 branch as well?
I've found the wiki page [1] says hard string freeze is next week.
So,
commits:
commit f10fc42189b3d3f6dd180234da9777e53e92b7e4
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Dec 28 20:00:03 2011 +0400
fdo#44204: shrink the first column in the open dialog, remove unused flags
diff --git a/dbaccess/source/ui/dlg/CollectionView.cxx
b/dbaccess/source/ui/dlg
commits:
commit 150c18ecb0d0eb0dbcef50bb1d76b7c549255104
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Dec 28 20:00:03 2011 +0400
fdo#44204: shrink the first column in the open dialog, remove unused flags
diff --git a/dbaccess/source/ui/dlg/CollectionView.cxx
b/dbaccess/source/ui/dlg
Hi Kaplan,
27.12.2011 03:04, Lior Kaplan пишет:
The in Insert - Indexes and Tables dialog, the word Preview (bottom
right corner in English interface) is trimmed. See screenshot (3.5.0
beta2). In RTL interface the same problem happens, and with a longer
translation more of the text is trimmed.
Hi Jan,
27.12.2011 17:45, Jan Holesovsky пишет:
The good news is that I fixed an unrelated text cut in my native
language a visual annoyance there ;-)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a38a8514ab33f9d8b174000ca635db949c16940
Our *.src-based UI is a real disaster. This
formula/source/core/api/FormulaCompiler.cxx |4 ++--
formula/source/ui/dlg/formula.cxx | 18 +-
formula/source/ui/dlg/funcpage.cxx|2 +-
formula/source/ui/dlg/parawin.cxx |2 +-
fpicker/source/office/OfficeControlAccess.cxx |
Hi Olivier,
24.12.2011 00:26, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part XVII
Module
fileaccess and filter
Pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e7bddf732798508e347221590110486e97bb45e6
Thanks a lot!
Ivan
26.12.2011 01:35, Olivier Hallot пишет:
Please find attached a partial fix for Easy Hack FDO43460
Part XIX
Module
formula and fpicker
Pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e4f51f112248b4e586f5bd86388099737ed17e9
Great work, thank you!
Ivan
vcl/source/window/menu.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 22ebb32863f7874ccd1d39881140a0bbcbc5f72a
Author: Ivan Timofeev timofeev@gmail.com
Date: Fri Dec 23 19:10:18 2011 +0400
don't hide images in menus (fdo#31471, fdo#41264)
diff --git
drawinglayer/source/primitive2d/controlprimitive2d.cxx |2 -
dtrans/source/cnttype/mcnttype.cxx | 18 -
dtrans/source/test/test_dtrans.cxx |2 -
editeng/source/editeng/editview.cxx|4 +--
Hi Gustavo,
23.12.2011 21:21, Gustavo Pacheco пишет:
Hi!
Partial fix for Easy Hack FDO43460 (part XIV) for review. Mentoring by
Olivier Hallot (thanks for the tips Olivier!).
Part XVI
Modules drawinglayer, dtrans and editeng
Looks nice for me, but
-if
401 - 500 of 584 matches
Mail list logo
