Re: [Lldb-commits] [lldb-dev] PTYPE replacement in LLDB

The original plan was to add a "type eval" to go alongside "type lookup". "type eval" would take an expression, evaluate it, and then print the resulting type. gdb's type takes either a type name or an expression, but there's no way to disambiguate if you have a type that has the same name as

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 11, 2017, at 4:05 PM, Leonard Mosescu via lldb-commits > wrote: > > > Process already has "Error Process::WillResume()" for this very reason. Just > have the Windows mini dump core file plug-in override it. The code in > Process::Resume already checks

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

o with #1 if someone > > with experience in this area can review the change. Anything else that I > > missed? > > > > Seems like #1 is the right choice if you're willing to give it a try. You > are right that this code is tricky, but it would be worth the effort to fix

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

re right that this code is tricky, but it would be worth the effort to fix it right, if for no other reason than to get some other eyes on it. I'm happy to answer any questions as you go along. This code has ping-ponged back and forth between Greg and me, so we should both be able to help you

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 9, 2017, at 7:38 PM, Zachary Turner wrote: > > Sure, but reading a core file involves handling user input. Obviously that > has to be sanitized and you can't crash on user input. I don't think there's > ever been any disagreement about that. On the other hand, if

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

I think we are talking at cross purposes. Seems to me you are saying “If we can assert that the answers to questions I ask must always copacetic, then we can express that in software, and that will make things so much easier". I’m saying "my experience of the data debuggers have to deal with

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Yes, the fact that llvm & clang and the MCJIT abort willy nilly has caused much pain to lldb. We don’t control that behavior and so are resigned to some continued suffering along those lines - though it seems like Lang is going to do a much cleaner job of handling problems in the new ORC JIT

[Lldb-commits] [lldb] r311786 - Add the DWARF DWP files to the Xcode project.

Author: jingham Date: Fri Aug 25 10:48:01 2017 New Revision: 311786 URL: http://llvm.org/viewvc/llvm-project?rev=311786=rev Log: Add the DWARF DWP files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r311679 - Fixed a typo in the example (getName -> GetName)

Author: jingham Date: Thu Aug 24 11:01:50 2017 New Revision: 311679 URL: http://llvm.org/viewvc/llvm-project?rev=311679=rev Log: Fixed a typo in the example (getName -> GetName) but while I was at it I converted the example to use properties, since that's much nicer looking. Modified:

[Lldb-commits] [lldb] r311590 - Log whether we found a step out plan or not.

Author: jingham Date: Wed Aug 23 12:40:21 2017 New Revision: 311590 URL: http://llvm.org/viewvc/llvm-project?rev=311590=rev Log: Log whether we found a step out plan or not. Modified: lldb/trunk/source/Target/ThreadPlanStepInRange.cpp Modified:

Re: [Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

> On Aug 8, 2017, at 12:02 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D35223#834050, @emaste wrote: > >> With this patch I observed three new failures on FreeBSD and three new >>

[Lldb-commits] [lldb] r309977 - Cut and paste error from r23162.

Author: jingham Date: Thu Aug 3 12:38:38 2017 New Revision: 309977 URL: http://llvm.org/viewvc/llvm-project?rev=309977=rev Log: Cut and paste error from r23162. Modified: lldb/trunk/source/API/SBBreakpoint.cpp lldb/trunk/source/API/SBBreakpointLocation.cpp Modified:

[Lldb-commits] [lldb] r309969 - Add an auto-continue flag to breakpoints & locations.

Author: jingham Date: Thu Aug 3 11:13:24 2017 New Revision: 309969 URL: http://llvm.org/viewvc/llvm-project?rev=309969=rev Log: Add an auto-continue flag to breakpoints & locations. You can get a breakpoint to auto-continue by adding "continue" as a command, but that has the disadvantage that

[Lldb-commits] [lldb] r309709 - Remember to make API headers Public in the LLDB target.

Author: jingham Date: Tue Aug 1 10:19:59 2017 New Revision: 309709 URL: http://llvm.org/viewvc/llvm-project?rev=309709=rev Log: Remember to make API headers Public in the LLDB target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r309238 - Fix the formatting for help on option value types.

Author: jingham Date: Wed Jul 26 17:18:18 2017 New Revision: 309238 URL: http://llvm.org/viewvc/llvm-project?rev=309238=rev Log: Fix the formatting for help on option value types. Patch by Jessica Han https://reviews.llvm.org/D35525 Modified:

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

Not at present, but you presumably know more about this than I do. Part of the point of Greg's extracting the DWARF parser from lldb and making it into it's own library in llvm was precisely so that somebody could then write a simple wrapper tool that would poke it with not necessarily

[Lldb-commits] [lldb] r308549 - Add help text for "expression" telling how to enter multi-line mode.

Author: jingham Date: Wed Jul 19 16:25:42 2017 New Revision: 308549 URL: http://llvm.org/viewvc/llvm-project?rev=308549=rev Log: Add help text for "expression" telling how to enter multi-line mode. This seemed natural to us, but wasn't documented anywhere and was not clear to everybody.

Re: [Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

Done (r307944). Thanks for the patch! Jim > On Jul 13, 2017, at 8:20 AM, Xuetian Weng via Phabricator via lldb-commits > wrote: > > wengxt added a comment. > > I don't have commit access. May any one help me to commit? > > > https://reviews.llvm.org/D34911 >

[Lldb-commits] [lldb] r307944 - Enable parsing C++ names generated by lambda functions.

Author: jingham Date: Thu Jul 13 12:48:43 2017 New Revision: 307944 URL: http://llvm.org/viewvc/llvm-project?rev=307944=rev Log: Enable parsing C++ names generated by lambda functions. https://reviews.llvm.org/D34911 from Weng Xuetian. Modified:

[Lldb-commits] [lldb] r307942 - Fix a deadlock in the Python interpreter vrs. SIGINT.

Author: jingham Date: Thu Jul 13 12:45:54 2017 New Revision: 307942 URL: http://llvm.org/viewvc/llvm-project?rev=307942=rev Log: Fix a deadlock in the Python interpreter vrs. SIGINT. The interpreter gets invoked in the sigint handler to cancel long-running Python operations. That requires the

[Lldb-commits] [lldb] r307870 - The llvm.org bugzilla moved.

Author: jingham Date: Wed Jul 12 17:36:21 2017 New Revision: 307870 URL: http://llvm.org/viewvc/llvm-project?rev=307870=rev Log: The llvm.org bugzilla moved. Modified: lldb/trunk/www/sidebar.incl Modified: lldb/trunk/www/sidebar.incl URL:

[Lldb-commits] [lldb] r307287 - Working through testcases, converting to run_to_source_breakpoint.

Author: jingham Date: Thu Jul 6 11:06:25 2017 New Revision: 307287 URL: http://llvm.org/viewvc/llvm-project?rev=307287=rev Log: Working through testcases, converting to run_to_source_breakpoint. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py

[Lldb-commits] [lldb] r307234 - Add a lldbutils routine that gathers up the boiler-plate

Author: jingham Date: Wed Jul 5 19:18:16 2017 New Revision: 307234 URL: http://llvm.org/viewvc/llvm-project?rev=307234=rev Log: Add a lldbutils routine that gathers up the boiler-plate to make a target, set a source regex breakpoint, run to the breakpoint and find the thread that hit the

[Lldb-commits] [lldb] r306725 - Timer.{h, cpp} moved, find them again in the project file.

Author: jingham Date: Thu Jun 29 11:54:40 2017 New Revision: 306725 URL: http://llvm.org/viewvc/llvm-project?rev=306725=rev Log: Timer.{h,cpp} moved, find them again in the project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r306445 - Fix up the Xcode project:

Author: jingham Date: Tue Jun 27 11:48:32 2017 New Revision: 306445 URL: http://llvm.org/viewvc/llvm-project?rev=306445=rev Log: Fix up the Xcode project: 1) Renaming the InstrumentationRuntime directory & file names 2) Bunch of stuff moved from Core to Utility 3) Deleted a bunch of files

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

This is WWDC week. We’ll try to find time to take a look at this, but silence may mean preoccupation more than anything else… Jim > On Jun 6, 2017, at 6:53 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I'd like to commit this this week.

[Lldb-commits] [lldb] r304379 - Forgot to mention rewriting CommandObject::DoExecute

Author: jingham Date: Wed May 31 20:05:30 2017 New Revision: 304379 URL: http://llvm.org/viewvc/llvm-project?rev=304379=rev Log: Forgot to mention rewriting CommandObject::DoExecute using the SB API's not the lldb_private API's. Modified: lldb/trunk/www/projects.html Modified:

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

be to me is for writing tests. > > > After all, they're simpler than the other style of test. Now, suppose there > > were some hypothetical DSL that allowed every test to be an inline test but > > still test equally complicated scenarios in half the code. Then suppose it > >

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

est but > still test equally complicated scenarios in half the code. Then suppose it > also ran on a more robust multiprocessing infrastructure than dotest.py. > That's all we're really talking about Thanks for the clarification. Jim > On Wed, May 31, 2017 at 12:06 PM Jim

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

Before we get past "it's hard" to "just to do it", it would help me to be clear first on what you are actually trying to achieve with this proposal. It's not clear to me what problem are people trying to solve here? If it is writing tests for the decomposable parts of lldb - like the tests

Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

SBThread::Resume instructs lldb to set the resume state on a thread to "eStateRunning", meaning that means the next time you continue the process, that thread will get a chance to run. It has no effect on the StopReason for the thread (it doesn't even start it running except maybe in the not

Re: [Lldb-commits] Documentation LLDB-MI

The virtue of the MI interface is that it allows you to write a tool that supports gdb as well as lldb. But the MI is a not an API per se, it's just a structured text interface. You send text commands to the MI server, and receive text results which you then parse to extract the results.

[Lldb-commits] [lldb] r303832 - Fix the warning when you pass -c to step/next/si/ni.

Author: jingham Date: Wed May 24 21:24:18 2017 New Revision: 303832 URL: http://llvm.org/viewvc/llvm-project?rev=303832=rev Log: Fix the warning when you pass -c to step/next/si/ni. During some cleanup the test for whether the thread plan accepted an iteration count was reversed, so we give a

[Lldb-commits] [lldb] r303643 - We shouldn't put actual tests in directories that contain

Author: jingham Date: Tue May 23 11:11:21 2017 New Revision: 303643 URL: http://llvm.org/viewvc/llvm-project?rev=303643=rev Log: We shouldn't put actual tests in directories that contain other test directories. Added:

Re: [Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

Yes, though the original code handled the unsuccessful completion cases slightly differently. I'm not sure how significant that is without pondering it further and I'm in the middle of something else right now. Jim > On May 17, 2017, at 1:31 PM, Pavel Labath via Phabricator >

[Lldb-commits] [lldb] r302327 - Be a little more permissive in DynamicLoaderMacOS::CanLoadImage

Author: jingham Date: Fri May 5 20:15:47 2017 New Revision: 302327 URL: http://llvm.org/viewvc/llvm-project?rev=302327=rev Log: Be a little more permissive in DynamicLoaderMacOS::CanLoadImage If we can't find the "is dyld locked" symbol, assume it is safe to load the image unless we only have 1

[Lldb-commits] [lldb] r302323 - Added "info threads", "thread 1" and "apropos".

Author: jingham Date: Fri May 5 18:38:26 2017 New Revision: 302323 URL: http://llvm.org/viewvc/llvm-project?rev=302323=rev Log: Added "info threads", "thread 1" and "apropos". Modified: lldb/trunk/www/lldb-gdb.html Modified: lldb/trunk/www/lldb-gdb.html URL:

Re: [Lldb-commits] [PATCH] D32823: Remove an expensive lock from Timer

I'd vote for keeping the timers if possible. Their job is to tell you "of the time spent in some operation, how much was spent in say DWARF parsing", etc. That has been useful on occasion. Jim > On May 4, 2017, at 2:12 PM, Scott Smith via Phabricator via lldb-commits >

Re: [Lldb-commits] [PATCH] D32832: Make ConstString creation and access lockfree

It isn't uncommon for folks to debug programs with all the debug information for the whole system available. In those cases, what looks to the user like a normal sized application is actually a very large one as far as lldb's global string pool is concerned. My experience is that whenever you

[Lldb-commits] [lldb] r301609 - Provide a mechanism to do some pre-loading of symbols up front.

Author: jingham Date: Thu Apr 27 19:51:06 2017 New Revision: 301609 URL: http://llvm.org/viewvc/llvm-project?rev=301609=rev Log: Provide a mechanism to do some pre-loading of symbols up front. Loading a shared library can require a large amount of work; rather than do that serially for each

[Lldb-commits] [lldb] r301608 - Add a newline to suppress compiler warnings.

Author: jingham Date: Thu Apr 27 19:44:07 2017 New Revision: 301608 URL: http://llvm.org/viewvc/llvm-project?rev=301608=rev Log: Add a newline to suppress compiler warnings. Modified: lldb/trunk/include/lldb/Core/TraceOptions.h Modified: lldb/trunk/include/lldb/Core/TraceOptions.h URL:

Re: [Lldb-commits] [lldb] r300902 - Add an example command to toggle between disassembly-only and source mode.

to figure out how to do ordinary things. Jim > On Apr 21, 2017, at 1:32 AM, Pavel Labath <lab...@google.com> wrote: > > This is cool, I just did some assembly debugging yesterday, and wished it was > easier :) > > On 20 April 2017 at 22:51, Jim Ingham via lldb-commits > &

[Lldb-commits] [lldb] r300902 - Add an example command to toggle between disassembly-only and source mode.

Author: jingham Date: Thu Apr 20 16:51:27 2017 New Revision: 300902 URL: http://llvm.org/viewvc/llvm-project?rev=300902=rev Log: Add an example command to toggle between disassembly-only and source mode. Sometimes you are debugging in source, but you really only want to see the disassembly.

[Lldb-commits] [lldb] r300785 - Fix !N and !-N commands and add a test case.

Author: jingham Date: Wed Apr 19 18:21:04 2017 New Revision: 300785 URL: http://llvm.org/viewvc/llvm-project?rev=300785=rev Log: Fix !N and !-N commands and add a test case. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/history/

[Lldb-commits] [lldb] r300733 - Add CopyDiagnostic to the DiagnosticManager.

Author: jingham Date: Wed Apr 19 13:56:44 2017 New Revision: 300733 URL: http://llvm.org/viewvc/llvm-project?rev=300733=rev Log: Add CopyDiagnostic to the DiagnosticManager. From Gregor Milos (gmi...@apple.com), for: https://reviews.llvm.org/D32078 Modified:

Re: [Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

We've had a couple of cases of "dead" code which turned out to be the llvm.org side of generic behavior for which Swift was the only current specific implementation. So while I agree, little single functions that aren't used anywhere are fine to cull, anything that looks like it might be the

[Lldb-commits] [lldb] r300564 - Add back code to implement "frame var -a, -l, -g" filters.

Author: jingham Date: Tue Apr 18 11:52:16 2017 New Revision: 300564 URL: http://llvm.org/viewvc/llvm-project?rev=300564=rev Log: Add back code to implement "frame var -a,-l,-g" filters. r285226 dropped the code that did these checks. I am pretty sure that was inadvertent, so I added that back

[Lldb-commits] [lldb] r300519 - TestStaticVariables still fails on Linux.

Author: jingham Date: Mon Apr 17 19:44:14 2017 New Revision: 300519 URL: http://llvm.org/viewvc/llvm-project?rev=300519=rev Log: TestStaticVariables still fails on Linux. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py Modified:

[Lldb-commits] [lldb] r300517 - This test is succeeding on macOS with clang.

Author: jingham Date: Mon Apr 17 19:20:59 2017 New Revision: 300517 URL: http://llvm.org/viewvc/llvm-project?rev=300517=rev Log: This test is succeeding on macOS with clang. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py Modified:

Re: [Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

> On Apr 12, 2017, at 9:51 AM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > >> >> On Apr 11, 2017, at 7:01 PM, Zachary Turner via Phabricator via lldb-commits >> <lldb-commits@lists.llvm.org> wrote: >> >> zturner a

Re: [Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

> On Apr 11, 2017, at 7:01 PM, Zachary Turner via Phabricator via lldb-commits > wrote: > > zturner added a comment. > > How much would it complicate things to move the hand maintained files out of > tree? If the Xcode build isn't really a thing we're officially

[Lldb-commits] [lldb] r300012 - Teach SBFrame how to guess its language.

Author: jingham Date: Tue Apr 11 19:19:54 2017 New Revision: 300012 URL: http://llvm.org/viewvc/llvm-project?rev=300012=rev Log: Teach SBFrame how to guess its language. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-language/

[Lldb-commits] [lldb] r299609 - getAsInteger is not a equivalent replacement for strtol

Author: jingham Date: Wed Apr 5 20:33:38 2017 New Revision: 299609 URL: http://llvm.org/viewvc/llvm-project?rev=299609=rev Log: getAsInteger is not a equivalent replacement for strtol work around that fact for CommandObjectMemoryWrite. Modified:

Re: [Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

No problem. You can't test on all platforms, so changes like this are bound to sometimes introduce regressions. If you can remember to watch the bots for systems you don't run or test on that makes the turnaround smoother. Otherwise, if it's a MacOS problem the QE folks here are sure to tell

Re: [Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

This patch is causing a testsuite failure in ObjC breakpoint setting: functionalities/breakpoint/objc/TestObjCBreakpoints.py You must be grabbing ObjC names and somehow treating them as C++ names. I reverted the patch till the test gets fixed. If you can't get your hands on an ObjC binary to

[Lldb-commits] [lldb] r299489 - Reverting r299374 & r299402 due to testsuite failure.

Author: jingham Date: Tue Apr 4 19:08:21 2017 New Revision: 299489 URL: http://llvm.org/viewvc/llvm-project?rev=299489=rev Log: Reverting r299374 & r299402 due to testsuite failure. This caused a failure in the test case: functionalities/breakpoint/objc/TestObjCBreakpoints.py When we are

[Lldb-commits] [lldb] r299451 - Tone down the "lldb types" log a bit.

Author: jingham Date: Tue Apr 4 12:48:21 2017 New Revision: 299451 URL: http://llvm.org/viewvc/llvm-project?rev=299451=rev Log: Tone down the "lldb types" log a bit. Change the get shared class info function to only dump its results to the inferior stdout when the log is verbose. This matches

[Lldb-commits] [lldb] r299276 - DisassembleRange can return an empty DisassemblerSP

Author: jingham Date: Fri Mar 31 17:39:55 2017 New Revision: 299276 URL: http://llvm.org/viewvc/llvm-project?rev=299276=rev Log: DisassembleRange can return an empty DisassemblerSP check for it. Modified: lldb/trunk/source/Target/StackFrame.cpp Modified:

[Lldb-commits] [lldb] r299147 - Don't add a newline if the object description already has one.

Author: jingham Date: Thu Mar 30 20:32:57 2017 New Revision: 299147 URL: http://llvm.org/viewvc/llvm-project?rev=299147=rev Log: Don't add a newline if the object description already has one. Modified: lldb/trunk/source/DataFormatters/ValueObjectPrinter.cpp Modified:

Re: [Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

Thanks. Jim > On Mar 30, 2017, at 1:16 PM, Tamas Berghammer wrote: > > Created bug for exposing ValueObject::Clone as SB API: > http://bugs.llvm.org/show_bug.cgi?id=32477 > > On Thu, Mar 30, 2017 at 1:04 PM Jim Ingham via Phabricator >

Re: [Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

I see. Might be worth filing an enhancement request to expose Clone so you can do this in a Python synthetic child provider. But there's no reason that lack should block this change. Jim > On Mar 30, 2017, at 12:51 PM, Tamas Berghammer wrote: > > It is possible to

Re: [Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

> On Mar 29, 2017, at 2:06 AM, Tamas Berghammer via Phabricator > wrote: > > tberghammer added a comment. > > SBValue::SetName is not part of the SB API (what is the right decision IMO as > an SBValue should be mostly immutable) so this issue doesn't effect it. I >

[Lldb-commits] [lldb] r298958 - Print the error if dsymForUUID sometimes produces bad plists.

Author: jingham Date: Tue Mar 28 18:25:34 2017 New Revision: 298958 URL: http://llvm.org/viewvc/llvm-project?rev=298958=rev Log: Print the error if dsymForUUID sometimes produces bad plists. Not much we can do about it but at least we can print the bad plist and the error. Modified:

[Lldb-commits] [lldb] r298876 - In FileSpec::Equal, short-cut GetNormalizedPath.

Author: jingham Date: Mon Mar 27 14:12:25 2017 New Revision: 298876 URL: http://llvm.org/viewvc/llvm-project?rev=298876=rev Log: In FileSpec::Equal, short-cut GetNormalizedPath. GetNormalizedPath seems to be slow, so it's worth shortcutting it if possible. This change does so when the filenames

[Lldb-commits] [lldb] r298874 - Fix the Xcode project for OpenBSD additions.

Author: jingham Date: Mon Mar 27 14:03:11 2017 New Revision: 298874 URL: http://llvm.org/viewvc/llvm-project?rev=298874=rev Log: Fix the Xcode project for OpenBSD additions. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r298331 - FindTypes should find "struct TypeName" as well as "TypeName".

Author: jingham Date: Mon Mar 20 21:13:50 2017 New Revision: 298331 URL: http://llvm.org/viewvc/llvm-project?rev=298331=rev Log: FindTypes should find "struct TypeName" as well as "TypeName". This fixes a bug introduced by r291559. The Module's FindType was passing the original name not the

[Lldb-commits] [lldb] r298290 - Get ObjectFileMachO to handle @executable_path

Author: jingham Date: Mon Mar 20 14:21:31 2017 New Revision: 298290 URL: http://llvm.org/viewvc/llvm-project?rev=298290=rev Log: Get ObjectFileMachO to handle @executable_path Only do this when we are debugging an executable, since we don't have a good way to trace from an ObjectFile back to its

[Lldb-commits] [lldb] r298289 - Fix a problem with line tables & .o files that start with code with no line table entries.

Author: jingham Date: Mon Mar 20 14:19:03 2017 New Revision: 298289 URL: http://llvm.org/viewvc/llvm-project?rev=298289=rev Log: Fix a problem with line tables & .o files that start with code with no line table entries. If you have code before the first line table entry when debugging with .o

Re: [Lldb-commits] [lldb] r297830 - Fix TestMoveNearest breakage on darwin

Finding the executables that a binary will load on run before you actually run is always best effort. We don't require the ObjectFile class to fully emulate the platform loader. So from the standpoint of writing tests, if the test relies on getting symbols from a loaded library it should

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

Yes formally that seems problematic. It wouldn't be a problem in practice because you should only call ResetNeedsUpdating in UpdateAutomaticSignalFiltering, and the only place where UpdateAutomaticSignalFiltering should be called is when Launching or Resuming, and you can't call either of

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

I like it in the base class and Greg was okay with that too. So let's leave that where it is. The only bit of this behavior that could be moved into UnixSignals as it seemed to me was the handling of "needs updating". I was mostly proposing that because then you can already pass the

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

The UnixSignals class produces the array of signal numbers that it knows it doesn't want to hear about. But it has no idea how any particular Process plugin would implement ignoring those symbols. So that part belongs to the Process plugin. I suggested in a previous comment also adding a

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

> On Mar 6, 2017, at 4:10 PM, Greg Clayton via Phabricator > wrote: > > clayborg requested changes to this revision. > clayborg added a comment. > This revision now requires changes to proceed. > > Very close. Can we try to get UpdateAutomaticSignalFiltering out of

Re: [Lldb-commits] [lldb] r296946 - Delete LLDB's code for getting / setting thread name.

It was done on all platforms, but the way it worked before was there was a HostInfo::GetMaxThreadNameLength that was the length passed into SetThreadName, and then the string was back trimmed to that length generically in ThisThread::SetName. You can see the length passed in in

Re: [Lldb-commits] [lldb] r296946 - Delete LLDB's code for getting / setting thread name.

This change seems to have lost the code that would make sure that on platforms with short thread names we pick up the end of the name passed in because that is generally the more specific part. Was that just an oversight? Jim > On Mar 3, 2017, at 5:31 PM, Zachary Turner via lldb-commits >

[Lldb-commits] [lldb] r296938 - Fix the macOS build all the way after r296909.

Author: jingham Date: Fri Mar 3 19:15:24 2017 New Revision: 296938 URL: http://llvm.org/viewvc/llvm-project?rev=296938=rev Log: Fix the macOS build all the way after r296909. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

Might also be useful to have a list of "files only compiled on platform X" somewhere. Then in this sort of case, you could compile, then scrutinize carefully all the files in the "not my platform list." Jim > On Mar 3, 2017, at 4:51 PM, Jim Ingham via lldb-c

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

Yeah, you could have grepped (is that how you spell that?) for "#include "lldb/Core/DataExtractor.h" then looked at any Dump method in the files that turned up. That would have reduced the noise. Ah, staircase wit... Jim > On Mar 3, 2017, at 4:46 PM, Zachary Turner

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

I'll get this working, but in the future when you are making changes of this sort please chase down all the instances of functions you are changing, even in files you aren't building locally. There might be a use that your conversion doesn't handle, and you don't want to find that out after

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

I guess you could fudge by changing DumpDataExtractor.h to DataDumper.h to indicate that it is more general than just data extractors. Jim > On Mar 3, 2017, at 3:48 PM, Zachary Turner wrote: > > Yea, it was a static method of DataExtractor before. I noticed the same >

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor. That's a little weird because it doesn't actually take a DataExtractor, but... Jim > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits > wrote: > > I can fix that, I didn't see it in

Re: [Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

That sounds right. Please do fix the function names. We can have another discussion about naming at some point, but we shouldn't do it piecemeal. Jim > On Mar 3, 2017, at 9:53 AM, Zachary Turner wrote: > > Yea, I can see splitting the target specific stuff into a

[Lldb-commits] [lldb] r296833 - Mention fetching thread lists lazily.

Author: jingham Date: Thu Mar 2 16:13:45 2017 New Revision: 296833 URL: http://llvm.org/viewvc/llvm-project?rev=296833=rev Log: Mention fetching thread lists lazily. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

[Lldb-commits] [lldb] r296826 - Forgot about local variable lookup.

Author: jingham Date: Thu Mar 2 16:04:05 2017 New Revision: 296826 URL: http://llvm.org/viewvc/llvm-project?rev=296826=rev Log: Forgot about local variable lookup. Yay for coffee lines. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

[Lldb-commits] [lldb] r296814 - Added a list of outstanding projects that would benefit lldb.

Author: jingham Date: Thu Mar 2 15:39:27 2017 New Revision: 296814 URL: http://llvm.org/viewvc/llvm-project?rev=296814=rev Log: Added a list of outstanding projects that would benefit lldb. This was a list that I've had kicking around for a while, and would add to whenever some hallway

[Lldb-commits] [lldb] r296693 - Make it clear what you should modify when you copy any of these sample

Author: jingham Date: Wed Mar 1 16:23:30 2017 New Revision: 296693 URL: http://llvm.org/viewvc/llvm-project?rev=296693=rev Log: Make it clear what you should modify when you copy any of these sample test cases. Modified:

[Lldb-commits] [lldb] r296692 - Add a test to ensure that SBFrame::Disassemble produces some output.

Author: jingham Date: Wed Mar 1 16:18:37 2017 New Revision: 296692 URL: http://llvm.org/viewvc/llvm-project?rev=296692=rev Log: Add a test to ensure that SBFrame::Disassemble produces some output. Added:

[Lldb-commits] [lldb] r296669 - Add a sample_test directory with simple starter

Author: jingham Date: Wed Mar 1 14:25:48 2017 New Revision: 296669 URL: http://llvm.org/viewvc/llvm-project?rev=296669=rev Log: Add a sample_test directory with simple starter test cases for standard and "inline" tests. Added: lldb/trunk/packages/Python/lldbsuite/test/sample_test/

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

> On Feb 28, 2017, at 4:15 PM, Zachary Turner wrote: > > > > On Tue, Feb 28, 2017 at 3:49 PM Jim Ingham wrote: > > > On Feb 28, 2017, at 3:36 PM, Zachary Turner wrote: > > > > That patch was not really about early returns, it was

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

> On Feb 28, 2017, at 3:36 PM, Zachary Turner wrote: > > That patch was not really about early returns, it was about using StringRef. > So my comment about the aesthetics was referring to the patch in general. > The early return was more of a drive by, since I was

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

form, you don't have adequate context, and you are much more likely to make a mistake. Jim > On Feb 28, 2017, at 3:22 PM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > >> On Feb 28, 2017, at 3:14 PM, Zachary Turner <ztur...@google.com>

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

> On Feb 28, 2017, at 3:14 PM, Zachary Turner wrote: > > On Tue, Feb 28, 2017 at 3:07 PM Jason Molenda wrote: > At it's core, lldb is a real world tool that thousands of people depend on; > breaking it or introducing bugs for little gain beyond

[Lldb-commits] [lldb] r296504 - Fix a bug in r294611 w.r.t. Darwin Kernel debugging.

Author: jingham Date: Tue Feb 28 12:57:54 2017 New Revision: 296504 URL: http://llvm.org/viewvc/llvm-project?rev=296504=rev Log: Fix a bug in r294611 w.r.t. Darwin Kernel debugging. Modified: lldb/trunk/include/lldb/Target/DynamicLoader.h lldb/trunk/include/lldb/Target/Process.h

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

Make that SBFrame::Disassemble... Jim > On Feb 28, 2017, at 10:21 AM, Jim Ingham wrote: > > SBStackFrame::Disassemble calls StackFrame::Disassemble to do its job. From > the looks of it, your goof would cause lldb never to return any instructions > when asked to

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

SBStackFrame::Disassemble calls StackFrame::Disassemble to do its job. From the looks of it, your goof would cause lldb never to return any instructions when asked to disassemble a stack frame, since StackFrame does the work lazily and the error was to NOT do the work when the disassembly is

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

No test case? Jim > On Feb 28, 2017, at 9:59 AM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date: Tue Feb 28 11:59:59 2017 > New Revision: 296495 > > URL: http://llvm.org/viewvc/llvm-project?rev=296495=rev > Log: > Fix incorrect logic in

Re: [Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

Having library functions that don't return good errors seems like such an obvious failing that it shouldn't be hard to motivate fixing that. Then our logging can go in the wrapper classes, using those errors. That seems like a pattern that solves the "don't duplicate code" problem and the

Re: [Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

I worry about stripping out the wrappers, because there are some differences in how lldb operates from llvm that I don't think we want to push down into llvm - in this case I'm thinking particularly about logging. DataBufferMemoryMap did a bunch of logging, which presumably would get lost if

Re: [Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

This is kind of after the fact, but why didn't we reuse DataBufferMemoryMap for the Memory Map data buffer that now happens to be backed by an LLVM implementation? DataBufferLLVM doesn't really tell anybody what the thing does w/o looking up the implementation. Jim > On Feb 27, 2017, at

Re: [Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

In some classes we have a Clear method that we use to release resources from an object when we are done with it but it might not get destroyed right away. I pretty sure Greg thought that you would be adding your change to such a method; and in fact it would be fine to add a Clear method to

<    2   3   4   5   6   7   8   9   10   11   >