On Thu, 17 Jun 2021 19:17:49 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed method call in glsl shaders
>
> modules/javafx.graphics/src/main/native-prism-
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclus
On Mon, 14 Jun 2021 01:06:25 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclus
On Mon, 14 Jun 2021 17:06:34 GMT, Michael Strauß wrote:
> * Expand the `Property.bind` and `Property.bindBidirectional` documentation
> * Change the name of the formal parameter of `Property.bind` to "source"
> (currently, it is inconsistently named "observable", "rawObservable" or
> "newObserv
On Mon, 14 Jun 2021 01:06:25 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger
wrote:
> Ok, I will try to write an automated test case which draws a sphere in a
> SubScene and then calculates the average color of the generated image. The
> test will be passed if the calculated average does not differ from the
> excepted av
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclusi
On Sun, 13 Jun 2021 23:08:22 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Con
On Fri, 11 Jun 2021 12:54:43 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLigh
On Tue, 8 Jun 2021 21:25:39 GMT, Kevin Rushforth wrote:
> (I need to arrange to get temporary access to a physical Linux box).
I would hope that Oracle can provide the hardware required to test its only
3D-capable library... :)
-
PR: https://git.openjdk.java.net/jfx/pull/334
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Con
On Tue, 8 Jun 2021 14:51:05 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed doc review comments
>
> tests/system/src/test/jav
On Tue, 8 Jun 2021 14:47:39 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed doc review comments
>
> tests/system/src/test/jav
On Tue, 8 Jun 2021 14:20:24 GMT, Kevin Rushforth wrote:
> I reviewed the API docs, and they look good. Can you update the CSR with the
> latest docs and move it to "Proposed"?
I added a single sentence to the direction property saying `It can be rotated
by setting a rotation transform on the {
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
> I intend to test this alone and in connection with your PR.
Alright. I'll keep an eye on this PR.
-
PR: https://git.openjdk.java.net/jfx/pull/531
ouble.
> >
> > As for the names, I have a slight preference for Border.stroke and
> Background.fill.
> >
> > -- Kevin
> >
> >
> > On 6/8/2021 4:25 AM, Nir Lisker wrote:
> >> Are dashed and dotted used frequently? I find that I only use solid
> unless
ing to
> fall back to using constructors.
>
>
> Am Di., 8. Juni 2021 um 03:21 Uhr schrieb Nir Lisker :
> >
> > The new API:
> >
> > 1. `Border.of(Paint stroke)` or `Border.stroke(Paint stroke)` that does
> > `new Border(new BorderStroke(Paint stroke , Border
which I don't like) -- that it seems OK to me.
>
> Can you repost your currently proposed API and see if those who might like
> to use it are satisfied with it?
>
> -- Kevin
>
>
> On 6/7/2021 4:41 PM, Nir Lisker wrote:
>
> Does this constitute sufficient interest i
Does this constitute sufficient interest in the enhancement?
On Thu, May 13, 2021 at 6:41 PM Michael Strauß
wrote:
> Another option could be to mirror the `Color` API in both `Border` and
> `Background`, like in the following examples:
>
> Color.rgb(125, 100, 75)
> Border.rgb(125, 100, 75)
> Bac
On Mon, 7 Jun 2021 13:29:01 GMT, Kevin Rushforth wrote:
> In that case, using computeSpotlightFactor in the GLSL shaders and
> computeSpotlightFactor3 in the HLSL shaders seems like the way to go. If we
> are settled on this, the two you aren't using should be commented out or
> #ifdefed out.
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclus
On Sat, 5 Jun 2021 17:38:27 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated docs per review
>
> modules/javafx.graphics/src/main/java/javafx/scene/Spot
On Sat, 5 Jun 2021 17:27:13 GMT, Kevin Rushforth wrote:
> So it looks like computeSpotlightFactor is the winner. Does that match your
> observations? It might be worth some further tuning.
Yes, on Ubuntu. On Win, `computeSpotlightFactor3` was the best for me. I
detailed my findings in the topm
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Con
On Wed, 2 Jun 2021 12:12:39 GMT, Ambarish Rapte wrote:
> Also I noticed that we are not providing a position property for both Point
> and Spot light. However as of now it seems not required. Should we consider
> to add it in future ?
The translate/layout transforms set the position. The direc
On Mon, 31 May 2021 13:57:22 GMT, Alessadro Parisi
wrote:
> This change allows custom control to change their style dynamically
> When the user-agent stylesheet changes the property automatically calls
> `NodeHelper.reapplyCSS(Region.this);` to recompute the CSS for the node and
> its children
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conc
I created https://github.com/openjdk/jfx/pull/514 as a WIP, ready to be
tested except for tests and apps.
On Sat, May 22, 2021 at 8:56 AM Nir Lisker wrote:
> There is an open bug report [1] that I created before the transition to
> GitHub that fixes BuildSrc and some apps, I will update
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Con
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclusi
On Tue, 25 May 2021 14:40:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/Spot
On Tue, 25 May 2021 14:35:14 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/Spot
On Tue, 25 May 2021 11:30:25 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/Sp
On Tue, 25 May 2021 10:53:37 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/pr
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **C
bindings by hand that are
> cross-platform if you want, though.
>
>
> Speaking of GTK, when is JavaFX going to support GTK4?
>
>
>
>
> On 5/18/21 4:42 PM, Nir Lisker wrote:
> >> there are some advantages in being able to run with the latest JDK LTS
> >>
> > One
that is
>> compelling enough that we want to require that version of the JDK in
>> order to be able to use it.
>>
>> So for this specific discussion: Is there any language feature or API in
>> JDK 12 - 16 that is compelling enough that we would want to bump the JDK
>&
On Fri, 16 Apr 2021 13:26:56 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Combined rotation and direction
>
> modules/javafx.graphics/src/main/java/javaf
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclus
On Fri, 16 Apr 2021 13:33:36 GMT, Ambarish Rapte wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 46:
>>
>>> 44: *
>>> 45: * The light cone is defined by 3 factors: an {@link
>>> #innerAngleProperty() inner angle}, an {@link #outerAngleProperty()
>>> 46: * ou
On Fri, 21 May 2021 19:24:19 GMT, Jose Pereda wrote:
>> This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
>> `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
>> animated GIFs, to the maximum size of the tables used (4096).
>>
>> In some occ
On Fri, 21 May 2021 19:24:19 GMT, Jose Pereda wrote:
>> This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
>> `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
>> animated GIFs, to the maximum size of the tables used (4096).
>>
>> In some occ
There is an open bug report [1] that I created before the transition to
GitHub that fixes BuildSrc and some apps, I will update it for the latest
changes.
Right now I am waiting to see which folders are still relevant.
[1] https://bugs.openjdk.java.net/browse/JDK-8221708
On Thu, May 20, 2021 at
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
d should probably
> be deleted or cleaned up and put somewhere where it is built regularly
> and run at least occasionally.
>
> -- Kevin
>
>
> On 5/20/2021 4:29 PM, Nir Lisker wrote:
> > Hi,
> >
> > I'm looking inside tests/functional and I see that this file
Hi,
I'm looking inside tests/functional and I see that this file
https://github.com/openjdk/jfx/blob/master/tests/functional/animation/javafx/animation/AnimationFunctionalTestBase.java
references com.sun.javafx.functions.Function0, but this class can't be
found. There is also a commented out sec
The Eclipse files are due an update. There were previous reports on issues
on Linux too (probably the ones you mentioned). We were hoping to be able
to remove them with Gradle generating them during the build, but last time
it was checked it couldn't. Don't know if Gradle 7 changed anything.
I saw
I'm getting this error in Eclipse when it tries to load the tasks, but in
the command line I can build and test. I already refreshed the dependencies
and cleaned the cache.
Did you solve this in Eclipse?
On Tue, May 11, 2021 at 1:44 PM Jeanette Winzenburg
wrote:
>
> Thanks Johan, Ajit
>
> --ref
>
> there are some advantages in being able to run with the latest JDK LTS
>
One *potential* issue with this approach is that LTS is not defined in
OpenJDK as far as I know. The LTS versions are a business decision of each
distributor. For now, they have all aligned on 8, 11, 17, but nothing
guara
I would also be surprised if printing and bean adapters are used much, but
what are the options? Rewrite the printing implementation.
On Tue, May 18, 2021 at 8:45 PM Tom Schindl
wrote:
> Uff - I'd like to revisit this topic. As I did some jlink stuff for our
> applications adding java.desktop on
On Fri, 14 May 2021 21:28:15 GMT, Kevin Rushforth wrote:
> There is also the outstanding issue with a retina display (scale=2) on macOS.
Yes, it has to be looked at, but I think it is unrelated to this particular
patch. If this is the case, we can file a different issue and continue with
this
Vote: YES
On Fri, May 14, 2021 at 6:25 PM Kevin Rushforth
wrote:
> Vote: YES
>
> -- Kevin
>
> On 5/14/2021 8:23 AM, Kevin Rushforth wrote:
> > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Reviewer.
>
>
Vote: YES
On Fri, May 14, 2021 at 6:25 PM Kevin Rushforth
wrote:
> Vote: YES
>
> -- Kevin
>
> On 5/14/2021 8:22 AM, Kevin Rushforth wrote:
> > I hereby nominate Arun Joseph [1] to OpenJFX Reviewer.
>
>
gt; BorderStrokeStyle.SOLID)));
> > setBorder(BorderFactory.createSolidBorder(Color.BLACK));
> >
> >
> > Gesendet: Sonntag, 25. April 2021 um 13:05 Uhr
> > Von: "Nir Lisker"
> > An: mariush...@web.de
> > Cc: "openjfx-dev@openjdk.java.net
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
On Tue, 11 May 2021 09:36:29 GMT, Jeanette Winzenburg
wrote:
> was introduced with fix
> [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) which uses
> MockListObserver in tests. Fix is analogous to previous eclipse build
> problems (f.i.
> [JDK-8265513](https://bugs.openjdk.ja
n swing, where you can create a lot of different
>borders easily. (Same to Background)
>Reference:
>[1]https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/cl
>asses/javax/swing/BorderFactory.java
>
>- Marius
>
>
>Gesendet: Donne
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg
wrote:
> Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in
> [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330).
>
> Fix is to add-exports in Eclipse .classpath in graphics (same as done for
> controls in
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
Hi,
Many times when I want to create a simple solid Background or Border, it is
quite a hassle because of the configurability these classes have:
new Border(new BorderStroke(Color. BLACK, BorderStrokeStyle.SOLID, null,
null));
new Background(new BackgroundFill(Color.BLACK, null, null));
I was th
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg
wrote:
> Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in
> [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330).
>
> Fix is to add-exports in Eclipse .classpath in graphics (same as done for
> controls in
On Fri, 9 Apr 2021 20:50:55 GMT, Kevin Rushforth wrote:
>> I will check the range issue on (non-VM) Linux. I don't have a Mac, so not
>> sure what to do if Linux checks out.
>>
>>> As for setting the spot light direction using rotation, I think there are
>>> three API choices, and I don't like
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `Po
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclusi
On Mon, 12 Apr 2021 10:39:07 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (an
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column virtualization.
> Virtualization mode is enabled when the row height is fixed by the following
> method.
>
> `tableView
On Fri, 9 Apr 2021 20:50:55 GMT, Kevin Rushforth wrote:
> I ran it, but didn't spend any time looking at how convenient it would be
> from an API point of view.
I meant convenient for the user. My main concern is that just using rotation
transforms will be frustrating because they don't always
On Fri, 9 Apr 2021 19:01:59 GMT, Kevin Rushforth wrote:
>> If you want to test aiming the light with transforms instead of a direction
>> vector, I modified the `NGSpotLight` and `AttenLightingSample` files to use
>> the rotation transforms.
>>
>> [transforms.zip](https://github.com/openjdk/jf
On Wed, 7 Apr 2021 11:06:53 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (and
ernals and see
how your proposal differs exactly.
By the way, do you make a distinction between ReactFX's Val and Var in
your proposal (one being read-only)?
On Sun, Apr 4, 2021 at 12:43 PM John Hendrikx wrote:
>
>
> On 02/04/2021 08:47, Nir Lisker wrote:
> > Hi John,
On Tue, 6 Apr 2021 12:08:39 GMT, Kevin Rushforth wrote:
>>> Seems like I forgot to hit the send button on the webform. Here's the
>>> tracking number: 9069787.
>>
>> I see it now. And thanks for providing the benchmark. That's what I was
>> looking for.
>
> The bug is now visible here: https:/
Hi John,
I've had my eyes set on ReactFX enhancements for a while too, especially as
a replacement for the unsafe "select" mechanism. One of the things that
kept me from going forward with this is seeing what Valhalla will bring.
Generic specialization might save a lot of duplication work on somet
On Tue, 30 Mar 2021 13:31:36 GMT, Jeanette Winzenburg
wrote:
>>> hmm ... failing checks, why?
>>
>> The failure on Windows is because your branch isn't up-to-date with
>> `master`, and is missing a recent fix to the Window build. You can either
>> `git merge master` (after updating your `mast
Can you make it private? This way we could still see if there are relevant
issues there like those that halted during the transition.
On Sun, Mar 28, 2021 at 3:24 PM Johan Vos wrote:
> I'm creating a separate thread for this, as it might get lost in other
> threads.
> We see that issues are stil
On Mon, 29 Mar 2021 15:17:22 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java
>> line 250:
>>
>>> 248: *
>>> 249: * @param observable the observable to observe for invalidation
>>> events
>>> 250: * @param consumer the
On Mon, 29 Mar 2021 15:53:55 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (an
What is "javafx:run"? If you run it from within Eclipse (the green "play"
button), does it work?
On Fri, Mar 26, 2021 at 10:08 AM Tom Eugelink wrote:
> To prevent me from going on a long search-and-rescue, I figured I'd post a
> small question here.
>
> I'm trying to run an application with the
There's no question that the JBS is the way to go for handling existing
reports.
As for incoming reports, I dislike the GitHub issues as they are just a
text dump, and many reporters are not careful about giving you versions
(Java/JavaFX/OS...) or working environment details. You can help GitHub
w
he parameter map, but only for type
>> safety.
>> >
>> > This is assuming I understand how the APIs work and I am not overlooking
>> > something crucial.
>> >
>> > On Mon, Mar 15, 2021 at 4:51 AM Nir Lisker wrote:
>> >
>> >> I
On Thu, 25 Mar 2021 02:02:25 GMT, Nir Lisker wrote:
>>> I the rotation needs to apply to whatever the direction vector is: whether
>>> that's implicitly (0,0,1) if we don't provide a separate direction vector
>>> or whether it's the user pro
On Thu, 25 Mar 2021 22:08:36 GMT, Kevin Rushforth wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> Kevin Rushforth has updated the pull request incrementally with one
> additiona
On Thu, 25 Mar 2021 13:21:24 GMT, Johan Vos wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> Good catch. Test fails before and succeeds after the patch.
By the way, this class co
On Thu, 25 Mar 2021 14:15:47 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/input/MouseEventTest.java
>> line 139:
>>
>>> 137: case ']':
>>> 138: --bracketCount;
>>> 139: assertTrue("Too many closing
What are these email addresses?
On Thu, Mar 25, 2021 at 1:12 PM Kevin Rushforth
wrote:
> Eventually the openjdk.org addresses will be live. I haven't heard a
> recent update on the timing for this. Until then, adding the email
> address as an unverified additional email address in your GitHub pr
On Thu, 25 Mar 2021 13:29:44 GMT, Jeanette Winzenburg
wrote:
>> Can you list the other affected methods?
>
>>
>>
>> Can you list the other affected methods?
>
> at line 211 (in the changed skinBase)
>
> /**
> * Subclasses can invoke this method to register that they want to listen
> to
On Thu, 25 Mar 2021 12:29:38 GMT, Kevin Rushforth wrote:
> Simple fix to add a missing closing bracket to `PickResult::toString`. This
> includes a unit test that fails without the fix and passes with the fix.
modules/javafx.graphics/src/main/java/javafx/scene/input/PickResult.java line
204:
On Thu, 25 Mar 2021 11:25:18 GMT, Jeanette Winzenburg
wrote:
>> I reviewed only the public API methods.
>
> @nlisker thanks for the detailed doc review - I really like your suggestions,
> which I think are considerable improvements (I did part of it in the
> respective methods of the handler)
On Thu, 25 Mar 2021 00:54:33 GMT, Nir Lisker wrote:
>>> I would like to allow a developer to achieve a functionality like is shown
>>> in https://www.youtube.com/watch?v=CFgwZX5dkcM at 9:50. The rotations are
>>> intuitive there. If we allow both rotation
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Co
On Mon, 22 Mar 2021 23:55:34 GMT, Kevin Rushforth wrote:
> I the rotation needs to apply to whatever the direction vector is: whether
> that's implicitly (0,0,1) if we don't provide a separate direction vector or
> whether it's the user provided direction vector, it would be odd to ignore
> tr
On Tue, 23 Feb 2021 12:06:08 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (an
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclu
On Sun, 21 Mar 2021 17:48:10 GMT, Nir Lisker wrote:
>> Finally getting back to this.
>>
>> There is an outstanding API question regarding the direction vector: Should
>> the transforms of the SpotLight node to scene coordinates affect the
>> direction vector (e.
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **Conclus
On Fri, 19 Mar 2021 21:01:58 GMT, Kevin Rushforth wrote:
> There is an outstanding API question regarding the direction vector: Should
> the transforms of the SpotLight node to scene coordinates affect the
> direction vector (e.g., such that a rotation would rotate the direction the
> spotligh
ps, so we
> can't measure the real GPU performance change.
> The mesh 5000 test shows 2-6 fps drop from master, with
> `computeSpotlightFactor` > `computeSpotlightFactor2` >
> `computeSpotlightFactor3` at in terms of performance (~2 fps difference each).
>
> **C
The mailing lists are only for development and discussion purposes. If you
think there's a bug or a missing feature you can ask here, but if you need
help then there is no formal mailing list for that.
If SO didn't help, you can try r/JavaFX on Reddit or search for a
JavaFX discord server.
On Mon,
901 - 1000 of 1597 matches
Mail list logo
