Re: [Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

omjavaid added inline comments. Comment at: source/Target/Target.cpp:714 @@ -713,2 +713,3 @@ { uint32_t num_current_watchpoints = target->GetWatchpointList().GetSize(); +if (num_supported_hardware_watchpoints == 0) clayborg wrote: > This

[Lldb-commits] [lldb] r273863 - Allow unaligned byte/word selection watchpoints for arm- linux/android targets.

Author: omjavaid Date: Mon Jun 27 06:18:23 2016 New Revision: 273863 URL: http://llvm.org/viewvc/llvm-project?rev=273863=rev Log: Allow unaligned byte/word selection watchpoints for arm- linux/android targets. Differential revision: http://reviews.llvm.org/D21516 Modified:

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL272916: Allow installing watchpoints at less than 8-byte alligned addresses for… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D21280?vs=60942=60987#toc Repository: rL

[Lldb-commits] [lldb] r272916 - Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

Author: omjavaid Date: Thu Jun 16 11:41:22 2016 New Revision: 272916 URL: http://llvm.org/viewvc/llvm-project?rev=272916=rev Log: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets This patch allows LLDB for AArch64 to watch all bytes, words or double words

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid marked 3 inline comments as done. Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:104 @@ +103,3 @@ +self.expect("watchpoint list -v", +substrs = ['hit_count = 2']) +

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid updated this revision to Diff 60942. omjavaid added a comment. Herald added a subscriber: srhines. I have added a test cases that tests all possibilities supported by current configuration. Tests pass on Nexus 9 and aarch64-linux-gnu (hikey board). LGTM?

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid added a comment. In http://reviews.llvm.org/D21280#457196, @labath wrote: > The overall change looks good, but please also add a test which specifically > tests for watchpoints at unaligned addresses. Last time I checked, we all > watchpoint tests were passing (at least on android)

[Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

omjavaid created this revision. omjavaid added reviewers: labath, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. This patch adds logic to make sure we can install watchpoints at 1,2 and 4 byte alligned addresses. ptrace

[Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

omjavaid created this revision. omjavaid added reviewers: tberghammer, labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch takes a few corrective measures to make sure we display meaningful reason against a watchpoint creation failure.

Re: [Lldb-commits] [lldb] r270745 - Mark some arm-linux specific xfails marking bug entries

On 26 May 2016 at 18:07, Pavel Labath <lab...@google.com> wrote: > Omair, > > please be careful about using arm xfails. You are using too wide > annotations and disabling tests even on configurations where they are > known to pass. > > > On 25 May 2016 at 19:48,

[Lldb-commits] [lldb] r270780 - Mark some aarch64-linux specific xfails marking bug entries

Author: omjavaid Date: Wed May 25 17:30:05 2016 New Revision: 270780 URL: http://llvm.org/viewvc/llvm-project?rev=270780=rev Log: Mark some aarch64-linux specific xfails marking bug entries TestBSDArchives.py and TestWatchLocation.py fail due to unicode error and bug has already been reported

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

omjavaid accepted this revision. omjavaid added a comment. Seems to be causing no regressions on arm-linux. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r269980 - xfail TestTopLevelExprs for arm and aarch64 linux

Author: omjavaid Date: Wed May 18 15:45:12 2016 New Revision: 269980 URL: http://llvm.org/viewvc/llvm-project?rev=269980=rev Log: xfail TestTopLevelExprs for arm and aarch64 linux TestTopLevelExprs fails on arm and aarch64 linux similar to behaviour on android. A bug exists here:

[Lldb-commits] [lldb] r269860 - xfail TestWatchLocation.py for arm-linux targets

Author: omjavaid Date: Tue May 17 18:01:56 2016 New Revision: 269860 URL: http://llvm.org/viewvc/llvm-project?rev=269860=rev Log: xfail TestWatchLocation.py for arm-linux targets TestWatchLocation.py fails on arm-linux target due to unicode error in lldb testsuite. This is a known issue and

[Lldb-commits] [lldb] r269647 - Xfail TestCrashDuringStep and TestCreateDuringInstructionStep on arm-linux

Author: omjavaid Date: Mon May 16 06:21:49 2016 New Revision: 269647 URL: http://llvm.org/viewvc/llvm-project?rev=269647=rev Log: Xfail TestCrashDuringStep and TestCreateDuringInstructionStep on arm-linux Both of above tests fail on arm and bugs have been reported on android already. Adding

[Lldb-commits] [lldb] r269187 - Xfail failing watchpoint tests on aarch64-linux

Author: omjavaid Date: Wed May 11 08:57:20 2016 New Revision: 269187 URL: http://llvm.org/viewvc/llvm-project?rev=269187=rev Log: Xfail failing watchpoint tests on aarch64-linux Some watchpoint tests fail on aarch64-linux as it lacks support for intalling watchpoints which are not alligned at

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

omjavaid added a comment. In case of ELF .arm attributes contains tags providing information on underlying CPU specification used. Thats only for the inferior being debugged but actually knowing which target we are running on, like for example if we want to figure out if we are running on a

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

omjavaid added a comment. @sas Ideally it should be thumb-* if an environment is thumb only but lldb right now has some areas where we need to handle this case. Either you put arm-* and leave it for someone else to correct the problems or put thumb-* and fix the issues that come up after that.

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. Please see inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149 @@ +148,3 @@ +{ +

[Lldb-commits] [lldb] r267550 - rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

Author: omjavaid Date: Tue Apr 26 06:26:00 2016 New Revision: 267550 URL: http://llvm.org/viewvc/llvm-project?rev=267550=rev Log: rL267291: Architecture change to thumb on parsing arm.attributes causes regression. Remove case handling elf arm attribute Tag_THUMB_ISA_use and setting

Re: [Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267550: rL267291: Architecture change to thumb on parsing arm.attributes causes… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D19520?vs=54961=54993#toc Repository: rL

[Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

omjavaid created this revision. omjavaid added reviewers: tberghammer, labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. rL267291 introduces a lot of regression on arm-linux by fixing module architecture to thumb if it finds thumb32 tag set.

[Lldb-commits] [lldb] r267508 - Fix arm-linux-gnueabi regression due to rL267291

Author: omjavaid Date: Mon Apr 25 20:08:59 2016 New Revision: 267508 URL: http://llvm.org/viewvc/llvm-project?rev=267508=rev Log: Fix arm-linux-gnueabi regression due to rL267291 rL267291 introduces a lot regression on arm-linux LLDB testsuite. This patch fixes half of them. I am merging it

Re: [Lldb-commits] [PATCH] D19252: Handle invalid values of PLT entry size generated by ld + gcc on arm linux targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267405: Handle invalid values of PLT entry size generated by linker (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D19252?vs=54146=54845#toc Repository: rL LLVM

[Lldb-commits] [lldb] r267405 - Handle invalid values of PLT entry size generated by linker

Author: omjavaid Date: Mon Apr 25 08:45:39 2016 New Revision: 267405 URL: http://llvm.org/viewvc/llvm-project?rev=267405=rev Log: Handle invalid values of PLT entry size generated by linker Make sure we figure out correct plt entry field in case linker has generated a small value below

[Lldb-commits] [PATCH] D19252: Handle invalid values of PLT entry size generated by ld + gcc on arm linux targets.

omjavaid created this revision. omjavaid added reviewers: tberghammer, rengolin, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. This patch provides a fix for wrong plt entry size generated for binaries built with gcc and

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

omjavaid accepted this revision. omjavaid added a comment. LGTM http://reviews.llvm.org/D18984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

omjavaid added a comment. Seems legit but One cosmetic comment inline. Also have you tested this patch by running LLDB testsuite on arm in both little and big endian modes? Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:157 @@ -149,12 +156,3 @@ { -if

Re: [Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

omjavaid added a reviewer: clayborg. omjavaid added a comment. I dont have a lot of background in this area of the code. Can you kindly take a look. http://reviews.llvm.org/D18059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D17716: Add complex and aggregate with vector types return value test cases

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. This patch adds tests to test complex return types and aggregate return types with vector elements. http://reviews.llvm.org/D17716 Files:

Re: [Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262218: Add/Improve complex, vector, aggregate types handling for SysV ARM… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D17708?vs=49353=49364#toc Repository: rL LLVM

[Lldb-commits] [lldb] r262218 - Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

Author: omjavaid Date: Mon Feb 29 07:39:20 2016 New Revision: 262218 URL: http://llvm.org/viewvc/llvm-project?rev=262218=rev Log: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI. For details see: Differential revision: http://reviews.llvm.org/D17708

[Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds code to SysV ARM ABI for handling complex and aggregates containing complex return types. It also improves support for

[Lldb-commits] [lldb] r261734 - Fix test for homogeneity in case of aggregate consisting of containerized vector types

Author: omjavaid Date: Wed Feb 24 06:17:43 2016 New Revision: 261734 URL: http://llvm.org/viewvc/llvm-project?rev=261734=rev Log: Fix test for homogeneity in case of aggregate consisting of containerized vector types Details can be found here: Differential revision:

Re: [Lldb-commits] [PATCH] D17501: Fix test for homogeneity in case of aggregate consisting of containerized vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rL261734: Fix test for homogeneity in case of aggregate consisting of containerized… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D17501?vs=48663=48909#toc Repository: rL

Re: [Lldb-commits] [PATCH] D17501: Fix test for homogeneity in case of aggregate consisting of containerized vector types

omjavaid added a comment. Just to mention this simplifies vector return type handling for ARM. A patch implementing that is following up if this gets approves. http://reviews.llvm.org/D17501 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D17501: Fix test for homogeneity in case of aggregate consisting of containerized vector types

omjavaid created this revision. omjavaid added a reviewer: clayborg. omjavaid added a subscriber: lldb-commits. Herald added a subscriber: aemerson. This patch ClangASTContext::IsHomogeneousAggregate test for homogeneity in light of Arm procedure call standard definition of a homogeneous

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid added a comment. Is this good to go ? http://reviews.llvm.org/D16975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r260512 - Handle floating-point type homogeneous aggregate return values in ABISysV_arm

Author: omjavaid Date: Thu Feb 11 05:41:22 2016 New Revision: 260512 URL: http://llvm.org/viewvc/llvm-project?rev=260512=rev Log: Handle floating-point type homogeneous aggregate return values in ABISysV_arm For details refer to review link given below. Differential revision:

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid added inline comments. Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:658 @@ -582,2 +657,3 @@ + if (byte_size <= 4) { Homogenous types with elements more than 4 will fall through and will be handled by this even in case of

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL260512: Handle floating-point type homogeneous aggregate return values in ABISysV_arm (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D16975?vs=47625=47626#toc Repository:

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

omjavaid added a comment. GDB doesnt use bkpt instruction for user debugging for the reason that it interferes with jtag debug probes. I am not sure if LLDB will be ever used with a jtag probe in near future but still a jtag prob might be connected to the same hardware which is using LLDB to

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid updated this revision to Diff 47191. omjavaid added a comment. updated diff after incorporating suggested corrections. http://reviews.llvm.org/D16975 Files: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp Index: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid added inline comments. Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:581-591 @@ -580,10 +580,13 @@ { size_t byte_size = compiler_type.GetByteSize(); if (byte_size <= 4) { RegisterValue r0_reg_value;

Re: [Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid updated this revision to Diff 47198. omjavaid added a comment. Updated adding float_count check. http://reviews.llvm.org/D16975 Files: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp Index: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

[Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Arm hard float ABI can use floating point registers for returning structures containing all 4 or 8 byte floating point

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL259885: Add support to detect arm hard float ABI based binaries for ABISysV_arm (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D16627?vs=46620=47014#toc Repository: rL LLVM

[Lldb-commits] [lldb] r259885 - Add support to detect arm hard float ABI based binaries for ABISysV_arm

Author: omjavaid Date: Fri Feb 5 08:37:53 2016 New Revision: 259885 URL: http://llvm.org/viewvc/llvm-project?rev=259885=rev Log: Add support to detect arm hard float ABI based binaries for ABISysV_arm This patch adds logic to detect if underlying binary is using arm hard float abi and use that

Re: [Lldb-commits] [PATCH] D16772: Fix single stepping over the IT instruction

omjavaid accepted this revision. omjavaid added a comment. Looks good. Was there a test failing in testsuite due to this? http://reviews.llvm.org/D16772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds logic to detect if underlying binary is using arm hard float abi and use that information while handling

[Lldb-commits] [lldb] r258930 - Decorarte TestInferiorAssert xfails on AArch64 Linux

Author: omjavaid Date: Wed Jan 27 07:57:33 2016 New Revision: 258930 URL: http://llvm.org/viewvc/llvm-project?rev=258930=rev Log: Decorarte TestInferiorAssert xfails on AArch64 Linux This patch decorates some of TestInferiorAssert test cases with expectedFailureLinux on AArch64. Modified:

[Lldb-commits] [lldb] r257405 - Xfail some Arm-Linux specific failures

Author: omjavaid Date: Mon Jan 11 16:52:18 2016 New Revision: 257405 URL: http://llvm.org/viewvc/llvm-project?rev=257405=rev Log: Xfail some Arm-Linux specific failures Updated expectedFailureLinux decorator to reflect architecture Marked some triaged failures as xfails on arm with updated

Re: [Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rL257405: Xfail some Arm-Linux specific failures (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15893?vs=44550=44563#toc Repository: rL LLVM http://reviews.llvm.org/D15893

Re: [Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

omjavaid updated this revision to Diff 44550. omjavaid added a comment. Removed expectedFailureArmLinux and updated expectedFailureLinux decorator to reflect architecture if needed. Marked some triaged failures as xfails on arm with updated expectedFailureLinux decorator. LGTM?

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

omjavaid added a subscriber: omjavaid. omjavaid added a comment. LGTM. I think we should submit this patch as tberghammer explained. http://reviews.llvm.org/D15533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

LGTM. I think we should submit this patch as tberghammer explained. On 8 January 2016 at 19:24, Tamas Berghammer wrote: > tberghammer added a comment. > > @omjavaid: What is your opinion about submitting this patch in its current > form with knowing that setting

Re: [Lldb-commits] [PATCH] D15877: Fix for undefined behavior while updating PC value on arm-linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL256847: Fix for undefined behavior while updating PC value on arm-linux (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15877?vs=43941=44015#toc Repository: rL LLVM

[Lldb-commits] [lldb] r256847 - Fix for undefined behavior while updating PC value on arm-linux

Author: omjavaid Date: Tue Jan 5 10:56:13 2016 New Revision: 256847 URL: http://llvm.org/viewvc/llvm-project?rev=256847=rev Log: Fix for undefined behavior while updating PC value on arm-linux Differential revision: http://reviews.llvm.org/D15877 Modified:

[Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

omjavaid created this revision. omjavaid added a reviewer: clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds a new expectedFailureArmLinux which marks arm-linux tests as xfails. Also marked a couple of failing tests to use

[Lldb-commits] [PATCH] D15877: Fix for undefined behavior while updating PC value on arm-linux

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch provides fix for the cases where an expression or jump tries to update the value of PC in thumb mode. As

Re: [Lldb-commits] [PATCH] D15357: Update code to silent some ARM/ARM64 specific compiler warnings

omjavaid abandoned this revision. omjavaid added a comment. Let the warnings stay for now. http://reviews.llvm.org/D15357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

omjavaid abandoned this revision. omjavaid added a comment. Correction made upstream by @tberghammer. http://reviews.llvm.org/D15355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r255499 - Add failure paths to a few JSONNumber members

Author: omjavaid Date: Mon Dec 14 08:52:07 2015 New Revision: 255499 URL: http://llvm.org/viewvc/llvm-project?rev=255499=rev Log: Add failure paths to a few JSONNumber members Differential revision: http://reviews.llvm.org/D15355 Modified: lldb/trunk/include/lldb/Utility/JSON.h

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

This revision was automatically updated to reflect the committed changes. Closed by commit rL255499: Add failure paths to a few JSONNumber members (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15355?vs=42706=42712#toc Repository: rL LLVM

[Lldb-commits] [lldb] r255547 - Correction in TestFrames.py test for arm targets in thumb mode

Author: omjavaid Date: Mon Dec 14 15:41:18 2015 New Revision: 255547 URL: http://llvm.org/viewvc/llvm-project?rev=255547=rev Log: Correction in TestFrames.py test for arm targets in thumb mode Differential revision: http://reviews.llvm.org/D15061 Modified:

Re: [Lldb-commits] [PATCH] D15061: Correction in TestFrames.py test for arm targets in thumb mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL255547: Correction in TestFrames.py test for arm targets in thumb mode (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15061?vs=41359=42765#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D15357: Update code to silent some ARM/ARM64 specific compiler warnings

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Following changes remove conditions where an unsigned integer is being tested to be greater or equal to zero. These conditions will

[Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. This patch updates GetAsUnsigned(), GetAsSigned(), and GetAsDouble() JSONNumber functions to add failure check. The previous code was generating compiler warnings for not being

[Lldb-commits] [PATCH] D15061: Correction in TestFrames.py test for arm targets in thumb mode

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds required correction in TestFrames.py for arm targets in thumb mode. On arm hardware thumb mode is identified by

Re: [Lldb-commits] [PATCH] D14985: Add 64/128 bit arm neon register definitions on linux

omjavaid added a comment. Some minor typos inline comments. I havnt applied nd tested this patch. Are you able to read these registers, i guess you need to generate neon or vfp code to test all registers properly. There no arm register test to my knowledge currently in testsuite we can put

[Lldb-commits] [lldb] r253973 - Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

Author: omjavaid Date: Tue Nov 24 04:35:03 2015 New Revision: 253973 URL: http://llvm.org/viewvc/llvm-project?rev=253973=rev Log: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets. Differential revision: http://reviews.llvm.org/D14823 Modified:

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253973: Disable forcing -marm (A32 instruction set) while running testsuite on arm… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D14823?vs=40652=41017#toc Repository: rL

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

omjavaid added a comment. I agree with you on having multiple configuration options to help identify failures in different configurations. What I mean is that we should keep clarity on architecture that is to use arm or aarch32 for 32bit and aarch64 for 64bit. With that we should run tests in

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

omjavaid added a comment. -mthumb and -marm are compiler flags so we can put these into our CXX or CFLAGS if we need to run those configurations. http://reviews.llvm.org/D14823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch disables forcing -marm (A32 instruction set) while running lldb testsuite on arm targets. gcc uses -marm and

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

omjavaid added a subscriber: omjavaid. omjavaid added a comment. -mthumb will force T32 instruction set while -marm will force A32. Best is not to use any of these flags to let the compiler decide best possible instruction set combination. http://reviews.llvm.org/D14816

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

-mthumb will force T32 instruction set while -marm will force A32. Best is not to use any of these flags to let the compiler decide best possible instruction set combination. On 19 November 2015 at 20:38, Oleksiy Vyalov via lldb-commits wrote: > ovyalov accepted

[Lldb-commits] [lldb] r252298 - Fix for AArch64 watchpoint cache corruption in case of ptrace failure

Author: omjavaid Date: Fri Nov 6 06:56:34 2015 New Revision: 252298 URL: http://llvm.org/viewvc/llvm-project?rev=252298=rev Log: Fix for AArch64 watchpoint cache corruption in case of ptrace failure Same fix has been submitted for Arm. Review can be found here: Differential revision:

Re: [Lldb-commits] [PATCH] D14051: Fix for Arm watchpoint cache corruption in case of ptrace failure

This revision was automatically updated to reflect the committed changes. Closed by commit rL251386: Fix for Arm watchpoint cache corruption in case of ptrace failure (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D14051?vs=38364=38502#toc Repository: rL LLVM

[Lldb-commits] [lldb] r251386 - Fix for Arm watchpoint cache corruption in case of ptrace failure

Author: omjavaid Date: Tue Oct 27 00:56:56 2015 New Revision: 251386 URL: http://llvm.org/viewvc/llvm-project?rev=251386=rev Log: Fix for Arm watchpoint cache corruption in case of ptrace failure Differential revision: http://reviews.llvm.org/D14051 Modified:

[Lldb-commits] [lldb] r251269 - Corrects return values and typos in Arm watchpoint code

Author: omjavaid Date: Sun Oct 25 18:18:35 2015 New Revision: 251269 URL: http://llvm.org/viewvc/llvm-project?rev=251269=rev Log: Corrects return values and typos in Arm watchpoint code This is just a trivial patch that corrects a couple of return value account to function's return type. Also

Re: [Lldb-commits] [PATCH] D12522: AArch64 Watchpoints: Make sure we are only setting supported no of debug registers.

omjavaid updated this revision to Diff 37748. omjavaid added a comment. This patch fixes unexpected behaviour of watchpoint code on Nexus 9 (AArch64). http://reviews.llvm.org/D12522 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp Index:

[Lldb-commits] [lldb] r250700 - Fix for random watchpoint testsuite failures on AArch64 targets.

Author: omjavaid Date: Mon Oct 19 09:54:33 2015 New Revision: 250700 URL: http://llvm.org/viewvc/llvm-project?rev=250700=rev Log: Fix for random watchpoint testsuite failures on AArch64 targets. This patch corrects the number of bytes of debug register resources which are written while

Re: [Lldb-commits] [PATCH] D12522: AArch64 Watchpoints: Make sure we are only setting supported no of debug registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250700: Fix for random watchpoint testsuite failures on AArch64 targets. (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D12522?vs=37748=37758#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch fixes a few areas where AArch64 hardware watchpoints were not emitting errors correctly. This makes sure any

[Lldb-commits] [lldb] r245961 - Adds support for hardware watchpoints on Arm targets.

Author: omjavaid Date: Tue Aug 25 13:22:04 2015 New Revision: 245961 URL: http://llvm.org/viewvc/llvm-project?rev=245961view=rev Log: Adds support for hardware watchpoints on Arm targets. http://reviews.llvm.org/D9703 This updated patches correct problems in arm hardware watchpoint support

[Lldb-commits] [lldb] r245428 - Fix lldb-server arm-linux-g++ build

Author: omjavaid Date: Wed Aug 19 05:44:16 2015 New Revision: 245428 URL: http://llvm.org/viewvc/llvm-project?rev=245428view=rev Log: Fix lldb-server arm-linux-g++ build Modified: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp Modified:

[Lldb-commits] [PATCH] D11899: Fix AArch64 watchpoint handlers in NativeRegisterContextLinux_arm64

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. There were some bugs that needed to be fixed in watchpoint handling code on arm64. Watchpoints were being written to all

<    1   2   3   4