https://github.com/labath commented:
I'm wondering if there's a more fundamental fix to be made here. Like perhaps
treating treating any allocatable SHT_NOBITS section as ZeroFill.
Basically to add `case SHT_NOBITS: if (H.sh_flags & SHF_ALLOC) return
eSectionTypeZeroFill;` to `GetSectionType`
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/96687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -10,9 +10,10 @@
class TestDAP_stepInTargets(lldbdap_testcase.DAPTestCaseBase):
-@skipIf(
-archs=no_match(["x86_64"])
-) # InstructionControlFlowKind for ARM is not supported yet.
+@skipIf
+# InstructionControlFlowKind for ARM is not supported yet.
@@ -1595,49 +1627,67 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE ) {
if (qualified_name.empty())
qualified_name.append("::");
- qualified_name.append(name);
+ qualified_name.append(unique_typename.GetCString());
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Looks good. Third time's the charm.
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/98690
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -405,8 +405,11 @@ def run_step_over_load(self):
# We can't find a breakpoint location for d_init before launching because
# executable dependencies are resolved relative to the debuggers PWD. Bug?
+# The remote lldb server resolves the executable dependencies
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const
DWARFDIE ) {
return {};
}
+void DWARFASTParserClang::MappingDeclDIEToDefDIE(
+const lldb_private::plugin::dwarf::DWARFDIE _die,
+const lldb_private::plugin::dwarf::DWARFDIE _die) {
+
@@ -10,9 +10,10 @@
class TestDAP_stepInTargets(lldbdap_testcase.DAPTestCaseBase):
-@skipIf(
-archs=no_match(["x86_64"])
-) # InstructionControlFlowKind for ARM is not supported yet.
+@skipIf
+# InstructionControlFlowKind for ARM is not supported yet.
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/98330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Thanks for pinging this. Sorry it dropped off my radar.
https://github.com/llvm/llvm-project/pull/90075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -1603,41 +1633,76 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE ) {
TypeSP
DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext ,
- const DWARFDIE _die,
+
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const
DWARFDIE ) {
return {};
}
+void DWARFASTParserClang::MappingDeclDIEToDefDIE(
+const lldb_private::plugin::dwarf::DWARFDIE _die,
+const lldb_private::plugin::dwarf::DWARFDIE _die) {
+
@@ -4,8 +4,8 @@
// REQUIRES: lld
-// RUN: %clang --target=x86_64-pc-linux -c %s -o %t-a.o -g
-gsimple-template-names -DFILE_A
-// RUN: %clang --target=x86_64-pc-linux -c %s -o %t-b.o -g
-gsimple-template-names -DFILE_B
labath wrote:
We should keep the
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const
DWARFDIE ) {
return {};
}
+void DWARFASTParserClang::MappingDeclDIEToDefDIE(
labath wrote:
nit: Maybe you're reading this another way, but this name does not sound like a
verb
https://github.com/labath commented:
Thanks. I think this looks pretty good now, just a couple of details to sort
out.
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const
DWARFDIE ) {
return {};
}
+void DWARFASTParserClang::MappingDeclDIEToDefDIE(
+const lldb_private::plugin::dwarf::DWARFDIE _die,
+const lldb_private::plugin::dwarf::DWARFDIE _die) {
+
@@ -1631,27 +1638,49 @@ bool SymbolFileDWARF::CompleteType(CompilerType
_type) {
return true;
}
- DWARFDIE dwarf_die = GetDIE(die_it->getSecond());
- if (dwarf_die) {
-// Once we start resolving this type, remove it from the forward
-// declaration map in
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1631,26 +1638,48 @@ bool SymbolFileDWARF::CompleteType(CompilerType
_type) {
return true;
}
- DWARFDIE dwarf_die = GetDIE(die_it->getSecond());
- if (dwarf_die) {
-// Once we start resolving this type, remove it from the forward
-// declaration map in
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/98293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> LGTM.
>
> As a nice to have, maybe add a short explanation to the first mutex
> explaining that these operations are only allowed between thread lists
> belonging to the same process. Your current comment makes it sound as if that
> only applies _if_ the processes are the
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/98293
>From 0a594fea0a5db3ebc8de74edbcd051cbac911697 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 10 Jul 2024 04:06:42 +0200
Subject: [PATCH 1/2] [lldb] Fix ThreadList assignment race
ThreadList uses the
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/96538
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -254,6 +256,29 @@ lldb_private::formatters::LibcxxStdMapSyntheticFrontEnd::
Update();
}
+llvm::Expected
+lldb_private::formatters::LibcxxStdMapSyntheticFrontEnd::
+CalculateNumChildrenForOldCompressedPairLayout() {
+ ValueObjectSP
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/96538
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,89 @@
+#ifndef STD_LLDB_COMPRESSED_PAIR_H
+#define STD_LLDB_COMPRESSED_PAIR_H
+
+#include <__memory/compressed_pair.h>
+#include
+
+namespace std {
+namespace __lldb {
+
+#if COMPRESSED_PAIR_REV == 0 // Post-c88580c layout
+struct __value_init_tag {};
+struct
@@ -0,0 +1,89 @@
+#ifndef STD_LLDB_COMPRESSED_PAIR_H
+#define STD_LLDB_COMPRESSED_PAIR_H
+
+#include <__memory/compressed_pair.h>
+#include
+
+namespace std {
+namespace __lldb {
+
+#if COMPRESSED_PAIR_REV == 0 // Post-c88580c layout
+struct __value_init_tag {};
+struct
@@ -0,0 +1,43 @@
+#include "../compressed_pair.h"
labath wrote:
We have some common includes in `packages/Python/lldbsuite/test/make/`. I think
it'd be better to put this there (probably in a subdirectory)
https://github.com/llvm/llvm-project/pull/98330
https://github.com/labath commented:
I'm like this approach. It can be a lot of work, so we may not be able to get
every contributor to do this, but I'd certainly encourage everyone to try.
https://github.com/llvm/llvm-project/pull/98330
___
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -170,6 +170,10 @@ enum Format {
eFormatHex,
eFormatHexUppercase,
eFormatFloat,
+ eFormatFloat128, //< Disambiguate between 128-bit `long double` (which uses
labath wrote:
This list should be appended to at the end to preserve the values of existing
@@ -334,6 +334,8 @@ static const llvm::fltSemantics (const
TargetSP _sp,
return llvm::APFloat::IEEEsingle();
case 8:
return llvm::APFloat::IEEEdouble();
+case 16:
+ return llvm::APFloat::IEEEquad();
labath wrote:
This may not be a
@@ -819,6 +823,7 @@ enum BasicType {
eBasicTypeFloat,
eBasicTypeDouble,
eBasicTypeLongDouble,
+ eBasicTypeFloat128,
labath wrote:
The same goes here, although apparently https://reviews.llvm.org/D120690 has
snuck through and nobody noticed.
https://github.com/labath approved this pull request.
LGTM. Coincidentally, I was just working on a bug where this was (a part of)
the problem. :)
https://github.com/llvm/llvm-project/pull/98432
___
lldb-commits mailing list
@@ -27,12 +27,13 @@ class ThreadList : public ThreadCollection {
friend class Process;
public:
- ThreadList(Process *process);
+ ThreadList(Process );
ThreadList(const ThreadList );
~ThreadList() override;
+ // Precondition: both thread lists must be belong
@@ -736,11 +734,12 @@ void ThreadList::NotifySelectedThreadChanged(lldb::tid_t
tid) {
void ThreadList::Update(ThreadList ) {
if (this != ) {
-// Lock both mutexes to make sure neither side changes anyone on us while
-// the assignment occurs
-std::scoped_lock
labath wrote:
Previous attempt to fix this issue: https://reviews.llvm.org/D158034
https://github.com/llvm/llvm-project/pull/98293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/98293
ThreadList uses the Process mutex to guard its state. This means its not
possible to safely modify its process member, as the member is required to lock
the mutex.
Fortunately for us, we never actually need to
Author: Pavel Labath
Date: 2024-07-10T09:36:26Z
New Revision: 14ba847d273a0defe0f4617bcfe9e1b2163e2bbc
URL:
https://github.com/llvm/llvm-project/commit/14ba847d273a0defe0f4617bcfe9e1b2163e2bbc
DIFF:
https://github.com/llvm/llvm-project/commit/14ba847d273a0defe0f4617bcfe9e1b2163e2bbc.diff
LOG:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/98154
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4194,8 +4188,7 @@ bool Process::ProcessEventData::ShouldStop(Event
*event_ptr,
// is, and it's better to let the user decide than continue behind their
// backs.
- for (idx = 0; idx < not_suspended_thread_list.GetSize(); ++idx) {
-curr_thread_list =
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/98154
>From 27d419b047d0c2e95978b8c88dd84641aae423f2 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 9 Jul 2024 15:00:05 +0200
Subject: [PATCH] [lldb] Small cleanup of ProcessEventData::ShouldStop
While looking
https://github.com/labath approved this pull request.
Thank you.
https://github.com/llvm/llvm-project/pull/96654
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/98154
While looking at a TSAN report (patch coming soon) in the ThreadList class, I
noticed that this code would be simpler if it did not use the ThreadList class.
>From 2e74468a99015645f1abbfdf42f6e5c9893e7cf3 Mon
@@ -113,6 +130,10 @@ def _get_platform_os(p):
platform = "openbsd"
return platform
+# Triple is not available if we're not connected yet
+if p.GetName() == "remote-linux":
+return "linux"
+
labath wrote:
Yes, I would very
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/98144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -113,6 +130,10 @@ def _get_platform_os(p):
platform = "openbsd"
return platform
+# Triple is not available if we're not connected yet
+if p.GetName() == "remote-linux":
+return "linux"
+
labath wrote:
Can you explain
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,468 @@
+//===-- DILAST.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,43 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = cast_expression;
+
+cast_expression = unary_expression;
+
+unary_expression = postfix_expression
+ | unary_operator cast_expression;
+
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,43 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = cast_expression;
+
+cast_expression = unary_expression;
+
+unary_expression = postfix_expression
+ | unary_operator cast_expression;
+
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/labath commented:
> BTW, I have verified that this stripped down version passes all the frame
> variable tests in LLDB.
That's cool. Just to confirm, have you looked at replacing `target variable` as
well? It uses the same language as "frame var" under the hood, which but
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/95738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,468 @@
+//===-- DILAST.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,446 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/98041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
This explains why the `test_OneTargetTwoDebuggers` flavour of the test was
crashing. It doesn't explain why would the other two versions crash. However
I'm not sure if the other two flavours are indeed crashing (all of the crashes
I've seen were in this flavour).
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/98041
In async mode, the test terminates sooner that it should
(`run_to_source_breakpoint` does not work in this mode), and then the test
crashes due to #98038. Most of the time, the test does not fail because its
@@ -36,10 +38,17 @@ using namespace lldb;
using namespace lldb_private;
static sig_atomic_t g_signal_flags[NSIG];
+#if defined(__QNX__)
+static llvm::DenseMap g_signal_info;
labath wrote:
This code is definitely not async-signal-safe. However, before you try
@@ -222,6 +232,148 @@ struct ForkLaunchInfo {
// End of code running in the child process.
+#if defined(__QNX__)
+static ::pid_t PosixSpawn(const ForkLaunchInfo ,
labath wrote:
This is basically reimplementing `LaunchProcessPosixSpawn` inside
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
This is only a very light review. I agree with others that an RFC thread is a
better place to discuss this. After we sort that out, this patch should be
further subdivided into smaller pieces.
https://github.com/llvm/llvm-project/pull/97630
@@ -35,6 +39,10 @@
#include
#endif
+#if !defined(EOK)
labath wrote:
Everything else just uses zero (`0`) as "no error". I don't see a reason for
this code to be different.
https://github.com/llvm/llvm-project/pull/97630
@@ -56,6 +56,10 @@ def target_is_android():
return configuration.lldb_platform_name == "remote-android"
+def target_is_remote_linux():
+return configuration.lldb_platform_name == "remote-linux"
+
+
labath wrote:
I guess this isn't used anymore.
@@ -92,11 +96,22 @@ def match_android_device(device_arch, valid_archs=None,
valid_api_levels=None):
def finalize_build_dictionary(dictionary):
+if dictionary is None:
+dictionary = {}
if target_is_android():
-if dictionary is None:
-
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/97579
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/97328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/97328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/97754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -246,3 +270,119 @@
lldb_private::formatters::LibcxxStdUnorderedMapSyntheticFrontEndCreator(
return (valobj_sp ? new LibcxxStdUnorderedMapSyntheticFrontEnd(valobj_sp)
: nullptr);
}
+
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/97752
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -456,3 +477,97 @@
lldb_private::formatters::LibcxxStdMapSyntheticFrontEndCreator(
CXXSyntheticChildren *, lldb::ValueObjectSP valobj_sp) {
return (valobj_sp ? new LibcxxStdMapSyntheticFrontEnd(valobj_sp) : nullptr);
}
+
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/97713
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97713
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/97555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/97568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -55,14 +55,23 @@ def test_basic(self):
self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets")
# Verify the target names are correct.
-self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()")
-
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Why do we even have the `GetValueOffset` function? Wouldn't it be possible to
dredge the actual type describing the node layout from somewhere (a template
argument of something, or a return value of some method?)
https://github.com/llvm/llvm-project/pull/97551
https://github.com/labath approved this pull request.
I'd say eight years is a sufficient compatibility window. :)
https://github.com/llvm/llvm-project/pull/97549
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath wrote:
> LGTM
>
> Been wondering if we should follow the same principle as we did with
> `std::string` and simulate the layouts for all the STL types, keeping a
> record of them as they change. So we know we don't break the old layouts. Of
> course it has a separate maintenance cost
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/97568
>From 53b9fda6f7bf0ec4df32869c9d4ba2203aa1870a Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 3 Jul 2024 12:20:12 +
Subject: [PATCH 1/2] [lldb] Make variant formatter work with libstdc++-14
In this
1 - 100 of 3616 matches
Mail list logo
