Re: [VOTE] Release Apache Wicket 10.1.0

2024-05-31 Thread Thomas Heigl
+1 Ran our CI build and did some exploratory testing. Thomas On Thu, May 30, 2024 at 8:52 PM Tobias Soloschenko wrote: > +1 > > kind regards > > Tobias > > > Am 30.05.2024 um 13:47 schrieb Martin Grigorov : > > > > +1 to release > > > > Tested: > > - local build from sources > > - various exa

Re: [VOTE] Release Apache Wicket 10.0.0 - TAKE 2

2024-03-11 Thread Thomas Heigl
+1 Upgraded our main app, ran CI tests and did exploratory tests. Best, Thomas On Mon, Mar 11, 2024 at 5:41 PM Tobias Soloschenko wrote: > +1 > > kind regards > > Tobias > > > Am 11.03.2024 um 17:17 schrieb Andrea Del Bene : > > > > +1 to release > > > > Migrated tutorial examples to wicket

Commons Fileupload M2

2024-02-11 Thread Thomas Heigl
Hi all, There is a new milestone for commons-fileupload (M2): https://github.com/apache/commons-fileupload/blob/master/RELEASE-NOTES.txt They decided to split servlet support into two modules: - commons-fileupload2-jakarta-servlet5 - commons-fileupload2-jakarta-servlet6 We should probably upgr

[jira] [Commented] (WICKET-6890) Render debug setting 'outputMarkupContainerClassName` as an attribute

2024-02-09 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816003#comment-17816003 ] Thomas Heigl commented on WICKET-6890: -- OK I wrote a very quick draft of

[jira] [Commented] (WICKET-6890) Render debug setting 'outputMarkupContainerClassName` as an attribute

2024-02-09 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815978#comment-17815978 ] Thomas Heigl commented on WICKET-6890: -- OK! I will try to send a PR in the co

[jira] [Commented] (WICKET-6890) Render debug setting 'outputMarkupContainerClassName` as an attribute

2024-02-08 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815720#comment-17815720 ] Thomas Heigl commented on WICKET-6890: -- OK I'm not a big fan of th

[jira] [Commented] (WICKET-6890) Render debug setting 'outputMarkupContainerClassName` as an attribute

2024-02-08 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815716#comment-17815716 ] Thomas Heigl commented on WICKET-6890: -- We just ran into the issue mentioned a

Re: Wicket 10(-M?) checkpoint

2023-12-11 Thread Thomas Heigl
Hi all, I upgraded our main application to Wicket 10.0.0-M2, Spring 6.1, and Spring Boot 3.2 last week. All my (thousands) of tests are green and I did some exploratory testing. LGTM! Thomas On Wed, Dec 6, 2023 at 2:08 PM Vit Rozkovec wrote: > > > On 06. 12. 23 13:08, Martin Grigorov wrote:

Re: Wicket 10 Release Plans

2023-09-11 Thread Thomas Heigl
+1 for M2 and a final release as soon as possible. I also have no plans of adding anything to Wicket 10 before the release. I would have deployed M1 to production already if my Jakarta migration wasn't blocked by performance issues in Hibernate 6 ,) Best, Thomas On Mon, Sep 11, 2023 at 3:30 PM

[jira] [Commented] (WICKET-6979) Cut back slightly on some String instance creation in PageInfo and friends.

2023-04-19 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714035#comment-17714035 ] Thomas Heigl commented on WICKET-6979: -- I just realized that this ticket

[jira] [Updated] (WICKET-6979) Cut back slightly on some String instance creation in PageInfo and friends.

2023-04-19 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6979: - Fix Version/s: 10.0.0 9.14.0 (was: 9.11.0) > Cut b

[jira] [Resolved] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-19 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-7047. -- Fix Version/s: 10.0.0 9.14.0 Resolution: Fixed > Improve init

[jira] [Resolved] (WICKET-7046) Avoid allocating StringResponse when no response filters are active

2023-04-19 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-7046. -- Fix Version/s: 10.0.0 9.14.0 Resolution: Fixed > Avoid allocat

[jira] [Resolved] (WICKET-7045) Avoid allocations in PageParameters.getNamedKeys

2023-04-19 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-7045. -- Fix Version/s: 10.0.0 9.14.0 Resolution: Fixed > Avoid allocati

[jira] [Resolved] (WICKET-7049) Avoid allocation for empty buckets in FilteringHeaderResponse

2023-04-19 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-7049. -- Fix Version/s: 9.14.0 Resolution: Fixed > Avoid allocation for empty buckets

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-17 Thread Thomas Heigl
+1 Let's release 9.13.0. On Mon, Apr 17, 2023 at 5:59 PM Ernesto Reinaldo Barreiro < reier...@gmail.com> wrote: > +1 for releasing 9.13.0! > > On Fri, Apr 14, 2023 at 10:13 PM Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > Please download the source di

[jira] [Updated] (WICKET-7045) Avoid allocations in PageParameters.getNamedKeys

2023-04-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-7045: - Priority: Minor (was: Major) > Avoid allocations in PageParameters.getNamedK

[jira] [Updated] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-7047: - Priority: Minor (was: Major) > Improve initial buffer capacity for Strings.toMultilineMar

[jira] [Created] (WICKET-7049) Avoid allocation for empty buckets in FilteringHeaderResponse

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7049: Summary: Avoid allocation for empty buckets in FilteringHeaderResponse Key: WICKET-7049 URL: https://issues.apache.org/jira/browse/WICKET-7049 Project: Wicket

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-16 Thread Thomas Heigl
Hi all, I didn't expect to, but I discovered one more *major* way to reduce allocations in ajax requests: - https://github.com/apache/wicket/pull/578 This avoids allocating some 50-100KB *per request* in our ajax heavy application. Then there are two other small improvements: - https://github.

[jira] [Created] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7047: Summary: Improve initial buffer capacity for Strings.toMultilineMarkup Key: WICKET-7047 URL: https://issues.apache.org/jira/browse/WICKET-7047 Project: Wicket

[jira] [Created] (WICKET-7046) Avoid allocating StringResponse when no response filters are active

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7046: Summary: Avoid allocating StringResponse when no response filters are active Key: WICKET-7046 URL: https://issues.apache.org/jira/browse/WICKET-7046 Project: Wicket

[jira] [Created] (WICKET-7045) Avoid allocations in PageParameters.getNamedKeys

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7045: Summary: Avoid allocations in PageParameters.getNamedKeys Key: WICKET-7045 URL: https://issues.apache.org/jira/browse/WICKET-7045 Project: Wicket Issue Type

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-15 Thread Thomas Heigl
+1 Ran our CI build and did some exploratory testing on the staging environment. On Fri, Apr 14, 2023 at 9:13 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.13.0 > > > Please download the source distributions found in our staging area > linked below. > > I have included t

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-11 Thread Thomas Heigl
: > > > Many thanks for this. For us it will be fine if we can get a new version > of > > wicket by the end of this week. > > > > 👍 I agree ! this vote is cancelled > > > > > > On Tue, Apr 11, 2023 at 9:07 AM Thomas Heigl > wrote: > > > > &

[jira] [Resolved] (WICKET-7041) Reduce allocations when rendering component headers

2023-04-11 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-7041. -- Resolution: Fixed > Reduce allocations when rendering component head

[jira] [Resolved] (WICKET-7042) Improve sizing of StringResponse when writing scripts in PartialPageResponse

2023-04-11 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-7042. -- Resolution: Fixed > Improve sizing of StringResponse when writing scripts

[jira] [Updated] (WICKET-7042) Improve sizing of StringResponse when writing scripts in PartialPageResponse

2023-04-11 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-7042: - Fix Version/s: 10.0.0 9.13.0 > Improve sizing of StringResponse when writ

[jira] [Updated] (WICKET-7041) Reduce allocations when rendering component headers

2023-04-11 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-7041: - Fix Version/s: 10.0.0 9.13.0 > Reduce allocations when rendering compon

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-10 Thread Thomas Heigl
ded :) > > On Mon, 10 Apr 2023 at 22:29, Thomas Heigl wrote: > > > > Hi all, > > > > I know I'm a bit late, but I just discovered a way to reduce a ton of > > allocations in our application: > > > > https://github.com/apache/wicket/pull/572 > >

[jira] [Created] (WICKET-7042) Improve sizing of StringResponse when writing scripts in PartialPageResponse

2023-04-10 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7042: Summary: Improve sizing of StringResponse when writing scripts in PartialPageResponse Key: WICKET-7042 URL: https://issues.apache.org/jira/browse/WICKET-7042 Project

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-10 Thread Thomas Heigl
Hi all, I know I'm a bit late, but I just discovered a way to reduce a ton of allocations in our application: https://github.com/apache/wicket/pull/572 https://issues.apache.org/jira/browse/WICKET-7041 Any chance we can wait for this change? The implementation is trivial and should reduce alloca

[jira] [Created] (WICKET-7041) Reduce allocations when rendering component headers

2023-04-10 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7041: Summary: Reduce allocations when rendering component headers Key: WICKET-7041 URL: https://issues.apache.org/jira/browse/WICKET-7041 Project: Wicket Issue

Re: Release Wicket 10.0.0-M1?

2022-12-16 Thread Thomas Heigl
ue, Apr 19, 2022 at 9:27 PM Martin Grigorov wrote: > On Tue, Apr 19, 2022 at 2:42 PM Thomas Heigl wrote: > > > OK I just saw that Martin already asked them to do a release in > > https://issues.apache.org/jira/projects/FILEUPLOAD/issues/FILEUPLOAD-309 > . > > > >

Re: Wired behavior of maxClauseCount restriction since upgrading to solr 9.1

2022-12-01 Thread Thomas Heigl
Hi Jan, We ran into the same issue. Terms queries sound like the ideal solution for our use case, but I couldn't find any documentation on the {!terms} syntax. Is there anything in the official docs? Best, Thomas On Thu, Dec 1, 2022 at 2:09 PM Jan Høydahl wrote: > Have you tried using Terms Q

[jira] [Commented] (FILEUPLOAD-309) Release version 2.0.0

2022-11-18 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635846#comment-17635846 ] Thomas Heigl commented on FILEUPLOAD-309: - I second that, please rel

Re: Interested in testing the Jakarta artifacts

2022-10-28 Thread Thomas Heigl
Hi, Have the snapshots been published in the meantime? I'm very interested in testing against the snapshots. Best, Thomas On 2022/10/13 14:05:30 Francois Papon wrote: > Hi Julian, > > Not yet but I can push a snapshot. > > Let me push a PR. > > regards, > > Francois > > On 13/10/2022 15:5

Re: Time for 9.12.0?

2022-09-13 Thread Thomas Heigl
+1 On Tue, Sep 13, 2022 at 1:14 PM Andrea Del Bene wrote: > Looks like we have enough material to promote a new release. WDYT? > > -- > Andrea Del Bene. > Apache Wicket committer. >

Re: Info regarding shiro-web and jakarta servle

2022-08-27 Thread Thomas Heigl
Hi François, Did you make any progress on this issue? Is there something I could do to help? Best, Thomas On 2022/07/13 15:17:14 fpapon wrote: > Hi Alex, > > Tests are not yet finished from my side, I hope it will be done before > the end of this month. > > The WIP branch is available here

Re: [ANNOUNCE] Apache Wicket 9.11.0 released

2022-07-13 Thread Thomas Heigl
Hi, I just realized that WICKET-6982 was not included in this release, because I forgot to cherry-pick it on the 9.x branch ,/ I adjusted the fix version in JIRA and cherry-picked the commit now. In the future, I have to go over all issues I merged, and verify that I actually cherry-picked them.

[jira] [Updated] (WICKET-6982) Unnecessary initialization of stateful pages in ListenerRequestHandler

2022-07-13 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6982: - Fix Version/s: 10.0.0 9.12.0 (was: 9.11.0

Re: [VOTE] Release Apache Wicket 9.11.0

2022-07-09 Thread Thomas Heigl
+1 Ran CI build and did some exploratory testing with our main app. On Fri, Jul 8, 2022 at 11:05 AM Andrea Del Bene wrote: > +1 to release > > Tested with guide examples and my main business app > > On Thu, Jul 7, 2022 at 11:26 PM Sven Meier wrote: > > > +1 yes, release > > > > Tested build, s

[jira] [Resolved] (WICKET-6982) Unnecessary initialization of stateful pages in ListenerRequestHandler

2022-05-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6982. -- Fix Version/s: 9.11.0 Resolution: Fixed > Unnecessary initialization of stateful pa

[jira] [Resolved] (WICKET-6979) Cut back slightly on some String instance creation in PageInfo and friends.

2022-05-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6979. -- Fix Version/s: 9.11.0 Assignee: Thomas Heigl Resolution: Fixed > Cut b

[jira] [Updated] (WICKET-6982) Unnecessary initialization of stateful pages in ListenerRequestHandler

2022-05-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6982: - Description: ListenerRequestHandler currently forces initialization of pages. For already

[jira] [Created] (WICKET-6982) Unnecessary initialization of stateful pages in ListenerRequestHandler

2022-05-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6982: Summary: Unnecessary initialization of stateful pages in ListenerRequestHandler Key: WICKET-6982 URL: https://issues.apache.org/jira/browse/WICKET-6982 Project

Re: Info regarding shiro-web and jakarta servlet

2022-05-13 Thread Thomas Heigl
Hi, I'm in the process of upgrading my application to Spring 6, Spring Boot 3 and Hibernate 6. That means moving to the Jakarta APIs. Shiro is my only dependency that doesn't have a (pre)release based on Jakarta yet. While most containers will be able to support legacy javax APIs at runtime or

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-05-03 Thread Thomas Heigl
;static final" even allows java to reuse this item in any other > threads > > without any limitations as only the reference is thread safe but not the > > contents - am I right here? > > > > > > Anyway, I can asure you that I made a nearly similar mistak

Re: [VOTE] Release Apache Wicket 9.10.0

2022-05-03 Thread Thomas Heigl
+1. I deployed this release to production yesterday and have not noticed any issues so far. On Sun, May 1, 2022 at 12:38 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.10.0 > > Please download the source distributions found in our staging area > linked below. > > I have i

Release Wicket 9.10.0?

2022-04-29 Thread Thomas Heigl
Hi all, What do you think about releasing Wicket 9.10.0? https://issues.apache.org/jira/projects/WICKET/versions/12351540 I'd very much like to roll out all the recent allocation improvements. Best, Thomas

[jira] [Resolved] (WICKET-6977) hashCode computations generate excessive garbage objects

2022-04-29 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6977. -- Fix Version/s: 10.0.0 9.10.0 Resolution: Fixed > hashC

[jira] [Updated] (WICKET-6963) Use singletons for PanelMarkupSourcingStrategy

2022-04-28 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6963: - Fix Version/s: 9.10.0 > Use singletons for PanelMarkupSourcingStrat

[jira] [Assigned] (WICKET-6977) hashCode computations generate excessive garbage objects

2022-04-28 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl reassigned WICKET-6977: Assignee: Thomas Heigl > hashCode computations generate excessive garbage obje

[jira] [Resolved] (WICKET-6976) Reduce allocations when writing synthetic closing tags

2022-04-28 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6976. -- Fix Version/s: 10.0.0 9.10.0 Resolution: Fixed > Reduce allocati

Disable Travis builds?

2022-04-21 Thread Thomas Heigl
Hi, Given that our Travis builds aren't working anymore, should we delete the travis.yml files? It is annoying that all builds show up as failed on Github because the Travis status check is failing. Thomas

[jira] [Created] (WICKET-6976) Reduce allocations when writing synthetic closing tags

2022-04-20 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6976: Summary: Reduce allocations when writing synthetic closing tags Key: WICKET-6976 URL: https://issues.apache.org/jira/browse/WICKET-6976 Project: Wicket

[jira] [Updated] (WICKET-6975) Behavior.renderHead may be called multiple times

2022-04-20 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6975: - Fix Version/s: 10.0.0 9.10.0 > Behavior.renderHead may be called multi

[jira] [Resolved] (WICKET-6975) Behavior.renderHead may be called multiple times

2022-04-20 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6975. -- Resolution: Fixed > Behavior.renderHead may be called multiple ti

[jira] [Created] (WICKET-6975) Behavior.renderHead may be called multiple times

2022-04-20 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6975: Summary: Behavior.renderHead may be called multiple times Key: WICKET-6975 URL: https://issues.apache.org/jira/browse/WICKET-6975 Project: Wicket Issue Type

Re: Release Wicket 10.0.0-M1?

2022-04-19 Thread Thomas Heigl
OK I just saw that Martin already asked them to do a release in https://issues.apache.org/jira/projects/FILEUPLOAD/issues/FILEUPLOAD-309. On Tue, Apr 19, 2022 at 1:35 PM Thomas Heigl wrote: > Hi, > > I started migrating our app to the new Jakarta APIs. Wicket is the only > dep

Release Wicket 10.0.0-M1?

2022-04-19 Thread Thomas Heigl
Hi, I started migrating our app to the new Jakarta APIs. Wicket is the only dependency that doesn't yet have a pre-release. Is there anything preventing us from releasing 10.0.0-M1? Is the SNAPSHOT dependency on commons-fileupload the only remaining issue? If so, we should probably ask them to cr

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-07 Thread Thomas Heigl
gt; > > On Wed, 6 Apr 2022 at 02:50, Sven Meier wrote: > >> +1 > >> > >> Sven > >> > >> On 05.04.22 16:47, Tobias Soloschenko wrote: > >>> +1 > >>> > >>> kind regards > >>> > >>> Tobi

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-05 Thread Thomas Heigl
+1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.9.1 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatu

Re: shall we release 9.10.0 instead of 9.9.2?

2022-04-04 Thread Thomas Heigl
I would have preferred a 9.9.x hotfix that makes it clear that there is a serious issue with Wicket 9.9.0 that is resolved in this version. But since you added a new feature, I guess we could release it as 9.10.0 as well. Thomas On Mon, Apr 4, 2022 at 7:08 PM Ernesto Reinaldo Barreiro wrote: >

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-04 Thread Thomas Heigl
I just merged and cherry-picked the PR. >From my perspective, 9.9.1 is good to release. Thomas On Mon, Apr 4, 2022 at 12:10 PM Thomas Heigl wrote: > I created a PR for this: https://github.com/apache/wicket/pull/507 > > I'll cherry-pick it onto 9.x when the PR is a

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-04 Thread Thomas Heigl
> the way you find good! > > Martin > > On Sun, Apr 3, 2022, 12:53 Thomas Heigl wrote: > > > I have to take back my +1. > > > > I found one more issue with WICKET-6965 while stress testing our staging > > environment: > > > > > > >

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-03 Thread Thomas Heigl
ould fix this before releasing 9.9.1. This websocket code seems to be quite hard to get right. Best, Thomas On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl wrote: > +1 > > I think the changelog for WICKET-6963 should read "Revert: Use singletons > for PanelMarkupSourcingStrategy&qu

[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint

2022-04-03 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516488#comment-17516488 ] Thomas Heigl commented on WICKET-6965: -- [~mgrigorov]: I found on more issue

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-02 Thread Thomas Heigl
+1 I think the changelog for WICKET-6963 should read "Revert: Use singletons for PanelMarkupSourcingStrategy", to make clear that it was reverted. Thomas On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.9.1 > > Please download the source distr

Re: Hotfix 9.9.1

2022-04-01 Thread Thomas Heigl
+1. Thank you Andrea! On Fri, Apr 1, 2022 at 6:22 PM Ernesto Reinaldo Barreiro wrote: > +1. Many thanks for taking care of releases! > > On Fri, Apr 1, 2022 at 8:22 AM Andrea Del Bene > wrote: > > > I will start to rollout this version in few hours. If I have to wait for > > some last-minute ch

[jira] [Commented] (WICKET-6963) Use singletons for PanelMarkupSourcingStrategy

2022-03-31 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515202#comment-17515202 ] Thomas Heigl commented on WICKET-6963: -- My proposed solution is buggy under

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
It's just a single commit. I have reverted it for both 9.x and master. Best, Thomas On Thu, Mar 31, 2022 at 11:06 AM Andrea Del Bene wrote: > On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl wrote: > > > Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code &g

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
WICKET-6963 for now and release 9.9.1. Sorry for that! I was confident that my change was good, because it worked without problems in our production environment. Thomas On Thu, Mar 31, 2022 at 10:18 AM Thomas Heigl wrote: > Although the JavaDoc states that this should be possible: > > //

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
. Thomas On Thu, Mar 31, 2022 at 10:14 AM Thomas Heigl wrote: > I think we will have to revert WICKET-6963. > > I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed > in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton > strategy doesn

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
I think we will have to revert WICKET-6963. I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton strategy doesn't work. Thomas On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl wrote: > This is

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
This is probably caused by my change in https://issues.apache.org/jira/browse/WICKET-6963 I have been using this code in production for a couple of weeks now without issues, but there seem to be cases where the singleton strategy doesn't work. Can you reproduce this issue in a test-case? Thomas

Re: [VOTE] Release Apache Wicket 9.9.0

2022-03-27 Thread Thomas Heigl
+1 Ran our tests and manually verified the memory leak fix. On Sun, Mar 27, 2022 at 3:37 PM Ernesto Reinaldo Barreiro < reier...@gmail.com> wrote: > +1 > > On Sun, Mar 27, 2022 at 7:35 AM Tobias Soloschenko > wrote: > > > +1 > > > > kind regards > > > > Tobias > > > > > Am 27.03.2022 um 14:58 s

Release Wicket 9.9.0?

2022-03-25 Thread Thomas Heigl
Hi all, What do you think about releasing Wicket 9.9.0? I'm especially interested in getting https://issues.apache.org/jira/browse/WICKET-6965 released, because the memory leak is impacting our application. Best, Thomas

[jira] [Updated] (WICKET-6957) Declare JSPM 'uses' for IInitializer

2022-03-25 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6957: - Fix Version/s: 9.9.0 > Declare JSPM 'uses' for

[jira] [Resolved] (WICKET-6964) Do not allocate when escaping empty string

2022-03-23 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6964. -- Resolution: Fixed > Do not allocate when escaping empty str

[jira] [Resolved] (WICKET-6963) Use singletons for PanelMarkupSourcingStrategy

2022-03-23 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6963. -- Resolution: Fixed > Use singletons for PanelMarkupSourcingStrat

[jira] [Updated] (WICKET-6960) Reduce allocations when encoding ComponentInfo

2022-03-23 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6960: - Fix Version/s: 10.0.0 9.9.0 (was: 9.8.1) > Red

[jira] [Updated] (WICKET-6964) Do not allocate when escaping empty string

2022-03-23 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6964: - Fix Version/s: 10.0.0 9.9.0 > Do not allocate when escaping empty str

[jira] [Updated] (WICKET-6963) Use singletons for PanelMarkupSourcingStrategy

2022-03-23 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6963: - Fix Version/s: 10.0.0 9.9.0 > Use singletons for PanelMarkupSourcingStrat

Add destroyed flag to application?

2022-03-22 Thread Thomas Heigl
Hi, Yesterday, I discovered that our attempted fix for https://issues.apache.org/jira/browse/WICKET-6944 didn't work. Application destroy listeners are still registered for every new Websocket connection and never cleared. I can see two options to fix this: 1. Keep the current listeners and try

[jira] [Commented] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-22 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510378#comment-17510378 ] Thomas Heigl commented on WICKET-6944: -- Since {{JavaxWebSocketProcessor}} h

[jira] [Created] (WICKET-6964) Do not allocate when escaping empty string

2022-03-21 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6964: Summary: Do not allocate when escaping empty string Key: WICKET-6964 URL: https://issues.apache.org/jira/browse/WICKET-6964 Project: Wicket Issue Type

[jira] [Created] (WICKET-6963) Use singletons for PanelMarkupSourcingStrategy

2022-03-21 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6963: Summary: Use singletons for PanelMarkupSourcingStrategy Key: WICKET-6963 URL: https://issues.apache.org/jira/browse/WICKET-6963 Project: Wicket Issue Type

[jira] [Created] (WICKET-6962) Use singletons for PanelMarkupSourcingStrategy

2022-03-21 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6962: Summary: Use singletons for PanelMarkupSourcingStrategy Key: WICKET-6962 URL: https://issues.apache.org/jira/browse/WICKET-6962 Project: Wicket Issue Type

[jira] [Commented] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-21 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509951#comment-17509951 ] Thomas Heigl commented on WICKET-6944: -- I again have millions of objects aft

[jira] [Updated] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-21 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6944: - Attachment: image-2022-03-21-16-27-37-798.png > Memory leak in WicketEndpo

[jira] [Commented] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-21 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509950#comment-17509950 ] Thomas Heigl commented on WICKET-6944: -- [~mgrigorov]: I just took another

[jira] [Resolved] (WICKET-6960) Reduce allocations when encoding ComponentInfo

2022-03-06 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6960. -- Resolution: Fixed > Reduce allocations when encoding ComponentI

[jira] [Updated] (WICKET-6960) Reduce allocations when encoding ComponentInfo

2022-03-04 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6960: - Fix Version/s: 9.8.1 > Reduce allocations when encoding ComponentI

[jira] [Created] (WICKET-6960) Reduce allocations when encoding ComponentInfo

2022-03-04 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6960: Summary: Reduce allocations when encoding ComponentInfo Key: WICKET-6960 URL: https://issues.apache.org/jira/browse/WICKET-6960 Project: Wicket Issue Type

Re: [VOTE] Release Apache Wicket 9.8.0

2022-02-03 Thread Thomas Heigl
+1 Ran our tests and did some exploratory testing with our app. Thomas On Thu, Feb 3, 2022 at 7:40 PM Sven Meier wrote: > +1 to release > > Tested build, checksum and a few examples. > > Sven > > On 03.02.22 18:46, Ernesto Reinaldo Barreiro wrote: > > +1 > > > > I have tested our application w

[jira] [Resolved] (WICKET-6952) Performance improvements for Strings.isEmpty

2022-02-02 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl resolved WICKET-6952. -- Resolution: Fixed > Performance improvements for Strings.isEm

[jira] [Updated] (WICKET-6952) Performance improvements for Strings.isEmpty

2022-02-02 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-6952: - Fix Version/s: 10.0.0 9.8.0 > Performance improvements for Strings.isEm

Re: new 9.8.0 release

2022-02-02 Thread Thomas Heigl
Hi, My PR is merged as well. It only needs to be back-ported to 9.x. Martin, how do you usually do the back-porting? Simply cherry-pick the commit? Best, Thomas On Tue, Feb 1, 2022 at 6:28 PM Andrea Del Bene wrote: > On Tue, Feb 1, 2022 at 6:24 PM Thomas Heigl wrote: > > > H

[jira] [Created] (WICKET-6952) Performance improvements for Strings.isEmpty

2022-02-01 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-6952: Summary: Performance improvements for Strings.isEmpty Key: WICKET-6952 URL: https://issues.apache.org/jira/browse/WICKET-6952 Project: Wicket Issue Type

  1   2   3   4   5   >