[edk2-devel] SPDM Transports

2024-10-01 Thread Tim Lewis via groups.io
and are considering adding a separate driver that can sit on top of the MCTP layer. Do you think we should pursue the driver model or do you have another way to support multiple SPDM transports? Thanks, Tim Lewis CTO, Insyde Software -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Fwd: Re: Bash vs Perl

2023-07-14 Thread Tim Lewis via beginners
On Jul 14, 2023, 11:33 AM, at 11:33 AM, Tim Lewis wrote: >Hi William, >I use crontab on my Ubuntu server to automatically run Perl scripts. >Will that work for you? >Tim >William Torrez Corea wrote: >Can I mix bash with perl in a program? >I want to create a program in Per

100% CPU before LUKS password

2022-11-19 Thread Tim Lewis
While some Linux distributions (Debian, Fedora, etc) put /boot outside of LUKS, the ones using the Calamares installer (EndeavourOS, Spiral, etc) often put /boot inside LUKS/btrfs. The latter layout permits kernel rolebacks via btrfs snapshots, but will use 100% of one core until the kernel is load

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Tim Lewis via groups.io
Is the FSP 2.4 specification available publicly? It is hard to understand the impact of this without referencing the specification. From the FSP page on https://www.intel.com/content/www/us/en/intelligent-systems/intel-firmware-support-package/intel-fsp-overview.html, only 2.3 is available. Tha

Re: [edk2-devel] [RFC] Expose HII package list via C variables

2021-08-26 Thread Tim Lewis
d leave padding for possible future edits, it was > felt that using a PE/COFF section similar to the resource sections was > better. Resource sections are commonly in use for PE/COFF files (in Windows) > and the similar idea existed in the then-extant Mac binary format (resource > fo

Re: [edk2-devel] [RFC] Expose HII package list via C variables

2021-08-26 Thread Tim Lewis
a PE/COFF section similar to the resource sections was better. Resource sections are commonly in use for PE/COFF files (in Windows) and the similar idea existed in the then-extant Mac binary format (resource fork?). Thanks, Tim Lewis CTO, Insyde Software www.insyde.com -Original Me

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Tim Lewis
I would point out that there was significant work on libc in the past (see https://github.com/andreiw/UefiToolsPkg) but never any help to upstream these fixes, including making sure that many Linux tools can easily be ported. I myself have used it to port several BSD utilities over, but each t

Re: [edk2-devel] EDK2 Specs PDF links don't work.

2020-08-19 Thread Tim Lewis
vel@edk2.groups.io> mailto:devel@edk2.groups.io> > On Behalf Of Tim Lewis Sent: Wednesday, August 19, 2020 11:59 AM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> Subject: [edk2-devel] EDK2 Specs PDF links don't work. Sorry, I’m new to GitBook, but the PDF links for the spe

[edk2-devel] EDK2 Specs PDF links don't work.

2020-08-19 Thread Tim Lewis
Sorry, I’m new to GitBook, but the PDF links for the specs are not working. It just brings me into the middle of the GitBook HTML pages. I like to have an off-line reference and PDFs worked well in the past. I see the link points to a PDF URL, but the result is still not PDF. I’d prefer not to h

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/MtrrLib/UnitTest: Add host based unit test

2020-07-28 Thread Tim Lewis
Sean -- What I have seen done for fuzz testing is to (a) report the seed used to initialize the RNG in the log and then (b) provide an option to force the seed to that value. Using a static seed might actually be the default for CI runs, but stand-alone runs could use a random value. Just a t

[edk2-devel] Extremely long delays with UDF support?

2020-07-15 Thread Tim Lewis
Has anyone else seen extremely long delays with UDF support on USB CD-ROMs/DVDs? We found that PartitionDxe can add seconds because of the number blocks being read. Thanks, Tim -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#6263

[edk2-devel] Components sub-section ordering

2020-06-17 Thread Tim Lewis
ined in the DSC file's [LibraryClasses] and [Pcds*] sections, while global BuildOptions may be specified in either the DSC file's [BuildOptions] section or in the $(WORKSPACE)/Conf/tools_def.txt file. I would also note that the is not listed here. Can we just elide this? T

Re: [edk2-announce] Soft Feature Freeze starts now for edk2-stable202002

2020-02-16 Thread Tim Lewis
, Liming Sent: Sunday, February 16, 2020 9:20 PM To: Tim Lewis ; de...@edk2.groups.io; announce@edk2.groups.io Cc: Guptha, Soumya K ; Kinney, Michael D ; 'Laszlo Ersek' ; af...@apple.com; leif.lindh...@linaro.org Subject: RE: [edk2-announce] Soft Feature Freeze starts now for edk2-stable2

Re: [edk2-devel] [edk2-announce] Soft Feature Freeze starts now for edk2-stable202002

2020-02-16 Thread Tim Lewis
, Liming Sent: Sunday, February 16, 2020 9:20 PM To: Tim Lewis ; devel@edk2.groups.io; annou...@edk2.groups.io Cc: Guptha, Soumya K ; Kinney, Michael D ; 'Laszlo Ersek' ; af...@apple.com; leif.lindh...@linaro.org Subject: RE: [edk2-announce] Soft Feature Freeze starts now for edk2-stable2

Re: [edk2-announce] Soft Feature Freeze starts now for edk2-stable202002

2020-02-14 Thread Tim Lewis
Liming -- Is there any plan to list all of the security fixes related CVEs that are being checked in to the list of official features for this stable tag? We have listed the Boot Guard one. Thanks, Tim Lewis CTO, Insyde Software www.insyde.com -Original Message- From: announce@edk2

Re: [edk2-devel] [edk2-announce] Soft Feature Freeze starts now for edk2-stable202002

2020-02-14 Thread Tim Lewis
Liming -- Is there any plan to list all of the security fixes related CVEs that are being checked in to the list of official features for this stable tag? We have listed the Boot Guard one. Thanks, Tim Lewis CTO, Insyde Software www.insyde.com -Original Message- From: annou...@edk2

Re: [edk2-devel] Shell feature?

2020-02-11 Thread Tim Lewis
Andrew -- I think this is a good idea, but I think this is probably a shell spec issue because I don't want competing, incompatible implementations. A few other issues: I think there is a persistence issue (similar to shell variables) so that the change could be installed and survive a reboot.

[edk2-devel] Flush on main exit?

2019-10-18 Thread Tim Lewis
I have noticed recently, when porting BSD applications, that if main exits normally, the buffers are not flushed. This is most obvious when using StdLib along with printf or fprintf to stdout. Has anyone else noticed this? If there is a \n in the output, it gets flushed to stdout, but if the st

Re: [edk2-devel] Mappings and StdLib

2019-09-05 Thread Tim Lewis
Ok, now I found my answer. DevShell library class must be included with StdLib in order to correctly process shell-style input parameters. Without it, it falls back on DevConsole Thanks, Tim From: devel@edk2.groups.io On Behalf Of Tim Lewis Sent: Thursday, September 5, 2019 10:25 AM To

Re: [edk2-devel] Mappings and StdLib

2019-09-05 Thread Tim Lewis
ndrew Fish On Sep 4, 2019, at 5:14 PM, Tim Lewis mailto:tim.le...@insyde.com> > wrote: Following up on my last e-mail, I guess I had the wrong assumption: there doesn’t appear to be a way to resolve mappings within StdLib. Are there any plans here?

[edk2-devel] Mappings and StdLib

2019-09-04 Thread Tim Lewis
Following up on my last e-mail, I guess I had the wrong assumption: there doesn't appear to be a way to resolve mappings within StdLib. Are there any plans here? Thanks, Tim -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#4683

[edk2-devel] Q: StdLib and mappings

2019-09-04 Thread Tim Lewis
When using StdLib, I found that access and open have difficulty if the mapping name is not the same case as the mapping name in the path. I have traced this down to a line in DevSearch.c (line 68) if(wcsncmp(DevName, WorkNode->DevName, wcslen(WorkNode->DevName)) == 0) { It appear

Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression

2019-08-26 Thread Tim Lewis
Tested-by: Tim Lewis -Original Message- From: Michael D Kinney Sent: Wednesday, August 21, 2019 7:36 PM To: devel@edk2.groups.io Cc: Jordan Justen ; Ray Ni ; Andrew Fish ; Tim Lewis Subject: [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression https

Re: [edk2-devel] EmulatorPkg does not unload DLL after exit

2019-08-21 Thread Tim Lewis
Pkg/Unix/Host/Host.c#L1120 [3] https://github.com/tianocore/edk2/blob/master/EmulatorPkg/Unix/lldbefi.py#L357 Thanks, Andrew Fish On Aug 21, 2019, at 2:13 PM, Tim Lewis mailto:tim.le...@insyde.com> > wrote: When running a shell app twice, I ran into an interesting problem: glob

[edk2-devel] EmulatorPkg does not unload DLL after exit

2019-08-21 Thread Tim Lewis
When running a shell app twice, I ran into an interesting problem: global variables that had initializers were not initialized to the defaults specified in the source. Running the same shell app under the old NT32 seems to work. It turns out that the shell app was not being reloaded, but rather

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Tim Lewis
logies necessary! Raising compatibility concerns is very valid. > As I said, I just wanted to provide some other considerations I saw to > weigh in the decision. > > All the best, > Jonathan > > On 07/05/2019 22:02, Tim Lewis wrote: > > Jonathan -- > > >

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Tim Lewis
sing it that way for 2+ years. And it didn't cause us grief with our other product which does use an EDK2-derived shell. Best regards, Tim -Original Message- From: devel@edk2.groups.io On Behalf Of Jonathan Watt Sent: Tuesday, May 7, 2019 1:51 PM To: Tim Lewis ; 'Carsey,

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Tim Lewis
/UefiShellBcfgCommandLib: Fix '-opt' option Tim, Out of curiosity, what does the specification you refer to that was used to write the non-EDK2 implementations say about the -opt switch? Regards, Jim -Original Message- From: devel@edk2.groups.io On Behalf Of Tim Lewis Sent: Tuesday, M

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Tim Lewis
her the > spec could/should change. > > On 07/05/2019 18:40, Carsey, Jaben wrote: >> It will break existing scripts. Do you have such scripts in your >> environment dependent on this parameter? >> >>> -Original Message- >>> From: devel@edk2.groups

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Tim Lewis
-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option It will break existing scripts. Do you have such scripts in your environment dependent on this parameter? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Tim Lewis
The question is whether this will break compatibility with existing shell scripts. In order to maintain that compatibility, it may be necessary to add a new option rather than trying to update an existing one. Tim -Original Message- From: devel@edk2.groups.io On Behalf Of Carsey, Jaben S

Re: [edk2] Data Structure alignment

2019-03-14 Thread Tim Lewis
I believe the option ROM header itself has an alignment requirement greater than a DWORD. This is true whether it is from the option ROM BAR or whether it is copied into allocated memory via AllocatePool. In this case, the check you showed will still be adequate. But I am going from memory. Thanks

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-05 Thread Tim Lewis
Jaben -- Following on this: shouldn't this be a spec issue? If you are asking people to depend on the behavior. Thanks, Tim -Original Message- From: edk2-devel On Behalf Of Laszlo Ersek Sent: Friday, October 5, 2018 4:33 AM To: Carsey, Jaben ; Andrew Fish Cc: edk2-devel@lists.01.org Su

Re: [edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Tim Lewis
t;1K"} {"4K"} {"32K"} {"64K"} This is the version from the EDK2 specs page. -Original Message- From: edk2-devel On Behalf Of Zhu, Yonghong Sent: Thursday, July 26, 2018 5:59 PM To: Tim Lewis ; edk2-devel@lists.01.org Subject: Re: [edk2] FFS Alignment and the FDF

[edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Tim Lewis
Is my understanding correct: the FDF specification only supports a maximum of 64KB alignment for files (section 2.5.6), but the PI specification supports (table 7), up to 16MB alignment. Or am I misreading it? Thanks, Tim -Original Message- From: edk2-devel On Behalf Of Andrew Fish Sent

Re: [edk2] Does __attribute__ ((selectany)) make sense now for GCC?

2018-05-18 Thread Tim Lewis
pple.com Sent: Friday, May 18, 2018 3:39 PM To: Tim Lewis Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Does __attribute__ ((selectany)) make sense now for GCC? Tim, Looks like that is only available on Windows versions of GCC, and is more about compatible behavior. selectany

[edk2] Does __attribute__ ((selectany)) make sense now for GCC?

2018-05-18 Thread Tim Lewis
In Visual Studio we have __declspec(selectany) to limit the impact of unused data. I see that GCC for Windows has __attribute__ ((selectany)). Should we me using this for GLOBAL_REMOVE_IF_UNREFERENCED in MdePkg\Include\Base.h? Tim ___ edk2-de

Re: [edk2] Query regarding hole in EFI Memory Map

2018-05-14 Thread Tim Lewis
And now you see it again with 64-bit machines, where the flash and PCI config space (and MMIO) appear below 4GB, but there is DRAM above and below 4GB. Tim -Original Message- From: edk2-devel On Behalf Of Bill Paul Sent: Monday, May 14, 2018 6:13 PM To: edk2-devel@lists.01.org Cc: Neri,

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

2018-05-09 Thread Tim Lewis
Marvin - My suggestion would be the same as yours: to generate a runtime error. Tim -Original Message- From: edk2-devel On Behalf Of Marvin Häuser Sent: Wednesday, May 9, 2018 1:45 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Tim Lewis Subject: Re: [edk2] [PATCH] MdePkg/BaseLib

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

2018-05-08 Thread Tim Lewis
I think that this is a fatal error in EDK2. It basically says, "we are out of stack space." The alternative is: the system hangs in an unexpected way since the stack overflows into other pages. Tim -Original Message- From: edk2-devel On Behalf Of Yao, Jiewen Sent: Tuesday, May 8, 2018 5:

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Tim Lewis
If we start to see UEFI drivers that are using this, then it is a spec issue, because it means that systems which do not implement the event will not function correctly. Tim -Original Message- From: edk2-devel On Behalf Of Bi, Dandan Sent: Wednesday, April 11, 2018 9:53 PM To: Tim Lewis

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Tim Lewis
This is starting to sound like something that requires a UEFI spec update. Tim -Original Message- From: edk2-devel On Behalf Of Bi, Dandan Sent: Wednesday, April 11, 2018 8:47 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric ; Gao, Liming Subject: Re: [edk2]

Re: [edk2] RFC: Proposal to halt automatic builds of Windows BaseTools executables

2018-03-08 Thread Tim Lewis
heavily enough IMO to change the current situation. Regards, Tim -Original Message- From: Laszlo Ersek Sent: Thursday, March 8, 2018 1:19 PM To: Tim Lewis ; 'Bjorge, Erik C' ; edk2-devel@lists.01.org Subject: Re: [edk2] RFC: Proposal to halt automatic builds of Windows Ba

Re: [edk2] RFC: Proposal to halt automatic builds of Windows BaseTools executables

2018-03-08 Thread Tim Lewis
Erik -- What is the justification? Moving from more immediately usable to less immediately usable doesn't seem, on the surface, to be a good direction. Why not go the other direction and pre-build the binaries for the other environments? Thanks, Tim -Original Message- From: edk2-devel

Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex.

2018-01-25 Thread Tim Lewis
Supreeth -- Doesn't Appendix A of the PI 1.6 define this as: #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Supreeth Venkatesh S

Re: [edk2] Build error in StdLib with VS 2015 compiler

2017-11-01 Thread Tim Lewis
Are you building C++ (.cpp)? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Karunakar P Sent: Wednesday, November 1, 2017 8:27 PM To: 'edk2-devel@lists.01.org' Cc: 'Ye, Ting' ; 'Fu, Siyuan' ; 'Wu, Jiaxin' Subject: Re: [edk2] Build error in S

Re: [edk2] Shell Non-conformity to the Spec

2017-10-24 Thread Tim Lewis
Ah, now I remember. It was about aliases and case sensitivity, not environment variables. Tim Sent from my Windows 10 phone From: Carsey, Jaben Sent: Tuesday, October 24, 2017 1:11 PM To: Tim Lewis; jim.dai...@dell.com; Ni, Ruiyu Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Shell Non

Re: [edk2] Shell Non-conformity to the Spec

2017-10-24 Thread Tim Lewis
Jaben -- Wasn't there are previous e-mail thread about this? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Tuesday, October 24, 2017 11:29 AM To: jim.dai...@dell.com; Ni, Ruiyu Cc: edk2-devel@lists.01.org Subject: Re: [

Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color

2017-10-16 Thread Tim Lewis
And we always turn off the multiple colors. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jarlstrom, Laurie Sent: Monday, October 16, 2017 12:47 PM To: Carsey, Jaben ; Ni, Ruiyu ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Tim Lewis
Just a +1 for 4 separate PCDs. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Johnson, Brian (EXL - Eagan) Sent: Tuesday, August 29, 2017 10:12 AM To: Kinney, Michael D ; Yao, Jiewen ; Wang, Jian J ; edk2-devel@lists.01.org Subject: Re: [e

Re: [edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Tim Lewis
Mike -- Ok, I will enter it into Bugzilla later today. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, July 20, 2017 10:57 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2

[edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Tim Lewis
." Thanks, Tim Lewis CTO, Insyde Software www.insyde.com<http://www.insyde.com> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [RFC] PCD: Database size optimization for multi-SKU

2017-05-16 Thread Tim Lewis
01.org<mailto:edk2-devel@lists.01.org> Cc: Star Zeng<mailto:star.z...@intel.com>; Michael Kinney<mailto:michael.d.kin...@intel.com>; Liming Gao<mailto:liming@intel.com>; Tim Lewis<mailto:tim.le...@insyde.com>; Yonghong Zhu<mailto:yonghong@intel.com> Subj

Re: [edk2] [PATCH] ShellPkg/Touch: Create file if it doesn't exist

2017-05-15 Thread Tim Lewis
I don't think it is good to change the behavior of the tool beyond what is in the specification. Further, this tool has existed for quite a long time in the EDK shell and now the UEFI shell without this behavior. So the de-facto standard of this environment is "don't create". Leaving behind stra

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-15 Thread Tim Lewis
Star -- Thanks for your work on this. I have reviewed this and it looks good, addressing all of our concerns. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Monday, May 15, 2017 2:46 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-05 Thread Tim Lewis
can decide not to use this, but we actually like it. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, Star Sent: Friday, May 05, 2017 3:08 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming S

Re: [edk2] [RFC 0/3] Structure PCD value assignment in DEC/DSC

2017-05-04 Thread Tim Lewis
Mike -- Sorry for the delay. We have reviewed this RFC internally and we believe it is a useful change. Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, April 11, 2017 8:17 AM To: edk2-devel@lists.01.org

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-04 Thread Tim Lewis
...@intel.com] Sent: Thursday, May 04, 2017 6:42 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Tim, To avoid misunderstanding, I think I need to clarify more about this RFC. :) This RFC is NOT to

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-03 Thread Tim Lewis
s not found in array } Resource = NULL; while (!GetResourceForSkuId(*SkuId, &Resource) && *SkuId == 0) { *SkuId++; } If (Resource == NULL) { // error, no resource found for any of the SKU IDs } From: Zeng, Star [mailto:star.z...@intel.com] Sent: Wednesday, May 03, 2017 7:03

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-28 Thread Tim Lewis
-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Wednesday, April 26, 2017 5:27 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Shaw, Kevin W Subject: Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM Mike -- No, the meta-data

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Tim Lewis
, Star<mailto:star.z...@intel.com> Sent: Thursday, April 27, 2017 6:53 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Kinney, Michael D<mailto:michael.d.kin...@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Gao, Liming<mailto:liming@intel.com&

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Tim Lewis
abase. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, April 27, 2017 6:00 PM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Tim, Could you share

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Tim Lewis
Mike -- For the one-logo case, yes, that would work. But this is the simplest case. Consider HII string packages. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 5:28 PM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
ve the previous behavior. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 5:02 PM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2] [edk2-UniSpecificati

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
d. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 3:47 PM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2] [edk2-UniSpecification PATCH] Allow .uni fil

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
...@intel.com] Sent: Wednesday, April 26, 2017 3:57 PM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Hi Tim, How would this relationship information be used in a module? Do you have an example use case

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
riginal Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 12:04 PM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Hi Tim, If multiple SKUs a

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
, April 26, 2017 11:47 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM Tim, If you look at the entire file history of the EDK II, you will see

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
Mike -- I am saying that creating a relationship between SKUs that cannot be determined at runtime is a confusing thing to add to the DSC. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:40 AM To: Tim Lewis ; Zeng

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
kward compatible for these files. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:11 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2]

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:05 AM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Tim, Can you please provide more details on your specific concerns along with some use

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
when one is not present won't help the vast quantities of existing UNI files out there. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, April 26, 2017 10:45 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Shaw, Kevin W Su

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
Star -- This assumes that the SKU ID is only used for PCDs, which is not the case. The SKU ID may be used by other components, and other components may use the 0|DEFAULT rule as well. 1) There is no way to read this defaulting rule at runtime. The information is buried in the PCD database, bu

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
Mike -- This breaks our existing build tools, which assume that a file without a BOM is UTF-16. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Tuesday, April 25, 2017 6:07 PM To: edk2-devel@lists.01.org Cc: Jaben Cars

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Tim Lewis
There are "load options" that are passed to drivers (as a part of the EFI_LOADED_IMAGE_PROTOCOL), but there is no guarantee as to their format (binary data or ASCII string or UCS-2 string). It is possible for "load" to be modified to create this data and populate it between the calls to LoadImag

Re: [edk2] Print from DXE_DRIVER

2017-02-08 Thread Tim Lewis
Also, on many systems, the output will be invisible, since boot screen output is a platform policy. In general, using DEBUG() is better, since it can either be redirected to StdErr() or through the serial port. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
: Monday, January 23, 2017 1:59 PM To: Tim Lewis ; Ni, Ruiyu ; Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1 I was wondering if some replaced version of HiiLib could use the StrDefs.h differently and save the

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Monday, January 23, 2017 1:48 PM To: Tim Lewis ; Ni, Ruiyu ; Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1 Tim, I meant some customers do localize the shell

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
tional shell in a much more restricted environment. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, January 23, 2017 1:15 PM To: Tim Lewis ; Ni, Ruiyu ; Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben Sub

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
Also, in some cases, the text is taken directly from the specification. Introducing HII strings in order to make these translatable when the source material is normative doesn't help, IMO. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cars

Re: [edk2] [shell] Pipe causes pool failure in Shell.c

2016-12-02 Thread Tim Lewis
Jaben -- I'm not sure. In the debugger, it clearly showed the memory as having already been freed at the pointer. But I didn't track down who had done it. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, December 02, 2016 8:39 AM To:

[edk2] [shell] shift generates errors with no command-line options

2016-12-02 Thread Tim Lewis
In a script that looks like this: :start if not %1 == "" then echo %1 shift goto start endif 'shift' will generate an error message. The spec doesn't describe any behavior like this and it is annoying to write scripts that must avoid it. Of course you can work around it... Tim __

[edk2] [shell] @ does not work before if, endif, for and many other command.

2016-12-02 Thread Tim Lewis
Try this: :start @if %1 == "" then @goto Done @endif @echo Parameter: %1 @shift goto start :Done Per Chapter 4 Also, additional '@' before a command in a script file can prevent the current command from being echoed. ___

[edk2] [shell] Redirected Environment Variables Are Not Saved Correctly

2016-12-02 Thread Tim Lewis
Test by doing this, immediately after booting: Notice that echo has created a new environment variable _key to the value 4, But this variable does not show up when running "set" Why? It is because the FileHandleWrappers does not use SetEnvironmentVariable. Instead, it tries to read and write th

[edk2] [shell] Pipe causes pool failure in Shell.c

2016-12-01 Thread Tim Lewis
.01.org] On Behalf Of Tim Lewis Sent: Thursday, December 01, 2016 5:48 PM To: edk2-devel@lists.01.org Subject: [edk2] Pipe causes pool failure in Shell.c Using the latest Shell build, try: ls -sfo | parse FileInfo 2 This ends up with a breakpoint when FreePool is called on Shell.c, line 1756.

[edk2] Root Cause of Parse Failure With Redirected Input

2016-12-01 Thread Tim Lewis
if (StrStr (TempLine, L"ShellCommand,") == TempLine) { LoopVariable++; } This line fails because, with redirected input, the file has the UCS-2 byte order mark, so the string "ShellCommand," is not at the beginning of the line. With the file, the byte order mark is not presen

[edk2] Pipe causes pool failure in Shell.c

2016-12-01 Thread Tim Lewis
Using the latest Shell build, try: ls -sfo | parse FileInfo 2 This ends up with a breakpoint when FreePool is called on Shell.c, line 1756. I'm still debugging, but I wondered if anyone else has seen this? Also: ls -sfo > tmp parse FileInfo 2 < tmp prints nothing, but parse tmp FileInfo 2 w

[edk2] [shell] Redirection to environment variable used on command-line not working.

2016-12-01 Thread Tim Lewis
I have a command like this: X %_key% >v _key and X %_key% _key These two commands should do, essentially the same thing, since the command 'X' calls ShellSetEnvironmentVariable() if the 2nd parameter is present. Any thoughts? Tim ___ edk2-devel ma

[flashrom] Apollo Lake

2016-11-08 Thread Tim Lewis
the ROM using the HWSEQ style. I have tracked it down to the function that waits for complete, where it fails. Any thoughts? Thanks, Tim Lewis P.S. I have this working with other flash utilities, so I know that the hardware is working and the flash part is present and responds. FAILED.p@p

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-28 Thread Tim Lewis
Sure. I think we should adjust the specification in this case. My problem has been when someone says "but the EDK2 version does X" Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, October 28, 2016 9:59 AM To: Tim Lewis ; edk2-devel@li

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-28 Thread Tim Lewis
[mailto:jaben.car...@intel.com] Sent: Friday, October 28, 2016 8:20 AM To: Tim Lewis ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [shell] AliasLower never used in InternalSetAlias Tim, Given that all commands are case insensitive, I couldn't imagine why we would want case-sensit

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-27 Thread Tim Lewis
.org] On Behalf Of Tim Lewis Sent: Thursday, October 27, 2016 2:11 PM To: edk2-devel@lists.01.org Subject: [edk2] [shell] AliasLower never used in InternalSetAlias In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never

[edk2] [shell]cd.. and cd\ are not valid alias

2016-10-27 Thread Tim Lewis
But the EDK2 registers them as a part of Level 2 supported command initialization. ShellCommandRegisterAlias(L"cd ..", L"cd.."); ShellCommandRegisterAlias(L"cd \\", L"cd\\"); According to the SetAlias() description: An alias is a C-style identifier The same language is repeated in 3.6.4.

[edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-27 Thread Tim Lewis
In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never actually used. Am I missing something? // Convert to lowercase to make aliases case-insensitive if (Alias != NULL) { AliasLower = AllocateCopyPool (StrSize

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

2016-10-18 Thread Tim Lewis
Reviewed-by: Tim Lewis -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 18, 2016 4:07 AM To: edk2-devel-01 Cc: Jaben Carsey ; Ruiyu Ni ; Tim Lewis Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName() The

[edk2] FW: [shell] Problems in EfiShellGetGuidFromName

2016-10-18 Thread Tim Lewis
Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the EDK2 implementation? Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Thursday, October 13, 2016 11:16 AM To: edk2-devel-01 Subject: [edk2

Re: [edk2] [PATCH 1/5] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

2016-10-14 Thread Tim Lewis
Glad to see this is finally being done! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, October 14, 2016 2:44 AM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Michael D Kinney ; Jiewen Yao Subject: [edk2] [PATCH 1/5] Shell

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-14 Thread Tim Lewis
I prefer the renamed .h file, even though I have substantial investment in the current infrastructure. Why? Because engineers don't have time to remember "how does protocol X translate to header file Y" It should be a consistent rule. How many times have I needed to grep the header file name ju

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Tim Lewis
Liming -- And I agree that this should be the behavior. I was surprised by the lack of translation for the other string printed via %s. Tim -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, October 13, 2016 6:24 PM To: Tim Lewis ; edk2-devel-01

[edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Tim Lewis
In using AsciiPrint (I'm presuming the behavior is also in Print, but I haven't tested), I found an interesting behavior for linefeed characters embedded in strings that are parameters. I post it here just so people who are mystified by their output can understand it. Consider this example: CO

  1   2   3   4   5   6   >