Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19308#discussion_r140320919
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -517,6 +517,7 @@ public void loadBytes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19181
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19181
@eyalfa you should be able to retrigger tests yourself: `jenkins retest
this please`
---
-
To unsubscribe, e-mail: reviews
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138739155
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
---
@@ -19,28 +19,61 @@
import
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138738642
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138737542
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -46,6 +47,42 @@ public static int
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138737410
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -75,67 +76,131 @@ public static boolean unaligned() {
return
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r138735379
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -503,6 +511,47 @@ public void
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19181
cc @juliuszsompolski can you take a look, or perhaps take this for a test
drive?
---
-
To unsubscribe, e-mail: reviews
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r138733992
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -162,14 +162,20 @@ private int
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r138733553
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -85,7 +85,7 @@
private final
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19181
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19175
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Repository: spark
Updated Branches:
refs/heads/branch-2.2 50f86e1fe -> fb1b5f08a
[SPARK-21418][SQL] NoSuchElementException: None.get in DataSourceScanExec with
sun.io.serialization.extendedDebugInfo=true
## What changes were proposed in this pull request?
If no SparkConf is available to
Repository: spark
Updated Branches:
refs/heads/master 9f30d9280 -> ca59445ad
[SPARK-21418][SQL] NoSuchElementException: None.get in DataSourceScanExec with
sun.io.serialization.extendedDebugInfo=true
## What changes were proposed in this pull request?
If no SparkConf is available to
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19123
LGTM, merging to master/2.2. Thanks for picking this up!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19050#discussion_r135389263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -98,6 +99,11 @@ object RewritePredicateSubquery
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19050#discussion_r135271400
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -98,6 +99,11 @@ object RewritePredicateSubquery
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19050#discussion_r135270779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2502,3 +2373,140 @@ object UpdateOuterReferences
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19042
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/19042
[SPARK-21830][SQL] Bump ANTLR version and fix a few issues.
## What changes were proposed in this pull request?
This PR bumps the ANTLR version to 4.7, and fixes a number of small parser
Repository: spark
Updated Branches:
refs/heads/branch-2.2 236b2f4d5 -> a58536741
[SPARK-21826][SQL] outer broadcast hash join should not throw NPE
This is a bug introduced by
https://github.com/apache/spark/pull/11274/files#diff-7adb688cbfa583b5711801f196a074bbL274
.
Non-equal join
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19036
Merging to master/2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Repository: spark
Updated Branches:
refs/heads/master 183d4cb71 -> 2dd37d827
[SPARK-21826][SQL] outer broadcast hash join should not throw NPE
## What changes were proposed in this pull request?
This is a bug introduced by
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19036
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Repository: spark
Updated Branches:
refs/heads/master 77d046ec4 -> b3a07526f
[SPARK-21718][SQL] Heavy log of type: "Skipping partition based on stats ..."
## What changes were proposed in this pull request?
Reduce 'Skipping partitions' message to debug
## How was this patch tested?
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19010
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134208734
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -0,0 +1,653 @@
+/*
+ * Licensed
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18993
LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133972522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1180,6 +1180,9 @@ object ConvertToLocalRelation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133943823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1180,6 +1180,9 @@ object ConvertToLocalRelation
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18959
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Repository: spark
Updated Branches:
refs/heads/master ae9e42479 -> 6aad02d03
[SPARK-18394][SQL] Make an AttributeSet.toSeq output order consistent
## What changes were proposed in this pull request?
This pr sorted output attributes on their name and exprId in
`AttributeSet.toSeq` to make the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18979
cc @adrian-ionescu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18955
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18959#discussion_r133445750
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala
---
@@ -121,7 +121,12 @@ class AttributeSet private
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18955#discussion_r133438086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -72,7 +72,12 @@ abstract class SparkStrategies extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18958
On a more generic level. We could also choose to make `ColumnVectors`
immutable, and create builder classes to create (reusable) instances; this
would create a better separation between
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133434818
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnVector.java
---
@@ -0,0 +1,599 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18955#discussion_r133422587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -474,6 +474,10 @@ case class CollapseCodegenStages
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133421918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -89,14 +91,23 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133421832
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -89,14 +91,23 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133420801
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -491,6 +525,22 @@ public void loadBytes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133420728
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -40,8 +39,43 @@
private long
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133419451
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnVector.java
---
@@ -0,0 +1,599 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133418831
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,73 @@ public void update(int ordinal
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18843
Merging to master/2.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Repository: spark
Updated Branches:
refs/heads/branch-2.2 c90949698 -> 406eb1c2e
[SPARK-21595] Separate thresholds for buffering and spilling in
ExternalAppendOnlyUnsafeRowArray
## What changes were proposed in this pull request?
Repository: spark
Updated Branches:
refs/heads/master 0377338bf -> 94439997d
[SPARK-21595] Separate thresholds for buffering and spilling in
ExternalAppendOnlyUnsafeRowArray
## What changes were proposed in this pull request?
[SPARK-21595](https://issues.apache.org/jira/browse/SPARK-21595)
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18907
@shaneknapp thanks for quick response!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18907
I think something is up jenkins. @shaneknapp could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18843#discussion_r132156490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -844,24 +844,39 @@ object SQLConf {
.stringConf
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18892
@heary-cao can you improve the PR description, and explain what special
cases you are improving.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18843
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18892
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18843
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18880
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18836#discussion_r131596479
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -82,7 +82,7 @@ case class SortMergeJoinExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131530967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left: Expression
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18843
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Repository: spark
Updated Branches:
refs/heads/master 1347b2a69 -> 231f67247
[SPARK-21205][SQL] pmod(number, 0) should be null.
## What changes were proposed in this pull request?
Hive `pmod(3.13, 0)`:
```:sql
hive> select pmod(3.13, 0);
OK
NULL
Time taken: 2.514 seconds, Fetched: 1 row(s)
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18413
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18833
@maropu that only works for literals. I am sort-of in favor of the Hive
default; it seems kinda bad to bring down a job because of negative value.
---
If your project is set up for it, you can
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18836#discussion_r131239029
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -82,7 +82,7 @@ case class SortMergeJoinExec
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18679
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r129005758
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -267,16 +267,17 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r129005233
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -267,16 +267,17 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r129005122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -106,173 +101,167 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r129004992
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -106,173 +101,167 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r127453702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -106,173 +105,164 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r127449331
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -106,173 +105,164 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r126680805
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -805,4 +806,24 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18531#discussion_r125821262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -45,11 +45,9 @@ import
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18543
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r125735576
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/WindowSpec.scala ---
@@ -174,28 +191,22 @@ class WindowSpec private[sql
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18535
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18541
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18541#discussion_r125631732
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -588,6 +588,10 @@ public long getKeyPrefix
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18541#discussion_r125631249
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -596,17 +600,37 @@ public long getKeyPrefix
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18541#discussion_r125632002
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -596,17 +600,37 @@ public long getKeyPrefix
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18541#discussion_r125631060
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -596,17 +600,37 @@ public long getKeyPrefix
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r125602833
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -109,46 +109,54 @@ case class WindowExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r125603187
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -151,6 +151,48 @@ class DataFrameWindowFunctionsSuite
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r125598577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -43,57 +42,57 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r125599886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -106,173 +105,161 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r125602934
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/WindowSpec.scala ---
@@ -174,28 +191,22 @@ class WindowSpec private[sql
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18494
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r125034337
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -1088,6 +1088,12 @@ public UTF8String clone
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18483
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16699
@yanboliang @actuaryzhang this PR breaks the scala-2.10 build:
```
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/mllib/src/test/scala/org/apache/spark/ml
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r125025743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -94,4 +108,21 @@ object InternalRow
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r125025770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -94,4 +108,21 @@ object InternalRow
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r124995524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -94,4 +108,21 @@ object InternalRow
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r124995580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -94,4 +108,21 @@ object InternalRow
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r124984978
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -1088,6 +1088,12 @@ public UTF8String clone
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r124995623
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -1088,6 +1088,12 @@ public UTF8String clone
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r124988718
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -172,4 +172,40 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18483#discussion_r124985506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -94,4 +108,21 @@ object InternalRow
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/18470
[SPARK-21258][SQL] Fix WindowExec complex object aggregation with spilling
## What changes were proposed in this pull request?
`WindowExec` currently improperly stores complex objects
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18440
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
1101 - 1200 of 5057 matches
Mail list logo
