[systemsettings] [Bug 445224] kcm_formats doesn't show the short date format preview

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=445224

Ahmad Samir  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|NOT A BUG   |---

--- Comment #4 from Ahmad Samir  ---
I have the new KCM, which doesn't have the date format I mentioned in the
description; I posted a screenshot of the old one that has it, the current KCM
doesn't

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 445224] kcm_formats doesn't show the short date format preview

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=445224

--- Comment #2 from Ahmad Samir  ---
Created attachment 143382
  --> https://bugs.kde.org/attachment.cgi?id=143382=edit
kcm_formats

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 445224] New: kcm_formats doesn't show the short date format preview

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=445224

Bug ID: 445224
   Summary: kcm_formats doesn't show the short date format preview
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: a.samir...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Launching `systemsettings kcm_formats` I don't see the short date format e.g.:
09-11-2021 or
09/11/2021

it used to be shown in the KCM before the recent rewrite.

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: How do you label code to be deleted in KF6?

[Ahmad Samir]

On 11/9/21 04:33, Glen Ditchfield wrote:

I would like to have some members of KCalendarCore's incidence classes
removed during the transition from KF5 to KF6, and I'd like to be sure
that the changes won't be missed in the excitement.

Do you have some preferred way to label such changes?  For example, is
there some `#if` statement that can be wrapped around the code, such
that it will be compiled into KF5 but compiled out of KF6?




Hello. We use deprecation macros, grep for DEPRECATED in any KF repo, and see the manual pages for 
those macros (defined by extra-cmake-modules), lots of examples in the repos already.


--
Ahmad Samir

[konsole] [Bug 445173] Konsole crash when attempting to make new (and renamed) profile "default"

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=445173

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
I tested with your steps to reproduce, and I don't see this issue with the
master branch; there has been various changes to the profile dialog(s), and so
I assume it's been fixed in master.

FWIW, when you edit the "built-in" profile, the code creates a new profile
because the built-in one is immutable, it acts as a global fallback if you have
no profiles at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 445109] Phantom Firefox video under transparent Konsole background

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=445109

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||k...@davidedmundson.co.uk,
   ||vlad.zahorod...@kde.org

--- Comment #1 from Ahmad Samir  ---
Looks like a gfx or compositor issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 428950] Dolphin's Search does not respect wildcards and ignores period symbol

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=428950

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
If you don't have baloo enabled, kio_filenamesearch is used, which doesn't
support wildcards (never did, AFAICS), for regex:
. matches any one character
.* matches any number of characters
\. matches a literal '.' character

for example:
.*tar\.xz

will only match foobar.tar.xz

-- 
You are receiving this mail because:
You are watching all bug changes.

Reminder: KF6 weekly meeting

[Ahmad Samir]

Hello.

As was said in the last meeting's notes, the time of the meeting has been changed to 17:00 CET (due 
to DST change in continental Europe), so that's 16:00 UTC.


Have a good day.
--
Ahmad Samir

[frameworks-kio] [Bug 444624] Unable to change user/group of an element from the desktop

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=444624

--- Comment #3 from Ahmad Samir  ---
Note that you can only change the user if you're root, otherwise the user
combobox isn't shown. So it's only the group combobox that's not working here.

-- 
You are receiving this mail because:
You are watching all bug changes.

Correction to git script to create a work branch

[Ahmad Samir]

This concerns this section:
https://community.kde.org/Infrastructure/GitLab#Using_work_branches_instead_of_forks

The first version of the script (written by me) had a stupid flaw, it didn't guard against being 
called with an empty arg; usually it should be used like this:

$ git work branch-name

if you end up using it without an arg, just `git work`, the setup of your git repo could get screwed 
up, for example, trying to create a branch afterwards, you could end up with:

warning: refname 'origin/master' is ambiguous.
warning: refname 'origin/master' is ambiguous.
fatal: Ambiguous object name: 'origin/master'.


Fortunately, the fix seems to be simple:
$ git show-ref master
a6b947711efdf83718ad4d5ffb384a2bd36e559d refs/heads/master
3ae9d7d897d248024d5bc060fe89f7c30154d4c6 refs/heads/origin/master
a6b947711efdf83718ad4d5ffb384a2bd36e559d refs/remotes/origin/master

$ git update-ref -d refs/heads/origin/master

see this excellent https://stackoverflow.com/a/26046933 post for explanation (I am not a git expert, 
but that worked, AFAICS).


Anyway, the script has been fixed to bail out early if it's called without an 
arg.

Sorry for the inconvenience. :)

--
Ahmad Samir

Debugging io-slaves

[Ahmad Samir]

The wiki has been updated recently 
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves#If_KDE_FORK_SLAVES_is_set


With KIO master, now we should be able to catch a kio-slave in gdb when slaves are forked (the 
current default), just like we were able to do with kdeinit (when io-slaves aren't forked).


Regards,
Ahmad Samir

[frameworks-kservice] [Bug 434362] mimeapps.list entries containing spaces are not interpreted properly

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=434362

--- Comment #10 from Ahmad Samir  ---
That is an issue caused by a broken .desktop file.

If that file was created by KDE code, we can look into fixing how the file is
created.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kservice] [Bug 434362] mimeapps.list entries containing spaces are not interpreted properly

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=434362

--- Comment #8 from Ahmad Samir  ---
I tested again with element (matrix client, since that's what I have on disk),
renamed the .desktop file to 'elem ent.desktop'

x-scheme-handler/element=elem ent.desktop

and it seems to work. Any other clues how to reproduce this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 444621] Konsole does not find file after deleting and re-creating folder

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=444621

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED

--- Comment #1 from Ahmad Samir  ---
You deleted the whole folder from underneath the Shell's feet; to make it work
again you need to `cd ./`. So this the expected behaviour of the Shell you're
using, not Konsole.

FWIW, Konsole in such cases would should the string "(deleted)" as part of the
tab name.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 438043] Konsole suddenly stopped asking me for conformation on multi-line paste

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=438043

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #6 from Ahmad Samir  ---
An alternative is enabling "bracketed-paste" in bash (IIRC readline (which is
used by bash) has made bracketed-paste the default since version 8.1,
https://lwn.net/Articles/839213/).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 76380] Trashing files on other partitions and disks that are mounted without UID=USERID, GID=USERGROUPID, FMASK=177, DMASK=077 copies them to the Trash directory on /

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=76380

--- Comment #83 from Ahmad Samir  ---
Bind mounts should be fixed by:
https://invent.kde.org/frameworks/kio/-/merge_requests/550

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 442106] "UUID" or "LABEL" fstab entries cause file browsing slowdown (kio commit 7de9c2e3)

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442106

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||5.88
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/221a94a66
   ||c4d2f6e4f2dc938ee8a63a6ca73
   ||9477
 Status|ASSIGNED|RESOLVED

--- Comment #24 from Ahmad Samir  ---
Git commit 221a94a66c4d2f6e4f2dc938ee8a63a6ca739477 by Ahmad Samir.
Committed on 21/10/2021 at 16:12.
Pushed by ahmadsamir into branch 'master'.

KMountPoint: revert to parsing /dev/disk/by-{uuid,label}/ manually

Apparently libblkid is causing some performance issues when resolving
UUID/LABEL tags from fstab when the device that has that UUID/LABEL isn't
present.

Parsing /dev/disk/by-* is more basic, since it's a simple check resolving
some symlinks.

Thanks to the users in the bug report for the investigative work, because
personally I couldn't reproduce the problem on my machine no matter what I
tried.
FIXED-IN: 5.88

M  +1-2CMakeLists.txt
M  +2-3src/core/CMakeLists.txt
M  +1-1src/core/config-kmountpoint.h.cmake
M  +4-14   src/core/kmountpoint.cpp

https://invent.kde.org/frameworks/kio/commit/221a94a66c4d2f6e4f2dc938ee8a63a6ca739477

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 442106] "UUID" or "LABEL" fstab entries cause file browsing slowdown (kio commit 7de9c2e3)

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442106

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #23 from Ahmad Samir  ---
Thanks for the thorough investigation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 442183] Can't change the icon for desktop configuration file associated with Plasma Icon applet

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442183

Ahmad Samir  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #3 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 441847 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 441847] No longer possible to change panel launcher icons to a different image

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441847

Ahmad Samir  changed:

   What|Removed |Added

 CC||sergiu.taranu.inbox@gmail.c
   ||om

--- Comment #5 from Ahmad Samir  ---
*** Bug 442183 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 444135] Open dolphin feature prohibits symbol output

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=444135

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
The setting that control the "url hints" is Edit current profile -> Advanced ->
key combination to show url hints.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443655] Konsole Shift+Left -> "Ambiguous Shortcut detected"

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443655

--- Comment #8 from Ahmad Samir  ---
Close all instances of konsole, then rename ~/.local/sharekxmlgui5/konsole/,
then try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443655] Konsole Shift+Left -> "Ambiguous Shortcut detected"

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443655

--- Comment #3 from Ahmad Samir  ---
Open settings -> configure keyboard shortcuts, search for "left" and see if
there are two shortcuts with the same shift+left combo.

It's a bit weird, but it could be due to messed up config.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 434320] Sometimes "highlight codes" are pasted instead of highlighting

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=434320

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
I think that's bracketed paste; I get the same behaviour if I copy something
then Ctrl+V (quoted-insert) then Ctrl+Shift+V (to actually paste).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443885] Konsole is very slow to output text to screen

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443885

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Try disabling "Reflow lines" (profile settings -> scrolling).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 438187] Search for an item makes kdeinit5 to crash

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=438187

Ahmad Samir  changed:

   What|Removed |Added

Version|5.83.0  |21.08.2
   Assignee|kio-bugs-n...@kde.org   |plasma-b...@kde.org
  Component|general |default
Product|frameworks-kio  |kio-extras

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 438187] Search for an item makes kdeinit5 to crash

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=438187

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In|5.85|21.08.3
  Latest Commit|https://invent.kde.org/netw |https://invent.kde.org/netw
   |ork/kio-extras/commit/5dff3 |ork/kio-extras/commit/c3d52
   |95ecea2977cf149c293c16c4d4a |ebecb7f4890e8a412930bce9c74
   |5151493b|fc9e2f1f

--- Comment #8 from Ahmad Samir  ---
Git commit c3d52ebecb7f4890e8a412930bce9c74fc9e2f1f by Ahmad Samir.
Committed on 16/10/2021 at 21:29.
Pushed by ahmadsamir into branch 'release/21.08'.

kio_filenamesearch: fix crash due to KCoreDirLister changes

Error reporting was changed in KCoreDirlister, to match the original behaviour
we need to explicitly disable auto error handling.

This fixes a crash while searching in Dolphin, kio_filenamesearch intrenally
uses a dirlister, and a nested event loop, if there is an error while listing
some dir it tries to report it using a job ui delegate, but the parent job
could well be dead by that time, which causes a crash:
"QWidget: Cannot create a QWidget without QApplication"

Note that this crash only happens if KDE_FORK_SLAVES is _not_ set.
FIXED-IN: 21.08.3
(cherry picked from commit 5dff395ecea2977cf149c293c16c4d4a5151493b)

M  +1-0filenamesearch/kio_filenamesearch.cpp

https://invent.kde.org/network/kio-extras/commit/c3d52ebecb7f4890e8a412930bce9c74fc9e2f1f

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 410139] Konsole not getting locale, print messages in spanish instead englisg

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=410139

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
Those two messages come from whatever terminal app you're running, Konsole just
displays whatever the shell tells it to.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443655] Konsole Shift+Left -> "Ambiguous Shortcut detected"

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443655

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
> * With just one tab, Shift+Left will open a new tab fine. 

It supposed to switch to the previous tab, i.e. the tab on the left, not open a
new tab...

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 373440] konsole --new-tab opens window instead

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=373440

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #49 from Ahmad Samir  ---
At the very least we should change the --new-tab cli help message, to say this
only works when running Konsole in single process mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kconfig] [Bug 397602] Configuration files should contain only persistent configuration and not state

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=397602

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #13 from Ahmad Samir  ---
Note that State= includes toolbars and dockwidgets (e.g. dolphin's places
panel) locations/orientation; that isn't transient config IMHO.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443397] Konsole crashes during Firefox PGO+LTO compilation

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443397

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
This matches what I saw when I tries compiling firefox, it takes a lot of
memory, I had to decrease the number of parallel make jobs.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 443196] multiple instances open upon login

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443196

--- Comment #10 from Ahmad Samir  ---
I'd changed the Product in this report, so you don't need to file a new one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 443196] multiple instances open upon login

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443196

--- Comment #8 from Ahmad Samir  ---
Plasma 5.14 is quite old.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 443196] multiple instances open upon login

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443196

Ahmad Samir  changed:

   What|Removed |Added

   Assignee|konsole-de...@kde.org   |k...@davidedmundson.co.uk
Version|unspecified |5.18.7
 CC||plasma-b...@kde.org
  Component|general |general
   Target Milestone|--- |1.0
Product|konsole |plasmashell

--- Comment #7 from Ahmad Samir  ---
That means session saving isn't working correctly; but that would be a plasma
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443196] multiple instances open upon login

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443196

--- Comment #5 from Ahmad Samir  ---
You mean all konsole windows are closed before you logout but they still open
again when you login?

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: 5.87 respin request

[Ahmad Samir]

On 10/4/21 14:01, David Faure wrote:

On lundi 4 octobre 2021 13:22:22 CEST Ahmad Samir wrote:

On 10/3/21 08:29, Ahmad Samir wrote:

Please include
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf
0b6d2f3cff089207c61d7276

Fixes https://bugs.kde.org/show_bug.cgi?id=442332

Regards,
Ahmad Samir


And
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/3687f696a48b5917e
3edb5d1513543c0d9939de1

(Which replaces 99d8dca607327e with a supposedly better fix).


Yes this second commit makes more sense, the comment was wrong in the old
commit. But for users it should be all the same, so isn't 99d8dca607327e good
enough for 5.87 ?



Thinking about it, yes, disconnecting all signals before making our one, should 
have the same effect.

--
Ahmad Samir

D26675: [sddm-theme] Don't have a broken reveal password button

[Ahmad Samir]

ahmadsamir added a comment.


  In D26675#678819 , @davidre wrote:
  
  > we could install an icon into hicolor as fallback
  
  
  Some time ago I tried finding which icon was being used, but I didn't get 
anywhere and moved on (I copied the theme folder, modified the file to show the 
password and used the custom theme ever since).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: davidre, ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: 5.87 respin request

[Ahmad Samir]

On 10/3/21 08:29, Ahmad Samir wrote:

Please include
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf0b6d2f3cff089207c61d7276

Fixes https://bugs.kde.org/show_bug.cgi?id=442332

Regards,
Ahmad Samir



And 
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/3687f696a48b5917e3edb5d1513543c0d9939de1

(Which replaces 99d8dca607327e with a supposedly better fix).

--
Ahmad Samir

5.87 respin request

[Ahmad Samir]

Please include 
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf0b6d2f3cff089207c61d7276


Fixes https://bugs.kde.org/show_bug.cgi?id=442332

Regards,
Ahmad Samir

[konsole] [Bug 443212] Konsole resizes the window when switching virtual desktops when run outside KDE

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443212

--- Comment #3 from Ahmad Samir  ---
No problem, it's a weird bug to describe :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] Hiding/minimizing, then showing a konsole window, makes it revert to its default size

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In|21.08.1 |21.08.2

--- Comment #13 from Ahmad Samir  ---
The fix didn't catch the 21.08.1 tagging, so it's actually in 21.08.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] Hiding/minimizing, then showing a konsole window, makes it revert to its default size

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

Ahmad Samir  changed:

   What|Removed |Added

 CC||gi1242+...@gmail.com

--- Comment #12 from Ahmad Samir  ---
*** Bug 443212 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443212] Konsole resizes the window when switching virtual desktops when run outside KDE

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443212

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 441610 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 443196] multiple instances open upon login

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=443196

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
Is session restore enabled? (systemsettings -> startup and shutdown -> desktop
session).

-- 
You are receiving this mail because:
You are watching all bug changes.

D26675: [sddm-theme] Don't have a broken reveal password button

[Ahmad Samir]

ahmadsamir added a comment.


  One was to fix this is if sddm have copies of the needed password buttons, 
then it should work regardless of the installed icon themes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26675: [sddm-theme] Don't have a broken reveal password button

[Ahmad Samir]

ahmadsamir added a comment.


  In D26675#678811 , @bharadwaj-raju 
wrote:
  
  > Is there an SDDM issue to track this? Because I edited the file to make 
`revealPasswordButtonShown` true, and the button shows up just fine. Which 
makes me think this might've been fixed in SDDM.
  
  
  I am not sure, but I think the issue is when the breeze icon theme isn't 
available, then the button would be shown without an icon, i.e. invisible, and 
we got bug reports of users hitting hit by mistake. Given the nature of the 
text box we're dealing with here, hitting that invisible button by mistake is 
problematic security-wise.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

[frameworks-kio] [Bug 442310] inconsistent error messages depending on way used to try to create a symlink in unsupported filesystem

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442310

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Ahmad Samir  ---
https://invent.kde.org/frameworks/kio/-/merge_requests/592

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 440748] Option in the file picker to open image

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=440748

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/ceb192629
   ||f41838bad9acc586b1ef7178fff
   ||9a8e
   Version Fixed In||5.87

--- Comment #8 from Ahmad Samir  ---
Git commit ceb192629f41838bad9acc586b1ef7178fff9a8e by Ahmad Samir.
Committed on 19/09/2021 at 18:38.
Pushed by ahmadsamir into branch 'master'.

KDirOperator: provide an option to enable showing open-with item actions

The use case here is KFileWidget, even though it sounds weird to add
open-with actions to the open file dialog, it still makes sense if you're
uploading an image to some web site, while picking the image you may want
to open it in a full-fledged viewer; another example, when uploading/attaching
a text file to a bug report or mail client composer, you may want to check
the contents of the file. This is more intuitive than 'open containing folder'
then opening the file.
FIXED-IN: 5.87

M  +48   -0src/filewidgets/kdiroperator.cpp
M  +10   -0src/filewidgets/kdiroperator.h
M  +1-0src/filewidgets/kfilewidget.cpp

https://invent.kde.org/frameworks/kio/commit/ceb192629f41838bad9acc586b1ef7178fff9a8e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 103331] Group should be preserved when making backup

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=103331

--- Comment #22 from Ahmad Samir  ---
Git commit de7aff60e81b05239fd3d6c17895c48a985dd27a by Ahmad Samir.
Committed on 19/09/2021 at 10:06.
Pushed by ahmadsamir into branch 'master'.

Fix permissions when copying files

This reverts commit 7863f595991c5, I was wrong :)

Reading the code some more (in copyjob, file_copy and file_unix), the
permissions arg is '-1' when we shouldn't touch the dest permissions at all,
i.e. leave them as the system default permissions for newly created files
(umask ...etc).

The scenarios are:
- calling KIO::copy() A to B, permissions are preserved by default, i.e. the
  job copies A's permissions to the permissions arg when it calls file_copy
- calling KIO::copy() A to B, and calling setDefaultPermissions(true),
  the job sets the permissions arg to '-1' when it calls file_copy
- calling KIO::file_copy() directly, the you have full control, if you want
  to preserve the permissions use A's permissions as the permissions arg,
  otherwise use '-1' to use the system default permissions

ACL attributes are handled implicitly at the moment, which isn't ideal but
can be improved later on.
Related: bug 404777

FIXED-IN: 5.87

M  +4-6src/core/filecopyjob.h
M  +15   -22   src/ioslaves/file/file_unix.cpp

https://invent.kde.org/frameworks/kio/commit/de7aff60e81b05239fd3d6c17895c48a985dd27a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 404777] KIO::CopyJob::setDefaultPermissions does not work

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=404777

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/de7aff60e
   ||81b05239fd3d6c17895c48a985d
   ||d27a
   Version Fixed In||5.87
 Resolution|--- |FIXED

--- Comment #6 from Ahmad Samir  ---
Git commit de7aff60e81b05239fd3d6c17895c48a985dd27a by Ahmad Samir.
Committed on 19/09/2021 at 10:06.
Pushed by ahmadsamir into branch 'master'.

Fix permissions when copying files

This reverts commit 7863f595991c5, I was wrong :)

Reading the code some more (in copyjob, file_copy and file_unix), the
permissions arg is '-1' when we shouldn't touch the dest permissions at all,
i.e. leave them as the system default permissions for newly created files
(umask ...etc).

The scenarios are:
- calling KIO::copy() A to B, permissions are preserved by default, i.e. the
  job copies A's permissions to the permissions arg when it calls file_copy
- calling KIO::copy() A to B, and calling setDefaultPermissions(true),
  the job sets the permissions arg to '-1' when it calls file_copy
- calling KIO::file_copy() directly, the you have full control, if you want
  to preserve the permissions use A's permissions as the permissions arg,
  otherwise use '-1' to use the system default permissions

ACL attributes are handled implicitly at the moment, which isn't ideal but
can be improved later on.
Related: bug 103331

FIXED-IN: 5.87

M  +4-6src/core/filecopyjob.h
M  +15   -22   src/ioslaves/file/file_unix.cpp

https://invent.kde.org/frameworks/kio/commit/de7aff60e81b05239fd3d6c17895c48a985dd27a

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441206] Dolphin crashes after closing it while terminal is open.

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441206

Ahmad Samir  changed:

   What|Removed |Added

 CC||k...@tfaber.net

--- Comment #22 from Ahmad Samir  ---
*** Bug 442496 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442496] Crash in QStackedLayout::widget when closing Okteta

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442496

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #4 from Ahmad Samir  ---
Indeed, a duplicate of bug 441206.

*** This bug has been marked as a duplicate of bug 441206 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] Hiding/minimizing, then showing a konsole window, makes it revert to its default size

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

Ahmad Samir  changed:

   What|Removed |Added

 CC||trilader+kdeb...@gmail.com

--- Comment #11 from Ahmad Samir  ---
*** Bug 442492 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442492] X11: Konsole resizes the window to default size when minimizing/restoring the window

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442492

--- Comment #3 from Ahmad Samir  ---
You're right, wrong bug number.

*** This bug has been marked as a duplicate of bug 441610 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] Hiding/minimizing, then showing a konsole window, makes it revert to its default size

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

Ahmad Samir  changed:

   What|Removed |Added

Summary|when switching virtual  |Hiding/minimizing, then
   |desktops on OpenBox,|showing a konsole window,
   |konsole windows revert to   |makes it revert to its
   |their default sizes |default size

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442252] konsole starts with tiny window if old konsolerc present

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442252

Ahmad Samir  changed:

   What|Removed |Added

 CC||trilader+kdeb...@gmail.com

--- Comment #5 from Ahmad Samir  ---
*** Bug 442492 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442492] X11: Konsole resizes the window to default size when minimizing/restoring the window

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442492

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 442252 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 299155] File ACLs don't update after changing them and reopening properties

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=299155

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/74d698329
   ||4f58d75ce776fd9011a3d3355b3
   ||7f57
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.87

--- Comment #11 from Ahmad Samir  ---
Git commit 74d6983294f58d75ce776fd9011a3d3355b37f57 by Ahmad Samir.
Committed on 14/09/2021 at 23:31.
Pushed by ahmadsamir into branch 'master'.

KFileItem: refresh() shouldn't discard ACL attributes

Following the code:
- changing the ACL permissions of a file via KPropertiesDialog
- when the dialog is closed the dirlister which is installed on the view
  (in e.g. Dolphin or the open file dialog) is notified that the item has
  changed
- KCoreDirLister would then call item.refresh(), if the old item had the ACL
  field(s) set, and they would be gone after calling refresh()
FIXED-IN: 5.87

M  +0-4src/aclhelpers_p.h
M  +22   -0src/core/kfileitem.cpp

https://invent.kde.org/frameworks/kio/commit/74d6983294f58d75ce776fd9011a3d3355b37f57

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 442457] New: Save/discard/cancel close document dialog now defaults to Cancel

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442457

Bug ID: 442457
   Summary: Save/discard/cancel close document dialog now defaults
to Cancel
   Product: kate
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: ---

- open kate, type some text
- Ctrl + w, the dialog used to default to "Save", now defaults to "Cancel"

Might be related to this change in KWidgetsAddons:
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/54d85c9898f9f23084b4bd47e262e712385aca30

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 442093] Settings dialog in Kate is humongous

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442093

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Probably some QLabels that need to have setWordWrap(true).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 442237] No file name label for readonly files

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442237

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/54efaf612
   ||600ae68773c760636563aca5120
   ||90b2
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.87

--- Comment #3 from Ahmad Samir  ---
Git commit 54efaf612600ae68773c760636563aca512090b2 by Ahmad Samir.
Committed on 14/09/2021 at 17:32.
Pushed by ahmadsamir into branch 'master'.

KPropertiesDialog: show text label with item name for readonly items too
FIXED-IN: 5.87

M  +5-3src/widgets/kpropertiesdialog.cpp

https://invent.kde.org/frameworks/kio/commit/54efaf612600ae68773c760636563aca512090b2

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] when switching virtual desktops on OpenBox, konsole windows revert to their default sizes

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

--- Comment #9 from Ahmad Samir  ---
They are two separate issues, the window is resized when it's minimized then
shown; and the toolbars interfere with the window size hint (IIRC).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] when switching virtual desktops on OpenBox, konsole windows revert to their default sizes

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

--- Comment #7 from Ahmad Samir  ---
It's the same bug, depends on when a showevent is invoked.

As for the toolbars, that is due to the too-long text on them, try hiding the
text.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] when switching virtual desktops on OpenBox, konsole windows revert to their default sizes

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

Ahmad Samir  changed:

   What|Removed |Added

 CC||k...@bh.m5k8.net

--- Comment #5 from Ahmad Samir  ---
*** Bug 442388 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442388] Unexpected window resize after minimization/restore

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442388

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---
Already fixed in 21.08 stable branch, but the commit didn't catch the tagging
of 21.08.1.

*** This bug has been marked as a duplicate of bug 441610 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442252] konsole starts with tiny window if old konsolerc present

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442252

--- Comment #3 from Ahmad Samir  ---
(It's also possible I got it wrong and State has nothing to do with the window
size).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442252] konsole starts with tiny window if old konsolerc present

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442252

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
It looks like it's not just the State= key, these ones come into play too:
DP-1 Height
DP-1 Width
DP-1 XPosition
DP-1 YPosition

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442252] konsole starts with tiny window if old konsolerc present

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442252

Ahmad Samir  changed:

   What|Removed |Added

 CC||piotr.mierzwin...@gmail.com

--- Comment #1 from Ahmad Samir  ---
*** Bug 442284 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 442284] konsole is very small after very first start

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442284

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 442252 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: KF API Documentation proposed, small, addition

[Ahmad Samir]

On 09/09/2021 23:34, Friedrich W. H. Kossebau wrote:

Am Donnerstag, 9. September 2021, 23:23:29 CEST schrieb Ahmad Samir:

On 09/09/2021 22:47, Friedrich W. H. Kossebau wrote:

Am Donnerstag, 9. September 2021, 22:35:05 CEST schrieb Ahmad Samir:

On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote:

Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir:

On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote:

Thanks for pushing this here.

Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir:
Open question:
in which places is it a good idea to use "code"-style with class names
and
method names? So when does readability suffer by too many changes in
the
formatting in a text body?

Looking e.g. at the Qt docs for a reference, they do not use
"code"-style
when referencing classes or methods from text, as well as in the
listing
of classes and methods. So I wonder if this is by design or just
historic?


They use QDoc, IIUC; and it looks like they recommend using \c
https://doc.qt.io/qt-5/04-qdoc-commands-textmarkup.html

at least that page suggests so.


Then our question was not "if" they have a command to markup things to
be
printed code-like, but "when" it should be used. And the examples they
give
(not sure though if exclusive or inclusive) are

"
variable names, user-defined class names, and C++ keywords (for example,
int and for)
".

So no mention of names of the methods, members, properties and classes
the
documentation is about (note the "user-defined"). And looking at the
existing Qt API documentation, I would guess the given list is rather
exclusive then, and \c with Qt is not to be used when referencing the
elements of the documented API itself (at least in flow text).

Myself I meanwhile rather think that this might be a good choice.
Imagine
how e.g. https://doc.qt.io/qt-6/qstring.html would look like if all text
elements referencing Qt classes or method names would be in code-style.
I
guess the reading flow in the flow text blocks would suffer a lot.


So one vote for and one vote against, we need a tie-breaker.


What I would like to see are some argument for why you want this change?
What is broken now, what does it improve?
Can you give an example where your proposal is applied and what the result
is, before and after?


I think it's useful to markup the method names, that makes reading the API
docs in text format in a header file easier, the same way marking up
true/false is useful, the same way syntax highlighting in most text editors
is useful.


I see, that is where you are coming from, it makes some sense there. But...

... it only makes sense for people looking at headers in a plain text editor
which also is capable of parsing doxygen comments and adding respective
highlighting.

.. for every other plain text viewers/editors, including on the gitlab file
viewer, it makes things harder to read.



I don't see how it's harder to read the API docs than '@c true' or '@param'
or any other doxygen command when viewed in an editor that doesn't highlight doxygen syntax 
properly; those same editors highlight C++ code properly?



.. it very possibly lowers the quality of the generated API docs, which should
be the main purpose of writing those API documentation snippets, no?

So im summary not convinced this would be a change for the better.

Cheers
Friedrich




Since no one else seems to care either way, I'll drop the matter.

Regards,
Ahmad Samir

[dolphin] [Bug 442195] Remote shortcut on desktop no longer opened by Dolphin

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442195

--- Comment #6 from Ahmad Samir  ---
Seems to work here and the (s)ftp server I tested with was opened in dolphin.

Try:
kioclient5 exec ~/.local/share/remoteview/.desktop

and post any output here. (If you get no output, try first running `export
QT_LOGGING_RULES="*kio*=true;"` then run the kioclient5 command again).

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: KF API Documentation proposed, small, addition

[Ahmad Samir]

On 09/09/2021 22:47, Friedrich W. H. Kossebau wrote:

Am Donnerstag, 9. September 2021, 22:35:05 CEST schrieb Ahmad Samir:

On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote:

Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir:

On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote:

Thanks for pushing this here.

Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir:
Open question:
in which places is it a good idea to use "code"-style with class names
and
method names? So when does readability suffer by too many changes in the
formatting in a text body?

Looking e.g. at the Qt docs for a reference, they do not use
"code"-style
when referencing classes or methods from text, as well as in the listing
of classes and methods. So I wonder if this is by design or just
historic?


They use QDoc, IIUC; and it looks like they recommend using \c
https://doc.qt.io/qt-5/04-qdoc-commands-textmarkup.html

at least that page suggests so.


Then our question was not "if" they have a command to markup things to be
printed code-like, but "when" it should be used. And the examples they
give
(not sure though if exclusive or inclusive) are

"
variable names, user-defined class names, and C++ keywords (for example,
int and for)
".

So no mention of names of the methods, members, properties and classes the
documentation is about (note the "user-defined"). And looking at the
existing Qt API documentation, I would guess the given list is rather
exclusive then, and \c with Qt is not to be used when referencing the
elements of the documented API itself (at least in flow text).

Myself I meanwhile rather think that this might be a good choice. Imagine
how e.g. https://doc.qt.io/qt-6/qstring.html would look like if all text
elements referencing Qt classes or method names would be in code-style. I
guess the reading flow in the flow text blocks would suffer a lot.



So one vote for and one vote against, we need a tie-breaker.


What I would like to see are some argument for why you want this change?
What is broken now, what does it improve?
Can you give an example where your proposal is applied and what the result is,
before and after?



I think it's useful to markup the method names, that makes reading the API docs in text format in a 
header file easier, the same way marking up true/false is useful, the same way syntax highlighting 
in most text editors is useful.


For examples, open any header file in a KDE repo and add @c before a method name in the comment 
above any method. :)



Cheers
Friedrich





Regards,
Ahmad Samir

Re: KF API Documentation proposed, small, addition

[Ahmad Samir]

On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote:

Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir:

On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote:

Thanks for pushing this here.

Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir:
Open question:
in which places is it a good idea to use "code"-style with class names and
method names? So when does readability suffer by too many changes in the
formatting in a text body?

Looking e.g. at the Qt docs for a reference, they do not use "code"-style
when referencing classes or methods from text, as well as in the listing
of classes and methods. So I wonder if this is by design or just
historic?


They use QDoc, IIUC; and it looks like they recommend using \c
https://doc.qt.io/qt-5/04-qdoc-commands-textmarkup.html

at least that page suggests so.


Then our question was not "if" they have a command to markup things to be
printed code-like, but "when" it should be used. And the examples they give
(not sure though if exclusive or inclusive) are

"
variable names, user-defined class names, and C++ keywords (for example, int
and for)
".

So no mention of names of the methods, members, properties and classes the
documentation is about (note the "user-defined"). And looking at the existing
Qt API documentation, I would guess the given list is rather exclusive then,
and \c with Qt is not to be used when referencing the elements of the
documented API itself (at least in flow text).

Myself I meanwhile rather think that this might be a good choice. Imagine how
e.g. https://doc.qt.io/qt-6/qstring.html would look like if all text elements
referencing Qt classes or method names would be in code-style. I guess the
reading flow in the flow text blocks would suffer a lot.

Cheers
Friedrich




So one vote for and one vote against, we need a tie-breaker.

Regards,
Ahmad Samir


--
Ahmad Samir

Re: KF API Documentation proposed, small, addition

[Ahmad Samir]

On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote:

Thanks for pushing this here.

Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir:

I would like to add the following to:
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Documen
t_the_Classes


One can use [https://www.doxygen.nl/manual/commands.html Doxygen commands]
to improve readability, for example
* @c which will make the word after it use a monospace/typewriter font face,
typically e.g. @c true, @c false, @c setSomeValue(); for multiple words
you'll have to use: multiple words
* @copydoc to copy the docs of a different method, e.g. if one method
overloads another


I propose to turn "can use" into "should use" and define where which command
should be used where (and which variant in case of aliases), for a consistent
result.
Doxygen commands are already used, so I cannot see how the current proposal
for an addition makes a difference about helping when to do what?

So in the given case, the motivation of the proposal is to improve the
resulting documentation to have all in-text (C++) code expressions to be
formatted in code-typical ways (i.e. monospace fonts). So far this was mainly
done for literal code expressions like "nullptr", "true" and "false", whereas
method names or class names were not, until recently at least.



I agree about "should use".

For how to use a command, one should read the Doxygen docs, which are linked in 
the text.


Open question:
in which places is it a good idea to use "code"-style with class names and
method names? So when does readability suffer by too many changes in the
formatting in a text body?

Looking e.g. at the Qt docs for a reference, they do not use "code"-style when
referencing classes or methods from text, as well as in the listing of classes
and methods. So I wonder if this is by design or just historic?



They use QDoc, IIUC; and it looks like they recommend using \c
https://doc.qt.io/qt-5/04-qdoc-commands-textmarkup.html

at least that page suggests so.


Leaving @copydoc for a separate discussion.


There are 123 instances of @copydoc in kdelibs, with the the first appearance being [1] from back in 
2003, I am mainly trying to bring it back into use, by pointing it out in the docs.


Incidentally, I think whenever we update one of the core guide pages in the wiki, we should also 
post a link to the new addition in this ML, otherwise people who already know the guidelines 
inside-out won't read the whole thing again, so they miss the new bit (or miss disagreeing with it 
and starting a discussion).


[1] 
https://invent.kde.org/unmaintained/kdelibs/-/commit/cd9de18af7a5b8fc752346596d1ddde512203537



Cheers
Friedrich




Regards,
--
Ahmad Samir

[dolphin] [Bug 442195] Remote shortcut on desktop no longer opened by Dolphin

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=442195

--- Comment #2 from Ahmad Samir  ---
Could you post more detailed steps to reproduce the bug? how do you create a
remote folder link with Dolphin?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441803] Konsole does not allow to change default profile, but creates new profile instead, leading to cumbersome "New Tab" workflow

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441803

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/-/commit/5ab8
   ||423139467ad97d87d00dc82a85f
   ||91c5a1492
 Resolution|--- |FIXED
 CC||a.samir...@gmail.com
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||21.08

--- Comment #2 from Ahmad Samir  ---
I think this issue is fixed in
https://invent.kde.org/utilities/konsole/-/commit/5ab8423139467ad97d87d00dc82a85f91c5a1492
, version 21.08

Basically when you use "Edit current profile" for the first time, you'd be
editing the built-in profile, which is immutable, so the dialog actually
creates a new profile (as you saw), the missing bit was setting that new
profile as the current session profile:
SessionManager::instance()->setSessionProfile(session(), profile);

FWIW, in git master the menu text has been changed, if the dialog will create a
new profile the text is "create new profile", if it's editing an existing
(editable) profile, it is "edit current profile".

And there is an open MR to rename the "Default" (aka Fallback, aka Built-in)
profile to "Built-in" everywhere, to finally disambiguate the name of the
internal immutable profile.

(A "set profile as default" button sounds like a good idea, currently the only
way to set a profile as default is using the profile manager (settings ->
configure konsole)).

-- 
You are receiving this mail because:
You are watching all bug changes.

Please include this in 5.86

[Ahmad Samir]

Fixes KMountPoint::findByPath():
https://invent.kde.org/frameworks/kio/-/commit/147193f5661173d24d75f6558e5607d3418f6c71

Thanks,
Ahmad Samir

[konsole] [Bug 441199] Plugins menu is shown even when no plugins were loaded

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441199

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||21.12
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/8ee53c
   ||c56e47e7d9fb4f2623e21f68492
   ||e309305
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Ahmad Samir  ---
Git commit 8ee53cc56e47e7d9fb4f2623e21f68492e309305 by Ahmad Samir.
Committed on 03/09/2021 at 18:24.
Pushed by hindenburg into branch 'master'.

Hide the Plugins menu if no plugins were loaded

Apparently KXmlGUI sets the action object name to the "name=" tag from the
ui.rc XML file.
FIXED-IN: 21.12

M  +13   -1src/Application.cpp

https://invent.kde.org/utilities/konsole/commit/8ee53cc56e47e7d9fb4f2623e21f68492e309305

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432077] Konsole flashes when it's closed by pressing Ctrl-D

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=432077

--- Comment #18 from Ahmad Samir  ---
There are two commits, one in comment#7 and one in comment#14 with a couple of
weeks between them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432077] Konsole flashes when it's closed by pressing Ctrl-D

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=432077

--- Comment #16 from Ahmad Samir  ---
Unfortunately the fix didn't catch the git tagging of 20.08.1. The commit in
comment#14 is basically a one-liner, so hopefully easy to backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441889] SSH Manager does not allow port numbers greater than 9999

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441889

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||21.12
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/ee7f71
   ||142fedd6eda49b4246e65f434e4
   ||b3c5bd5
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Ahmad Samir  ---
Git commit ee7f71142fedd6eda49b4246e65f434e4b3c5bd5 by Ahmad Samir.
Committed on 02/09/2021 at 10:57.
Pushed by hindenburg into branch 'master'.

Fix the maximum port number in the SSH Manager plugin

It should be in the System Ports 0-1023 or User Ports 1024-49151 ranges.

See:
https://en.wikipedia.org/wiki/Registered_port
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml
FIXED-IN: 21.12

M  +3-1src/plugins/SSHManager/sshmanagerpluginwidget.cpp

https://invent.kde.org/utilities/konsole/commit/ee7f71142fedd6eda49b4246e65f434e4b3c5bd5

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441889] SSH Manager does not allow port numbers greater than 9999

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441889

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
I did some research and it looks like the maximum port number is 49151 (see the
merge request linked above for more details).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432077] Konsole flashes when it's closed by pressing Ctrl-D

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=432077

--- Comment #13 from Ahmad Samir  ---
Git commit e693f2d7f1977ca227589154a5cd8c18d8ce44b7 by Ahmad Samir.
Committed on 01/09/2021 at 09:38.
Pushed by hindenburg into branch 'master'.

The default navigation method should be TabbedNavigation

TabbedNavigation is when we have a MainWindow, i.e. the typical use case;
whereas NoNavigation is when using Konsole Part. The code in Part calls
setNavigationMethod(NoNavigation), so things should work as before.

I made a wrong assumption that TabbedNavigation was already the default.

M  +1-1src/ViewManager.cpp

https://invent.kde.org/utilities/konsole/commit/e693f2d7f1977ca227589154a5cd8c18d8ce44b7

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 89299] prevent paste of newline characters

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=89299

--- Comment #64 from Ahmad Samir  ---
Bracketed-paste isn't a Konsole feature, it's a BASH feature (and has been
available for a very long time, it's just that BASH enabled it by default in
recent versions).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432077] Konsole flashes when it's closed by pressing Ctrl-D

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=432077

--- Comment #11 from Ahmad Samir  ---
FWIW, should be fixed by
https://invent.kde.org/utilities/konsole/-/merge_requests/469

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432077] Konsole flashes when it's closed by pressing Ctrl-D

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=432077

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #10 from Ahmad Samir  ---
Yeah, I saw that yesterday when I built from git master, I'll look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441199] Plugins menu is shown even when no plugins were loaded

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441199

Ahmad Samir  changed:

   What|Removed |Added

Summary|Plugins menu is empty (has  |Plugins menu is shown even
   |no menu to show)|when no plugins were loaded
 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441199] Plugins menu is empty (has no menu to show)

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441199

Ahmad Samir  changed:

   What|Removed |Added

 CC||d...@mmassa.ro

--- Comment #1 from Ahmad Samir  ---
*** Bug 441820 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441820] Clicking on the "plugins" menu does nothing

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441820

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 441199 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441765] Crash in KCoreDirListerCache::reinsert while saving the history output

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441765

Ahmad Samir  changed:

   What|Removed |Added

 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441765] Crash in KCoreDirListerCache::reinsert while saving the history output

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441765

--- Comment #2 from Ahmad Samir  ---
The crash might be due to the nested eventloop started by QDialog::exec(), if
the dialog was opened then closed really quickly, the signals from KDirNotify
were emitted but the dialog was gone in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441765] Crash in KCoreDirListerCache::reinsert while saving the history output

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441765

Ahmad Samir  changed:

   What|Removed |Added

Summary|Unknown key combination has |Crash in
   |caused one crash during |KCoreDirListerCache::reinse
   |utilisation of the snappy   |rt while saving the history
   |daemon. |output
 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Looking at the backtrace, it looks like you pressed Ctrl+Shift+S which is the
shortcut for saving the history output, it basically invokes a file dialog to
select where you want to save the history, filename...etc.

Looks like the crash happens because reinsert() is trying to delete an item
from the list, but that KFileItem is already gone, most likely crashing while
trying to access a nullptr...

-- 
You are receiving this mail because:
You are watching all bug changes.

KF API Documentation proposed, small, addition

[Ahmad Samir]

I would like to add the following to:
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_the_Classes


One can use [https://www.doxygen.nl/manual/commands.html Doxygen commands] to improve readability, 
for example
* @c which will make the word after it use a monospace/typewriter font face, typically e.g. @c true, 
@c false, @c setSomeValue(); for multiple words you'll have to use:

multiple words
* @copydoc to copy the docs of a different method, e.g. if one method overloads 
another



--
Ahmad Samir

[frameworks-kio] [Bug 398908] Dolphin uses up huge amounts of memory over time

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=398908

Ahmad Samir  changed:

   What|Removed |Added

Summary|MimeTypeFinderJob can use   |Dolphin uses up huge
   |huge amounts of memory  |amounts of memory over time
   |reading unnecessary data|
 Resolution|FIXED   |---
 Status|CLOSED  |REOPENED

--- Comment #105 from Ahmad Samir  ---
First step -> reopen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kservice] [Bug 377446] KServiceGroupPrivate::entries return not all menu items

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=377446

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|FIXED   |UPSTREAM

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kservice] [Bug 377446] KServiceGroupPrivate::entries return not all menu items

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=377446

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
Closing per comment#2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441610] when switching virtual desktops on OpenBox, konsole windows revert to their default sizes

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441610

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
I'll see if can reproduce this issue (and I hope it's not Qt6 related (as I see
in the report you're running Qt6), because I am still on Qt5 :)).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kservice] [Bug 433714] Set "DRI_PRIME=1" if .desktop file contains `PrefersNonDefaultGPU=true`

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=433714

--- Comment #3 from Ahmad Samir  ---
Git commit 85c5815e10a3b448583817de98486d14ebcba3fc by Ahmad Samir.
Committed on 25/08/2021 at 19:18.
Pushed by ahmadsamir into branch 'master'.

Check for "PrefersNonDefaultGPU" desktop entry

And keep the check for X-KDE-RunOnDiscreteGpu for backwards compatibility.
This will be in KF version 5.86.

See:
https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/6eb7cfc0586d4eec3b856799007bf82aca6989a1
https://invent.kde.org/frameworks/kservice/-/commit/e548a548534a8a6aa094afcd7062dbf56cddc559

M  +12   -2src/widgets/kpropertiesdialog.cpp

https://invent.kde.org/frameworks/kio/commit/85c5815e10a3b448583817de98486d14ebcba3fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 441206] Dolphin crashes after closing it while terminal is open.

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441206

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/konsole/commit/2684bc |ities/konsole/commit/a731cd
   |7fa5ac0b740b3e8661c3a0ae013 |883304c2e00dce5210bc929a59d
   |6fde0a7 |49736c2

--- Comment #7 from Ahmad Samir  ---
Git commit a731cd883304c2e00dce5210bc929a59d49736c2 by Ahmad Samir.
Committed on 27/08/2021 at 12:31.
Pushed by ahmadsamir into branch 'release/21.08'.

Only emit empty() in SessionFinished() when in TabbedNavigation mode

empty() is emitted so that MainWindow calls close() and we get rid of the
colours-flashing bug when closing the last session/tab in a window, see
commit bbec72250d080. However all that isn't relevant when we are in
konsole Part mode, where there are no tabs or MainWindows.

This fixes a crash in Dolphin when closing its window while the embedded
Konsole Part is open. The crash would happen as calling
ViewContainer::currentTabViewCount() would end up in the ViewSplitter code
path, which is no-op in Konsole Part.

To test:
- Open dolphin, make sure the terminal panel isn't open to begin with
- open the terminal panel
- close the dolphin window while the terminal panel is open
FIXED-IN: 21.08.1
(cherry picked from commit 2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7)

M  +7-5src/ViewManager.cpp

https://invent.kde.org/utilities/konsole/commit/a731cd883304c2e00dce5210bc929a59d49736c2

-- 
You are receiving this mail because:
You are watching all bug changes.