Re: [Spice-devel] [PATCH spice-common] RFC: spice.proto: add webdav channel

2014-03-17 Thread Alon Levy
On 03/14/2014 06:17 PM, Marc-André Lureau wrote: If no further comments, can I move ahead adding that new channel? ACK by me. On Fri, Feb 28, 2014 at 4:39 PM, David Jaša dj...@redhat.com wrote: On Čt, 2014-02-27 at 18:27 +0100, Marc-André Lureau wrote: Hi On Wed, Feb 26, 2014 at 11:00

Re: [Spice-devel] [PATCH] Don't truncate large 'now' values in _spice_timer_set

2014-03-17 Thread Alon Levy
On 03/10/2014 12:58 PM, Christophe Fergeau wrote: From: David Gibson dgib...@redhat.com static void _spice_timer_set(SpiceTimer *timer, uint32_t ms, uint32_t now) The _spice_timer_set() function takes a 32-bit integer for the now value. The now value passed in however, can exceed 2^32

Re: [Spice-devel] Mouse mode client vs Mouse mode server

2014-03-17 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/15/2014 06:33 AM, Lindsay Mathieson wrote: Whats the significance of this? does server mode come into play when there is no qxl spice agent in the guest? client/server mode has the client/server determine the location of the cursor and

Re: [Spice-devel] [PATCH] migration: Don't assert() if MIGRATE_DATA comes before attaching the agent

2014-03-17 Thread Alon Levy
On 02/24/2014 07:44 PM, Christophe Fergeau wrote: During seamless migration, after switching host, if a client was connected during the migration, it will have data to send back to the new qemu/spice-server instance. This is handled through MIGRATE_DATA messages. SPICE char devices use such

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-16 Thread Alon Levy
On 01/12/2014 07:34 PM, Marc-André Lureau wrote: For example, with qemu, a webdav channel can be created this way: -chardev spiceport,name=org.spice-space.webdav.0,... And redirected to a virtio port: -device virtserialport,...,name=org.spice-space.webdav.0 Ack. Still reviewing the

Re: [Spice-devel] [vdagent-win 0/2] Add VD_AGENT_CAP_MAX_CLIPBOARD support

2014-03-10 Thread Alon Levy
On 03/09/2014 07:01 PM, Uri Lublin wrote: This patch-set adds support for max-clipboard. The implementation is similar to the implementation of linux-vdagent. Patch1 fixes clipboard error handling (also will be used in Patch2) Patch2 implements max-clipboard support Patches look good to me.

Re: [Spice-devel] [PATCH spice-gtk 0/2] WebDAV channel

2014-03-03 Thread Alon Levy
On 02/28/2014 02:16 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Hi, This is the client bits to get folder sharing capability using the WebDAV channel. How to test it? You'll need spice-server with this patch:

Re: [Spice-devel] Kubuntu as a KVM virtualised guest with spice drivers

2014-03-02 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/2014 05:30 AM, Lindsay Mathieson wrote: My apologies if this is inappropriate for the list. I run a proxmox cluster at work (kvm/qemu 1.7) and X just restarts constantly when trying to use the guest drivers for spice (QXL,

Re: [Spice-devel] How to start with Spice Development?

2014-02-25 Thread Alon Levy
On 02/17/2014 08:14 PM, Jeremy White wrote: On 02/17/2014 08:44 AM, Alf G. wrote: Hi, I am very interested to delve into spice and perhaps do some work on it. What is the best way to start? Can I use the documents on spice-space.org/documentation.html

Re: [Spice-devel] Building Spice in an IDE

2014-02-24 Thread Alon Levy
On 02/01/2014 12:54 AM, Wade Johnson wrote: Hi, I am trying to build Spice in Eclipse and make a test environment, but I am having some issues mostly with some dependencies not being resolved, and some constant definitions not being found. Are there any pointers or build guides to getting

[Qemu-devel] [PULL 0/1 v2] libcacard glusterfs fix

2014-02-09 Thread Alon Levy
changes from v1: Added Signed-of by me. The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707: Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into staging (2014-02-08 15:57:51 +) are available in the git repository at:

[Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to

2014-02-09 Thread Alon Levy
linked with the libraries it needs. Signed-off-by: Christophe Fergeau cferg...@redhat.com Signed-off-by: Alon Levy al...@redhat.com --- libcacard/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 4d15da4..6b06448 100644

Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Alon Levy
On 01/30/2014 03:56 PM, Christophe Fergeau wrote: Acked-by: Alon Levy al...@redhat.com As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need

[Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Alon Levy
From: Christophe Fergeau cferg...@redhat.com As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need all of these. This patch ensures it's only

[Qemu-devel] [PULL 0/1] libcacard glusterfs fix

2014-01-30 Thread Alon Levy
The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd: Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +) are available in the git repository at: git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs

[Spice-devel] [PATCH] Handle SIGUSR1 from and SIGHUP to X

2014-01-27 Thread Alon Levy
From: Anonymous wishes@to.remain Relevant excerpt from Xserver(1) man page: /SIGUSR1/ This signal is used quite differently from either of the above. When the server starts, it checks to see if it has inherited SIGUSR1 as SIG_IGN instead of the usual SIG_DFL. In this case, the

Re: [Users] [Spice-devel] Windows guest

2014-01-20 Thread Alon Levy
: Alon Levy [mailto:al...@redhat.com] Sent: Sunday, January 19, 2014 9:06 AM To: Itamar Heim; Maurice James; users@ovirt.org; spice-devel Subject: Re: [Spice-devel] [Users] Windows guest On 01/18/2014 12:36 AM, Itamar Heim wrote: On 01/16/2014 04:22 PM, Maurice James wrote: Does anyone know

Re: [Spice-devel] [Users] Windows guest

2014-01-20 Thread Alon Levy
: Alon Levy [mailto:al...@redhat.com] Sent: Sunday, January 19, 2014 9:06 AM To: Itamar Heim; Maurice James; us...@ovirt.org; spice-devel Subject: Re: [Spice-devel] [Users] Windows guest On 01/18/2014 12:36 AM, Itamar Heim wrote: On 01/16/2014 04:22 PM, Maurice James wrote: Does anyone know

Re: [Spice-devel] [PATCH] randr: Make resolution changing more robust

2014-01-20 Thread Alon Levy
On 01/20/2014 06:43 PM, Christophe Fergeau wrote: When running a guest using a KMS QXL driver on a RHEL6 hypervisor, spice_vdagent would crash on resolution changes with: X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request:

[Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error message

2014-01-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/display/qxl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index e4f172e..f6af470 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1367,7 +1367,8 @@ static void

[Qemu-devel] [PATCH 2/2] qxl: clear irq on reset

2014-01-20 Thread Alon Levy
that the irq is clear. Signed-off-by: Alon Levy al...@redhat.com --- hw/display/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index f6af470..e164d96 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1126,6 +1126,7 @@ static void qxl_reset_state

[Qemu-devel] [PATCH v2] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
Fix signed to unsigned comparison in qxl_create_guest_primary and add the size of the framebuffer to the error message used when setting the guest bug state (which causes a complete guess blackout until reset, so it helps if it is verbose). Signed-off-by: Alon Levy al...@redhat.com --- hw

[Qemu-devel] [PATCH v3] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
guess blackout until reset, so it helps if it is verbose). Signed-off-by: Alon Levy al...@redhat.com --- hw/display/qxl.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index e4f172e..ba752b5 100644 --- a/hw/display/qxl.c +++ b/hw

[Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
guess blackout until reset, so it helps if it is verbose). Signed-off-by: Alon Levy al...@redhat.com --- hw/display/qxl.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index e4f172e..ceae1d9 100644 --- a/hw/display/qxl.c +++ b

Re: [Users] [Spice-devel] Windows guest

2014-01-19 Thread Alon Levy
On 01/18/2014 12:36 AM, Itamar Heim wrote: On 01/16/2014 04:22 PM, Maurice James wrote: Does anyone know if directdraw/directx works on windows guests in Ovirt? adding spice devel There is no direct3d or directdraw implementation in the driver we provide.

Re: [Spice-devel] Meeting at FOSDEM'14

2014-01-19 Thread Alon Levy
On 01/17/2014 10:24 PM, Fedor Lyakhov wrote: Hi, Who is going to visit FOSDEM this year? It would be nice to meet you there! I'll be giving a talk https://fosdem.org/2014/schedule/event/virtiaas23/ on Sunday (Feb 2nd) in the Virtualisation dev room, and you're very welcome! I am going to

Re: [Spice-devel] [Users] Windows guest

2014-01-19 Thread Alon Levy
On 01/18/2014 12:36 AM, Itamar Heim wrote: On 01/16/2014 04:22 PM, Maurice James wrote: Does anyone know if directdraw/directx works on windows guests in Ovirt? adding spice devel There is no direct3d or directdraw implementation in the driver we provide.

Re: [Spice-devel] [PATCH 00/17] Split RedsStream out of reds.c

2014-01-13 Thread Alon Levy
On 01/07/2014 01:14 PM, Christophe Fergeau wrote: Hey, This is a series I've had locally for a while. It moves RedsStream related code out of reds.c to its own file. This shaves ~1000 lines of code out of reds.c The patch series could be split in 2 independent series, first one would be

Re: [Spice-devel] [PATCH 03/17] Move sync_write* to reds_stream.h

2014-01-13 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2014 01:00 PM, Christophe Fergeau wrote: On Sun, Jan 12, 2014 at 01:04:10PM +0200, Alon Levy wrote: On 01/07/2014 01:14 PM, Christophe Fergeau wrote: They are renamed to reds_stream_write* You also changed the return type

Re: [Spice-devel] [PATCH 3/3] Add VD_AGENT_CAP_MAX_CLIPBOARD support

2014-01-12 Thread Alon Levy
On 01/07/2014 01:28 AM, Marc-André Lureau wrote: ping Looks good to me. On Thu, Nov 14, 2013 at 5:03 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: From: Marc-André Lureau marcandre.lur...@gmail.com Do not send clipboard data bigger than last received VDAgentMaxClipboard.

Re: [Spice-devel] Fw: Re: multiple client connect spice-server

2014-01-12 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/07/2014 01:10 PM, Lindsay Mathieson wrote: On Tue, 7 Jan 2014 10:38:26 AM David Ja?a wrote: No, only one client can connect at the same time. David On Út, 2014-01-07 at 10:05 +0800, hhb584520 wrote: how to multiple spice clients can

Re: [Spice-devel] [PATCH 03/17] Move sync_write* to reds_stream.h

2014-01-12 Thread Alon Levy
On 01/07/2014 01:14 PM, Christophe Fergeau wrote: They are renamed to reds_stream_write* You also changed the return type for reds_stream_write_all (was sync_write) to bool, which is now being cast to int in some code paths. Not an objection, but perhaps worth a later patch (unless it's already

Re: [Spice-devel] [PATCH 16/17] Introduce reds_stream_set_channel()

2014-01-12 Thread Alon Levy
On 01/07/2014 01:14 PM, Christophe Fergeau wrote: --- server/reds.c| 6 +++--- server/reds_stream.c | 9 + server/reds_stream.h | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index a993f2c..c6983d8 100644 ---

Re: [Spice-devel] some question about spice client project cegui gui implement

2014-01-05 Thread Alon Levy
On 12/23/2013 04:19 AM, feifei li wrote: Dear all: I read spice client project,find that gui is implement by CEGUI.The taharez_look.scheme,taharez_look.looknfeel,taharez_look.imageset files are provied by XML foemat in CEGUI system, but are provided by .c format in spice client project.I

Re: [Spice-devel] SPICE and guest breakout risk assessment

2014-01-01 Thread Alon Levy
On 12/30/2013 08:44 AM, adrelanos wrote: Hi, I am currently working on testing out KVM as a platform for Whonix, a Debian based spin with anonymity enforcement via usage of virtual machines. All traffic from a workstation vm is forced through a Tor gateway on the second gateway vm.

Re: [Spice-devel] Why spice server can't update area by tree?

2013-12-12 Thread Alon Levy
On 12/08/2013 08:57 AM, thddu wrote: I found some guest applications create a lot of unnecessary qxl commands rendering. But update_area logic of spice server does not utilize the current tree. 1、Why spice server can't update area by tree? I think it's just a todo item. You can see

Re: Problem after update windows VirtIO drivers

2013-12-11 Thread Alon Levy
On 12/11/2013 11:27 AM, Vadim Rozenfeld wrote: On Tue, 2013-12-10 at 15:29 +0200, Alon Levy wrote: On 12/10/2013 04:24 AM, Vadim Rozenfeld wrote: - Original Message - From: Alon Levy al...@redhat.com To: Carlos Rodrigues c...@eurotux.com, kvm@vger.kernel.org, Vadim Rozenfeld vroze

Re: Problem after update windows VirtIO drivers

2013-12-10 Thread Alon Levy
On 12/10/2013 04:24 AM, Vadim Rozenfeld wrote: - Original Message - From: Alon Levy al...@redhat.com To: Carlos Rodrigues c...@eurotux.com, kvm@vger.kernel.org, Vadim Rozenfeld vroze...@redhat.com Sent: Tuesday, December 10, 2013 3:45:32 AM Subject: Re: Problem after update

Re: Problem after update windows VirtIO drivers

2013-12-09 Thread Alon Levy
On 12/09/2013 04:45 PM, Carlos Rodrigues wrote: Hello, After update the VirtIO drivers for Windows Server 2008 R2 64-bit, when i reboot virtual machine, the windows OS get stuck on loading bar. The VirtIO drivers is the latest stable that i made the download from

Re: [Spice-devel] Mouse Edit Cursor invisible on dark backgrounds in Win 7 Guest

2013-12-09 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/07/2013 05:06 PM, Lindsay Mathieson wrote: On Sat, 7 Dec 2013 09:21:44 AM Marian Krcmarik wrote: Most likely The problem you described is fixed by http://lists.freedesktop.org/archives/spice-devel/2013-October/015079.html, So The bug

[Qemu-devel] [PULL] libcacard fixes

2013-12-09 Thread Alon Levy
Anthony, The following changes since commit a1d22a367d5780c9553b2cd5a24f665534ce6ed6: target-cris: Use new qemu_ld/st opcodes (2013-12-08 09:36:02 +0100) are available in the git repository at: git://people.freedesktop.org/~alon/qemu libcacard_ccid.4 for you to fetch changes up to

[Qemu-devel] [PULL] libcacard: Fix compilation for older versions of glib (bug #1258168)

2013-12-09 Thread Alon Levy
From: Stefan Weil s...@weilnetz.de See https://bugs.launchpad.net/bugs/1258168 libcacard/vscclient.c: In function 'do_socket_read': libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached' libcacard/vscclient.c:410: warning: nested extern declaration of

Re: [Qemu-devel] [PATCH v2] libcacard: Fix compilation for older versions of glib (bug #1258168)

2013-12-08 Thread Alon Levy
On 12/05/2013 08:41 PM, Stefan Weil wrote: See https://bugs.launchpad.net/bugs/1258168 libcacard/vscclient.c: In function 'do_socket_read': libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached' libcacard/vscclient.c:410: warning: nested extern declaration

Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default

2013-12-02 Thread Alon Levy
what it thinks is a video stream. Turn off video detection by default to avoid these artifacts. Reviewed-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-core.c b/ui/spice

Re: [Spice-devel] [PATCH spice-gtk 3/5] Add SpiceVMC GIOStream

2013-11-18 Thread Alon Levy
On 11/18/2013 01:03 AM, Marc-André Lureau wrote: Hey Fedor On Sun, Nov 17, 2013 at 5:48 PM, Fedor Lyakhov fedor.lyak...@gmail.com wrote: Marc, What does VMC stand for here? Is it related to my idea of virtual media controller, or just a coincidence? It's a coincidence ;) Hans should

Re: [Spice-devel] [PATCH 9/9] chardev: learn to keep running when vm is stopped

2013-11-18 Thread Alon Levy
On 11/18/2013 12:28 PM, Marc-André Lureau wrote: All chardev channels are stopped when calling spice_server_vm_stop(), which prevents them from doing any i/o. However, the Spice block device channel needs to keep running even when the VM is stopped. It is entirely drived by the server, so it

Re: [Spice-devel] [PATCH 4/9] build-sys: bump current, as ABI is going to be broken next

2013-11-18 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 02:21 PM, Christophe Fergeau wrote: On Mon, Nov 18, 2013 at 11:28:28AM +0100, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Spice-devel] [Qemu-devel] [PATCH 05/21] char: add qemu_chr_fe_event()

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com The patch description is incomplete, or the patch should be split - this patch also implements qemu_chr_fe_event for spiceport. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com

Re: [Spice-devel] [PATCH 20/21] spice-core: allow an interface to be in AIO context

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: The Spice block driver must be able complete operations within a AIO context only. Spice is currently only running within the main loop, and doesn't allow the block driver to complete operations, such as flush during migration. This patch

Re: [Spice-devel] [PATCH 4/9] build-sys: bump current, as ABI is going to be broken next

2013-11-18 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 02:48 PM, Christophe Fergeau wrote: On Mon, Nov 18, 2013 at 02:32:45PM +0200, Alon Levy wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 02:21 PM, Christophe Fergeau wrote: On Mon, Nov 18, 2013 at 11:28:28AM +0100

Re: [Spice-devel] [PATCH 4/9] build-sys: bump current, as ABI is going to be broken next

2013-11-18 Thread Alon Levy
I'd rather we avoid breaking ABI 'just' for the NBD channel. What do you think is the correct criteria? My criteria would be to never break it, so not really useful. I'd tend to return the question, if we break the ABI now (which hasn't been done in recent times), where do we stop? Some

Re: [Qemu-devel] [PATCH 05/21] char: add qemu_chr_fe_event()

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com The patch description is incomplete, or the patch should be split - this patch also implements qemu_chr_fe_event for spiceport. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com

Re: [Qemu-devel] [Spice-devel] [PATCH 20/21] spice-core: allow an interface to be in AIO context

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: The Spice block driver must be able complete operations within a AIO context only. Spice is currently only running within the main loop, and doesn't allow the block driver to complete operations, such as flush during migration. This patch

Re: [Qemu-devel] [PATCH] qxl: replace pipe signaling with bottom half

2013-10-30 Thread Alon Levy
it up. Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Alon Levy al...@redhat.com --- hw/display/qxl.c | 33 +++-- hw/display/qxl.h | 3 +-- 2 files changed, 4 insertions(+), 32 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c

[Spice-devel] [PATCH xf86-video-qxl 1/2] spiceqxl_util.[hc]: add copyright license headers

2013-10-27 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/spiceqxl_util.c | 22 ++ src/spiceqxl_util.h | 22 ++ 2 files changed, 44 insertions(+) diff --git a/src/spiceqxl_util.c b/src/spiceqxl_util.c index 49cd5ab..975467d 100644 --- a/src/spiceqxl_util.c +++ b

Re: [Spice-devel] Release timing / strategy?

2013-10-27 Thread Alon Levy
On 10/25/2013 07:01 PM, Jeremy White wrote: I've just now submitted updated spice-html5 packages to bohdi, so hopefully Fedora users will able to run an updated version shortly and stop having the missing minus key :-/. But I don't have a strategy for release timing. The html5 client

[Spice-devel] [PATCH spice-common] spice.proto: fix uninitalized variable in demarshaller

2013-10-22 Thread Alon Levy
Our automatically generated marshallers use temporary variables whose name is based on the field, without checking for shadowing. This bites us in one location that is fixed by this patch. A better solution would be to fix the marshaller, but it's more then I want to bite right now. RHBZ: 1021995

Re: [Spice-devel] [PATCH spice-common] spice.proto: fix uninitalized variable in demarshaller

2013-10-22 Thread Alon Levy
On 10/22/2013 04:47 PM, Alon Levy wrote: Our automatically generated marshallers use temporary variables whose name is based on the field, without checking for shadowing. This bites us in one location that is fixed by this patch. A better solution would be to fix the marshaller, but it's more

[Spice-devel] [PATCH xf86-video-qxl] tests/xspice_util.py: fix hardcoded port

2013-10-21 Thread Alon Levy
--- tests/xspice_util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xspice_util.py b/tests/xspice_util.py index a2e8578..409a0fc 100755 --- a/tests/xspice_util.py +++ b/tests/xspice_util.py @@ -57,7 +57,7 @@ def launch_xspice(port): if not

[Spice-devel] [PATCH 1/5] spiceqxl_spice_server: no need to call spice_server_set_noauth twice

2013-10-21 Thread Alon Levy
--- src/spiceqxl_spice_server.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/spiceqxl_spice_server.c b/src/spiceqxl_spice_server.c index 63a3179..14ee752 100644 --- a/src/spiceqxl_spice_server.c +++ b/src/spiceqxl_spice_server.c @@ -254,9 +254,6 @@ void

[Spice-devel] [PATCH 2/5] xspice: chown both files used by vdagent for suid Xorg case

2013-10-21 Thread Alon Levy
When running a suid Xorg mkfifo and bind produce files owned by root. Change the ownership so that the user launched vdagent vdagentd can write to them. This also makes it easier to cleanup the files from the Xspice process that is not running as root (and is launching both vdagent vdagentd,

[Spice-devel] [PATCH 3/5] Xspice: cleanup non regular files too

2013-10-21 Thread Alon Levy
--- scripts/Xspice | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Xspice b/scripts/Xspice index 34a5fcc..be87c08 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -159,7 +159,7 @@ cleanup_processes = [] def cleanup(*args): for f in cleanup_files: -if

[Spice-devel] [PATCH 5/5] Xspice: cleanup vdagent files

2013-10-21 Thread Alon Levy
--- scripts/Xspice | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Xspice b/scripts/Xspice index 9b82bfe..b1528f9 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -278,6 +278,7 @@ if args.vdagent_enabled: for f in [vdagentd_uds, args.vdagent_virtio_path,

[Spice-devel] [PATCH 4/5] Xspice: fix cleanup when some processes are already dead

2013-10-21 Thread Alon Levy
--- scripts/Xspice | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/Xspice b/scripts/Xspice index be87c08..9b82bfe 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -162,9 +162,15 @@ def cleanup(*args): if os.path.exists(f):

[ANNOUNCE] xf86-video-qxl 0.1.1

2013-10-20 Thread Alon Levy
): 883578 - remote-viewer gets frozen after migration of guest with video playback 968931 - Crash in Xspice after closing tab with spice-html5 894421 - Small change in guests resolution results in wrong resolution Adam Jackson (1): Remove mibstore.h Alon Levy (23

[Spice-devel] [PATCH] qxl_image: fix build break once MIN/MAX switched to spice-protocol

2013-10-20 Thread Alon Levy
In commit 5e122e4ab1ac35186cc610cd0d518cfd5e78d902 --- src/qxl_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qxl_image.c b/src/qxl_image.c index 2349fca..0a0ca30 100644 --- a/src/qxl_image.c +++ b/src/qxl_image.c @@ -31,6 +31,9 @@ #include string.h #include assert.h

[Spice-devel] [PATCH xspice 1/2] Xspice: cleanup Xorg process on SIGTERM

2013-10-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- scripts/Xspice | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/Xspice b/scripts/Xspice index a4eb647..17439a1 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -22,6 +22,7 @@ import sys import tempfile import atexit

[Spice-devel] [PATCH xspice 2/2] xspice: add tests for audio remoting

2013-10-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- tests/xspice_audio_test.py| 19 +++ tests/xspice_audio_test_helper.py | 19 +++ tests/xspice_util.py | 69 +++ 3 files changed, 107 insertions(+) create mode 100755 tests

[Spice-devel] [PATCH] Release 0.1.1

2013-10-20 Thread Alon Levy
--- NEWS | 12 configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 NEWS diff --git a/NEWS b/NEWS new file mode 100644 index 000..4ece9fe --- /dev/null +++ b/NEWS @@ -0,0 +1,12 @@ +Major changes in 0.1.1 +== +

[Spice-devel] [PATCH (pushed) xf86-video-qxl] fix make dist

2013-10-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index edc2f0b..4c4ae40 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -110,6 +110,7 @@ spiceqxl_drv_la_SOURCES

[Spice-devel] [ANNOUNCE] xf86-video-qxl 0.1.1

2013-10-20 Thread Alon Levy
): 883578 - remote-viewer gets frozen after migration of guest with video playback 968931 - Crash in Xspice after closing tab with spice-html5 894421 - Small change in guests resolution results in wrong resolution Adam Jackson (1): Remove mibstore.h Alon Levy (23

[Spice-devel] [PATCH v3 spice-gtk 2/2] channel-cursor: mono cursors edge highlighting

2013-10-19 Thread Alon Levy
Fix 998529, mono (invert) cursors not visible on a black background, by doing simple edge detection on the cursor (this is done once when the cursor is changed and then cached, cursors are 32x32 generally) and thus having a cursor with contrast on both dark and light backgrounds. When (if) GDK

[Spice-devel] [PATCH] channel-cursor: mono cursors edge highlighting

2013-10-18 Thread Alon Levy
Fix 998529, mono (invert) cursors not visible on a black background, by doing simple edge detection on the cursor (this is done once when the cursor is changed and then cached, cursors are 32x32 generally) and thus having a cursor with contrast on both dark and light backgrounds. When (if) GDK

Re: [Spice-devel] [PATCH] channel-cursor: mono cursors edge highlighting

2013-10-18 Thread Alon Levy
On 10/18/2013 02:30 PM, Alon Levy wrote: Please ignore, I'll send a new version. Fix 998529, mono (invert) cursors not visible on a black background, by doing simple edge detection on the cursor (this is done once when the cursor is changed and then cached, cursors are 32x32 generally) and thus

[Spice-devel] [PATCH v2 spice-gtk 1/2] cursor-channel.c: add cursor print function for debugging only (ifdefed)

2013-10-18 Thread Alon Levy
--- gtk/channel-cursor.c | 32 1 file changed, 32 insertions(+) diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c index d1d2c34..66e91df 100644 --- a/gtk/channel-cursor.c +++ b/gtk/channel-cursor.c @@ -246,6 +246,35 @@ static void

[Spice-devel] [PATCH v2 spice-gtk 2/2] channel-cursor: mono cursors edge highlighting

2013-10-18 Thread Alon Levy
Fix 998529, mono (invert) cursors not visible on a black background, by doing simple edge detection on the cursor (this is done once when the cursor is changed and then cached, cursors are 32x32 generally) and thus having a cursor with contrast on both dark and light backgrounds. When (if) GDK

Re: [Spice-devel] [patch 2/3] spice-server: add push_utf8 callback to input channel

2013-10-17 Thread Alon Levy
On 10/16/2013 02:04 PM, diet...@proxmox.com wrote: For next time: can you send the patches inline? it is easier to respond to then to mails with attachments. You should increment SPICE_INTERFACE_KEYBOARD_MINOR as well to allow users (qemu / spiceterm / xspice etc.) to compile to both old and

Re: [Spice-devel] [PATCH spice-gtk] display: blank surface on creation

2013-10-17 Thread Alon Levy
On 10/16/2013 10:08 PM, Marc-André Lureau wrote: In theory, zero-ing the surface shouldn't be necessary, as only invalidated/painted region should be shown. However, this results in less artifacts on resolution changes (probably some regions are painted, but with masks, blend, copy etc), in

[Spice-devel] [PATCH xf86-video-qxl 1/5] qxl_get_formats: use surface enum, not bitmap (fixes clang warning)

2013-10-17 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/qxl.h | 2 +- src/qxl_kms.c | 2 +- src/qxl_surface.c | 5 +++-- src/qxl_surface_ums.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 52e92e9..c699c58 100644 --- a/src

[Spice-devel] [PATCH xf86-video-qxl 2/5] spiceqxl_display: add noreturn attribute (silence clang warning)

2013-10-17 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/spiceqxl_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/spiceqxl_display.c b/src/spiceqxl_display.c index 9c42d84..3acbb1c 100644 --- a/src/spiceqxl_display.c +++ b/src/spiceqxl_display.c @@ -287,7 +287,8

Re: [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-10-17 Thread Alon Levy
On 10/14/2013 05:52 PM, Fabio Fantoni wrote: I have added vdagent support on libxl for hvm domUs using upstream qemu. On windows domUs it is working without problems found in over one year that I'm using it. On linux domUs is not working, it seems to be a problem on the kernel side and/or

Re: [Spice-devel] Announcing spice-vdagent 0.15.0

2013-10-15 Thread Alon Levy
On 10/14/2013 04:15 PM, Alon Levy wrote: Hi All, I'm happy to announce a new release of the spice Linux agent, the first version with Xspice support. Changes in spice-vdagent-0.15.0: * Xspice support * Release clipboard on client disconnect if owned by client

[Spice-devel] [PATCH 1/2] vdagent-virtio-port: no need to log opening the port as a socket

2013-10-14 Thread Alon Levy
--- src/vdagent-virtio-port.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index a5da35f..b04d55b 100644 --- a/src/vdagent-virtio-port.c +++ b/src/vdagent-virtio-port.c @@ -91,7 +91,6 @@ struct vdagent_virtio_port

[Spice-devel] [PATCH 2/2] Prepare for release 0.15.0

2013-10-14 Thread Alon Levy
--- ChangeLog| 7 +++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 99508f9..4138359 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +spice-vdagent-0.15.0 + +* Xspice support +* Release clipboard

Re: [Spice-devel] [xf86-video] Handle a missed case where lack of kms doesn't work with XSpice.

2013-10-01 Thread Alon Levy
On 10/01/2013 10:02 PM, Jeremy White wrote: Ack Signed-off-by: Jeremy White jwh...@codeweavers.com --- src/qxl_driver.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ac5408e..515704b 100644 --- a/src/qxl_driver.c +++

Re: [Spice-devel] [PATCH 4/4] gl: use glCopyPixels()

2013-09-24 Thread Alon Levy
On 09/24/2013 02:47 PM, Marc-André Lureau wrote: I don't see why the fallback method should be the default. glCopyTexImage2D and glCopyPixels are equally broken with current Intel mesa/drivers (I'll be filing a bug). But sw rendering is correct. --- common/glc.c | 2 +- 1 file changed, 1

Re: [Spice-devel] [PATCH 08/11] spicec: add sw canvas diff check

2013-09-24 Thread Alon Levy
On 09/24/2013 02:42 PM, Marc-André Lureau wrote: Looks good, but can you explain why you disable diff check for fill, text? --- client/display_channel.cpp | 88 +- client/display_channel.h | 2 ++ client/red_pixmap.h| 19 ++

Re: [Spice-devel] [PATCH 11/11] spicec: refresh the display after display resize

2013-09-24 Thread Alon Levy
On 09/24/2013 02:42 PM, Marc-André Lureau wrote: This appears to be unrelated to the gl checks, same as the nograb fix (excellent). Can you move both to the start of the patchset? --- client/display_channel.cpp | 4 1 file changed, 4 insertions(+) diff --git

Re: [Spice-devel] [PATCH 00/11] fix spicec gl_fbo

2013-09-24 Thread Alon Levy
On 09/24/2013 02:42 PM, Marc-André Lureau wrote: Hi, Please find a few patches fixing gl_fbo usage and glitches. spice-common needs to be updated too, with the opengl related fixes. (the submodule update will be done before, so ignore updates during review of these patches please) Looks good

[Spice-devel] [PATCH] mono cursor: increase contrast, better looking putty cursor (rhbz 998529)

2013-09-23 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- The previous fix is almost impossible to notice on putty, I'm assuming the original values for the on/off pixels were taken from a different use case, but so far since we do have a bug for putty and no bug for anything else I propose we fix the putty

Re: [Spice-devel] wireshark codegen

2013-09-16 Thread Alon Levy
Opinions on this? The end goal is to be able to generate a header that has both the enums and descriptions of those enum values (e.g. a mapping from enum to string name) that we can use for the wireshark dissector. Obviously, when a new channel or new message gets added to the protocol,

Re: [Spice-devel] [spice-html5] Send the client cache size correctly in little endian order so we don't claim to have an infinitely large cache.

2013-09-15 Thread Alon Levy
Signed-off-by: Jeremy White jwh...@codeweavers.com Looks good to me, Ack. --- spicedataview.js | 12 spicemsg.js |3 +-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/spicedataview.js b/spicedataview.js index ef9555d..43f0170 100644 ---

Re: [Spice-devel] [spice-html5] Give the Garbage collector a clue to recycle images; avoids fairly massive memory leaks during video playback.

2013-09-15 Thread Alon Levy
ACK. Signed-off-by: Jeremy White jwh...@codeweavers.com --- display.js |4 1 file changed, 4 insertions(+) diff --git a/display.js b/display.js index f9bfe76..d0d0994 100644 --- a/display.js +++ b/display.js @@ -778,6 +778,10 @@ function handle_draw_jpeg_onload() {

Re: [winswitch] [Spice-devel] Use spice to show individual X clients like xpra does?

2013-09-10 Thread Alon Levy
On 10/09/13 01:16, Alon Levy wrote: Hi - Original Message - Hi, I've played around a bit with xpra[1]. Xpra (AFAIK) starts an X server with a dummy video driver (or xvfb?) on the remote machine and a client xpra process on the local machine shows remote application

Re: [Spice-devel] [winswitch] Use spice to show individual X clients like xpra does?

2013-09-10 Thread Alon Levy
On 10/09/13 01:16, Alon Levy wrote: Hi - Original Message - Hi, I've played around a bit with xpra[1]. Xpra (AFAIK) starts an X server with a dummy video driver (or xvfb?) on the remote machine and a client xpra process on the local machine shows remote application

Re: [Spice-devel] unsupported partial overlap

2013-09-10 Thread Alon Levy
Hi, it has been reported (https://bugs.launchpad.net/ubuntu/+source/spice/+bug/1212704) that in a multi-monitor setup with partial overlap, spicy runs fine but spicec refused to run. This is explicitly checked for in client/x11/platform.cpp:crtc_overlap_test(). I've looked at the git

Re: [Spice-devel] unsupported partial overlap

2013-09-10 Thread Alon Levy
Quoting Alon Levy (al...@redhat.com): Hi, it has been reported (https://bugs.launchpad.net/ubuntu/+source/spice/+bug/1212704) that in a multi-monitor setup with partial overlap, spicy runs fine but spicec refused to run. This is explicitly checked for in client/x11

Re: [winswitch] [Spice-devel] Use spice to show individual X clients like xpra does?

2013-09-09 Thread Alon Levy
Hi - Original Message - Hi, I've played around a bit with xpra[1]. Xpra (AFAIK) starts an X server with a dummy video driver (or xvfb?) on the remote machine and a client xpra process on the local machine shows remote application windows just like they would run

Re: [Spice-devel] Use spice to show individual X clients like xpra does?

2013-09-09 Thread Alon Levy
Hi - Original Message - Hi, I've played around a bit with xpra[1]. Xpra (AFAIK) starts an X server with a dummy video driver (or xvfb?) on the remote machine and a client xpra process on the local machine shows remote application windows just like they would run

Re: [Spice-devel] [PATCH qxl-win] Revert miniport: halve QXL_IO_UPDATE_IRQ calls

2013-09-09 Thread Alon Levy
This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046. The patch causes the display to get stuck. Till we understand exactly why, I'm reverting it. ACK. --- xddm/miniport/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c index

<    1   2   3   4   5   6   7   8   9   10   >