Re: [Kicad-developers] [PATCH] Add preferences dialog hotkey

2018-10-16 Thread John Beard
Hi, I'd suggest perhaps Ctrl-Shift-P, which is used by Inkscape. P with various modifiers is fairly common shortcut for preferences: https://defkey.com/search?irq=Preferences I feel like Ctrl-, might be useful as paired hotkey with Ctrl-. (eg increase/decrease)? Cheers, John On 16 October

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-16 Thread John Beard
: > > John, > > This patch fails to link on windows. I've attached the build error. > > Wayne > > On 10/9/2018 9:53 AM, John Beard wrote: > > Hi, > > > > Here is an update patch that rebases over the commenting out of > > pcb_test_window, polyg

Re: [Kicad-developers] 5.0.1 release status.

2018-10-15 Thread John Beard
Hi Wayne, There was a commit on master made for this purpose: 9a3cfb857. The function is to remove a failing test and thereby avoid having to exclude it from the CTest harness, which doesn't work on old Boosts. I thought it was in v5, but it is evidently not (and git branch --contains concurs).

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-13 Thread John Beard
> > Cheers, > > Wayne > > On 10/9/2018 10:25 AM, John Beard wrote: > > Hi Wayne, > > > > No problems, I get it! > > > > It's not needed for the fuzzing stuff, it's actually a pre-cursor for > > a patch set to do with the dialog_page_settings di

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-12 Thread John Beard
overhead Cheers, John On Thu, Oct 11, 2018 at 11:43 AM John Beard wrote: > > Hi, > > Here's a quick patch to add some documentation about print-debugging > and trace. It's a follow-up to the fuzz tool, as there would be a > conflict in the MD file, as one section follows the

Re: [Kicad-developers] Net selector

2018-10-11 Thread John Beard
ce (rather than per-item), but it looks like LIST_ITEM_PADDING of 6 > is doing the trick. > > Are you going to commit that, or do you want me to? > > Cheers, > Jeff. > > > On 11 Oct 2018, at 18:33, John Beard wrote: > > Hi Jeff, > > It's better now for

Re: [Kicad-developers] Net selector

2018-10-11 Thread John Beard
etention. > > I also adjusted the spacing on GTK. I’ve changed it from what Windows uses > to what OSX uses. It may need yet a 3rd value, so let me know if it’s still > too short with only a few list items (or too tall with a bunch of list items). > > Cheers, > Jeff. > &

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-11 Thread John Beard
t helpful!). Cheers, John On Tue, Oct 9, 2018 at 2:53 PM John Beard wrote: > > Hi, > > Here is an update patch that rebases over the commenting out of > pcb_test_window, polygon_triangulation and polygon_generator and fixes > a link error to do with base_screen.cpp. > > Cheer

Re: [Kicad-developers] Net selector

2018-10-11 Thread John Beard
Hi Jeff, It doesn't seem to accept spaces for me on GTK (bea75753d). I don't think retaining the last filter is extremely useful, though perhaps if you were going around changing a lot of things to the same net? But that will be a better job for the Object Inspector in future anyway. Cheers,

Re: [Kicad-developers] Net selector

2018-10-10 Thread John Beard
> tell me how it goes. It’s all good on OSX, but that’s the only machine I > have. > > Cheers, > Jeff. > > > > On 10 Oct 2018, at 10:16, John Beard wrote: > > > > Hi, > > > > I do (try to) use most dialogs with the keyboard (limited

Re: [Kicad-developers] Net selector

2018-10-10 Thread John Beard
Hi, I do (try to) use most dialogs with the keyboard (limited sensation in my fingers make mice and especially touchpads less useful to me). Correct handling of focus, tab-traversal and so on is also important for accessibility reasons, as well as being indicative of a coherent UI in general.

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-09 Thread John Beard
at 3:04 PM Wayne Stambaugh wrote: > > Hey John, > > I would like to help you out with this but I'm slammed at work and I'm > not going to be able to help out. Is this a patch a prerequisite for > your fuzzing patch? > > Cheers, > > Wayne > > On 10/8/2018 1:11 PM,

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-09 Thread John Beard
Hi, Here is an update patch that rebases over the commenting out of pcb_test_window, polygon_triangulation and polygon_generator and fixes a link error to do with base_screen.cpp. Cheers, John On Mon, Oct 8, 2018 at 5:27 PM John Beard wrote: > > Sorry, > > I wrote "

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-08 Thread John Beard
.text+0x398): > undefined reference to `wxConfigBase::Read(wxString const&, double*, > double) const' > collect2.exe: error: ld returned 1 exit status > make[2]: *** [qa/common/CMakeFiles/qa_common.dir/build.make:217: > qa/common/qa_common.exe] Error 1 > make[1]: *** [CMakeFi

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-08 Thread John Beard
Sorry, I wrote "ms", I meant "us" - the times are in the handful-of-millsecond range. Cheers, John On Mon, Oct 8, 2018 at 5:24 PM John Beard wrote: > > Hi, > > This is a patch to add a test program that allows to parse a Pcbnew > file from command line para

[Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-08 Thread John Beard
From 642c679fb5c16a4a1fbc76205e745ef8f09cf921 Mon Sep 17 00:00:00 2001 From: John Beard Date: Sat, 6 Oct 2018 15:35:17 +0100 Subject: [PATCH] QA: PCB file input parse test program (fuzzable) This adds a test program which can be used to test the parsing of a given KiCad PCB file. This interface

Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-06 Thread John Beard
hn [1]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html#header_depends From d89cd6a36b9e595378123a4dd0177f7049b11201 Mon Sep 17 00:00:00 2001 From: John Beard Date: Fri, 5 Oct 2018 17:17:54 +0100 Subject: [PATCH] QA: Add TITLE_BLOCK tests Add some unit tests

[Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-05 Thread John Beard
(). ${INC_AFTER} is used for config.h, is that right? Cheers, John From c6433cddefe70ae0250a3fc84b085e168585c8f0 Mon Sep 17 00:00:00 2001 From: John Beard Date: Fri, 5 Oct 2018 17:17:54 +0100 Subject: [PATCH 1/4] QA: Add TITLE_BLOCK tests Add some unit tests on TITLE_BLOCK This commit also

[Kicad-developers] [PATCH] Expand testing documentation

2018-10-04 Thread John Beard
Hi, Simple patch to give some more/updated details on how to use the unit tests. Cheers, John From 67dcd2b9f7d7716a31b21e5e958f664ada1eaadc Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 4 Oct 2018 15:37:24 +0100 Subject: [PATCH 1/3] Update testing documentation --- Documentation

[Kicad-developers] [PATCH] Enable cursor and pan keys in Gerbview

2018-10-04 Thread John Beard
ef48f45b333f383b5f878d1cf103a98c325824a9 Mon Sep 17 00:00:00 2001 From: John Beard Date: Wed, 3 Oct 2018 17:26:33 +0100 Subject: [PATCH] Put cursor and pan control in libcommon/tool, enable in Gerbview Put the cursor and pan control TOOL_ACTIONs in ACTION, and refer to them in that way. The handlers

Re: [Kicad-developers] [PATCH] Hotkey list dialog

2018-10-04 Thread John Beard
ot required for them to be perfectly functional. Cheers, John [1] https://docs.wxwidgets.org/3.1/classwx_sizer_flags.html#a2dc000b863b8580ae3f183c0e11c9944 [2] https://github.com/wxWidgets/wxWidgets/blob/master/include/wx/sizer.h#L107 On Wed, Oct 3, 2018 at 6:53 PM John Beard wrote: > >

Re: [Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread John Beard
der instead of margin to prevent confusion as that is how > it is defined in the wxwidgets documentation. I'm fine either way. > > I will merge your if there are not objections. You can just create > another patch. > > Cheers, > > Wayne > > On 10/3/2018 11:20 AM, John Beard wro

Re: [Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread John Beard
Hi, Here's a screenshot of the list widget this creates. I also forgot to mention that this also allows to remove the "InstallOnPanel" workaround to installing the custom hotkey widget on the wxFB panel's placeholder panel. Cheers, John On Wed, Oct 3, 2018 at 4:20 PM John Beard wro

[Kicad-developers] [PATCH] Hotkey list dialog

2018-10-03 Thread John Beard
buttons via the new BUTTON_ROW_PANEL class. Cheers, John From 2e27dd083faef63b043e7f791014ec7ee089a45b Mon Sep 17 00:00:00 2001 From: John Beard Date: Wed, 3 Oct 2018 11:02:43 +0100 Subject: [PATCH 4/5] Centralise some UI constants, use in hotkey lists There are lot of places where constants are used in th

[Kicad-developers] Nicknames for hotkey configs - should be translated?

2018-10-03 Thread John Beard
Hi, Quick question about the "nicknames" parameter for the hotkey config dialog. At all the call sites for the ShowPreferences() dialog, the parameter aHotkeysNickname is constructed with _(). This parameter is used to provide a default name for the hotkey file on export. Does this string

Re: [Kicad-developers] [PATCH] Add KICAD_TEMPLATE_DIR to Configure Paths... help

2018-10-02 Thread John Beard
; > Cheers, > > Wayne > > On 10/02/2018 04:45 PM, John Beard wrote: > > Hi Wayne, > > > > Sorry about that, I actually started with the intention of providing > > tooltips for the wxGrids in the library manager and the paths > > configuration dialog. However, I

Re: [Kicad-developers] [PATCH] Add KICAD_TEMPLATE_DIR to Configure Paths... help

2018-10-02 Thread John Beard
for defined env variable but you did >not >hook up the tooltip logic in the dialog. Are you planning to do that >at >some point in the future? > >I'm going to merge this patch if there are no objections. > >Cheers, > >Wayne > >On 10/1/2018 5:35 AM, John Beard w

[Kicad-developers] [PATCH] Add KICAD_TEMPLATE_DIR to Configure Paths... help

2018-10-01 Thread John Beard
in a block of HTML and also we could use it to provide tool-tips or similar to other dialogs. Cheers, John From 7ff43f092fb36b788f570ac8614978d16d424eec Mon Sep 17 00:00:00 2001 From: John Beard Date: Fri, 28 Sep 2018 22:08:31 +0100 Subject: [PATCH] Centralise utilities for env variables. This puts

[Kicad-developers] [PATCH] Fix leaks in DL_Dxf::test

2018-09-28 Thread John Beard
2e4bdc2e93cc577b6d37592e077b897f71ba6d6f Mon Sep 17 00:00:00 2001 From: John Beard Date: Fri, 28 Sep 2018 18:21:20 +0100 Subject: [PATCH] Dxf: Fix leaks in DL_Dxf::test This function is never actually used, but the resource leaks set off static analysers. Fixes: coverity:131460-131465 --- dxflib_qcad/dl_dxf.cpp | 7

[Kicad-developers] [PATCH] Fix resource leak in chamfer test

2018-09-28 Thread John Beard
John From 53e1c92fbdf204d7070258cf27b30e156ddc37e5 Mon Sep 17 00:00:00 2001 From: John Beard Date: Fri, 28 Sep 2018 17:59:42 +0100 Subject: [PATCH] QA: Fix ownership of new CPolyline in qa_shape_poly_set_refactor CPolyLine::Chamfer returns a newly allocated object. The current test of this do

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
Thanks for the clarification. Wishlist bugs are always tagged for the > next release version so there is no need to make any hotkey list dialog > changes for 5.0.1. > > On 09/28/2018 10:42 AM, John Beard wrote: > > Hi Wayne, > > > > I was only planning to make changes to the list dialog

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
gged as soon as possible and merge the eeschema-gal stuff so > we can get some wider testing on that. Having all hands on deck to fix > any issue we find in the eeschema-gal code will be more beneficial. > > Cheers, > > Wayne > > On 09/28/2018 10:23 AM, John Beard wrote:

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
e the time please let me know because this needs to be > fixed for the 5.0.1 release. > > Cheers, > > Wayne > > On 09/28/2018 07:53 AM, John Beard wrote: > > Hi, > > > > Here is a patch set for adding a filter control to the hotkey editor > > dialog.

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
; > Wayne > > On 09/28/2018 07:53 AM, John Beard wrote: > > Hi, > > > > Here is a patch set for adding a filter control to the hotkey editor > > dialog. Preview video: https://sendvid.com/je0cyg87 > > > > Most of the work in the first commit is separating

[Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
altogether and bind the "show hotkey list" command to simply opening the prefs dialog to the hotkey panel Cheers, John From 6f219fc68c17d0648c0f32fd468174b34210a078 Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 27 Sep 2018 15:48:52 +0100 Subject: [PATCH 2/6] Add some hotkey store tests

[Kicad-developers] [PATCH] Make generic 'common' test and add UTF8 tests

2018-09-25 Thread John Beard
now if that way is preferred. Cheers, John From 1f9a290604bf0dd8f2ee5d47d58ed34504dc36de Mon Sep 17 00:00:00 2001 From: John Beard Date: Tue, 25 Sep 2018 12:11:10 +0100 Subject: [PATCH 1/2] QA: Make a generic common test suite * Renames /qa/common to /qa/qa_utils, as it is not to do with /common * Rena

Re: [Kicad-developers] GAL canvas strategy - testers needed!

2018-09-18 Thread John Beard
Hi, The rendering of unclosed polyline in symbols is different in GAL. See the attached (standard libs potentiometer symbol) - in the legacy canvas, the arrow doesn't have a missing lower side. Is this a bug in GAL, or is it actually intended and the symbol is wrong (but happened to work before

Re: [Kicad-developers] GAL canvas strategy - testers needed!

2018-09-18 Thread John Beard
.net/ListHelp > >> > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help

Re: [Kicad-developers] GAL canvas strategy - testers needed!

2018-09-14 Thread John Beard
Hi, Quick bug report on fb748be43 (eeschema GAL HEAD) on Linux: Undoing a global label doesn't refresh. 1) Make a global label 2) Undo it 3) Nothing happens 4) Refresh (F3): Label disappears Otherwise, looking quite slick. Cheers, John On Fri, Sep 14, 2018 at 10:30 AM Jeff Young wrote: > > I

[Kicad-developers] [PATCH] Remove obsolete fillet refactor tests

2018-08-05 Thread John Beard
works from Boost 1.59, and Ubuntu 16 evidently uses 1.58. Cheers, John From 5378f576008abd7cbe5ddb46616488a5b8df66be Mon Sep 17 00:00:00 2001 From: John Beard Date: Sun, 5 Aug 2018 19:16:55 +0100 Subject: [PATCH] QA: Remove obsolete fillet refactor tests These tests are fundamentally broken

[Kicad-developers] [PATCH] Update doxygen logo

2018-08-05 Thread John Beard
e761d36462181a706dca187920e36cea58101d39 Mon Sep 17 00:00:00 2001 From: John Beard Date: Sun, 5 Aug 2018 13:10:30 +0100 Subject: [PATCH] Docs: update doxygen docs logo The logo used was subtly different to the official KiCad logo - different font weight and corner rounds. --- Documentation

Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-08-04 Thread John Beard
, 2018 at 6:23 PM, Seth Hillbrand wrote: > Hi John- > > I get a segfault when trying to use the hotkey to insert a point on a zone > when it is not selected. > > -Seth > > > Am Di., 24. Juli 2018 um 10:00 Uhr schrieb John Beard > : >> >> This patch a

Re: [Kicad-developers] "Make Gerbers and drills zip"

2018-07-31 Thread John Beard
I was working on a program to do this (over the Python API) because I wanted to be able to drive deliverable generation from a makefile. Code is here: https://github.com/johnbeard/kiplot An example plot config (generates nearly all the possible outputs all at once) is here:

Re: [Kicad-developers] wxFormBuilder documentation

2018-07-31 Thread John Beard
On Tue, Jul 31, 2018 at 4:51 PM, Seth Hillbrand wrote: > wxFormBuilder isn't perfect but it solves many of > the tedious issues. I find wxFB to be much more tedious than code. If dialog code *is* unbearably tedious, IMO that means there is not enough abstraction, and too much repetitive UI is

[Kicad-developers] wxFormBuilder documentation

2018-07-31 Thread John Beard
Hi, According to the Kicad UI Guidelines [1]: "KiCad's dialogs must be designed with wxFormBuilder. As wxFormBuilder available in packages is likely to be a different version than what other developers have installed, it has been decided to use the version kept in a Github repository, branch

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread John Beard
Flag icons are also (ab)used in the About dialog for the translator credits. According to `git grep "lang_.*_xpm`, that's the only other use. As expected, I don't see them in the menu on Arch Linux, but I do have other menu icons. Cheers, John On Tue, Jul 31, 2018 at 12:24 PM, jp charras

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-30 Thread John Beard
Hi, Here are 6a and 6b options, including the DeMorgan icons. Cheers, John On Thu, Jul 26, 2018 at 5:40 PM, Jeff Young wrote: > I actually agree that 6a looks better on it’s own, but 6b matches the > DeMorgan icons better. > > (Of course we could always update those to match the opamp….) > >

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-30 Thread John Beard
While we're at it, new_cvpcb looks like it's also unused: it's built and listed in bitmaps.h, but nothing ever uses it. Cheers, John On Sat, Jul 28, 2018 at 11:28 PM, Jeff Young wrote: > No, looks like I just missed deleting it. > >> On 28 Jul 2018, at 23:01, John Beard wrote: &

Re: [Kicad-developers] MacOS build issue with new geometry tests

2018-07-29 Thread John Beard
___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp From 28d23f2c73a7f824ddb

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-28 Thread John Beard
t blurryness. I don’t know if they’re worth fixing or not, but if > you’re so inclined…. > > Cheers, > Jeff. > > > On 25 Jul 2018, at 15:05, John Beard wrote: > > Hi, > > The pixel alignment of the op-amp icons looks a bit fuzzy compared to > the other newer icons

Re: [Kicad-developers] Board setup icon

2018-07-26 Thread John Beard
image that's hard to interpret easily. > > On Tue, Jul 24, 2018 at 4:35 AM, John Beard wrote: >> >> Hi, >> >> Here is a new icon for the board setup toolbar and menu item. The >> generic gear icon is no clear, as it looks like "Preferences" rather >&g

[Kicad-developers] [PATCH] -Wcatch-value in kicad2step.cpp

2018-07-26 Thread John Beard
Hi, Another -Wcatch-value warning, this time in kicad2step.cpp. Cheers, John From 7f1b0be567101647a31f1b4cc69c0d05cf441d40 Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 26 Jul 2018 13:37:44 +0100 Subject: [PATCH] Fix -Wcatch-value in kicad2step.cpp --- utils/kicad2step/kicad2step.cpp

[Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-26 Thread John Beard
CPPs persist. Cheers, John From 2a6103b313ae567377dc20f9ea9fa6bbf004535c Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 26 Jul 2018 15:43:31 +0100 Subject: [PATCH] Update CA and ZH source svg filename These were updated in 7841f8a466, but the source files seem to have not been changed

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-26 Thread John Beard
but if you’re so inclined…. >> >> Cheers, >> Jeff. >> >> >> On 25 Jul 2018, at 15:05, John Beard wrote: >> >> Hi, >> >> The pixel alignment of the op-amp icons looks a bit fuzzy compared to >> the other newer icons. These are not the

[Kicad-developers] [PATCH] Icon for "Update PCB from Schematic"

2018-07-25 Thread John Beard
way. I personally don't really care what the icon is, as long as it's clearly distinguished in context from any other action. As usual, PNG is for reference. Cheers, John From fa555f19ef8a115cca2365ea88da010f1202c541 Mon Sep 17 00:00:00 2001 From: John Beard Date: Wed, 25 Jul 2018 23:44:57 +0100 Su

[Kicad-developers] [RFC] Op-amp symbol icons

2018-07-25 Thread John Beard
Hi, The pixel alignment of the op-amp icons looks a bit fuzzy compared to the other newer icons. These are not the only misaligned icons, but they are a very prominent set of them. The problem is that both: 1) The lines are not on the pixel grid 2) The lines are not a whole number of pixels

Re: [Kicad-developers] Hotkeys in GAL

2018-07-25 Thread John Beard
On Wed, Jul 25, 2018 at 8:45 AM, Maciej Sumiński wrote: > > I would not mind adding more hotkeys, I think the primary reason is that > not every action is executed often enough to justify a hotkey. Even with > the current configuration it might be challenging to find a free hotkey > for an

Re: [Kicad-developers] Board setup icon

2018-07-25 Thread John Beard
t use of the GUI. > > Also, I will not enter into tiny image pixel alignment problem because > we did it so many time in the last 5 years here but instead I would > love to propose to begin talking about the use of vector format icons > and possible the use of script to combine icons

Re: [Kicad-developers] Board setup icon

2018-07-25 Thread John Beard
> generic ’T’.) > > Thanks, > Jeff. > > >> On 24 Jul 2018, at 16:56, Jeff Young wrote: >> >> I’ve merged your icon, John. Thanks for your contribution! >> >>> On 24 Jul 2018, at 12:35, John Beard wrote: >>> >>> Hi, >>>

[Kicad-developers] Hotkeys in GAL

2018-07-24 Thread John Beard
Hi, I have a few questions about hotkeys in GAL tools: 1) Is there are reason so many GAL tools don't get hotkeys? Very many TOOL_ACTIONS have a hotkey set to '0'. Most others that do have a hotkey have a LegacyHotkey definition. Only a very few have the GAL-style keys (e.g. rotate CW). I

[Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-07-24 Thread John Beard
). It doesn't work on polygons, as that is still unimplemented in the underlying action. Cheers, John From 9a4da96b7df9941e6dcbb61201adfeaed70bea95 Mon Sep 17 00:00:00 2001 From: John Beard Date: Tue, 24 Jul 2018 16:15:05 +0100 Subject: [PATCH 1/2] Add hotkey (Insert) for zone create corner Adds

[Kicad-developers] Board setup icon

2018-07-24 Thread John Beard
Hi, Here is a new icon for the board setup toolbar and menu item. The generic gear icon is no clear, as it looks like "Preferences" rather than board setup. PNG included for reference only. Cheers, John From 329eda7c68c0ca56f1d8095342000fdc72868955 Mon Sep 17 00:00:00 2001 From:

Re: [Kicad-developers] [PATCH] qa_geometry tests

2018-07-24 Thread John Beard
I think the first three of these patches are still worth committing now. That will allow "make test" to be used to collect all our (working) tests and give us somewhere to hang new tests so that they can used. We can discuss whether or not we want "make test" to also rebuild the tests separately,

[Kicad-developers] [PATCH] Another -Wcatch-value fix

2018-07-23 Thread John Beard
Hi, Another small fix for a -Wcatch-value warning that I noticed during a clean build. Cheers, John From eebe86ea52c028b42389db6139b3b2b4f9bd Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 19 Jul 2018 17:15:36 +0100 Subject: [PATCH] Fix -Wcatch-value in sexpr.cpp This is fixed

Re: [Kicad-developers] eeschema GAL renderer (with old tools)

2018-07-23 Thread John Beard
, Tomasz Wlostowski wrote: > On 23/07/18 12:48, John Beard wrote: >> Hi Tom, >> >> It's now building on 621206fdd, thanks! >> >> I get the following asserts. Let me know if you rather I reported this >> kind of thing in separate emails/threads/on another pl

Re: [Kicad-developers] eeschema GAL renderer (with old tools)

2018-07-23 Thread John Beard
run [31] gtk_main [32] wxGUIEventLoop::DoRun() [33] wxEventLoopBase::Run() [34] wxAppConsoleBase::MainLoop() [35] wxEntry(int&, wchar_t**) [36] __libc_start_main [37] _start Cheers, John On Mon, Jul 23, 2018 at 11:01 AM, John Beard wrote: > Hi Tom, > > I tried to build this (commit 4e

Re: [Kicad-developers] eeschema GAL renderer (with old tools)

2018-07-23 Thread John Beard
Hi Tom, I tried to build this (commit 4eb9a3c51), and CMake failed with a missing file (eeschema/libedit/controller.cpp). Removing that from the CMakeLists.txt resulted in (predictably enough) a link failure:

Re: [Kicad-developers] Branches

2018-07-19 Thread John Beard
On Thu, Jul 19, 2018 at 1:47 PM, Wayne Stambaugh wrote: > Unless we are going to prohibit new features (new file formats, new tool > framework for eeschema, etc.) from being merged into the dev branch > until 5.1 is released, I disagree. If we want to only work on 5.1 in > the dev branch, then

Re: [Kicad-developers] Branches

2018-07-19 Thread John Beard
I agree with Orson. It's unfortunate for people to not be able to dump new features onto master after such a long freeze. However, if 5.1 and master/6-dev diverge, there will be a lot of pain in porting bugs, especially if one branch has work that very is invasive and touches a lot of code, and

[Kicad-developers] Launchpad tags

2018-07-11 Thread John Beard
Hi, I think it would be helpful to have a couple more official tags on launchpad: * testing - anything related to issues with the test programs * legacy - anything related the old canvases (which might be only of limited importance to fix going forward towards a GAL-only future) Cheers, John

Re: [Kicad-developers] [PATCH] qa_geometry tests

2018-07-10 Thread John Beard
as fixing qa tests, I don't think that will impact the v5 release > but pushing it off to 5.0.1 or 5.1 probably makes more sense at this > point. I do agree that there should be an easier way to run tests. > > Cheers, > > Wayne > > On 7/9/2018 5:35 AM, John Beard wrote: >

Re: [Kicad-developers] [PATCH] qa_geometry tests

2018-07-09 Thread John Beard
Note to Wayne: Nothing here concerns v5 release, I was just trying to get a geom test working for future. On Mon, Jul 9, 2018 at 9:12 AM, John Beard wrote: > Hi, > > Let's come back to the make test behaviour after v5, I think we'll > need to discuss that separately. However, I thi

Re: [Kicad-developers] [PATCH] qa_geometry tests

2018-07-09 Thread John Beard
ad17427e8e3c12da7f10df699 Minclude > :04 04 af9f333c0f56dca3a90fb7b04f385dbf39425e8d > 99b5f9757c78216a08220b7eb056f343658b961d Mpcbnew > > > Den tor. 5. jul. 2018 kl. 12.13 skrev John Beard : >> >> Hi, >> >> Are the qa_geometry test supposed to all work? >> >

[Kicad-developers] [PATCH] qa_geometry tests

2018-07-05 Thread John Beard
erFillet/Fillet" tests as they are failing, but if those tests can be fixed, it would be good to run them too. Cheers, John From a6b98ecfd06529d7722a2834083d67a011741e63 Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 5 Jul 2018 11:11:57 +0100 Subject: [PATCH] Enable CTest tests and add q

[Kicad-developers] [PATCH/QUESTION] Fix -Wshadow warnings in sch_sheet_path.cpp

2018-06-28 Thread John Beard
ich might have a bearing on reproducibility. Cheers, John From 0a716288c7877f239c907ea360632a6778914b49 Mon Sep 17 00:00:00 2001 From: John Beard Date: Thu, 28 Jun 2018 14:36:14 +0100 Subject: [PATCH] Fix -Wshadow warning in sch_sheet_path.cpp MIME-Version: 1.0 Content-Type: text/plain; charse

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-25 Thread John Beard
Hi, I think with this kind of thing, KiCad should be strict with what it will accept. Otherwise you might find people rely on broken or undefined behaviour and de facto defaults and it all goes wrong when it's fixed or changed on KiCad's end in future. That's how you get "quirks modes".

[Kicad-developers] [PATCH] Fix pad arrays for SDIP and micromatch plugins

2018-06-25 Thread John Beard
Hi, This fixes some broken PadArray __init__ functions in the SDIP and MicroMatch plugins. Cheers, John From e7ee6a943d5c7be36500bb66e994cecd46978030 Mon Sep 17 00:00:00 2001 From: John Beard Date: Wed, 13 Jun 2018 19:16:01 +0100 Subject: [PATCH] Pcbnew python plugins: fix some pad arrays

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-25 Thread John Beard
> > On 6/18/2018 6:06 AM, Nick Østergaard wrote: > > Mmm, I think I would prefer the Ki logo > > > > man. 18. jun. 2018 10.11 skrev John Beard > <mailto:john.j.be...@gmail.com>>: > > > > In that case, here is the patch with the 48px app logo in

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-18 Thread John Beard
ook better than > the redundant KiCad. > > On 06/17/2018 08:53 AM, John Beard wrote: > > Sadly I don't think there is a way to set the logo alt text in doxygen > > (so it would still read "KiCad" when the image is not displayed, for > > screen readers, when copy

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-17 Thread John Beard
e the word KiCad from the title, as it essentially >> reads "[KiCad] KiCad Pcbnew Python Scripting" >> >> >> 2018-06-13 21:12 GMT+02:00 John Beard > john.j.be...@gmail.com>>: >> >> Sorry, I had a line commented in a local commit to a

Re: [Kicad-developers] [PATCH] Add logo to documentation

2018-06-13 Thread John Beard
gt; > It appears to be choking on the pcbnew/CMakeFile.txt. Is it possible > that you have other changes to this file that are not in the master branch? > > Cheers, > > Wayne > > On 6/13/2018 1:50 PM, John Beard wrote: > > Hi, > > > > This patch adds a small KiC

[Kicad-developers] [PATCH] Add logo to documentation

2018-06-13 Thread John Beard
3579685855ce1f022ce50fbed5294b67d730510f Mon Sep 17 00:00:00 2001 From: John Beard Date: Wed, 13 Jun 2018 12:51:49 +0100 Subject: [PATCH] Documentation: add logo to Doxygen pages This adds a small KiCad logo in the top left of the Doxygen pages. For the main docs and the dev docs, this is easily done in the Doxyfile

Re: [Kicad-developers] Stable release update.

2018-06-12 Thread John Beard
Hi Wayne, Great news! I have one suggestion for a currently-un-milestoned bug that I'd (partly selfishly) really like to see fixed for v5: https://bugs.launchpad.net/kicad/+bug/1518694 This is the one where you can't shift posture when routing to a pad in the PNS router. It's certainly not a

Re: [Kicad-developers] [PATCH] Python FP wizard helper: docstrings and rounded/chamfered rects

2018-06-12 Thread John Beard
now the state of > that work. > > I would like to see a supported API, but I guess this could be blocked > slightly because of the wxpython phoenix story. > > > > 2018-06-12 15:34 GMT+02:00 John Beard : > >> Hi Nick and Wayne, >> >> The patches as they are don't

Re: [Kicad-developers] [PATCH] Python FP wizard helper: docstrings and rounded/chamfered rects

2018-06-12 Thread John Beard
>> as is and you can make the doxygen changes in a later patch or I can >> wait for you to create a new patch with all of the changes. I'm fine >> either way. >> >> Cheers, >> >> Wayne >> >> On 6/4/2018 7:33 AM, John Beard wrote: >>

[Kicad-developers] [PATCH] Fix -Wparentheses warning in track_cleaner.cpp

2018-06-12 Thread John Beard
Hi, This is a very simple patch to address a -Wparentheses warning in pcbnew/track_cleaner.cpp. It was "wxBusyCursor( dummy );", it is now "wxBusyCursor dummy;" Cheers, John From 60b4e54c733934f42f1911c8c8a08d7c2ecf011a Mon Sep 17 00:00:00 2001 From: John Beard Date: Tue,

Re: [Kicad-developers] [PATCH] Fix 'catching polymorphic type by value' warnings

2018-06-05 Thread John Beard
Hi, Sorry, I missed one out in kicad/import_project.cpp Cheers, John On Tue, Jun 5, 2018 at 8:43 AM, John Beard wrote: > Hi, > > Small patch to fix some warnings (GCC 8.1.0) like this: > > warning: catching polymorphic type ‘class std::out_of_range’ by value &

[Kicad-developers] [PATCH] Fix 'catching polymorphic type by value' warnings

2018-06-05 Thread John Beard
range& )" C.f. recent commit ff1802d7a "Fix Coverity "Big parameter passed by value" warnings". As one of these fixes is in view.h, the warning came up a fair bit. Cheers, John From 24c862577174450ba2a591797e2f6dd6b188e87c Mon Sep 17 00:00:00 2001 From: John Beard Da

[Kicad-developers] [PATCH] Python FP wizard helper: docstrings and rounded/chamfered rects

2018-06-04 Thread John Beard
here that will break existing plugins, the only API changes are additions. Cheers, John From 6073d002d607d0ba2ba9dac778997db0f93c6cb4 Mon Sep 17 00:00:00 2001 From: John Beard Date: Fri, 1 Jun 2018 12:19:31 +0100 Subject: [PATCH 1/3] Pcbnew FP wizard: minor style fixes This contains only a few

Re: [Kicad-developers] v5 timeline

2017-04-03 Thread John Beard
check the launchpad permissions. Please remove it when you get a >> chance. I do not want users thinking this is an official rc1 candidate. >> It is not. The symbol library table, stitching via, and revised >> connection algorithm are all part of v5 rc1. >> >&g

Re: [Kicad-developers] v5 timeline

2017-03-31 Thread John Beard
Hi, I "accidentally" made a Launchpad series for v5: https://launchpad.net/kicad/5.0 I wasn't really expecting to have permissions to do that, but it went though, so here it is! I doubled down on it and so there's also a milestone for RC1. Project management people are of course welcome to

Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread John Beard
both patches. I guess it has not been > noticed, as most people do not really pay attention to rotation > direction, it is only up to 3 hotkey presses to get any of the 90* > multiples. > > Anyway, it is surely better to perform what is written on the label. > > Cheers, > Orson

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-30 Thread John Beard
Ctrl is already used for angle snap. I think there should be a generic way to turn grid snap on and off in all GAL modes. Then it stays on or off until you toggle it again. This is a little bit tricky to do as a global action due to how the GAL tool manager keeps VIEW_CONTROL state for each

Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread John Beard
t;c...@embeon.de> wrote: > Hello, Jon! > > On 2017-03-30 11:07, John Beard wrote: >> Hi, >> When CW/CCW rotation was added in GAL (7045ed92f), the tool actions >> didn't correct for the internal represention of angles, so CW/CCW were >> reversed. This patch fix

[Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread John Beard
ault? Cheers, John From 2a04337fd517d00c311b1cca4fd28cede1365330 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Thu, 30 Mar 2017 16:48:00 +0800 Subject: [PATCH] Pcbnew: correct CW/CCW rotation. These were backwards since internal angles are CCW due to the inverted

Re: [Kicad-developers] Flip around X or Y axis?

2017-03-30 Thread John Beard
porters > (VRML, IDF, etc). > > On Thu, Mar 30, 2017 at 6:12 PM, John Beard <john.j.be...@gmail.com> wrote: >> Hi, >> >> There's a small inconsistency with the way flipping works. If you flip >> text, it is flipped about the Y axis, so it remains upright, but

[Kicad-developers] [PATCH] GAL coverity fixes: uninitialised members

2017-03-30 Thread John Beard
: John Beard <john.j.be...@gmail.com> Date: Thu, 30 Mar 2017 15:52:40 +0800 Subject: [PATCH] Init GAL class members (Coverity fixes) Fixes: CID 157139 (GAL) CID 157138 (CAIRO_GAL) --- common/gal/cairo/cairo_gal.cpp| 19 --- common/gal/graphics_abstraction_lay

Re: [Kicad-developers] [PATCH] Ruler tool asserts when mirrored text is visible

2017-03-30 Thread John Beard
tes. I am open to discuss other ideas. > > Cheers, > Orson > > On 03/29/2017 01:40 PM, John Beard wrote: >> Sorry, that patch doesn't have the right comment. Please use this one. >> >> Thanks, >> >> John >> >> On Wed, Mar 29, 2017 at 7:37 PM, Joh

[Kicad-developers] Flip around X or Y axis?

2017-03-30 Thread John Beard
Hi, There's a small inconsistency with the way flipping works. If you flip text, it is flipped about the Y axis, so it remains upright, but reads from right-to-left. If you flip anything else, it is flipped about the X axis, so left and right are unchanged, but it is upside down. Flipping the

Re: [Kicad-developers] [PATCH] Ruler tool asserts when mirrored text is visible

2017-03-29 Thread John Beard
Sorry, that patch doesn't have the right comment. Please use this one. Thanks, John On Wed, Mar 29, 2017 at 7:37 PM, John Beard <john.j.be...@gmail.com> wrote: > Hi, > > This resolves https://bugs.launchpad.net/kicad/+bug/1677210. > > This is caused because the GAL ruler

<    1   2   3   4   5   >