Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205045839
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205045449
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205044870
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,79 +12,122 @@
package org.apache.storm.metric
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2775
+1
---
Merge branch 'resource-leak' of https://github.com/zd-project/storm into
STORM-3159-merge
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/7a0fa47f
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/7a0fa47f
Diff:
Repository: storm
Updated Branches:
refs/heads/master a7e817bcd -> 7a0fa47f7
STORM-3159: Fixed a potential file resource leak.
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/ab0b1a80
Tree:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2770
The change looks fine to me, but I'm not sure why we want to change it. If
you want it to go in, please raise an issue for it and put the issue number in
the commit message.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2743
@zd-project In your last commit, you removed the `AtomicReference` wrapper
for the `Timer.Context`. Is it because you expect the `Timer.Context` to only
be used by one thread?
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r204882262
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204862238
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204860271
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204876125
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -312,7 +315,7 @@ public void launchDaemon
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204867270
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -88,19 +110,24 @@ public static void startMetricsReporters(Map
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204861682
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204875066
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,79 +12,122 @@
package org.apache.storm.metric
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204862534
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204858543
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2763
Yes, I'll take a look.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2769
+1. Please raise an issue for this, and squash to one commit that contains
the issue number.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2763
+1, thanks for your patience. Please squash to one commit, and I'll merge.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2743
As I see it there are still some issues that were commented on but are not
resolved.
* The TODOs should be removed/fixed
* Comment here about adding a comment
https://github.com/apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203772574
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203769516
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203762570
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203761959
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203723843
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203720155
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203717231
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203723640
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203716797
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203724683
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2761#discussion_r203693962
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/ClusterSummary.java ---
@@ -63,8 +60,6 @@ public static _Fields findByThriftId(int fieldId
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2768
STORM-3156: Remove the transactional topology API
https://issues.apache.org/jira/browse/STORM-3156
I'm not very familiar with the transactional topology API, so please let me
know if I missed
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2767
Going to trigger another build, the previous one failed on the Java 10 runs
due to a transient issue with Travis.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2767
@danny0405 If you ignore the first commit and only look at changes from
https://github.com/apache/storm/pull/2767/commits/29d98ccd1c775c58448dac2ed0010718113bfab8
it should be easier to manage. It's
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2767
STORM-2953: Remove storm-kafka
Contains https://github.com/apache/storm/pull/2766, so please ignore the
first commit.
https://issues.apache.org/jira/browse/STORM-2953
You can merge this pull
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2766
I tried out storm-sql-kafka with a small example similar to the orders
example at https://storm.apache.org/releases/2.0.0-SNAPSHOT/storm-sql.html. I
adjusted the docs for the storm-sql-example page
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2766
STORM-2972: Replace storm-kafka with storm-kafka-client in storm-sql-â¦
â¦kafka
https://issues.apache.org/jira/browse/STORM-2972
The new kafka scheme syntax is stolen from [Apache
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
I think all my comments were addressed, thanks for your patience. LGTM, +1.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
Looks great.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
[storm-sql-internal-example.xml(1).txt](https://github.com
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202683106
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
The second diagram on the page also mentions Trident. I don't
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202682665
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
Thanks, looks great. I think the dotted line box is missing
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
Sounds good.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202653817
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
It would probably be pretty quick to duplicate with e.g.
https
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
The test failures look unrelated, not sure why it's suddenly failing. If
they don't go away by rebasing to master, we might want to raise issues to
track them.
I don't know if you're looking
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
I don't think we need to change it. I just wanted to make a note of it.
When this has been merged, we might want to add a couple of notes about
debugging to the docs, we can mention the log line there.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202650814
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202650588
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -47,54 +45,60
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202650461
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge and push
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
Tried out this branch with a storm-sql-kafka example, it seems to work
fine.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202345310
--- Diff: sql/README.md ---
@@ -1,187 +1,8 @@
# Storm SQL
-Compile SQL queries to Storm topologies.
+Compile SQL queries to Storm topologies
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202356815
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -47,54 +45,60
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202355372
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +75,12 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202341073
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
I'm wondering if it would be worth updating this rather than
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202347946
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -118,16 +138,32 @@ public RelDataType getRowType
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202359820
--- Diff:
sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -41,7 +26,46 @@
import java.util.Map;
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202358383
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202349103
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge and push
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202350280
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/rel/StreamsStreamInsertRel.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202344785
--- Diff: docs/storm-sql.md ---
@@ -6,14 +6,14 @@ documentation: true
The Storm SQL integration allows users to run SQL queries over streaming
data
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202357967
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202346634
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202344217
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,24 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202344011
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202343846
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202300189
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202299829
--- Diff:
storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2761#discussion_r202126575
--- Diff: storm-client/src/storm.thrift ---
@@ -206,10 +206,8 @@ struct NimbusSummary {
struct ClusterSummary {
1: required list supervisors
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2761
Should I just comment out beginFileDownload in the thrift file, or does it
need to stay in Nimbus and LocalCluster commented out as well?
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2761#discussion_r202086557
--- Diff: storm-client/src/storm.thrift ---
@@ -206,10 +206,8 @@ struct NimbusSummary {
struct ClusterSummary {
1: required list supervisors
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r202028846
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/ClusterSummary.java ---
@@ -29,24 +29,21 @@
private static final
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2761
STORM-2947: Remove deprecated field and method from Thrift
Part of https://issues.apache.org/jira/browse/STORM-2947
You can merge this pull request into a Git repository by running:
$ git pull
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r202000446
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/ClusterSummary.java ---
@@ -29,24 +29,21 @@
private static final
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r202000182
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -85,11 +84,6 @@ public static StormCommon setInstance(StormCommon
common
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r201999379
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -85,11 +84,6 @@ public static StormCommon setInstance(StormCommon
common
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r201999052
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -781,7 +781,7 @@ private static SerializationDelegate
getSerializationDelegate(Map
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
Fixed.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
Yes, the thread is still interrupted after the exception is thrown. I'll
change it to use `interrupted` instead.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r201455774
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -781,7 +781,7 @@ private static SerializationDelegate
getSerializationDelegate(Map
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2759
Will squash commits before merge, didn't want to mix them up in case this
should be split into smaller PRs.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2759
STORM-2947: Remove some deprecated methods from Storm 2.0.0.
This handles some of the deprecated things mentioned in STORM-2947.
There'll probably be followups to this PR to remove more functionality
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2590
@HeartSaVioR Rebased.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2758
STORM-3046: Ensure KafkaTridentSpoutEmitter handles empty batches corâ¦
â¦rectly when they occur at the beginning of the stream
1.x version of https://github.com/apache/storm/pull/2652
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2757
STORM-3013: Keep KafkaConsumer open when storm-kafka-client spout is â¦
â¦deactivated, in order to keep metrics working
1.x version of https://github.com/apache/storm/pull/2648
You can
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
@aniketalhat Thanks for the fix. I cherry picked the changes to master, 1.x
and 1.1.x. Could you please close this PR, as the changes have been merged?
---
Merge branch 'STORM-3082-1.x-merge' into asfgit-1.x-branch
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/4e1e6266
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/4e1e6266
Diff:
Repository: storm
Updated Branches:
refs/heads/1.1.x-branch 824bd4816 -> 487b81d07
STORM-3082: Added support to handle absent topics
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/487b81d0
Tree:
Repository: storm
Updated Branches:
refs/heads/1.x-branch 27498b32c -> 4e1e62667
STORM-3082: Added support to handle absent topics
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e463cf02
Tree:
Repository: storm
Updated Branches:
refs/heads/master da9cb5490 -> 2e3f76735
STORM-3082: Added support to handle absent topics
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b82ffcff
Tree:
STORM-3082: Port to master
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/f6208b84
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/f6208b84
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/f6208b84
Branch:
Merge branch 'STORM-3082-merge' into asfgit-master
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/2e3f7673
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/2e3f7673
Diff:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2756
Thanks @choojoyq, merged.
---
Merge branch 'STORM-3090' of https://github.com/choojoyq/storm into asfgit-1.1.x
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/824bd481
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/824bd481
Diff:
Repository: storm
Updated Branches:
refs/heads/1.1.x-branch 63aedca3c -> 824bd4816
STORM-3090 - use topic together with partition number during recreation of
partition managers
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit:
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2746#discussion_r201149188
--- Diff:
integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataIncrementingSpout.java
---
@@ -0,0 +1,64 @@
+/*
+ * Copyright
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2756
+1
Yes, likely. There's no reason people can't just upgrade to 1.1.x/1.2.x
instead, and it's adding a bunch of work for us to have to keep backporting to
old branches.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2756#discussion_r200972001
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -80,22 +81,24 @@ public void refresh() {
List mine
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
Oops, yes. Jungtaek is right, I don't think we're working on 1.0.x anymore.
The changes look good to me. +1. I'll try cherry-picking these changes to
master, 1.x and 1.1.x in a bit.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200959509
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java
---
@@ -54,8 +57,12 @@ public NamedTopicFilter(String
501 - 600 of 2639 matches
Mail list logo
